2138db3d7d
Merge pull request #4690 from wwylele/uds-deprecated
...
UDS: implement deprecated functions
2019-03-21 09:52:01 -04:00
aedf5a84b0
Merge pull request #4671 from jroweboy/mic4
...
Microphone support
2019-03-20 23:12:38 +05:30
b4d538468d
Change resampling s16 -> u8 to respect aliasing rules
2019-03-20 09:31:03 -06:00
bf4b0dd1f4
input_common/sdl_impl: Make lambda capture more specific in SDLState constructor
...
We don't need to universally capture by reference. We specifically just
need to capture the this pointer.
2019-03-19 23:55:38 +01:00
ed31197402
input_common/sdl_impl: Remove unnecessary std::chrono::duration construction
...
Specifying the time unit itself is sufficient here.
2019-03-19 23:55:31 +01:00
a5c087f5de
input_common/sdl_impl: Remove unused variable in SDLState constructor
2019-03-19 23:55:23 +01:00
1f233e4365
Merge pull request #4691 from liushuyu/oes_fix
...
video_core: renderer_opengl: gles color fix
2019-03-18 19:01:13 -04:00
322f575ff5
Merge pull request #4697 from xperia64/getopt_fix
...
Fix getopt return type on systems where char is unsigned by default
2019-03-18 10:42:52 -04:00
9739e2b6fd
Support signed 8bit pcm in cubeb input. Address review
2019-03-17 22:52:03 -06:00
dbc3c8e9bb
core/core: Remove the global telemetry accessor function
...
With all usages converted off of it, this function can be removed.
2019-03-17 23:17:57 +01:00
65572a0fb8
yuzu: Remove usage of the global telemetry accessor
...
In these cases the system object is nearby, and in the other, the
long-form of accessing the telemetry instance is already used, so we can
get rid of the use of the global accessor.
2019-03-17 23:17:57 +01:00
d37a2fb9e6
yuzu-cmd/yuzu: Replace direct usage of the global system telemetry accessor in main()
...
We already have the system instance around, so we can use that instead
of the accessor.
2019-03-17 23:17:57 +01:00
6f251a6db2
core/core: Replace direct usage of the global system telemetry accessor from Shutdown()
...
The telemetry instance is actually a member of the class itself, so we
can access it directly instead of going through the global accessor.
2019-03-17 23:17:57 +01:00
592ec9b084
logging/backend: Make time_origin a class variable instead of a local static
...
Moves local global state into the Impl class itself and initializes it
at the creation of the instance instead of in the function.
This makes it nicer for weakly-ordered architectures, given the
CreateEntry() class won't need to have atomic loads executed for each
individual call to the CreateEntry class.
2019-03-17 23:17:57 +01:00
235fc348af
logging/backend: Move CreateEntry into the Impl class
...
This function is only ever used within this source file and makes it
easier to remove static state in the following change.
2019-03-17 23:17:57 +01:00
29c3d72940
Merge pull request #4678 from wwylele/mii-archive
...
archive_ncch: add open source mii archive
2019-03-17 15:54:28 -04:00
c47c24bbd2
common/bit_field: Make BitField trivially copyable
...
This makes the class much more flexible and doesn't make performing
copies with classes that contain a bitfield member a pain.
Given BitField instances are only intended to be used within unions, the
fact the full storage value would be copied isn't a big concern (only
sizeof(union_type) would be copied anyways).
While we're at it, provide defaulted move constructors for consistency.
2019-03-16 04:10:03 +01:00
fa0919915c
Fix GLES version header on picky drivers
2019-03-15 23:32:29 +00:00
224142a57e
Fix getopt on systems where char is unsigned by default
2019-03-15 23:19:24 +00:00
4696b13170
UDS: I was drunk
2019-03-15 00:35:39 -04:00
1fbda5518e
Merge pull request #4684 from liushuyu/fix_freeze
...
frontend: qt: fix a freeze issue
2019-03-14 16:07:54 -04:00
fd7730e7c8
Merge pull request #4575 from BreadFish64/android6
...
android: add logging
2019-03-14 16:00:59 -04:00
71b0eab85c
video_core: renderer_opengl: addressed comments...
...
use indexing to make code more concise; use const bool instead of bool
2019-03-14 10:58:29 -06:00
a986e35795
UDS: Change reply command ID for two versions of ConnectToNetwork
2019-03-14 10:10:18 -04:00
476df9debf
video_core: renderer_opengl: addressed comments...
...
... removed incorrect comments and removed incorrect value calculations
2019-03-13 19:17:29 -06:00
9c016ff3a3
Y2R: pass in MemorySystem from service
2019-03-13 10:23:58 -04:00
d6f3ac1f4e
IR: pass in Core::Timing for ExtraHID
2019-03-13 10:23:58 -04:00
ea496507d5
DSP_DSP: use member system instead of global instance
2019-03-13 10:23:58 -04:00
164eb100eb
video_core: renderer_opengl: addressed comments...
...
... removed redundant comments and removed incorrect value assignments
2019-03-12 22:56:11 -06:00
3983b12086
video_core: renderer_opengl: gles color fix
2019-03-12 22:28:54 -06:00
aaa599a849
UDS: duplicate DecryptBeaconData implementation for deprecated version
...
They are really identical in the NWM module code
2019-03-13 00:21:10 -04:00
16fb6a2c8d
UDS: implement ConnectToNetworkDeprecated and forward params to ConnectToNetwork
2019-03-13 00:03:51 -04:00
fc0fe5c3c0
UDS: devide IPC and impl for ConnectToNetwork
2019-03-13 00:03:51 -04:00
e121c59583
UDS: implement BeginHostingNetworkDeprecated and forward params to BeginHostingNetwork
2019-03-13 00:03:51 -04:00
5353d539ce
UDS: divide IPC and impl for BeginHostingNetwork
2019-03-12 23:00:18 -04:00
1076864935
UDS: implement InitializeDeprecated and forward params to Initialize
2019-03-12 21:53:07 -04:00
021c77bc9f
UDS: divide IPC and impl for InitializeWithVersion
2019-03-12 21:50:14 -04:00
8750b81ce0
ServiceFrameworkBase: remove ownership to ServerPort
...
This causes a reference cycle because ServerPort also holds a shared pointer to SessionRequestHandler (inherited by ServiceFrameworkBase). Given that the member port is never used in ServiceFrameworkBase, we can simply remove it. The port object is kept alive by ServiceManager|KernelSystem::named_ports -> ClientPort -> ServerPort
2019-03-12 19:11:50 -04:00
54d2f16c22
core: reset kernel after service manager in Shutdown
...
Services can hold kernel objects and do cleanup upon destruction, so we need to keep the kernel alive longer. The new order approximnately resembles the reverse construction order. I will revisit the ordering issue and make it less error-prone after global state cleanup
2019-03-12 19:06:20 -04:00
ca46b4c3e2
frontend: qt: fix a freeze where...
...
... if you click on entry in the game list too fast, citra will hang
2019-03-12 13:35:33 -06:00
ff3d7532c9
nfc: Improve implementation of GetAmiiboConfig
...
When making the initial implementation, I forgot to add the series variable to the AmiiboConfig struct.
With this PR it is added and many of the AmiiboConfig fields get their proper values now.
The loading of the Amiibo data that is added here has been hwtested.
This fixes Amiibos in Yoshis Woolly World, Smash (partially) and probably other games too.
2019-03-12 19:08:01 +01:00
36e368ff99
remove Common::TrimSourcePath
...
wwylele / 白疾風Today at 6:14 PM
I doubt the performance of constructing regex everytime the function is called
Is TrimSourcePath only called by logging? if so, you can move the implementation into logging, and cache the regex object into global
This function is probably too specific to be in common anyway
2019-03-10 19:18:09 -05:00
6ce58248b0
APT: use member system instead of global instance
2019-03-10 11:10:24 -04:00
88a011ec8e
GetTextureSurface: return on invalid physical address early
...
Previously this check is in GetSurface (if (addr == 0)). This worked fine because GetTextureSurface directly forwarded the address value to GetSurface. However, now with mipmap support, GetTextureSurface would call GetSurface several times with different address offset, resulting some >0 but still invalid address in case the input is 0. We should error out early on invalid address instead of sending it furthor down which would cause invalid memory access
2019-03-10 11:06:08 -04:00
605dfe80e7
appease clang format
2019-03-09 19:15:35 -06:00
f767b5fdef
android: add logging
2019-03-09 18:23:32 -06:00
9848610ea2
android: init user path
2019-03-09 18:23:27 -06:00
36ae10f555
archive_ncch: add open source mii archive
2019-03-09 08:19:32 -05:00
ebdef4fd69
gl_rasterizer_cache: unlink watchers if surface is moved to remove_surfaces but is not immediately removed
2019-03-08 09:37:25 -05:00
777af04f4a
gl_rasterizer: ignore mipmap setting for cubemap before we implements it
2019-03-08 09:37:25 -05:00
d7196b5573
gl_rasterizer_cache: invalidate watchers on (partial) surface invalidation
2019-03-08 09:37:25 -05:00
fa141c799b
gl_shader_gen: use accurate LOD formula for texture 2D
2019-03-08 09:37:25 -05:00
ca78d34933
gl_rasterizer: implement mipmap
2019-03-08 09:37:24 -05:00
acaca4188e
gdbstub: Fix some bugs in IsMemoryBreak() and ServeBreak. Add workaround to let watchpoints break into GDB. ( #4651 )
...
* gdbstub: fix IsMemoryBreak() returning false while connected to client
As a result, the only existing codepath for a memory watchpoint hit to break into GDB (InterpeterMainLoop, GDB_BP_CHECK, ARMul_State::RecordBreak) is finally taken,
which exposes incorrect logic* in both RecordBreak and ServeBreak.
* a blank BreakpointAddress structure is passed, which sets r15 (PC) to NULL
* gdbstub: DynCom: default-initialize two members/vars used in conditionals
* gdbstub: DynCom: don't record memory watchpoint hits via RecordBreak()
For now, instead check for GDBStub::IsMemoryBreak() in InterpreterMainLoop and ServeBreak.
Fixes PC being set to a stale/unhit breakpoint address (often zero) when a memory watchpoint (rwatch, watch, awatch) is handled in ServeBreak() and generates a GDB trap.
Reasons for removing a call to RecordBreak() for memory watchpoints:
* The``breakpoint_data`` we pass is typed Execute or None. It describes the predicted next code breakpoint hit relative to PC;
* GDBStub::IsMemoryBreak() returns true if a recent Read/Write operation hit a watchpoint. It doesn't specify which in return, nor does it trace it anywhere. Thus, the only data we could give RecordBreak() is a placeholder BreakpointAddress at offset NULL and type Access. I found the idea silly, compared to simply relying on GDBStub::IsMemoryBreak().
There is currently no measure in the code that remembers the addresses (and types) of any watchpoints that were hit by an instruction, in order to send them to GDB as "extended stop information."
I'm considering an implementation for this.
* gdbstub: Change an ASSERT to DEBUG_ASSERT
I have never seen the (Reg[15] == last_bkpt.address) assert fail in practice, even after several weeks of (locally) developping various branches around GDB. Only leave it inside Debug builds.
2019-03-08 00:09:06 -05:00
c3e6610807
Merge pull request #4627 from FearlessTobi/cia-install-short
...
citra_qt: when opening a cia file directly, make Citra ask to install it
2019-03-07 23:55:58 -05:00
9560060f04
Merge pull request #4666 from FearlessTobi/port-2167
...
Port yuzu-emu/yuzu#2167 : "common: Move Quaternion, Rectangle, Vec2, Vec3, and Vec4 into the Common namespace"
2019-03-07 23:52:42 -05:00
f5b86cff52
Clang-format
2019-03-06 22:43:35 -07:00
f5df13eb24
Remove global state and add mic hot swapping
2019-03-06 20:59:58 -07:00
182d672c15
Add ifdef around cubeb for android. Address a few review comments
2019-03-06 20:03:22 -07:00
5c61d53047
Fix compiler error
2019-03-06 11:30:23 -07:00
ba4dfe4217
Increase mic stream volume to max in case the users mic is set low for some reason
2019-03-06 11:17:32 -07:00
5f532c2560
Address review comments
2019-03-06 11:16:43 -07:00
2999c8325e
archive_extsavedata: add correct FileOpen delays
2019-03-06 18:53:44 +01:00
5055a6c262
Address review comments
2019-03-06 18:53:34 +01:00
5954dc11ba
Merge pull request #4669 from wwylele/rpc-server-freeze
...
rpc: send ending packet in Server instead of UDPServer
2019-03-06 09:11:04 -07:00
fc7e6c9cc9
fs_user: Add a delay for each file open
2019-03-06 16:09:24 +01:00
d0de727a97
Merge pull request #4668 from wwylele/swkbd-size
...
applet/swkbd: use UTF-16 string to test string size
2019-03-05 12:23:54 -05:00
3ea30fe2b3
Merge pull request #4610 from zhaowenlan1779/cheats-ui
...
Implement UI for adding/editing/deleting cheats
2019-03-05 22:07:40 +08:00
c669aa8d55
Rest of the owl
2019-03-04 23:07:05 -07:00
5c9e327ff3
Fix
2019-03-04 23:07:05 -07:00
7fccc995ce
Initial Mic setup
2019-03-04 23:06:42 -07:00
b3261472fe
Merge pull request #4665 from FearlessTobi/port-yuzu-stuffz
...
Port various minor PRs from yuzu
2019-03-04 12:36:10 -05:00
9c57b74907
Merge pull request #4618 from wwylele/fs-clean
...
FS: pass down program ID for archive operation (cleanup System::GetInstance part 3)
2019-03-04 12:34:54 -05:00
870579d38f
rpc: send ending packet in Server instead of UDPServer
...
udp_server might not be created due to error (occupied port etc.), in which case its destructor and thread-ending call chain will not be excuted in Server::Stop. However, the ending packet still need to be send no matter udp is on or not, so move it to Server::Stop
2019-03-04 11:05:07 -05:00
47ed3f4db5
applet/swkbd: use UTF-16 string to test string size
...
Also removed a TODO as it is verified that max_text_length is inclusive (allows size = max_text_length)
2019-03-04 10:33:23 -05:00
e1a4912ade
common/math_util: Move contents into the Common namespace
...
These types are within the common library, so they should be within the
Common namespace.
2019-03-02 18:13:10 +01:00
643472e24a
common/vector_math: Move Vec[x] types into the Common namespace
...
These types are within the common library, so they should be using the
Common namespace.
2019-03-02 15:04:13 +01:00
db58652680
common/quaternion: Move Quaternion into the Common namespace
...
Quaternion is within the common library, so it should be using the
Common namespace.
2019-03-02 14:44:09 +01:00
d354a2ee3b
audio_core/codec: Resolve truncation warnings within DecodeADPCM
...
The assignments here were performing an implicit truncation from int to
s16. Make it explicit that this is desired behavior.
2019-03-02 14:06:30 +01:00
f322c51a63
core/frontend/emu_window: Make ClipToTouchScreen a const member function
...
This member function doesn't modify instance state, so it can have the
const specifier applied to it.
2019-03-02 14:06:09 +01:00
6149be43cf
yuzu/compatdb: Remove unused lambda capture
...
Silences a compiler warning with clang.
2019-03-02 14:04:13 +01:00
ad1cfc8d50
Merge pull request #4608 from wwylele/sharedmem-circular
...
Kernel/SharedMemory: make owner_process a raw pointer
2019-02-25 10:32:45 -05:00
93275d752b
Merge pull request #4645 from FearlessTobi/port-2116
...
Port yuzu-emu/yuzu#2116 : "threadsafe_queue: Remove NeedSize template parameter"
2019-02-25 10:25:11 -05:00
206413ba7b
Merge pull request #4630 from wwylele/memory-no-lock
...
Memory: don't lock hle mutex in memory read/write
2019-02-25 10:23:23 -05:00
5f10cc412f
Merge pull request #4632 from zhaowenlan1779/socu
...
service/soc_u: Implement getaddrinfo and getnameinfo
2019-02-25 10:23:13 -05:00
fdb5a8c2df
Merge pull request #4629 from FearlessTobi/bunnei-fooled-me
...
Port minor changes for BitField from yuzu
2019-02-25 10:22:44 -05:00
42c777b0e5
Merge pull request #4617 from wwylele/hle-service-clean
...
HLE/IPC: clean up System::GetInstance
2019-02-25 10:22:13 -05:00
c265f3f507
Merge pull request #4616 from wwylele/core-global-clean
...
Cleanup System::GetInstance reference - Part 1
2019-02-25 10:22:02 -05:00
f8b3617394
bit_field: Remove is_pod check, add is_trivially_copyable_v.
2019-02-24 19:40:20 +01:00
e24c7a474c
bit_field: Make all methods constexpr.
2019-02-24 19:39:15 +01:00
28b2ee9cd7
add java to .clang-format
2019-02-22 16:29:19 -06:00
5f80075c31
Merge pull request #4596 from CarlKenner/master
...
Fix mouse touchscreen in SBS 3D mode
2019-02-22 16:24:22 -05:00
28e849cddb
Merge pull request #4598 from BreadFish64/user_path
...
common: decouple getting and setting user paths
2019-02-22 16:23:41 -05:00
b0a4220711
Merge pull request #4647 from FearlessTobi/fix-weird-bug
...
citra_qt/main: make SPEED_LIMIT_STEP static constexpr
2019-02-22 16:21:54 -05:00
8f2bd97277
Merge pull request #4655 from tgsm/gcc-version
...
Remove GCC version checks
2019-02-22 16:21:21 -05:00
c357531acb
citra_qt/main: make SPEED_LIMIT_STEP static constexpr
...
MSVC does not seem to like using constexpr values in a lambda that were declared outside of it.
Previously on MSVC build the hotkeys to inc-/decrease the speed limit were not working correctly because in the lambda the SPEED_LIMIT_STEP had garbage values.
After googling around a bit I found: https://github.com/codeplaysoftware/computecpp-sdk/issues/95 which seems to be a similar issue.
Trying the suggested fix to make the variable static constexpr also fixes the bug here.
2019-02-20 16:11:38 +01:00
0556cac37d
threadsafe_queue: Use std::size_t for representing size
...
Makes it consistent with the regular standard containers in terms of
size representation. This also gets rid of dependence on our own
type aliases, removing the need for an include.
2019-02-20 16:05:22 +01:00
433ab35e7e
Remove GCC version checks
...
Citra can't be compiled using GCC <7 because of required C++17 support, so these version checks don't need to exist anymore.
2019-02-19 16:39:34 -05:00
f6d0e43c77
Merge pull request #4654 from tgsm/video-nested
...
video_core: use nested namespaces
2019-02-19 21:44:38 +08:00
820e3893de
Merge pull request #4652 from tgsm/audio-nested
...
audio_core: use nested namespaces
2019-02-19 21:39:35 +08:00
d6c530d08c
video_core: use nested namespaces
2019-02-19 03:09:57 -05:00
39e163b7ce
core: use nested namespaces
2019-02-18 20:34:18 -05:00
a400e49338
audio_core: use nested namespaces
2019-02-17 23:41:48 -05:00
f409342ab5
Merge pull request #4613 from BreadFish64/gles5
...
video_core: add GLES support
2019-02-17 15:44:39 -05:00
70653c6a87
citra_qt/config: actually save name of input profile
...
Fixes the issue where all input profiles had the name "default" after restarting Citra.
2019-02-16 21:41:51 +01:00
931895d9b0
citra_qt: when opnening a cia file directly, make Citra ask to install it
2019-02-16 17:18:19 +01:00
3bc78e577f
threadsafe_queue: Remove NeedSize template parameter
...
The necessity of this parameter is dubious at best, and in 2019 probably
offers completely negligible savings as opposed to just leaving this
enabled. This removes it and simplifies the overall interface.
2019-02-15 22:00:44 +01:00
d3d53bae83
common: decouple getting and setting user paths
...
paths -> g_paths
2019-02-15 14:48:31 -06:00
e6feef96c1
Service: clear IPC header for unimplemented function stub
2019-02-14 22:16:50 -05:00
3f86be88f0
HLE/IPC: pass in kernel & memory reference from parent to avoid global state reference
2019-02-14 22:09:25 -05:00
0a424b86d2
ServerSession: replace GetPointer with block copy for HLE translation
...
Do it in the same way as HLERequestContext::SleepClientThread callback and avoid unsafe GetPointer
2019-02-14 22:09:25 -05:00
36c8e1d7a9
HLE/IPC: move command buffer translation into kernel as TODO says
2019-02-14 22:09:25 -05:00
4d10a2d652
tests/audio_core: remove hack for system objects
2019-02-14 14:08:45 -05:00
64f6e5e597
ARM: pass MemorySystem separately in the constructor and make System optional
...
So that unit test can test CPU without constructing the entire system. Also remove hacks in the System class
2019-02-14 14:04:46 -05:00
9573ee46bd
Memory: replace Core::CPU
2019-02-14 14:04:46 -05:00
5f6d9f1915
Kernel/IPC: use MemorySystem from parameter
2019-02-14 14:04:46 -05:00
20f47583f6
Kernel: replace usage of Core::System::GetInstance().PrepareReschedule() with callback
2019-02-14 14:04:46 -05:00
eb050b8403
Kernel: replace usage of Core::System::GetInstance()::Timing()
2019-02-14 14:04:46 -05:00
276ca88c9e
kernel/thread: replace usage of Core::CPU()
2019-02-14 14:04:46 -05:00
b9f6bd9278
ldr_ro: replace usage of Core::CPU()
2019-02-14 14:04:46 -05:00
de1128c60d
Merge pull request #4628 from FearlessTobi/backport-some-stuff
...
Backport various minor frontend review changes from yuzu and port minor PR from yuzu
2019-02-14 11:45:27 -05:00
4b2397aa77
Merge pull request #4633 from BreadFish64/fully-invalid
...
video_core: improve efficiency of CachedSurface::IsSurfaceFullyInvalid
2019-02-14 11:44:46 -05:00
8f2c35d7b6
Merge pull request #4614 from wwylele/nwm-uds-global
...
NWM_UDS: move states into the class
2019-02-14 11:44:28 -05:00
1f38c53d8f
Merge pull request #4508 from B3n30/dsp_aac
...
CoreAudio::HLE: Add FFmpeg/WMF AAC decoder
2019-02-14 11:44:09 -05:00
a4ba35fe3a
audio_core: hle: mf: lint
2019-02-13 15:15:11 -07:00
671ac441e9
audio_core: hle: mf: move transform initializer to ctor
2019-02-13 14:32:14 -07:00
6178cc08b7
audio_core: hle: mf: conform to RAII as possible
2019-02-13 14:08:34 -07:00
fc6e33d812
video_core: Sort predicate order to have semantically positive value first
2019-02-13 21:06:37 +01:00
e5495e541d
citra_qt/config: backport minor changes from yuzu
2019-02-13 21:06:37 +01:00
59dbc72e7b
configure_dialog: backport minor changes from yuzu
2019-02-13 21:06:24 +01:00
d63acfc1e9
video_core: add workarounds to enable GLES support
...
video_core: shorten GetGLSLVersionString
video_core: make GLES version and extensions consistent
video_core: move some logic to LoadShader
video_core: deduplicate fragment shader precision specifier
2019-02-12 16:57:18 -06:00
1995e8ff32
service/soc_u: address review comments
2019-02-10 18:49:18 +08:00
f0e041e27a
audio_core: hle: mf: correctly handle stream change
2019-02-09 16:49:48 -07:00
d90f733330
video_core: improve efficiency of CachedSurface::IsSurfaceFullyInvalid
2019-02-09 17:33:18 -06:00
01e0902fa4
audio_core: hle: mf: fix a memory accessing issue
2019-02-09 13:55:54 -07:00
6281660844
audio_core: hle: mf: address yet another batch of reviews
2019-02-09 13:55:42 -07:00
1f31f23b33
Merge pull request #4631 from tgsm/game-list-demos
...
citra_qt: show demos on game list
2019-02-09 14:15:59 +01:00
08bf899d70
service/soc_u: Implement getaddrinfo and getnameinfo
2019-02-09 20:12:09 +08:00
ab1f47ed15
audio_core: hle: mf: make DetectMediaType return a struct
2019-02-09 11:57:36 +01:00
168f2ee79a
audio_core: mf: make initialize function return smart pointer
2019-02-09 11:57:36 +01:00
c91f5029ff
audio_core: hle: mf: fix a regression...
...
... where the sample copying logic is incorrect due to the wrong usage
of `std::array`
2019-02-09 11:57:36 +01:00
6332e57069
audio_core: hle: mf: return values as std::optional
2019-02-09 11:57:36 +01:00
25fa10327b
audio_core: hle: mf: use object proxy
2019-02-09 11:57:36 +01:00
26b3b41788
audio_core: hle: mf: wrap enum in class
2019-02-09 11:57:36 +01:00
633f02b9b2
audio_core: hle: mf: avoid name conflicts
2019-02-09 11:57:36 +01:00
452ac7b874
audio_core: hle: mf: use more enum
2019-02-09 11:57:36 +01:00
be764e4f88
audio_core: hle: mf: multiple fixes...
...
... more smart pointers and re-arrange code
2019-02-09 11:57:36 +01:00
4bc6bfd51f
audio_core: hle: mf: re-arrange comments
2019-02-09 11:57:36 +01:00
972b527374
audio_core: hle: mf: cleanup headers
2019-02-09 11:57:36 +01:00
2c40ef2a90
audio_core: hle: mf: rename functions
2019-02-09 11:57:36 +01:00
ea8a1f8754
Media Foundation Memory Fix
...
* audio_core: hle: mf: more smart pointers
* audio_core: hle: mf: fix memory leaks
* audio_core: hle: mf: even more smart pointers
2019-02-09 11:57:36 +01:00
10f876653d
audio_core: hle: mf: transition to use smart pointers
2019-02-09 11:56:51 +01:00
bee5ba3e33
audio_core: hle: mf: fix a regression...
...
... an introduction in 8f591d3b85714383196fd21e744a7eed5302ff0a
2019-02-09 11:56:51 +01:00
06316be8a7
audio_core: hle: mf: minor fix
2019-02-09 11:56:51 +01:00
c03861c2d9
audio_core: hle: mf: address another batch of reviews from @B3N30
2019-02-09 11:56:51 +01:00
7f5b54fda4
audio_core: hle: mf: address reviews from @B3N30
2019-02-09 11:56:51 +01:00
11e277149c
audio_core: hle: fix compile
2019-02-09 11:56:51 +01:00
80b4dd21d2
audio_core: dsp_hle: add Media Foundation decoder...
...
* appveyor: switch to Media Foundation API
* Travis CI MinGW build needs an update with the container image
2019-02-09 11:56:51 +01:00
1581dea6de
more reviews addressed
2019-02-09 11:55:12 +01:00
8fe3e37df5
audio_core: fix msvc include issue
2019-02-09 11:55:12 +01:00
bd9984b5f8
Addressed reviews
2019-02-09 11:55:12 +01:00
847003cc1c
FFmpegDL: Added external_dlls folder to user folder
...
AACDecoder: addressed reviews
2019-02-09 11:52:31 +01:00
45b5de7a18
Fixup: Merge conflict with dsp lle
2019-02-09 11:52:31 +01:00
c521f3b7d6
CoreAudio::HLE: Add FFmpeg aac decoder
2019-02-09 11:52:31 +01:00
ee0afb4318
citra_qt: show demos on game list
2019-02-08 19:04:05 -05:00
bf1dbb47dc
Merge pull request #4619 from wwylele/shadow-explosion
...
gl_rasterizer: change shadow_texture_bias from shader config to shader uniform
2019-02-08 18:38:40 -05:00
687fa0134d
Merge pull request #4609 from wwylele/nuke-zmq
...
Reimplement scripting over plain UDP
2019-02-08 18:38:21 -05:00
7074dab2da
Memory: don't lock hle mutex in memory read/write
...
The comment already invalidates itself: neither MMIO nor rasterizer cache belongsHLE kernel state. This mutex has a too large scope if MMIO or cache is included, which is prone to dead lock when multiple thread acquires these resource at the same time. If necessary, each MMIO component or rasterizer should have their own lock.
2019-02-08 10:43:06 -05:00
6be1b4d293
renderer_base: backport minor changes from yuzu
2019-02-06 17:16:27 +01:00
f620c862f3
Merge pull request #4437 from adityaruplaha/hotkey-config-squashed
...
citra-qt: Make hotkeys configurable via the GUI (Attempt 2)
2019-02-03 21:57:34 -05:00
cd21abe50f
sdl: add GLES support
2019-02-03 15:58:09 -06:00
a6d9baa05a
FS: pass down program ID for archive operation
...
To eliminate System::GetInstance usage. Archive type like SelfNCCH and SaveData changes the actual reference path for different client, so archive backend interface should accept client information from the service interface. Currently we only pass the program ID as the client information.
2019-02-02 20:44:13 -05:00
b5f2318ae7
gl_rasterizer: change shadow_texture_bias from shader config var to shader uniform
...
Games can frequently change this register. Using it as shader config var would generates a lot of shaders
2019-02-02 20:40:08 -05:00
008197a569
Remove scripting switch in cmake
2019-02-02 15:25:23 -05:00
6347b5cbb4
Remove libzmq submodule
2019-02-02 15:25:23 -05:00
d765a73a53
Scripting: reimplement protocol over plan UDP using boost::asio
2019-02-02 15:25:23 -05:00
433176a9b9
citra_qt: Implement UI for adding/editing/deleting cheats
...
The UI file is rewritten, to better make use of Qt's layouts (instead of depending on abstract geometry). "Add Cheat", "Save", "Delete" buttons are also added.
The UI logic should be rather easy and usable (IMO), but the code may seem a bit dirty. If anyone has a better idea regarding UI logic design or code implementation, feel free to tell me about it.
2019-02-02 08:15:27 +08:00
573036b38e
core/cheats: Add and change a few functions
...
Added a few interfaces for adding/deleting/replacing/saving cheats. The cheats list is guarded by a std::shared_mutex, and would only need a exclusive lock when it's being updated.
I marked the `Execute` function as `const` to avoid accidentally changing the internal state of the cheat on execution, so that execution can be considered a "read" operation which only needs a shared lock.
Whether a cheat is enabled or not is now saved by a special comment line `*citra_enabled`.
2019-02-02 08:15:23 +08:00
2731437a17
Merge pull request #4583 from xperia64/screenshot_fix
...
citra_qt: Fix saving screenshot when no file extension is provided
2019-02-01 10:49:28 -05:00
ae57d72b33
Merge pull request #4603 from DimitriPilot3/gdbstub-watchpoint-fix1
...
gdbstub: only let Execute breakpoints write/restore BKPT opcodes into memory
2019-02-01 10:49:09 -05:00
f78512d6de
Merge pull request #4599 from wwylele/bitfield-endian
...
Common: make BitField endianness-aware
2019-02-01 10:48:56 -05:00
6382d9bfc3
NWM_UDS: move states into the class
2019-01-31 15:42:45 -05:00
3a7a686fa9
Kernel/SharedMemory: make owner_process a raw pointer
...
To break a circular reference formed by process->handle_table->shared_memory->process. Since SharedMemory uses its owner process in the destructor, which is not kept alive by SharedMemory any more, we need to make sure that the lifetime of process is longer than the shared memory. To partially resolve this, Process now explicitly releases shared memory first in its destructor. This is with the assumtion that there is no inter-process reference to shared memory on exit, which is not true when we introduce more multi-process emulation. A TODO is left there for this, as more RE needs to be done on how 3DS handles this situation
2019-01-29 11:18:51 -05:00
104829ae58
remove all occurance of specifying endianness inside BitField
...
This commit it automatically generated by command in zsh:
sed -i -- 's/BitField<\(.*\)_le>/BitField<\1>/g' **/*(D.)
BitField is now aware to endianness and default to little endian. It expects a value representation type without storage specification for its template parameter.
2019-01-28 22:09:43 -05:00
055b9513a3
common/bitfield: make it endianness-aware
2019-01-28 22:09:43 -05:00
fa9d6b79f9
common/swap: remove default value for swap type internal storage
...
This is compromise for swap type being used in union. A union has deleted default constructor if it has at least one variant member with non-trivial default constructor, and no variant member of T has a default member initializer. In the use case of Bitfield, all variant members will be the swap type on endianness mismatch, which would all have non-trivial default constructor if default value is specified, and non of them can have member initializer
2019-01-28 22:09:43 -05:00
985cd878e6
common/swap: use template and tag for LE/BE specification
...
The tag can be useful for other type-generic templates like BitFields to forward the endianness specification
2019-01-28 22:09:43 -05:00
602334cb1e
Fix mouse touchscreen in SBS 3D mode.
...
You can now click or drag on either eye's touchscreen.
2019-01-27 16:25:42 +10:30
d388fe58f7
gdbstub: only let Execute breakpoints write/restore BKPT opcodes into target memory
2019-01-26 22:08:39 +01:00
24f966481f
dsp_interface: fix sound being played while volume is 0
...
According to documentation, if the argument of std::exp is zero, one is returned.
However we want the return value to be also zero in this case so no audio is played.
2019-01-26 14:53:58 +01:00
80ebd75285
citra-qt: Add /default parsing for hotkeys. Also minor code cleanups.
2019-01-25 20:42:49 +05:30
8b047a49ae
Merge pull request #4586 from xperia64/qt_color_button_fix
...
citra_qt: Use QPixmap/QIcon for background color selection button
2019-01-23 20:24:57 -05:00
054a97c08b
Merge pull request #4579 from xperia64/3d_slider
...
Change 3D Slider in-game
2019-01-23 20:23:55 -05:00
306ce6416a
vfp_helper: Remove accidental use of the comma operator in vfp_single_unpack()
...
Makes the line of code slightly easier to read properly.
2019-01-22 18:30:34 -05:00
c1a066fa89
yuzu/configuration/configure_web: Remove an unused lambda capture
...
'this' isn't actually used within the lambda, since what we need
from the class is already assigned within the capture section of
the lambda.
2019-01-21 22:11:02 +01:00
b16445064b
yuzu/configuration/configure_web: Use an ellipsis with 'Verifying' text
...
It's a common UI pattern to use an ellipsis to indicate an ongoing
action, rather than just specifying the word by itself.
2019-01-21 22:10:56 +01:00
efd5768398
Merge pull request #4457 from FearlessTobi/remove-vsync
...
citra_qt: Remove V-Sync option
2019-01-21 15:56:12 -05:00
ce26de858a
Use QPixmap/QIcon for background color selection button
2019-01-20 22:09:23 -05:00
71f36efd27
citra-qt: Use structured bindings where applicable in `ConfigureHotkeys::applyConfiguration`. Fix a few minor issues.
...
* Address https://github.com/citra-emu/citra/pull/4437#discussion_r241380912
2019-01-20 16:14:07 +05:30
dccd1664ad
citra-qt/configuration: Fix a weird issue where the tab UI disappears when language is changed.
2019-01-20 16:14:03 +05:30
988acf588a
citra-qt: Add back missing hotkeys & conflict fixes.
...
* Also fixed a missing spacer in ConfigureGeneral.
2019-01-20 16:13:59 +05:30
4309585623
citra-qt: Commented & documented code related to hotkeys as & when required.
2019-01-20 16:13:54 +05:30
9615acb550
citra-qt: Fixed reloading hotkeys on-the fly.
2019-01-20 16:13:49 +05:30
5fa25fcf13
citra-qt: Add base support for hotkey reconfiguration + UI (whole of PR citra-emu/citra#3786 )
...
* Adds a new Hotkeys tab in the Controls group.
* Right click to reconfigure.
* See the original PR for more details & screenshots.
2019-01-20 16:12:10 +05:30
c6d623f4ba
Fix crash when no files are selected
2019-01-19 22:14:19 -05:00
82acde7e4b
Add file extension to screenshot filename if not provided
2019-01-19 22:10:30 -05:00
5df6506e81
game_list: Remove a reference of a reference
2019-01-19 21:30:32 +01:00
6560fac5ff
audio_core: remove unnecessary spaces on comments
2019-01-19 21:28:52 +01:00
1302c9c1e7
frontend: Remove V-Sync option from UI
...
The V-Sync option is fundamentally broken in Citra, so let's do the same as yuzu and remove it entirely for SDL2 and at least from the frontend for QT.
(It was also only used by 7.3% of users)
2019-01-19 17:43:44 +01:00
c1ac39f058
Actually fix the race condition
2019-01-18 16:32:16 -05:00
5f5646c850
Fix types
2019-01-18 15:24:39 -05:00
6f2eb2a418
Do 3D slider updating in the HID module
2019-01-17 23:48:50 -05:00
81f4cef201
Revert "Change 3D slider in-game"
...
This reverts commit bb9a972e35
2019-01-17 23:33:24 -05:00
95a57a2fe3
Merge pull request #4538 from valentinvanelslande/profiles
...
Add multiple input profile support
2019-01-17 22:32:24 -05:00
bb9a972e35
Change 3D slider in-game
2019-01-17 22:18:15 -05:00
3523831195
Frontend: Only reload icons in chat when the chat room is open
2019-01-17 12:25:17 -07:00
f110cd95a6
Merge pull request #4569 from zhaowenlan1779/multiplayer-fix
...
multiplayer: minor UI fixes
2019-01-17 09:37:18 -07:00
2d65371c20
citra_qt/multiplayer: Update themed icon on theme change
2019-01-16 22:01:21 +08:00
ac3b514875
android: fix native library inclusion
2019-01-15 20:28:56 -06:00
7b1cfff825
android: use better icons
...
vector assets are available
unfortunately android studio mutilates citra's vector icon
2019-01-15 20:28:29 -06:00
d4646938e9
android: move cmakelist
2019-01-15 19:24:03 -06:00
5f0dcd52ae
multiplayer: minor UI fixes
...
Just two minor fixes:
1. Font color is black in dark theme. It is now only black for pings.
2. If a user is called `abc`, you can ping them by `@abc_`. Now a ping only takes effect when there are spaces around it.
2019-01-13 22:21:04 +08:00
4f23d5d69e
Merge pull request #4490 from wwylele/teakra-new
...
audio: implement DSP LLE
2019-01-11 16:45:00 +01:00
62b40e9155
Merge branch 'master' into profiles
2019-01-07 10:39:44 -05:00
941d241e7d
Merge pull request #4537 from RicBent/master
...
Added Debug/GPIO14 Buttons
2019-01-07 10:07:31 -05:00
895936360b
network: remove cpp-jwt library dependency
...
This is not used anywhere in in the module
2018-12-31 23:23:09 -05:00
df02ea48d2
minor ui changes
2018-12-29 19:28:56 -05:00
64b992487e
fix regression
2018-12-29 16:23:33 -05:00
dce82fa005
move comment
2018-12-29 13:15:31 -05:00
57f224fc50
fix clang-format
2018-12-29 09:31:03 -05:00
707bc48440
Added new buttons to movie system
2018-12-29 08:19:59 -06:00
3d00beb9d5
add a comment, rename old index
2018-12-29 09:19:45 -05:00
e7b1a1d5c8
fix clang-format
2018-12-29 09:04:43 -05:00
60d1822206
if to clamp
2018-12-29 08:39:30 -05:00
5a14af5f38
address some comments
2018-12-29 08:27:06 -05:00
5a4c7c32d8
Update src/citra_qt/configuration/config.cpp
...
Co-Authored-By: valentinvanelslande <valentinvanelslandeacnl@gmail.com>
2018-12-29 08:14:37 -05:00
ec7a3fb72c
Update src/core/settings.h
...
Co-Authored-By: valentinvanelslande <valentinvanelslandeacnl@gmail.com>
2018-12-28 23:33:40 -05:00
8e614c3eb0
clang-format; address one comment
2018-12-28 23:31:55 -05:00
fbd0944a5a
Merge pull request #4512 from FearlessTobi/port-1902
...
Port yuzu-emu/yuzu#1902 : "audio_core: Make g_sink_details internally linked"
2018-12-28 22:55:08 -05:00
860860397b
more fixes
2018-12-28 21:26:50 -05:00
39140bbff8
another fix
2018-12-28 21:24:01 -05:00
16ebb38b4a
more fixes
2018-12-28 21:23:43 -05:00
e420fb666f
another fix
2018-12-28 21:15:18 -05:00
6d0c50dfec
more fixes
2018-12-28 21:14:44 -05:00
bf93b94658
fixes
2018-12-28 21:13:57 -05:00
90965525ac
Apply suggestions from code review
...
Co-Authored-By: valentinvanelslande <valentinvanelslandeacnl@gmail.com>
2018-12-28 21:00:09 -05:00
7c95032e3a
Add multiple input profile support
...
Only supported in the Qt frontend.
2018-12-28 20:28:45 -05:00
6ad609a539
Added GPIO14 button and UI config buttons
2018-12-28 17:13:37 -06:00
7c007eac24
Fixed coding style
2018-12-28 15:13:16 -06:00
446b614409
Removed unnecessary debug key abbreviations
2018-12-28 13:33:54 -06:00
403d2f0058
Added Debug Button
2018-12-28 12:47:50 -06:00
3989c17cb0
Merge pull request #4531 from lioncash/mem
...
core/memory: Remove unnecessary memory zeroing in MemorySystem::Impl
2018-12-27 22:29:20 +08:00
432e847c24
core/memory: Remove unnecessary memory zeroing in MemorySystem::Impl
...
std::make_unique for arrays is equivalent to doing:
std::unique_ptr<T>(new typename std::remove_extent<T>::type[size]())
(note the ending () after the array size specifier). This means that the
default value within memory for the constructed types will be whatever
the default constructor for that type does. Given the built-in
type for std::uint8_t doesn't have a constructor, this is equivalent to
forcing zero-initialization, so the memory will already be zeroed out on
construction. Because of that, there's no need to zero it out again.
2018-12-27 00:35:53 -05:00
d2aac218a6
renderer_opengl: Correct forward declaration of FramebufferLayout
...
This is actually a struct, not a class, which can lead to compilation
warnings.
2018-12-27 02:48:05 +01:00
3ede436053
Merge pull request #4489 from FearlessTobi/port-ui-stuff
...
Port QT interface changes from yuzu.
2018-12-21 20:52:14 -05:00
443f4b964d
DSP/LLE: add multithread mode
2018-12-21 20:49:24 -05:00
fbad420240
Common/Barrier: add method to get current generation
2018-12-21 20:49:24 -05:00
969dc3b46f
Update teakra and address more comments
2018-12-21 20:49:23 -05:00
05c372bf6c
Update teakra to fix macos issue; address comment feedbacks
2018-12-21 20:49:23 -05:00
67213ca855
audio_core/lle: link ahbm and audio callback
2018-12-21 20:49:22 -05:00
21da135cc6
Configuration: add option to use DSP LLE
2018-12-21 20:49:22 -05:00
483680a124
audio_core/lle: only process pipe signal after loading
2018-12-21 20:49:22 -05:00
92e5c51adb
Service/DSP: implement semaphore event
2018-12-21 20:49:22 -05:00
6f6ffceec4
audio_core/hle,lle: implement UnloadComponent
2018-12-21 20:49:21 -05:00
9b41e6f85f
audio_core/lle: implement LoadComponent
2018-12-21 20:49:21 -05:00
4add509b20
audio_core/hle: move implementation of LoadComponent
2018-12-21 20:49:21 -05:00
9ab4e3c686
audio_core/lle: implement GetDspMemory and SetServiceToInterrupt
2018-12-21 20:49:21 -05:00
df8aaee965
DSP_DSP: avoid global in ReadPipe
2018-12-21 20:49:20 -05:00
5c13eca700
audio_core/lle: implement PipeRead/GetPipeReadableSize
2018-12-21 20:49:20 -05:00
daf23eca2e
DSP_DSP: avoid global in WriteProcessPipe
2018-12-21 20:49:20 -05:00
e40efbf37b
audio_core/lle: implement PipeWrite
2018-12-21 20:49:20 -05:00
c9736b3300
audio_core/hle,lle: implement SetSemaphore
2018-12-21 20:49:20 -05:00
4671ccf416
audio_core/lle: implement RecvDataIsReady
2018-12-21 20:49:19 -05:00
14eb3561de
audio_core/hle: move implementation of RecvDataIsReady
2018-12-21 20:49:19 -05:00
b609753fb6
audio_core/lle: implement RecvData
2018-12-21 20:49:19 -05:00
7f568a3c19
DSP/HLE: move implementation of RecvData to audio_core, behind common interface
2018-12-21 20:49:19 -05:00
6d51d95d44
audio_core: add teakra and lle interface
2018-12-21 20:49:18 -05:00
eabc9727d8
Merge pull request #4468 from citra-emu/multiplayer-v4/main
...
Multiplayer version 4
2018-12-22 09:45:28 +08:00
83e3e30d0e
Merge pull request #4496 from wwylele/smd-fix
...
gl_rasterizer_cache/MortonCopy: avoid read/write to invalid address
2018-12-19 19:46:10 -05:00
5c75974909
Merge pull request #4500 from wwylele/sync-cache
...
Memory: sync rasterizer cache mark to fix LLE applet crash
2018-12-19 19:45:48 -05:00
7a379ee03a
citra_qt/multiplayer: Add `View Profile` option
...
Adds an UI action to navigate to the user's profile located in Citra Community.
2018-12-18 22:07:42 +08:00
29548bbe86
Merge pull request #4511 from FearlessTobi/port-1871
...
Port yuzu-emu/yuzu#1871 : "yuzu/wait_tree: Pass QString by value and std::move in the initializer list for WaitTreeText"
2018-12-17 00:02:42 -05:00
4df4b90795
citra_qt/multiplayer: Change style for pinged messages a bit
...
To allow it to be seen more clearly in dark themes
2018-12-16 23:08:47 +08:00
66a4f8a9d0
(QLabel)_is_already_in_use-Correct_Auto_Default
2018-12-16 11:16:05 +00:00
4574bd1e5c
web_service: Change endpoint to `/lobby`.
...
Preparation for shipping.
2018-12-16 10:48:42 +08:00
90082268dc
audio_core: Make g_sink_details internally linked
...
We can hide the direct array from external view and instead provide
functions to retrieve the necessary info. This has the benefit of
completely hiding the makeup of the SinkDetails structure from the rest
of the code.
Given that this makes the array hidden, we can also make the array
constexpr by altering the members slightly. This gets rid of several
static constructor calls related to std::vector and std::function.
Now we don't have heap allocations here that need to occur before the
program can even enter main(). It also has the benefit of saving a
little bit of heap space, but this doesn't matter too much, since the
savings in that regard are pretty tiny.
2018-12-16 02:44:04 +01:00
c2790a3f86
yuzu/wait_tree: Pass QString by value and std::move in the initializer list for WaitTreeText
...
Just a trivial modernization that potentially avoids copying strings in certain scenarios.
2018-12-16 01:18:06 +01:00
13ec2abbf6
network: Make citra mods optional and disabled by default
...
To avoid extra legal responsibility, this should actually only be used on our self-hosted rooms.
2018-12-15 22:47:07 +08:00
9d062d63da
network, citra_qt: Give moderation permission to community mods
...
Based on the `roles` payload in the JWT, the rooms will now give mod permission to Citra Community Moderators. To notify the client of its permissions, a new response, IdJoinSuccessAsMod is added, and there's now a new RoomMember::State called Moderator.
2018-12-15 20:28:03 +08:00
94be4050bc
network/packet: Fix reading vectors/arrays of strings
...
Previously would break here, as it is trying to initialize a string with 0, which is then considered NULL.
2018-12-15 14:37:23 +08:00
8b8b39ec0e
citra_qt/multiplayer: Add user ping support
...
The user would be notified if the message contains "@" followed by the user's nickname or forum username. An alert would be shown, and the icon and message in the status bar would be changed. All notification is only shown if the chat window currently does not have focus.
Also added a connected_notification icon for showing in the status bar.
2018-12-15 11:03:35 +08:00
6feeaed77e
citra: add errors callback and add status message types
2018-12-15 11:03:35 +08:00
bd29f1facb
dedicated_room: load and save ban list
...
The ban list is stored in a format so-called CitraRoom-BanList-1 and just first stores username ban list, one entry per line, then an empty line and then store the ip ban list.
2018-12-15 11:03:34 +08:00
deb398d190
citra_qt: Save ban list for room hosting
2018-12-15 11:03:33 +08:00
15540df140
citra_qt/multiplayer/chat_room: Add moderation to context menu
2018-12-15 11:03:33 +08:00
6359b6094c
citra_qt: Add a moderation dialog
...
The dialog currently supports accessing the ban list and removing entries from it.
2018-12-15 11:03:32 +08:00
7acd2664dd
network/room_member: Add moderation functions
...
To allow for passing moderation errors around without impacting the State, this commit also separates the previous State enum into two enums: State, and Error. The State enum now only contains generic states like disconnected or connected, and the Error enum describes the specific error happened.
citra_qt/multiplayer/{state, message} is changed accordingly.
2018-12-15 11:03:31 +08:00
38f86cce94
network/room: Moderation implementation
...
Currently consist of 4 moderation commands (kick, ban, unban and get ban list).
2018-12-15 11:03:28 +08:00
6c29d441f4
multiplayer: fix "Connected" message not appearing on first connection
2018-12-15 11:03:10 +08:00
0823d8e009
citra: add status messages and fix missing errors
2018-12-15 11:03:09 +08:00
Weiyi Wang
Vamsi Krishna
James Rowe
Lioncash
xperia64
liushuyu
fearlessTobi
BreadFish64
Dimitri A
bunnei
Pengfei Zhu
tgsm
ReinUsesLisp
SachinVin
B3N30
Carl Kenner
Dimitri ALBORA
Adityarup Laha
Frederic Laing
Otávio Pace
Ben
Valentin Vanelslande
RicBent
danman447