6b1ec838aa
vector_math: Convert typedefs to type aliases
2018-08-24 18:37:18 +02:00
bf964ac6e9
common: Convert type traits templates over to variable template versions where applicable
...
Uses the C++17 inline variable variants
2018-08-24 18:22:42 +02:00
a74ba1cd59
file_util: Remove compiler version checks around is_trivially_copyable()
...
The minimum clang/GCC versions we support already support this. We can also
remove is_standard_layout(), as fread and fwrite only require the type to be
trivially copyable.
2018-08-24 18:18:11 +02:00
c8b1edac63
Port #943 from yuzu: "game_list: Join declarations and assignments in onTextChanged()"
2018-08-24 17:28:00 +02:00
1f0cbf43d6
Port #942 from yuzu: "qt: Minor cleanup-related changes"
2018-08-24 17:14:09 +02:00
79434d3d4c
citra-qt: Use Qt 5 signal/slots where applicable
...
Makes the signal/slot connections type-safe instead of string-based.
2018-08-23 18:34:25 +02:00
2abe11ee1e
Fix compile errors
2018-08-23 18:23:21 +02:00
c786df3e4b
kernel/process: Use std::array where applicable
2018-08-23 18:08:20 +02:00
37e78de206
kernel/process: Use accessors instead of class members for referencing segment array
...
Using member variables for referencing the segments array increases the
size of the class in memory for little benefit. The same behavior can be
achieved through the use of accessors that just return the relevant
segment.
2018-08-23 18:08:03 +02:00
469ed4a09f
kernel/vm_manager: Convert loop into std::any_of()
2018-08-23 17:53:37 +02:00
c7e1dab45b
kernel/vm_manager: Use const where applicable
...
Makes our immutable state explicit.
2018-08-23 17:53:20 +02:00
bb88c3b7b5
kernel/vm_manager: Use the VAddr type alias in CarveVMA()
...
These two variables correspond to address ranges.
2018-08-23 17:39:18 +02:00
63c7b44ba8
kernel: Move object class to its own source files
...
General moving to keep kernel object types separate from the direct
kernel code. Also essentially a preliminary cleanup before eliminating
global kernel state in the kernel code.
2018-08-23 17:31:59 +02:00
29e5dec986
sink_details: Deduplicate long std::function repetition
...
We can just use type aliases to avoid needing to write the same long
type twice
2018-08-23 17:03:09 +02:00
50b58da56c
sink_details: std::move std::function instances
...
Given std::function is allowed to potentially allocate, these should be
std::move'd to prevent potential reallocation (should that ever happen).
2018-08-23 17:03:00 +02:00
d944d1120f
video_core: Remove unimplemented Start() function prototype
...
Given this has no definition, we can just remove it entirely.
2018-08-23 16:58:30 +02:00
7d8569d799
fix soc service - Fcntl failed on validate header
2018-08-21 12:14:18 +07:00
b3ca900ba7
Revert "Set DiscordRPC OFF by default ( #4109 )"
...
This reverts commit 516be14a6b
2018-08-20 10:34:58 -06:00
516be14a6b
Set DiscordRPC OFF by default ( #4109 )
2018-08-20 16:19:12 +02:00
9d056282df
citra_qt: record movie record/playback path
2018-08-20 11:36:00 +02:00
3b459f6eb3
citra_qt, movie: allow recording/playback before emulation starts
2018-08-20 11:34:27 +02:00
a9ad8daf47
citra_qt: Add movie frontend
2018-08-20 11:34:26 +02:00
0f44f7b481
core/movie: Movie refactor, add a completion callback
2018-08-20 11:27:25 +02:00
6cb9a45154
Add Discord Rich Presence Support ( #3883 )
...
* Initial Discord RPC support
Build with Discord Presence ON
Fix RPC detection
Fix Time elapsed on pause; will now continue to count.
* Fix CI builds with compile flag
Addressed reviews
Fix silly mistakes
Fix 'Not in-game' display
class instead of namespace
Fix
Revamped
remove redundant code
Using Pimpl pattern
* Implement Null class
* Fix config updation
* Addressed All Reviews
* externals/discord-rpc : Updated to latest commit
2018-08-20 11:20:33 +02:00
b19e88a9f4
Small fixup
2018-08-19 16:46:10 +02:00
4cd737abae
Address zhaowenlans feedback
2018-08-19 15:53:46 +02:00
d1c5f01afe
Add more verbose popups for video_core errors
2018-08-19 15:48:40 +02:00
039fb95f80
More fixes as per PR feedback.
2018-08-16 19:44:31 +01:00
a6ecb3c913
Fixed as per PR feedback.
2018-08-16 16:24:16 +01:00
bd658a8801
GDB Modernization:
...
- Can be used in either DynCom or Dynarmic mode
- Added support for threads
- Proper support for FPU registers
- Fix for NibbleToHex conversion that used to produce false error codes
- Fix for clang-format failing under Windows
2018-08-16 10:40:52 +01:00
5c5aad09ce
qt_themes: add two colorful themes ( #4004 )
...
* qt_themes: add two colorful themes
These two colorful themes are based on the Default and Dark themes, and contain icons that are colored rather than black and white. These icons come from https://icons8.com and they have been slightly revised by me. I'm pretty sure I was licensed to use them for Citra.
* Add license for icons
2018-08-16 10:39:23 +02:00
20cb8f66db
Merge pull request #4099 from zhaowenlan1779/lle-service-modules-fixup
...
citra_qt: set object name for LLEServiceModulesWidget
2018-08-14 10:48:03 -06:00
e837717592
citra_qt: set object name for LLEServiceModulesWidget
...
Gets rid of a qt error that occurs when Citra is closed.
2018-08-14 20:28:47 +08:00
aed15a8d9d
Merge pull request #4012 from zhaowenlan1779/ui-retext
...
citra_qt: UI text improvements
2018-08-13 23:31:39 -06:00
8cbb60c281
Change level of invalid UDP packet log message from Error to Debug.
2018-08-12 22:17:34 -04:00
2c31bd1a52
network: fix 3 typos
2018-08-12 17:55:15 -05:00
1b1439c6af
NWM_UDS: use sizeof(<var being used>) instead of hard-coded type ( #4093 )
...
* NWM_UDS: use sizeof(<var being used>) instead of hard-coded type
Intend to fix #4090 .
` node_map.node.second` type was changed to `u16` in #3985 . However the type change wasn't reflected here. Should have used variable name instead to automatically do type change
* NWM_UDS: ... and also the node.first one
* NWM_UDS: ... and here
* Network: bump version because we changed UDS packet layout
* Update nwm_uds.cpp
2018-08-12 22:47:48 +02:00
c18a7896e0
Merge pull request #4078 from zhaowenlan1779/port-yuzu-934
...
Port " core_timing: Make GetGlobalTimeUs() return std::chrono::microseconds" from yuzu
2018-08-11 10:26:21 +01:00
8db6822ee9
citra_qt: add motion/touch config
2018-08-11 14:16:44 +08:00
8af89b6979
input_common, common: Add a few functions
...
These functions include reloading udp client, testing communication and configuring calibration. I also added a function to common/thread.h to use WaitFor.
2018-08-11 14:09:35 +08:00
e1ae14d508
input_common/udp: allow changing pad index
2018-08-11 13:23:10 +08:00
d1c364bb85
Merge pull request #4073 from zhaowenlan1779/port-yuzu-988
...
Port "common/color: Minor cleanup" from yuzu
2018-08-10 21:18:01 +01:00
c0346718fd
Merge pull request #4076 from zhaowenlan1779/port-yuzu-945
...
qt/main: Better file-existence checking within OnMenuRecentFile() and UpdateUITheme()
2018-08-10 21:17:32 +01:00
4aec7ec96b
Merge pull request #4079 from zhaowenlan1779/port-yuzu-932
...
Port "core_timing: Use transparent functors where applicable" from yuzu
2018-08-10 21:15:00 +01:00
0b798ab7a2
Merge pull request #4081 from zhaowenlan1779/port-yuzu-900
...
Port "math_util: Always initialize members of Rectangle" from yuzu
2018-08-10 21:09:02 +01:00
f201484c63
Merge pull request #4082 from zhaowenlan1779/port-yuzu-906
...
Port "input_common: minor changes" from yuzu
2018-08-10 21:08:49 +01:00
44fc338f21
Merge pull request #4083 from zhaowenlan1779/port-yuzu-904
...
Port "kernel/thread: Minor changes" from yuzu
2018-08-10 21:08:22 +01:00
39d5ada4e1
kernel/thread: Remove unimplemented function prototype
...
Given there's no implementation, we may as well remove the code
entirely.
2018-08-10 17:05:01 +08:00
596caf70b7
kernel/thread: Make GetFreeThreadLocalSlot()'s loop indices size_t
...
Avoids using a u32 to compare against a range of size_t, which can be a
source of warnings. While we're at it, compress a std::tie into a
structured binding.
2018-08-10 10:13:50 +08:00
893d9c5ff3
kernel/thread: Make GetFreeThreadLocalSlot() reference parameter a const reference
...
This function only reads the data being referenced, it doesn't modify
it, so we can turn the reference into a const reference.
2018-08-10 10:13:49 +08:00
c71c9e63ec
kernel/thread: Make GetFreeThreadLocalSlot() internally linked
...
This function isn't used outside of this translation unit, so we can
make it internally linked.
2018-08-10 10:13:48 +08:00
384c9e5382
input_common: Use std::move where applicable
...
Avoids unnecessary atomic reference count increments and decrements
2018-08-10 10:12:30 +08:00
8ce104f0a0
input_common: Add missing override specifiers
2018-08-10 10:12:29 +08:00
23e8dd66c4
math_util: Always initialize members of Rectangle
...
Prevents potentially using the members uninitialized.
2018-08-10 10:11:25 +08:00
a431c85b6b
core_timing: Convert typedef into a type alias
...
Makes the alias a little more readable from left-to-right.
2018-08-10 10:00:36 +08:00
196ab8be89
core_timing: Use transparent functors where applicable
...
Gets rid of the need to hardcode the type in multiple places. This will
now be deduced automatically, based off the elements in the container
being provided to the algorithm.
2018-08-10 09:59:17 +08:00
660be9499d
core_timing: Make GetGlobalTimeUs() return std::chrono::microseconds
...
Enforces the time unit being returned and also allows using the standard
time utilities to manipulate it.
2018-08-10 09:56:17 +08:00
265e875e5b
qt/main: Better file-existence checking within OnMenuRecentFile() and UpdateUITheme()
2018-08-10 09:45:48 +08:00
319d685b13
common/color: Remove unnecessary const qualifiers on return types
...
These are just superfluous and not necessesary
2018-08-10 09:35:28 +08:00
b956a2be1c
common/color: Get rid of undefined behavior
...
Gets rid of type punning via reinterpret_cast within functions. Instead,
we use memcpy to transfer the contents across types.
2018-08-10 09:35:27 +08:00
5e658efdb8
Service::HTTP_C: Add decryption of the ClCertA ( #4045 )
...
* Service::HTTP_C: Add decryption of the ClCertA
* fixup! Service::HTTP_C: Add decryption of the ClCertA
* fixup! Service::HTTP_C: Add decryption of the ClCertA
* FileSys:: Add MakeNCCHArchivePath and MakeNCCHFilePath; Small fixes in HTTP_C::DecryptDefaultClientCert
* fixup! fixup! Service::HTTP_C: Add decryption of the ClCertA
* fixup! fixup! fixup! Service::HTTP_C: Add decryption of the ClCertA
2018-08-09 23:02:53 +02:00
d09646ab9d
citra-qt: service: add convenient LLE service module configuration ( #3967 )
...
* citra-qt: service: add convenient LLE service module configuration
* fix SDL settings
* unexpose AttemptLLE
* static
* fix array includes
* use default with writesetting
2018-08-09 21:10:11 +02:00
dceb4150a8
Merge pull request #4065 from zhaowenlan1779/port-yuzu-947
...
game_list: Use QString::fromStdString() where applicable instead of c_str()
2018-08-09 09:41:35 -06:00
77573b93ce
Merge pull request #4066 from zhaowenlan1779/port-yuzu-946
...
Port "qt/main: Collapse if statement in UpdateRecentFiles()" from yuzu
2018-08-09 09:41:10 -06:00
22c0575cf4
Merge pull request #4061 from zhaowenlan1779/port-yuzu-967
...
Port "file_util: Avoid sign-conversions in WriteArray() and ReadArray()" from yuzu
2018-08-09 09:40:26 -06:00
cc6d3ce22f
Merge pull request #4053 from Steveice10/master
...
am: Corrections to handling of non-existent content indices.
2018-08-09 09:39:44 -06:00
aa98e55a88
fixup! Service::SM: Wait till client is registered
2018-08-08 23:42:45 +02:00
02a3b5ae2b
Service::SM: Wait till client is registered
2018-08-08 23:30:48 +02:00
84fc8eaaba
Merge pull request #4020 from wwylele/loader-crypto-new
...
ncch_container: support encrypted games
2018-08-08 22:12:19 +03:00
8ae126eb33
Merge pull request #4001 from Subv/http2
...
Services/HTTP: Corrected some error codes and added a few new ones.
2018-08-08 15:37:33 +02:00
b72e7d48e8
Service/HTTP: Added logs to some of the error conditions.
2018-08-08 08:32:46 -05:00
a51c700f59
Port "qt/main: Collapse if statement in UpdateRecentFiles()" from yuzu
2018-08-08 16:55:23 +08:00
b71fbe62a8
game_list: Use QString::fromStdString() where applicable instead of c_str()
2018-08-08 16:43:59 +08:00
0495ba5d91
file_util: Avoid sign-conversions in WriteArray() and ReadArray()
...
Prevents compiler warnings.
2018-08-08 15:45:31 +08:00
93386efccb
Merge pull request #4056 from zhaowenlan1779/clear-recent-files
...
citra_qt: add Clear Recent Files menu action
2018-08-07 21:28:33 -06:00
169bb29a54
Correct direction vectors for cemuhook motion input
2018-08-07 21:05:09 -06:00
6bcbda5ab2
Input: UDP Client to provide motion and touch controls
...
An implementation of the cemuhook motion/touch protocol, this adds the
ability for users to connect several different devices to citra to send
direct motion and touch data to citra.
2018-08-07 21:05:09 -06:00
d4a808c885
ncch_container: support encrypted games
2018-08-07 18:53:06 +03:00
6a1f9afbba
citra_qt: add Clear Recent Files menu action
...
I had to edit a bit of the Restart action so that it does not go wrong because recent files are cleared.
2018-08-06 09:19:35 +08:00
0233f3286c
Merge pull request #4052 from zhaowenlan1779/bg-color-real-fix
...
video_core: Allow changing background color while emulation is running
2018-08-04 09:27:30 -06:00
4c3961d5dd
am: Correct ListDLCContentInfos index bounds.
2018-08-04 01:27:05 -07:00
d93ed644f6
am: Return empty path string for non-existent content indices.
2018-08-04 01:03:29 -07:00
0c37140690
video_core: Allow changing background color while emulation is running
...
As @jroweboy stated, this is just one more atomic in VideoCore.
2018-08-04 15:11:51 +08:00
9937cab2cd
citra: default_ini bg color default value fix
...
I discovered this while making changing background color.. Just a minor nit.
2018-08-04 12:20:47 +08:00
79db1f8b49
Service/HTTP: Log the PIDs in the Initialize functions.
2018-08-03 15:24:26 -05:00
5bc72cca6b
Merge pull request #3924 from zhaowenlan1779/settings
...
citra_qt: Settings (configuration) default value fix
2018-08-03 23:09:57 +03:00
650c20eebf
citra_qt: Settings (configuration) rework
2018-08-03 13:49:30 +08:00
751e00a615
Merge pull request #3902 from valentinvanelslande/restart
...
citra_qt: add restart hotkey & menu option
2018-08-02 22:55:07 -06:00
6bc87cdf3e
Merge pull request #3987 from zhaowenlan1779/language-config-fix-2
...
citra_qt/configuration: retranslate hotkey widget on language change
2018-08-02 11:15:27 -06:00
c35a251d86
Merge pull request #3985 from BreadFish64/fix-warnings
...
core: clean up warnings
2018-08-02 11:14:57 -06:00
14b0435df2
Merge pull request #3994 from FearlessTobi/replace-clamp-functions
...
Remove MathUtil::Clamp and replace it with its std:: counterpart
2018-08-02 11:08:07 -06:00
cafe9838b5
Merge pull request #4047 from zhaowenlan1779/bg-color
...
citra_qt/configuration: Add background color config
2018-08-02 11:05:20 -06:00
4b59c1b601
Merge pull request #4042 from wwylele/i-love-drivers
...
gl_rasterizer: apply AMD hack only when the vendor is AMD
2018-08-02 11:01:25 -06:00
c771dd9813
Merge pull request #4021 from FearlessTobi/port-709
...
Port #709 from yuzu: "common/misc: Deduplicate code in GetLastErrorMsg()
2018-08-02 11:00:53 -06:00
5bf87e986e
Merge pull request #4040 from valentinvanelslande/lighting
...
swrasterizer/lighting: remove newline in logging macro
2018-08-02 11:18:03 +03:00
9b558253a0
Merge pull request #4031 from zhaowenlan1779/port-yuzu-723
...
Port "gdbstub: Get rid of a few signed/unsigned comparisons" from yuzu
2018-08-02 11:17:38 +03:00
27b015e652
Merge pull request #4011 from zhaowenlan1779/cmake-warning
...
citra_qt/CMakeLists: get rid of a warning
2018-08-02 11:16:46 +03:00
14bc20fc8d
Merge pull request #3996 from NarcolepticK/dsp-remove-weakptr
...
service/dsp: Clean up global state
2018-08-02 11:14:59 +03:00
60edddac7d
citra_qt/configuration: Add background color config
...
This is actually very easy to do. I added a label and a push button for it, and used the Qt standard dialog QColorDialog for picking colors.
2018-08-02 11:39:27 +08:00
aa4b71d0ce
update fmt to latest stable release
...
5.1.0
fixes a multitude of errors on MSVC
2018-08-01 14:10:24 -05:00
74cd98ecad
core: clean up warnings
2018-08-01 14:10:23 -05:00
ba6eee71f5
Merge pull request #4024 from zhaowenlan1779/port-yuzu-745
...
Port yuzu-emu/yuzu#745 from yuzu
2018-08-01 15:02:40 +01:00
6a9e18a49a
Merge pull request #4022 from zhaowenlan1779/port-yuzu-837
...
Port yuzu-emu/yuzu#837 from yuzu
2018-08-01 15:01:17 +01:00
703da21688
Merge pull request #4046 from zhaowenlan1779/config-camera-retranslate
...
citra_qt/configuration: retranslate camera tab
2018-08-01 15:00:12 +01:00
51d05bd42b
citra_qt/configuration: retranslate camera tab
...
It was really a stupid mistake..
2018-08-01 21:51:38 +08:00
8e103d0675
kernel/timer: Make data members private where applicable
...
Instead, we can just expose functions that return the queryable state
instead of letting anything modify it.
2018-08-01 17:49:52 +08:00
383dd967d1
citra_qt: UI text improvements
...
Changed a few texts that are not so good in the UI according to
@neobrain.
2018-08-01 17:32:33 +08:00
b92af5a858
param_package: Take std::string by value in string-based Set() function
...
Allows avoiding string copies by letting the strings be moved into the
function calls.
2018-08-01 17:21:11 +08:00
266f2b6242
gl_rasterizer: only apply AMD hack when the vendor is AMD
2018-07-31 22:58:17 +03:00
b2ad88dac1
swrasterizer/lighting: remove newline in logging macro
...
Software rasterizer version of #3904
2018-07-30 16:09:16 -05:00
05eb0ccb03
Merge pull request #4014 from wwylele/old-service
...
service: remove deprecated service interface
2018-07-30 11:31:54 -06:00
9af731793a
Merge pull request #4025 from zhaowenlan1779/port-yuzu-775
...
Port "string_util: Minor changes" from yuzu
2018-07-30 18:28:38 +01:00
ec76cd82b0
Merge pull request #4037 from zhaowenlan1779/port-yuzu-710
...
Port "common/common_funcs: Remove unused rotation functions" from yuzu
2018-07-30 18:28:11 +01:00
7b46b7e29a
Merge pull request #4010 from zhaowenlan1779/statusbar-retheme
...
qt_themes: add themed connected/disconnected icons for dark and fix status bar theme updating
2018-07-30 10:35:42 -06:00
ecb3dc2fb8
Merge pull request #4038 from zhaowenlan1779/port-yuzu-711
...
Port "common/swap: Minor changes" from yuzu
2018-07-30 10:21:49 -06:00
8fd9f22657
Merge pull request #4030 from zhaowenlan1779/port-yuzu-743
...
Port "logging: Use std::string_view where applicable" from yuzu
2018-07-30 10:19:28 -06:00
5a47cbed17
no need to cast to u32 according to @wwylele comment
2018-07-30 22:40:56 +08:00
b4cdbf3ee8
gdbstub: Get rid of a few signed/unsigned comparisons
...
Ensures both operands in comparisons are the same signedness.
2018-07-30 22:40:43 +08:00
5d7ccfb920
citra_qt/CMakeLists: get rid of a warning
...
This got rid of a warning of CMake Policy CMP0071 not set. In fact, setting it to either OLD or NEW is same for Citra (I tested on MSVC and MinGW), and the OLD option is deprecated, so I am using NEW here.
2018-07-30 22:32:48 +08:00
1a0529a064
common/swap: Remove unnecessary const on return value of swap()
2018-07-30 21:30:15 +08:00
a2203e1566
common/swap: Use static_cast where applicable
2018-07-30 21:30:14 +08:00
5a66820c20
common/swap: Use using aliases where applicable
2018-07-30 21:30:13 +08:00
b0c35c54ca
Fix travis MinGW build
2018-07-30 14:50:23 +02:00
15abf35889
Address feedback by wwylele
2018-07-30 14:46:13 +02:00
b539745153
common/common_funcs: Remove unused rotation functions
...
These are unused and essentially don't provide much benefit either. If
we ever need rotation functions, these can be introduced in a way that
they don't sit in a common_* header and require a bunch of ifdefing to
simply be available
2018-07-30 20:08:59 +08:00
b4524eb70b
Merge pull request #3988 from zhaowenlan1779/multiplayer-block
...
citra_qt/multiplayer: allow blocking other players in chat room
2018-07-30 14:07:40 +02:00
d5333c37de
Merge pull request #4033 from zhaowenlan1779/port-yuzu-764
...
Port "file_util: Minor changes to ScanDirectoryTree() and ForeachDirectoryEntry()" from yuzu
2018-07-30 13:51:21 +02:00
45beea31ea
Merge pull request #4034 from zhaowenlan1779/port-yuzu-802
...
Port "wait_tree: Silence warning about all code paths not returning a value" from yuzu
2018-07-30 12:38:24 +01:00
4acc4d87d6
Merge pull request #4032 from zhaowenlan1779/port-yuzu-758
...
Port "common: Remove synchronized_wrapper.h" from yuzu
2018-07-30 12:36:45 +01:00
c4c158c6b6
Merge pull request #4036 from zhaowenlan1779/port-yuzu-705
...
Port "file_util: return string by const reference for GetExeDirectory()" from yuzu
2018-07-30 12:10:35 +01:00
995d1cd785
string_util: Get rid of separate resize() in CPToUTF16(), UTF16ToUTF8(), CodeToUTF8() and UTF8ToUTF16()
...
There's no need to perform the resize separately here, since the
constructor allows presizing the buffer.
Also move the empty string check before the construction of the string
to make the early out more straightforward.
2018-07-30 18:18:15 +08:00
f34dde32d1
string_util: Use emplace_back() in SplitString() instead of push_back()
...
This is equivalent to doing:
push_back(std::string(""));
which is likely not to cause issues, assuming a decent std::string
implementation with small-string optimizations implemented in its
design, however it's still a little unnecessary to copy that buffer
regardless. Instead, we can use emplace_back() to directly construct the
empty string within the std::vector instance, eliminating any possible
overhead from the copy.
2018-07-30 18:18:14 +08:00
841bb4e5bd
string_util: Remove unnecessary std::string instance in TabsToSpaces()
...
We can just use the variant of std::string's replace() function that can
replace an occurrence with N copies of the same character, eliminating
the need to allocate a std::string containing a buffer of spaces.
2018-07-30 18:18:12 +08:00
71729fd47a
Merge pull request #3951 from zhaowenlan1779/cfg-country-code
...
service/cfg, citra_qt: add country code configuration
2018-07-30 12:02:07 +03:00
1f14ebf35d
Merge pull request #3977 from B3n30/bad_word_list
...
Add virtual bad word list; Load if dump is missing
2018-07-30 12:01:45 +03:00
99b2a871a7
file_util: return string by const reference for GetExeDirectory()
...
This disallows modifying the internal string buffer (which shouldn't be
modified anyhow).
2018-07-30 16:55:55 +08:00
77f4859059
Merge pull request #4026 from zhaowenlan1779/port-yuzu-765
...
Port "file_util: Remove goto usages from Copy()" from yuzu
2018-07-30 11:44:32 +03:00
bf5b5d25ed
wait_tree: Silence warning about all code paths not returning a value
...
If code execution hits this spot, something has gone very wrong, so mark
the path as unreachable. This silences a warning on MSVC.
2018-07-30 16:32:09 +08:00
abc86921ab
Merge pull request #4027 from zhaowenlan1779/port-yuzu-704
...
Port "string_util: Remove AsciiToHex()" from yuzu
2018-07-30 11:22:46 +03:00
df5069f8c0
file_util: Use a u64 to represent number of entries
...
This avoids a truncating cast on size. I doubt we'd ever traverse a
directory this large, however we also shouldn't truncate sizes away.
2018-07-30 16:19:03 +08:00
cc6cb45536
file_util: std::move FST entries in ScanDirectoryTree()
...
Avoids unnecessary copies when building up the FST entries.
2018-07-30 16:16:58 +08:00
f4a389dca5
Merge pull request #4023 from zhaowenlan1779/port-yuzu-797
...
Port yuzu-emu/yuzu#797 from yuzu
2018-07-30 08:28:35 +01:00
1eb3d0c634
common: Remove synchronized_wrapper.h
...
This is entirely unused in the codebase.
2018-07-30 15:12:04 +08:00
1affca05c7
logging/filter: Use std::string_view in ParseFilterString()
...
Allows avoiding constructing std::string instances, since this only
reads an arbitrary sequence of characters.
We can also make ParseFilterRule() internal, since it doesn't depend on
any private instance state of Filter
2018-07-30 14:56:53 +08:00
798ebda049
logging/backend: Add missing standard includes
...
A few inclusions were being satisfied indirectly. To prevent breakages
in the future, include these directly.
2018-07-30 14:56:52 +08:00
765c7e711a
logging/backend: Use std::string_view in RemoveBackend() and GetBackend()
...
These can just use a view to a string since its only comparing against
two names in both cases for matches. This avoids constructing
std::string instances where they aren't necessary.
2018-07-30 14:56:51 +08:00
8068f506c5
string_util: Remove AsciiToHex()
...
Easy TODO
2018-07-30 09:06:14 +08:00
d3a52e45e3
file_util: Remove goto usages from Copy()
...
We can just leverage std::unique_ptr to automatically close these for us
in error cases instead of jumping to the end of the function to call
fclose on them.
2018-07-30 08:48:58 +08:00
5b691d3fe0
param_package: Use std::unordered_map's insert_or_assign instead of map indexing
...
This avoids a redundant std::string construction if a key doesn't exist
in the map already.
e.g.
data[key] requires constructing a new default instance of the value in
the map (but this is wasteful, since we're already setting something
into the map over top of it).
2018-07-30 08:22:42 +08:00
290bfa1804
param_package: Get rid of file-static std::string construction
...
Avoids potential dynamic allocation occuring during program launch
2018-07-30 08:22:41 +08:00
Lioncash
fearlessTobi
Nguyen Dac Nam
James Rowe
Vamsi Krishna
zhupengfei
Jarek Syrylak
Jarek Syrylak
CodingKoopa
Valentin Vanelslande
Weiyi Wang
Merry
Ben
BreadFish64
B3n30
Subv
Steveice10