From be431f5ed080955cce358e9750347229b2bc9a04 Mon Sep 17 00:00:00 2001
From: ameerj <52414509+ameerj@users.noreply.github.com>
Date: Sat, 17 Apr 2021 00:48:35 -0400
Subject: [PATCH] shader: Implement BFE and BFI CC

Fix two bugs in BFI.
---
 .../backend/spirv/emit_spirv_select.cpp         |  3 +--
 .../maxwell/translate/impl/bitfield_extract.cpp | 11 +++++++----
 .../maxwell/translate/impl/bitfield_insert.cpp  | 17 +++++++++--------
 3 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/src/shader_recompiler/backend/spirv/emit_spirv_select.cpp b/src/shader_recompiler/backend/spirv/emit_spirv_select.cpp
index 8b0562da5..0b45db45e 100644
--- a/src/shader_recompiler/backend/spirv/emit_spirv_select.cpp
+++ b/src/shader_recompiler/backend/spirv/emit_spirv_select.cpp
@@ -10,8 +10,7 @@ Id EmitSelectU1(EmitContext& ctx, Id cond, Id true_value, Id false_value) {
     return ctx.OpSelect(ctx.U1, cond, true_value, false_value);
 }
 
-Id EmitSelectU8([[maybe_unused]] EmitContext& ctx, [[maybe_unused]] Id cond,
-                [[maybe_unused]] Id true_value, [[maybe_unused]] Id false_value) {
+Id EmitSelectU8(EmitContext&, Id, Id, Id) {
     throw NotImplementedException("SPIR-V Instruction");
 }
 
diff --git a/src/shader_recompiler/frontend/maxwell/translate/impl/bitfield_extract.cpp b/src/shader_recompiler/frontend/maxwell/translate/impl/bitfield_extract.cpp
index 0738ae7a6..9d5a87e52 100644
--- a/src/shader_recompiler/frontend/maxwell/translate/impl/bitfield_extract.cpp
+++ b/src/shader_recompiler/frontend/maxwell/translate/impl/bitfield_extract.cpp
@@ -18,10 +18,6 @@ void BFE(TranslatorVisitor& v, u64 insn, const IR::U32& src) {
         BitField<48, 1, u64> is_signed;
     } const bfe{insn};
 
-    if (bfe.cc != 0) {
-        throw NotImplementedException("BFE CC");
-    }
-
     const IR::U32 offset{v.ir.BitFieldExtract(src, v.ir.Imm32(0), v.ir.Imm32(8), false)};
     const IR::U32 count{v.ir.BitFieldExtract(src, v.ir.Imm32(8), v.ir.Imm32(8), false)};
 
@@ -53,6 +49,13 @@ void BFE(TranslatorVisitor& v, u64 insn, const IR::U32& src) {
     result = IR::U32{v.ir.Select(zero_count, zero, result)};
 
     v.X(bfe.dest_reg, result);
+
+    if (bfe.cc != 0) {
+        v.SetZFlag(v.ir.IEqual(result, zero));
+        v.SetSFlag(v.ir.ILessThan(result, zero, true));
+        v.ResetCFlag();
+        v.ResetOFlag();
+    }
 }
 } // Anonymous namespace
 
diff --git a/src/shader_recompiler/frontend/maxwell/translate/impl/bitfield_insert.cpp b/src/shader_recompiler/frontend/maxwell/translate/impl/bitfield_insert.cpp
index fb7f821e6..1e1ec2119 100644
--- a/src/shader_recompiler/frontend/maxwell/translate/impl/bitfield_insert.cpp
+++ b/src/shader_recompiler/frontend/maxwell/translate/impl/bitfield_insert.cpp
@@ -16,18 +16,14 @@ void BFI(TranslatorVisitor& v, u64 insn, const IR::U32& src_a, const IR::U32& ba
         BitField<47, 1, u64> cc;
     } const bfi{insn};
 
-    if (bfi.cc != 0) {
-        throw NotImplementedException("BFI CC");
-    }
-
-    const IR::U32 offset{v.ir.BitFieldExtract(src_a, v.ir.Imm32(0), v.ir.Imm32(8), false)};
+    const IR::U32 zero{v.ir.Imm32(0)};
+    const IR::U32 offset{v.ir.BitFieldExtract(src_a, zero, v.ir.Imm32(8), false)};
     const IR::U32 unsafe_count{v.ir.BitFieldExtract(src_a, v.ir.Imm32(8), v.ir.Imm32(8), false)};
     const IR::U32 max_size{v.ir.Imm32(32)};
 
     // Edge case conditions
-    const IR::U1 zero_offset{v.ir.IEqual(offset, v.ir.Imm32(0))};
     const IR::U1 exceed_offset{v.ir.IGreaterThanEqual(offset, max_size, false)};
-    const IR::U1 exceed_count{v.ir.IGreaterThanEqual(unsafe_count, max_size, false)};
+    const IR::U1 exceed_count{v.ir.IGreaterThan(unsafe_count, max_size, false)};
 
     const IR::U32 remaining_size{v.ir.ISub(max_size, offset)};
     const IR::U32 safe_count{v.ir.Select(exceed_count, remaining_size, unsafe_count)};
@@ -36,9 +32,14 @@ void BFI(TranslatorVisitor& v, u64 insn, const IR::U32& src_a, const IR::U32& ba
     IR::U32 result{v.ir.BitFieldInsert(base, insert, offset, safe_count)};
 
     result = IR::U32{v.ir.Select(exceed_offset, base, result)};
-    result = IR::U32{v.ir.Select(zero_offset, base, result)};
 
     v.X(bfi.dest_reg, result);
+    if (bfi.cc != 0) {
+        v.SetZFlag(v.ir.IEqual(result, zero));
+        v.SetSFlag(v.ir.ILessThan(result, zero, true));
+        v.ResetCFlag();
+        v.ResetOFlag();
+    }
 }
 } // Anonymous namespace