citra-emu
/
citra-canary
Archived
1
0
Fork 0
Code

arm_dyncom_thumb: Merge STR/LDR table subsets.

This commit is contained in:
Lioncash 2015-05-26 20:18:47 -04:00
parent 99b1f868a3
commit 0265d950e6
1 changed files with 11 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/core/arm/dyncom/arm_dyncom_thumb.cpp
View File

@ -189,33 +189,22 @@ tdstate thumb_translate(u32 addr, u32 instr, u32* ainstr, u32* inst_size) {
case 10: case 10:
case 11: case 11:
// TODO: Format 7 and Format 8 perform the same ARM encoding, so the following could be {
// merged into a single subset, saving on the following boolean: static const ARMword subset[8] = {
0xE7800000, // STR Rd,[Rb,Ro]
if ((tinstr & (1 << 9)) == 0) {
static const ARMword subset[4] = {
0xE7800000, // STR Rd,[Rb,Ro]
0xE7C00000, // STRB Rd,[Rb,Ro]
0xE7900000, // LDR Rd,[Rb,Ro]
0xE7D00000 // LDRB Rd,[Rb,Ro]
};
*ainstr = subset[(tinstr & 0x0C00) >> 10] // base
|((tinstr & 0x0007) << (12 - 0)) // Rd
|((tinstr & 0x0038) << (16 - 3)) // Rb
|((tinstr & 0x01C0) >> 6); // Ro
} else {
static const ARMword subset[4] = {
0xE18000B0, // STRH Rd,[Rb,Ro] 0xE18000B0, // STRH Rd,[Rb,Ro]
0xE7C00000, // STRB Rd,[Rb,Ro]
0xE19000D0, // LDRSB Rd,[Rb,Ro] 0xE19000D0, // LDRSB Rd,[Rb,Ro]
0xE7900000, // LDR Rd,[Rb,Ro]
0xE19000B0, // LDRH Rd,[Rb,Ro] 0xE19000B0, // LDRH Rd,[Rb,Ro]
0xE7D00000, // LDRB Rd,[Rb,Ro]
0xE19000F0 // LDRSH Rd,[Rb,Ro] 0xE19000F0 // LDRSH Rd,[Rb,Ro]
}; };
*ainstr = subset[(tinstr & 0x0C00) >> 10] // base
|((tinstr & 0x0007) << (12 - 0)) // Rd *ainstr = subset[(tinstr & 0xE00) >> 9] // base
|((tinstr & 0x0038) << (16 - 3)) // Rb |((tinstr & 0x0007) << (12 - 0)) // Rd
|((tinstr & 0x01C0) >> 6); // Ro |((tinstr & 0x0038) << (16 - 3)) // Rb
|((tinstr & 0x01C0) >> 6); // Ro
} }
break; break;