citra-emu
/
citra-canary
Archived
1
0
Fork 0
Code

glsl_shader_fs_gen: Apply shadow before ambient light (#7404)

This commit is contained in:
GPUCode 2024-01-31 23:29:39 +02:00 committed by GitHub
parent 63feac6bb3
commit 480604ec72
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/video_core/renderer_software/sw_lighting.cpp
View File

@ -285,19 +285,20 @@ std::pair<Common::Vec4<u8>, Common::Vec4<u8>> ComputeFragmentsColors(
}
}
auto diffuse =
(light_config.diffuse.ToVec3f() * dot_product + light_config.ambient.ToVec3f()) *
dist_atten * spot_atten;
auto specular = (specular_0 + specular_1) * clamp_highlights * dist_atten * spot_atten;
const bool shadow_primary_enable =
lighting.config0.shadow_primary && !lighting.IsShadowDisabled(num);
const bool shadow_secondary_enable =
lighting.config0.shadow_secondary && !lighting.IsShadowDisabled(num);
const auto shadow_primary =
shadow_primary_enable ? shadow.xyz() : Common::MakeVec(1.f, 1.f, 1.f);
const auto shadow_secondary =
shadow_secondary_enable ? shadow.xyz() : Common::MakeVec(1.f, 1.f, 1.f);
if (!lighting.IsShadowDisabled(num)) {
if (lighting.config0.shadow_primary) {
diffuse = diffuse * shadow.xyz();
}
if (lighting.config0.shadow_secondary) {
specular = specular * shadow.xyz();
}
}
const auto diffuse = (light_config.diffuse.ToVec3f() * dot_product * shadow_primary +
light_config.ambient.ToVec3f()) *
dist_atten * spot_atten;
const auto specular = (specular_0 + specular_1) * clamp_highlights * dist_atten *
spot_atten * shadow_secondary;
diffuse_sum += Common::MakeVec(diffuse, 0.0f);
specular_sum += Common::MakeVec(specular, 0.0f);

4
src/video_core/shader/generator/glsl_fs_shader_gen.cpp
View File

@ -810,8 +810,8 @@ void FragmentModule::WriteLighting() {
// Compute primary fragment color (diffuse lighting) function
out += fmt::format(
"diffuse_sum.rgb += (({}.diffuse * dot_product) + {}.ambient) * {} * {}{};\n",
light_src, light_src, dist_atten, spot_atten, shadow_primary);
"diffuse_sum.rgb += (({}.diffuse * dot_product{}) + {}.ambient) * {} * {};\n",
light_src, shadow_primary, light_src, dist_atten, spot_atten);
// Compute secondary fragment color (specular lighting) function
out += fmt::format("specular_sum.rgb += ({} + {}) * clamp_highlights * {} * {}{};\n",