Make UNIMPLEMENTED_MSG consistent with UNIMPLEMENTED (#5631)
The current inconsistency can result in a developer unintentionally creating a crash when using UNIMPLEMENTED_MSG, if they're only familiar with UNIMPLEMENTED. The two macros shouldn't have such wildly different behaviors.
This commit is contained in:
parent
6f45b402e7
commit
4888a14c12
|
@ -55,4 +55,4 @@ assert_noinline_call(const Fn& fn) {
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
#define UNIMPLEMENTED() LOG_CRITICAL(Debug, "Unimplemented code!")
|
#define UNIMPLEMENTED() LOG_CRITICAL(Debug, "Unimplemented code!")
|
||||||
#define UNIMPLEMENTED_MSG(_a_, ...) ASSERT_MSG(false, _a_, __VA_ARGS__)
|
#define UNIMPLEMENTED_MSG(_a_, ...) LOG_CRITICAL(Debug, _a_, __VA_ARGS__)
|
||||||
|
|
Reference in New Issue