citra-emu
/
citra-canary
Archived
1
0
Fork 0

yuzu/configuration/configure_input: Default destructor in the cpp file

The previous code could potentially be a compilation issue waiting to
occur, given we forward declare the type for a std::unique_ptr. If the
complete definition of the forward declared type isn't visible in a
translation unit that the class is used in, then it would fail to
compile.

Defaulting the destructor in a cpp file ensures the std::unique_ptr's
destructor is only invoked where its complete type is known.
This commit is contained in:
Lioncash 2018-12-02 14:06:39 -05:00 committed by fearlessTobi
parent 7aeb4e29c2
commit 9c0c817e6f
2 changed files with 3 additions and 0 deletions

View File

@ -221,6 +221,8 @@ ConfigureInput::ConfigureInput(QWidget* parent)
ui->buttonHome->setEnabled(false);
}
ConfigureInput::~ConfigureInput() = default;
void ConfigureInput::applyConfiguration() {
std::transform(buttons_param.begin(), buttons_param.end(), Settings::values.buttons.begin(),
[](const Common::ParamPackage& param) { return param.Serialize(); });

View File

@ -30,6 +30,7 @@ class ConfigureInput : public QWidget {
public:
explicit ConfigureInput(QWidget* parent = nullptr);
~ConfigureInput() override;
/// Save all button configurations to settings file
void applyConfiguration();