service/mvd: Migrate to ServiceFramework (#3890)

* service/mvd: Migrate to ServiceFramework

* service/mvd: Silenced clang format

src/core/hle/service/mvd/mvd.cpp

@@ -4,13 +4,12 @@
 
 #include "core/hle/service/mvd/mvd.h"
 #include "core/hle/service/mvd/mvd_std.h"
-#include "core/hle/service/service.h"
 
 namespace Service {
 namespace MVD {
 
-void Init() {
-    AddService(new MVD_STD());
+void InstallInterfaces(SM::ServiceManager& service_manager) {
+    std::make_shared<MVD_STD>()->InstallAsService(service_manager);
 }
 
 } // namespace MVD

src/core/hle/service/mvd/mvd.h

@@ -4,11 +4,13 @@
 
 #pragma once
 
+#include "core/hle/service/service.h"
+
 namespace Service {
 namespace MVD {
 
 /// Initializes all MVD services.
-void Init();
+void InstallInterfaces(SM::ServiceManager& service_manager);
 
 } // namespace MVD
 } // namespace Service

src/core/hle/service/mvd/mvd_std.cpp

@@ -2,12 +2,14 @@
 // Licensed under GPLv2 or any later version
 // Refer to the license.txt file included.
 
+#include "core/hle/ipc_helpers.h"
 #include "core/hle/service/mvd/mvd_std.h"
 
 namespace Service {
 namespace MVD {
 
-const Interface::FunctionInfo FunctionTable[] = {
+MVD_STD::MVD_STD() : ServiceFramework("mvd:std", 1) {
+    static const FunctionInfo functions[] = {
         // clang-format off
         {0x00010082, nullptr, "Initialize"},
         {0x00020000, nullptr, "Shutdown"},
@@ -22,11 +24,10 @@ const Interface::FunctionInfo FunctionTable[] = {
         {0x001F0902, nullptr, "SetOutputBuffer"},
         {0x00210100, nullptr, "OverrideOutputBuffers"}
         // clang-format on
-};
+    };
 
-MVD_STD::MVD_STD() {
-    Register(FunctionTable);
-}
+    RegisterHandlers(functions);
+};
 
 } // namespace MVD
 } // namespace Service

src/core/hle/service/mvd/mvd_std.h

@@ -9,13 +9,10 @@
 namespace Service {
 namespace MVD {
 
-class MVD_STD final : public Interface {
+class MVD_STD final : public ServiceFramework<MVD_STD> {
 public:
     MVD_STD();
-
-    std::string GetPortName() const override {
-        return "mvd:std";
-    }
+    ~MVD_STD() = default;
 };
 
 } // namespace MVD

src/core/hle/service/service.cpp

@@ -247,7 +247,7 @@ void Init(std::shared_ptr<SM::ServiceManager>& sm) {
     GSP::InstallInterfaces(*sm);
     HID::InstallInterfaces(*sm);
     IR::InstallInterfaces(*sm);
-    MVD::Init();
+    MVD::InstallInterfaces(*sm);
     NDM::InstallInterfaces(*sm);
     NEWS::InstallInterfaces(*sm);
     NFC::InstallInterfaces(*sm);