36e368ff99
remove Common::TrimSourcePath
...
wwylele / 白疾風Today at 6:14 PM
I doubt the performance of constructing regex everytime the function is called
Is TrimSourcePath only called by logging? if so, you can move the implementation into logging, and cache the regex object into global
This function is probably too specific to be in common anyway
2019-03-10 19:18:09 -05:00
6ce58248b0
APT: use member system instead of global instance
2019-03-10 11:10:24 -04:00
605dfe80e7
appease clang format
2019-03-09 19:15:35 -06:00
f767b5fdef
android: add logging
2019-03-09 18:23:32 -06:00
9848610ea2
android: init user path
2019-03-09 18:23:27 -06:00
36ae10f555
archive_ncch: add open source mii archive
2019-03-09 08:19:32 -05:00
acaca4188e
gdbstub: Fix some bugs in IsMemoryBreak() and ServeBreak. Add workaround to let watchpoints break into GDB. ( #4651 )
...
* gdbstub: fix IsMemoryBreak() returning false while connected to client
As a result, the only existing codepath for a memory watchpoint hit to break into GDB (InterpeterMainLoop, GDB_BP_CHECK, ARMul_State::RecordBreak) is finally taken,
which exposes incorrect logic* in both RecordBreak and ServeBreak.
* a blank BreakpointAddress structure is passed, which sets r15 (PC) to NULL
* gdbstub: DynCom: default-initialize two members/vars used in conditionals
* gdbstub: DynCom: don't record memory watchpoint hits via RecordBreak()
For now, instead check for GDBStub::IsMemoryBreak() in InterpreterMainLoop and ServeBreak.
Fixes PC being set to a stale/unhit breakpoint address (often zero) when a memory watchpoint (rwatch, watch, awatch) is handled in ServeBreak() and generates a GDB trap.
Reasons for removing a call to RecordBreak() for memory watchpoints:
* The``breakpoint_data`` we pass is typed Execute or None. It describes the predicted next code breakpoint hit relative to PC;
* GDBStub::IsMemoryBreak() returns true if a recent Read/Write operation hit a watchpoint. It doesn't specify which in return, nor does it trace it anywhere. Thus, the only data we could give RecordBreak() is a placeholder BreakpointAddress at offset NULL and type Access. I found the idea silly, compared to simply relying on GDBStub::IsMemoryBreak().
There is currently no measure in the code that remembers the addresses (and types) of any watchpoints that were hit by an instruction, in order to send them to GDB as "extended stop information."
I'm considering an implementation for this.
* gdbstub: Change an ASSERT to DEBUG_ASSERT
I have never seen the (Reg[15] == last_bkpt.address) assert fail in practice, even after several weeks of (locally) developping various branches around GDB. Only leave it inside Debug builds.
2019-03-08 00:09:06 -05:00
c3e6610807
Merge pull request #4627 from FearlessTobi/cia-install-short
...
citra_qt: when opening a cia file directly, make Citra ask to install it
2019-03-07 23:55:58 -05:00
9560060f04
Merge pull request #4666 from FearlessTobi/port-2167
...
Port yuzu-emu/yuzu#2167 : "common: Move Quaternion, Rectangle, Vec2, Vec3, and Vec4 into the Common namespace"
2019-03-07 23:52:42 -05:00
f5b86cff52
Clang-format
2019-03-06 22:43:35 -07:00
f5df13eb24
Remove global state and add mic hot swapping
2019-03-06 20:59:58 -07:00
182d672c15
Add ifdef around cubeb for android. Address a few review comments
2019-03-06 20:03:22 -07:00
5c61d53047
Fix compiler error
2019-03-06 11:30:23 -07:00
ba4dfe4217
Increase mic stream volume to max in case the users mic is set low for some reason
2019-03-06 11:17:32 -07:00
5f532c2560
Address review comments
2019-03-06 11:16:43 -07:00
2999c8325e
archive_extsavedata: add correct FileOpen delays
2019-03-06 18:53:44 +01:00
5055a6c262
Address review comments
2019-03-06 18:53:34 +01:00
5954dc11ba
Merge pull request #4669 from wwylele/rpc-server-freeze
...
rpc: send ending packet in Server instead of UDPServer
2019-03-06 09:11:04 -07:00
fc7e6c9cc9
fs_user: Add a delay for each file open
2019-03-06 16:09:24 +01:00
d0de727a97
Merge pull request #4668 from wwylele/swkbd-size
...
applet/swkbd: use UTF-16 string to test string size
2019-03-05 12:23:54 -05:00
3ea30fe2b3
Merge pull request #4610 from zhaowenlan1779/cheats-ui
...
Implement UI for adding/editing/deleting cheats
2019-03-05 22:07:40 +08:00
c669aa8d55
Rest of the owl
2019-03-04 23:07:05 -07:00
5c9e327ff3
Fix
2019-03-04 23:07:05 -07:00
7fccc995ce
Initial Mic setup
2019-03-04 23:06:42 -07:00
b3261472fe
Merge pull request #4665 from FearlessTobi/port-yuzu-stuffz
...
Port various minor PRs from yuzu
2019-03-04 12:36:10 -05:00
9c57b74907
Merge pull request #4618 from wwylele/fs-clean
...
FS: pass down program ID for archive operation (cleanup System::GetInstance part 3)
2019-03-04 12:34:54 -05:00
870579d38f
rpc: send ending packet in Server instead of UDPServer
...
udp_server might not be created due to error (occupied port etc.), in which case its destructor and thread-ending call chain will not be excuted in Server::Stop. However, the ending packet still need to be send no matter udp is on or not, so move it to Server::Stop
2019-03-04 11:05:07 -05:00
47ed3f4db5
applet/swkbd: use UTF-16 string to test string size
...
Also removed a TODO as it is verified that max_text_length is inclusive (allows size = max_text_length)
2019-03-04 10:33:23 -05:00
e1a4912ade
common/math_util: Move contents into the Common namespace
...
These types are within the common library, so they should be within the
Common namespace.
2019-03-02 18:13:10 +01:00
643472e24a
common/vector_math: Move Vec[x] types into the Common namespace
...
These types are within the common library, so they should be using the
Common namespace.
2019-03-02 15:04:13 +01:00
db58652680
common/quaternion: Move Quaternion into the Common namespace
...
Quaternion is within the common library, so it should be using the
Common namespace.
2019-03-02 14:44:09 +01:00
d354a2ee3b
audio_core/codec: Resolve truncation warnings within DecodeADPCM
...
The assignments here were performing an implicit truncation from int to
s16. Make it explicit that this is desired behavior.
2019-03-02 14:06:30 +01:00
f322c51a63
core/frontend/emu_window: Make ClipToTouchScreen a const member function
...
This member function doesn't modify instance state, so it can have the
const specifier applied to it.
2019-03-02 14:06:09 +01:00
6149be43cf
yuzu/compatdb: Remove unused lambda capture
...
Silences a compiler warning with clang.
2019-03-02 14:04:13 +01:00
ad1cfc8d50
Merge pull request #4608 from wwylele/sharedmem-circular
...
Kernel/SharedMemory: make owner_process a raw pointer
2019-02-25 10:32:45 -05:00
93275d752b
Merge pull request #4645 from FearlessTobi/port-2116
...
Port yuzu-emu/yuzu#2116 : "threadsafe_queue: Remove NeedSize template parameter"
2019-02-25 10:25:11 -05:00
206413ba7b
Merge pull request #4630 from wwylele/memory-no-lock
...
Memory: don't lock hle mutex in memory read/write
2019-02-25 10:23:23 -05:00
5f10cc412f
Merge pull request #4632 from zhaowenlan1779/socu
...
service/soc_u: Implement getaddrinfo and getnameinfo
2019-02-25 10:23:13 -05:00
fdb5a8c2df
Merge pull request #4629 from FearlessTobi/bunnei-fooled-me
...
Port minor changes for BitField from yuzu
2019-02-25 10:22:44 -05:00
42c777b0e5
Merge pull request #4617 from wwylele/hle-service-clean
...
HLE/IPC: clean up System::GetInstance
2019-02-25 10:22:13 -05:00
c265f3f507
Merge pull request #4616 from wwylele/core-global-clean
...
Cleanup System::GetInstance reference - Part 1
2019-02-25 10:22:02 -05:00
f8b3617394
bit_field: Remove is_pod check, add is_trivially_copyable_v.
2019-02-24 19:40:20 +01:00
e24c7a474c
bit_field: Make all methods constexpr.
2019-02-24 19:39:15 +01:00
28b2ee9cd7
add java to .clang-format
2019-02-22 16:29:19 -06:00
5f80075c31
Merge pull request #4596 from CarlKenner/master
...
Fix mouse touchscreen in SBS 3D mode
2019-02-22 16:24:22 -05:00
28e849cddb
Merge pull request #4598 from BreadFish64/user_path
...
common: decouple getting and setting user paths
2019-02-22 16:23:41 -05:00
b0a4220711
Merge pull request #4647 from FearlessTobi/fix-weird-bug
...
citra_qt/main: make SPEED_LIMIT_STEP static constexpr
2019-02-22 16:21:54 -05:00
8f2bd97277
Merge pull request #4655 from tgsm/gcc-version
...
Remove GCC version checks
2019-02-22 16:21:21 -05:00
c357531acb
citra_qt/main: make SPEED_LIMIT_STEP static constexpr
...
MSVC does not seem to like using constexpr values in a lambda that were declared outside of it.
Previously on MSVC build the hotkeys to inc-/decrease the speed limit were not working correctly because in the lambda the SPEED_LIMIT_STEP had garbage values.
After googling around a bit I found: https://github.com/codeplaysoftware/computecpp-sdk/issues/95 which seems to be a similar issue.
Trying the suggested fix to make the variable static constexpr also fixes the bug here.
2019-02-20 16:11:38 +01:00
0556cac37d
threadsafe_queue: Use std::size_t for representing size
...
Makes it consistent with the regular standard containers in terms of
size representation. This also gets rid of dependence on our own
type aliases, removing the need for an include.
2019-02-20 16:05:22 +01:00
433ab35e7e
Remove GCC version checks
...
Citra can't be compiled using GCC <7 because of required C++17 support, so these version checks don't need to exist anymore.
2019-02-19 16:39:34 -05:00
f6d0e43c77
Merge pull request #4654 from tgsm/video-nested
...
video_core: use nested namespaces
2019-02-19 21:44:38 +08:00
820e3893de
Merge pull request #4652 from tgsm/audio-nested
...
audio_core: use nested namespaces
2019-02-19 21:39:35 +08:00
d6c530d08c
video_core: use nested namespaces
2019-02-19 03:09:57 -05:00
39e163b7ce
core: use nested namespaces
2019-02-18 20:34:18 -05:00
a400e49338
audio_core: use nested namespaces
2019-02-17 23:41:48 -05:00
f409342ab5
Merge pull request #4613 from BreadFish64/gles5
...
video_core: add GLES support
2019-02-17 15:44:39 -05:00
70653c6a87
citra_qt/config: actually save name of input profile
...
Fixes the issue where all input profiles had the name "default" after restarting Citra.
2019-02-16 21:41:51 +01:00
931895d9b0
citra_qt: when opnening a cia file directly, make Citra ask to install it
2019-02-16 17:18:19 +01:00
3bc78e577f
threadsafe_queue: Remove NeedSize template parameter
...
The necessity of this parameter is dubious at best, and in 2019 probably
offers completely negligible savings as opposed to just leaving this
enabled. This removes it and simplifies the overall interface.
2019-02-15 22:00:44 +01:00
d3d53bae83
common: decouple getting and setting user paths
...
paths -> g_paths
2019-02-15 14:48:31 -06:00
e6feef96c1
Service: clear IPC header for unimplemented function stub
2019-02-14 22:16:50 -05:00
3f86be88f0
HLE/IPC: pass in kernel & memory reference from parent to avoid global state reference
2019-02-14 22:09:25 -05:00
0a424b86d2
ServerSession: replace GetPointer with block copy for HLE translation
...
Do it in the same way as HLERequestContext::SleepClientThread callback and avoid unsafe GetPointer
2019-02-14 22:09:25 -05:00
36c8e1d7a9
HLE/IPC: move command buffer translation into kernel as TODO says
2019-02-14 22:09:25 -05:00
4d10a2d652
tests/audio_core: remove hack for system objects
2019-02-14 14:08:45 -05:00
64f6e5e597
ARM: pass MemorySystem separately in the constructor and make System optional
...
So that unit test can test CPU without constructing the entire system. Also remove hacks in the System class
2019-02-14 14:04:46 -05:00
9573ee46bd
Memory: replace Core::CPU
2019-02-14 14:04:46 -05:00
5f6d9f1915
Kernel/IPC: use MemorySystem from parameter
2019-02-14 14:04:46 -05:00
20f47583f6
Kernel: replace usage of Core::System::GetInstance().PrepareReschedule() with callback
2019-02-14 14:04:46 -05:00
eb050b8403
Kernel: replace usage of Core::System::GetInstance()::Timing()
2019-02-14 14:04:46 -05:00
276ca88c9e
kernel/thread: replace usage of Core::CPU()
2019-02-14 14:04:46 -05:00
b9f6bd9278
ldr_ro: replace usage of Core::CPU()
2019-02-14 14:04:46 -05:00
de1128c60d
Merge pull request #4628 from FearlessTobi/backport-some-stuff
...
Backport various minor frontend review changes from yuzu and port minor PR from yuzu
2019-02-14 11:45:27 -05:00
4b2397aa77
Merge pull request #4633 from BreadFish64/fully-invalid
...
video_core: improve efficiency of CachedSurface::IsSurfaceFullyInvalid
2019-02-14 11:44:46 -05:00
8f2c35d7b6
Merge pull request #4614 from wwylele/nwm-uds-global
...
NWM_UDS: move states into the class
2019-02-14 11:44:28 -05:00
1f38c53d8f
Merge pull request #4508 from B3n30/dsp_aac
...
CoreAudio::HLE: Add FFmpeg/WMF AAC decoder
2019-02-14 11:44:09 -05:00
a4ba35fe3a
audio_core: hle: mf: lint
2019-02-13 15:15:11 -07:00
671ac441e9
audio_core: hle: mf: move transform initializer to ctor
2019-02-13 14:32:14 -07:00
6178cc08b7
audio_core: hle: mf: conform to RAII as possible
2019-02-13 14:08:34 -07:00
fc6e33d812
video_core: Sort predicate order to have semantically positive value first
2019-02-13 21:06:37 +01:00
e5495e541d
citra_qt/config: backport minor changes from yuzu
2019-02-13 21:06:37 +01:00
59dbc72e7b
configure_dialog: backport minor changes from yuzu
2019-02-13 21:06:24 +01:00
d63acfc1e9
video_core: add workarounds to enable GLES support
...
video_core: shorten GetGLSLVersionString
video_core: make GLES version and extensions consistent
video_core: move some logic to LoadShader
video_core: deduplicate fragment shader precision specifier
2019-02-12 16:57:18 -06:00
1995e8ff32
service/soc_u: address review comments
2019-02-10 18:49:18 +08:00
f0e041e27a
audio_core: hle: mf: correctly handle stream change
2019-02-09 16:49:48 -07:00
d90f733330
video_core: improve efficiency of CachedSurface::IsSurfaceFullyInvalid
2019-02-09 17:33:18 -06:00
01e0902fa4
audio_core: hle: mf: fix a memory accessing issue
2019-02-09 13:55:54 -07:00
6281660844
audio_core: hle: mf: address yet another batch of reviews
2019-02-09 13:55:42 -07:00
1f31f23b33
Merge pull request #4631 from tgsm/game-list-demos
...
citra_qt: show demos on game list
2019-02-09 14:15:59 +01:00
08bf899d70
service/soc_u: Implement getaddrinfo and getnameinfo
2019-02-09 20:12:09 +08:00
ab1f47ed15
audio_core: hle: mf: make DetectMediaType return a struct
2019-02-09 11:57:36 +01:00
168f2ee79a
audio_core: mf: make initialize function return smart pointer
2019-02-09 11:57:36 +01:00
c91f5029ff
audio_core: hle: mf: fix a regression...
...
... where the sample copying logic is incorrect due to the wrong usage
of `std::array`
2019-02-09 11:57:36 +01:00
6332e57069
audio_core: hle: mf: return values as std::optional
2019-02-09 11:57:36 +01:00
25fa10327b
audio_core: hle: mf: use object proxy
2019-02-09 11:57:36 +01:00
26b3b41788
audio_core: hle: mf: wrap enum in class
2019-02-09 11:57:36 +01:00
633f02b9b2
audio_core: hle: mf: avoid name conflicts
2019-02-09 11:57:36 +01:00
452ac7b874
audio_core: hle: mf: use more enum
2019-02-09 11:57:36 +01:00
be764e4f88
audio_core: hle: mf: multiple fixes...
...
... more smart pointers and re-arrange code
2019-02-09 11:57:36 +01:00
BreadFish64
Weiyi Wang
Dimitri A
bunnei
James Rowe
fearlessTobi
Pengfei Zhu
Lioncash
tgsm
liushuyu
ReinUsesLisp
SachinVin