1
0
Fork 0

core: Make converting constructors explicit where applicable

Avoids unwanted implicit conversions. Thankfully, given the large amount
of cleanup in past PRs, only this tiny amount is left over to cover.
This commit is contained in:
Lioncash 2018-07-23 23:10:48 -04:00 committed by zhupengfei
parent 4a3c4f5f67
commit 661f7bbcfd
4 changed files with 4 additions and 4 deletions

View File

@ -222,7 +222,7 @@ protected:
* @param max_sessions Maximum number of sessions that can be * @param max_sessions Maximum number of sessions that can be
* connected to this service at the same time. * connected to this service at the same time.
*/ */
ServiceFramework(const char* service_name, u32 max_sessions = DefaultMaxSessions) explicit ServiceFramework(const char* service_name, u32 max_sessions = DefaultMaxSessions)
: ServiceFrameworkBase(service_name, max_sessions, Invoker) {} : ServiceFrameworkBase(service_name, max_sessions, Invoker) {}
/// Registers handlers in the service. /// Registers handlers in the service.

View File

@ -189,7 +189,7 @@ private:
u32 entryPoint; u32 entryPoint;
public: public:
ElfReader(void* ptr); explicit ElfReader(void* ptr);
u32 Read32(int off) const { u32 Read32(int off) const {
return base32[off >> 2]; return base32[off >> 2];

View File

@ -84,7 +84,7 @@ constexpr u32 MakeMagic(char a, char b, char c, char d) {
/// Interface for loading an application /// Interface for loading an application
class AppLoader : NonCopyable { class AppLoader : NonCopyable {
public: public:
AppLoader(FileUtil::IOFile&& file) : file(std::move(file)) {} explicit AppLoader(FileUtil::IOFile&& file) : file(std::move(file)) {}
virtual ~AppLoader() {} virtual ~AppLoader() {}
/** /**

View File

@ -32,7 +32,7 @@ public:
* Recorder constructor * Recorder constructor
* @param initial_state Initial recorder state * @param initial_state Initial recorder state
*/ */
Recorder(const InitialState& initial_state); explicit Recorder(const InitialState& initial_state);
/// Finish recording of this Citrace and save it using the given filename. /// Finish recording of this Citrace and save it using the given filename.
void Finish(const std::string& filename); void Finish(const std::string& filename);