add texture dumping as a config entry

externals/fmt

@@ -1 +1 @@
-Subproject commit 4b8f8fac96a7819f28f4be523ca10a2d5d8aaaf2
+Subproject commit 7512a55aa3ae309587ca89668ef9ec4074a51a1f

externals/lodepng/lodepng

@@ -0,0 +1 @@
+Subproject commit 31d9704fdcca0b68fb9656d4764fa0fb60e460c2

src/citra/config.cpp

@@ -162,6 +162,9 @@ void Config::ReadValues() {
     Settings::values.custom_bottom_bottom =
         static_cast<u16>(sdl2_config->GetInteger("Layout", "custom_bottom_bottom", 480));
 
+    // Utility
+    Settings::values.dump_textures = sdl2_config->GetBoolean("Utility", "dump_textures", false);
+
     // Audio
     Settings::values.enable_dsp_lle = sdl2_config->GetBoolean("Audio", "enable_dsp_lle", false);
     Settings::values.enable_dsp_lle_multithread =

src/citra/default_ini.h

@@ -178,6 +178,10 @@ custom_bottom_bottom =
 # 0 (default): Top Screen is prominent, 1: Bottom Screen is prominent
 swap_screen =
 
+# Dumps textures as PNG to dump/textures/[Title ID]/.
+# 0 (default): Off, 1: On
+dump_textures =
+
 [Audio]
 # Whether or not to enable DSP LLE
 # 0 (default): No, 1: Yes

src/citra_qt/configuration/config.cpp

@@ -230,6 +230,13 @@ void Config::ReadControlValues() {
     qt_config->endGroup();
 }
 
+void Config::ReadUtilityValues() {
+
+    qt_config->beginGroup("Utility");
+    Settings::values.dump_textures = ReadSetting("dump_textures", false).toBool();
+    qt_config->endGroup();
+}
+
 void Config::ReadCoreValues() {
     qt_config->beginGroup(QStringLiteral("Core"));
 
@@ -693,6 +700,14 @@ void Config::SaveControlValues() {
     qt_config->endGroup();
 }
 
+void Config::SaveUtilityValues() {
+    qt_config->beginGroup("Utility");
+
+    WriteSetting("dump_textures", Settings::values.dump_textures, false);
+
+    qt_config->endGroup();
+}
+
 void Config::SaveCoreValues() {
     qt_config->beginGroup(QStringLiteral("Core"));
 

src/citra_qt/configuration/config.h

@@ -42,6 +42,7 @@ private:
     void ReadUIGameListValues();
     void ReadUILayoutValues();
     void ReadUpdaterValues();
+    void ReadUtilityValues();
     void ReadWebServiceValues();
 
     void SaveValues();
@@ -62,6 +63,7 @@ private:
     void SaveUIGameListValues();
     void SaveUILayoutValues();
     void SaveUpdaterValues();
+    void SaveUtilityValues();
     void SaveWebServiceValues();
 
     QVariant ReadSetting(const QString& name) const;

src/citra_qt/configuration/configure_graphics.cpp

@@ -87,6 +87,7 @@ void ConfigureGraphics::ApplyConfiguration() {
     Settings::values.layout_option =
         static_cast<Settings::LayoutOption>(ui->layout_combobox->currentIndex());
     Settings::values.swap_screen = ui->swap_screen->isChecked();
+    Settings::values.dump_textures = ui->toggle_dump_textures->isChecked();
     Settings::values.bg_red = static_cast<float>(bg_color.redF());
     Settings::values.bg_green = static_cast<float>(bg_color.greenF());
     Settings::values.bg_blue = static_cast<float>(bg_color.blueF());

src/citra_qt/configuration/configure_graphics.ui

@@ -328,6 +328,25 @@
      </layout>
     </widget>
    </item>
+   <item>
+    <widget class="QGroupBox" name="utilityBox">
+     <property name="title">
+      <string>Utility</string>
+     </property>
+     <layout class="QVBoxLayout" name="verticalLayout_4">
+      <item>
+       <widget class="QCheckBox" name="toggle_dump_textures">
+        <property name="toolTip">
+         <string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;Dump textures to PNG files.&lt;/p&gt;&lt;p&gt;Textures are dumped to dump/textures/[Title ID]/.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
+        </property>
+        <property name="text">
+         <string>Dump Textures (Hardware Renderer only)</string>
+        </property>
+       </widget>
+      </item>
+     </layout>
+    </widget>
+   </item>
    <item>
     <spacer name="verticalSpacer">
      <property name="orientation">

src/core/settings.cpp

@@ -87,6 +87,7 @@ void LogSettings() {
     LogSetting("Stereoscopy_Factor3d", Settings::values.factor_3d);
     LogSetting("Layout_LayoutOption", static_cast<int>(Settings::values.layout_option));
     LogSetting("Layout_SwapScreen", Settings::values.swap_screen);
+    LogSetting("Utility_DumpTextures", Settings::values.dump_textures);
     LogSetting("Audio_EnableDspLle", Settings::values.enable_dsp_lle);
     LogSetting("Audio_EnableDspLleMultithread", Settings::values.enable_dsp_lle_multithread);
     LogSetting("Audio_OutputEngine", Settings::values.sink_id);

src/core/settings.h

@@ -170,6 +170,8 @@ struct Values {
     bool filter_mode;
     std::string pp_shader_name;
 
+    bool dump_textures;
+
     // Audio
     bool enable_dsp_lle;
     bool enable_dsp_lle_multithread;