1
0
Fork 0

yuzu/CMakeLists: Disable implicit QString->QUrl conversions

Enforces the use of the proper URL resolution functions. e.g.

url = some_local_path_string;

should actually be:

url = QUrl::fromLocalPath(some_local_path_string);

etc.

This makes it harder to cause bugs when operating with both strings and
URLs at the same time.
This commit is contained in:
Lioncash 2019-06-05 16:05:34 -04:00 committed by fearlessTobi
parent 3d2e6165d3
commit e88a9ace8d
1 changed files with 3 additions and 0 deletions

View File

@ -234,6 +234,9 @@ target_compile_definitions(citra-qt PRIVATE
# Disable unsafe overloads of QProcess' start() function. # Disable unsafe overloads of QProcess' start() function.
-DQT_NO_PROCESS_COMBINED_ARGUMENT_START -DQT_NO_PROCESS_COMBINED_ARGUMENT_START
# Disable implicit QString->QUrl conversions to enforce use of proper resolving functions.
-DQT_NO_URL_CAST_FROM_STRING
) )
if (CITRA_ENABLE_COMPATIBILITY_REPORTING) if (CITRA_ENABLE_COMPATIBILITY_REPORTING)