Feature Report: GLVTX (#77)

* Initial work on glvtx post

* Rough draft v2

* Add sidebyside layout. Add mp4 video support. Address review comments

* Update the graphic for GPU usage. Add a better break for the summary

* Add banner. Various small fixes. Removed GS section. Still no graphs >.<

* Address speeeeeling mistakes. Add missing graphs

* Update forum id

site/content/entry/improvements-to-hardware-renderer.md

@@ -0,0 +1,188 @@
++++
+date = "2018-02-28T17:00:00-04:00"
+title = "Hardware Renderer Updates"
+tags = [ "feature-update" ]
+author = "jroweboy"
+banner = "hardware-shaders.png"
+forum = 11831
++++
+
+## Cut to the chase, how fast is this?
+
+{{< 
+    sidebyside "gifv" "/images/entry/improvements-to-hardware-renderer/"
+    "before.mp4=Before"
+    "after.mp4=After" 
+>}}
+
+<h4 style="text-align: center;">Realtime performance comparison with framelimit off</h4>
+<!--more-->
+Very fast. Test results across various computers show that it **averages out to be a 2x speed boost.**
+With the new update, Citra will use much more of your GPU, removing some of the dependence on a CPU with high single-core performance.
+As always, the actual difference will vary by game and by your specific hardware configuration!
+In celebration of this massive improvement, we wanted to share some of the successes and struggles we've had over the years with the hardware renderer.
+
+## Brief History of Citra's Rendering Backends
+
+Back in early 2015, Citra was still a young emulator, and had just barely started displaying graphics for the first time.
+In a momentous occasion, Citra displayed 3D graphics from a commercial game, Legend of Zelda: Ocarina of Time 3D
+
+{{< figure type="youtube" id="sYukdJam6gk" title="It took a year from when citra started to get to this point" >}}
+
+This engineering feat was thanks to the hard work of many contributors in both the emulator scene and the 3ds hacking scene, who worked tirelessly to reverse engineer the 3DS GPU, a chip called the PICA200.
+But not even a few months later, Citra was able to play the game at full speed! 
+
+{{< figure type="youtube" id="Hj8sPsB5qXQ" title="Good thing that shield flashing bug still isn't around" >}}
+
+Why is there such a major difference in speed from the first and the second video?
+The speed difference boils down to how the 3DS GPU is being emulated.
+The first video is showing off the software renderer, which emulates the PICA200 by using your computer's CPU.
+On the other hand, the second video is using the OpenGL hardware renderer, which emulates the PICA200 by using your computer's GPU.
+From those videos, using your GPU to emulate the 3DS GPU is the clear winner when it comes to speed!
+However, it's not all sunshine and daisies; there's always tradeoffs in software development.
+
+## Challenges in the Hardware Renderer
+
+Earlier it was stated that the OpenGL hardware renderer was emulating the PICA200 by using the GPU instead of the CPU, and ... that's only partially true.
+As it stands, only a portion of the PICA200 emulation is running on the GPU; most of it is running on the CPU!
+To understand why, we need to dive a little deeper into the difference between CPUs and modern GPUs.
+
+{{< figure src="/images/entry/improvements-to-hardware-renderer/gpu_pipeline_before.png" 
+    title="The green shaded portions are what Citra emulates using the GPU. For a hardware renderer, Citra isn't using the GPU much!" 
+>}}
+
+As a general rule of thumb, CPUs are fast at computing general tasks, while GPUs are *blazing fast* at computing very specific tasks.
+Whenever the tasks the PICA200 can perform matches up with tasks you can do on a GPU using OpenGL, everything is fast and everyone is happy!
+That said, we tend to run into edge cases that the PICA200 supports, but frankly, OpenGL is not well suited to support.
+This leads to cases where sometimes we just have to [live with minor inaccuracies as a tradeoff for speed.](https://github.com/citra-emu/citra/pull/2697)
+
+{{< figure src="/images/entry/improvements-to-hardware-renderer/outline_bug.png" title="The infamous Pokémon outlines bug was one such example of something that OpenGL just doesn't handle well" >}}
+
+OpenGL is also great for emulator developers because it's a cross-platform standard for graphics, with support for all major desktop platforms.
+But because OpenGL is just a specification, every vendor is left up to their own to make their drivers support the specification for every individual platform.
+This means performance and features can vary widely between operating systems, graphics driver, and the physical graphics card.
+As you might have guessed, this leads to some [OS specific bugs that are very hard to track down](https://github.com/citra-emu/citra/issues/2416).
+In the linked issue, only on Mac OSX, Citra would leak memory from the hardware renderer.
+We traced it back to how textures were juggled between the 3DS memory and the host GPU, but we don't have many developers that use Mac, so we never did find the root cause.
+For a little bit of good news, **this is fixed in the latest nightly**, but only because the entire texture handling code was rewritten!
+
+## Moving Forward with the Hardware Renderer: Cleaning up Texture Forwarding
+
+Despite the issues mentioned above, OpenGL has been a fair choice for a hardware renderer, and [phantom](https://github.com/phanto-m/) has been hard at work improving the renderer.
+Their first major contribution was a massive, [complete rewrite](https://github.com/citra-emu/citra/pull/3281) of the [texture forwarding support](https://citra-emu.org/entry/texture-forwarding-brings-hd-output-to-citra/) that was added back in 2016.
+The new texture forwarding code increases the speed of many games, and fixes upscaled rendering in some other games as well.
+
+{{< figure src="/images/entry/improvements-to-hardware-renderer/metroid_before.png"
+    title="Metroid: Samus Returns heavily used a PICA200 feature that had a comment `// TODO: implement this` in the hardware renderer" >}}
+{{< figure src="/images/entry/improvements-to-hardware-renderer/metroid_after.png"
+    title="Writing that missing method fixed upscaling while making the game much faster" >}}
+
+Whenever a texture is used in the hardware renderer, the hardware renderer will try to use a copy of the texture already in the GPU memory, but if that fails, it has to reload the texture from the emulated 3DS memory.
+This is called a texture upload, and it's slow for a good reason.
+The communication between CPU and GPU is optimized for large amounts of data transferred, but as a tradeoff, it's not very fast.
+This works great for PC games, where you know all the textures you want to upload ahead of time and can send them in one large batch, but ends up hurting performance for Citra since we can't know in advance when the emulated game will do something that requires a texture upload.
+
+The texture forwarding rewrite increases the speed of many games by adding in new checks to avoid this costly synchronization of textures between emulated 3DS memory and the host GPU memory.
+Additionally, the new texture forwarding can avoid even more texture uploads by copying the data from any compatible locations.
+As an extension of this feature, [phantom](https://github.com/phanto-m/) went the extra mile and fixed Pokémon outlines as well!
+Pokémon games would draw the outline by reinterpreting the depth and stencil buffer as an RGBA texture, using the value for the red color to draw the outline.
+Sadly, OpenGL doesn't let you just reinterpret like that, meaning we needed to be more creative.
+[phantom](https://github.com/phanto-m/) worked around this limitation by copying the data into a [Pixel Buffer Object](https://www.khronos.org/opengl/wiki/Pixel_Buffer_Object), and running a shader to extract the data into a [Buffer Texture](https://www.khronos.org/opengl/wiki/Buffer_Texture) which they could use to draw into a new texture with the correct format.
+
+{{< figure src="/images/entry/improvements-to-hardware-renderer/outline_upscaled.png" title="The long standing issue is gone!" >}}
+
+The texture forwarding rewrite has been battle tested in Citra Canary for the last 2 months, during which time we fixed over 20 reported issues.
+We are happy to announce that it's now merged into the master branch, so please enjoy the new feature in the latest nightly build!
+
+## The Big News You've Been Waiting For
+
+A few paragraphs ago, we mentioned that Citra's hardware renderer did most of the emulation on the CPU, and only some of it on the GPU.
+The big news today is Citra now does the **entire GPU emulation on the host GPU**.
+
+{{< figure src="/images/entry/improvements-to-hardware-renderer/gpu_pipeline_after.png" title="Just look at all that green for each pipeline stage!" >}}
+
+With an unbelievable amount of effort, [phantom](https://github.com/phanto-m/) has done it again.
+Moving the rest of the PICA200 emulation to the GPU was always a sort of "white whale" for Citra.
+We knew it would make things fast, but the sheer amount of effort required to make this happen scared off all those who dared attempt it.
+But before we get into why this was so challenging, let's see some real performance numbers!
+
+#### All testing was done with the following settings: 4x Internal Resolution, Accurate Hardware Shaders On, Framelimit Off
+
+{{< figure size="large" src="/images/entry/improvements-to-hardware-renderer/gpu_vendor_graph.png" title="Dedicated GPUs saw the biggest improvement" >}}
+
+{{< figure size="large" src="/images/entry/improvements-to-hardware-renderer/midend_gpu_graph.png" title="Mid-High end GPUs tend to be fast" >}}
+
+{{< figure size="large" src="/images/entry/improvements-to-hardware-renderer/lowend_gpu_graph.png" title="Low-Mid end GPUs are just a bit fast" >}}
+
+{{< figure size="large" src="/images/entry/improvements-to-hardware-renderer/pokemon_beforeafter_graph.png" title="According to telemetry data, Pokémon is the most played game on Citra" >}}
+
+{{< figure size="large" src="/images/entry/improvements-to-hardware-renderer/mh_beforeafter_graph.png" title="But Monster Hunter is catching up in playtime" >}}
+
+## Obstacles to Emulating the PICA200 on a GPU
+
+### Making Functions Out of GOTOs
+
+It's likely that the game developers for the 3DS didn't have to write PICA200 GPU assembly, but when emulating the PICA200, all Citra can work with is a commandlist and a stream of PICA200 opcodes.
+While the developers probably wrote in a high level shader language that supports functions, when the shaders are compiled, most of that goes away.
+The PICA200 supports barebones `CALL`, `IF`, and `LOOP` operations, but also supports an arbitrary `JMP` that can go to any address.
+Translating PICA200 shaders into GLSL (OpenGL Shader Language) means that you'll have to be prepared to rewrite every arbitrary `JMP` without using a `goto` as GLSL doesn't support them.
+
+[phantom](https://github.com/phanto-m/) assumed the worst when they originally translated PICA200 shaders into GLSL and wrote a monstrous switch statement that would have a case for every jump target and act as a PICA200 shader interpreter.
+This worked, but proved to be slower than the software renderer!
+Now that [phantom](https://github.com/phanto-m/) knew it was possible, and they had some data about how the average PICA200 shader looked, they took to rewrite it with the goal to make it fast.
+While the shaders could theoretically be very unruly and hard to convert, almost all the shaders were well behaved, presumably because they are compiled from a higher level language.
+This time around, [phantom](https://github.com/phanto-m/) generated native GLSL functions wherever possible by analyzing the control flow of the instructions, and the results are much prettier and faster.
+Armed with the new knowledge, [phantom](https://github.com/phanto-m/) rewrote the conversion a third time, and optimized the generated shaders even further.
+What started off slower than the software renderer ended up being the massive performance boost we have today!
+
+### Multiplication Shouldn't Be This Slow
+
+When converting from PICA200 shaders into GLSL, there are a few PICA200 opcodes that should just match up without any issues.
+Addition, subtraction, and multiplication should ... wait. Where did this issue come from?
+
+{{< sidebyside "image" "/images/entry/improvements-to-hardware-renderer/"
+    "accurate_mul_on.png=On: I don't see any issue..." 
+    "accurate_mul_off.png=Off: Oh. Well maybe Eren looks better this way" >}}
+
+It turns out that the PICA200 multiplication opcode has a few edge cases that don't impact a large majority of games, and leads to some hilarious results in others.
+On the PICA200, `infinity * 0 = 0` but in OpenGL `infinity * 0 = NaN` and this can't be configured.
+In the generated GLSL shaders, [phantom](https://github.com/phanto-m/) emulates this behavior by making a function call instead of a simple multiplication.
+
+```glsl
+vec4 sanitize_mul(vec4 lhs, vec4 rhs) {
+    vec4 product = lhs * rhs;
+    return mix(product, mix(mix(vec4(0.0), product, isnan(rhs)), product, isnan(lhs)), isnan(product));
+}
+```
+
+Alas, it's a performance penalty to use a function everywhere instead of regular multiplication.
+On weaker GPUs, we noticed the penalty is so severe, we actually made this configurable.
+The whole point of a hardware renderer is to be fast, so eating a penalty when only a small handful of games need this level of accuracy would be regrettable.
+You can turn off this feature in the settings by deselecting "Accurate Hardware Shader" and get a noticeable performance boost, but be aware that a few games will break in strange ways!
+
+### Finding Bugs and Working Overtime
+
+We were very excited to launch this feature when [phantom](https://github.com/phanto-m/) declared that it was ready; results from user testing were entirely positive, and the performance improvements were unbelievable, but one thing stood in the way.
+No one had yet tested to see if it worked on AMD GPUs.
+We called for our good friend [JMC47](https://dolphin-emu.org/blog/authors/JMC47/) to break out the AMD card he uses for testing Dolphin, and Citra crashed the driver! Oh no!
+
+From [JMC47](https://dolphin-emu.org/blog/authors/JMC47/)'s time in Dolphin, he's made a few friends here and there, and he found someone willing to investigate.
+After a few gruelling weeks, [JonnyH](https://github.com/JonnyH) was able to narrow down what the problem is, and luckily it's not a bug in the AMD drivers.
+It turns out that it's a bug in the GL specification, or more precisely, the exact issue is ambiguous wording.
+[glDrawRangeElementsBaseVertex](https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glDrawRangeElementsBaseVertex.xhtml) states that the indices should be a pointer, but doesn't say whether the pointer should be to CPU memory or GPU memory.
+Citra passed a pointer to CPU memory without a second thought, as both Nvidia and Intel drivers seemed fine with it, but AMD drivers are strict.
+As a workaround, [phantom](https://github.com/phanto-m/) added support for streaming storage buffers, which allows Citra to work with the data on the CPU and sync it with the GPU when it's time to draw.
+
+It's a challenge to support all of the many GPUs out there, and we've put in so much work to ensure that this new feature will run on as many hardware configurations as possible.
+But it's very likely that there will be some GPUs that do not fully support the new hardware renderer, and so we added another option in the Configuration to allow users to turn this feature off entirely.
+Simply changing the "Shader Emulation" from "GPU" to "CPU" will revert to using the same old CPU shaders that Citra was using before.
+
+{{< figure src="/images/entry/improvements-to-hardware-renderer/renderer_settings.png" title="Check out the new Renderer settings in the Graphics tab" >}}
+
+## What's next
+
+While today marks a victory for fast emulation, we always have room for improvement.
+As explained earlier in the article, getting OpenGL to work consistently across all platforms and GPUs is surprisingly challenging, so be ready for bugs.
+This isn't the end for the hardware renderer, but a wonderful boost to one of Citra's more complicated features.
+There is always something more that can be done to make the hardware renderer even faster and more accurate (contributions welcome!), but in the meantime, we hope you enjoy playing even more games at full speed!
+

site/themes/citra-bs-theme/layouts/shortcodes/figure.html

@@ -1,5 +1,15 @@
-<figure>
+{{ $type := index .Params "type" }}
-    <img src="{{.Get "src"}}" {{ with .Get "alt" }}alt="{{ . }}"{{ end }} />
+
+<figure {{ if eq (.Get "size") "large" }}style="padding: 20px 0px;"{{ end }}>
+    {{ if eq $type "youtube"  }}
+        {{/* copy pasted from hugo source code */}}
+        <div {{ if .Get "class" }}class="{{ .Get "class" }}"{{ else }}style="position: relative; padding-bottom: 56.25%; padding-top: 30px; height: 0; overflow: hidden;"{{ end }}>
+            <iframe src="//www.youtube.com/embed/{{ .Get "id" }}?{{ with .Get "autoplay" }}{{ if eq . "true" }}autoplay=1{{ end }}{{ end }}"
+            {{ if not (.Get "class") }}style="position: absolute; top: 0; left: 0; width: 100%; height: 100%;" {{ end }}allowfullscreen frameborder="0" title="YouTube Video"></iframe>
+        </div>
+    {{ else }}
+        <img src="{{.Get "src"}}" {{ with .Get "alt" }}alt="{{ . }}"{{ end }} />
+    {{ end }}
     {{ with .Get "title" }}
     <figcaption>
         <h4>

site/themes/citra-bs-theme/layouts/shortcodes/gifv.html

@@ -0,0 +1,13 @@
+<figure>
+    <video preload="auto" autoplay="autoplay" muted="muted" loop="loop" webkit-playsinline="">
+        <source src="{{ .Get "src" }}" type="video/mp4">
+        Your browser doesn't support mp4 video. :(
+    </video>
+    {{ with .Get "title" }}
+    <figcaption>
+        <h4>
+            {{ . }}
+        </h4>
+    </figcaption>
+    {{ end }}
+</figure>

site/themes/citra-bs-theme/layouts/shortcodes/sidebyside.html

@@ -0,0 +1,32 @@
+{{/* USAGE: {{< sidebyside "gifv" "/path/to/src" "file1=caption" "file2=caption" >}} */}}
+
+{{ $type := index .Params 0 }}
+{{ $path := index .Params 1 }}
+{{ $figures := after 2 .Params }}
+
+<div class="container" style="width: 100%;">
+    {{ $.Scratch.Set "size" (div 12 (len $figures)) }}
+    {{ range $figure := $figures }}
+        {{ $.Scratch.Set "src" (index (split $figure "=") 0) }}
+        {{ $.Scratch.Set "title" (index (split $figure "=") 1) }}
+        <div class="theme-table-image col-sm-{{ $.Scratch.Get "size" }}">
+            <figure style="padding: 0px;">
+                {{ if eq $type "gifv" }}
+                    <div class="embed-responsive embed-responsive-4by3">
+                        <video class="embed-responsive-item" preload="auto" autoplay="autoplay" muted="muted" loop="loop" webkit-playsinline="">
+                            <source src="{{ printf "%s%s" $path ($.Scratch.Get "src") }}" type="video/mp4">
+                            Your browser doesn't support mp4 video. :(
+                        </video>
+                    </div>
+                {{ else if eq $type "image" }}
+                    <img src="{{ printf "%s%s" $path ($.Scratch.Get "src") }}" alt="{{ $.Scratch.Get "title" }}" />
+                {{ end }}
+                <figcaption>
+                    <h4>
+                        {{ $.Scratch.Get "title" }}
+                    </h4>
+                </figcaption>
+            </figure>
+        </div>
+    {{ end }}
+</div>