telemetry_json: Take std::string parameters by value
Taking them by const reference isn't advisable here, because it means the std::move calls were doing nothing and we were always copying the std::string instances.
This commit is contained in:
parent
c9013c481a
commit
8747d93f6a
|
@ -8,8 +8,7 @@
|
|||
|
||||
namespace WebService {
|
||||
|
||||
TelemetryJson::TelemetryJson(const std::string& host, const std::string& username,
|
||||
const std::string& token)
|
||||
TelemetryJson::TelemetryJson(std::string host, std::string username, std::string token)
|
||||
: host(std::move(host)), username(std::move(username)), token(std::move(token)) {}
|
||||
TelemetryJson::~TelemetryJson() = default;
|
||||
|
||||
|
|
|
@ -19,7 +19,7 @@ namespace WebService {
|
|||
*/
|
||||
class TelemetryJson : public Telemetry::VisitorInterface {
|
||||
public:
|
||||
TelemetryJson(const std::string& host, const std::string& username, const std::string& token);
|
||||
TelemetryJson(std::string host, std::string username, std::string token);
|
||||
~TelemetryJson();
|
||||
|
||||
void Visit(const Telemetry::Field<bool>& field) override;
|
||||
|
|
Reference in New Issue