citra-emu
/
citra
Archived
1
0
Fork 0
Code

citra_qt/multiplayer: three minor fixes 

* Fix the issue that icons for owned games do not appear

* Fix the issue where you would double click on a room and connect to another

* Fix the issue that room name and nickname does not have size limitation
This commit is contained in:
zhupengfei 2018-09-05 22:26:45 +08:00
parent 05118a2326
commit cdd3bd72e5
No known key found for this signature in database
GPG Key ID: 85B82A3E62174206
2 changed files with 25 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/citra_qt/multiplayer/lobby.cpp
View File

@ -21,13 +21,24 @@
Lobby::Lobby(QWidget* parent, QStandardItemModel* list, Lobby::Lobby(QWidget* parent, QStandardItemModel* list,
std::shared_ptr<Core::AnnounceMultiplayerSession> session) std::shared_ptr<Core::AnnounceMultiplayerSession> session)
: QDialog(parent, Qt::WindowTitleHint | Qt::WindowCloseButtonHint | Qt::WindowSystemMenuHint), : QDialog(parent, Qt::WindowTitleHint | Qt::WindowCloseButtonHint | Qt::WindowSystemMenuHint),
ui(std::make_unique<Ui::Lobby>()), announce_multiplayer_session(session), game_list(list) { ui(std::make_unique<Ui::Lobby>()), announce_multiplayer_session(session) {
ui->setupUi(this); ui->setupUi(this);
// setup the watcher for background connections // setup the watcher for background connections
watcher = new QFutureWatcher<void>; watcher = new QFutureWatcher<void>;
model = new QStandardItemModel(ui->room_list); model = new QStandardItemModel(ui->room_list);
// Create a proxy to the game list to get the list of games owned
game_list = new QStandardItemModel;
for (int i = 0; i < list->rowCount(); i++) {
auto parent = list->item(i, 0);
for (int j = 0; j < parent->rowCount(); j++) {
game_list->appendRow(parent->child(j)->clone());
}
}
proxy = new LobbyFilterProxyModel(this, game_list); proxy = new LobbyFilterProxyModel(this, game_list);
proxy->setSourceModel(model); proxy->setSourceModel(model);
proxy->setDynamicSortFilter(true); proxy->setDynamicSortFilter(true);
@ -114,20 +125,21 @@ void Lobby::OnJoinRoom(const QModelIndex& source) {
return; return;
} }
QModelIndex connection_index = proxy->index(index.row(), Column::HOST);
const std::string nickname = ui->nickname->text().toStdString();
const std::string ip =
proxy->data(connection_index, LobbyItemHost::HostIPRole).toString().toStdString();
int port = proxy->data(connection_index, LobbyItemHost::HostPortRole).toInt();
// attempt to connect in a different thread // attempt to connect in a different thread
QFuture<void> f = QtConcurrent::run([&, password] { QFuture<void> f = QtConcurrent::run([nickname, ip, port, password] {
if (auto room_member = Network::GetRoomMember().lock()) { if (auto room_member = Network::GetRoomMember().lock()) {
QModelIndex connection_index = proxy->index(index.row(), Column::HOST);
const std::string nickname = ui->nickname->text().toStdString();
const std::string ip =
proxy->data(connection_index, LobbyItemHost::HostIPRole).toString().toStdString();
int port = proxy->data(connection_index, LobbyItemHost::HostPortRole).toInt();
room_member->Join(nickname, ip.c_str(), port, 0, Network::NoPreferredMac, password); room_member->Join(nickname, ip.c_str(), port, 0, Network::NoPreferredMac, password);
} }
}); });
watcher->setFuture(f); watcher->setFuture(f);
// and disable widgets and display a connecting while we wait
QModelIndex connection_index = proxy->index(index.row(), Column::HOST); // TODO(jroweboy): disable widgets and display a connecting while we wait
// Save settings // Save settings
UISettings::values.nickname = ui->nickname->text(); UISettings::values.nickname = ui->nickname->text();

8
src/citra_qt/multiplayer/validation.h
View File

@ -28,12 +28,12 @@ public:
} }
private: private:
/// room name can be alphanumeric and " " "_" "." and "-" /// room name can be alphanumeric and " " "_" "." and "-" and must have a size of 4-20
QRegExp room_name_regex = QRegExp("^[a-zA-Z0-9._- ]+$"); QRegExp room_name_regex = QRegExp("^[a-zA-Z0-9._- ]{4,20}$");
QRegExpValidator room_name; QRegExpValidator room_name;
/// nickname can be alphanumeric and " " "_" "." and "-" /// nickname can be alphanumeric and " " "_" "." and "-" and must have a size of 4-20
QRegExp nickname_regex = QRegExp("^[a-zA-Z0-9._- ]+$"); QRegExp nickname_regex = QRegExp("^[a-zA-Z0-9._- ]{4,20}$");
QRegExpValidator nickname; QRegExpValidator nickname;
/// ipv4 address only /// ipv4 address only