Archived
1
0
This repository has been archived on 2024-03-23. You can view files and clone it, but cannot push or open issues or pull requests.
citra/src/common/logging
yzct12345 3641b9891d logging: Simplify and make thread-safe
This simplifies the logging system.

This also fixes some lost messages on startup.

The simplification is simple. I removed unused functions and moved most things in the .h to the .cpp. I replaced the unnecessary linked list with its contents laid out as three member variables. Anything that went through the linked list now directly accesses the backends. Generic functions are replaced with those for each specific use case and there aren't many. This change increases coupling but we gain back more KISS and encapsulation.

With those changes it was easy to make it thread-safe. I just removed the mutex and turned a boolean atomic. I was planning to use this thread-safety in my next PR about stacktraces. It was actually async-signal-safety at first but I ended up using a different approach. Anyway getting rid of the linked list is important for that because have the list of backends constantly changing complicates things.
2023-06-30 12:15:51 +03:00
..
backend.cpp logging: Simplify and make thread-safe 2023-06-30 12:15:51 +03:00
backend.h logging: Simplify and make thread-safe 2023-06-30 12:15:51 +03:00
filter.cpp logging: Simplify and make thread-safe 2023-06-30 12:15:51 +03:00
filter.h logging: Simplify and make thread-safe 2023-06-30 12:15:51 +03:00
formatter.h Upgrade codebase to C++ 20 + fix warnings + update submodules (#6115) 2022-09-21 18:36:12 +02:00
log.h common: logging: Restructure backend code 2023-06-30 12:15:51 +03:00
text_formatter.cpp common: logging: Restructure backend code 2023-06-30 12:15:51 +03:00
text_formatter.h common/log: Move Log namespace into the Common namespace 2023-06-30 12:15:51 +03:00
types.h common: logging: Restructure backend code 2023-06-30 12:15:51 +03:00