settings_setting: Fix errors
ToString didn't have a constexpr if statement where needed. Canonicalize missed an else, causing unreachable code error on MSVC.
This commit is contained in:
parent
04d4b6ab80
commit
4903f40efe
|
@ -142,7 +142,7 @@ protected:
|
|||
return value_.has_value() ? std::to_string(*value_) : "none";
|
||||
} else if constexpr (std::is_same<Type, bool>()) {
|
||||
return value_ ? "true" : "false";
|
||||
} else if (std::is_same<Type, AudioEngine>()) {
|
||||
} else if constexpr (std::is_same<Type, AudioEngine>()) {
|
||||
return CanonicalizeEnum(value_);
|
||||
} else {
|
||||
return std::to_string(static_cast<u64>(value_));
|
||||
|
@ -222,9 +222,10 @@ public:
|
|||
[[nodiscard]] std::string constexpr Canonicalize() const override {
|
||||
if constexpr (std::is_enum<Type>::value) {
|
||||
return CanonicalizeEnum(this->GetValue());
|
||||
}
|
||||
} else {
|
||||
return ToString(this->GetValue());
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns the save preference of the setting i.e. when saving or reading the setting from a
|
||||
|
|
Reference in New Issue