Review comments - part 5
This commit is contained in:
parent
ac06105dfe
commit
e4daf4bee5
|
@ -3,6 +3,7 @@
|
||||||
// Refer to the license.txt file included.
|
// Refer to the license.txt file included.
|
||||||
|
|
||||||
#pragma once
|
#pragma once
|
||||||
|
|
||||||
#include <condition_variable>
|
#include <condition_variable>
|
||||||
#include <functional>
|
#include <functional>
|
||||||
|
|
||||||
|
|
|
@ -12,5 +12,5 @@ create_target_directory_groups(web_service)
|
||||||
get_directory_property(OPENSSL_LIBS
|
get_directory_property(OPENSSL_LIBS
|
||||||
DIRECTORY ${CMAKE_SOURCE_DIR}/externals/libressl
|
DIRECTORY ${CMAKE_SOURCE_DIR}/externals/libressl
|
||||||
DEFINITION OPENSSL_LIBS)
|
DEFINITION OPENSSL_LIBS)
|
||||||
add_definitions(-DCPPHTTPLIB_OPENSSL_SUPPORT)
|
target_compile_definitions(web_service PUBLIC -DCPPHTTPLIB_OPENSSL_SUPPORT)
|
||||||
target_link_libraries(web_service PUBLIC common json-headers ${OPENSSL_LIBS} httplib lurlparser)
|
target_link_libraries(web_service PRIVATE common json-headers ${OPENSSL_LIBS} httplib lurlparser)
|
||||||
|
|
|
@ -30,11 +30,9 @@ ConfigureWeb::~ConfigureWeb() = default;
|
||||||
void ConfigureWeb::setConfiguration() {
|
void ConfigureWeb::setConfiguration() {
|
||||||
ui->web_credentials_disclaimer->setWordWrap(true);
|
ui->web_credentials_disclaimer->setWordWrap(true);
|
||||||
ui->telemetry_learn_more->setOpenExternalLinks(true);
|
ui->telemetry_learn_more->setOpenExternalLinks(true);
|
||||||
ui->telemetry_learn_more->setText(tr("<a "
|
ui->telemetry_learn_more->setText(
|
||||||
"href='https://yuzu-emu.org/entry/"
|
tr("<a href='https://yuzu-emu.org/help/features/telemetry/'><span style=\"text-decoration: "
|
||||||
"telemetry-and-why-thats-a-good-thing/'><span "
|
"underline; color:#039be5;\">Learn more</span></a>"));
|
||||||
"style=\"text-decoration: underline; "
|
|
||||||
"color:#039be5;\">Learn more</span></a>"));
|
|
||||||
|
|
||||||
ui->web_signup_link->setOpenExternalLinks(true);
|
ui->web_signup_link->setOpenExternalLinks(true);
|
||||||
ui->web_signup_link->setText(
|
ui->web_signup_link->setText(
|
||||||
|
|
|
@ -116,7 +116,7 @@ void GMainWindow::ShowTelemetryCallout() {
|
||||||
|
|
||||||
UISettings::values.callout_flags |= static_cast<uint32_t>(CalloutFlag::Telemetry);
|
UISettings::values.callout_flags |= static_cast<uint32_t>(CalloutFlag::Telemetry);
|
||||||
const QString telemetry_message =
|
const QString telemetry_message =
|
||||||
tr("<a href='https://yuzu-emu.org/entry/telemetry-and-why-thats-a-good-thing/'>Anonymous "
|
tr("<a href='https://yuzu-emu.org/help/features/telemetry/'>Anonymous "
|
||||||
"data is collected</a> to help improve yuzu. "
|
"data is collected</a> to help improve yuzu. "
|
||||||
"<br/><br/>Would you like to share your usage data with us?");
|
"<br/><br/>Would you like to share your usage data with us?");
|
||||||
if (QMessageBox::question(this, tr("Telemetry"), telemetry_message) != QMessageBox::Yes) {
|
if (QMessageBox::question(this, tr("Telemetry"), telemetry_message) != QMessageBox::Yes) {
|
||||||
|
|
Reference in New Issue