memory: check page against address space size
This commit is contained in:
parent
18000df5e9
commit
07f71e2620
|
@ -24,6 +24,16 @@
|
||||||
|
|
||||||
namespace Core::Memory {
|
namespace Core::Memory {
|
||||||
|
|
||||||
|
namespace {
|
||||||
|
|
||||||
|
bool AddressSpaceContains(const Common::PageTable& table, const Common::ProcessAddress addr,
|
||||||
|
const std::size_t size) {
|
||||||
|
const Common::ProcessAddress max_addr = 1ULL << table.GetAddressSpaceBits();
|
||||||
|
return addr + size >= addr && addr + size <= max_addr;
|
||||||
|
}
|
||||||
|
|
||||||
|
} // namespace
|
||||||
|
|
||||||
// Implementation class used to keep the specifics of the memory subsystem hidden
|
// Implementation class used to keep the specifics of the memory subsystem hidden
|
||||||
// from outside classes. This also allows modification to the internals of the memory
|
// from outside classes. This also allows modification to the internals of the memory
|
||||||
// subsystem without needing to rebuild all files that make use of the memory interface.
|
// subsystem without needing to rebuild all files that make use of the memory interface.
|
||||||
|
@ -191,6 +201,11 @@ struct Memory::Impl {
|
||||||
std::size_t page_offset = addr & YUZU_PAGEMASK;
|
std::size_t page_offset = addr & YUZU_PAGEMASK;
|
||||||
bool user_accessible = true;
|
bool user_accessible = true;
|
||||||
|
|
||||||
|
if (!AddressSpaceContains(page_table, addr, size)) [[unlikely]] {
|
||||||
|
on_unmapped(size, addr);
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
while (remaining_size) {
|
while (remaining_size) {
|
||||||
const std::size_t copy_amount =
|
const std::size_t copy_amount =
|
||||||
std::min(static_cast<std::size_t>(YUZU_PAGESIZE) - page_offset, remaining_size);
|
std::min(static_cast<std::size_t>(YUZU_PAGESIZE) - page_offset, remaining_size);
|
||||||
|
@ -420,7 +435,7 @@ struct Memory::Impl {
|
||||||
}
|
}
|
||||||
|
|
||||||
void MarkRegionDebug(u64 vaddr, u64 size, bool debug) {
|
void MarkRegionDebug(u64 vaddr, u64 size, bool debug) {
|
||||||
if (vaddr == 0) {
|
if (vaddr == 0 || !AddressSpaceContains(*current_page_table, vaddr, size)) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -476,7 +491,7 @@ struct Memory::Impl {
|
||||||
}
|
}
|
||||||
|
|
||||||
void RasterizerMarkRegionCached(u64 vaddr, u64 size, bool cached) {
|
void RasterizerMarkRegionCached(u64 vaddr, u64 size, bool cached) {
|
||||||
if (vaddr == 0) {
|
if (vaddr == 0 || !AddressSpaceContains(*current_page_table, vaddr, size)) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -611,7 +626,7 @@ struct Memory::Impl {
|
||||||
// AARCH64 masks the upper 16 bit of all memory accesses
|
// AARCH64 masks the upper 16 bit of all memory accesses
|
||||||
vaddr = vaddr & 0xffffffffffffULL;
|
vaddr = vaddr & 0xffffffffffffULL;
|
||||||
|
|
||||||
if (vaddr >= 1uLL << current_page_table->GetAddressSpaceBits()) {
|
if (!AddressSpaceContains(*current_page_table, vaddr, 1)) [[unlikely]] {
|
||||||
on_unmapped();
|
on_unmapped();
|
||||||
return nullptr;
|
return nullptr;
|
||||||
}
|
}
|
||||||
|
|
Reference in New Issue