linker: Remove unused parameter from WriteRelocations()
is_jump_relocation is never used within the function, so we can just remove it.
This commit is contained in:
parent
07e5319d55
commit
184c516182
|
@ -49,8 +49,7 @@ struct Elf64_Sym {
|
||||||
static_assert(sizeof(Elf64_Sym) == 0x18, "Elf64_Sym has incorrect size.");
|
static_assert(sizeof(Elf64_Sym) == 0x18, "Elf64_Sym has incorrect size.");
|
||||||
|
|
||||||
void Linker::WriteRelocations(std::vector<u8>& program_image, const std::vector<Symbol>& symbols,
|
void Linker::WriteRelocations(std::vector<u8>& program_image, const std::vector<Symbol>& symbols,
|
||||||
u64 relocation_offset, u64 size, bool is_jump_relocation,
|
u64 relocation_offset, u64 size, VAddr load_base) {
|
||||||
VAddr load_base) {
|
|
||||||
for (u64 i = 0; i < size; i += sizeof(Elf64_Rela)) {
|
for (u64 i = 0; i < size; i += sizeof(Elf64_Rela)) {
|
||||||
Elf64_Rela rela;
|
Elf64_Rela rela;
|
||||||
std::memcpy(&rela, &program_image[relocation_offset + i], sizeof(Elf64_Rela));
|
std::memcpy(&rela, &program_image[relocation_offset + i], sizeof(Elf64_Rela));
|
||||||
|
@ -124,12 +123,11 @@ void Linker::Relocate(std::vector<u8>& program_image, u32 dynamic_section_offset
|
||||||
}
|
}
|
||||||
|
|
||||||
if (dynamic.find(DT_RELA) != dynamic.end()) {
|
if (dynamic.find(DT_RELA) != dynamic.end()) {
|
||||||
WriteRelocations(program_image, symbols, dynamic[DT_RELA], dynamic[DT_RELASZ], false,
|
WriteRelocations(program_image, symbols, dynamic[DT_RELA], dynamic[DT_RELASZ], load_base);
|
||||||
load_base);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
if (dynamic.find(DT_JMPREL) != dynamic.end()) {
|
if (dynamic.find(DT_JMPREL) != dynamic.end()) {
|
||||||
WriteRelocations(program_image, symbols, dynamic[DT_JMPREL], dynamic[DT_PLTRELSZ], true,
|
WriteRelocations(program_image, symbols, dynamic[DT_JMPREL], dynamic[DT_PLTRELSZ],
|
||||||
load_base);
|
load_base);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -24,8 +24,7 @@ protected:
|
||||||
};
|
};
|
||||||
|
|
||||||
void WriteRelocations(std::vector<u8>& program_image, const std::vector<Symbol>& symbols,
|
void WriteRelocations(std::vector<u8>& program_image, const std::vector<Symbol>& symbols,
|
||||||
u64 relocation_offset, u64 size, bool is_jump_relocation,
|
u64 relocation_offset, u64 size, VAddr load_base);
|
||||||
VAddr load_base);
|
|
||||||
void Relocate(std::vector<u8>& program_image, u32 dynamic_section_offset, VAddr load_base);
|
void Relocate(std::vector<u8>& program_image, u32 dynamic_section_offset, VAddr load_base);
|
||||||
|
|
||||||
void ResolveImports();
|
void ResolveImports();
|
||||||
|
|
Reference in New Issue