Merge pull request #7621 from bunnei/set-mem-perm
core: hle: kernel: Implement SetMemoryPermission.
This commit is contained in:
commit
9a0648ff0a
|
@ -806,6 +806,33 @@ ResultCode KPageTable::ResetTransferMemory(VAddr addr, std::size_t size) {
|
||||||
KMemoryAttribute::Locked, KMemoryAttribute::IpcAndDeviceMapped));
|
KMemoryAttribute::Locked, KMemoryAttribute::IpcAndDeviceMapped));
|
||||||
|
|
||||||
block_manager->Update(addr, size / PageSize, state, KMemoryPermission::ReadAndWrite);
|
block_manager->Update(addr, size / PageSize, state, KMemoryPermission::ReadAndWrite);
|
||||||
|
return ResultSuccess;
|
||||||
|
}
|
||||||
|
|
||||||
|
ResultCode KPageTable::SetMemoryPermission(VAddr addr, std::size_t size,
|
||||||
|
Svc::MemoryPermission svc_perm) {
|
||||||
|
const size_t num_pages = size / PageSize;
|
||||||
|
|
||||||
|
// Lock the table.
|
||||||
|
std::lock_guard lock{page_table_lock};
|
||||||
|
|
||||||
|
// Verify we can change the memory permission.
|
||||||
|
KMemoryState old_state;
|
||||||
|
KMemoryPermission old_perm;
|
||||||
|
R_TRY(this->CheckMemoryState(
|
||||||
|
std::addressof(old_state), std::addressof(old_perm), nullptr, addr, size,
|
||||||
|
KMemoryState::FlagCanReprotect, KMemoryState::FlagCanReprotect, KMemoryPermission::None,
|
||||||
|
KMemoryPermission::None, KMemoryAttribute::All, KMemoryAttribute::None));
|
||||||
|
|
||||||
|
// Determine new perm.
|
||||||
|
const KMemoryPermission new_perm = ConvertToKMemoryPermission(svc_perm);
|
||||||
|
R_SUCCEED_IF(old_perm == new_perm);
|
||||||
|
|
||||||
|
// Perform mapping operation.
|
||||||
|
R_TRY(Operate(addr, num_pages, new_perm, OperationType::ChangePermissions));
|
||||||
|
|
||||||
|
// Update the blocks.
|
||||||
|
block_manager->Update(addr, num_pages, old_state, new_perm, KMemoryAttribute::None);
|
||||||
|
|
||||||
return ResultSuccess;
|
return ResultSuccess;
|
||||||
}
|
}
|
||||||
|
|
|
@ -47,6 +47,7 @@ public:
|
||||||
KMemoryInfo QueryInfo(VAddr addr);
|
KMemoryInfo QueryInfo(VAddr addr);
|
||||||
ResultCode ReserveTransferMemory(VAddr addr, std::size_t size, KMemoryPermission perm);
|
ResultCode ReserveTransferMemory(VAddr addr, std::size_t size, KMemoryPermission perm);
|
||||||
ResultCode ResetTransferMemory(VAddr addr, std::size_t size);
|
ResultCode ResetTransferMemory(VAddr addr, std::size_t size);
|
||||||
|
ResultCode SetMemoryPermission(VAddr addr, std::size_t size, Svc::MemoryPermission perm);
|
||||||
ResultCode SetMemoryAttribute(VAddr addr, std::size_t size, KMemoryAttribute mask,
|
ResultCode SetMemoryAttribute(VAddr addr, std::size_t size, KMemoryAttribute mask,
|
||||||
KMemoryAttribute value);
|
KMemoryAttribute value);
|
||||||
ResultCode SetHeapCapacity(std::size_t new_heap_capacity);
|
ResultCode SetHeapCapacity(std::size_t new_heap_capacity);
|
||||||
|
|
|
@ -164,6 +164,36 @@ static ResultCode SetHeapSize32(Core::System& system, u32* heap_addr, u32 heap_s
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
constexpr bool IsValidSetMemoryPermission(MemoryPermission perm) {
|
||||||
|
switch (perm) {
|
||||||
|
case MemoryPermission::None:
|
||||||
|
case MemoryPermission::Read:
|
||||||
|
case MemoryPermission::ReadWrite:
|
||||||
|
return true;
|
||||||
|
default:
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
static ResultCode SetMemoryPermission(Core::System& system, VAddr address, u64 size,
|
||||||
|
MemoryPermission perm) {
|
||||||
|
// Validate address / size.
|
||||||
|
R_UNLESS(Common::IsAligned(address, PageSize), ResultInvalidAddress);
|
||||||
|
R_UNLESS(Common::IsAligned(size, PageSize), ResultInvalidSize);
|
||||||
|
R_UNLESS(size > 0, ResultInvalidSize);
|
||||||
|
R_UNLESS((address < address + size), ResultInvalidCurrentMemory);
|
||||||
|
|
||||||
|
// Validate the permission.
|
||||||
|
R_UNLESS(IsValidSetMemoryPermission(perm), ResultInvalidNewMemoryPermission);
|
||||||
|
|
||||||
|
// Validate that the region is in range for the current process.
|
||||||
|
auto& page_table = system.Kernel().CurrentProcess()->PageTable();
|
||||||
|
R_UNLESS(page_table.Contains(address, size), ResultInvalidCurrentMemory);
|
||||||
|
|
||||||
|
// Set the memory attribute.
|
||||||
|
return page_table.SetMemoryPermission(address, size, perm);
|
||||||
|
}
|
||||||
|
|
||||||
static ResultCode SetMemoryAttribute(Core::System& system, VAddr address, u64 size, u32 mask,
|
static ResultCode SetMemoryAttribute(Core::System& system, VAddr address, u64 size, u32 mask,
|
||||||
u32 attribute) {
|
u32 attribute) {
|
||||||
LOG_DEBUG(Kernel_SVC,
|
LOG_DEBUG(Kernel_SVC,
|
||||||
|
@ -2724,7 +2754,7 @@ static const FunctionDef SVC_Table_32[] = {
|
||||||
static const FunctionDef SVC_Table_64[] = {
|
static const FunctionDef SVC_Table_64[] = {
|
||||||
{0x00, nullptr, "Unknown"},
|
{0x00, nullptr, "Unknown"},
|
||||||
{0x01, SvcWrap64<SetHeapSize>, "SetHeapSize"},
|
{0x01, SvcWrap64<SetHeapSize>, "SetHeapSize"},
|
||||||
{0x02, nullptr, "SetMemoryPermission"},
|
{0x02, SvcWrap64<SetMemoryPermission>, "SetMemoryPermission"},
|
||||||
{0x03, SvcWrap64<SetMemoryAttribute>, "SetMemoryAttribute"},
|
{0x03, SvcWrap64<SetMemoryAttribute>, "SetMemoryAttribute"},
|
||||||
{0x04, SvcWrap64<MapMemory>, "MapMemory"},
|
{0x04, SvcWrap64<MapMemory>, "MapMemory"},
|
||||||
{0x05, SvcWrap64<UnmapMemory>, "UnmapMemory"},
|
{0x05, SvcWrap64<UnmapMemory>, "UnmapMemory"},
|
||||||
|
|
|
@ -249,6 +249,14 @@ void SvcWrap64(Core::System& system) {
|
||||||
func(system, Param(system, 0), Param(system, 1), static_cast<u32>(Param(system, 2))).raw);
|
func(system, Param(system, 0), Param(system, 1), static_cast<u32>(Param(system, 2))).raw);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Used by SetMemoryPermission
|
||||||
|
template <ResultCode func(Core::System&, u64, u64, Svc::MemoryPermission)>
|
||||||
|
void SvcWrap64(Core::System& system) {
|
||||||
|
FuncReturn(system, func(system, Param(system, 0), Param(system, 1),
|
||||||
|
static_cast<Svc::MemoryPermission>(Param(system, 2)))
|
||||||
|
.raw);
|
||||||
|
}
|
||||||
|
|
||||||
// Used by MapSharedMemory
|
// Used by MapSharedMemory
|
||||||
template <ResultCode func(Core::System&, Handle, u64, u64, Svc::MemoryPermission)>
|
template <ResultCode func(Core::System&, Handle, u64, u64, Svc::MemoryPermission)>
|
||||||
void SvcWrap64(Core::System& system) {
|
void SvcWrap64(Core::System& system) {
|
||||||
|
|
Reference in New Issue