Merge pull request #93 from lioncash/ref
core: Pass string by reference in FetchFromPortName and DeleteService
This commit is contained in:
commit
a130086587
|
@ -41,7 +41,7 @@ void Manager::AddService(Interface* service) {
|
|||
}
|
||||
|
||||
/// Removes a service from the manager, also frees memory
|
||||
void Manager::DeleteService(std::string port_name) {
|
||||
void Manager::DeleteService(const std::string& port_name) {
|
||||
Interface* service = FetchFromPortName(port_name);
|
||||
m_services.erase(std::remove(m_services.begin(), m_services.end(), service), m_services.end());
|
||||
m_port_map.erase(port_name);
|
||||
|
@ -54,7 +54,7 @@ Interface* Manager::FetchFromHandle(Handle handle) {
|
|||
}
|
||||
|
||||
/// Get a Service Interface from its port
|
||||
Interface* Manager::FetchFromPortName(std::string port_name) {
|
||||
Interface* Manager::FetchFromPortName(const std::string& port_name) {
|
||||
auto itr = m_port_map.find(port_name);
|
||||
if (itr == m_port_map.end()) {
|
||||
return nullptr;
|
||||
|
|
|
@ -149,13 +149,13 @@ public:
|
|||
void AddService(Interface* service);
|
||||
|
||||
/// Removes a service from the manager (does not delete it though)
|
||||
void DeleteService(std::string port_name);
|
||||
void DeleteService(const std::string& port_name);
|
||||
|
||||
/// Get a Service Interface from its UID
|
||||
Interface* FetchFromHandle(u32 uid);
|
||||
|
||||
/// Get a Service Interface from its port
|
||||
Interface* FetchFromPortName(std::string port_name);
|
||||
Interface* FetchFromPortName(const std::string& port_name);
|
||||
|
||||
private:
|
||||
|
||||
|
|
Reference in New Issue