25038aeb0d
telemetry_json: Use the PImpl idiom to avoid unnecessary dependency exposure
...
Users of the web_service library shouldn't need to care about an
external library like json.h. However, given it's exposed in our
interface, this requires that other libraries publicly link in the JSON
library. We can do better.
By using the PImpl idiom, we can hide this dependency in the cpp file
and remove the need to link that library in altogether.
2018-10-23 15:35:17 +02:00
131ce59800
telemetry_json: Add missing override specifier to the destructor of TelemetryJson
2018-10-23 15:33:41 +02:00
8747d93f6a
telemetry_json: Take std::string parameters by value
...
Taking them by const reference isn't advisable here, because it means
the std::move calls were doing nothing and we were always copying the
std::string instances.
2018-10-23 15:33:34 +02:00
c9013c481a
telemetry_json: Remove unnecessary includes
...
Removes unused includes. Also rectifies a missing <chrono> include.
2018-10-23 15:33:18 +02:00
7142d3cf78
telemetry_session: Remove doxygen comment for a non-existent parameter
...
There's no "func" parameter, so this can just be removed.
2018-10-23 15:30:07 +02:00
61627c2042
telemetry_session: Add missing includes
...
Prevents potential compilation issues in the future by including missing
headers for certain functions and types.
2018-10-23 15:28:50 +02:00
d5bb2a21aa
telemetry_session: Remove unimplemented FinalizeAsyncJob prototype
...
This isn't implemented anywhere, so it can just be removed.
2018-10-23 15:27:05 +02:00
129ca865b3
Merge pull request #4355 from lioncash/query
...
svc: Correct vma_map boundary check within QueryProcessMemory
2018-10-22 09:27:46 -04:00
930abb4b5e
svc: Correct vma_map boundary check within QueryProcessMemory
...
This should be using the process instance retrieved within the function,
and not g_current_process, otherwise this is potentially comparing
iterators from unrelated vma_map instances (which is undefined
behavior).
2018-10-21 22:00:12 -04:00
57ce5079bc
Merge pull request #4336 from wwylele/file-util-mingw
...
Only redefine some 64-bit file operation for MSVC
2018-10-21 20:34:48 -04:00
6f1759c5bd
Merge pull request #4341 from wwylele/kernel-global
...
Kernel: make a kernel instance and remove object ID counter from global state
2018-10-21 18:53:36 -04:00
11729eafe1
Merge pull request #4315 from FearlessTobi/port-1332
...
WebService: Backport review comments from yuzu-emu/yuzu#1332
2018-10-20 18:05:06 -04:00
65ec8de31e
web_service: hide dependencies to private
2018-10-20 10:47:17 -04:00
57d68bb541
Address review comments
2018-10-20 10:35:55 -04:00
7daac96862
Review comments - part 5
2018-10-20 10:35:55 -04:00
9901b289b6
Review comments -part 4
2018-10-20 10:35:55 -04:00
08793a6dae
Review comments - part 3
2018-10-20 10:35:55 -04:00
8a87a6a72f
Address more review comments
2018-10-20 10:35:55 -04:00
b0aed19823
Address a bunch of review comments
2018-10-20 10:35:55 -04:00
eadd8b91b2
Merge pull request #4338 from FearlessTobi/port-1490
...
Port yuzu-emu/yuzu#1490 : "citra_qt/main: Simplify OnMenuLoadFile()"
2018-10-20 10:09:41 -04:00
18caa787d2
Merge pull request #4197 from B3n30/spsc_queue_wait
...
threadsafe_queue: Add PopWait and use it where possible
2018-10-19 19:36:37 -04:00
751ebe55e9
Kernel: pass ref down to Object and wrap ID counter into kernel state
2018-10-18 21:41:36 -04:00
87426b29ff
kernel: pass ref to shared memory
2018-10-18 21:41:36 -04:00
2a411bb501
Kernel: wrap resource limit state into kernel state; pass ref to resource limit
2018-10-18 21:41:36 -04:00
13c26b4371
Kernel: pass ref to session pair
2018-10-18 21:41:36 -04:00
1213a298df
Kernel: pass ref to port
2018-10-18 21:41:36 -04:00
c141657d83
Kernel: pass ref to timer
2018-10-18 21:41:36 -04:00
247249d5d3
Kernel: pass ref to sempahore
2018-10-18 21:41:36 -04:00
181646679c
ServiceManager: pass down core reference
2018-10-18 21:41:36 -04:00
d940293d32
Kernel: pass ref to thread
2018-10-18 21:41:36 -04:00
9565091fc2
kernel: pass ref in Process
2018-10-18 21:41:36 -04:00
213b259cf1
kernel: pass ref in CodeSet
2018-10-18 21:41:36 -04:00
7449ba85a6
Kernel: pass ref in Mutex
2018-10-18 21:41:36 -04:00
eec11a94cb
Kernel: pass Kernel ref in Event
2018-10-18 21:41:36 -04:00
734be98966
Kernel: pass Kernel reference into AddressArbiter
2018-10-18 21:41:00 -04:00
f446fd1fe5
Kernel: add KernelSystem class
2018-10-18 21:41:00 -04:00
1de63f9b16
Merge pull request #4328 from B3n30/remove_current_module
...
remove GetCurrentModule() functions in HLE Services
2018-10-18 21:39:24 -04:00
9458ae0977
Merge pull request #4259 from zhaowenlan1779/game-list
...
citra_qt: Add Game List configuration
2018-10-18 21:29:33 +08:00
53a3498aee
Merge pull request #4193 from B3n30/controller5
...
Joystick: Allow for background events; Add deadzone to SDLAnalog
2018-10-17 10:49:21 -04:00
c4ed7e75f4
Merge pull request #4340 from wwylele/disable-scripting
...
CMake: disable scripting on default
2018-10-17 17:48:11 +08:00
f48157c6ea
Load AES keys stored in boot9.bin ( #4335 )
...
* Load AES keys stored in boot9.bin
2018-10-17 10:13:55 +02:00
380b83e9bd
cmake: mingw also needs _FILE_OFFSET_BITS=64
2018-10-16 13:23:07 -04:00
2a7b87874b
Merge pull request #4343 from FearlessTobi/port-1487
...
Port yuzu-emu/yuzu#1487 : "Apply the [[maybe_unused]] attribute to the parameter of SetDiscordEnabled()"
2018-10-16 11:07:31 -04:00
15ecc38ada
citra_qt/main: Apply the [[maybe_unused]] attribute to the parameter of SetDiscordEnabled()
...
Depending on whether or not USE_DISCORD_PRESENCE is defined, the "state"
parameter can be used or unused. If USE_DISCORD_PRESENCE is not defined,
the parameter will be considered unused, which can lead to compiler
warnings. So, we can explicitly mark it with [[maybe_unused]] to inform
the compiler that this is intentional.
2018-10-16 14:42:48 +02:00
fc46bba4f2
CMake: disable scripting on default
2018-10-15 12:23:47 -04:00
b01b94d843
FileSys::Ticket::Load: Return error if signature type does not match ( #4339 )
...
* FileSys::Ticket::Load: Return error if signature type does not match
* fixup! FileSys::Ticket::Load: Return error if signature type does not match
2018-10-15 11:26:35 -04:00
0df32275a7
Merge pull request #4282 from zhaowenlan1779/frame-advance
...
core, citra_qt: add frame advancing to framelimiter
2018-10-15 21:25:41 +08:00
7ddfce4a87
citra_qt/main: Simplify OnMenuLoadFile()
...
We can utilize QStringList's join() function to perform all of the
appending in a single function call.
While we're at it, make the extension list a single translatable string
and add a disambiguation comment to explain to translators what %1
actually is.
2018-10-14 22:31:46 +02:00
8ecd31db41
citra_qt: use enum classes for the settings
2018-10-14 22:55:28 +08:00
84ddb1cba0
Merge pull request #4331 from zhaowenlan1779/cemuhook-fix
...
citra: fix cemuhook module crash
2018-10-14 21:35:38 +08:00
Lioncash
Weiyi Wang
fearlessTobi
Pengfei Zhu
Ben