cfb59aad3f
yuzu/bootmanager: Remove pointer downcast in GRenderWindow's constructor
...
We can just pass a pointer to GMainWindow directly and make it a
requirement of the interface. This makes the interface a little safer,
since this would technically otherwise allow any random QWidget to be
the parent of a render window, downcasting it to GMainWindow (which is
undefined behavior).
2019-06-03 15:31:52 -04:00
49e3a6e924
yuzu/bootmanager: Remove unnecessary pointer casts
...
We can just invoke these functions by qualifying the object name before
the function.
2019-06-03 15:31:51 -04:00
e70f16fff7
input_common/sdl/sdl_impl: Silence sign conversion warnings
...
Makes the conversions explicit, as opposed to implicit.
2019-05-31 04:47:02 -03:00
1edf018319
common/math_util: Provide a template deduction guide for Common::Rectangle
...
Allows for things such as:
auto rect = Common::Rectangle{0, 0, 0, 0};
as opposed to being required to explicitly write out the underlying
type, such as:
auto rect = Common::Rectangle<int>{0, 0, 0, 0};
The only requirement for the deduction is that all constructor arguments
be the same type.
2019-05-31 04:44:02 -03:00
ed74a3cb8b
Merge pull request #1931 from DarkLordZach/mii-database-1
...
mii: Implement MiiManager backend and several mii service commands
2019-05-30 13:26:40 -04:00
75561d190a
Merge pull request #2431 from DarkLordZach/game-list-cache
...
yuzu: Implement a caching mechanism for the game list
2019-05-30 13:04:40 -04:00
9b2d38582f
main: Remove extraneous comment
2019-05-30 10:47:56 -04:00
e3608578e4
Merge pull request #2446 from ReinUsesLisp/tid
...
shader: Implement S2R Tid{XYZ} and CtaId{XYZ}
2019-05-29 12:21:17 -04:00
665b7e8e18
Merge pull request #2518 from ReinUsesLisp/sdl2-window
...
yuzu_cmd: Split emu_window OpenGL implementation into its own file
2019-05-29 11:01:12 -04:00
cfd885163f
Merge pull request #2519 from lioncash/sign
...
loader/nso, core/core_timing_util: Silence sign-comparison warning
2019-05-27 12:26:17 -04:00
2eb4d27c48
Merge pull request #2524 from ReinUsesLisp/fixup-extension
...
gl_shader_gen: Always declare extensions after the version declaration
2019-05-27 12:25:59 -04:00
21c0b4dec8
gl_device: Add commentary to AOFFI unit test source code
...
The intention behind this commit is to hint someone inspecting an
apitrace dump to ignore this ill-formed GLSL code.
2019-05-27 00:55:57 -03:00
84928e6d67
gl_shader_gen: Always declare extensions after the version declaration
...
This addresses a bug on geometry shaders where code was being written
before all #extension declarations were done. Ref to #2523
2019-05-27 00:51:35 -03:00
46e2ca5475
game_list_worker: Add better error handling to caching
2019-05-26 17:14:09 -04:00
944c07ac7d
yuzu: Clear partial/full game list cache when data is updated
2019-05-26 15:12:12 -04:00
f95bdb5088
game_list: Implement caching for game list
...
Preserves list of add ons and the icon, which are the two costliest parts of game list population.
2019-05-26 15:12:12 -04:00
180f22f17e
ui_settings: Add option to cache game list
2019-05-26 15:12:12 -04:00
37eaf39b44
emu_window: Pass OnMinimalClientAreaChangeRequest argument by copy
...
There's no performance improvement in passing an unsigned pair by
reference.
2019-05-26 00:54:13 -03:00
90c9d703ba
Merge pull request #2516 from lioncash/label
...
renderer_opengl/utils: Use a std::string_view with LabelGLObject()
2019-05-25 23:01:25 -04:00
bb248a2710
Merge pull request #2509 from lioncash/aoc
...
service/aoc_u: Minor cleanup
2019-05-25 23:00:12 -04:00
f97e206348
Merge pull request #2511 from lioncash/file-str
...
common/file_util: Minor cleanup
2019-05-25 22:59:16 -04:00
91300bdfb2
Merge pull request #2517 from lioncash/hotkey
...
configure_hotkeys: Minor cleanup
2019-05-25 22:58:46 -04:00
0fa039d8d0
core_timing_util: Silence sign-comparison warnings
...
We can just make the conversion explicit instead of implicit here to
silence -Wsign-compare warnings.
2019-05-25 17:01:18 -04:00
e5159cfb84
loader/nso: Silence sign-comparison warning
...
This was previously performing a size_t == int comparison. Silences a
-Wsign-compare warning.
2019-05-25 16:53:33 -04:00
4b80dd23a4
yuzu_cmd: Split emu_window OpenGL implementation into its own file
2019-05-25 17:47:13 -03:00
88cd5e888e
configure_hotkeys: Remove unnecessary Settings::Apply() call
...
Nothing from the hotkeys dialog relies on this call occurring, and is
already called from the dialog that calls applyConfiguration().
2019-05-25 04:34:54 -04:00
6640f631e2
configure_hotkeys: Tidy up key sequence conflict error string
...
Avoids mentioning the user and formalizes the error itself.
2019-05-25 04:25:11 -04:00
d61199721d
configure_hotkeys: Change critical error dialog into a warning dialog
...
critical() is intended for critical/fatal errors that threaten the
overall stability of an application. A user entering a conflicting key
sequence is neither of those.
2019-05-25 04:08:18 -04:00
ef3c0f54d0
configure_hotkeys: Move conflict detection logic to IsUsedKey()
...
We don't need to extract the entire set of hotkeys into a list and then
iterate through it. We can traverse the list and early-exit if we're
able to.
2019-05-25 04:08:13 -04:00
c03fb00ac1
configure_hotkeys: Remove unused EmitHotkeysChanged()
...
1. This is something that should be solely emitted by the hotkey dialog
itself
2. This is functionally unused, given there's nothing listening for the
signal.
2019-05-25 04:08:07 -04:00
5d645c6dd9
sequence_dialog: Reorganize the constructor
...
The previous code was all "smushed" together wasn't really grouped
together that well.
This spaces things out and separates them by relation to one another,
making it easier to visually parse the individual sections of code that
make up the constructor.
2019-05-25 04:08:02 -04:00
9218e347cd
sequence_dialog: Remove unnecessary horizontal specifier
...
QDialogButtonBoxes are horizontal by default.
2019-05-25 04:07:56 -04:00
5a4564bd8e
renderer_opengl/utils: Use a std::string_view with LabelGLObject()
...
Uses a std::string_view instead of a std::string, given the pointed to
string isn't modified and is only used in a formatting operation.
This is nice because a few usages directly supply a string literal to
the function, allowing these usages to otherwise not heap allocate,
unlike the std::string overloads.
While we're at it, we can combine the address formatting into a single
formatting call.
2019-05-24 23:50:10 -04:00
e86d2e2e5b
Merge pull request #2513 from lioncash/string
...
yuzu/main: Specify string conversions explicitly
2019-05-24 22:46:10 -04:00
68c9c9222d
Merge pull request #2358 from ReinUsesLisp/parallel-shader
...
gl_shader_cache: Use shared contexts to build shaders in parallel at boot
2019-05-24 22:42:08 -04:00
3c0280cf66
yuzu/CMakeLists: Disable implicit QString conversions
...
Now that all of our code is compilable with implicit QString
conversions, we can enforce it at compile-time by disabling them.
2019-05-24 21:31:01 -04:00
bb06b98d81
yuzu/applets/software_keyboard: Remove unused assert header
...
This isn't actually used anywhere, so it can be removed.
2019-05-24 21:27:13 -04:00
16bf791939
yuzu/applets/software_keyboard: std::move argument in MainWindowFinishedText()
...
Given the std::optional can contain an object type that heap allocates,
we can use std::move to avoid an unnecessary copy/allocation from
occurring.
2019-05-24 21:27:12 -04:00
b3d7180164
yuzu/applets/software_keyboard: Resolve sign mismatch comparison
...
Qt uses a signed value to represent container sizes, so this was causing
a sign mismatch warning.
2019-05-24 21:27:12 -04:00
cf9cc41478
yuzu/applets/software_keyboard: Specify string conversions explicitly
...
Allows the software keyboard applet code to compile with implicit string
conversions disabled.
2019-05-24 21:27:12 -04:00
f5d416e071
yuzu/applets/error: Specify string conversions explicitly
...
Allows the error applet to build successfully with implicit string
conversions disabled.
2019-05-24 21:27:12 -04:00
6f2a8fbb13
yuzu/main: Specify string conversions where applicable
2019-05-24 21:27:09 -04:00
1a2d90ab09
Merge pull request #2485 from ReinUsesLisp/generic-memory
...
shader/memory: Implement generic memory stores and loads (ST and LD)
2019-05-24 18:24:26 -04:00
59f110ef31
Merge pull request #2504 from lioncash/config
...
yuzu/configuration/config: Specify string conversions explicitly
2019-05-24 18:23:58 -04:00
d4f8fe24d9
Merge pull request #2489 from FearlessTobi/port-4716
...
Port citra-emu/citra#4716 : "HLE/IPC: HLEContext can memorize the client thread and use it for SleepClientThread"
2019-05-24 18:23:15 -04:00
c70404eab5
Merge pull request #2505 from ReinUsesLisp/glad-update
...
externals: Update glad to support OpenGL 4.6 compatibility profile
2019-05-24 18:23:04 -04:00
e7ab0e9127
common/file_util: Remove unnecessary return at end of void StripTailDirSlashes()
...
While we're at it, also invert the conditional into a guard clause.
2019-05-23 14:33:29 -04:00
11e9bee91d
common/file_util: Make GetCurrentDir() return a std::optional
...
nullptr was being returned in the error case, which, at a glance may
seem perfectly OK... until you realize that std::string has the
invariant that it may not be constructed from a null pointer. This
means that if this error case was ever hit, then the application would
most likely crash from a thrown exception in std::string's constructor.
Instead, we can change the function to return an optional value,
indicating if a failure occurred.
2019-05-23 14:24:13 -04:00
943f6da1ac
common/file_util: Remove duplicated documentation comments
...
These are already present within the header, so they don't need to be
repeated in the cpp file.
2019-05-23 14:22:12 -04:00
2b1fcc8a14
common/file_util: Make ReadFileToString and WriteStringToFile consistent
...
Makes the parameter ordering consistent, and also makes the filename
parameter a std::string. A std::string would be constructed anyways with
the previous code, as IOFile's only constructor with a filepath is one
taking a std::string.
We can also make WriteStringToFile's string parameter utilize a
std::string_view for the string, making use of our previous changes to
IOFile.
2019-05-23 13:52:43 -04:00
Lioncash
bunnei
Zach Hilman
ReinUsesLisp