yuzu-emu
/
yuzu-mainline
Archived
1
0
Fork 0
Code
20,977 Commits 1 Branch 0 Tags 105 MiB
Commit Graph

18565 Commits

Author SHA1 Message Date
bunnei 6b2f653143 hle: kernel: k_scheduler_lock: Fix shadowing errors. 2021-01-11 14:23:16 -08:00
bunnei 354130cd84 core: arm: arm_interface: Fix shadowing errors. 2021-01-11 14:23:16 -08:00
bunnei 82f6037ec2 core: hle: Add missing calls to MicroProfileOnThreadExit. 2021-01-11 14:23:16 -08:00
bunnei 912dd50146 core: hle: Integrate new KConditionVariable and KAddressArbiter implementations. 2021-01-11 14:23:16 -08:00
bunnei 952d1ac487 core: hle: kernel: Update KAddressArbiter. 2021-01-11 14:23:16 -08:00
bunnei b4e6d6c385 core: hle: kernel: Update KConditionVariable. 2021-01-11 14:23:16 -08:00
bunnei 1212fa60b6 core: hle: kernel: Begin moving common SVC defintions to its own header. 2021-01-11 14:23:16 -08:00
bunnei 8a155c4058 hle: kernel: Remove unnecessary AddressArbiter definition. 2021-01-11 14:23:16 -08:00
bunnei 92d5c63f01 common: common_funcs: Add R_UNLESS macro. 2021-01-11 14:23:16 -08:00
bunnei f12701b303 hle: kernel: k_scheduler: Cleanup OnThreadPriorityChanged. 2021-01-11 14:23:16 -08:00
bunnei d1309fb275 hle: kernel: Rename thread "status" to "state". 2021-01-11 14:23:16 -08:00
bunnei c3c43e32fc hle: kernel: thread: Replace ThreadStatus/ThreadSchedStatus with a single ThreadState. 
- This is how the real kernel works, and is more accurate and simpler.
 2021-01-11 14:23:16 -08:00
bunnei 7420a717e6 core: hle: kernel: Add some useful functions for checking kernel addresses. 2021-01-11 14:23:16 -08:00
bunnei 4bbf173fc1 core: hle: kernel: svc_types: Add type definitions for KAddressArbiter. 2021-01-11 14:23:16 -08:00
bunnei fb43b8efd2 common: Introduce useful tree structures. 2021-01-11 14:23:16 -08:00
bunnei 35c3c078e3 core: hle: kernel: Update KSynchronizationObject. 2021-01-11 14:23:16 -08:00
bunnei 1ae883435d core: hle: kernel: Begin moving common SVC results to its own header. 2021-01-11 14:23:16 -08:00
bunnei 8fc6e92ef1 hle: service: nfp: Remove incorrect signaling behavior in GetDeviceState. 2021-01-11 14:23:16 -08:00
Levi 7a3c884e39 Merge remote-tracking branch 'upstream/master' into int-flags 2021-01-10 22:09:56 -07:00
bunnei 46cd71d1c7
Merge pull request #5229 from Morph1984/fullscreen-opt 
yuzu/main: Add basic command line arguments
 2021-01-10 18:53:04 -08:00
LC 5e161b2531
Merge pull request #5324 from Morph1984/docked-default 
config: Enable docked mode by default
 2021-01-10 20:51:33 -05:00
bunnei 32df83e55d
Merge pull request #5312 from german77/overclockenabled 
apm: Stub IsCpuOverclockEnabled
 2021-01-10 14:30:13 -08:00
Morph 05f58144c9 config: Enable docked mode by default 2021-01-10 09:37:38 -05:00
Morph 25724898d0 cmake: Enforce C4101 
This matches GCC's -Wunused-variable
 2021-01-10 01:16:25 -05:00
Morph e07540264d yuzu_cmd: Silence unreferenced local variable warning 2021-01-10 01:10:36 -05:00
LC 0f932d30f5
Merge pull request #5320 from ReinUsesLisp/div-ceil-type 
common/div_ceil: Return numerator type
 2021-01-09 16:45:29 -05:00
Morph 4aae21e1e4 general: Resolve C4062 warnings on MSVC 2021-01-09 14:46:35 -05:00
ReinUsesLisp c190586597 common/div_ceil: Return numerator type 
Fixes instances where DivCeil(u32, u64) would surprisingly return u64,
instead of the more natural u32.
 2021-01-09 03:16:10 -03:00
ReinUsesLisp d7128845c9 cmake: Enforce C4062, C4265, C4388, and C5038 
This should match some warnings we treat as errors on gcc and clang,
caching bugs early and reducing the number of instances where we have to
edit commits to make CI happy when developing from Windows.
 2021-01-09 02:19:17 -03:00
ReinUsesLisp c68d0dc851 file_sys/registered_cache: Silence virtual functions without override warnings 2021-01-09 00:04:12 -03:00
ReinUsesLisp b4451c5e81 core: Silence unhandled enum in switch warnings 2021-01-08 23:21:07 -03:00
ReinUsesLisp 613b3671b7 tests/ring_buffer: Silence signed/unsigned mismatch warnings 2021-01-08 23:14:38 -03:00
bunnei 8eea7c1176
Merge pull request #5231 from ReinUsesLisp/dyn-bindings 
renderer_vulkan/fixed_pipeline_state: Move enabled bindings to static state
 2021-01-08 12:24:46 -08:00
german 385a4555d5 Stub IsCpuOverclockEnabled 2021-01-08 09:44:56 -06:00
ReinUsesLisp 154a7653f9 vk_fence_manager: Use timeline semaphores instead of spin waits 
With timeline semaphores we can avoid creating objects. Instead of
creating an event, grab the current tick from the scheduler and flush
the current command buffer. When the fence has to be queried/waited, we
can do so against the master semaphore instead of spinning on an event.

If Vulkan supported NVN like events or fences, we could signal from the
command buffer and wait for that without splitting things in two
separate command buffers.
 2021-01-08 02:47:28 -03:00
Ameer J 16392a23cc remove inaccurate reference 
Co-authored-by: LC <mathew1800@gmail.com>
 2021-01-07 14:33:45 -05:00
ameerj 06cef3355e fix for nvdec disabled, cleanup host1x 2021-01-07 14:33:45 -05:00
ameerj 2c27127d04 nvdec syncpt incorporation 
laying the groundwork for async gpu, although this does not fully implement async nvdec operations
 2021-01-07 14:33:45 -05:00
MerryMage 21199cb965 vulkan_library: Common::DynamicLibrary::Open is [[nodiscard]] 
Ignore the return value on __APPLE__ systems as well
 2021-01-07 17:37:47 +00:00
MerryMage aace20afc7 texture_cache: Replace PAGE_SHIFT with PAGE_BITS 
PAGE_SHIFT is a #define in system headers that leaks into user code on some systems
 2021-01-07 16:51:34 +00:00
Morph e8d40559d5
Merge pull request #5288 from ReinUsesLisp/workaround-garbage 
gl_texture_cache: Avoid format views on Intel and AMD
 2021-01-06 15:39:51 +08:00
bunnei dc02b03c4a
Merge pull request #5293 from ReinUsesLisp/return-values 
core: Enforce C4715 (not all control paths return a value)
 2021-01-05 19:04:15 -08:00
bunnei 275b96a0e2
Merge pull request #5289 from ReinUsesLisp/vulkan-device 
vulkan_common: Move device abstraction to the common directory and allow surfaceless devices
 2021-01-05 17:44:56 -08:00
ReinUsesLisp 43d9f417ae core: Enforce C4715 (not all control paths return a value) 2021-01-05 04:18:40 -03:00
ReinUsesLisp 4f13e270c8 core: Silence warnings when compiling without asserts 2021-01-05 04:18:16 -03:00
LC 2a6e6306d8
Merge pull request #5292 from ReinUsesLisp/empty-set 
vk_rasterizer: Skip binding empty descriptor sets on compute
 2021-01-04 21:32:57 -05:00
bunnei 4e6aa1cfdd
Merge pull request #5261 from gal20/hide_mouse_patch 
yuzu/main: Fix 'Hide mouse on inactivity' and port citra-emu/citra#5476
 2021-01-04 17:19:04 -08:00
ReinUsesLisp 1ccf805367 vk_rasterizer: Skip binding empty descriptor sets on compute 
Fixes unit tests where compute shaders had no descriptors in the set,
making Vulkan drivers crash when binding an empty set.
 2021-01-04 17:56:39 -03:00
ameerj 6b354ccaee buffer_queue: Protect queue_sequence list access with a mutex 
fixes a data race as this is an unprotected variable manipulated by multiple threads
 2021-01-04 01:36:41 -05:00
FearlessTobi 8e77d331be yuzu/configure_filesystem: Remove "Select Cache Directory" option 
This tab of the settings is already extremely bloated and the setting itself is quite useless.
With a gamelist of almost 30 games, the cache directory is smaller than 1MB for me and therefore I don't see why it needs to be configurable.
 2021-01-04 06:29:48 +01:00
ReinUsesLisp ac1e4734c2 vulkan_device: Allow creating a device without surface 2021-01-04 02:22:22 -03:00
ReinUsesLisp d235cf3933 renderer_vulkan/nsight_aftermath_tracker: Move to vulkan_common 2021-01-04 02:22:22 -03:00
ReinUsesLisp 3753553b6a renderer_vulkan: Move device abstraction to vulkan_common 2021-01-04 02:22:22 -03:00
Rodrigo Locatti 4801f4250d
Merge pull request #5286 from ReinUsesLisp/rename-vk-device 
renderer_vulkan: Rename VKDevice to Device
 2021-01-04 02:22:02 -03:00
ReinUsesLisp 7d904fef2e gl_texture_cache: Avoid format views on Intel and AMD 
Intel and AMD proprietary drivers are incapable of rendering to texture
views of different formats than the original texture. Avoid creating
these at a cache level. This will consume more memory, emulating them
with copies.
 2021-01-04 02:06:40 -03:00
ReinUsesLisp 3a49c1a691 gl_texture_cache: Create base images with sRGB 
This breaks accelerated decoders trying to imageStore into images with
sRGB. The decoders are currently disabled so this won't cause issues at
runtime.
 2021-01-04 01:54:54 -03:00
FearlessTobi beb951770a Address review comments 2021-01-04 04:36:50 +01:00
xperia64 fd5776aac2 Delete the old log file before rotating (#5675) 2021-01-04 04:33:34 +01:00
Rodrigo Locatti 87a8925523
Merge pull request #5285 from lioncash/error-str 
main: Resolve error string not displaying
 2021-01-03 19:56:15 -03:00
ReinUsesLisp 974d731926 renderer_vulkan: Rename VKDevice to Device 
The "VK" prefix predates the "Vulkan" namespace. It was carried around
the codebase for consistency. "VKDevice" currently is a bad alias with
"VkDevice" (only an upcase character of difference) that can cause
confusion. Rename all instances of it.
 2021-01-03 17:51:48 -03:00
Rodrigo Locatti 7265e80c12
Merge pull request #5230 from ReinUsesLisp/vulkan-common 
vulkan_common: Move reusable Vulkan abstractions to a separate directory
 2021-01-03 17:38:29 -03:00
Lioncash 86592b274e main: Resolve error string not displaying 
During the transition to make the error dialog translatable, I
accidentally got rid of the conversion to ResultStatus, which prevented
operator<< from being invoked during formatting.

This adds a function to directly retrieve the result status string
instead so that it displays again.
 2021-01-03 13:18:04 -05:00
bunnei 71e18dddbe
Merge pull request #5278 from MerryMage/cpuopt_unsafe_inaccurate_nan 
dynarmic: Add Unsafe_InaccurateNaN optimization
 2021-01-03 03:27:29 -08:00
bunnei f64456c7e2
Merge pull request #5279 from bunnei/buffer-queue-connect 
hle: service: nvflinger: buffer_queue: Do not reset id/layer_id on Connect.
 2021-01-03 01:01:38 -08:00
bunnei bf8bd60ab3 Fix the old log file to work with the log parser. 2021-01-03 01:44:52 +01:00
xperia64 f478a57737 Rotate previous log file to '.old' if it exists 2021-01-03 01:44:42 +01:00
bunnei 235b5d27ae
Merge pull request #5267 from lioncash/localize 
main: Make the loader error dialog fully translatable
 2021-01-02 15:44:32 -08:00
bunnei beaa25d777 hle: service: nvflinger: buffer_queue: Do not reset id/layer_id on Connect. 
- This behavior is a mistake, fixes Katana Zero.
 2021-01-02 15:42:16 -08:00
MerryMage 57c9da1b39 dynarmic: Add Unsafe_InaccurateNaN optimization 2021-01-02 20:13:21 +00:00
Morph a745d87971 general: Fix various spelling errors 2021-01-02 10:23:41 -05:00
Fernando Sahmkow 53d92318b8 X86/NativeClock: Reimplement RTDSC access to be lock free. 2021-01-02 04:00:27 +01:00
Fernando Sahmkow d4f871cb6a X86/NativeClock: Improve performance of clock calculations on hot path. 2021-01-02 00:43:47 +01:00
bunnei 1ff341f3dc
Merge pull request #5209 from Morph1984/refactor-controller-connect 
configure_input: Modify controller connection delay
 2021-01-01 13:10:34 -08:00
Morph 904ac1daec configure_input: Modify controller connection delay 
Increases the controller connection delay to 60ms and refactors it to attempt to disconnect all controllers prior to connecting all controllers in HID.
 2021-01-01 06:39:24 -05:00
MerryMage 6d30745d77 memory: Remove MemoryHook 2021-01-01 11:34:38 +00:00
bunnei eb318ffffc
Merge pull request #5249 from ReinUsesLisp/lock-free-pages 
core/memory: Read and write page table atomically
 2021-01-01 02:54:01 -08:00
gal20 5dfb8743cb yuzu/main: fix mouse not showing on move and port citra-emu/citra#5476 2020-12-31 21:16:09 +02:00
Lioncash 8c27a74132 main: Make the loader error dialog fully translatable 
Makes the dialog fully localizable and also adds disambiguation comments
to help translators understand what the formatting specifiers indicate.
 2020-12-31 12:44:31 -05:00
Lioncash 803ac4ca59 main: Tidy up enum comparison 
enum classes are comparable with one another, so these casts aren't
necessary.
 2020-12-31 10:21:15 -05:00
bunnei 60121d8f28
Merge pull request #5264 from 16-Bit-Dog/patch-1 
Make the coding conventions more consistant
 2020-12-31 01:46:53 -08:00
bunnei fb41c82aaa
Merge pull request #5265 from german77/port5509 
Port citra-emu/citra#5509 "Look at direction of analog axis travel instead of instantaneous sample"
 2020-12-30 22:24:30 -08:00
bunnei 25d607f5f6
Merge pull request #5208 from bunnei/service-threads 
Service threads
 2020-12-30 22:06:05 -08:00
ReinUsesLisp cdbee27692 vulkan_instance: Allow different Vulkan versions and enforce 1.1 
For listing the available physical devices we can use Vulkan 1.0.
Now that MoltenVK supports 1.1 we can require it for running games.

Add missing documentation.
 2020-12-31 02:07:34 -03:00
ReinUsesLisp 7344a7c447 vk_device: Use an array to report lacking device limits 
This makes easier to add and tune the required device limits.
 2020-12-31 02:07:34 -03:00
ReinUsesLisp f687392e6f vk_device: Stop initialization when device is not suitable 
VKDevice::IsSuitable was not being called. To address this issue, check
suitability before initialization and throw an exception if it fails.

By doing this, we can deduplicate some code on queue searches.
Previosuly we would first search if a present and graphics queue
existed, then on initialization we would search again to find the index.
 2020-12-31 02:07:33 -03:00
ReinUsesLisp 53ea06dc17 renderer_vulkan: Remove two step initialization on VKDevice 
The Vulkan device abstraction either initializes successfully on the
constructor or throws a Vulkan exception.
 2020-12-31 02:07:33 -03:00
ReinUsesLisp 085adfea00 renderer_vulkan: Throw when enumerating devices fails 
Report device enumeration errors with exceptions to be consistent with
other initialization related function calls. Reduces the amount of code
to maintain.
 2020-12-31 02:07:33 -03:00
ReinUsesLisp 11f0f7598d renderer_vulkan: Initialize surface in separate file 
Move surface initialization code to a separate file. It's unlikely to
use this code outside of Vulkan, but keeping platform-specific code
(Win32, Xlib, Wayland) in its own translation unit keeps things cleaner.
 2020-12-31 02:07:33 -03:00
ReinUsesLisp dce8720780 renderer_vulkan: Catch and report exceptions 
Move more Vulkan code to report errors with exceptions and report them
through a log before notifying it with an error boolean for backwards
compatibility. In the future we can replace the rasterizer two-step
initialization to always use exceptions.
 2020-12-31 02:07:33 -03:00
ReinUsesLisp 47843b4f09 renderer_vulkan: Create debug callback on separate file and throw 
Initialize debug callbacks (messenger) from a separate file. This allows
sharing code with different backends.

Change our Vulkan error handling to use exceptions instead of error
codes, simplifying the initialization process.
 2020-12-31 02:07:33 -03:00
ReinUsesLisp 25f88d99ce renderer_vulkan: Move instance initialization to a separate file 
Simplify Vulkan's backend initialization code by moving it to a separate
file, allowing us to initialize a Vulkan instance from different
backends.
 2020-12-31 02:07:33 -03:00
ReinUsesLisp d1435009ed vulkan_common: Rename renderer_vulkan/wrapper.h to vulkan_common/vulkan_wrapper.h 
Allows sharing Vulkan wrapper code between different rendering backends.
 2020-12-31 02:07:14 -03:00
ReinUsesLisp d937421422 vulkan_common: Move dynamic library load to a separate file 
Allows us to initialize a Vulkan dynamic library from different backends
without duplicating code.
 2020-12-31 02:02:48 -03:00
german aa4c7687ee Port citra-emu/citra#5509 2020-12-30 22:29:20 -06:00
16-Bit-Dog fa5a1a4bfd
Make the coding conventions more consistant 
lut_index had 0 added when nothing was supposed to be added

despite this, index was not added to 0 when nothing was supposed to be added...
 2020-12-30 19:03:26 -05:00
Lioncash bcafef4b94 half_set: Resolve -Wmaybe-uninitialized warnings 2020-12-30 17:59:42 -05:00
Lioncash f0d9ab0717 maxwell_to_vk: Initialize usage variable in SurfaceFormat() 
Silences a -Wmaybe-uninitialized warning
 2020-12-30 13:25:03 -05:00
LC da07977db0
Merge pull request #5251 from ReinUsesLisp/wuninitialized 
cmake: Enforce -Wuninitialized
 2020-12-30 06:34:42 -05:00
ReinUsesLisp 9764c13d6d video_core: Rewrite the texture cache 
The current texture cache has several points that hurt maintainability
and performance. It's easy to break unrelated parts of the cache
when doing minor changes. The cache can easily forget valuable
information about the cached textures by CPU writes or simply by its
normal usage.The current texture cache has several points that hurt
maintainability and performance. It's easy to break unrelated parts
of the cache when doing minor changes. The cache can easily forget
valuable information about the cached textures by CPU writes or simply
by its normal usage.

This commit aims to address those issues.
 2020-12-30 03:38:50 -03:00
ReinUsesLisp ac2e2ebe97 cmake: Enforce -Wuninitialized 2020-12-30 02:58:58 -03:00
ReinUsesLisp 157fc2d785 service/pcie: Fix invalid initialization argument 2020-12-30 02:58:38 -03:00
ReinUsesLisp 9106ac1e6b video_core: Add a delayed destruction ring abstraction 2020-12-30 02:10:19 -03:00
ReinUsesLisp 21b18057f7 host_shaders: Add Vulkan assembler compute shaders 2020-12-30 02:03:50 -03:00
ReinUsesLisp 87ff58b1d7 host_shaders: Add helper to blit depth stencil fragment shader 2020-12-30 02:02:07 -03:00
ReinUsesLisp ae5725b709 host_shaders: Add texture color blit fragment shader 2020-12-30 02:00:48 -03:00
ReinUsesLisp 64fbf319f1 host_shaders: Add shaders to present to the swapchain 2020-12-30 01:59:12 -03:00
ReinUsesLisp 82b7daed9c host_shaders: Add shaders to convert between depth and color images 2020-12-30 01:48:44 -03:00
ReinUsesLisp dc81a90640 host_shaders: Add compute shader to copy BC4 as RG32UI to RGBA8 2020-12-30 01:47:08 -03:00
ReinUsesLisp 5169ce9fcd host_shaders: Add shader to render a full screen triangle 2020-12-30 01:44:09 -03:00
ReinUsesLisp 59c46f9de9 host_shaders: Add pitch linear upload compute shader 2020-12-30 01:41:42 -03:00
ReinUsesLisp 12d16248dd host_shaders: Add block linear upload compute shaders 2020-12-30 01:39:35 -03:00
ReinUsesLisp f20e18f60d host_shaders: Add copyright headers to OpenGL present shaders 2020-12-30 01:35:56 -03:00
ReinUsesLisp 95d156a150 video_core/host_shaders: Add support for prebuilt SPIR-V shaders 
Add support for building SPIR-V shaders from GLSL and generating headers
to include the text of those same GLSL shaders to consume from OpenGL.
 2020-12-30 01:29:07 -03:00
ReinUsesLisp b3587102d1 core/memory: Read and write page table atomically 
Squash attributes into the pointer's integer, making them an uintptr_t
pair containing 2 bits at the bottom and then the pointer. These bits
are currently unused thanks to alignment requirements.

Configure Dynarmic to mask out these bits on pointer reads.

While we are at it, remove some unused attributes carried over from
Citra.

Read/Write and other hot functions use a two step unpacking process that
is less readable to stop MSVC from emitting an extra AND instruction in
the hot path:

 mov         rdi,rcx
 shr         rdx,0Ch
 mov         r8,qword ptr [rax+8]
 mov         rax,qword ptr [r8+rdx*8]
 mov         rdx,rax
-and         al,3
 and         rdx,0FFFFFFFFFFFFFFFCh
 je          Core::Memory::Memory::Impl::Read<unsigned char>
 mov         rax,qword ptr [vaddr]
 movzx       eax,byte ptr [rdx+rax]
 2020-12-29 21:54:49 -03:00
bunnei 85cfd96f62
Merge pull request #5247 from comex/xx-concepts 
k_priority_queue: Fix concepts use
 2020-12-29 16:50:20 -08:00
bunnei 82e0eeed21 hle: kernel: service_thread: Make thread naming more consistent. 2020-12-29 16:46:29 -08:00
bunnei a2a0f5318d hle: kernel: Manage service threads on another thread. 
- This is to allow service threads to defer destruction of themselves.
 2020-12-29 16:46:29 -08:00
bunnei 69e82d01d5 common: ThreadWorker: Add class to help do asynchronous work. 2020-12-29 16:46:29 -08:00
bunnei b02464f685
Merge pull request #5246 from comex/xx-include 
Add missing include of "core/hle/kernel/kernel.h"
 2020-12-29 16:43:17 -08:00
bunnei c192da3f82 hle: kernel: Manage host thread IDs using TLS. 
- Avoids the need to have a large map of host to guest thread IDs.
 2020-12-29 15:55:30 -08:00
comex 388cf58b31 k_priority_queue: Fix concepts use 
- For `std::same_as`, add missing include of `<concepts>`.

- For `std::convertible_to`, create a replacement in `common/concepts.h`
  and use that instead.

  This would also be found in `<concepts>`, but unlike `std::same_as`,
  `std::convertible_to` is not yet implemented in libc++, LLVM's STL
  implementation - not even in master.  (In fact, `std::same_as` is the
  *only* concept currently implemented.  For some reason.)
 2020-12-29 14:33:41 -05:00
comex b36896b90e Add missing include of "core/hle/kernel/kernel.h" 
This is needed as the header invokes methods on KernelCore.
 2020-12-29 14:22:35 -05:00
LC aa87278bf0
Merge pull request #5245 from ameerj/sleepthread-log 
svc: demote SleepThread log to LOG_TRACE
 2020-12-29 14:03:24 -05:00
ameerj 0383363a8f svc: demote SleepThread log to LOG_TRACE 
This log is called often, and introduces a lot of noise when debug logging is enabled, making it difficult to see other debug logs.
 2020-12-29 14:01:56 -05:00
bunnei 22ba437aa4
Merge pull request #5236 from gal20/udp_client_patch 
input_common: process udp packets only for the correct pad
 2020-12-29 02:51:40 -08:00
bunnei dfdac7d38a hle: kernel: Move ServiceThread ownership to KernelCore. 
- Fixes a circular dependency which prevented threads from being released on shutdown.
 2020-12-29 01:12:39 -08:00
bunnei f57be2e626 hle: kernel: service_thread: Add thread name and take weak_ptr of ServerSession. 2020-12-29 01:06:39 -08:00
bunnei 7d77a3f88f hle: service: Acquire and release a lock on requests. 
- This makes it such that we can safely access service members from CoreTiming thread.
 2020-12-28 21:33:34 -08:00
bunnei c7a06908ae audio_core: stream: Ensure buffer is valid before release. 2020-12-28 21:33:34 -08:00
bunnei 06f8c3dc01 core: Do not reset device_memory on shutdown. 
- This will be reset on initialization.
 2020-12-28 21:33:34 -08:00
bunnei d0649d0971 core: hle: kernel: Clear process list on boot. 2020-12-28 21:33:34 -08:00
bunnei 954341763a gpu: gpu_thread: Ensure MicroProfile is shutdown on exit. 2020-12-28 21:33:34 -08:00
bunnei 994a9fec4e hle: service: vi: Refactor to grab buffer only once. 2020-12-28 21:33:34 -08:00
bunnei 6433b1dfd6 service: nvflinger: Improve synchronization for BufferQueue. 
- Use proper mechanisms for blocking on DequeueBuffer.
- Ensure service thread terminates on emulation Shutdown.
 2020-12-28 21:33:34 -08:00
bunnei bea51d948d hle: service: Ensure system is powered on before writing IPC result. 2020-12-28 16:33:48 -08:00
bunnei 6d2f9428c5 core: kernel: Clear process list earlier. 2020-12-28 16:33:48 -08:00
bunnei 4991620f89 video_core: gpu_thread: Do not wait when system is powered down. 2020-12-28 16:33:48 -08:00
bunnei 916438a9de core: settings: Untangle multicore from asynchronous GPU. 
- Now that GPU is always threaded, we can support multicore with synchronous GPU.
 2020-12-28 16:33:48 -08:00
bunnei 40571c073f video_core: gpu: Implement synchronous mode using threaded GPU. 2020-12-28 16:33:48 -08:00
bunnei 14c825bd1c video_core: gpu: Refactor out synchronous/asynchronous GPU implementations. 
- We must always use a GPU thread now, even with synchronous GPU.
 2020-12-28 16:33:48 -08:00
bunnei 5d4715cc6a hle: kernel: hle_ipc: Remove SleepClientThread. 
- This was kind of hacky, and no longer is necessary with service threads.
 2020-12-28 16:33:48 -08:00
bunnei 87d6588cb5 hle: service: bsd: Update to work with service threads, removing SleepClientThread. 2020-12-28 16:33:48 -08:00
bunnei 0c81b83ca9 hle: service: nvdrv: Revert #4981 to remove usage of SleepClientThread. 
- Note, this always processes the ioctl right away, which fixes BotW 1.0.0 issues.
 2020-12-28 16:33:48 -08:00
bunnei 8bc3d66354 hle: kernel: service_thread: Add parameter for thread pool size. 2020-12-28 16:33:47 -08:00
bunnei 19a8f03ad5 hle: service: nvflinger: Refactor locking and interfaces. 2020-12-28 16:33:47 -08:00
bunnei b377da042b hle: service: vi: Remove usage of SleepClientThread. 2020-12-28 16:33:47 -08:00
bunnei 28281ae250 core: hle: server_session: Use separate threads for each service connection. 2020-12-28 16:33:47 -08:00
gal20 1defd0847a udp client: process packets only for the correct pad 2020-12-27 22:22:48 +02:00
german 80fece4e08 Allow to invert analog axis with right click 2020-12-26 17:46:14 -06:00
ReinUsesLisp 661483f313 renderer_vulkan/fixed_pipeline_state: Move enabled bindings to static state 
Without using VK_EXT_robustness2, we can't consider the 'enabled' (not
null) vertex buffers as dynamic state, as this leads to invalid Vulkan
state. Move this to static state that is always hashed and compared in
the pipeline key.

The bits for enabled vertex buffers are moved into the attribute state
bitfield. This is not 'correct' as it's not an attribute state, but that
struct has bits to spare, and it's used in an array of 32 elements (the
exact same number of vertex buffer bindings).
 2020-12-25 23:34:38 -03:00
Morph ff3aa5d380 yuzu/main: Add basic command line arguments 
The following command line arguments are supported:

yuzu.exe "path_to_game" - Launches a game at "path_to_game"
yuzu.exe -f - Launches the next game in fullscreen
yuzu.exe -g "path_to_game" - Launches a game at "path_to_game"
yuzu.exe -f -g "path_to_game" - Launches a game at "path_to_game" in fullscreen
 2020-12-25 15:41:00 -05:00
Rodrigo Locatti 0dc4ab42cc
Merge pull request #5226 from ReinUsesLisp/c4715-vc 
video_core: Enforce C4715 (not all control paths return a value)
 2020-12-25 03:11:47 -03:00
Rodrigo Locatti 453560fb3a
Merge pull request #5225 from ReinUsesLisp/always-vulkan 
cmake: Always enable Vulkan
 2020-12-25 02:52:29 -03:00
bunnei c8a4967c9d
core: memory: Ensure thread safe access when pages are rasterizer cached (#5206) 
* core: memory: Ensure thread safe access when pages are rasterizer cached.
 2020-12-24 21:51:49 -08:00
ReinUsesLisp 1b9e08ab78 cmake: Always enable Vulkan 
Removes the unnecesary burden of maintaining separate #ifdef paths and
allows us sharing generic Vulkan code across APIs.
 2020-12-24 21:07:24 -03:00
ReinUsesLisp 1e191cc837 video_core: Enforce C4715 (not all control paths return a value) 
Most of the time people write code that always returns a value,
terminates execution, throws an exception, or uses an unconventional
jump primitive.

This is not always true when we build without asserts on mainline builds.
To avoid introducing undefined behavior on our most used builds, enforce
this warning signalling an error and stopping the build from shipping.
 2020-12-24 21:01:23 -03:00
ReinUsesLisp 5dbda22659 vk_shader_decompiler: Silence warning when compiling without asserts 2020-12-24 21:01:09 -03:00
bunnei 5836530a87
Merge pull request #5217 from lat9nq/save-on-boot 
yuzu/main: Save settings when starting guest
 2020-12-23 01:45:24 -08:00
lat9nq 17badbc442 yuzu/main: Improve menubar access keys 
Adds a unique access key to each action within each menu. A few actions
already had their own access key, so those were untouched.
 2020-12-22 19:32:58 -05:00
german 64fad8cfe9 Add option to reset window size to 1080p 2020-12-22 17:06:48 -06:00
bunnei 29ccc7673f
Merge pull request #5042 from Morph1984/project-aether 
Project Aether: Reimplementation of the Web Browser Applet
 2020-12-21 23:47:10 -08:00
lat9nq c243932b41 yuzu/main: Save settings when starting guest 
Saves UISettings and Settings when booting a guest. Moves updating
UISettings::values from GMainWindow::closeEvent into its own function,
then reuses it in GMainWindow::BootGame.
 2020-12-22 02:29:30 -05:00
bunnei 1279c7ce7a
Merge pull request #5131 from bunnei/scheduler-rewrite 
Rewrite Kernel scheduler based on Atmosphere
 2020-12-20 20:57:54 -08:00
bunnei c3e201a829
Merge pull request #5201 from ameerj/bufferq-refactor 
vi/buffer_queue: Buffer queue management refactor
 2020-12-20 15:48:39 -08:00
FearlessTobi 10b0ab7926 yuzu: Remove gdbstub configuration 
The gdbstub itself was removed with https://github.com/yuzu-emu/yuzu/pull/5028.
This PR just removes the remaining gdb configuration code from the emulator and the UI.
 2020-12-19 19:19:42 +01:00
Morph 82fa9f8d56 applets/web: Implement the online web browser applet 2020-12-18 10:33:28 -05:00
Morph 51cddcb8b8 applets/web: Fix keyboard to emulated controller input 2020-12-18 10:33:28 -05:00
Morph 2ddd83cdfe main: Add the ability to disable the web applet 
This should only be used for Super Mario 3D All-Stars. This is a temporary solution until it can be implemented properly.
 2020-12-18 10:33:28 -05:00
Morph 8b95bf041d main, applets/web: Re-add progress dialog for RomFS extraction 2020-12-18 10:33:28 -05:00
Morph 93cb783853 applets/web: Implement the Qt web browser applet frontend 2020-12-18 10:33:28 -05:00
Morph d5e0923e3d web_browser_scripts: Add injection scripts for the web browser 2020-12-18 10:33:28 -05:00
Morph d46ca5a015 pl_u, applets/web: Decrypt shared fonts to TTF files 2020-12-18 10:33:28 -05:00
Morph 46183294b2 ns_vm: Stub NeedsUpdateVulnerability 
This is used to force system updates on launching the web browser. We do not care about system updates so this can be set to false.
 2020-12-18 10:33:28 -05:00
Morph f9653a4417 frontend/input_interpreter: Add InputInterpreter API 
The InputInterpreter class interfaces with HID to retrieve button press states. Input is intended to be polled every 50ms so that a button is considered to be held down after 400ms has elapsed since the initial button press and subsequent repeated presses occur every 50ms.

Co-authored-by: Chloe <25727384+ogniK5377@users.noreply.github.com>
 2020-12-18 10:33:28 -05:00
Morph 54ea3c47c8 controllers/npad: Make press_state atomic 2020-12-18 10:33:28 -05:00
Morph 5836786246 util: Add URL Request Interceptor for QWebEngine 2020-12-18 10:33:28 -05:00
Morph 51a7681957 bootmanager: Add a check whether loading is complete 2020-12-18 10:33:28 -05:00
Morph d6d1a8e02c applets/web: Implement the default web browser applet frontend 2020-12-18 10:33:28 -05:00
Morph 89df483567 applets/web: Implement the offline browser applet backend 2020-12-18 10:33:27 -05:00
Morph a5750f437d applets/web: Initial implementation of the web browser applet 2020-12-18 10:33:27 -05:00
Morph ccb439efb0 applets: Remove the previous web browser applet implementation 2020-12-18 10:33:27 -05:00
Morph 79316be18c system_archive: Add + and - buttons to the Nintendo Extended OSS font 2020-12-18 02:55:48 -05:00
ameerj 873ad1272e buffer_queue: better use of std::array 2020-12-18 00:12:14 -05:00
ameerj 8cb683f3b9 Overwrite slots instead of queuing them, add disconnect signal 
Fix for Katana Zero and Yoshi's Crafted World
 2020-12-17 14:22:46 -05:00
Morph 5d29d2111c system_archive: Update Nintendo Extended OSS font 
Co-authored-by: Its-Rei <kupfel@gmail.com>
 2020-12-17 08:58:13 -05:00
bunnei f3db273753
Merge pull request #5190 from Morph1984/validate_device_handle 
controllers/npad: Validate device handles before use
 2020-12-15 16:40:11 -08:00
bunnei 2e1b998d5e
Merge pull request #5119 from Morph1984/fs-opendatastoragewithprogramindex 
fsp_srv: Implement OpenDataStorageWithProgramIndex
 2020-12-15 11:07:03 -08:00
bunnei 37bec068c2
Merge pull request #5157 from lioncash/array-dirty 
maxwell_3d: Remove unused dirty_pointer array
 2020-12-15 00:35:47 -08:00
bunnei df6427d30b
Merge pull request #5168 from Morph1984/aoc-PurchaseEventManager 
aoc_u: Stub IPurchaseEventManager and its service commands
 2020-12-14 16:08:38 -08:00
lat9nq 292dd642ce cmake: Fix generating CMake configs and linking with Boost 
Fixes regression by 761206cf81, causing
yuzu to not build on Linux with any version of Boost except a cached
1.73 Conan version from before about a day ago.

Moves the Boost requirement out of the `REQUIRED_LIBS` psuedo-2D-array
for Conan to instead be manually configured, using Conan as a fallback
solution if the system does not meet our requirements.

Requires any update from the linux-fresh container in order to build.

**DO NOT MERGE** until someone with the MSVC toolchain can verify this
works there, too.
 2020-12-13 01:28:51 -05:00
bunnei 761206cf81
common: Update CMakeList to fix build issue with Boost. 2020-12-12 11:50:07 -08:00
Morph 1c773c0869 controllers/npad: Validate device handles before use 
Some games such as NEKOPARA Vol. 3 send invalid device handles when calling InitializeVibrationDevice. Introduce a check to validate the device handle before use.
 2020-12-12 07:05:38 -05:00
bunnei 69b46dd607
Merge pull request #5183 from lioncash/alias2 
vfs: Use existing type aliases consistently
 2020-12-12 01:54:28 -08:00
bunnei c918c6480f
Merge pull request #5187 from Morph1984/revert-stdfs 
fs: Revert all std::filesystem changes
 2020-12-11 20:07:37 -08:00
bunnei 37194dd4e9
Merge pull request #5172 from lioncash/svc-wide 
svc: Remove unnecessary casts
 2020-12-11 17:39:30 -08:00
Morph 4de079b256 Revert "Merge pull request #5173 from lioncash/common-fs" 
This reverts commit ce5fcb6bb2, reversing
changes made to 6f41763061.
 2020-12-11 20:24:22 -05:00
Morph 8941cdb7d2 Revert "Merge pull request #5174 from ReinUsesLisp/fs-fix" 
This reverts commit 5fe55b16a1, reversing
changes made to e94dd7e2c4.
 2020-12-11 20:24:22 -05:00
Morph dfee6321cd Revert "Merge pull request #5176 from Morph1984/fix-createfile" 
This reverts commit 6d6115475b, reversing
changes made to 5fe55b16a1.
 2020-12-11 20:24:22 -05:00
Morph 0195038c07 Revert "Merge pull request #5179 from ReinUsesLisp/fs-path" 
This reverts commit 4e94d0d53a, reversing
changes made to 6d6115475b.
 2020-12-11 20:21:46 -05:00
Morph ac3ec5ed13 Revert "Merge pull request #5181 from Morph1984/5174-review" 
This reverts commit cdb36aef9e, reversing
changes made to 5e9b77129f.
 2020-12-11 20:21:21 -05:00
bunnei cdb36aef9e
Merge pull request #5181 from Morph1984/5174-review 
common/file_util: Address review comments of #5174
 2020-12-10 15:52:11 -08:00
bunnei 2d47a5fd41
Merge pull request #5123 from Morph1984/nim-IsLargeResourceAvailable 
nim: Stub IsLargeResourceAvailable
 2020-12-10 11:34:18 -08:00
bunnei d1a2b3fb18
Merge pull request #5162 from lioncash/copy-shader 
gl_shader_decompiler: Elide unnecessary copies within DeclareConstantBuffers()
 2020-12-10 00:11:11 -08:00
Lioncash b1657b8c6b vfs: Use existing type aliases consistently 
Makes use of the VirtualDir and VirtualFile aliases across the board
instead of having a few isolated places that don't use it.
 2020-12-10 01:44:43 -05:00
Morph ec8548b414 common/file_util: Simplify the behavior of CreateFullPath 2020-12-09 19:28:11 -05:00
ReinUsesLisp bab9cae71f common/file_util: Let std::filesystem cast from UTF16 to std::string 
Fix invalid encoding paths when iterating over a directory on Windows.
 2020-12-09 18:52:36 -03:00
Morph b06d6e3646 vfs_real: Fix CreateFile for files without a file extension 2020-12-09 06:34:49 -05:00
ReinUsesLisp 5329834376 common/file_util: Fix and deprecate CreateFullPath, add CreateDirs 
Fix CreateFullPath to have its intended previous behavior (whatever
that was), and deprecate it in favor of the new CreateDirs function.

Unlike CreateDir, CreateDirs is marked as [[nodiscard]] to avoid new
code ignoring its result value.
 2020-12-09 05:42:03 -03:00
ReinUsesLisp 52f13f2339 common/file_util: Succeed on CreateDir when the directory exists 2020-12-09 05:21:08 -03:00
Rodrigo Locatti e94dd7e2c4
Merge pull request #5142 from comex/xx-poll-events 
network, sockets: Replace `POLL_IN`, `POLL_OUT`, etc. constants with an `enum class PollEvents`
 2020-12-09 03:52:20 -03:00
Rodrigo Locatti ce5fcb6bb2
Merge pull request #5173 from lioncash/common-fs 
common/file_util: Make use of std::filesystem
 2020-12-09 03:47:21 -03:00
Lioncash 20aad9e01a file_util: Migrate remaining file handling functions over to std::filesystem 
Converts creation and deletion functions over to std::filesystem,
simplifying our file-handling code.

Notably with this, CopyDir will now function on Windows.
 2020-12-09 01:24:05 -05:00
bunnei 6f41763061
Merge pull request #5166 from lioncash/log-cast 
core: Remove unnecessary enum casts in log calls
 2020-12-08 21:58:13 -08:00
bunnei 05a703e15d
Merge pull request #5135 from Morph1984/applets-shadow 
applets: Resolve variable shadowing
 2020-12-08 17:43:59 -08:00
Lioncash 0e54aa17e6 file_util: Migrate Exists() and IsDirectory() over to std::filesystem 
Greatly simplifies our file-handling code for these functions.
 2020-12-08 18:36:53 -05:00
Lioncash 2de124e223 svc: Remove unnecessary casts 
Simplifies and removes some casts. In all cases, these were generally
widening from a 32-bit unsigned type to a 64-bit unsigned type, so no
information would be lost from the conversion.
 2020-12-08 15:42:10 -05:00
bunnei 6057dc46e5
Merge pull request #5167 from lioncash/doc-memory 
memory: Resolve -Wdocumentation warning for Write()
 2020-12-08 11:47:04 -08:00
Morph deff708cbe IPurchaseEventManager: Implement GetPurchasedEventReadableHandle 
- Used by Pokémon Café Mix
- Used by DOOM: Eternal
 2020-12-08 13:39:19 -05:00
Morph a9cfe06aaf IPurchaseEventManager: Stub Set(Default)DeliveryTarget 
- Used by Pokémon Café Mix
- Used by DOOM: Eternal
 2020-12-08 13:39:13 -05:00
Morph 009bdb3558 aoc_u: Stub Create(Permanent)EcPurchasedEventManager 
- Used by Pokémon Café Mix
- Used by DOOM: Eternal
 2020-12-08 13:39:07 -05:00
Lioncash a44ff5ed31 memory: Resolve -Wdocumentation warning for Write() 
Write() doesn't return anything, so the @returns tag shouldn't be
present.
 2020-12-08 12:44:58 -05:00
bunnei 00c6254129
Merge pull request #5156 from comex/xx-raws 
configure_motion_touch: Fix unescaped backslash in regex
 2020-12-08 09:39:47 -08:00
Morph e15039372e fsp_srv: Implement OpenDataStorageWithProgramIndex 
- Used by RollerCoaster Tycoon 3: Complete Edition
 2020-12-08 08:19:05 -05:00
Morph 0eb6c6cd83 file_sys: Consolidate common Title ID operations 2020-12-08 08:19:05 -05:00
Morph 51e6f8271a
Merge pull request #5165 from lioncash/copy-controller 
controller: Avoid unnecessary copies in ConfigurationComplete()
 2020-12-08 20:48:45 +08:00
Lioncash 6b7320add4 core: Remove unnecessary enum casts in log calls 
Follows the video core PR. fmt doesn't require casts for enum classes
anymore, so we can remove quite a few casts.
 2020-12-07 23:02:23 -05:00
Lioncash 215cfbb757 controller: Use std::move within ConvertToFrontendParameters() 
Avoids unnecessary copies.
 2020-12-07 22:04:16 -05:00
Lioncash 97dd67ad1c controller: Avoid unnecessary copies in ConfigurationComplete() 
Avoids unnecessary 1072 byte copies when querying info about
controllers.
 2020-12-07 22:02:58 -05:00
Morph 607bb8d14b
Merge pull request #5020 from german77/AnalogfromButtonFix 
Disable analog joystick from buttons by default
 2020-12-08 10:30:21 +08:00
german b57ba7bfb6 Disable analog joystick from buttons by default 2020-12-07 19:34:52 -06:00
Rodrigo Locatti 3415890dd5
Merge pull request #5164 from lioncash/contains 
video_core: Make use of ordered container contains() where applicable
 2020-12-07 21:55:51 -03:00
Rodrigo Locatti 4bd74ed4c7
Merge pull request #5163 from lioncash/concat 
ast: Improve string concat readability in operator()
 2020-12-07 21:55:21 -03:00
bunnei f782aecf4d
Merge pull request #5153 from comex/xx-unix 
CMakeLists,network: Create YUZU_UNIX macro to replace __unix__
 2020-12-07 15:32:06 -08:00
Lioncash 09fa1d6a73 video_core: Make use of ordered container contains() where applicable 
With C++20, we can use the more concise contains() member function
instead of comparing the result of the find() call with the end
iterator.
 2020-12-07 16:30:39 -05:00
Lioncash 45c5b084fd ast: Improve string concat readability in operator() 
Provides an in-place format string to make it more pleasant to read.
 2020-12-07 16:15:28 -05:00
Lioncash edcbd47800 gl_shader_decompiler: Elide unnecessary copies within DeclareConstantBuffers() 
Resolves a -Wrange-loop-analysis warning.
 2020-12-07 14:01:52 -05:00
bunnei 5cd051eced
Merge pull request #5149 from comex/xx-map-interval 
map_interval: Change field order to address uninitialized field warning
 2020-12-07 10:14:02 -08:00
Rodrigo Locatti 12f3b13995
Merge pull request #5159 from lioncash/move-amend 
shader_ir: std::move node within DeclareAmend()
 2020-12-07 04:58:01 -03:00
Lioncash 5d2f18fbcd buffer_block: Mark interface as nodiscard where applicable 
Prevents logic errors from occurring from unused values.
 2020-12-07 01:53:40 -05:00
Lioncash 3954f14c6d buffer_block: Remove unnecessary includes 
Reduces the amount of dependencies the header pulls in.
 2020-12-07 01:52:16 -05:00
Rodrigo Locatti 9ae6224f12
Merge pull request #5158 from lioncash/video-fmt 
video_core: Remove unnecessary enum class casting in logging messages
 2020-12-07 03:35:25 -03:00
bunnei a58d57a60d
Merge pull request #5148 from comex/xx-unused-fields 
core: Mark unused fields as [[maybe_unused]]
 2020-12-06 22:33:00 -08:00
bunnei 24cabf5e2f
Merge pull request #5154 from comex/xx-ipc 
hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cpp
 2020-12-06 22:32:04 -08:00
Lioncash 7234f436aa shader_ir: std::move node within DeclareAmend() 
Same behavior, but elides an unnecessary atomic reference count
increment and decrement.
 2020-12-07 00:51:03 -05:00
Lioncash 4c5f5c9bf3 video_core: Remove unnecessary enum class casting in logging messages 
fmt now automatically prints the numeric value of an enum class member
by default, so we don't need to use casts any more.

Reduces the line noise a bit.
 2020-12-07 00:41:50 -05:00
LC 8a00a0ade6
Merge pull request #5147 from comex/xx-purevirt 
nvdrv: Remove useless re-declaration of pure virtual methods that were already declared in the superclass
 2020-12-07 00:08:46 -05:00
LC 43f0b42088
Merge pull request #5150 from comex/xx-boxcat 
boxcat: Avoid unnecessary object copy
 2020-12-07 00:07:39 -05:00
LC 23aabe85e6
Merge pull request #5152 from comex/xx-override 
renderer_vulkan: Add missing `override` specifier
 2020-12-07 00:07:17 -05:00
LC 69af6ada2f
Merge pull request #5136 from lioncash/video-shadow3 
video_core: Resolve more variable shadowing scenarios pt.3
 2020-12-07 00:06:53 -05:00
Lioncash 9e7a1f1351 maxwell_3d: Move member variables to end of class 
Follows our established coding style.
 2020-12-06 20:56:00 -05:00
Lioncash ce0712bf95 maxwell_3d: Resolve -Wdocumentation warning 
Removes a documentation comment for a non-existent member.
 2020-12-06 20:48:12 -05:00
Lioncash bcc5c4403a maxwell_3d: Remove unused dirty_pointer array 
This is unused and removing it shrinks the structure by 3584 bytes.
 2020-12-06 20:46:57 -05:00
comex 2dce2be138 configure_motion_touch: Fix unescaped backslash in regex 
Since this is inside a string literal, backslashes that are part of
regex syntax have to be escaped.  But that's ugly, so convert to a raw
string instead.
 2020-12-06 19:25:48 -05:00
comex 0791082b43 network, sockets: Replace `POLL_IN`, `POLL_OUT`, etc. constants with an `enum class PollEvents` 
Actually, two enum classes, since for some reason there are two separate
yet identical `PollFD` types used in the codebase.  I get that one is
ABI-compatible with the Switch while the other is an abstract type used
for the host, but why not use `WSAPOLLFD` directly for the latter?

Anyway, why make this change?  Because on Apple platforms, `POLL_IN`,
`POLL_OUT`, etc. (with an underscore) are defined as macros in
<sys/signal.h>.  (This is inherited from FreeBSD.)  So defining
a variable with the same name causes a compile error.

I could just rename the variables, but while I was at it I thought I
might as well switch to an enum for stronger typing.

Also, change the type used for values copied directly to/from the
`events` and `revents` fields of the host *native*
`pollfd`/`WSASPOLLFD`, from `u32` to `short`, as `short` is the correct
canonical type on both Unix and Windows.
 2020-12-06 19:14:42 -05:00
comex e31cb50405 Fix "explicitly defaulted but implicitly deleted" warning 
`PhysicalCore`'s move assignment operator was declared as `= default`,
but was implicitly deleted because `PhysicalCore` has fields
of reference type.  Switch to explicitly deleting it to avoid a Clang
warning.

The move *constructor* is still defaulted, and is required to exist due
to the use of `std::vector<PhysicalCore>`.
 2020-12-06 19:02:04 -05:00
comex 3373149fdc hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cpp 
- Add a type check so that calling Push with an invalid type produces a
  compile error rather than a linker error.

- vi.cpp was calling Push with a variable of type `std::size_t`.
  There's no explicit overload for `size_t`, but there is one for `u64`,
  which on most platforms is the same type as `size_t`.  On macOS,
  however, it isn't: both types are 64 bits, but `size_t` is `unsigned
  long` and `u64` is `unsigned long long`.  Regardless, it makes more
  sense to explicitly use `u64` here instead of `size_t`.
 2020-12-06 18:59:22 -05:00
comex 0e122c13ad CMakeLists,network: Create YUZU_UNIX macro to replace __unix__ 
__unix__ is not predefined on Apple platforms even though they are Unix.
 2020-12-06 18:56:40 -05:00
comex eea5122d1b renderer_vulkan: Add missing `override` specifier 2020-12-06 18:38:52 -05:00
comex b8fbf6969c map_interval: Change field order to address uninitialized field warning 
Clang complains about `new_chunk`'s constructor using the
then-uninitialized `first_chunk` (even though it's just to get a pointer
into it).
 2020-12-06 18:37:23 -05:00
comex feac654ba0 core: Mark unused fields as [[maybe_unused]] 2020-12-06 18:36:10 -05:00
comex 5cb1a343d1 boxcat: Avoid unnecessary object copy 2020-12-06 18:31:13 -05:00
comex 716ae72aac nvdrv: Remove useless re-declaration of pure virtual methods that were already declared in the superclass 2020-12-06 18:24:33 -05:00
comex d637114c17 video_core: Adjust `NUM` macro to avoid Clang warning 
The previous definition was:

    #define NUM(field_name) (sizeof(Maxwell3D::Regs::field_name) / sizeof(u32))

In cases where `field_name` happens to refer to an array, Clang thinks
`sizeof(an array value) / sizeof(a type)` is an instance of the idiom
where `sizeof` is used to compute an array length.  So it thinks the
type in the denominator ought to be the array element type, and warns if
it isn't, assuming this is a mistake.

In reality, `NUM` is not used to get array lengths at all, so there is no
mistake.  Silence the warning by applying Clang's suggested workaround
of parenthesizing the denominator.
 2020-12-06 18:24:16 -05:00
Rodrigo Locatti 7e5f595b31
Merge pull request #5143 from comex/xx-users-size 
yuzu_cmd: Remove 'users_size'
 2020-12-06 19:34:53 -03:00
Rodrigo Locatti 88959b0047
Merge pull request #5141 from comex/xx-true-false 
maxwell_dma: Rename RenderEnable::Mode::FALSE and TRUE to avoid name conflict
 2020-12-06 19:34:24 -03:00
bunnei dd05c7ec79
Merge pull request #5140 from FearlessTobi/port-5577 
Port citra-emu/citra#5577: "Update cubeb and request a persistent stream session"
 2020-12-06 01:53:02 -08:00
bunnei 53a04d6b5d
Merge pull request #5132 from lioncash/xbyak-abi 
xbyak_abi: Avoid implicit sign conversions
 2020-12-06 01:22:43 -08:00
bunnei 1bdb756d28 hle: kernel: Process: Various style fixes based on code review feedback. 2020-12-06 00:27:13 -08:00
bunnei d4ae0ae0e9 core: cpu_manager: Fix a typo in PreemptSingleCore, which broke many games. 
- We were reload'ing the old current scheduler, which may have changed.
 2020-12-06 00:27:13 -08:00
bunnei 9b492430bb hle: kernel: Thread: Various style fixes based on code review feedback. 2020-12-06 00:27:13 -08:00
bunnei ed4d1e2ade hle: kernel: KScopedSchedulerLockAndSleep: Various style fixes based on code review feedback. 2020-12-06 00:27:13 -08:00
bunnei b1b4f2337e hle: kernel: KScopedLock: Various style fixes based on code review feedback. 2020-12-06 00:27:13 -08:00
bunnei 165d8485f0 hle: kernel: KAbstractSchedulerLock: Various style fixes based on code review feedback. 2020-12-06 00:27:13 -08:00
bunnei 960500cfd2 hle: kernel: KScheduler: Various style fixes based on code review feedback. 2020-12-06 00:27:13 -08:00
bunnei 8fd921557f hle: kernel: KPriorityQueue: Various style fixes based on code review feedback. 2020-12-06 00:27:13 -08:00
bunnei 4d3be1816c hle: kernel: KAffinityMask: Various style fixes based on code review feedback. 2020-12-06 00:27:13 -08:00
bunnei 357d79fb6e hle: kernel: GlobalSchedulerContext: Various style fixes based on code review feedback. 2020-12-06 00:27:13 -08:00
bunnei d2c0c94f0b common: BitSet: Various style fixes based on code review feedback. 2020-12-06 00:27:13 -08:00
bunnei b1326d9230 hle: kernel: Use C++ style comments in KScheduler, etc. 2020-12-06 00:03:24 -08:00
bunnei bc59ca92b6 kernel: KScopedSchedulerLockAndSleep: Remove unused ctor. 2020-12-06 00:03:24 -08:00
bunnei b9b7e4f915 kernel: time_manager: Add missing lock guards. 2020-12-06 00:03:24 -08:00
bunnei ccce6cb3be hle: kernel: Migrate to KScopedSchedulerLock. 2020-12-06 00:03:24 -08:00
bunnei 4756cb203e hle: kernel: Separate KScopedSchedulerLockAndSleep from k_scheduler. 2020-12-06 00:03:24 -08:00
bunnei 8d3e06349e hle: kernel: Separate KScheduler from GlobalSchedulerContext class. 2020-12-06 00:03:24 -08:00
bunnei 9e29e36a78 hle: kernel: Rewrite scheduler implementation based on Mesopshere. 2020-12-06 00:03:24 -08:00
bunnei c10a37e5b6 hle: kernel: physical_core: Clear exclusive state after each run. 
- This is closer to pre-multicore behavior, and works a bit better.
 2020-12-06 00:03:24 -08:00
bunnei 7e5d0f1fe3 hle: kernel: Port KAbstractSchedulerLock from Mesosphere. 2020-12-06 00:03:24 -08:00
bunnei 39d356782e hle: kernel: svc: Remove reschedule on svcBreak. 
- This breaks things, and is unnecessary, since emulation will be done at this point.
 2020-12-06 00:03:24 -08:00
bunnei d58a609ae4 hle: kernel: process: Add schedule count tracking, to be used for yield impl. 2020-12-06 00:03:24 -08:00
bunnei 493263f415 hle: kernel: svc: Remove unnecessary hack in svcSleep. 2020-12-06 00:03:24 -08:00
bunnei a3ccac3eb7 common: Port KPriorityQueue from Mesosphere. 2020-12-06 00:03:24 -08:00
bunnei 8dbfa4e1a4 common: Port BitSet from Mesosphere. 2020-12-06 00:03:24 -08:00
bunnei e18ee8d681 hle: kernel: Port KAffinityMask from Mesosphere. 2020-12-06 00:03:24 -08:00
comex a6e6cd5788 maxwell_dma: Rename RenderEnable::Mode::FALSE and TRUE to avoid name conflict 
On Apple platforms, FALSE and TRUE are defined as macros by
<mach/boolean.h>, which is included by various system headers.

Note that there appear to be no actual users of the names to fix up.
 2020-12-05 17:59:02 -05:00
comex 9dc69fa07c yuzu_cmd: Remove 'users_size' 
Specifically:

    const auto size = sdl2_config->GetInteger("System", "users_size", 0);

The variable is never used, producing a warning.  I wondered if this
ought to be assigning something to in `Settings`, but nothing else in
the codebase ever mentions a setting called "users_size", so I guess
it's safe to remove...
 2020-12-05 17:50:39 -05:00
Vitor Kiguchi a1e7360273 Update cubeb and request a persistent stream session 2020-12-05 22:26:41 +01:00
Lioncash f95602f152 video_core: Resolve more variable shadowing scenarios pt.3 
Cleans out the rest of the occurrences of variable shadowing and makes
any further occurrences of shadowing compiler errors.
 2020-12-05 16:02:23 -05:00
Lioncash c277d7d171 game_list_p: Resolve deprecated usage of QVariant operator< 
This is designated as obsolete in Qt's docs (see:
https://doc.qt.io/qt-5/qvariant-obsolete.html#operator-lt)
 2020-12-05 15:38:58 -05:00
Morph f6d4a289d5 applets: Resolve variable shadowing 2020-12-05 08:37:13 -05:00
Lioncash 414a87a4f4 video_core: Resolve more variable shadowing scenarios pt.2 
Migrates the video core code closer to enabling variable shadowing
warnings as errors.

This primarily sorts out shadowing occurrences within the Vulkan code.
 2020-12-05 06:39:35 -05:00
bunnei e6a896c4bd
Merge pull request #5124 from lioncash/video-shadow 
video_core: Resolve more variable shadowing scenarios
 2020-12-05 00:48:08 -08:00
bunnei 63419e144f
Merge pull request #5127 from FearlessTobi/port-5617 
Port citra-emu/citra#5617: "Fix telemetry-related exit crash from use-after-free"
 2020-12-04 21:57:40 -08:00
Lioncash 2c375013dd xbyak_abi: Shorten std::size_t to size_t 
Makes for less reading.
 2020-12-05 00:43:55 -05:00
Lioncash b126267442 xbyak_abi: Avoid implicit sign conversions 2020-12-05 00:43:41 -05:00
Chloe Marcec 7fbeb489d3 system_version: Update to 11.0.0 2020-12-05 16:08:03 +11:00
FearlessTobi 37d672bf08 Fix telemetry-related exit crash from use-after-free 
Co-Authored-By: xperia64 <xperia64@users.noreply.github.com>
 2020-12-05 02:42:50 +01:00
Lioncash 94af77aa7c codec: Remove deprecated usage of AVCodecContext::refcounted_frames 
This was only necessary for use with the
avcodec_decode_video2/avcoded_decode_audio4 APIs which are also
deprecated.

Given we use avcodec_send_packet/avcodec_receive_frame, this isn't
necessary, this is even indicated directly within the FFmpeg API changes
document here on 2017-09-26:

https://github.com/FFmpeg/FFmpeg/blob/master/doc/APIchanges#L410

This prevents our code from breaking whenever we update to a newer
version of FFmpeg in the future if they ever decide to fully remove this
API member.
 2020-12-04 16:23:13 -05:00
Lioncash 677a8b208d video_core: Resolve more variable shadowing scenarios 
Resolves variable shadowing scenarios up to the end of the OpenGL code
to make it nicer to review. The rest will be resolved in a following
commit.
 2020-12-04 16:19:09 -05:00
Morph c2f83c04cb nim: Stub IsLargeResourceAvailable 
- Used by Immortals Fenyx Rising
 2020-12-04 09:53:21 -05:00
bunnei fad38ec6e8
Merge pull request #5064 from lioncash/node-shadow 
node: Eliminate variable shadowing
 2020-12-04 00:45:33 -08:00
bunnei defa826c53
Merge pull request #5061 from lioncash/pessimizing 
vp9/vic: Resolve pessimizing moves
 2020-12-03 23:21:12 -08:00
bunnei 69aaad9b96
Merge pull request #4996 from bunnei/use-4jits 
Kernel: Refactor to use 4-instances of Dynarmic & various cleanups and improvements
 2020-12-03 15:32:45 -08:00
Lioncash edd8208779 node: Mark member functions as [[nodiscard]] where applicable 
Prevents logic bugs from accidentally ignoring the return value.
 2020-12-03 16:03:34 -05:00
Lioncash 7cf34c3637 node: Eliminate variable shadowing 2020-12-03 15:59:38 -05:00
Lioncash cf9767c608 vp9/vic: Resolve pessimizing moves 
Removes the usage of moves that don't result in behavior different from
a copy, or otherwise would prevent copy elision from occurring.
 2020-12-03 12:33:07 -05:00
Lioncash 424bffcd3f mouse_poller: Remove unused includes 2020-12-03 10:41:13 -05:00
Lioncash 16aadcc354 mouse_input: Invert conditional in UpdateYuzuSettings() 
Allows the struct to be constructed in place.
 2020-12-03 10:41:13 -05:00
Lioncash 395997178b mouse_input: Remove two casts and amend some formatting 
Removes the use of two static casts and improves the readability of some
vectors slightly.
 2020-12-03 10:41:09 -05:00
Lioncash 5842a767a9 mouse_input: Resolve a -Wdocumentation warning 2020-12-03 10:26:50 -05:00
Lioncash 774d7eab64 mouse_input: Remove unused includes 2020-12-03 10:26:30 -05:00
bunnei 88089c8754
Merge pull request #5000 from lioncash/audio-error 
audio_core: Make shadowing and unused parameters errors
 2020-12-02 23:08:43 -08:00
Lioncash 1ea6bdef05 audio_core: Make shadowing and unused parameters errors 
Moves the audio code closer to enabling warnings as errors in general.
 2020-12-03 00:54:31 -05:00
bunnei 9abb23cd27
Merge pull request #5002 from ameerj/nvdec-frameskip 
nvdec: Queue and display all decoded frames, cleanup decoders
 2020-12-02 15:55:15 -08:00
bunnei 25f650e075
Merge pull request #4937 from german77/multiUDP 
InputCommon: Add multiple udp server support
 2020-12-01 11:47:37 -08:00
LC d39dfdf45c
Merge pull request #5047 from german77/MouseInput 
InputCommon: Fix implicit conversion in mouse input
 2020-12-01 09:40:46 -05:00
german ece0ae2bfb Fix implicit conversion in mouse input 2020-11-30 21:48:18 -06:00
bunnei 7b4a213603
Merge pull request #5013 from ReinUsesLisp/vk-early-z 
vk_shader_decompiler: Implement force early fragment tests
 2020-11-30 11:11:07 -08:00
lat9nq 756225c8ff Disable web applet and warning when compiling for Linux on CI 
yuzu's web applet does not or barely reacts to user input while open in
Linux. It can be closed via 'Exit Web Applet' on the menubar, however if
yuzu is in fullscreen, this is effectively a softlock as the menubar
cannot be accessed.

This disables building yuzu with the web applet on the Linux CI target.
In addition, this disables the QMessageBox warning about not having
compiled yuzu with the web applet.
 2020-11-30 13:25:46 -05:00
bunnei 7bc3e80399
Merge pull request #4939 from german77/MouseInput 
InputCommon: Implement full mouse support
 2020-11-29 22:59:50 -08:00
bunnei 63b3b25715
Merge pull request #5005 from ReinUsesLisp/div-ceil 
common: Add Common::DivCeil and Common::DivCeilLog2
 2020-11-29 01:41:06 -08:00
bunnei 4b9e1b6586 kernel: scheduler: Minor cleanup to remove duplicated code. 2020-11-29 01:31:52 -08:00
bunnei b7ef581c6e kernel: time_manager: Protect access with a mutex. 2020-11-29 01:31:52 -08:00
bunnei 24cae76d16 common: fiber: Use VirtualBuffer for stack memory. 
- This will be aligned by default, and helps memory usage.
 2020-11-29 01:31:52 -08:00
bunnei c2ad1243ba hle: kernel: thread: Remove unused "Running" state. 2020-11-29 01:31:52 -08:00
bunnei 63fd1bb503 core: arm: Implement InvalidateCacheRange for CPU cache invalidation. 2020-11-29 01:31:52 -08:00
bunnei c0870315fd hle: kernel: time_manager: Avoid a crash on process exit. 2020-11-29 01:31:51 -08:00
bunnei 9705f651b2 hle: kernel: AddressArbiter: Remove unused code. 2020-11-29 01:31:51 -08:00
bunnei 9423347c1b hle: kernel: SynchronizationObject: Use atomic_bool for is_signaled. 2020-11-29 01:31:51 -08:00
bunnei c042a89113 common: fiber: Use boost::context instead of native fibers on Windows. 2020-11-29 01:31:51 -08:00
bunnei 7b642c7781 hle: kernel: multicore: Replace n-JITs impl. with 4 JITs. 2020-11-29 01:31:51 -08:00
bunnei 6750b4d3af
Merge pull request #4998 from Morph1984/bioshock-patch 
hid: Check if applet_resource exists in InitializeVibrationDevice
 2020-11-28 23:20:23 -08:00
german 4eb7327559 Add missing types to NpadCommunicationMode 2020-11-28 21:56:02 -06:00
bunnei 312a8bd4b4
Merge pull request #5021 from german77/StubCommunicationMode 
HID: Stub set and get NpadCommunicationMode
 2020-11-28 15:22:46 -08:00
Chloe Marcec d7019d8307 audio_core: Remove temp_mix_buffer 
It's unused and doesn't need to be initialized
 2020-11-28 23:25:28 +11:00
bunnei d9b729bbfd
Merge pull request #5015 from comex/xx-sign-compare 
tests: Fix warning about comparison between signed and unsigned
 2020-11-27 19:54:26 -08:00
bunnei 1fde40b2c7
Merge pull request #5011 from lioncash/file-str2 
core: Reduce string copies in GetGameFileFromPath()
 2020-11-27 17:23:00 -08:00
LC fca87cfa3e
Merge pull request #5014 from comex/xx-invalid-offsetof 
CMakeLists: disable -Winvalid-offsetof
 2020-11-27 17:44:07 -05:00
comex 32f3b6b865 CMakeLists: disable -Winvalid-offsetof 
This Clang warning complains when offsetof is used on a
non-standard-layout type (i.e. any class using various C++ features),
even though it works fine (and is not undefined behavior as of C++17).
 2020-11-27 17:42:02 -05:00
comex 3dc310bd52 tests: Fix warning about comparison between signed and unsigned 2020-11-27 17:41:20 -05:00
Lioncash 5bc4eabe36 core: Eliminate remaining usages of the global system instance 
Removes all remaining usages of the global system instance. After this,
migration can begin to migrate to being constructed and managed entirely
by the various frontends.
 2020-11-27 11:40:45 -05:00
Lioncash 073e07ae2d savedata_factory: Eliminate usage of the global system instance 
Now there's only two meaningful instances left in core.
 2020-11-27 09:45:08 -05:00
Rodrigo Locatti ee5e77fbf9
Merge pull request #5018 from lioncash/service-global 
service: Eliminate usages of the global system instance
 2020-11-27 02:41:56 -03:00
german 3898d8f0d7 Stub set and get NpadCommunicationMode 2020-11-26 21:35:11 -06:00
Lioncash 1a954b2a59 service: Eliminate usages of the global system instance 
Completely removes all usages of the global system instance within the
services code by passing in the using system instance to the services.
 2020-11-26 20:03:11 -05:00
comex 4681e1ea9e codec: Fix `pragma GCC diagnostic pop` missing corresponding push 2020-11-26 16:35:42 -05:00
ReinUsesLisp 2ccf85a910 vk_shader_decompiler: Implement force early fragment tests 
Force early fragment tests when the 3D method is enabled.
The established pipeline cache takes care of recompiling if needed.

This is implemented only on Vulkan to avoid invalidating the shader
cache on OpenGL.
 2020-11-26 17:52:26 -03:00
Lioncash 9d3d0ae999 core: Reduce string copies in GetGameFileFromPath() 
Eliminates some minor string churn where applicable. Also eliminates an
unnecessary vector copy.
 2020-11-26 14:05:13 -05:00
ameerj 979b602738 Limit queue size to 10 frames 
Workaround for ZLA, which seems to decode and queue twice as many frames as it displays.
 2020-11-26 14:04:06 -05:00
bunnei 322349e8cc
Merge pull request #4975 from comex/invalid-syncpoint-id 
nvdrv, video_core: Don't index out of bounds when given invalid syncpoint ID
 2020-11-26 01:27:24 -08:00
german e46f0e084c Implement full mouse support 2020-11-25 23:59:30 -06:00
bunnei ebcee03b0c
Merge pull request #4981 from ogniK5377/ioctl-ctrl 
nvservices: Reintroducee IoctlCtrl
 2020-11-25 21:48:57 -08:00
german 2c2b586d86 Add multiple udp server support 2020-11-25 23:44:41 -06:00
ameerj c9e3abe206 Address PR feedback 
remove some redundant moves, make deleter match naming guidelines.

Co-Authored-By: LC <712067+lioncash@users.noreply.github.com>
 2020-11-26 00:18:26 -05:00
ReinUsesLisp 630823e363 common: Add Common::DivCeil and Common::DivCeilLog2 
Add an equivalent to 'Common::AlignUp(n, d) / d' and a log2 alternative.
 2020-11-25 23:37:56 -03:00
Jan Beich e48e9a406c input_common: ignore some Clang warnings after 5c4774e8ce 
error: unknown warning option '-Werror=unused-but-set-parameter'; did you mean '-Werror=unused-parameter'? [-Werror,-Wunknown-warning-option]
error: unknown warning option '-Werror=unused-but-set-variable'; did you mean '-Werror=unused-const-variable'? [-Werror,-Wunknown-warning-option]
 2020-11-25 23:57:11 +00:00
Rodrigo Locatti 0e15c68f54
Merge pull request #4976 from comex/poll-events 
Overhaul EmuWindow::PollEvents to fix yuzu-cmd calling SDL_PollEvents off main thread
 2020-11-25 20:44:53 -03:00
ameerj eab041866b Queue decoded frames, cleanup decoders 2020-11-25 17:10:44 -05:00
Rodrigo Locatti b834c21894
Merge pull request #4946 from ameerj/alpha-test 
renderer_vulkan: Implement alpha testing
 2020-11-25 18:48:34 -03:00
ameerj d52ee6d0a7 cleanup unneeded comments and newlines 2020-11-25 14:46:08 -05:00
bunnei dcfa1992ea
Merge pull request #4959 from Morph1984/emulated-controller-styleset 
configure_input_player: Use the NpadStyleSet to limit the available controllers shown
 2020-11-25 11:20:46 -08:00
bunnei b7f1095980
Merge pull request #4932 from ogniK5377/misc-audio 
audren: Make use of nodiscard, rework downmixing, release all buffers
 2020-11-25 10:50:52 -08:00
Morph 6f70e1b1ff hid: Check if applet_resource exists in InitializeVibrationDevice 2020-11-25 13:33:30 -05:00
bunnei 9aeada734d
Merge pull request #4978 from bunnei/shutdown-crash 
core: cpu_manager: Fix shutdown crash when closing before emulation starts.
 2020-11-25 01:20:01 -08:00
ameerj e87670ee48 Refactor MaxwellToSpirvComparison. Use Common::BitCast 
Co-Authored-By: Rodrigo Locatti <reinuseslisp@airmail.cc>
 2020-11-25 00:33:20 -05:00
ameerj 1dbf71ceb3 Address PR feedback from Rein 2020-11-24 22:46:45 -05:00
ameerj 9014861858 vulkan_renderer: Alpha Test Culling Implementation 
Used by various textures in many titles, e.g.  SSBU menu.
 2020-11-24 22:46:45 -05:00
bunnei d1da7eb119
Merge pull request #4905 from german77/AnalogFromButton 
Allow to dial any angle with digital joystick
 2020-11-24 16:04:55 -08:00
bunnei 3359e5ab70 core: cpu_manager: Fix shutdown crash when closing before emulation starts. 2020-11-24 15:25:39 -08:00
bunnei 4fbe4da911 frontend: yuzu (qt): Register a callback for ExecuteProgram. 2020-11-24 15:18:29 -08:00
bunnei 4fb5ca80c0 service: am: Implement ExecuteProgram and required stubs. 
- This is used by Super Mario 3D All-Stars.
 2020-11-24 15:17:43 -08:00
bunnei 5f75d97125 core: loader: Implement support for loading indexed programs. 2020-11-24 15:16:24 -08:00
bunnei 7791cc8c2e
hle: services: Fix a crash with improper NVFlinger lifetime management. (#4977) 
* hle: services: Fix a crash with improper NVFlinger lifetime management.

- This crash would happen when attempting to shutdown yuzu early on in boot.
 2020-11-24 14:31:58 -08:00
comex e8b2fd21d8 nvdrv, video_core: Don't index out of bounds when given invalid syncpoint ID 
- Use .at() instead of raw indexing when dealing with untrusted indices.

- For the special case of WaitFence with syncpoint id UINT32_MAX,
  instead of crashing, log an error and ignore.  This is what I get when
  running Super Mario Maker 2.
 2020-11-24 12:59:41 -05:00
Rodrigo Locatti fbda5e9ec9
Merge pull request #3681 from lioncash/component 
decoder/image: Fix incorrect G24R8 component sizes in GetComponentSize()
 2020-11-24 04:38:03 -03:00
Rodrigo Locatti 410ed82922
Merge pull request #4942 from lioncash/system 
core: Make use of [[nodiscard]] with the System class
 2020-11-24 04:26:59 -03:00
Rodrigo Locatti 7afb7a9494
Merge pull request #4972 from lioncash/unused4 
svc: Remove unnecessary [[maybe_unused]] tag
 2020-11-24 04:25:59 -03:00
bunnei 6694e11303
input_common: Fix typo in gc_poller.cpp with [[maybe_unused]]. 2020-11-23 21:42:06 -08:00
Chloe Marcec ab25d1fe9a nvservices: Reintroducee IoctlCtrl 
Fixes regression caused by #4907 which caused games like Breath of the Wild 1.0.0 not to boot.
 2020-11-24 16:40:23 +11:00
bunnei 7fb7540d69 input_common: Add more missing [[maybe_unused]] from #4927. 2020-11-23 20:50:35 -08:00
bunnei d04abd39eb
Fix warnings in core/frontend/input.h with [[maybe_unused]] 
Fixes build break due to #4927
 2020-11-23 18:11:21 -08:00
bunnei e371d12af6
Merge pull request #4927 from lioncash/input-error 
input_common: Treat warnings as errors
 2020-11-23 17:25:53 -08:00
comex 994f497781 Overhaul EmuWindow::PollEvents to fix yuzu-cmd calling SDL_PollEvents off main thread 
EmuWindow::PollEvents was called from the GPU thread (or the CPU thread
in sync-GPU mode) when swapping buffers.  It had three implementations:

- In GRenderWindow, it didn't actually poll events, just set a flag and
  emit a signal to indicate that a frame was displayed.

- In EmuWindow_SDL2_Hide, it did nothing.

- In EmuWindow_SDL2, it did call SDL_PollEvents, but this is wrong
  because SDL_PollEvents is supposed to be called on the thread that set
  up video - in this case, the main thread, which was sleeping in a
  busyloop (regardless of whether sync-GPU was enabled).  On macOS this
  causes a crash.

To fix this:

- Rename EmuWindow::PollEvents to OnFrameDisplayed, and give it a
  default implementation that does nothing.

- In EmuWindow_SDL2, do not override OnFrameDisplayed, but instead have
  the main thread call SDL_WaitEvent in a loop.
 2020-11-23 17:58:49 -05:00
bunnei 5d1447897a
Merge pull request #4451 from slashiee/extended-logging 
logging/settings: Increase maximum log size to 100 MB and add extended logging option
 2020-11-23 13:34:15 -08:00
Lioncash 874be0e3e1 svc: Remove unnecessary [[maybe_unused]] tag 
The parameter is used in this function, so this suppression isn't
necessary.
 2020-11-23 10:17:20 -05:00
Lioncash 5c4774e8ce input_common: Treat warnings as errors 
Migrates over warnings as errors for input common to match how the
common library treats warnings as errors.
 2020-11-22 04:50:03 -05:00
bunnei 3a85bc1e77
Merge pull request #4944 from lioncash/system-rem 
patch_manager: Remove usages of the global system instance
 2020-11-21 22:12:34 -08:00
Morph e13a91fa9b
Merge pull request #4954 from lioncash/compare 
gl_rasterizer: Make floating-point literal a float
 2020-11-22 09:55:23 +08:00
bunnei 5502f39125
Merge pull request #4955 from lioncash/move3 
async_shaders: std::move data within QueueVulkanShader()
 2020-11-21 01:21:08 -08:00
bunnei afd0e2ee87
Merge pull request #4907 from ogniK5377/nvdrv-cleanup 
core: Make nvservices more standardized
 2020-11-20 22:15:44 -08:00
Morph 8758378dc4 applets/controller: Use a pair of emulated controller index to controller type 2020-11-20 22:22:22 -05:00
Morph 102630f2b2 configure_input_player: Use the npad style set to show the available controllers 
This will reduce the likelihood of an invalid controller type to be set within a game
 2020-11-20 22:22:22 -05:00
LC d88baa746b
Merge pull request #4957 from ReinUsesLisp/alpha-test-rt 
gl_rasterizer: Remove warning of untested alpha test
 2020-11-20 21:19:06 -05:00
ReinUsesLisp acc14d233f gl_rasterizer: Remove warning of untested alpha test 
Alpha test has been proven to only affect the first render target.
 2020-11-20 23:17:40 -03:00
bunnei b00f4abe36
Merge pull request #4953 from lioncash/shader-shadow 
shader_bytecode: Eliminate variable shadowing
 2020-11-20 16:58:14 -08:00
bunnei c47c3d723f
Merge pull request #4951 from bunnei/olsc-stub 
hle: service: Stub OLSC Initialize and SetSaveDataBackupSettingEnabled functions.
 2020-11-20 14:06:37 -08:00
bunnei 3794c91145 olsc: Move member initialization to after member functions. 2020-11-20 10:50:50 -08:00
Lioncash 01db5cf203 async_shaders: emplace threads into the worker thread vector 
Same behavior, but constructs the threads in place instead of moving
them.
 2020-11-20 04:46:56 -05:00
Lioncash ba3916fc67 async_shaders: Simplify implementation of GetCompletedWork() 
This is equivalent to moving all the contents and then clearing the
vector. This avoids a redundant allocation.
 2020-11-20 04:44:44 -05:00
Lioncash 3fcc98e11a async_shaders: Simplify moving data into the pending queue 2020-11-20 04:41:29 -05:00
Lioncash 5b441fa25d async_shaders: std::move data within QueueVulkanShader() 
Same behavior, but avoids redundant copies.

While we're at it, we can simplify the pushing of the parameters into
the pending queue.
 2020-11-20 04:38:18 -05:00
Lioncash 8469b76630 gl_rasterizer: Make floating-point literal a float 
Gets rid of an unnecessary expansion from float to double.
 2020-11-20 04:24:33 -05:00
Lioncash b7cd5d742e shader_bytecode: Make use of [[nodiscard]] where applicable 
Ensures that all queried values are made use of.
 2020-11-20 02:20:37 -05:00
Lioncash 56ecafc204 shader_bytecode: Eliminate variable shadowing 2020-11-20 02:13:45 -05:00
Morph 715f0c3b0c
Merge pull request #4941 from lioncash/config 
configure_input_player: Use static qualifier for IsProfileNameValid()
 2020-11-20 14:16:01 +08:00
LC bba7e8ea4b
Merge pull request #4950 from german77/RumbleStrenght 
Modify rumble amplification
 2020-11-20 00:40:09 -05:00
LC e883101999
Merge pull request #4952 from ReinUsesLisp/bit-cast 
common/bit_cast: Add function matching std::bit_cast without constexpr
 2020-11-20 00:39:30 -05:00
Rodrigo Locatti 1889b641d9
Merge pull request #4308 from ReinUsesLisp/maxwell-3d-funcs 
maxwell_3d: Move code to separate functions and insert instead of push_back
 2020-11-20 01:57:22 -03:00
ReinUsesLisp 3f2e605dd1 common/bit_cast: Add function matching std::bit_cast without constexpr 
Add a std::bit_cast-like function archiving the same runtime results as
the standard function, without compile time support.

This allows us to use bit_cast while we wait for compiler support, it
can be trivially replaced in the future.
 2020-11-20 01:52:37 -03:00
bunnei 6e37676482 hle: service: Stub OLSC Initialize and SetSaveDataBackupSettingEnabled functions. 
- Used by Animal Cross: New Horizons v1.6.0 update, minimal stub gets this update working.
 2020-11-19 12:36:09 -08:00
german77 5b6545b141 Modify rumble amplification 2020-11-19 11:30:52 -06:00
Lioncash 412044960a virtual_buffer: Do nothing on resize() calls with same sizes 
Prevents us from churning memory by freeing and reallocating a memory
block that would have already been adequate as is.
 2020-11-19 07:54:03 -05:00
bunnei 92344da20c
Merge pull request #4936 from lioncash/page 
page_table: Allow page tables to be moved
 2020-11-18 20:40:10 -08:00
Lioncash 6f8a06bac5 patch_manager: Remove usages of the global system instance 
With this, only 19 usages of the global system instance remain within
the core library.

We're almost there.
 2020-11-18 09:36:48 -05:00
Lioncash aaf262bfed core: Remove unused private Init function for the System class 
This isn't used, so it can be removed.
 2020-11-18 02:09:08 -05:00
Lioncash bcaadac22c core: Make use of [[nodiscard]] with the System class 
Given this is a central class, we should flag cases where the return
value of some functions not being used is likely a bug.
 2020-11-18 02:06:44 -05:00
Lioncash be4fc777c0 configure_input_player: Use static qualifier for IsProfileNameValid() 
This is a static member function, so we don't need use an existing
instance to call this function.
 2020-11-17 23:12:44 -05:00
bunnei abda366362
Merge pull request #4866 from Morph1984/mjolnir-p3-prod 
Project Mjölnir: Part 3 - Controller Profiles and Vibration Rework
 2020-11-17 20:02:27 -08:00
Lioncash 0ca91ced2d virtual_buffer: Add compile-time type-safety guarantees with VirtualBuffer 
VirtualBuffer makes use of VirtualAlloc (on Windows) and mmap() (on
other platforms). Neither of these ensure that non-trivial objects are
properly constructed in the allocated memory.

To prevent potential undefined behavior occurring due to that, we can
add a static assert to loudly complain about cases where that is done.
 2020-11-17 20:09:58 -05:00
Lioncash b3c8997829 page_table: Allow page tables to be moved 
Makes page tables and virtual buffers able to be moved, but not copied,
making the interface more flexible.

Previously, with the destructor specified, but no move assignment or
constructor specified, they wouldn't be implicitly generated.
 2020-11-17 20:08:20 -05:00
Lioncash 3cfd962ef4 page_table: Add missing doxygen parameters to Resize() 
Resolves two -Wdocumentation warnings.
 2020-11-17 19:45:20 -05:00
Lioncash 0890451c55 page_table: Remove unnecessary header inclusions 
Prevents indirect inclusions for these headers.
 2020-11-17 19:43:27 -05:00
Lioncash 70812ec57b rasterizer_interface: Make use of [[nodiscard]] where applicable 2020-11-17 07:19:13 -05:00
Lioncash a78021580d render_base: Make use of [[nodiscard]] where applicable 2020-11-17 07:19:12 -05:00
Lioncash b928fca114 gpu: Make use of [[nodiscard]] where applicable 2020-11-17 07:19:09 -05:00
bunnei 8ace3959a5
Merge pull request #4929 from lioncash/nodiscard-input 
motion_input: Mark member functions as [[nodiscard]] where applicable
 2020-11-16 21:40:16 -08:00
Chloe Marcec 908d3c5679 Addressed changes 2020-11-17 15:40:19 +11:00
Chloe Marcec 9a4beac95a audren: Make use of nodiscard, rework downmixing, release all buffers 
Preliminary work for upmixing & general cleanup. Fixes basic issues in games such as Shovel Knight and slightly improves the LEGO games. Upmixing stitll needs to be implemented.

Audio levels in a few games will be fixed as we now use the downmix coefficients when possible instead of supplying our own
 2020-11-17 14:14:29 +11:00
Morph e7e8a87927 sdl_impl: Pump SDL Events at 1000 Hz 2020-11-15 23:33:21 -05:00
Morph b254d528bc configure_input: Accommodate for the mouse input device engine 2020-11-15 23:33:21 -05:00
Morph ad50209383 hid: Reimplement Begin/EndPermitVibrationSession 
Upon further investigation, these commands allow temporary vibrations even when the "Controller Vibration" system setting is disabled. As a result, vibrations are allowed when either the system setting or this flag is set to true. Therefore, we can only block vibrations when both flags are set to false.
 2020-11-15 23:33:21 -05:00
Morph d8ad2f3484 controllers/npad: Load input devices on init 2020-11-15 23:33:21 -05:00
Morph 6f5b942897 configure_input: Update the input profiles for other player tabs 2020-11-15 23:33:21 -05:00
Morph 97b2220a82 general: Fix compiler warnings on linux and miscellaneous changes 2020-11-15 23:33:21 -05:00
Morph 117bdc71e0 sdl_impl: Revert to the "old" method of mapping sticks 
Not all controllers have a SDL_GameController binding. This caused controllers not present in the SDL GameController database to have buttons mapped instead of axes.

Furthermore, it was not possible to invert the axes when it could be useful such as emulating a horizontal single joycon or other potential cases. This allows us to invert the axes by reversing the order of mapping (vertical, then horizontal).
 2020-11-15 23:33:21 -05:00
Morph 760a9e8693 applets/controller: Change the input button to create input profiles 
Co-authored-by: Its-Rei <kupfel@gmail.com>
 2020-11-15 23:33:21 -05:00
Morph 30e0d1c973 controllers/npad: Remove the old vibration filter 
Previously we used a vibration filter that filters out amplitudes close to each other. It turns out there are cases where this results into vibrations that are too inaccurate. Remove this and move the 100Hz vibration filter (Only allowing a maximum of 100 vibrations per second) from sdl_impl to npad when enable_accurate_vibrations is set to false.
 2020-11-15 23:33:21 -05:00
Morph 91c06dae1a input: Disconnect a controller prior to connecting a new one 
Some games do not respond to a change in controller type if 1) The controller is not disconnected prior to being reconnected and/or 2) The controller is reconnected instantly after being disconnected.

Since it is not possible to change controllers instantly on hardware and requiring a disconnect prior to connecting a new one, we should emulate this as well with a small delay, fixing the aforementioned issue.
 2020-11-15 23:33:21 -05:00
Morph 978ca65f59 hid: Implement InitializeVibrationDevice and IsVibrationDeviceMounted 2020-11-15 23:33:20 -05:00
Morph e9e1876e82 input_common: Add VibrationDevice and VibrationDeviceFactory 
A vibration device is an input device that returns an unsigned byte as status.
It represents whether the vibration device supports vibration or not.
If the status returns 1, it supports vibration. Otherwise, it does not support vibration.
 2020-11-15 23:33:20 -05:00
Morph 38110dd485 configure_input: Add per-player vibration 
Allows for enabling and modifying vibration and vibration strength per player.
Also adds a toggle for enabling/disabling accurate vibrations.

Co-authored-by: Its-Rei <kupfel@gmail.com>
 2020-11-15 23:33:20 -05:00
Morph d6a41cfc21 settings: Remove global vibration strength modifier 
This will be replaced in favor of per-player vibration strength modifiers.
 2020-11-15 23:33:20 -05:00
Morph 92fa5257c7 hid: Mark Begin/EndPermitVibrationSession as stubs 
The implementation of these commands seem incomplete and causes rumble in Super Mario Party to stop working since only EndPermitVibrationSession is called. Thus, these are better off being marked as a stub until this can be investigated more thoroughly.
 2020-11-15 23:33:20 -05:00
Morph 373408ae8c controllers/npad: Send an empty vibration on destruction/deactivation 
This stops all controllers from continuously vibrating when emulation is stopped.
 2020-11-15 23:33:20 -05:00
Morph 70f16f1722 hid: Stub IsVibrationDeviceMounted 
- Used in Super Mario Odyssey
 2020-11-15 23:33:20 -05:00
Morph 9b501af8e3 controllers/npad: Add heuristics to reduce rumble state changes 
Sending too many state changes in a short period of time can cause massive performance issues.
As a result, we have to use several heuristics to reduce the number of state changes to minimize/eliminate this performance impact while maintaining the quality of these vibrations as much as possible.
 2020-11-15 23:33:20 -05:00
Morph 652d6766d5 configure_input: Hook up the vibration percentage spinbox 
This allows setting the vibration strength percentage anywhere from 1% to 100%.
Also hooks up the remaining motion button and checkbox in the Controller Applet.
 2020-11-15 23:33:20 -05:00
Morph e02ef3c3be controllers/npad: Stop games from vibrating incorrect controllers 
Fixes vibration in 1-2 Switch and potentially other games where they would vibrate both players' joycons at the same time.
 2020-11-15 23:33:20 -05:00
Morph 07b81f57ba hid: Fix controller rumble based on new research 
This fixes the issue where rumble is only sent to the first controller.
Now, individual controllers can receive their own rumble commands.
 2020-11-15 23:33:20 -05:00
Morph 31de52513e hid: Pop a struct of parameters instead of popping individual parameters 
Some parameters need to be doubleword aligned due to the presence of the applet_resource_user_id.
Previously, this value was invalid in many commands where it was not doubleword aligned when popped.
 2020-11-15 23:33:20 -05:00
Morph e3c2749986 hid: Reorder all HID commands 
Reorders all HID commands in command id order.
 2020-11-15 23:33:20 -05:00
Morph b92bf51ae1 hid: Implement GetVibrationDeviceInfo 
The first u32 describes the vibration device type which is a Linear Resonant Actuator used in Nintendo Switch controller hardware.

The second u32 describes the vibration device position, in this case distinguishing between left and right vibration actuators.

Pro Controllers have 2 LRAs each that can vibrate independently of each other, which means they have 2 distinct vibration device handles to distinguish between the two actuators.

Similarly for joycons, the left joycon can be distinguished from the right joycon through the vibration device handle since each joycon has 1 LRA.
 2020-11-15 23:33:20 -05:00
Morph 16e2e1c45f hid: Stub InitializeVibrationDevice 2020-11-15 23:33:20 -05:00
Morph 428ce8ec29 controllers/npad: Rename NPadType to NpadStyleSet 
This more accurately represents the underlying type and avoids confusion with NpadType
 2020-11-15 23:33:20 -05:00
Morph 0a966e2cac controllers/npad: Add DeviceHandle struct 
A DeviceHandle describes a vibration device or six-axis sensor based on the npad type, npad id, and device index/position
 2020-11-15 23:33:20 -05:00
Morph ceb7b11f16 configure_input_player: Change "Defaults" button behavior 
RestoreDefaults() now restores the selected devices' mappings using UpdateMappingWithDefaults().
This allows us to move the keyboard mapping from RestoreDefaults() to UpdateMappingWithDefaults().
 2020-11-15 23:33:20 -05:00
Morph 8f2959f680 settings: Preparation for per-game input settings 2020-11-15 23:33:20 -05:00
Morph 8ead176639 udp/client: Reduce testing period to 5 seconds 2020-11-15 23:33:19 -05:00
Morph 64e174237e config: Migrate config files into config/custom 
Co-authored-by: lat9nq <lat9nq@virginia.edu>
 2020-11-15 23:33:19 -05:00
Morph c0c4ed0d3b controllers/npad: Connect a controller on init if none are connected 2020-11-15 23:33:19 -05:00
Morph 5cafa70d3b applets/controller: Auto accept a valid single player configuration 2020-11-15 23:33:19 -05:00
Morph 484623cd61 bootmanager: Allow mouse clicks only if touch is disabled 
Previously mouse clicks will not register when touch is disabled.
This rectifies that and allows mouse clicks to be mapped to other buttons if the touchscreen is disabled.
 2020-11-15 23:33:19 -05:00
Morph 57d89e291d input_profiles: Implement input profiles 2020-11-15 23:33:19 -05:00
Morph 75eaab2e0f configure_input_player: Implement input exclusivity and persistence 
With this, the "Input Devices" combobox should accurately reflect the input device being used and disallows inputs from other input devices unless the input device is set to "Any".
 2020-11-15 23:33:19 -05:00
Morph 9d4edd4e88 ui/themes: Cleanup UI 2020-11-15 23:33:19 -05:00
Lioncash 0a50ba3bd1 motion_input: Mark constructor as explicit 2020-11-15 14:20:41 -05:00
Lioncash cb826bcee7 motion_input: Mark member functions as [[nodiscard]] where applicable 2020-11-15 14:18:09 -05:00
LC ce718522bc
Merge pull request #4914 from lat9nq/gl-warnings 
bootmanager: Log and show GL_RENDERER string when GPU is insufficient
 2020-11-15 06:33:48 -05:00
bunnei 87f220efff
Merge pull request #4895 from Morph1984/cave-story-plus-applet-fix 
applets/controller: Introduce additional checks for mode and caller
 2020-11-12 21:55:06 -08:00
ReinUsesLisp 622830f4e1 maxwell_3d: Use insert instead of loop push_back 
This reduces the overhead of bounds checking on each element.
It won't reduce the cost of allocation because usually this vector's
capacity is usually large enough to hold whatever we push to it.
 2020-11-11 19:52:19 -03:00
ReinUsesLisp 9ea8cffe35 maxwell_3d: Move code to separate functions 
Deduplicate some code and put it in separate functions so it's easier to
understand and profile.
 2020-11-11 19:52:19 -03:00
german f5110340e6 fix minor clang error 2020-11-10 10:38:15 -06:00
bunnei c22d0d9945
Merge pull request #4901 from bunnei/caps-stub 
hle: service: caps_u: Stub GetAlbumFileList3AaeAruid.
 2020-11-09 21:20:08 -08:00
Chloe Marcec fc4d692c50 Addressed issues 2020-11-10 15:57:36 +11:00
Chloe Marcec 31c12de0fe core: Make nvservices more standardized 2020-11-10 15:57:35 +11:00
lat9nq c433c0a746 bootmanager: Address review comments 
Changes QMessageBox usages to warnings, as the problems they bring to
light are being safely handled by the application and do not warrant
something of the "critical" level.

Changes LOG_CRITICAL to LOG_ERROR for the same reason. Preferring ERROR
to WARNING as yuzu is denying loading of any guest applications after
checking for these conditions.

Moved logging the GL_RENDERER string into GetUnsupportedGLExtensions()
to make more clear that unsupported extensions were already being
logged. Makes placement of the logs easier to understand later, as well.
 2020-11-09 22:55:05 -05:00
lat9nq 945cfe234b bootmanager: Log and show GL_RENDERER string when GPU is insufficient 
Changes the first message to not include the OpenGL version, as the
error is caused by OpenGL failing to load.

Adds a new check for OpenGL version 4.3. This will display a message
with a similar error as well as the GL_RENDERER string. Adds a CRITICAL
log message when triggered. This prevents a crash with yuzu trying to
use older OpenGL versions.

Modifies the unsupported extension message to output the GL_RENDERER
string in the message, as well as logging the string.
 2020-11-09 22:12:41 -05:00
Rodrigo Locatti 9b24197ca0
Merge pull request #4909 from lioncash/interrupt 
cpu_interrupt_handler: Mark move contructor/assignment as deleted
 2020-11-08 22:09:40 -03:00
Lioncash da7be67daf ipc_helpers: Remove usage of the global system instance 
Resolves numerous deprecation warnings throughout the codebase due to
inclusion of this header. Now building core should be significantly less
noisy (and also relying on less global state).

This also uncovered quite a few modules that were relying on indirect
includes, which have also been fixed.
 2020-11-08 15:58:11 -05:00
Lioncash 0aad914527 cpu_interrupt_handler: Mark move contructor/assignment as deleted 
The interrupt handler contains a std::atomic_bool, which isn't copyable
or movable, so the special move member functions will always be deleted,
despite being defaulted.

This can resolve warnings on clang and GCC.
 2020-11-08 15:37:04 -05:00
german 70df449d0a Allow to dial any angle with digital joystick 2020-11-08 09:15:33 -06:00
Morph a6ecdf42bc applets: Rename LibraryAppletVersion to ControllerAppletVersion 2020-11-08 10:04:12 -05:00
Morph 9efbf5309f applets/controller: Pop normal data for StrapGuide and FirmwareUpdate 2020-11-08 09:35:25 -05:00
Morph af1183a993 applets/controller: Introduce additional checks for mode and caller 
Some games like Cave Story+ set invalid values in the ControllerPrivateArg's mode and caller fields.
Use other fields to determine the appropriate mode and caller should either or both fields be invalid.
 2020-11-08 09:35:25 -05:00
Morph 88192af8ac applets/controller: Add ControllerUpdateFirmwareArg struct 2020-11-08 09:35:25 -05:00
bunnei 7bf9f9ae49
Merge pull request #4903 from bunnei/remove-gpu-integrity 
video_core: dma_pusher: Remove integrity check on command lists.
 2020-11-08 02:48:22 -08:00
LC e829973742
Merge pull request #4906 from lat9nq/log-cpu-accuracy 
settings: log value of CPU_Accuracy
 2020-11-07 17:01:33 -05:00
lat9nq 1e149dc18b settings: log value of CPU_Accuracy 2020-11-07 16:14:10 -05:00
bunnei dc5396a466 video_core: dma_pusher: Remove integrity check on command lists. 
- This seems to cause softlocks in Breath of the Wild.
 2020-11-07 00:08:19 -08:00
bunnei af477fb8c5
Merge pull request #4888 from lioncash/unicorn-remove 
core: Remove usage of unicorn
 2020-11-06 22:39:05 -08:00
bunnei a0d7a2732d hle: service: caps_u: Stub GetAlbumFileList3AaeAruid. 
- This works similiar to GetAlbumContentsFileListForApplication.
- Since we do not implement the album, this should be safe to stub for now.
- Used by Super Smash Bros. Ultimate (newer updates) in World of Light.
 2020-11-06 22:23:15 -08:00
Lioncash 00fb79b2f3 common/fiber: Move all member variables into impl class 
Hides all of the implementation details for users of the class. This has
the benefit of reducing includes and also making the fiber classes
movable again.
 2020-11-06 20:36:32 -05:00
bunnei 91a45834fd
Merge pull request #4891 from lioncash/clang2 
General: Fix clang build
 2020-11-06 10:33:13 -08:00
bunnei 0b75ec5316
Merge pull request #4894 from lioncash/fn 
settings: Simplify initializer of resolution factor
 2020-11-06 09:54:02 -08:00
Lioncash c0ab5b79dc settings: Simplify initializer of resolution factor 
This can use a braced initializer to accomplish the same thing with less
code.
 2020-11-05 22:07:10 -05:00
bunnei a111a9ae2c
Merge pull request #4854 from ReinUsesLisp/cube-array-shadow 
shader: Partially implement texture cube array shadow
 2020-11-05 16:25:00 -08:00
Lioncash 6f006d051e General: Fix clang build 
Allows building on clang to work again
 2020-11-05 10:07:16 -05:00
bunnei d62d28522b
Merge pull request #4889 from lioncash/setting-global 
core/settings: Move configuring_global behind an API
 2020-11-04 17:09:19 -08:00
bunnei 087f52e872
Merge pull request #4858 from lioncash/initializer 
General: Resolve a few missing initializer warnings
 2020-11-04 12:10:10 -08:00
Lioncash 7aae6d6d2b core/settings: Move configuring_global behind an API 
Rather than have directly modified global state here, we can make it an
implementation detail and have an interface that changes are queried
through.
 2020-11-04 04:16:37 -05:00
Chloe 6bbbbe8f85
Merge pull request #4869 from bunnei/improve-gpu-sync 
Improvements to GPU synchronization & various refactoring
 2020-11-04 18:36:55 +11:00
Lioncash fc6db97a09 core: Remove usage of unicorn 
Unicorn long-since lost most of its use, due to dynarmic gaining support
for handling most instructions. At this point any further issues
encountered should be used to make dynarmic better.

This also allows us to remove our dependency on Python.
 2020-11-03 20:22:05 -05:00
bunnei 4bfa411ddc
Merge pull request #4874 from lioncash/nodiscard2 
nvdec: Make use of [[nodiscard]] where applicable
 2020-11-03 16:34:07 -08:00
bunnei 222fe75401
Merge pull request #4873 from lioncash/common-error 
common: Enable warnings as errors
 2020-11-03 11:00:23 -08:00
bunnei 448e4d5c2a
Merge pull request #4878 from bunnei/unload-nrr 
hle: service: ldr: Implement UnloadNrr.
 2020-11-03 08:52:40 -08:00
Lioncash 4a4b685a04 common: Enable warnings as errors 
Cleans up common so that we can enable warnings as errors.
 2020-11-02 15:50:58 -05:00
Lioncash 4f0f481f63 nvdec: Make use of [[nodiscard]] where applicable 
Prevents bugs from occurring where the results of a function are
accidentally discarded
 2020-11-02 02:45:15 -05:00
bunnei 1089d76736
Merge pull request #4865 from ameerj/async-threadcount 
async_shaders: Increase Async worker thread count for >8 thread cpus
 2020-11-01 01:54:01 -07:00
bunnei 848bdf8a40 fixup! hle service: nvdrv: nvhost_gpu: Update to use SyncpointManager and other improvements. 2020-11-01 01:52:38 -07:00
bunnei 7d2839d7a3 core: Initialize GPU before services. 2020-11-01 01:52:38 -07:00
bunnei e67b8678f8 hle service: nvdrv: nvhost_gpu: Update to use SyncpointManager and other improvements. 
- Refactor so that SubmitGPFIFO and KickoffPB use shared functionality.
- Implement add_wait and add_increment flags.
 2020-11-01 01:52:38 -07:00
bunnei c6e1c46ac7 video_core: dma_pusher: Add support for integrity checks. 
- Log corrupted command lists, rather than crash.
 2020-11-01 01:52:38 -07:00
bunnei c64545d07a video_core: dma_pusher: Add support for prefetched command lists. 2020-11-01 01:52:38 -07:00
bunnei 1d4cbb92f2 service: hle: nvflinger: Fix potential shutdown crash when GPU is destroyed. 2020-11-01 01:52:38 -07:00
bunnei 6053b95552 video_core: gpu: Implement WaitFence and IncrementSyncPoint. 2020-11-01 01:52:37 -07:00
bunnei 66edfd61c6 hle service: nvdrv: nvhost_ctrl: Update to use SyncpointManager. 2020-11-01 01:52:37 -07:00
bunnei 4a3fd97e48 hle service: nvdrv: Update to instantiate SyncpointManager. 2020-11-01 01:52:34 -07:00
bunnei d567b7e841 hle: service: nvdrv: Implement SyncpointManager, to manage syncpoints. 2020-11-01 01:51:54 -07:00
Levi Behunin bca9591660
Rename to align with switchbrew and remove gpu function (#4714) 
* Rename to align with switchbrew

* Rename to align with switchbrew and remove gpu function that checks if clearing should be done.
 2020-11-01 01:24:17 -07:00
bunnei 98f68d06f1
Merge pull request #4853 from ReinUsesLisp/fcmp-imm 
shader/arithmetic: Implement FCMP immediate + register variant
 2020-10-31 01:25:02 -07:00
bunnei a0e5cccb92 hle: service: ldr: Implement UnloadNrr. 
- Used by Final Fantasy X/X-2 HD Remaster.
 2020-10-31 01:22:53 -07:00
LC 6db0c0d8d9
Merge pull request #4872 from jbeich/clang 
video_core: unbreak -Werror in NVDEC with Clang
 2020-10-30 15:11:40 -04:00
Lioncash 14a97d082e CMakeLists: Resolve MSVC build failures 
Prevents the compiler tripping up about Windows headers.
 2020-10-30 14:57:58 -04:00
Jan Beich 50e52ade85 video_core: unbreak -Werror in NVDEC with Clang 
src/core/hle/service/nvdrv/devices/nvhost_nvdec_common.cpp:41:15: error: unused variable 'OutOfMemory' [-Werror,-Wunused-const-variable]
constexpr u32 OutOfMemory{static_cast<u32>(-12)};
              ^
 2020-10-30 16:43:10 +00:00
bunnei 8aa9ae5ba5
Merge pull request #4868 from lioncash/discard-error 
General: Make ignoring a discarded return value an error
 2020-10-30 00:35:40 -07:00
Lioncash 11d0a6e7b8 General: Catch more expressions with no effect on MSVC 
MSVC lets us fine-tune catching expressions with no side-effects a
little more.
 2020-10-30 00:13:26 -04:00
Lioncash 26547d3e3b General: Make ignoring a discarded return value an error 
Allows our CI to catch more potential bugs. This also removes the
[[nodiscard]] attribute of IOFile's Open member function. There are
cases where a file may want to be opened, but have the status of it
checked at a later time.
 2020-10-30 00:13:21 -04:00
Lioncash 8049b8beb6 common/stream: Be explicit with copy and move operators 2020-10-29 22:57:35 -04:00
Lioncash 12eeffcb7c vp9: Be explicit with copy and move operators 
It's deprecated in the language to autogenerate these if the destructor
for a type is specified, so we can explicitly specify how we want these
to be generated.
 2020-10-29 22:57:35 -04:00
Lioncash 0d713cf8eb vp9: Mark functions with [[nodiscard]] where applicable 
Prevents values from mistakenly being discarded in cases where it's a
bug to do so.
 2020-10-29 22:57:32 -04:00
Lioncash badea3b301 vp9: Provide a default initializer for "hidden" member 
The API of VP9 exposes a WasFrameHidden() function which accesses this
member. Given the constructor previously didn't initialize this member,
it's a potential vector for an uninitialized read.

Instead, we can initialize this to a deterministic value to prevent that
from occurring.
 2020-10-29 22:35:55 -04:00
Lioncash f8543249f0 vp9: Make some member functions internally linked 
These helper functions don't directly modify any member state and can be
hidden from view.
 2020-10-29 22:34:46 -04:00
Lioncash 5553bd3ba2 General: Resolve a few missing initializer warnings 
Resolves a few -Wmissing-initializer warnings.
 2020-10-29 19:37:07 -04:00
bunnei ef29bf4515
Merge pull request #4837 from lioncash/nvdec-2 
nvdec: Minor tidying up
 2020-10-29 12:28:07 -07:00
ameerj 3620206136 async_shaders: Increase Async worker thread count for 8+ thread cpus 
Adds 1 async worker thread for every 2 available threads above 8
 2020-10-29 14:16:45 -04:00
bunnei 2dbb144fc6
Merge pull request #4781 from german77/GChotplug 
Add hotplug, rumble and fix 3rd party adapters for the GC adapter
 2020-10-29 10:28:19 -07:00
Morph 9cfc5fee2f kernel/process: Add missing <ctime> include 
Fixes compilation on MSVC
 2020-10-29 03:17:20 -04:00
LC 1a6b1bf1d7
Merge pull request #4857 from liushuyu/master 
web_service: follow-up fix to #4842
 2020-10-29 01:54:45 -04:00
bunnei c5134cbf3a
Merge pull request #4835 from lat9nq/rng-default-time 
kernel: Use the current time as the default RNG seed
 2020-10-28 22:51:29 -07:00
bunnei c6d001c94f
Merge pull request #4838 from lioncash/syncmgr 
sync_manager: Amend parameter order of calls to SyncptIncr constructor
 2020-10-28 22:49:22 -07:00
liushuyu cf63eacc1a
web_service: follow-up fix to #4842 ... 
* The web_service http request is now fixed on Windows (R) platform.
* The issue is due to a complicated race-condition in `httplib`, a detailed
  explanation is available at https://github.com/yhirose/cpp-httplib/pull/701
* A pending Pull Request on `httplib` has been applied to remedy the
  said race-condition.
* The socket availability check is removed due to a behavioral chice of
  `httplib` that a socket will not be created before any actual request
  is sent.
 2020-10-28 23:16:06 -06:00
german 5333db91c1 Add hotplug, rumble and fix 3rd party adapters for the GC adapter 2020-10-28 21:12:34 -05:00
bunnei 156556ddd2 web_service: web_backend: Handle socket errors with GenericRequest. 
- Fixes a shutdown crash when we try to submit telemetry if there is a service issue.
 2020-10-28 17:19:12 -07:00
bunnei 94eca09cf6 video_core: cdma_pusher: Add missing LOG_DEBUG field in ExecuteCommand. 2020-10-28 16:47:08 -07:00
bunnei 7af2cb4318
Merge pull request #4846 from lioncash/service-fn 
service: Update function tables
 2020-10-28 13:47:56 -07:00
ReinUsesLisp 657771bdcb shader: Partially implement texture cube array shadow 
This implements texture cube arrays with shadow comparisons but doesn't
fix the asserts related to it.

Fixes out of bounds reads on swizzle constructors and makes them use
bounds checked ::at instead of the unsafe operator[].
 2020-10-28 17:12:40 -03:00
ReinUsesLisp 44b552be71 shader/arithmetic: Implement FCMP immediate + register variant 
Trivially add the encoding for this.
 2020-10-28 17:05:41 -03:00
LC 725fcbb368
Merge pull request #4851 from ReinUsesLisp/core-threads-race 
hle/kernel: Remove unused registered_core_threads to fix data races
 2020-10-28 04:54:35 -04:00
LC a1f176ce52
Merge pull request #4850 from ReinUsesLisp/fiber-ptr-ref 
common/fiber: Take shared_ptr<Fiber> by copy in YieldTo
 2020-10-28 04:54:19 -04:00
LC 1fd22823bc
Merge pull request #4849 from ReinUsesLisp/fix-fiber-test 
tests: Fix data race in fibers test
 2020-10-28 04:26:10 -04:00
LC 978e7897a3
Merge pull request #4848 from ReinUsesLisp/type-limits 
video_core: Enforce -Werror=type-limits
 2020-10-28 03:16:10 -04:00
ReinUsesLisp 79da90cea8 video_core: Enforce -Wredundant-move and -Wpessimizing-move 
Silence three warnings and make them errors to avoid introducing more in the future.
 2020-10-28 02:44:50 -03:00
ReinUsesLisp 4a451e5849 video_core: Enforce -Werror=type-limits 
Silences one warning and avoids introducing more in the future.
 2020-10-28 02:37:47 -03:00
ReinUsesLisp cdb2480d39 common/fiber: Take shared_ptr<Fiber> by copy in YieldTo 
YieldTo does not intend to modify the passed shared_ptrs.
Pass it by copy to keep a reference count while this function executes.
 2020-10-28 02:02:44 -03:00
ReinUsesLisp 3fdb42e0b4 tests: Fix data race in fibers test 
Previous to this commit, the tests were using operator[] from
unordered_map to query elements but this silently inserts empty elements
when they don't exist. If all threads were executed without concurrency,
this wouldn't be an issue, but the same unordered_map could be written
from two threads at the same time. This is a data race and makes some
previously inserted elements invisible for a short period of time,
causing them to insert and return an empty element. This default
constructed element (a zero) was used to index an array of fibers that
asserted when one of them was nullptr, shutting the test session off.

To address this issue, lock on thread id reads and writes. This could be
a shared mutex to allow concurrent reads, but the definition of
std::this_thread::get_id is fuzzy when using non-standard techniques
like fibers. I opted to use a standard mutex.

While we are at it, fix the included headers.
 2020-10-28 01:41:24 -03:00
Lioncash 020519def8 service: Update function tables 
Updates function tables according to info on SwitchBrew.
 2020-10-27 21:19:46 -04:00
liushuyu 8e673cbb08
web_backend: fix a regression introduced in 39c8d18 
* A regression was in 39c8d18 and token verification function was
  broken.
* The reason being `httplib` now requires OpenSSL 1.1+ API while
  LibreSSL 2.x provided OpenSSL 1.0 compatible API.
* The bundled LibreSSL has been updated to 3.2.2 so it now provides
  OpenSSL 1.1 compatible API now.
* Also the path hint has been added so that it will find the correct
  path to the CA certs on *nix systems.
* An option is provided so that *nix system distributions/providers can
  use their own SSL implementations when compiling Yuzu/Citra to
  (hopefully) complies with their maintenance guidelines.
* LURLParse is also removed since `httplib` can handle
  `scheme:host:port` string itself now.
 2020-10-27 02:57:19 -06:00
Lioncash 047e77e2f0 sync_manager: Amend parameter order of calls to SyncptIncr constructor 
Corrects some cases where the arguments would be incorrectly swapped.
 2020-10-27 03:22:57 -04:00
Lioncash cce14b4cd7 h264: Make WriteUe take a u32 
Enforces the type of the desired value in calling code.
 2020-10-27 03:21:53 -04:00
Lioncash 6291975731 vp9: std::move buffer within ComposeFrameHeader() 
We can move the buffer here to avoid a heap reallocation
 2020-10-27 02:27:31 -04:00
Lioncash 00decfbb07 vp9: Remove dead code 2020-10-27 02:26:17 -04:00
Lioncash 111802bbbb vp9: Join declarations with assignments 2020-10-27 02:26:03 -04:00
Lioncash 3b5d5fa86f vp9: Remove pessimizing moves 
The move will already occur without std::move.
 2020-10-27 02:21:40 -04:00
Lioncash dcc26c54a5 vp9: Resolve variable shadowing 2020-10-27 02:20:17 -04:00
Lioncash c04203b786 nvdec: Tidy up header includes 
Prevents a few unnecessary inclusions.
 2020-10-27 02:16:42 -04:00
bunnei 941563f981 yuzu: settings: Enable multicore, asynch GPU, and assembly shaders by default. 
- In general, this is now the preferred settings for most games.

# Conflicts:
#	src/yuzu/configuration/config.cpp
 2020-10-26 23:13:05 -07:00
bunnei d33399e1f4
Merge pull request #4729 from ameerj/nvdec-prod 
video_core: NVDEC Implementation
 2020-10-26 23:02:42 -07:00
ReinUsesLisp ce69ff2890 hle/kernel: Remove unused registered_core_threads to fix data races 
This member was only used on asserts and it triggered data races.
Remove it to fix them.
 2020-10-27 01:55:39 -03:00
bunnei c7f32931ee
Merge pull request #4832 from bunnei/cpu-manager-microprofile-fix 
core: cpu_manager: Add missing call to MicroProfileOnThreadExit().
 2020-10-26 21:29:09 -07:00
bunnei 1828f82000
Merge pull request #4833 from bunnei/timezonemanager-explicit 
hle: services: TimeZoneContentManager: This can be made explicit.
 2020-10-26 21:28:45 -07:00
ameerj eb67a45ca8 video_core: NVDEC Implementation 
This commit aims to implement the NVDEC (Nvidia Decoder) functionality, with video frame decoding being handled by the FFmpeg library.

The process begins with Ioctl commands being sent to the NVDEC and VIC (Video Image Composer) emulated devices. These allocate the necessary GPU buffers for the frame data, along with providing information on the incoming video data. A Submit command then signals the GPU to process and decode the frame data.

To decode the frame, the respective codec's header must be manually composed from the information provided by NVDEC, then sent with the raw frame data to the ffmpeg library.

Currently, H264 and VP9 are supported, with VP9 having some minor artifacting issues related mainly to the reference frame composition in its uncompressed header.

Async GPU is not properly implemented at the moment.

Co-Authored-By: David <25727384+ogniK5377@users.noreply.github.com>
 2020-10-26 23:07:36 -04:00
bunnei 9f08cea2c4
Merge pull request #4834 from lioncash/copy-fn 
controller: Pass ControllerParameters by reference in ReconfigureControllers()
 2020-10-26 18:49:26 -07:00
lat9nq 8bd246032a kernel: Use the current time as the default RNG seed 
Use the current time, not zero, as the default RNG seed.
 2020-10-26 21:42:11 -04:00
Lioncash 6b5f565324 controller: Pass ControllerParameters by reference in ReconfigureControllers() 
Prevents unnecessary copies and heap reallocations from occurring.
 2020-10-26 21:06:15 -04:00
bunnei 3984bb6def hle: services: TimeZoneContentManager: This can be made explicit. 2020-10-26 16:11:45 -07:00
bunnei 54aabb00b0 core: cpu_manager: Add missing call to MicroProfileOnThreadExit(). 
- Fixes an occasional crash when trying to launch subsequent games.
 2020-10-26 16:09:15 -07:00
Rodrigo Locatti 2f6ba54483
Merge pull request #4827 from lioncash/trunc 
controller: Convert led_patterns integer literals to bool literals
 2020-10-25 16:56:30 -03:00
Rodrigo Locatti ae3a755d13
Merge pull request #4828 from lioncash/lockguard 
general: Use template deduction guides for lock_guard
 2020-10-25 16:55:54 -03:00
Lioncash 98f4c5e7b8 general: Use template deduction guides for lock_guard 
Same behavior, less code.
 2020-10-25 13:53:22 -04:00
Lioncash 061a63547f controller: Convert led_patterns integer literals to bool literals 
'bool' isn't always guaranteed to be the same size as an int, so this
can technically cause truncation warnings if we support other platforms.
 2020-10-25 13:44:12 -04:00
Morph 9afbcd9e8a applets/profile_select: Resolve a warning in exec() 
Resolves a warning where not all control paths return a value.
 2020-10-25 09:16:43 -04:00
bunnei ab052cf684
Merge pull request #4817 from Kewlan/open-single-save-location 
main/profile_select: Don't ask for profile when there's only one.
 2020-10-24 03:02:19 -07:00
LC 6f6d83befa
Merge pull request #4816 from Morph1984/controller-disconnect-fix 
sdl_impl: Fix controller reconnection issues
 2020-10-23 13:53:51 -04:00
bunnei 3e46934442
Merge pull request #4706 from ReinUsesLisp/cmake-host-shaders 
video_core: Fix instances where msbuild always regenerated host shaders
 2020-10-23 10:01:16 -07:00
bunnei e7042163c8
Merge pull request #4792 from bunnei/rtc-fix 
service: time: Update current time with changes to RTC setting.
 2020-10-22 20:46:54 -07:00
Kewlan 85b5b816cf Don't ask for profile when there's only one. 2020-10-22 11:16:56 +02:00
Lioncash ea20b5c970 core: Fix clang build pt.3 
Should finally resolve building with clang.
 2020-10-21 22:14:23 -04:00
Morph 2f852f182a sdl_impl: Fix controller reconnection issues 
It turns out that after a controller is disconnected, there is a chance that events from the previous controller are sent/processed after it has been disconnected.
This causes the previously disconnected controller to reappear as connected due to GetSDLJoystickBySDLID() emplacing this controller back to the map.

Fix this by only returning an SDLJoystick if and only if it exists in the map.
 2020-10-21 09:41:30 -04:00
bunnei 1fc61d09d3
Merge pull request #4811 from lioncash/warn-video 
video_core: Conditially activate relevant compiler warnings
 2020-10-20 20:59:37 -07:00
Lioncash e408bd3b7c core: Fix clang build pt.2 
Resolves the clang build issue in a more unintrusive way.
 2020-10-20 22:16:03 -04:00
bunnei 3d592972dc
Revert "core: Fix clang build" 2020-10-20 19:07:39 -07:00
Lioncash 678d012c2c video_core: Conditially activate relevant compiler warnings 
These compiler flags aren't shared with clang, so specifying these flags
unconditionally can lead to a bit of warning spam.

While we're in the area, we can also enable -Wunused-but-set-parameter
given this is almost always a bug.
 2020-10-20 20:28:25 -04:00
Lioncash fdd9154069 kernel: Fix build with recent compiler flag changes 
This slipped through the cracks due to another change being merged
before the compiler flag changes.
 2020-10-20 20:23:18 -04:00
LC 536c51912d
Merge pull request #4807 from ReinUsesLisp/glasm-robust-ssbo 
gl_arb_decompiler: Implement robust buffer operations
 2020-10-20 19:19:38 -04:00
LC 88d5140cf2
Merge pull request #4796 from lioncash/clang 
core: Fix clang build
 2020-10-20 19:19:12 -04:00
bunnei 940c3bf68d
Merge pull request #4390 from ogniK5377/get-applet-inf-stub 
nifm: GetAppletInfo stub
 2020-10-20 15:59:19 -07:00
LC ea8345cdcd
Merge pull request #4809 from Morph1984/mjolnir-p3 
configure_input_player: Fix modifier buttons
 2020-10-20 15:00:06 -04:00
bunnei e03dc4d569
Merge pull request #4627 from Morph1984/fix-dinput-controller-disconnect 
sdl_impl: Erase the SDLJoystick entry after removing a controller
 2020-10-20 11:40:06 -07:00
Morph ff82f3894a configure_input_player: Fix modifier buttons 
Fix them for real this time, now they finally work.
 2020-10-20 14:23:25 -04:00
ReinUsesLisp f21a189148 gl_arb_decompiler: Implement robust buffer operations 
This emulates the behavior we get on GLSL with regular SSBOs with a
pointer + length pair. It aims to be consistent with the crashes we
might get.

Out of bounds stores are ignored. Atomics are ignored and return zero.
Reads return zero.
 2020-10-20 03:34:32 -03:00
David Marcec 298b50e220 Added remaining params 2020-10-20 16:45:01 +11:00
David Marcec acd35e1b60 nifm: GetAppletInfo stub 
Fixes crash for Catherine Full Body
 2020-10-20 16:42:40 +11:00
bunnei 60bd54776a
Merge pull request #4788 from ReinUsesLisp/lockfree-host-thread 
kernel: Implement host thread register methods without locking
 2020-10-19 22:31:52 -07:00
bunnei e7a26ecec5
Merge pull request #4785 from Morph1984/fs-hades 
filesystem: Fix CreateDirectory and DeleteFile
 2020-10-19 16:04:01 -07:00
bunnei f1ead11df7
Merge pull request #4204 from ReinUsesLisp/vulkan-1.0 
renderer_vulkan: Create and properly use Vulkan 1.0 instances when 1.1 is not available
 2020-10-19 14:18:54 -07:00
bunnei 598ef6b0b3
Merge pull request #4802 from lioncash/bcat 
core: Add boxcat sources with target_sources
 2020-10-19 12:40:49 -07:00
bunnei 54b977acaa
Merge pull request #4783 from bunnei/nvdrv-freespace 
hle: service: nvdrv: Implement nvhost_as_gpu::FreeSpace.
 2020-10-18 12:41:18 -07:00
Lioncash 0ab7bfdfce core: Add boxcat sources with target_sources 
Same behavior, minus a script variable.
 2020-10-18 08:09:06 -04:00
bunnei 2190f1a2b7
Merge pull request #4801 from lioncash/missing-bound 
mii/manager: Make use of unused lower bound in GetRandomValue()
 2020-10-17 23:32:40 -07:00
bunnei 743fe1aea3
Merge pull request #4782 from ReinUsesLisp/remove-dyn-primitive 
vk_graphics_pipeline: Manage primitive topology as fixed state
 2020-10-17 22:14:17 -07:00
Lioncash be1954e04c core: Fix clang build 
Recent changes to the build system that made more warnings be flagged as
errors caused building via clang to break.

Fixes #4795
 2020-10-17 19:50:39 -04:00
Lioncash c1577f3448 mii/manager: Make use of unused lower bound in GetRandomValue() 
Previously, the lower bound wasn't being used and zero was being used as
the lower bound every time this function was called.

This affects the outcome of some of the randomized entries a little bit,
for example, the lower-bound for beard and mustache flags was supposed
to be 1, not 0.

Aside from these cases, the bug didn't affect anything else.
 2020-10-17 09:50:04 -04:00
bunnei 1eb908bc88
Merge pull request #4797 from bunnei/bcat-errors 
service: bcat: Check client connection before interacting with socket.
 2020-10-16 23:28:40 -07:00
bunnei 363c644730 service: bcat: Check client connection before interacting with socket. 
- Fixes a crash when BCAT service is offline.
 2020-10-16 21:16:56 -07:00
Lioncash 30b1e71066 udp/client: Make use of designated initializers in TestCommunication() 
Same behavior, but makes the callback list nicer to look at.
 2020-10-16 06:23:51 -04:00
Lioncash 36cfb234d5 udp/client: Take std::function by const reference with TestCommunication() 
Avoids redundant copies.
 2020-10-16 06:22:29 -04:00
Morph 7b3f5845d2 sdl_impl: Erase the SDLJoystick entry after removing a controller 
Previously, disconnecting a controller still leaves a null SDLJoystick entry within the vector of SDLJoysticks mapped by GUID.
When a DirectInput device of the same GUID is reconnected, it adds that device to a new port causing non-detectable input.
Furthermore, opening the "Configure" menu would cause yuzu to crash since it first tries to resolve the name of a null SDLJoystick entry that was not removed.
Resolve this by properly erasing the SDLJoystick entry from the vector.
 2020-10-16 00:04:59 -04:00
bunnei 64f967fd49
Merge pull request #4790 from lioncash/input-common 
input_common/CMakeLists: Make some warnings errors
 2020-10-15 20:59:34 -07:00
bunnei dbd1662ae2
Merge pull request #4784 from bunnei/cancelbuffer 
hle: service: vi: Implement BufferQueue::CancelBuffer.
 2020-10-15 19:57:27 -07:00
Lioncash 046c0c91a3 input_common/CMakeLists: Make some warnings errors 
Makes the input_common code warnings consistent with the rest of the
codebase.
 2020-10-15 19:37:51 -04:00
bunnei 1d714c8c7f service: acc: Stub IManagerForApplication::StoreOpenContext. 
- Used by Super Mario 3D All-Stars.
 2020-10-14 20:06:33 -07:00
bunnei d47ac3ce09
Merge pull request #4772 from goldenx86/block-rdna 
vk_device: Block VK_EXT_extended_dynamic_state for RDNA devices
 2020-10-14 17:51:39 -07:00
bunnei 1f186f34a2 hle: service: vi: Implement BufferQueue::CancelBuffer. 
- This is used by Super Mario 3D All-Stars.
 2020-10-13 22:11:52 -07:00
ReinUsesLisp b9a9b83bee kernel: Implement host thread register methods without locking 
Locks on GetCurrentHostThreadID were causing performance issues
according to Visual Studio's profiler. It was consuming twice the time
as arm_interface.Run(). The cost was not in the function itself but in
the lockinig it required.

Reimplement these functions using atomics and static storage instead of
an unordered_map. This is a side effect to avoid locking and using linked
lists for reads.

Replace unordered_map with a linear search.
 2020-10-13 18:00:25 -03:00
Lioncash 9f9b64d280 audio_core/CMakeLists: Make warnings consistent with core 
Normalizes the warnings shared between audio_core and core.
 2020-10-13 16:36:58 -04:00
Lioncash 39c8d18feb core/CMakeLists: Make some warnings errors 
Makes our error coverage a little more consistent across the board by
applying it to Linux side of things as well. This also makes it more
consistent with the warning settings in other libraries in the project.

This also updates httplib to 0.7.9, as there are several warning
cleanups made that allow us to enable several warnings as errors.
 2020-10-13 13:16:49 -04:00
ReinUsesLisp e4e0abc418 vk_graphics_pipeline: Manage primitive topology as fixed state 
Vulkan has requirements for primitive topologies that don't play nicely
with yuzu's. Since it's only 4 bits, we can move it to fixed state
without changing the size of the pipeline key.

- Fixes a regression on recent Nvidia drivers on Fire Emblem: Three
  Houses.
 2020-10-13 04:08:33 -03:00
Morph 8db3feae19 filesystem: Fix CreateDirectory and DeleteFile 
Add a check if dir is nullptr (does not exist)

Fixes save game creation in Hades
 2020-10-13 00:57:04 -04:00
bunnei 62c6c9f6a6 service: time: Update current time with changes to RTC setting. 
- This can be used to advance time, e.g. for Pokemon Sword/Shield pokejobs.
 2020-10-12 18:09:15 -07:00
bunnei d291fc1a51
Merge pull request #3929 from FearlessTobi/ticket-keys 
file_sys/nsp: Make SetTicketKeys actually do something
 2020-10-12 17:58:36 -07:00
bunnei b260847218 hle: service: nvdrv: Implement nvhost_as_gpu::FreeSpace. 
- This is used by Super Mario 3D All-Stars.
 2020-10-12 17:39:14 -07:00
bunnei 4c348f4069
Merge pull request #4766 from ReinUsesLisp/tmml-cube 
shader/texture: Implement CUBE texture type for TMML and fix arrays
 2020-10-12 12:53:57 -07:00
bunnei 419a59a7b1
Merge pull request #4775 from ReinUsesLisp/enforce-class-memaccess 
video_core: Enforce -Wclass-memaccess
 2020-10-09 23:38:02 -07:00
bunnei f250011ba0
Merge pull request #4757 from german77/BetterMotion 
InputCommon: Add compatibility with only accelerometer and auto calibrate for drift
 2020-10-09 23:37:08 -07:00
ReinUsesLisp e1600b0962 video_core: Enforce -Wclass-memaccess 2020-10-09 16:46:11 -03:00
LC 61b246a3a9
Merge pull request #4771 from ReinUsesLisp/warn-unused-var 
video_core: Enforce -Wunused-variable and -Wunused-but-set-variable
 2020-10-08 21:10:31 -04:00
goldenx86 0120e5b1d9 vk_device: Block VK_EXT_extended_dynamic_state for RDNA devices 
RDNA devices seem to crash when using VK_EXT_extended_dynamic_state in
the latest 20.9.2 proprietary Windows drivers. As a workaround, for now
we block device names corresponding to current RDNA released products.
 2020-10-08 21:27:49 -03:00
bunnei 06e65de93c
Merge pull request #4677 from german77/ShakeFromButton 
InputCommon: Add random motion input for buttons
 2020-10-08 10:18:39 -07:00
Rodrigo Locatti 7a99226785
Merge pull request #4765 from ReinUsesLisp/fix-sort-devices 
renderer_vulkan/wrapper: Fix physical device sorting
 2020-10-08 00:54:44 -03:00
ReinUsesLisp dffaffaac1 shader/texture: Implement CUBE texture type for TMML and fix arrays 
TMML takes an array argument that has no known meaning, this one appears
as the first component in gpr8 followed by s, t and r. Skip this
component when arrays are being used. Also implement CUBE texture types.

- Used by Pikmin 3: Deluxe Demo.
 2020-10-07 23:17:46 -03:00
bunnei 3446eb79b5
Merge pull request #4731 from lat9nq/mingw-zstd-fix 
common: Use system zstd on Linux
 2020-10-07 17:57:14 -07:00
bunnei 92adb69fa7
Merge pull request #4736 from Morph1984/home-button-input-protection-stub 
hid: Stub HomeButtonInputProtection service commands
 2020-10-07 14:54:05 -07:00
ReinUsesLisp cd3e959f23 renderer_vulkan/wrapper: Fix physical device sorting 
The old code had a sort function that was invalid and it didn't work as
expected when the base vector had a different order (e.g. renderdoc was
attached).

This sorts devices as expected and fixes a debug assert on MSVC.
 2020-10-07 17:13:22 -03:00
bunnei cc0dc3280d
Merge pull request #4710 from Morph1984/fix-integrated-updates 
submission_package: Fix updates integrated into cartridge images.
 2020-10-06 22:27:52 -07:00
bunnei 32b4627a9c
Merge pull request #4737 from Morph1984/setshimlibraryversion-stub 
capsrv: Stub 3 variants of SetShimLibraryVersion
 2020-10-06 21:39:38 -07:00
bunnei e9b81e9f01
Merge pull request #4727 from FrogTheFrog/patch-1 
Reduce the "shake" requirements when configuring UDP.
 2020-10-06 15:29:28 -07:00
bunnei 614bd0ee8c
Merge pull request #4742 from german77/InputFilter 
HID: Only use inputs corresponding to controller type
 2020-10-05 21:40:09 -07:00
german a54aee290f Address comments 2020-10-04 18:15:53 -05:00
german a220d8799e Add compatibility with only accelerometer and auto calibrate for drift 2020-10-03 22:22:01 -05:00
ReinUsesLisp 2a24b1c973 video_core: Enforce -Wunused-variable and -Wunused-but-set-variable 2020-10-02 21:19:35 -03:00
bunnei 182cf7d631
Merge pull request #4734 from german77/motionfusion 
HID: Add Stub for EnableSixAxisSensorFusion
 2020-10-01 22:39:39 -07:00
german 2f47b27654 Only use inputs corresponding to controller type 2020-10-01 19:39:53 -05:00
german 283616dbd8 Stubbed EnableSixAxisSensorFusion 2020-09-30 10:00:24 -05:00
David 4d0ae1a17a
Merge pull request #4291 from german77/ImplementControllerRumble 
input_common: First implementation of controller rumble
 2020-09-30 21:24:11 +10:00
David f7808f5658
Merge pull request #4726 from lioncash/applet 
frontend/controller: Eliminate dependency on the global system instance
 2020-09-30 21:22:45 +10:00
Morph 91bd2281bf caps_c: Stub SetShimLibraryVersion 
- Used by caps_su SetShimLibraryVersion
 2020-09-30 07:19:46 -04:00
Morph 7d287a6fb0 caps_u: Stub SetShimLibraryVersion 
- Used in Super Smash Bros. Ultimate
 2020-09-30 07:19:46 -04:00
Morph 9a251339dc caps_su: Properly stub SetShimLibraryVersion 2020-09-30 07:19:46 -04:00
Morph 6380731486 hid: Stub HomeButtonInputProtection service commands 
- Used in 1-2 Switch. Given that we do not emulate the functionality of the home button yet, we can stub this for now.
 2020-09-30 06:38:24 -04:00
LC 1ba0b077fc
Merge pull request #4733 from ReinUsesLisp/game-list-leak 
qt/game_list: Give GameListSearchField::KeyReleaseEater a parent
 2020-09-30 05:54:18 -04:00
LC cb56eaee41
Merge pull request #4732 from ReinUsesLisp/wall-clock-destr 
common/wall_clock: Add virtual destructors
 2020-09-30 05:53:12 -04:00
LC 3665a05488
Merge pull request #4735 from goldenx86/patch-1 
Remove ext_extended_dynamic_state blacklist
 2020-09-30 05:52:47 -04:00
bunnei 392c1b96bc
Merge pull request #4705 from german77/SplitMotionPoller 
HID: Use different timing for motion
 2020-09-30 01:04:22 -07:00
Lukas Senionis 6ee1a784b8 Reduce the "shake" requirements when configuring UDP. 2020-09-30 10:30:33 +03:00
Matías Locatti d7843b8ef2
Remove ext_extended_dynamic_state blacklist 
Latest AMD 20.9.2 driver fixed this, there's no reason to keep it blocked, as the previous stable signed driver release doesn't include the extension.
 2020-09-30 03:13:38 -03:00
ReinUsesLisp 771a9c21cc common/wall_clock: Add virtual destructors 
From -fsanitize=address, this code wasn't calling the proper destructor.
Adding virtual destructors for each inherited class and the base class
fixes this bug.

While we are at it, mark the functions as final.
 2020-09-30 02:53:34 -03:00
bunnei a1e3f6e27b
Merge pull request #4728 from Morph1984/applets-on-top 
main: Allow applets to display on top while fullscreen
 2020-09-29 15:46:44 -07:00
bunnei 09609dd50e
Merge pull request #4721 from lioncash/genfn 
codec: Make lookup table static constexpr
 2020-09-29 15:16:24 -07:00
bunnei 2a82f1b08b
Merge pull request #4722 from lioncash/casting 
cubeb_sink: Use static_cast instead of reinterpret_cast in DataCallback()
 2020-09-29 15:09:12 -07:00
bunnei 02ea62568f
Merge pull request #1703 from DarkLordZach/nvdec-ioctl 
nvdrv: Stub nvdec/vic ioctls to bypass nvdec movies
 2020-09-29 15:00:48 -07:00
ReinUsesLisp ae6df703f5 qt/game_list: Give GameListSearchField::KeyReleaseEater a parent 
This fixes a memory leak as KeyReleaseEater's destructor was never
called.
 2020-09-29 16:23:16 -03:00
german ab88c2f611 First implementation of controller rumble 2020-09-29 10:38:25 -04:00
lat9nq 2cbce77b92 CMakeLists: use system zstd on Linux 
From what I understand, this tells CMake to use the system, not conan,
version of zstd. Required to build on the coming MinGW Docker container.
 2020-09-28 21:11:39 -04:00
lat9nq 9d665cb8db CMakeLists: fix for finding zstd on linux-mingw 2020-09-28 20:28:47 -04:00
bunnei a8be822e8e
Merge pull request #4719 from lioncash/audio-warn 
audio_core: Resolve sign conversion warnings
 2020-09-27 01:52:59 -07:00
Rodrigo Locatti e5a1e0a76d
Merge pull request #4724 from lat9nq/fix-vulkan-nvidia-allocate-2 
vk_stream_buffer: Fix initializing Vulkan with NVIDIA on Linux
 2020-09-26 23:52:49 +00:00
bunnei 442096298e
Merge pull request #4703 from lioncash/desig7 
shader/registry: Make use of designated initializers where applicable
 2020-09-26 15:23:15 -07:00
Morph 86e4aa81e9 main: Allow applets to display on top while fullscreen 
Using the Qt::WindowStaysOnTopHint flag allows these dialogs to show up on top while running in fullscreen. However, if yuzu goes out of focus (by alt-tabbing or otherwise), this flag does not seem to have an effect.
 2020-09-26 06:55:47 -04:00
bunnei fbb5ca2633
Merge pull request #4718 from lioncash/vk 
vk_command_pool: Add missing header guard
 2020-09-26 00:13:48 -07:00
bunnei 891090799c
Merge pull request #4720 from lioncash/header 
audio_core: Remove unnecessary inclusions
 2020-09-25 22:04:26 -07:00
Lioncash 5c4e237902 core: Mark GetInstance() as deprecated 
This way it's obvious that this function shouldn't be used in any future
code.
 2020-09-25 19:23:23 -04:00
Lioncash 3e4a0a13cb frontend/controller: Eliminate dependency on the global system instance 2020-09-25 19:23:20 -04:00
german 2978232390 Add random motion input to keyboard 2020-09-25 17:59:52 -05:00
german 03b574ae22 Add random motion input to SDL 2020-09-25 17:59:52 -05:00
Lioncash 90c6141164 command_generator: Make lookup table static constexpr 
Allows compilers to elide needing to push these values on the stack
every time the function is called.
 2020-09-25 18:33:04 -04:00
lat9nq ca26fd0f42 vk_stream_buffer: Fix initializing Vulkan with NVIDIA on Linux 
The previous fix only partially solved the issue, as only certain GPUs that needed 9 or less MiB subtracted would work (i.e. GTX 980 Ti, GT 730). This takes from DXVK's example to divide `heap_size` by 2 to determine `allocable_size`. Additionally tested on my Quadro K4200, which previously required setting it to 12 to boot.
 2020-09-25 17:42:59 -04:00
Lioncash dc83ca8914 behavior_info: Fix typo Renerer -> Renderer 2020-09-25 17:14:02 -04:00
Lioncash 4073931305 cubeb_sink: Use static_cast instead of reinterpret_cast in DataCallback() 
Conversions from void* to the proper data type are well-defined and
supported by static_cast. We don't need to use reinterpret_cast here.
 2020-09-25 17:10:02 -04:00
Lioncash 7c0908f301 codec: Make lookup table static constexpr 
Allows compilers to elide needing to push these values on the stack
every time the function is called.
 2020-09-25 14:24:25 -04:00
Lioncash 966966dc02 audio_core: Remove unnecessary inclusions 
Same behavior, but removes header dependencies where they don't need to
be.
 2020-09-25 13:19:42 -04:00
Lioncash 8b4ecf22d4 audio_core: Resolve sign conversion warnings 
While were at it, we can also enable sign conversion warnings and other
common warnings as errors to prevent these from creeping back into the
codebase.
 2020-09-25 01:22:47 -04:00
Lioncash 111852a983 effect_context: Make use of explicit where applicable 
While we're at it we can make the destructor of the base class virtual
to ensure that any polymorphism issues never occur.
 2020-09-25 00:27:11 -04:00
Lioncash 940d85241b vk_command_pool: Move definition of Pool into the cpp file 
Allows the implementation details to be changed without recompiling any
files that include this header.
 2020-09-25 00:15:52 -04:00
Lioncash 4ed4bba305 vk_command_pool: Make use of override on destructor 2020-09-25 00:14:10 -04:00
Lioncash e0f2db4376 vk_command_pool: Add missing header guard 2020-09-25 00:12:45 -04:00
Levi Behunin bc69cc1511 More forgetting... duh 2020-09-24 22:12:13 -06:00
LC 4d4afc1502
Merge pull request #4717 from lioncash/debug 
service: Restore "unused" function
 2020-09-25 00:07:19 -04:00
Lioncash f3a1bf53f9 service: Restore "unused" function 
Turns out this function is actually used, but within a trace log.
 2020-09-25 00:06:40 -04:00
bunnei 2634e3c6eb
Merge pull request #4711 from lioncash/move5 
arithmetic_integer_immediate: Make use of std::move where applicable
 2020-09-24 21:02:42 -07:00
Levi Behunin 24c1bb3842 Forgot to apply suggestion here as well 2020-09-24 21:58:51 -06:00
Levi Behunin a19dc3bf00 Address Comments 2020-09-24 21:52:23 -06:00
Levi Behunin d53b79ff5c Start of Integer flags implementation 2020-09-24 16:40:06 -06:00
Morph 3602df7f1f submission_package: Fix updates integrated into cartridge images. 2020-09-24 17:23:14 -04:00
bunnei fa4294cc6f
Merge pull request #4678 from Morph1984/LoadOpenContext-partial-impl 
acc: Partially implement LoadOpenContext
 2020-09-24 11:21:25 -07:00
Lioncash e3a615a616 arithmetic_integer_immediate: Make use of std::move where applicable 
Same behavior, minus any redundant atomic reference count increments and
decrements.
 2020-09-24 13:28:45 -04:00
ReinUsesLisp 67af0323f0 video_core: Fix instances where msbuild always regenerated host shaders 
When HEADER_GENERATOR was included in the DEPENDS section of custom
commands, msbuild assumed this was always modified. Changing this file
is not common so we can remove it from there.
 2020-09-23 22:27:17 -03:00
bunnei d66b897a6d
Merge pull request #4674 from ReinUsesLisp/timeline-semaphores 
renderer_vulkan: Make unconditional use of VK_KHR_timeline_semaphore
 2020-09-23 18:24:27 -07:00
german ddff03cff5 Use different timing for motion 2020-09-23 19:09:33 -05:00
bunnei 10e8acc451
Merge pull request #4618 from german77/GcAdapterAutoMap 
Add automap feature for GC adapter
 2020-09-23 15:55:26 -07:00
Lioncash 77532ebde3 shader/registry: Silence a -Wshadow warning 2020-09-23 15:10:25 -04:00
Lioncash cd6f4f7eed shader/registry: Remove unnecessary namespace qualifiers 
Using statements already make these unnecessary.
 2020-09-23 15:08:34 -04:00
Rodrigo Locatti 8b0f334e0c
Merge pull request #4702 from lioncash/doc-warn 
memory: Resolve a -Wdocumentation warning
 2020-09-23 19:07:47 +00:00
Rodrigo Locatti c307ae2402
Merge pull request #4701 from lioncash/unused-proto 
install_dialog: Remove unused function prototype
 2020-09-23 19:07:27 +00:00
Rodrigo Locatti 6d9661939f
Merge pull request #4700 from lioncash/copies 
game_list: Eliminate redundant argument copies
 2020-09-23 19:06:47 +00:00
Lioncash ffeb4ef83e shader/registry: Make use of designated initializers where applicable 
Same behavior, less repetition.
 2020-09-23 15:06:25 -04:00
Lioncash b14d344dfc memory: Resolve a -Wdocumentation warning 
memory doesn't exist as a parameter any more.
 2020-09-23 13:39:27 -04:00
Lioncash aa35e51fcd install_dialog: Make use of [[nodiscard]] where applicable 
Allows the compiler to warn against cases where the return value isn't
used (which would be a bug).
 2020-09-23 13:22:04 -04:00
Lioncash e107870bc8 install_dialog: Remove unused function prototype 
This function doesn't have an implementation, so it can be removed to
prevent others from unintentionally using it.
 2020-09-23 13:20:12 -04:00
Lioncash f43a1da808 game_list: Make game list function naming consistent 
Makes the naming consistent with the rest of the functions that are
present.
 2020-09-23 11:28:11 -04:00
Lioncash d264b7375c game_list: Eliminate redundant argument copies 
Several functions can be taken by const reference to avoid copies
 2020-09-23 11:20:12 -04:00
Lioncash 0dc6967ff1 control_flow: emplace elements in place within TryQuery() 
Places data structures where they'll eventually be moved to to avoid
needing to even move them in the first place.
 2020-09-22 22:54:36 -04:00
Lioncash fcd0145eb5 control_flow: Make use of std::move in InsertBranch() 
Avoids unnecessary atomic increments and decrements.
 2020-09-22 22:48:09 -04:00
Lioncash ff45c39578 General: Make use of std::nullopt where applicable 
Allows some implementations to avoid completely zeroing out the internal
buffer of the optional, and instead only set the validity byte within
the structure.

This also makes it consistent how we return empty optionals.
 2020-09-22 17:32:33 -04:00
Lioncash a881efbf26 ips_layer: Eliminate a redundant copy in Parse() 
Prevents unnecessary copying of the line being parsed.
 2020-09-22 16:38:45 -04:00
bunnei 53829d4cbd
Merge pull request #4675 from Morph1984/fix-boot-multicontent 
submission_package: Account for multi-content NSPs
 2020-09-21 16:36:46 -07:00
Morph 7a504a9365 acc: Stub LoadOpenContext 
This is used in multiple games such as:
- Clubhouse Games: 51 Worldwide Classics
- Grandia HD Collection
- XCOM 2 Collection
- Baldur's Gate 1/2
- Dr Kawashima's Brain Training
- Super Mario 3D All-Stars
 2020-09-21 01:01:02 -04:00
Rodrigo Locatti a2eb44db82
Merge pull request #4692 from ReinUsesLisp/remove-vsync 
renderer_opengl: Remove emulated mailbox presentation
 2020-09-21 00:21:32 +00:00
bunnei 754109fd54
Merge pull request #4683 from Morph1984/NpadHandheldActivationMode-impl 
hid: Implement Get/SetNpadHandheldActivationMode
 2020-09-20 12:39:20 -07:00
ReinUsesLisp 7003090187 renderer_opengl: Remove emulated mailbox presentation 
Emulated mailbox presentation was causing performance issues on
Nvidia's OpenGL driver. Remove it.
 2020-09-20 16:29:41 -03:00
bunnei 8a85a562ed
Merge pull request #4643 from FearlessTobi/decrease-pad-update-interval 
Test: Decrease pad_update_ns
 2020-09-19 00:39:50 -07:00
ReinUsesLisp 4f5bbe56ba vk_query_cache: Hack counter destructor to avoid reserving queries 
This is a hack to destroy all HostCounter instances before the base
class destructor is called. The query cache should be redesigned to have
a proper ownership model instead of using shared pointers.

For now, destroy the host counter hierarchy from the derived class
destructor.
 2020-09-19 01:47:29 -03:00
ReinUsesLisp 58b0ae84b5 renderer_vulkan: Make unconditional use of VK_KHR_timeline_semaphore 
This reworks how host<->device synchronization works on the Vulkan
backend. Instead of "protecting" resources with a fence and signalling
these as free when the fence is known to be signalled by the host GPU,
use timeline semaphores.

Vulkan timeline semaphores allow use to work on a subset of D3D12
fences. As far as we are concerned, timeline semaphores are a value set
by the host or the device that can be waited by either of them.

Taking advantange of this, we can have a monolithically increasing
atomic value for each submission to the graphics queue. Instead of
protecting resources with a fence, we simply store the current logical
tick (the atomic value stored in CPU memory). When we want to know if a
resource is free, it can be compared to the current GPU tick.

This greatly simplifies resource management code and the free status of
resources should have less false negatives.

To workaround bugs in validation layers, when these are attached there's
a thread waiting for timeline semaphores.
 2020-09-19 01:46:37 -03:00
german c5e257017f Add automap feature for GC adapter 2020-09-18 16:51:16 -05:00
Lioncash 91bca9eb0b fermi_2d: Make use of designated initializers 
Same behavior, less repetition. We can also ensure all members of Config
are initialized.
 2020-09-18 13:55:21 -04:00
Morph ab961e0701 hid: Implement Get/SetNpadHandheldActivationMode 
- Used in Clubhouse Games: 51 Worldwide Classics
 2020-09-18 10:10:30 -04:00
Morph 70499b8cbd configure_input_player: Fixes motion mapping using ConfigureButtonClick 2020-09-18 03:56:31 -04:00
bunnei 8568f44ffa
Merge pull request #4647 from Morph1984/readd-context-menu 
configure_input_player: Re-add "Clear" context menu option
 2020-09-17 22:59:13 -07:00
Morph 40a72e9cd5 am: Stub GetPreviousProgramIndex 
- Used in Super Mario 3D All-Stars
 2020-09-17 22:03:02 -04:00
Morph 65d9def873 configure_input_player: Re-add "Clear" context menu option 
The context menu was removed in Mjölnir Part 1 as part of the input rewrite as we were unaware of it's usage statistics.
However, as this was the only way to clear the inputs of individual buttons, this PR will re-add it back in.
 2020-09-17 21:57:06 -04:00
Morph 41c2f5200c submission_package: Account for multi-content NSPs 
Previously we assumed a submission package can only contain one Program NCA with a single TitleID.
However, Super Mario 3D All-Stars contains four Program NCAs, each with their unique TitleIDs.
This accounts for the existence of multi-content games such as this one.
- Fixes booting Super Mario 3D All-Stars from the games list.
 2020-09-17 20:44:51 -04:00
Rodrigo Locatti 53fc5d0190
Merge pull request #4670 from lioncash/initializer 
arm_dynarmic_cp15: Initialize member variables
 2020-09-17 21:20:53 +00:00
Rodrigo Locatti 9bdca01c27
Merge pull request #4665 from lioncash/sm-kernel 
service/sm: Eliminate dependency on the global system instance
 2020-09-17 21:20:39 +00:00
Rodrigo Locatti 8100275309
Merge pull request #4666 from lioncash/unused-func 
service: Remove unused funcation
 2020-09-17 21:19:48 +00:00
Rodrigo Locatti 131532b570
Merge pull request #4671 from lioncash/nfp-copy 
command_generator/nfp: Eliminate unnecessary copies
 2020-09-17 21:19:12 +00:00
Rodrigo Locatti 31461589c5
Merge pull request #4672 from lioncash/narrowing 
decoder/texture: Eliminate narrowing conversion in GetTldCode()
 2020-09-17 21:17:54 +00:00
Rodrigo Locatti 9f51242524
Merge pull request #4673 from lioncash/fallthrough 
decode/image: Eliminate switch fallthrough in DecodeImage()
 2020-09-17 21:17:16 +00:00
bunnei 3f6d83b27c
Merge pull request #4594 from german77/MotionHID 
hid/configuration: Implement motion controls to HID
 2020-09-17 12:39:01 -07:00
Lioncash 4944d48ee8 decode/image: Eliminate switch fallthrough in DecodeImage() 
Fortunately this didn't result in any issues, given the block that code
was falling through to would immediately break.
 2020-09-17 15:12:18 -04:00
Lioncash ffc66f089d decoder/texture: Eliminate narrowing conversion in GetTldCode() 
The assignment was previously truncating a u64 value to a bool.
 2020-09-17 15:04:17 -04:00
Lioncash 362e2940be audio_core/command_generator: Use const references where applicable 
In a lot of cases, we can make use of const references rather than
non-const references.

While we're in the area we can silence some truncation and sign
conversion warnings.
 2020-09-17 13:52:55 -04:00
Lioncash 9539e4d8fd audio_core/command_generator: Avoid an unnecessary copy in GenerateFinalMixCommand() 2020-09-17 13:45:24 -04:00
Lioncash aca3621146 nfp: Eliminate two unnecessary copies 
GetAmiiboBuffer() returns by const reference, so we can use a reference
instead of taking the returned buffer by value.
 2020-09-17 13:35:55 -04:00
Lioncash 1ee9ceb5af arm_dynarmic_cp15: Initialize member variables 
Ensures that the member variables are always initialized to a
deterministic value on creation.
 2020-09-17 13:03:49 -04:00
Lioncash 02b8b6677a control_metadata: Resolve typo in Portuguese language name 
This isn't used anywhere, so this is a trivial fix.
 2020-09-17 11:45:30 -04:00
Lioncash 8bbd82863d service: Remove unused funcation 
This is now completely unused, so it can be removed.
 2020-09-17 11:03:26 -04:00
Lioncash 057aa6275d service/sm: Slightly more efficient string name validation 
We can check the end of the string first for null-termination, rather
than the beginning of the string.
 2020-09-17 10:54:12 -04:00
Lioncash 78b1bc3b61 service/sm: Eliminate dependency on the global system instance 2020-09-17 10:43:54 -04:00
bunnei fcd0925ecf
Merge pull request #4653 from ReinUsesLisp/gc-warns 
gc_adapter: Disable MSVC nonstandard extension warning on libusb.h
 2020-09-16 22:33:58 -07:00
bunnei 1eae35621e
Merge pull request #4663 from ReinUsesLisp/wswitch 
video_core: Enforce -Werror=switch
 2020-09-16 20:43:23 -07:00
Lioncash a62c1999c5 file_sys/romfs_factory: Eliminate usage of the global system accessor 2020-09-16 19:15:19 -04:00
Lioncash 0e80567bef file_sys/bis_factory: Eliminate usage of the global system accessor 2020-09-16 18:16:04 -04:00
Lioncash aa8d6fc041 loader/nso: Remove unnecessary [[maybe_unused]] 2020-09-16 18:09:01 -04:00
ReinUsesLisp eb914b6c50 video_core: Enforce -Werror=switch 
This forces us to fix all -Wswitch warnings in video_core.
 2020-09-16 17:48:01 -03:00
Lioncash 113a3972a6 core/loader: Remove dependencies on the global system instance 
Now all that remains is:

18 instances in file_sys code
14 instances in GDB stub code (this can be tossed wholesale)
4 instances in HLE code
2 instances in settings code.
 2020-09-16 08:46:59 -04:00
Rodrigo Locatti 004bfefeb5
Merge pull request #4658 from lioncash/copy3 
nca_patch: Reduce stack usage size within SearchBucketEntry()
 2020-09-16 00:25:11 +00:00
Lioncash 66fc037ef2 nca_patch: Significantly reduce the stack usage size within SearchBucketEntry() 
Previously this function was using ~16KB of stack (16528 bytes), which
was caused by the function arguments being taken by value rather than by
reference.

We can make this significantly lighter on the stack by taking them by
reference.
 2020-09-15 09:10:58 -04:00
Lioncash 99b372a6c5 nca_patch: Make SearchBucketEntry() internally linked 
This is only used internally and doesn't depend on any class state, so
we can make it fully internal.
 2020-09-15 09:06:46 -04:00
Lioncash 3a8464cde2 cheat_engine: Convert ExtractName into a non-template function 
We don't need to create two separate instantiations of the same code, we
can simply make the character template argument a regular function
parameter.
 2020-09-15 03:24:44 -04:00
Lioncash ba7eb5abf4 cheat_engine: Remove unnecessary system argument to CheatParser's Parse function 
This isn't used within the function at all in any implementations, so we
can remove it entirely.
 2020-09-15 03:20:40 -04:00
Lioncash 33e4a0b6c1 patch_manager: Resolve implicit truncations in FormatTitleVersion() 
We make it explicit that we're truncating arithmetic here to resolve
compiler warnings (even if the sizes weren't u32/u64 arithmetic
generally promotes to int :<)
 2020-09-14 19:19:59 -04:00
Lioncash a4392c24cf patch_manager: Make use of type aliases 
We can use these to avoid typing the same type redundantly. This way, if
these ever change, only a single location needs to be modified.
 2020-09-14 19:17:50 -04:00
Lioncash 637ab14ae6 patch_manager: Make a few functions internally linked 
These functions are only used within this translation unit, so we can
make them internally linked.
 2020-09-14 19:04:51 -04:00
ReinUsesLisp bc8ace9917 gc_adapter: Disable MSVC nonstandard extension warning on libusb.h 
Pragma disable zero-sized array nonstandard extension warning on MSVC.
 2020-09-14 19:38:08 -03:00
Lioncash e0dd440b1f crypto/key_manager: Remove dependency on the global system accessor 
We can supply the content provider as an argument instead of hardcoding
a global accessor in the implementation.
 2020-09-14 16:49:59 -04:00
Lioncash ec2a6e5ba8 kernel: Remove all dependencies on the global system instance 
With this, the kernel finally doesn't depend directly on the global
system instance anymore.
 2020-09-14 14:03:13 -04:00
bunnei 042567e4b2
Merge pull request #4636 from lioncash/kernel-hle 
service: Remove two usages of the global system accessor
 2020-09-14 09:17:10 -07:00
bunnei 5fc6bf96d8
Merge pull request #4323 from ReinUsesLisp/no-spin 
kernel/scheduler: Use std::mutex instead of spin lock
 2020-09-11 23:23:53 -07:00
bunnei ec634b6a88
Merge pull request #4634 from lioncash/blocking 
bsd: Resolve a few warnings
 2020-09-11 15:17:34 -07:00
bunnei 324029d4f9
Merge pull request #4310 from ogniK5377/apollo-1-prod 
audio_core: Apollo Part 1, AudioRenderer refactor
 2020-09-11 10:57:27 -04:00
bunnei 03179ecafe
Merge pull request #4597 from Morph1984/mjolnir-p2 
Project Mjölnir: Part 2 - Controller Applet
 2020-09-10 19:28:23 -04:00
bunnei 41b8ecdeb6
Merge pull request #4608 from lioncash/sign3 
configure_input_player: Resolve sign conversion warnings in UpdateMappingWithDefaults()
 2020-09-10 13:56:16 -04:00
FearlessTobi 57162e1df3 Test: Decrease pad_update_ns 
There have been reports of quite heavy input lag in the past.
Compared to Citra for example, our pad_update_ns value is very high.
So let's decrease it and see if it helps with this problem.
 2020-09-10 16:38:53 +02:00
Rodrigo Locatti 663ea382da
Merge pull request #4633 from ReinUsesLisp/gpu-init 
video_core: Remove all Core::System references in renderer
 2020-09-10 02:28:54 +00:00
Lioncash ffdf8c0cb3 service: Remove two usages of the global system accessor 
Removes more instances of reliance on global state.
 2020-09-07 03:18:45 -04:00
Lioncash c715fc4c5e gc_adapter: Make DeviceConnected() a const member function 
This doesn't modify instance state, so it can be made const.
 2020-09-07 02:49:13 -04:00
Lioncash 40968e3993 bsd: Resolve unused value within SendToImpl 
Previously the address provided to SendToImpl would never be propagated
to SendTo(). This fixes that.
 2020-09-07 01:06:30 -04:00
Lioncash cd643ab5c9 bsd: Resolve sign comparison warnings 2020-09-07 01:06:27 -04:00
Lioncash 180fa6859f sockets_translate: Make use of designated initializers 
Same behavior, less typing.
 2020-09-07 00:53:10 -04:00
Lioncash 188a3cf74c blocking_worker: Make use of templated lambda 
We can simplify this a little by explicitly specifying the typename for
the lambda function.
 2020-09-07 00:47:46 -04:00
Lioncash 9652973db2 blocking_worker: Resolve -Wdocumentation warning 2020-09-07 00:45:53 -04:00
bunnei 841b295ad0
Merge pull request #4606 from lioncash/constexpr 
game_list_p: Mark some constants as constexpr
 2020-09-06 23:19:38 -04:00
ReinUsesLisp 9e87193725 video_core: Remove all Core::System references in renderer 
Now that the GPU is initialized when video backends are initialized,
it's no longer needed to query components once the game is running: it
can be done when yuzu is booting.

This allows us to pass components between constructors and in the
process remove all Core::System references in the video backend.
 2020-09-06 05:28:48 -03:00
bunnei e126021ffe
Merge pull request #4397 from ReinUsesLisp/bsd 
services: Implement most of bsd:s and GetCurrentIpAddress from nifm
 2020-09-05 22:40:59 -04:00
Morph 5b6268d26a configure_input: Hook up the motion button and checkbox 
This allows toggling motion on or off, and allows access to the motion configuration.
Also changes the [waiting] text for motion buttons to Shake! as this is how motion is connected to a player.
 2020-09-05 09:46:34 -04:00
german 797564599f Minor cleanup 2020-09-05 09:42:21 -04:00
german 6ee8eab670 Add cemu hook changes related to PR #4609 2020-09-04 21:48:13 -05:00
german 0774b17846 Remove RealMotionDevice 2020-09-04 21:48:13 -05:00
Morph 8e18b61972 configure_input_player: Show/hide motion buttons based on the controller 2020-09-04 21:48:13 -05:00
Morph df3cbd4758 controllers/npad: Simplify motion entry assignment 
Simplifies the motion assignment in the Dual Joycon entry and assigns index 1 of the motion entry (Motion 2) for the right joycon.
 2020-09-04 21:48:13 -05:00
german ff679f3d17 Include HID and configuration changes related to motion 2020-09-04 21:48:03 -05:00
Morph 0e33b19ae0 hid: Implement MergeSingleJoyasDualJoy 
- Used in multiple games such as Super Mario Odyssey.
 2020-09-04 15:38:33 -04:00
Morph b65456b958 applets/controller: Resolve several compiler warnings 
Resolves -Wsign-compare and -Wunused-variable
 2020-09-04 12:23:26 -04:00
Morph 076e4d44c3 Address feedback 2020-09-04 12:23:25 -04:00
Morph 1ec71b6ea0 clang-format 2020-09-04 12:23:25 -04:00
Morph f95ea04995 applets/controller: Set min_players to have a minimum value of 1. 
- Some games like Shipped have a minimum requirement of 0 connected players and is undesired behavior. We must require a minimum of 1 player connected regardless of what games may ask.
 2020-09-04 12:23:25 -04:00
Morph 371226448a applets/controller: Modify heuristic to account for certain games 
Now left and right joycons have the same priority (meaning both needs to be supported by the game).

Explanation of the new heuristic:
Assign left joycons to even player indices and right joycons to odd player indices.
We do this since Captain Toad Treasure Tracker expects a left joycon for Player 1 and a right Joycon for Player 2 in 2 Player Assist mode.
 2020-09-04 12:23:25 -04:00
Morph 6597b3817c main: Apply settings after applet configuration is complete. 2020-09-04 12:23:25 -04:00
Morph 7299356f37 applets/controller: Implement fallback applet for the SDL frontend 
Implement the fallback applet for the SDL frontend, connecting only the minimum amount of players required.
 2020-09-04 12:23:25 -04:00
Morph 72b2f5d34f applets/controller: Load configuration prior to setting up connections 
This avoids unintentionally changing the states of elements while loading them in.
 2020-09-04 12:23:25 -04:00
Morph aeec0f8a38 applets/controller: Make 8 a static constexpr value of NUM_PLAYERS 
Avoids repetitive usages of the int literal '8' or calls to player_widgets.size()
 2020-09-04 12:23:25 -04:00
Morph 5ce3015945 applets/controller: Implement "Explain Text" 
"Explain Text" is additional text that is shown for each player in the controller applet.
 2020-09-04 12:23:25 -04:00
Morph 5219615418 Project Mjölnir: Part 2 - Controller Applet 
Co-authored-by: Its-Rei <kupfel@gmail.com>
 2020-09-04 12:23:25 -04:00
bunnei 94a25b75a0
Merge pull request #4611 from lioncash/xbyak2 
externals: Update Xbyak to 5.96
 2020-09-03 20:24:27 -04:00
bunnei 3b0fe38e86
Merge pull request #4583 from lioncash/trunc 
gc_poller: Resolve compilation warnings on MSVC
 2020-09-03 20:23:33 -04:00
bunnei 40c230e0fa
Merge pull request #4578 from lioncash/xor 
common_funcs: Add missing XOR operators to DECLARE_ENUM_FLAG_OPERATORS
 2020-09-03 17:11:51 -04:00
bunnei ba5419b965
Merge pull request #4590 from ReinUsesLisp/tsan-sched 
hle/scheduler: Fix data race in is_context_switch_pending
 2020-09-03 14:39:57 -04:00
bunnei 39319f09d8
Merge pull request #4575 from lioncash/async 
async_shaders: Mark getters as const member functions
 2020-09-03 11:34:30 -04:00
ReinUsesLisp 827ff077e7 file_sys/patch_manager: Add missing include 
Fixes build issues
 2020-09-03 04:51:49 -03:00
bunnei 38980b2471
Merge pull request #4568 from lioncash/fsp 
fsp_srv: Resolve -Wmaybe_uninitialized warning in OpenSaveDataFileSystem()
 2020-09-02 23:07:03 -04:00
bunnei 57e43682ed
Merge pull request #4564 from lioncash/file-include 
file_sys: Replace inclusions with forward declarations where applicable
 2020-09-02 23:06:38 -04:00
lat9nq 0914e84014 main: Use three dots to complete the ellipsis 
Fixes a typo in the UI file. An ellipsis has 3 dots.
 2020-09-02 15:23:15 -04:00
Morph 45ecd601be input_common/motion_input: Make use of Common::PI constant 
Also amend the copyright notice to yuzu's instead of Dolphin's, which was mistakenly copy-pasted from another file.
 2020-09-02 11:58:15 -04:00
bunnei f64917a852
Merge pull request #4570 from german77/motionInput 
input_common: Add a basic class for motion devices
 2020-09-02 11:09:18 -04:00
bunnei 3dcccabd1d
Merge pull request #4382 from FearlessTobi/port-udp-config 
yuzu: Add motion and touch configuration from Citra
 2020-09-01 13:56:37 -04:00
bunnei ad9ce67b52
Merge pull request #4588 from ReinUsesLisp/tsan-event 
common/thread: Fix data race in is_set
 2020-08-31 21:21:38 -04:00
bunnei a1f13a3662
Merge pull request #4589 from ReinUsesLisp/tsan-host 
hle/kernel: Fix data race in GetCurrentHostThreadID
 2020-08-31 21:20:49 -04:00
LC b5ed2d408c
Merge pull request #4461 from comex/thread-names 
Fix thread naming on Linux, which limits names to 15 bytes.
 2020-08-31 15:31:48 -04:00
ReinUsesLisp c573920c01 vk_device: Fix driver id check on AMD for VK_EXT_extended_dynamic_state 
'driver_id' can only be known on Vulkan 1.1 after creating a logical
device. Move the driver id check to disable
VK_EXT_extended_dynamic_state after the logical device is successfully
initialized.

The Vulkan device will have the extension enabled but it will not be
used.
 2020-08-30 20:22:48 -03:00
Lioncash a5dcccfdd2 externals: Update Xbyak to 5.96 
I made a request on the Xbyak issue tracker to allow some constructors
to be constexpr in order to avoid static constructors from needing to
execute for some of our register constants.

This request was implemented, so this updates Xbyak so that we can make
use of it.
 2020-08-30 05:09:48 -04:00
bunnei e9b9fc4674
Merge pull request #4601 from lioncash/const3 
sdl_impl: Minor cleanup
 2020-08-29 23:23:41 -04:00
bunnei 37faf24c3f
Merge pull request #4605 from lioncash/copy3 
bootmanager: Prevent unnecessary copies in TouchUpdateEvent()
 2020-08-29 23:22:39 -04:00
Vitor Kiguchi e6f9fe1f60 sdl_joystick: disable the use of the hidapi drivers due to many problems caused by them. 
The main problem is the loss of compatibility with some controllers, but there are also
unwanted changes to the behaviour of PS4 controllers (hardcoded lightbar color).
 2020-08-30 05:06:49 +02:00
FearlessTobi d1e1ea0fef Address second batch of reviews 2020-08-30 00:43:25 +02:00
Lioncash 92c162126b configure_input_player: Resolve sign conversion warnings in UpdateMappingWithDefaults() 
Prevents sign mismatch warnings in the loop conditionals.
 2020-08-29 16:43:12 -04:00
FearlessTobi 0aa6ec4276 Reolve reorder warning 2020-08-29 22:06:47 +02:00
FearlessTobi d176feffad Address review comments and fix code compilation 2020-08-29 20:56:51 +02:00
Lioncash 1aba91e993 bootmanager: Prevent unnecessary copies in TouchUpdateEvent() 
The list of points is returned by const reference, so we don't need to
make a copy of every element in the list.
 2020-08-29 14:33:10 -04:00
Lioncash fae65d8a72 game_list_p: Avoid string churn in GameListItemPath data() 2020-08-29 14:30:49 -04:00
Lioncash cde658cb27 game_list_p: Mark some constants as constexpr 
Consistency change with how we mark constants in the rest of the
codebase.
 2020-08-29 14:23:41 -04:00
FearlessTobi e6bd1fd1b8 yuzu: Add motion and touch configuration 2020-08-29 18:56:34 +02:00
LC ce43139eb7
Merge pull request #4604 from lioncash/lifetime 
yuzu/main: Amend lifetime issues with InputSubsystem
 2020-08-29 01:33:29 -04:00
Lioncash bcd3c79eca yuzu/main: Amend lifetime issues with InputSubsystem 
Due to the way Qt performs destruction of parent/child widgets, we need
to make the lifetime of the input subsystem shared across the main
window and the render window.
 2020-08-29 00:58:11 -04:00
Morph 403e36fab2 yuzu/configuration: Fix index out of bounds for default_analogs 2020-08-29 00:24:47 -04:00
Lioncash 69fa6b4906 sdl_impl: Reduce allocations in GetButtonMappingForDevice() 
These maps can be constexpr arrays of std::pair.
 2020-08-28 21:24:17 -04:00
Lioncash f2a680ca89 sdl_impl: Make use of std::move on std::string where applicable 
Avoids redundant copies.
 2020-08-28 21:14:54 -04:00
Lioncash e92164e6a0 sdl_impl: Make use of insert_or_assign() where applicable 
Avoids churning ParamPackage instances.
 2020-08-28 21:13:26 -04:00
Lioncash f3ac088345 sdl_impl: Prevent type truncation in BuildAnalogParamPackageForButton() default arguments 
We need to add the 'f' suffix to make the right hand side a float and
not a double.
 2020-08-28 21:08:08 -04:00
Lioncash 2e2dde2f95 sdl_impl: Simplify make_tuple call 
The purpose of make_tuple is that you don't need to explicitly type out
the types of the things that comprise said tuple.

Given this just returns default values, we can simplify this a bit.
 2020-08-28 21:04:18 -04:00
Lioncash 2680526e6b sdl_impl: Mark FromEvent() as a const member function 
This doesn't modify internal member state, so it can be marked as const.
 2020-08-28 20:58:49 -04:00
LC 57d9ef5a89
Merge pull request #4600 from lioncash/prototype 
input_common/main: Remove unimplemented prototype
 2020-08-28 20:10:33 -04:00
Lioncash 98f5d8a713 input_common/main: Remove unnecessary headers 2020-08-28 19:23:19 -04:00
Lioncash 4b9b203c09 input_common/main: Remove unimplemented prototype 
I forgot to remove this in the rebase when removing most of the global
variables within the input common codebase.
 2020-08-28 19:11:17 -04:00
ReinUsesLisp fe90c4fd7b vk_device: Blacklist AMD proprietary from VK_EXT_extended_dynamic_state 
Vertex binding's <stride> is bugged on AMD's proprietary drivers when
using VK_EXT_extended_dynamic_state. Blacklist it for now while we
investigate how to report this issue to AMD.
 2020-08-28 19:14:57 -03:00
bunnei 45b73ba840
Merge pull request #4544 from lioncash/input-sub 
input_common: Eliminate most global state
 2020-08-28 09:57:50 -04:00
bunnei 40320a1d84
Merge pull request #4586 from yuzu-emu/tsan-cpu-interrupt 
cpu_interrupt_handler: Make is_interrupted an atomic
 2020-08-28 09:21:47 -04:00
german 1be18dc110 Fix orientation errors and improve drift correction 2020-08-27 17:19:21 -05:00
german e6fc3b5662 Address comments 2020-08-27 17:19:21 -05:00
german 2d207ec609 Implement a basic class for motion devices 2020-08-27 17:19:21 -05:00
Lioncash 9e1b0af259 input_common: Eliminate most global state 
Abstracts most of the input mechanisms under an InputSubsystem class
that is managed by the frontends, eliminating any static constructors
and destructors. This gets rid of global accessor functions and also
allows the frontends to have a more fine-grained control over the
lifecycle of the input subsystem.

This also makes it explicit which interfaces rely on the input subsystem
instead of making it opaque in the interface functions. All that remains
to migrate over is the factories, which can be done in a separate
change.
 2020-08-27 16:11:17 -04:00
bunnei 3db9a25977
Merge pull request #4530 from Morph1984/mjolnir-p1 
Project Mjölnir: Part 1 - Input Rewrite
 2020-08-27 14:58:44 -04:00
bunnei 3f7b0e0772
Merge pull request #4577 from lioncash/asserts 
common/assert: Make use of C++ attribute syntax
 2020-08-27 11:09:02 -04:00
bunnei 9864da7d43
Merge pull request #4524 from lioncash/memory-log 
shader/memory: Amend UNIMPLEMENTED_IF_MSG without a message
 2020-08-27 00:16:10 -04:00
bunnei 1bb8c27a70
Merge pull request #4569 from ReinUsesLisp/glsl-cmake 
video_core/host_shaders: Add CMake integration for string shaders
 2020-08-26 22:57:39 -04:00
Morph 8ffc491546 input_common/main: Add "/Mouse" to the display name 2020-08-26 22:41:51 -04:00
bunnei 1e2a92918b
Merge pull request #4555 from ReinUsesLisp/fix-primitive-topology 
vk_state_tracker: Fix primitive topology
 2020-08-26 22:19:52 -04:00
Lioncash 7b50c48df7 memory_manager: Make use of [[nodiscard]] in the interface 2020-08-26 20:15:03 -04:00
Lioncash d12d59f62a memory_manager: Make operator+ const qualified 
This doesn't modify member state, so it can be marked as const.
 2020-08-26 20:11:58 -04:00
Morph f5f30781ae configure_input_player: Fix modifier scale button mapping 2020-08-26 02:32:32 -04:00
Morph 1bd70d73c0 configuration/input: Add support for mouse button clicks 
Supports the Left, Right, Middle, Backward and Forward mouse buttons.
 2020-08-26 02:32:32 -04:00
Morph eb149ec696 controllers/npad: Fix inconsistencies with controller connection statuses 2020-08-26 02:32:32 -04:00
Morph 334ef2efdd controllers/npad: Fix LibNX controller connection statuses 
This allows homebrew applications to be able to properly detect connected controllers.
 2020-08-26 02:32:32 -04:00
Morph e7c174b426 controllers/npad: Fix LedPattern for P1-4 2020-08-26 02:32:32 -04:00
Morph de79897f04 input_common: Fix directional deadzone values 
The hardware tested value is 0.5 which translates to SHRT_MAX / 2
 2020-08-26 02:32:32 -04:00
Morph efa0b7a056 Address feedback 2020-08-26 02:32:32 -04:00
Morph f0fac0c7fb Project Mjölnir: Part 1 
Co-authored-by: James Rowe <jroweboy@gmail.com>
Co-authored-by: Its-Rei <kupfel@gmail.com>
 2020-08-26 02:32:32 -04:00
Lioncash f60d5aac3e gc_poller: Resolve compilation warnings on MSVC 
We just need to make our intentional implicit truncations explicit.
 2020-08-25 23:03:12 -04:00
ReinUsesLisp ccdd84a778 hle/scheduler: Fix data race in is_context_switch_pending 
As reported by tsan, SelectThreads could write to
is_context_switch_pending holding a mutex while SwitchToCurrent reads it
without holding any.

It is assumed that the author didn't want an atomic here, so the code is
reordered so that whenever is_context_switch_pending is read inside
SwitchToContext, the mutex is locked.
 2020-08-26 02:56:05 +00:00
ReinUsesLisp 36eade7f4c hle/kernel: Fix data race in GetCurrentHostThreadID 
As reported by tsan, host_thread_ids could be read while
any of the RegisterHostThread variants were called.

To fix this, lock the register mutex when yuzu is running in multicore
mode and GetCurrentHostThreadID is called.
 2020-08-26 02:52:50 +00:00
ReinUsesLisp f119ef798b common/thread: Fix data race in is_set 
As report by tsan, Event::Set can write is_set while WaitFor and friends
are reading from it. To address this issue, make is_set an atomic.
 2020-08-26 02:50:51 +00:00
ReinUsesLisp 56ac22f737 cpu_interrupt_handler: Misc style changes 2020-08-26 02:43:26 +00:00
ReinUsesLisp ea7bda25ba cpu_interrupt_handler: Make is_interrupted an atomic 
Fixes a race condition detected from tsan
 2020-08-26 02:43:15 +00:00
bunnei 902bf6d37d
Merge pull request #4574 from lioncash/const-fn 
memory_manager: Mark IsGranularRange() as a const member function
 2020-08-25 11:24:13 -04:00
bunnei dd828607e0
Merge pull request #4563 from lioncash/rcache 
registered_cache: Make use of designated initializers
 2020-08-25 10:07:33 -04:00
bunnei b798813eee
Merge pull request #4548 from lioncash/color 
common/color: Migrate code over to the Common namespace
 2020-08-25 10:07:13 -04:00
M&M 43ce33b6cc logging/settings: Increase maximum log size to 100 MB and add extended logging option 
The extended logging option is automatically disabled on boot but can be enabled afterwards, allowing the log file to go up to 1 GB during that session.
This commit also fixes a few errors that are present in the general debug menu.
 2020-08-24 21:39:56 -07:00
bunnei bb752df736
Merge pull request #4542 from ReinUsesLisp/gpu-init-base 
video_core: Initialize renderer with a GPU
 2020-08-24 22:56:11 -04:00
bunnei 6fd3a1bf85
Merge pull request #4562 from lioncash/loop 
cpu_manager: Make use of ranged for where applicable
 2020-08-24 17:58:41 -04:00
Lioncash 504175e5b6 common_funcs: Add missing XOR operators to DECLARE_ENUM_FLAG_OPERATORS 
Ensures that the full set of bitwise operators are available for types
that make use of this macro.
 2020-08-24 04:42:43 -04:00
Lioncash 3bfaabdbdd common/assert: Make use of C++ attribute syntax 
Normalizes the syntax used for attributes
 2020-08-24 04:15:10 -04:00
Lioncash bafef3d1c9 async_shaders: Mark getters as const member functions 
While we're at it, we can also mark them as nodiscard.
 2020-08-24 01:15:50 -04:00
Lioncash 5bce81c3d6 memory_manager: Mark IsGranularRange() as a const member function 
This doesn't modify internal member state, so it can be marked as const.
 2020-08-24 00:37:57 -04:00
Lioncash bae4e6c2f5 gl_texture_cache: Take std::string by reference in DecorateViewName() 
LabelGLObject takes a string_view, so we don't need to make copies of
the std::string.
 2020-08-23 23:36:33 -04:00
Lioncash f3bb52c0a9 video_core/fence_manager: Remove unnecessary includes 
Avoids pulling in unnecessary things that can cause rebuilds when they
aren't required.
 2020-08-23 21:44:50 -04:00
bunnei ab350b8975
Merge pull request #4561 from lioncash/key-constexpr 
key_manager: Make data arrays constexpr
 2020-08-23 20:41:05 -04:00
ReinUsesLisp 91df2beee3 video_core/host_shaders: Add CMake integration for string shaders 
Add the necessary CMake code to copy the contents in a string source
shader (GLSL or GLASM) to a header file then consumed by video_core
files.

This allows editting GLSL in its own files without having to maintain
them in source files.

For now, only OpenGL presentation shaders are moved, but we can add
GLASM presentation shaders and static SPIR-V generation through
glslangValidator in the future.
 2020-08-23 21:37:20 -03:00
ReinUsesLisp 0eaf7e1daa gl_shader_util: Use std::string_view instead of star pointer 
This allows us passing any type of string and hinting the length of the
string to the OpenGL driver.
 2020-08-23 21:23:54 -03:00
bunnei 42a00877a2
Merge pull request #4549 from lioncash/files 
vfs_real: Avoid redundant map lookups
 2020-08-23 19:08:36 -04:00
bunnei 9619964e8c
Merge pull request #4559 from lioncash/webresult 
web_service: Move web_result.h into web_service
 2020-08-23 17:54:43 -04:00
Lioncash 4c1a95ed61 fsp_srv: Resolve -Wunused-but-set-variable warning 
We can just log out the parameters in the meantime.
 2020-08-23 17:16:32 -04:00
Lioncash 01d1b5cdaf file_sys: Replace inclusions with forward declarations where applicable 
Same behavior, minus unnecessary inclusions where not necessary.
 2020-08-23 17:02:55 -04:00
Lioncash 85db5f4091 fsp_srv: Resolve -Wmaybe_uninitialized warning in OpenSaveDataFileSystem() 
Initialize id to a deterministic value and also mark the unreachable
cases in the switch with UNREACHABLE().
 2020-08-23 16:37:57 -04:00
Lioncash 67a8e73101 registered_cache: Make use of ends_with for string suffix checking 
Simplifies code.
 2020-08-23 11:25:45 -04:00
Lioncash f83c6e1e0c registered_cache: Make use of designated initializers 
Removes the need for comments to indicate the fields being assigned.
 2020-08-23 10:26:20 -04:00
bunnei cfb7fd395c
Merge pull request #4560 from lioncash/convert 
core_timing: Resolve sign conversion warning
 2020-08-23 02:11:14 -04:00
Lioncash b62a8ca43e key_manager: Make data arrays constexpr 
We can convert these maps into constexpr arrays to eliminate some
runtime static constructors.
 2020-08-22 22:47:24 -04:00
Lioncash 544fbd5c84 cpu_manager: Make use of ranged for where applicable 
We can simplify a few loops by making use of ranged for.
 2020-08-22 22:43:19 -04:00
Lioncash 79504f1a39 core_timing: Remove unused header 2020-08-22 22:12:37 -04:00
Lioncash 25cd5d9dda core_timing: Move clock initializer into constructor initializer list 
Same behavior, minus unnecessary zeroing out of the pointer.
 2020-08-22 20:26:48 -04:00
Lioncash 2624b1eae6 core_timing: Resolve sign conversion warning 
This constant is only ever assigned to downcount, which is a s64, not a
u64.
 2020-08-22 20:26:45 -04:00
Lioncash ca5ed50655 web_service: Move web_result.h into web_service 
This is the only place it's actively used. It's also more appropriate
for web-related structures to be within the web service target.
Especially given this one doesn't rely on anything in the common
library.
 2020-08-22 19:29:54 -04:00
ReinUsesLisp da53bcee60 video_core: Initialize renderer with a GPU 
Add an extra step in GPU initialization to be able to initialize render
backends with a valid GPU instance.
 2020-08-22 01:51:45 -03:00
bunnei baff9ffcac
Merge pull request #4521 from lioncash/optionalcache 
gl_shader_disk_cache: Make use of std::nullopt where applicable
 2020-08-21 23:56:55 -04:00
bunnei 66ac7cf730
Merge pull request #4541 from MerryMage/yolo 
dynarmic: Add unsafe optimizations
 2020-08-21 23:06:21 -04:00
bunnei 53fbf8e206
Merge pull request #4523 from lioncash/self-assign 
macro-interpreter: Resolve -Wself-assign-field warning
 2020-08-21 18:25:53 -04:00
ReinUsesLisp aed6011d7c vk_state_tracker: Fix primitive topology 
State track the current primitive topology with a regular comparison
instead of using dirty flags.

This fixes a bug in dirty flags for this particular state and it also
avoids unnecessary state changes as this property is stored in a
frequently changed bit field.
 2020-08-20 23:07:30 -03:00
ReinUsesLisp c5a78f4480 vk_device: Use Vulkan 1.0 properly 
Enable the required capabilities to use Vulkan 1.0 without validation
errors and disable those that are not compatible with it.
 2020-08-20 16:55:22 -03:00
ReinUsesLisp 29a0ca2391 renderer_vulkan: Create a Vulkan 1.0 instance when 1.1 is not available 
This commit doesn't make yuzu compatible with Vulkan 1.0 yet, it only
creates an 1.0 instance.
 2020-08-20 16:55:22 -03:00
bunnei 3ea3de4ecd
Merge pull request #4546 from lioncash/telemetry 
common/telemetry: Migrate namespace into the Common namespace
 2020-08-20 14:29:13 -04:00
bunnei 3b8a8cf825
Merge pull request #4547 from lioncash/header-concept 
common/concepts: Move <type_traits> include out of the Common namespace
 2020-08-19 23:29:45 -04:00
bunnei acbae572d3
Revert "common/time_zone: Simplify GetOsTimeZoneOffset()" 2020-08-19 18:27:31 -04:00
bunnei b1fa647f28
Merge pull request #4539 from lioncash/disc 
common: Silence two discarded result warnings
 2020-08-18 22:03:09 -04:00
bunnei 2d2e235bcf
Merge pull request #4522 from lioncash/vulk-copy 
vulkan/wrapper: Avoid unnecessary copy in EnumerateInstanceExtensionProperties()
 2020-08-18 19:31:35 -04:00
Lioncash f6bb905182 common/telemetry: Migrate namespace into the Common namespace 
Migrates the Telemetry namespace into the Common namespace to make the
code consistent with the rest of our common code.
 2020-08-18 15:08:32 -04:00
Lioncash 551882e512 vfs_real: Resolve sign conversion warnings 2020-08-18 14:58:33 -04:00
Lioncash ed9ae5a977 vfs_real: Avoid redundant map lookups 
Avoids some trivially avoidable map lookups by keeping the result of
find operations around and querying them.
 2020-08-18 14:58:29 -04:00
Lioncash e864aa25d5 common/color: Migrate code over to the Common namespace 
No external code makes use of this header, so we can freely change the
namespace.
 2020-08-18 14:27:41 -04:00
Lioncash 999fc2fece common/concepts: Move <type_traits> include out of the Common namespace 
This is a compiler/linker error waiting to happen.
 2020-08-18 14:24:54 -04:00
bunnei bea9ed2548
Merge pull request #4381 from Morph1984/fix-open-folder-installed-title 
main: Fix Open Save/Mod Locations for installed titles
 2020-08-18 12:54:06 -04:00
bunnei 00573fb2c9
Merge pull request #4532 from lioncash/object-name 
configuration_shared: Simplify name lookup in highlighting functions
 2020-08-18 00:45:02 -04:00
bunnei 56c6a5def8
Merge pull request #4535 from lioncash/fileutil 
common/fileutil: Convert namespace to Common::FS
 2020-08-17 22:35:30 -04:00
bunnei 0c885249df
Merge pull request #4537 from lioncash/tz 
common/time_zone: Simplify GetOsTimeZoneOffset()
 2020-08-17 14:27:02 -04:00
bunnei 3472c00b3b
Merge pull request #4540 from lioncash/tr3 
configure_hotkeys: Don't translate empty strings
 2020-08-17 12:24:58 -04:00
bunnei 0530dd6ea1
Merge pull request #4494 from lioncash/transcode 
aes_util: Make use of non-template variant of Transcode
 2020-08-17 03:50:35 -04:00
Rodrigo Locatti d8a90e6536
Merge pull request #4531 from lioncash/overload 
yuzu: Make use of qOverload where applicable
 2020-08-17 04:13:14 -03:00
David cbaf1bc711
Merge pull request #4443 from ameerj/vk-async-shaders 
vulkan_renderer: Async shader/graphics pipeline compilation
 2020-08-17 15:06:11 +10:00
bunnei bbb5623f52
Merge pull request #4515 from lat9nq/pgs-menubar-config 
main: Add an option to modify the currrent game's configuration
 2020-08-17 01:03:39 -04:00
David a91acd5365
Merge pull request #4520 from lioncash/pessimize 
async_shaders: Resolve -Wpessimizing-move warning
 2020-08-17 14:36:05 +10:00
ameerj fde8102a41 Remove unneeded newlines, optional Registry in shader params 
Addressing feedback from Rodrigo
 2020-08-16 16:33:21 -04:00
Ameer J f49ffdd648 Morph: Update worker allocation comment 
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
 2020-08-16 12:02:22 -04:00
ameerj 1b829fbd7a move thread 1/4 count computation into allocate workers method 2020-08-16 12:02:22 -04:00
ameerj 31a76410e8 Address feedback, add shader compile notifier, update setting text 2020-08-16 12:02:22 -04:00
ameerj c02464f64e Vk Async Worker directly emplace in cache 2020-08-16 12:02:22 -04:00
ameerj 4539073ce1 Address feedback. Bruteforce delete duplicates 2020-08-16 12:02:22 -04:00
ameerj 6ac97405df Vk Async pipeline compilation 2020-08-16 12:02:22 -04:00
David Marcec 80ac1331b5 Preliminary effects 2020-08-17 01:23:55 +10:00
MerryMage 836ec9176a dynarmic: Add unsafe optimizations 2020-08-16 14:15:39 +01:00
Lioncash e23289d869 configure_hotkeys: Don't translate empty strings 
There's no need to translate an empty string. This just gives
translators unnecessary work.
 2020-08-16 08:13:25 -04:00
Lioncash c4ed791164 common/fileutil: Convert namespace to Common::FS 
Migrates a remaining common file over to the Common namespace, making it
consistent with the rest of common files.

This also allows for high-traffic FS related code to alias the
filesystem function namespace as

namespace FS = Common::FS;

for more concise typing.
 2020-08-16 06:52:40 -04:00
Lioncash d09456fc41 common: Silence two discarded result warnings 
These are intentionally discarded internally, since the rest of the
public API allows querying success. We want all non-internal uses of
these functions to be explicitly checked, so we can signify that we
intentionally want to discard the return values here.
 2020-08-16 06:17:33 -04:00
Lioncash fe97d34156 common/time_zone: Simplify GetOsTimeZoneOffset() 
We can simplify this function down into a single line with the use of
fmt. A benefit with the fmt approach is that the fmt variant of
localtime is thread-safe as well, making GetOsTimeZoneOffset()
thread-safe as well.
 2020-08-16 03:58:47 -04:00
Lioncash dbb1cbce67 yuzu: Resolve -Wextra-semi warnings 
While we're in the same area, we can ensure GameDir member variables are
always initialized to consistent values.
 2020-08-16 03:58:29 -04:00
bunnei db96034ea4
Merge pull request #4528 from lioncash/discard 
common: Make use of [[nodiscard]] where applicable
 2020-08-16 01:47:54 -04:00
bunnei 404362e1b0
Merge pull request #4519 from lioncash/semi 
maxwell_3d: Resolve -Wextra-semi warning
 2020-08-16 00:55:15 -04:00
lat9nq 9f972b7d01 main: Add an option to modify the currrent game's configuration 
Creates a new entry in the Emulation menu called "Configure Current Game..." that is only available if a game is currently being executed in yuzu. When selected, it opens the game properties dialog for the current game.

Thanks to @BSoDGamingYT for reminding me to do this.
 2020-08-15 20:28:48 -04:00
Lioncash 1ee060ca0d common/compression: Roll back std::span changes 
Seems like all compilers don't support std::span yet.
 2020-08-15 17:17:56 -04:00
Lioncash df72480395 common: Make use of [[nodiscard]] where applicable 
Now that clang-format makes [[nodiscard]] attributes format sensibly, we
can apply them to several functions within the common library to allow
the compiler to complain about any misuses of the functions.
 2020-08-15 17:17:52 -04:00
bunnei 2b601e8636
Merge pull request #4526 from lioncash/core-semi 
core: Resolve several -Wextra-semi warnings
 2020-08-15 02:14:11 -04:00
bunnei e6f9231ef0
Merge pull request #4527 from lioncash/pessimizing2 
software_keyboard: Resolve a pessimizing move warning
 2020-08-15 02:13:44 -04:00
bunnei cb6808b4d0
Merge pull request #4492 from lioncash/linkage 
system_control: Make functions internally linked where applicable
 2020-08-15 02:11:49 -04:00
bunnei 2aabd1eb05
Merge pull request #4463 from lioncash/lockdiscard 
kernel/scheduler: Mark SchedulerLock constructor as nodiscard
 2020-08-15 01:31:23 -04:00
bunnei feb243b08d
Merge pull request #4416 from lioncash/span 
lz4_compression/zstd_compression: Make use of std::span in interfaces
 2020-08-15 00:53:11 -04:00
bunnei 2dace90346
Merge pull request #4453 from ReinUsesLisp/block-to-linear 
textures/decoders: Fix block linear to pitch copies
 2020-08-14 19:52:12 -04:00
Lioncash fe86109877 configuration_shared: Simplify name lookup in highlighting functions 
We can query the given object name directly from the widget itself. This
removes any potential for forgetting to change the name if the widget
gets renamed and makes the API much simpler (just pass in the widget,
and not worry about its name).
 2020-08-14 14:17:02 -04:00
Lioncash 969a4cc4da yuzu: Make use of qOverload where applicable 
Eliminates a verbose function cast.
 2020-08-14 14:12:55 -04:00
Lioncash b14277ef97 time_zone_content_manager: Collapse auto and default case 
Prevents a useless self-assignment from occurring.
 2020-08-14 10:58:58 -04:00
David Marcec 1f1c3bddc0 Disable biquad filter 2020-08-14 23:20:20 +10:00
Lioncash 03d5a5d9de software_keyboard: Resolve a pessimizing move warning 
A std::vector created in place like this is already an rvalue and
doesn't need to be moved.
 2020-08-14 09:14:54 -04:00
Lioncash 2296e921d2 core: Resolve several -Wextra-semi warnings 
We can amend one of the cascade macros to require semicolons in order to
compile. In other cases, we can just remove the superfluous semicolons.
 2020-08-14 09:09:20 -04:00
Lioncash dcc5562cd5 shader/memory: Amend UNIMPLEMENTED_IF_MSG without a message 
We need to provide a message for this variant of the macro, so we can
simply log out the type being used.
 2020-08-14 08:38:37 -04:00
Lioncash 34ec64233a macro-interpreter: Resolve -Wself-assign-field warning 
This was assigning the field to itself, which is a no-op. The size
doesn't change between its initial assignment and this one, so this is a
safe change to make.
 2020-08-14 08:26:50 -04:00
Lioncash 167d36ec3c vulkan/wrapper: Avoid unnecessary copy in EnumerateInstanceExtensionProperties() 
Given this is implicitly creating a std::optional, we can move the
vector into it.
 2020-08-14 08:23:49 -04:00
Lioncash c8135b3c18 gl_shader_disk_cache: Make use of std::nullopt where applicable 
Allows the compiler to avoid unnecessarily zeroing out the internal
buffer of std::optional on some implementations.
 2020-08-14 08:20:44 -04:00
Lioncash 6b13d08822 async_shaders: Resolve -Wpessimizing-move warning 
Prevents pessimization of the move constructor (which thankfully didn't
actually happen in practice here, given std::thread isn't copyable).
 2020-08-14 08:16:50 -04:00
Lioncash 83d8bf9af9 maxwell_3d: Resolve -Wextra-semi warning 
Semicolons after a function definition aren't necessary.
 2020-08-14 08:13:41 -04:00
David Marcec 1b3d86c02f Reworked ADPCM decoder to allow better streaming 2020-08-14 21:04:28 +10:00
Lioncash a93f6e51d3 emu_window: Mark Scoped constructor and Acquire() as nodiscard 
Ensures that callers make use of the constructor, preventing bugs from
silently occurring.
 2020-08-14 04:43:44 -04:00
Lioncash f808258ed9 kernel/scheduler: Mark SchedulerLock constructor as nodiscard 
Allows the compiler to warn about cases where the constructor is used
but then immediately discarded, which is a potential cause of
locking/unlocking bugs.
 2020-08-14 04:43:44 -04:00
Rodrigo Locatti e050594706
Merge pull request #4495 from lioncash/conv 
cheat_engine: Resolve implicit bool->u64 conversion
 2020-08-14 03:10:17 -03:00
bunnei a9de967fa3
Merge pull request #4514 from Morph1984/worker-alloc 
gl_shader_cache: Use std::max() for determining num_workers
 2020-08-13 17:06:57 -04:00
LC ff0b14ee62
Merge pull request #4511 from lioncash/build2 
General: Tidy up clang-format warnings part 2
 2020-08-13 15:13:21 -04:00
Lioncash b724a4d90c General: Tidy up clang-format warnings part 2 2020-08-13 14:19:08 -04:00
Morph e0ff98dd34 gl_shader_cache: Use std::max() for determining num_workers 
Does not allocate more threads than available in the host system for boot-time shader compilation and always allocates at least 1 thread if hardware_concurrency() returns 0.
 2020-08-12 09:23:34 -04:00
bunnei a8ffe6eee4
Merge pull request #4497 from lioncash/freezer-alg 
freezer: Make use of std::erase_if
 2020-08-11 23:07:17 -04:00
bunnei e143adc3cf
Merge pull request #4493 from jbeich/dragonfly 
common/virtual_buffer: drop unused includes
 2020-08-11 12:52:50 -04:00
bunnei 4605e4d6ff
Merge pull request #4502 from lioncash/build 
General: Tidy up clang-format warnings
 2020-08-11 11:04:05 -04:00
ReinUsesLisp f00641459e textures/decoders: Fix block linear to pitch copies 
There were two issues with block linear copies. First the swizzling was
wrong and this commit reimplements them.

The other issue was that these copies are generally used to download
render targets from the GPU and yuzu was not downloading them from
host GPU memory unless the extreme GPU accuracy setting was selected.
This commit enables cached memory reads for all accuracy levels.

- Fixes level thumbnails in Super Mario Maker 2.
 2020-08-10 20:45:03 -03:00
bunnei 257b1d2c4b
Merge pull request #4496 from lioncash/ce-desig 
cheat_engine: Make use of designated initializers
 2020-08-10 13:53:43 -04:00
ameerj d6672501ac Remove UI changes 
This PR is now only the Analog devices handling the range value defaulting at 100%
 2020-08-10 12:46:14 -04:00
ameerj 9c6ae697f5 Add range slider functionality for gc adapter 2020-08-10 12:46:14 -04:00
Ameer 8928aa3008 undo unnecessary newlines, slider range 50-150 2020-08-10 12:46:14 -04:00
Ameer 504095cea9 Address c++20 warning, fix inaccurate range text display when slide == 0 2020-08-10 12:46:14 -04:00
Ameer ed51c2abda Add range slider for analog sticks 2020-08-10 12:46:14 -04:00
bunnei acfd771e79
Merge pull request #4491 from lioncash/unused-vars 
kernel: Remove unused variables
 2020-08-10 12:04:30 -04:00
bunnei 664019954a
Merge pull request #4488 from lioncash/file 
vfs_vector: Make creation of array vfs files less verbose
 2020-08-09 17:19:34 -04:00
Lioncash 1c3490a8db General: Tidy up clang-format warnings 2020-08-08 20:08:44 -04:00
bunnei f14bb61acd
Merge pull request #4448 from Morph1984/fix-entries 
game_list_worker: Do not clear entries when > 1 gamedir is present
 2020-08-07 17:11:52 -04:00
bunnei 929fc849e9
Merge pull request #4457 from ogniK5377/SetScreenShotPermission 
am: Unstub SetScreenShotPermission
 2020-08-07 09:34:20 -04:00
bunnei 5429ea0e69
Merge pull request #4389 from ogniK5377/redundant-format-type 
video_core: Remove redundant pixel format type
 2020-08-07 09:33:58 -04:00
Lioncash 8e86fa7e60 common/concepts: Rename IsBaseOf to DerivedFrom 
This makes it more inline with its currently unavailable standardized
analogue std::derived_from.

While we're at it, we can also make the template match the requirements
of the standardized variant as well.
 2020-08-07 08:09:57 -04:00
bunnei f5d538f118
Merge pull request #4483 from lioncash/constexpr-hex 
partition_data_manager: Make data arrays constexpr
 2020-08-06 23:14:14 -04:00
bunnei 5cc2f99fab
Merge pull request #4490 from lioncash/arbiter 
address_arbiter/scheduler: Resolve sign conversion warnings
 2020-08-06 22:28:11 -04:00
Lioncash 61cd7eb47d freezer: Move entry finding to its own function 
Cleans up the callsites in other functions.
 2020-08-06 03:11:21 -04:00
Lioncash 06ab28263b freezer: Take address values by value 
VAddr will always be 64-bit, so there's no need to take a trivial
primitive alias by reference.
 2020-08-06 03:04:54 -04:00
Lioncash 253a17451b freezer: Make use of std::erase_if 
With C++20 we can simplify the erasing idiom.
 2020-08-06 03:03:05 -04:00
Lioncash 5b89291308 cheat_engine: Resolve implicit bool->u64 conversion 
We can just return zero here.
 2020-08-06 02:55:47 -04:00
Lioncash df96a214ae cheat_engine: Make use of designated initializers 
Same behavior, but makes the member being assigned obvious.
 2020-08-06 02:48:13 -04:00
Lioncash 4f2acc54f5 partition_data_manager: Update master key hashes 
Fills in some hashes that were previously unhandled.
 2020-08-06 02:42:01 -04:00
Lioncash 7f0f37fca7 partition_data_manager: Make data arrays constexpr 
Previously the constructor for all of these would run at program
startup, consuming time before the application can enter main().

This is also particularly dangerous, given the logging system wouldn't
have been initialized properly yet, yet the program would use the logs
to signify an error.

To rectify this, we can replace the literals with constexpr functions
that perform the conversion at compile-time, completely eliminating the
runtime cost of initializing these arrays.
 2020-08-06 02:41:58 -04:00
Lioncash 04bb47f57f partition_data_manager: Eliminate magic value 
We can use sizeof to make it obvious at the call site where the value is
coming from.
 2020-08-06 02:34:10 -04:00
Lioncash 09f884b7bd aes_util: Make use of non-template variant of Transcode 
Same behavior, less template instantiations.
 2020-08-06 02:31:19 -04:00
comex d37f0b29e2 Fix thread naming on Linux, which limits names to 15 bytes. 
- In `SetCurrentThreadName`, when on Linux, truncate to 15 bytes, as (at
  least on glibc) `pthread_set_name_np` will otherwise return `ERANGE` and
  do nothing.
- Also, add logging in case `pthread_set_name_np` returns an error
  anyway.  This is Linux-specific, as the Apple and BSD versions of
  `pthread_set_name_np return `void`.
- Change the name for CPU threads in multi-core mode from
  "yuzu:CoreCPUThread_N" (19 bytes) to "yuzu:CPUCore_N" (14 bytes) so it
  fits into the Linux limit.  Some other thread names are also cut off,
  but I didn't bother addressing them as you can guess them from the
  truncated versions.  For a CPU thread, truncation means you can't see
  which core it is!
 2020-08-05 20:34:49 -07:00
bunnei 1cc0e4b4d8
Merge pull request #4489 from lioncash/typesafe 
ipc_helpers: Only allow trivially copyable objects with PushRaw() and PopRaw()
 2020-08-05 23:20:23 -04:00
bunnei 35c1607f23
Merge pull request #4484 from lioncash/aesutil 
aes_util: Allow SetIV() to be non-allocating
 2020-08-05 22:35:41 -04:00
bunnei d888ac7d20
Merge pull request #4477 from lioncash/log-desig 
logging/backend: Make use of designated initializers
 2020-08-05 22:34:12 -04:00
Jan Beich 238208ee30 common/virtual_buffer: drop unused includes 
On DragonFly and NetBSD build fails with

src/common/virtual_buffer.cpp
src/common/virtual_buffer.cpp:16:10: fatal error: sys/sysinfo.h: No such file or directory
 #include <sys/sysinfo.h>
          ^~~~~~~~~~~~~~~
 2020-08-05 21:36:35 +00:00
bunnei 61678c4e9f
Merge pull request #4475 from lioncash/bqueue 
buffer_queue: Make use of designated initializers/std::nullopt where applicable
 2020-08-05 16:56:46 -04:00
bunnei e8868c2ed1
Merge pull request #4479 from lioncash/concepts 
CMakeLists: Resolve #4478
 2020-08-05 16:18:08 -04:00
Lioncash 87c64c41d2 system_control: Make functions internally linked where applicable 
These functions are only ever used internally as implementation details
for GenerateRandomRange(), so these can be given internal linkage.
 2020-08-05 15:34:27 -04:00
Lioncash a10d64ea79 kernel: Remove unused variables 
Resolves a few compiler warnings.
 2020-08-05 15:19:48 -04:00
Lioncash 9893da8e2c scheduler: Resolve sign conversion warning 2020-08-05 15:12:29 -04:00
Lioncash 1a45b15a8c address_arbiter: Resolve sign conversion warning 
Makes our type conversion explicit.
 2020-08-05 15:07:19 -04:00
bunnei 4a2d9c6454
Merge pull request #4444 from lioncash/volatile 
common/atomic_ops: Don't cast away volatile from pointers
 2020-08-05 14:22:36 -04:00
Lioncash a77ee63f65 ipc_helpers: Only allow trivially copyable objects with PushRaw() and PopRaw() 
It's undefined behavior to use non-trivially copyable objects with
std::memcpy, so we can add asserts to catch usages of these at
compile-time.
 2020-08-05 14:08:28 -04:00
Lioncash 0a5456feb9 vfs_vector: Make creation of array vfs files less verbose 
We can add a helper function to make creation of these files nicer.
While we're at it, we can eliminate an unnecessary std::array copy in
the constructor. This makes the overhead on some of these functions way
less intensive, given some arrays were quite large.

e.g. The timezone location names are 9633 bytes in size.
 2020-08-05 12:37:00 -04:00
bunnei 07691f994a
Merge pull request #4466 from ogniK5377/loader-type-safe 
loader: Make IdentifyFile typesafe
 2020-08-05 12:34:25 -04:00
Morph cf946312ca main: Fallback to loader if no control nca is found with patch manager 
In some rare instances, the patch manager is not able to find a control nca, fallback to the previous method of parsing a control nca through the loader if this occurs.
 2020-08-04 21:14:20 -04:00
Morph 1146049de0 main: Fix Open Save/Mod Locations for installed titles 
Previously NAND/SDMC installed titles would open device saves when they are supposed to be user saves. This is due to the control nca not being read and thus returns 0 for both GetDefaultNormalSaveSize() and GetDeviceSaveDataSize(). Fix this by utilizing the patch manager to read the control nca.
 2020-08-04 21:14:20 -04:00
Morph 123024cea2 game_list_worker: Do not clear entries when > 1 gamedir is present 
Previously the map of entries was being cleared while looping through each game directory, this resulted into all game directories except the last game dir to lose content metadata information. Fix this by clearing the entries only once.
 2020-08-04 21:13:35 -04:00
bunnei 142930e609
Merge pull request #4476 from lioncash/tz 
time_zone_binary: Make use of designated initializers
 2020-08-04 18:56:28 -04:00
bunnei ba9ed7b1fe
Merge pull request #4401 from ogniK5377/GetIndirectLayerImageRequiredMemoryInfo 
vi: IApplicationDisplayService:GetIndirectLayerImageRequiredMemoryInfo
 2020-08-04 18:45:11 -04:00
bunnei f11628b9b7
Merge pull request #4430 from bunnei/new-gpu-vmm 
hle: nvdrv: Rewrite of GPU memory management.
 2020-08-04 18:44:26 -04:00
bunnei efd1b57d03
Merge pull request #4445 from Morph1984/async-threads 
renderer_opengl: Use 1/4 of all threads for async shader compilation
 2020-08-04 18:43:42 -04:00
bunnei c71d05de84
Merge pull request #4450 from Morph1984/fix-gamelist-scanning 
game_list_worker: Fix game list subdirectory scanning
 2020-08-04 18:43:17 -04:00
bunnei ecbee11829
Merge pull request #4472 from lioncash/const-get 
perf_stats: Mark GetMeanFrametime() as const
 2020-08-04 07:00:23 -07:00
bunnei 0ae267bf77
Merge pull request #4469 from lioncash/missing 
vk_texture_cache: Silence -Wmissing-field-initializer warnings
 2020-08-04 06:59:51 -07:00
David 741cbbdc0e
Merge pull request #4470 from lioncash/qualifier 
patch_manager: Resolve -Wignored-qualifier warnings
 2020-08-04 14:09:48 +10:00
David 723314b682
Merge pull request #4481 from lioncash/cpp-dep 
yuzu: Resolve C++20 deprecation warnings related to lambda captures
 2020-08-04 14:06:07 +10:00
David 25fb7cd16d
Merge pull request #4474 from lioncash/hle-profile 
profile_manager: Make use of designated initializers
 2020-08-04 13:51:15 +10:00
bunnei c6e5a36452
Merge pull request #4473 from lioncash/cheat-desig 
dmnt_cheat_vm: Make use of designated initializers
 2020-08-03 18:07:17 -07:00
bunnei 0dbb95c42d
Merge pull request #4456 from Morph1984/stub-really-long-fs-func 
fsp-srv: Stub Read/WriteSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute
 2020-08-03 18:06:48 -07:00
Lioncash 15660bd857 aes_util: Allow SetIV to be non-allocating 
In a few places, the data to be set as the IV is already within an array.
We shouldn't require this data to be heap-allocated if it doesn't need
to be. This allows certain callers to reduce heap churn.
 2020-08-03 14:29:58 -04:00
bunnei b2911421ec
Merge pull request #4480 from lioncash/optimize 
tests/core_timing: Remove pragma optimize(off)
 2020-08-03 11:27:52 -07:00
bunnei 9808f244cc
Merge pull request #4482 from lioncash/ldr-sign 
service/ldr: Resolve sign mismatch warnings
 2020-08-03 11:27:13 -07:00
bunnei a971667d1f
Merge pull request #4468 from lioncash/regcache 
registered_cache: Resolve -Wmaybe_uninitialized warnings
 2020-08-03 11:26:45 -07:00
bunnei 94c1689ef3
Merge pull request #4471 from ogniK5377/sm-getservice-concept 
sm: Make use of IsBaseOf for GetService
 2020-08-03 11:11:22 -07:00
Lioncash 570150bc86 perf_stats: Make use of designated initializers 
Same behavior, but allows us to avoid a now-unnecessary zero
initialization.
 2020-08-03 12:33:40 -04:00
Lioncash d767be65be perf_stats: Mark GetMeanFrametime() as const 
The general pattern is to mark mutexes as mutable when it comes to
matters of constness, given the mutex acts as a transient member of a
data structure.
 2020-08-03 12:33:35 -04:00
Lioncash 06809ad7bc vulkan: Silence more -Wmissing-field-initializer warnings 2020-08-03 12:28:57 -04:00
Lioncash b249e4e0ce yuzu: Resolve C++20 deprecation warnings related to lambda captures 
C++20 deprecates capturing the this pointer via the '=' capture.
Instead, we replace it or extend the capture specification.
 2020-08-03 11:54:04 -04:00
Lioncash f525da56e5 service/ldr: Resolve sign mismatch warnings 
We were performing an int < size_t comparison. We can just correct the
type of the induction variable.
 2020-08-03 11:48:16 -04:00
Lioncash dd2ff23621 CMakeLists: Resolve #4478 
This switch is enabled by default in all recent versions of GCC and
Clang.
 2020-08-03 11:21:24 -04:00
Lioncash e1ab72a0ea tests/core_timing: Remove pragma optimize(off) 
I made a review comment about this in the PR that this was introduced
in (#3955, commit 71c4779211), but it
seems to have been missed.

We shouldn't be using this pragma here because it's MSVC specific. This
causes warnings on other compilers.

The test it's surrounding is *extremely* dubious, but for the sake of
silencing warnings on other compilers, we can mark "placebo" as volatile
and be on with it.
 2020-08-03 11:12:55 -04:00
bunnei 3697fc8d14
Merge pull request #4467 from lioncash/mode 
file_sys/mode: Make use of DECLARE_ENUM_FLAG_OPERATORS with Mode
 2020-08-03 08:07:56 -07:00
Lioncash 04ca1ed2bd time_zone_binary: Make use of designated initializers 2020-08-03 10:42:38 -04:00
Lioncash 8725b37a35 logging/backend: Make use of designated initializers 
Same behavior, less code.
 2020-08-03 10:37:48 -04:00
Lioncash 9b837c6069 buffer_queue: Make use of std::nullopt 
Allows compilers to eliminate unnecessary zeroing out of the optional's
buffer.
 2020-08-03 09:31:51 -04:00
Lioncash 24bd068a08 buffer_queue: Make use of designated initializers 2020-08-03 09:31:51 -04:00
Lioncash b9831fd80a profile_manager: Make use of std::nullopt 
Allows some implementations to completely avoid unnecessarily zeroing
out the internal buffer.
 2020-08-03 09:03:42 -04:00
Lioncash 3fcaf937d2 profile_manager: Make use of designated initializers 
More compact code.
 2020-08-03 09:01:31 -04:00
Lioncash c883666045 dmnt_cheat_vm: Make use of designated initializers 
Allows for more compact code.
 2020-08-03 08:50:51 -04:00
Lioncash 2b8ae009a0 file_sys/mode: Make use of DECLARE_ENUM_FLAG_OPERATORS with Mode 
Same behavior, minus a hand-rolled operator.
 2020-08-03 07:52:36 -04:00
David Marcec 6a0b77996b sm: Make use of IsBaseOf for GetService 2020-08-03 21:46:14 +10:00
Lioncash 1c6d3ba397 patch_manager: Resolve -Wignored-qualifier warnings 
Top level const will always be ignored in this case, so it can be
removed.
 2020-08-03 07:42:56 -04:00
Lioncash 4ca0014479 registered_cache: Resolve -Wmaybe_uninitialized warnings 
While we're at it, we can avoid a redundant map lookup.
 2020-08-03 07:34:46 -04:00
David Marcec a5af1161c9 Place in anonymous namespace 2020-08-03 21:31:28 +10:00
David Marcec 6cfff2c3f6 loader: Make IdentifyFile typesafe 
Relies on #4465 for concept.h Common::IsBaseOf
 2020-08-03 21:31:27 +10:00
David 9b75481755
ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer (#4465) 
* ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer

With the support of C++20, we can use concepts to deduce if a type is an STL container or not.

* More agressive concept for stl containers

* Add -fconcepts

* Move to common namespace

* Add Common::IsBaseOf
 2020-08-03 07:28:54 -04:00
David 6c7292de33
Merge pull request #4263 from lat9nq/fix-screencaps-2 
screenshots: Option to save screenshots immediately in a specified directory + Linux workaround
 2020-08-03 21:00:14 +10:00
David 0ca42c806f
Merge pull request #4439 from lioncash/cpu 
cpu_manager: Remove redundant std::function declarations
 2020-08-03 20:58:31 +10:00
David 50d8264833
Merge pull request #4438 from lioncash/localizing 
yuzu/main: Remove redundant usages of QStringLiteral("")
 2020-08-03 20:58:00 +10:00
David Marcec 0947f613b1 mix buffer depopping 2020-08-01 16:25:08 +10:00
Morph fc86cb4ca2 minor nits 2020-07-31 11:02:59 -04:00
David Marcec e586921c28 am: Unstub SetScreenShotPermission 2020-08-01 00:44:14 +10:00
Morph 1241020093 fsp-srv: Stub Read/WriteSaveDataFileSystemExtraDataWithMaskBySaveDataAttribute 
Stub these 2 service commands required for Animal Crossing: New Horizons Update 1.4.0
 2020-07-30 15:39:44 -04:00
Morph 45fd67c109 fs: Rename SaveDataDescriptor to SaveDataAttribute 2020-07-30 15:29:39 -04:00
David 0c262f8ac2
Merge pull request #4392 from lioncash/guard 
compatible_formats: Add missing header guard
 2020-07-31 01:08:56 +10:00
David Marcec 1b8fe7073b adpcm streaming 2020-07-30 18:16:57 +10:00
bunnei 4c0f6f1bc8
Merge pull request #4396 from lioncash/comma 
surface_params: Replace questionable usages of the comma operator with semicolons
 2020-07-29 19:55:44 -04:00
Morph e0d02d032b game_list_worker: Fix game list subdirectory scanning 
Oddly enough the scan that feeds the manual content provider is hardcoded to scan 2 nested directories deep.
This effectively rendered the scan subdirectories setting useless as the manual content provider cannot find any games located more than 2 nested directories deep.
Furthermore, this behavior causes game files to be picked up by the manual content provider even if scan subdirectories is disabled.

FIx this by utilizing the behavior described when populating the game list for populating the content provider.
 2020-07-29 09:22:29 -04:00
Morph e59d17167d main: Add support for removing SDMC installed titles 2020-07-29 06:50:30 -04:00
Morph ed46f3c62a xts_archive: Check if the file is nullptr prior to parsing 
Fixes an access violation where the file no longer exists at the specified path while being parsed.
 2020-07-29 06:50:30 -04:00
Morph 2ec852dd9f registered_cache: Add support for removing folder ncas 2020-07-29 06:50:30 -04:00
Morph b317942131 game_list: Limit context menu options for homebrew 
Hides the following options when the title id is 0:
- Open Save Location
- Open Mod Data Location
- Open Transferable Shader Cache
- All removal options except Remove Custom Configuration
 2020-07-29 06:50:30 -04:00
Morph cd814bfdfe main: Remove assert for opening savedata when program_id = 0 2020-07-29 06:50:30 -04:00
Morph f78e44762a main: Silence [[fallthrough]] warning 2020-07-29 06:50:30 -04:00
Morph ef02370816 main: Split removal cases into their individual functions and address feedback 2020-07-29 06:50:30 -04:00
Morph 85e1facfe6 main: Connect game list remove signals to removal functions 2020-07-29 06:50:30 -04:00
Morph de6b852dc2 game_list: Add "Remove" context menu 
Adds the following actions:
- Remove Installed Update
- Remove All Installed DLC
- Remove Shader Cache
- Remove Custom Configuration
- Remove All Installed Contents
 2020-07-29 06:50:30 -04:00
bunnei b205b12e75
Merge pull request #4442 from lioncash/devicemem 
device_memory: Remove unused system member
 2020-07-28 13:03:30 -07:00
Morph 8d42456dc2 configure_graphics: Remove Force 30 FPS mode 
The introduction of multicore rendered this setting non-functional as timing code was changed.

This removes the setting entirely.
 2020-07-28 08:07:26 -04:00
Morph e8f22730d1 renderer_opengl: Use 1/4 of all threads for async shader compilation 2020-07-28 05:08:27 -04:00
Lioncash e3f0c93230 common/atomic_ops: Don't cast away volatile from pointers 
Preserves the volatility of the pointers being casted.
 2020-07-28 04:36:53 -04:00
ReinUsesLisp bc699ace15 service/bsd: Handle Poll with no entries accurately 
Testing shows that Poll called with zero entries returns -1 and signals
an errno of zero.
 2020-07-28 01:51:47 -03:00
ReinUsesLisp f7d59f3e0e services/bsd: Implement most of bsd:s 
This implements: Socket, Poll, Accept, Bind, Connect, GetPeerName,
GetSockName, Listen, Fcntl, SetSockOpt, Shutdown, Recv, RecvFrom,
Send, SendTo, Write, and Close

The implementation was done referencing: SwIPC, switchbrew, testing
with libnx and inspecting its code, general information about bsd
sockets online, and analysing official software.

Not everything from these service calls is implemented, but everything
that is not implemented will be logged in some way.
 2020-07-28 01:48:42 -03:00
ReinUsesLisp 2c67bbf609 service/sockets: Add worker pool abstraction 
Manage worker threads with an easy to use abstraction.
We can expand this to support thread deletion in the future.
 2020-07-28 01:47:03 -03:00
ReinUsesLisp 5692c48ab7 service/sockets: Add worker abstraction to execute blocking calls asynchronously 
This abstraction allows executing blocking functions (like recvfrom on a
socket configured for blocking) without blocking the service thread.
It is intended to be used with SleepClientThread.
 2020-07-28 01:47:03 -03:00
ReinUsesLisp 80b4bd3583 service/sockets: Add translate functions 
These functions translate from Network enumerations/structures to guest
enumerations/structures and viceversa.
 2020-07-28 01:47:03 -03:00
ReinUsesLisp 22263ccaa4 service/sockets: Add enumerations and structures 
Add guest enumerations and structures used in socket services
 2020-07-28 01:47:03 -03:00
ReinUsesLisp ef8acc9c3d services/nifm: Implement GetCurrentIpAddress 
This is trivially implemented using the Network abstraction

- Used by ftpd
 2020-07-28 01:47:03 -03:00
Lioncash 2258f33ee4 device_memory: Remove unused system member 
This isn't used by anything in particular, so it can be removed.
 2020-07-27 23:37:49 -04:00
Lioncash 989ad52dc1 cpu_manager: Remove redundant std::function declarations 
We can just return the function directly. Making for less reading.
 2020-07-27 21:57:05 -04:00
bunnei db94457205
Update src/core/hle/service/nvdrv/devices/nvmap.cpp 
Co-authored-by: LC <mathew1800@gmail.com>
 2020-07-27 18:27:20 -07:00
Lioncash a7af349dae core_timing: Make use of uintptr_t to represent user_data 
Makes the interface future-proofed for supporting other platforms in the event we ever support platforms with differing pointer sizes. This way, we have a type in place that is always guaranteed to be able to represent a pointer exactly.
 2020-07-27 21:21:01 -04:00
Lioncash 2e303095d5 yuzu/main: Remove redundant usages of QStringLiteral("") 
An empty QStringLiteral can more efficiently be replaced with an empty
QString.
 2020-07-27 21:04:17 -04:00
bunnei 6b35317ff3
Merge pull request #4419 from lioncash/initializer 
vulkan: Resolve -Wmissing-field-initializer warnings
 2020-07-27 15:52:03 -07:00
bunnei f97c2cdd0b
Merge pull request #4434 from CrazyMax/lang_unused_var 
AM: GetDesiredLanguage: remove unused variable
 2020-07-27 12:37:52 -07:00
Rodrigo Locatti d51afc4efb
Merge pull request #4432 from bylaws/patch-1 
video_core/gpu: Correct the size of the puller registers
 2020-07-27 05:25:49 -03:00
CrazyMax 1ffff4dab2 remove unused variable; 2020-07-27 10:36:26 +03:00
bunnei 99d191d80d
Merge pull request #4431 from kelnos/fix-exit-crash 
GCAdapter: only join worker thread if running & joinable
 2020-07-26 18:03:37 -07:00
Brian J. Tarricone d840ed90e1 GCAdapter: only join worker thread if running & joinable 2020-07-26 14:54:02 -07:00
Billy Laws f490b4545d
video_core/gpu: Correct the size of the puller registers 
The puller register array is made up of u32s however the `NUM_REGS` value is the size in bytes, so switch it to avoid making the struct unnecessary large. Also fix a small typo in a comment.
 2020-07-26 22:26:29 +01:00
lat9nq 156bf5b297 config: Make the save-as identifier more consistent 
Solves an issue with restoring the value upon reloading program.
 2020-07-26 13:31:00 -04:00
bunnei 08f02836d8
Merge pull request #4426 from lioncash/lock 
nvflinger: Use return value of Lock()
 2020-07-26 09:19:24 -07:00
bunnei 4524e1bd54
Merge pull request #4418 from lioncash/udp-warn 
udp/client: Remove unused boost include
 2020-07-25 21:50:37 -07:00
bunnei 05def61398 hle: nvdrv: Rewrite of GPU memory management. 2020-07-26 00:49:43 -04:00
bunnei 45cf48bd0a
Merge pull request #4415 from lioncash/maybe 
virtual_buffer: Mark size parameter of FreeMemoryPages() as [[maybe_unused]]
 2020-07-25 21:35:09 -07:00
bunnei b69f902b18
Merge pull request #4417 from lioncash/poll 
gc_adapter/gc_poller: Resolve compiler warnings
 2020-07-25 19:42:09 -07:00
FearlessTobi 35b96a28d7 yuzu/configure_debug: Remove duplicated checkboxes 
Those are already found in the Filesystem tab.
They were added back to the Debug tab by mistake in the Vulkan PR.
 2020-07-26 02:45:19 +02:00
Lioncash 7b070bbf62 nvflinger: Mark interface functions with return values as [[nodiscard]] 
Not using the return value of these functions are undeniably the source
of a bug. This way we allow compilers to loudly make any future misuses
evident.
 2020-07-25 19:42:45 -04:00
Lioncash 5dab23e017 nvflinger: Use return value of Lock() 
comex reported in #4424 that we were incorrectly discarding the return
value of Lock() which is correct.
 2020-07-25 19:04:53 -04:00
bunnei a2e1810287
Merge pull request #4350 from ogniK5377/hid-update-connected 
hid: Only update keyboard & debug pad inputs if enabled
 2020-07-25 11:57:24 -07:00
LC e3503de588
common/string_util: Remove unimplemented function prototype (#4414) 
This function was relocated to log.h as a constexpr function, so this
can be removed.
 2020-07-25 15:37:51 +02:00
David Marcec 3dcbba38bf Fix perf regression 2020-07-25 21:46:25 +10:00
Lioncash 80eedff9e1 vulkan: Resolve -Wmissing-field-initializer warnings 2020-07-25 03:50:18 -04:00
Lioncash 1a7cf26884 udp/client: Remove unused boost include 
Also silences a deprecation warning from boost on Clang/GCC.
 2020-07-25 03:42:03 -04:00
Lioncash ac7e4e2cab gc_adapter: Resolve C++20 deprecation warning 2020-07-25 03:38:22 -04:00
Lioncash 04699c366b gc_poller: Resolve -Wsign-compare warning 2020-07-25 03:37:22 -04:00
Lioncash e19972dfc4 gc_poller: Resolve -Wredundant-move warning 2020-07-25 03:35:40 -04:00
Lioncash 2e511246fa lz4_compression: Make use of std::span in interfaces 
Allows compressing the data and size parameters into one.
 2020-07-25 03:17:04 -04:00
Lioncash c5bdccfecb zstd_compression: Make use of std::span in interfaces 
Allows condensing the data and size parameters into a single argument.
 2020-07-25 03:11:56 -04:00
Lioncash ca6ff01333 virtual_buffer: Mark size parameter of FreeMemoryPages() as [[maybe_unused]] 
This isn't used on Windows, but is used on non-Windows operating
systems.
 2020-07-25 03:04:27 -04:00
bunnei d046e9b458
Merge pull request #4380 from ogniK5377/swkbd-inline-1 
swkbd: Return result for Calc request for inlined swkbd
 2020-07-24 22:31:24 -07:00
bunnei dc2d31b1b2
Merge pull request #4393 from lioncash/unused5 
vk_rasterizer: Remove unused variable in Clear()
 2020-07-24 20:33:58 -07:00
David Marcec f4eb7dceaf Fix stream channel count when outputting to stereo 2020-07-25 13:31:43 +10:00
David Marcec b924c71822 Address issues 2020-07-25 12:39:37 +10:00
David Marcec 8a497adf85 Queue extra mix buffer 2020-07-25 12:39:36 +10:00
David Marcec d68856ab12 Disable time stretcher for time being 2020-07-25 12:39:35 +10:00
David Marcec 380658c21d audio_core: Apollo Part 1, AudioRenderer refactor 2020-07-25 12:39:34 +10:00
bunnei c73701edea
Merge pull request #4377 from Morph1984/dark-themes 
qt-themes: Add Midnight Blue qdarkstyle theme (2.8.1)
 2020-07-24 19:23:45 -07:00
bunnei 2ed8f3f549
Merge pull request #4334 from lat9nq/clear-per-game-settings 
configure_per_game: Clearer per-game settings
 2020-07-24 19:19:27 -07:00
bunnei d488cb843e
Merge pull request #4388 from lioncash/written 
buffer_cache: Eliminate redundant map lookup in MarkRegionAsWritten()
 2020-07-24 11:29:37 -07:00
bunnei f650cf8a9a
Merge pull request #4391 from lioncash/nrvo 
video_core: Allow copy elision to take place where applicable
 2020-07-24 06:33:09 -07:00
bunnei 1d7de0a8ee
Merge pull request #4394 from lioncash/unused6 
video_core: Remove unused variables
 2020-07-23 19:54:59 -07:00
bunnei 5ac91a6c7a
Merge pull request #4353 from ameerj/gc-refactor 
gc_adapter: Refactor code
 2020-07-23 18:44:39 -07:00
Jan Beich f99be1c923 network: add missing include for BSDs 
src/core/network/network.cpp:112:28: error: use of undeclared identifier 'SHUT_RD'
constexpr int SD_RECEIVE = SHUT_RD;
                           ^
src/core/network/network.cpp:113:25: error: use of undeclared identifier 'SHUT_WR'
constexpr int SD_SEND = SHUT_WR;
                        ^
src/core/network/network.cpp:114:25: error: use of undeclared identifier 'SHUT_RDWR'
constexpr int SD_BOTH = SHUT_RDWR;
                        ^
src/core/network/network.cpp:120:37: error: unknown type name 'in_addr'; did you mean 'in_addr_t'?
constexpr IPv4Address TranslateIPv4(in_addr addr) {
                                    ^~~~~~~
                                    in_addr_t
/usr/include/netdb.h:66:20: note: 'in_addr_t' declared here
typedef __uint32_t      in_addr_t;
                        ^
src/core/network/network.cpp:121:27: error: member reference base type 'in_addr_t' (aka 'unsigned int') is not a structure or union
    const u32 bytes = addr.s_addr;
                      ~~~~^~~~~~~
src/core/network/network.cpp:121:15: error: variables defined in a constexpr function must be initialized
    const u32 bytes = addr.s_addr;
              ^
src/core/network/network.cpp:126:10: error: incomplete result type 'sockaddr' in function definition
sockaddr TranslateFromSockAddrIn(SockAddrIn input) {
         ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:127:5: error: unknown type name 'sockaddr_in'; did you mean 'sockaddr'?
    sockaddr_in result;
    ^~~~~~~~~~~
    sockaddr
/usr/include/netdb.h:142:9: note: 'sockaddr' declared here
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:127:17: error: variable has incomplete type 'sockaddr'
    sockaddr_in result;
                ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:131:29: error: use of undeclared identifier 'AF_INET'
        result.sin_family = AF_INET;
                            ^
src/core/network/network.cpp:135:29: error: use of undeclared identifier 'AF_INET'
        result.sin_family = AF_INET;
                            ^
src/core/network/network.cpp:139:23: error: use of undeclared identifier 'htons'
    result.sin_port = htons(input.portno);
                      ^
src/core/network/network.cpp:143:14: error: variable has incomplete type 'sockaddr'
    sockaddr addr;
             ^
/usr/include/netdb.h:142:9: note: forward declaration of 'sockaddr'
        struct  sockaddr *ai_addr;      /* binary address */
                ^
src/core/network/network.cpp:156:1: error: unknown type name 'linger'
linger MakeLinger(bool enable, u32 linger_value) {
^
src/core/network/network.cpp:157:5: error: unknown type name 'linger'
    linger value;
    ^
src/core/network/network.cpp:185:16: error: use of undeclared identifier 'AF_INET'
        return AF_INET;
               ^
src/core/network/network.cpp:195:16: error: use of undeclared identifier 'SOCK_STREAM'
        return SOCK_STREAM;
               ^
src/core/network/network.cpp:197:16: error: use of undeclared identifier 'SOCK_DGRAM'
        return SOCK_DGRAM;
               ^
src/core/network/network.cpp:207:16: error: use of undeclared identifier 'IPPROTO_TCP'
        return IPPROTO_TCP;
               ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
 2020-07-22 22:10:15 +00:00
David Marcec 8abb31a19d vi: IApplicationDisplayService:GetIndirectLayerImageRequiredMemoryInfo 
Needed for dark souls and monster hunter
 2020-07-21 23:06:18 +10:00
Rodrigo Locatti 7278c59d70
Merge pull request #4359 from ReinUsesLisp/clamp-shared 
renderer_{opengl,vulkan}: Clamp shared memory to host's limit
 2020-07-21 04:51:05 -03:00
Rodrigo Locatti 721e6015a8
Merge pull request #4360 from ReinUsesLisp/glasm-bar 
gl_arb_decompiler: Execute BAR even when inside control flow
 2020-07-21 04:50:55 -03:00
Rodrigo Locatti 9ea9a60e17
Merge pull request #4361 from ReinUsesLisp/lane-id 
decode/other: Implement S2R.LaneId
 2020-07-21 04:50:45 -03:00
Lioncash 82b7e5c8ee surface_params: Make use of designated initializers where applicable 
Provides a convenient way to avoid unnecessary zero initializing.
 2020-07-21 02:27:22 -04:00
Lioncash bd9545a3a8 surface_params: Remove redundant assignment 
This is a redundant assignment that can be removed.
 2020-07-21 02:26:49 -04:00
Lioncash c705a1db96 surface_params: Replace questionable usages of the comma operator with semicolons 
These are bugs waiting to happen.
 2020-07-21 02:26:48 -04:00
David e9bfe05e04
Merge pull request #4306 from ReinUsesLisp/bsd-network 
core/network: Add network abstraction
 2020-07-21 16:05:47 +10:00
Lioncash e17fb5ee97 video_core: Remove unused variables 
Silences several compiler warnings about unused variables.
 2020-07-21 00:57:25 -04:00
Lioncash 4b369126c4 vk_rasterizer: Remove unused variable in Clear() 
The relevant values are already assigned further down in the lambda, so
this can be removed entirely.
 2020-07-21 00:49:10 -04:00
Lioncash 059305a6bf compatible_formats: Add missing header guard 
Prevents potential inclusion issues from occurring.
 2020-07-21 00:42:19 -04:00
Lioncash 6adc824d9d video_core: Allow copy elision to take place where applicable 
Removes const from some variables that are returned from functions, as
this allows the move assignment/constructors to execute for them.
 2020-07-21 00:36:13 -04:00
bunnei 3d13d7f48f
Merge pull request #4324 from ReinUsesLisp/formats 
video_core: Fix, add and rename pixel formats
 2020-07-21 00:13:04 -04:00
lat9nq e35239b861 configure_ui: Ensure a separator follows the returned path 2020-07-20 23:19:07 -04:00
lat9nq 19250aadee configure_ui: don't use an empty string 
If the user had cancelled, it would clear the text box. That behavior was sanitized underneath, but may anyways cause inconveniences.
 2020-07-20 23:11:46 -04:00
lat9nq 599b7c26a9 main: Don't use as many string copies 
Co-Authored-By: LC <lioncash@users.noreply.github.com>
 2020-07-20 23:03:55 -04:00
lat9nq a723ed31fd main: rewrite (save as) screenshot saving 
This picks a default directory and file name. If on Windows and save-as screenshot saving is enabled, it asks the user, first defaulting to the default screenshot path, and with a default filename in the format `[title_id]_[year-mt-dy_hr-mn-sc-msc].png`. Otherwise, or on Linux for now, it simply saves a file in that directory with that file name.
 2020-07-20 23:03:55 -04:00
lat9nq 71b902cf62 configuration: Setup UI to config screenshot path and saving 
This adds two options to the General -> UI tab. The first disables picking a place to save the file. The second chooses a default directory for saving screenshots.
 2020-07-20 23:03:49 -04:00
lat9nq 3848155c42 common: Add a screenshots directory 
Adds a screenshots directory as a path managed by FileUtil.
 2020-07-20 22:51:02 -04:00
David Marcec dd4a02d15c video_core: Remove redundant pixel format type 
We already get the format type before converting shadow formats and during shadow formats.
 2020-07-21 12:44:32 +10:00
bunnei 61e4c0f83d
Merge pull request #4168 from ReinUsesLisp/global-memory 
gl_arb_decompiler: Use NV_shader_buffer_{load,store} on assembly shaders
 2020-07-20 21:54:17 -04:00
Lioncash 26c6c71837 buffer_cache: Eliminate redundant map lookup in MarkRegionAsWritten() 
We can make use of emplace()'s return value to determine whether or not
we need to perform an increment.

emplace() performs no insertion if an element already exist, so this can
eliminate a find() call.
 2020-07-20 17:48:00 -04:00
Morph d942472cce wait_tree: Include Midnight Blue dark themes 2020-07-20 01:25:25 -04:00
James Rowe 7e01311061 qt-themes: Add Midnight Blue qdarkstyle theme (2.8.1) 
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
 2020-07-20 01:25:25 -04:00
David Marcec 8248d76964 Address issues 2020-07-20 11:52:07 +10:00
lat9nq 2120740ee6 configure_graphics_advnaced: clang-format mk ii 2020-07-19 13:26:55 -04:00
lat9nq 23347b8869 configure_graphics_advanced: Fix oversight from rebase 2020-07-19 13:26:55 -04:00
lat9nq 520b4c7829 configuration_shared: Remove unused functions 
These were only kept for compatibility with old code during testing.
 2020-07-19 13:26:55 -04:00
lat9nq 3ef4769f31 configuration: Use forward declares and remove extraneous structs 2020-07-19 13:26:55 -04:00
lat9nq 335aef78c4 configuration_shared: Make CheckState strongly typed 
Also gets rid of unnecessary explicit namespace usage.
 2020-07-19 13:26:55 -04:00
lat9nq 55ac28769a clang-format 2020-07-19 13:26:55 -04:00
lat9nq 0d462f5608 configuration_shared: Break up tracker structs to respective classes 
One less global variable.
 2020-07-19 13:26:55 -04:00
lat9nq e483ed21eb configure_system: break instead of semicolon 
Makes the code more readable

Co-Authored-By: LC <lioncash@users.noreply.github.com>
 2020-07-19 13:26:55 -04:00
lat9nq d5fdbd88c8 clang-format 2020-07-19 13:26:55 -04:00
lat9nq 33a9218f35 configure_system: Highlight labels on startup 
whoops
 2020-07-19 13:26:55 -04:00
lat9nq 90a0fb1e0e configure_graphics: Fix layout in global config 
Fixes a regression where the global config takes up a lot of extra space.
 2020-07-19 13:26:55 -04:00
lat9nq c94a8a3a43 configure_per_game: Improve style consistency 
The way the configurations are set up, it is not trivial to do this. I'll leave it as is, but the API selection, and the background color and volume slider selectors are kind of not following the style.
 2020-07-19 13:26:55 -04:00
lat9nq a350ae6be6 configure_system: Implement highlighted overrides 2020-07-19 13:26:55 -04:00
lat9nq 6316a3d8d9 configuration_shared: Add default combobox setup function 
Not a catch-all, but helps clean up the code for when I do this a lot. Also fixes some bugs caught in configure_graphics.
 2020-07-19 13:26:55 -04:00
lat9nq 2627241541 configuration_shared: Use an int instead of a QString 
I noticed some of the code could be reduced to just passing the function an int, since I was doing the same thing over and over. Also clang-formats configure_graphics
 2020-07-19 13:26:55 -04:00
lat9nq 38152ab0b9 configure_graphics_advanced: Implement highlighted overrides 2020-07-19 13:26:55 -04:00
lat9nq b79a6ebf9c configuration_shared: Switch back to background colors 
Let's see if I make up my mind.
 2020-07-19 13:26:55 -04:00
lat9nq 44b3183ec8 configuration_shared: Better use global text 
Also adds trackers for graphics and advanced graphics
 2020-07-19 13:26:55 -04:00
lat9nq c9f93c05f7 configure_audio: fix UI margins 2020-07-19 13:26:55 -04:00
lat9nq c4246b80f8 configure_graphics: Implement highlighted overrides 2020-07-19 13:26:55 -04:00
lat9nq bf25d583c6 configure_audio: Implement highlighted overrides 2020-07-19 13:26:55 -04:00
lat9nq da65b92f9e configuration_shared: Require name of the widget for highlighting 
Prevents mass-coloring of elements later on
 2020-07-19 13:26:55 -04:00
lat9nq 5a9dc8f002 configuration_shared: Use a highlight instead of background color 
Fixes visibility in the built-in dark theme
 2020-07-19 13:26:55 -04:00
lat9nq 58672cc7b6 configure_general: Implement manual tristate buttons 2020-07-19 13:26:55 -04:00
lat9nq e26e82d8d5 configuration_shared: Initial functions and data for manual tristate 
Sets up initial support for implementing colored tristate functions. These functions color a QWidget blue when it's overriding a global setting, and discolor it when not. The lack of color indicates it uses the global state, replacing the Qt::CheckState::PartiallyChecked state with the global state.
 2020-07-19 13:26:55 -04:00
ameerj 68d6d3e173 Fix axis thresholding while polling 
axes were very sensitive when mapping controls.
 2020-07-19 11:49:26 -04:00
David Marcec d7d2c27b48 swkbd: Return result for Calc request for inlined swkbd 
Fixes random swkbd popups in monster hunter
 2020-07-19 18:56:16 +10:00
ReinUsesLisp 51817f6e59 core/network: Add network abstraction 
This commit adds a network abstraction designed to implement bsd:s but
at the same time work as a generic abstraction to implement any
networking code we have to use from core.

This is implemented on top of BSD sockets on Unix systems and winsock on
Windows. The code is designed around winsocks having compatibility
definitions to support both BSD and Windows sockets.
 2020-07-19 04:12:40 -03:00
Rodrigo Locatti ad0b295125
Merge pull request #4376 from ogniK5377/dark-wait-tree 
frontend: Improve wait tree readability for dark themes
 2020-07-19 03:55:36 -03:00
Jan Beich db43b37e15 alignment: explicitly include <new> after 723edb4c06 
In file included from src/core/hle/kernel/memory/page_table.cpp:5:
src/./common/alignment.h:67:68: error: no member named 'align_val_t' in namespace 'std'
        return static_cast<T*>(::operator new (n * sizeof(T), std::align_val_t{Align}));
                                                              ~~~~~^
src/./common/alignment.h:71:51: error: no member named 'align_val_t' in namespace 'std'
        ::operator delete (p, n * sizeof(T), std::align_val_t{Align});
                                             ~~~~~^
 2020-07-18 23:06:16 +00:00
David Marcec 617eeb09e0 Address issues 2020-07-19 01:02:41 +10:00
FearlessTobi 4450a2688a Address trivial review comments. 2020-07-18 14:09:13 +02:00
FearlessTobi 0072003a14 configure_ui: Address some review comments from the previous PR 2020-07-18 14:09:13 +02:00
FearlessTobi 347b50ad43 yuzu: Port translation support from Citra 
Co-Authored-By: Weiyi Wang <wwylele@gmail.com>
 2020-07-18 14:09:11 +02:00
David Marcec db4502b7b7 frontend: Improve wait tree readability for dark themes 2020-07-18 20:22:03 +10:00
bunnei 4a8cb9a706
Merge pull request #4348 from lioncash/nano 
core_timing: Make usage of nanoseconds more consistent in the interface
 2020-07-18 01:45:10 -04:00
bunnei bbeea7502c
Merge pull request #4373 from lioncash/allocator 
alignment: Simplify AlignmentAllocator implementation
 2020-07-18 01:04:17 -04:00
ReinUsesLisp a8a2526128 gl_arb_decompiler: Use NV_shader_buffer_{load,store} on assembly shaders 
NV_shader_buffer_{load,store} is a 2010 extension that allows GL applications
to use what in Vulkan is known as physical pointers, this is basically C
pointers. On GLASM these is exposed through the LOAD/STORE/ATOM
instructions.

Up until now, assembly shaders were using NV_shader_storage_buffer_object.
These work fine, but have a (probably unintended) limitation that forces
us to have the limit of a single stage for all shader stages. In contrast,
with NV_shader_buffer_{load,store} we can pass GPU addresses to the
shader through local parameters (GLASM equivalent uniform constants, or
push constants on Vulkan). Local parameters have the advantage of being
per stage, allowing us to generate code without worrying about binding
overlaps.
 2020-07-18 01:59:57 -03:00
bunnei c700079e08
Merge pull request #4345 from Morph1984/fix-createfile 
filesystem: Create subdirectories prior to creating a file
 2020-07-18 00:59:26 -04:00
bunnei 90cbcaa44a
Merge pull request #4273 from ogniK5377/async-shaders-prod 
video_core: Add asynchronous shader decompilation and compilation
 2020-07-18 00:48:27 -04:00
David Marcec 967307d3be Fix style issues 2020-07-18 14:24:32 +10:00
bunnei 821d295f24
Merge pull request #4364 from lioncash/desig5 
vulkan: Make use of designated initializers where applicable
 2020-07-18 00:12:43 -04:00
bunnei af1151b1b0
Merge pull request #4365 from lioncash/mii 
mii/manager: Make use of designated initializers
 2020-07-17 22:20:15 -04:00
bunnei 0b733903f0
Merge pull request #4374 from ReinUsesLisp/fix-err 
vk_device: Fix build error on old MSVC versions
 2020-07-17 20:30:24 -04:00
bunnei 47b305387a
Merge pull request #4366 from lioncash/mii-sign 
mii/manager: Resolve sign mismatch warnings
 2020-07-17 20:13:06 -04:00
FearlessTobi 4d4bbe756f file_sys/nsp: Make SetTicketKeys actually do something 
Previously, the method wasn't modifying any class state and therefore not having any effects when called.
Since this has been the case for a very long time now, I'm not sure if we couldn't just remove this method altogether.
 2020-07-18 02:02:39 +02:00
ReinUsesLisp 81c8f92f2e vk_device: Fix build error on old MSVC versions 
Designated initializers on old MSVC versions fail to build when they
take the address of a constant.
 2020-07-17 20:27:53 -03:00
bunnei 5d95e62443
Merge pull request #4344 from VolcaEM/c3 
dmnt_cheat_vm: Implement opcode 0xC3 (ReadWriteStaticRegister)
 2020-07-17 17:11:52 -04:00
bunnei 0f0b756775
Merge pull request #4309 from Morph1984/fix-romfs-bug 
fs: Fix RomFS building when zero byte files are present
 2020-07-17 17:01:20 -04:00
ameerj 1e7bed0a45 std::size_t where appropriate, make error message more clear if can't read 2020-07-17 12:10:32 -04:00
bunnei 19c6bf72db
Merge pull request #4322 from ReinUsesLisp/fix-dynstate 
vk_state_tracker: Fix dirty flags for stencil_enable on VK_EXT_extended_dynamic_state
 2020-07-17 09:50:45 -04:00
Lioncash 723edb4c06 alignment: Simplify AlignmentAllocator implementation 
With C++20, much of the allocator interface has been simplified, so we
can make the same adjustments.
 2020-07-17 08:30:12 -04:00
LC 47956a3bbc
Merge pull request #4369 from lioncash/hle-macro 
macro_hle: Remove unnecessary std::make_pair calls
 2020-07-17 05:20:41 -04:00
LC 9d3cbf6a90
Merge pull request #4340 from lioncash/remove 
shader_cache: Make use of std::erase_if
 2020-07-17 05:19:20 -04:00
David Marcec 4f473cda64 Drop settings namespace 2020-07-17 17:23:24 +10:00
David Marcec 85b591f6f0 Remove duplicate config 2020-07-17 14:26:18 +10:00
David Marcec f48187449e Use conditional var 2020-07-17 14:26:17 +10:00
David Marcec 2ba195aa0d Drop max workers from 8->2 for testing 2020-07-17 14:26:15 +10:00
David Marcec 85d7a8f466 Rebase for per game settings 2020-07-17 14:26:14 +10:00
David Marcec 468bd9c1b0 async shaders 2020-07-17 14:24:57 +10:00
David c783cf443e
Merge pull request #4347 from lioncash/logging 
settings: Make use of std::string_view over std::string for logging
 2020-07-17 13:25:06 +10:00
David 92f37a229e
Merge pull request #4371 from lioncash/cmake2 
core/CMakeLists: Add missing physical_memory.h header file
 2020-07-17 13:22:19 +10:00
David adbf5ca50b
Merge pull request #4357 from lioncash/unused4 
kernel: Remove unused variables
 2020-07-17 13:18:31 +10:00
David 69f8b6a53e
Merge pull request #4358 from lioncash/unused5 
kernel/thread: Remove unimplemented function prototype
 2020-07-17 13:17:52 +10:00
Lioncash c0650cd82c macro_hle: Remove unnecessary static keywords 
These functions are already in an anonymous namespace which makes the
functions internally linked.
 2020-07-16 23:17:17 -04:00
David 0d10c863a5
Merge pull request #4367 from lioncash/inc2 
constants: Add missing <array> include
 2020-07-17 13:14:01 +10:00
David 9cca0c2f83
Merge pull request #4368 from lioncash/macro 
macro: Resolve missing parameter in doxygen comment
 2020-07-17 13:13:22 +10:00
David 3ce4edba64
Merge pull request #4370 from lioncash/simplify 
macro_hle: Simplify shift expression in HLE_771BB18C62444DA0()
 2020-07-17 13:13:05 +10:00
Lioncash 311f500753 core/CMakeLists: Add missing physical_memory.h header file 
Allows this header file to show up in IDE CMake generators.
 2020-07-16 22:56:31 -04:00
Lioncash be6b7591d9 macro_hle: Simplify shift expression in HLE_771BB18C62444DA0() 
Given the expression involves a 32-bit value, this simplifies down to
just: 0x3ffffff. This is likely a remnant from testing that was never
cleaned up.

Resolves a -Wshift-overflow warning.
 2020-07-16 22:16:11 -04:00
Lioncash cc935d997b macro_hle: Remove unnecessary std::make_pair calls 
The purpose of make_pair is generally to deduce the types within the
pair without explicitly specifying the types, so these usages were
generally unnecessary, particularly when the type is enforced by the
array declaration.
 2020-07-16 21:59:25 -04:00
Lioncash 502dbfb9eb macro: Resolve missing parameter in doxygen comment 
Resolves a -Wdocumentation warning.
 2020-07-16 21:54:42 -04:00
Lioncash e07eb5b223 constants: Add missing <array> include 
Eliminates reliance on an indirect include.
 2020-07-16 21:43:20 -04:00
Lioncash e54c940abf mii/manager: Resolve sign mismatch warnings 
Previously the loop termination condition was testing variables of
different signedness.
 2020-07-16 21:07:04 -04:00
Rodrigo Locatti 39ae2deb28
Merge pull request #4363 from lioncash/mismatch 
vk_texture_cache: Amend mismatched access masks and indices in UploadBuffer
 2020-07-16 21:54:40 -03:00
Lioncash 7f989378c0 mii/manager: Make use of designated initializers 
Allows returning the structure in a more concise manner.
 2020-07-16 20:45:33 -04:00
bunnei 3bbf4462db
Merge pull request #4292 from bunnei/mii-rewrite 
hle: service: mii: Rewrite service to properly support creation of random and default miis.
 2020-07-16 20:05:40 -04:00
Lioncash 7785123b1c wrapper: Make use of designated initializers where applicable 2020-07-16 20:01:01 -04:00
Lioncash 01da386617 vk_texture_cache: Make use of designated initializers where applicable 2020-07-16 19:52:38 -04:00
Lioncash 169759e069 vk_texture_cache: Amend mismatched access masks and indices in UploadBuffer 
Discovered while converting relevant parts of the codebase over to
designated initializers.
 2020-07-16 19:45:46 -04:00
Lioncash 08d36afd40 vk_swapchain: Make use of designated initializers where applicable 2020-07-16 19:27:02 -04:00
Lioncash 3c060503bc vk_stream_buffer: Make use of designated initializers where applicable 2020-07-16 19:22:11 -04:00
Lioncash 70147e913f vk_staging_buffer_pool: Make use of designated initializers where applicable 2020-07-16 19:22:03 -04:00
Lioncash 2025f847bb vk_shader_util: Make use of designated initializers where applicable 2020-07-16 19:17:41 -04:00
Lioncash 97e7663004 vk_scheduler: Make use of designated initializers where applicable 2020-07-16 19:11:43 -04:00
Lioncash fd7af52ec3 vk_sampler_cache: Make use of designated initializers where applicable 2020-07-16 19:06:40 -04:00
Lioncash 772b6e4d28 vk_resource_manager: Make use of designated initializers where applicable 2020-07-16 19:02:35 -04:00
Lioncash 8ebd6a21c5 vk_renderpass_cache: Make use of designated initializers where applicable 2020-07-16 18:57:23 -04:00
Lioncash 01f297f2e0 vk_rasterizer: Make use of designated initializers where applicable 2020-07-16 18:49:42 -04:00
Lioncash c07b0ffe47 vk_query_cache: Make use of designated initializers where applicable 2020-07-16 18:34:04 -04:00
Lioncash d43e923990 vk_pipeline_cache: Make use of designated initializers where applicable 2020-07-16 18:32:29 -04:00
Lioncash 7d5f93832c vk_memory_manager: Make use of designated initializers where applicable 2020-07-16 18:26:30 -04:00
Lioncash 75c00c3cb0 vk_image: Make use of designated initializers where applicable 2020-07-16 18:24:26 -04:00
Lioncash 6d165481ad vk_descriptor_pool: Make use of designated initializers where applicable 2020-07-16 18:19:45 -04:00
Lioncash fb563e75e9 vk_graphics_pipeline: Resolve narrowing warnings 
For whatever reason, VK_TRUE and VK_FALSE aren't defined as having a
VkBool32 type, so we need to cast to it explicitly.
 2020-07-16 18:13:49 -04:00
Lioncash 5330ca396d vk_compute_pipeline: Make use of designated initializers where applicable 2020-07-16 17:32:12 -04:00
Lioncash 757ddd8158 vk_compute_pass: Make use of designated initializers where applicable 
Note: Some barriers can't be converted over yet, as they ICE MSVC.
 2020-07-16 17:23:56 -04:00
Lioncash a66a0a6a53 vk_buffer_cache: Make use of designated initializers where applicable 
Note: An array within CopyFrom() cannot be converted over yet, as it
ICEs MSVC when converted over.
 2020-07-16 16:59:39 -04:00
Rodrigo Locatti 104c523d3d
Merge pull request #4327 from lioncash/desig2 
address_space_info: Make use of designated initializers
 2020-07-16 17:41:55 -03:00
Rodrigo Locatti be68ee88c2
Merge pull request #4333 from lioncash/desig3 
vk_graphics_pipeline: Make use of designated initializers where applicable
 2020-07-16 17:41:45 -03:00
Rodrigo Locatti b6d73ec9c2
Merge pull request #4332 from lioncash/vkdev 
vk_device: Make use of designated initializers where applicable
 2020-07-16 17:41:20 -03:00
ReinUsesLisp 210cc0204d decode/other: Implement S2R.LaneId 
This maps to host's thread id.

- Fixes graphical issues on Paper Mario.
 2020-07-16 16:09:39 -03:00
ReinUsesLisp 88e57b13e0 gl_arb_decompiler: Execute BAR even when inside control flow 
Unlike GLSL, GLASM allows us to call BAR inside control flow.

- Fixes graphical artifacts in Paper Mario.
 2020-07-16 16:05:52 -03:00
ReinUsesLisp a5a72cbd20 renderer_{opengl,vulkan}: Clamp shared memory to host's limit 
This stops shaders from failing to build when the exceed host's shared
memory size limit. An error is logged.
 2020-07-16 16:02:46 -03:00
bunnei 98b36625fa
Merge pull request #4321 from lioncash/desig 
vk_blit_screen: Make use of designated initializers where applicable
 2020-07-16 14:55:36 -04:00
Lioncash 8bef49cde5 kernel/thread: Remove unimplemented function prototype 
This isn't used, so it can be removed.
 2020-07-16 14:32:46 -04:00
Lioncash 2bab07c367 kernel: Remove unused variables 
Resolves some compiler warnings in the Linux build.
 2020-07-16 14:17:50 -04:00
Lioncash 07d080ecc8 kernel: Add missing include 2020-07-16 13:51:51 -04:00
Lioncash f0125b2be8 cpu_manager: Mark function getters as static 
All these do are return std::function instances of static functions, so
these can be used without an instance of the CPU manager.
 2020-07-16 13:30:56 -04:00
Lioncash 51546ce57e cpu_manager: Remove unused preemption_count variable 
Shrinks the data structure by 8 bytes.
 2020-07-16 13:24:25 -04:00
Lioncash 201514cb50 cpu_manager: Add missing includes 
Previously this header was relying on indirect inclusions that are no
longer satisfied.
 2020-07-16 13:22:58 -04:00
Ameer 94f5f29573 Refactor adapter code 2020-07-16 13:00:04 -04:00
bunnei a89dfc9183
Merge pull request #4261 from ameerj/gc-calibration 
input_common: GC Controller save and compare against analog origin state
 2020-07-16 11:40:09 -04:00
bunnei 2781201bfb
Merge pull request #4337 from lat9nq/fix-per-game-async 
main: Set async gpu properly after loading per-game setting
 2020-07-16 11:33:51 -04:00
bunnei 9121d35e70
Merge pull request #4297 from FearlessTobi/skip-profile-select 
main/profile_select: Don't prompt for profile selection when only one is available
 2020-07-16 09:45:09 -04:00
David 0648e023ea
Merge pull request #4346 from lioncash/thread 
kernel/handle_table: Remove usages of the global system instance
 2020-07-16 23:02:04 +10:00
David Marcec 0319cc1c37 hid: Only update keyboard & debug pad inputs if enabled 
Previously we would ignore this setting and would update the states regardless of the user setting
 2020-07-16 22:28:49 +10:00
David 815f30dc10
Merge pull request #4249 from Morph1984/delete-update-aoc-on-overwrite 
registered_cache: Remove previous update/dlc if it exists on install
 2020-07-16 20:36:22 +10:00
Morph f66e3181dc Check for empty section0 and CNMT prior to install 2020-07-16 05:22:51 -04:00
Morph 5892fc1555 Add comment to clarify the nullptr check 2020-07-16 00:15:27 -04:00
Morph 2079bb4090 filesystem: Create subdirectories prior to creating a file 
If subdirectories exist in the given path parameter and don't exist in the real filesystem create them prior to creating the files within.
This fixes the softlocks upon save creation in The Legend of Zelda: Breath of the Wild
 2020-07-16 00:15:27 -04:00
bunnei f26f53f35b
Merge pull request #4328 from lioncash/unused-var3 
memory_layout: Remove unused data member
 2020-07-15 22:08:05 -04:00
Lioncash 0435b7d361 core_timing: Remove unused data member 
Shrinks the size of the CoreTiming class by 8 bytes.
 2020-07-15 19:41:37 -04:00
Lioncash bef1844a51 core_timing: Make TimedCallback take std::chrono::nanoseconds 
Enforces our desired time units directly with a concrete type.
 2020-07-15 19:41:22 -04:00
Lioncash 8b50c660df core_timing: Make use of std::chrono with ScheduleEvent 2020-07-15 18:54:15 -04:00
Lioncash af5a56ddc4 settings: Resolve a sign conversion warning within GetTimeZoneString() 
A sign conversion warning was occurring due to an int < size_t
comparison.
 2020-07-15 13:45:22 -04:00
Lioncash 73bb87c06b kernel/process: Move name and system context to the bottom of the member list 
These aren't directly important or commonly used within the process, so
we can move these to the bottom to allow everything else to be more
likely to be within a cache line.
 2020-07-15 13:40:18 -04:00
Lioncash 52e83f0d5c kernel/handle_table: Remove usages of the global system instance 
Removes even more usages of the global system instance, trimming away
more dependencies on global variables and making them explicit in the
interface.
 2020-07-15 13:40:15 -04:00
Lioncash 5dbf91d739 settings: Make use of std::string_view over std::string for logging 
In all usages of LogSetting(), string literals are provided.
std::string_view is better suited here, as we won't churn a bunch of
string allocations every time the settings are logged out.

While we're at it, we can fold LogSetting() into LogSettings(), given
it's only ever used there.
 2020-07-15 13:37:33 -04:00
Lioncash 4ad69ca96e kernel/thread: Remove global GetCurrentThread() 
This is only used in one place, so we can fold it into the calling code,
eliminating a place for the global system instance to be used.
 2020-07-15 13:28:05 -04:00
Morph 0ca7b8269a clang format 2020-07-15 13:27:04 -04:00
Morph 1bbc61f5f1 Use proper install result when overwriting files 2020-07-15 13:27:04 -04:00
Morph 8794e623d9 Remove global system instance and address feedback 2020-07-15 13:27:04 -04:00
Morph a82fdea1ac registered_cache: Remove previous update/dlc if it exists on install 
- This checks for and removes old updates or dlc based on title id. If a content meta nca exists within the registered cache, it will attempt to remove all the ncas associated with the content meta before installing a new update/dlc
 2020-07-15 13:27:04 -04:00
VolcaEM e90802e762
clang-format 2020-07-15 01:22:52 +02:00
VolcaEM b608acd688
dmnt_cheat_vm: Implement opcode 0xC3 (ReadWriteStaticRegister) 
This was based on Atmosphére's DMNT Cheat VM:

- https://github.com/Atmosphere-NX/Atmosphere/blob/master/stratosphere/dmnt/source/cheat/impl/dmnt_cheat_vm.hpp
- https://github.com/Atmosphere-NX/Atmosphere/blob/master/stratosphere/dmnt/source/cheat/impl/dmnt_cheat_vm.cpp

From Atmosphére's documentation: "Code type 0xC3 reads or writes a static register with a given register"

There are now only two remaining opcodes to implement (PauseProcess and BreakProcess)

This is untested because I don't have any experience in testing cheats on yuzu
 2020-07-15 01:19:22 +02:00
Rodrigo Locatti 263200f982
Merge pull request #4342 from lioncash/endian 
common/swap: Make use of std::endian
 2020-07-14 18:49:07 -03:00
Lioncash 9f027b1af2 common/swap: Make use of std::endian 
Allows removing a bunch of defines in favor of a two liner.
 2020-07-14 16:26:54 -04:00
Lioncash 969100d41a shader_cache: Make use of std::erase_if 
Now that we use C++20, we can also make use of std::erase_if instead of
needing to do the erase-remove idiom.
 2020-07-14 15:49:15 -04:00
bunnei 666b37ad56
Merge pull request #4242 from ReinUsesLisp/maxwell-dma 
maxwell_dma: Match official doc and support pitch->voxel copies
 2020-07-14 14:04:16 -04:00
lat9nq a683e42516 clang-format 2020-07-14 13:46:42 -04:00
lat9nq 6d1477f214 settings: Move settings sanitization to its own function 
Creates a new function that can be expanded later to fix other settings that are known to cause emulation errors across executables.
 2020-07-14 13:36:09 -04:00
Ameer 93fe982a0c Rebase to master 2020-07-14 13:04:02 -04:00
bunnei e2730372b8
Merge pull request #4294 from MerryMage/cpu-opt-settings 
configuration: Add settings to enable/disable specific CPU optimizations
 2020-07-14 12:38:03 -04:00
bunnei 450cbcfee6
Merge pull request #4282 from Morph1984/fs-size 
filesystem: Set various NAND partition sizes to their defaults
 2020-07-14 12:16:42 -04:00
Ameer ab65de2f96 Fix crash if gc configured but adapter not connected 2020-07-14 11:23:10 -04:00
bunnei 393cdb15f5
Merge pull request #4314 from lioncash/input-warn 
gcadapter: Tidy up compiler warnings
 2020-07-14 10:20:12 -04:00
bunnei edb291b3be
Merge pull request #4315 from lioncash/udp-warn 
udp: Silence a C++20 deprecation warning
 2020-07-14 09:33:16 -04:00
lat9nq 8160e142e1 main: Set async gpu properly after loading per-game setting 
Another error that got pass me and only noticed when I was doing the per-game settings UI rework. This prevents asynchronous GPU emulation from being disabled while multi core is enabled as a result of a poorly put together per-game config.
 2020-07-14 01:02:10 -04:00
lat9nq e02687ff47 configure_general: Explicitly guard use_multi_core when applying settings 
This is likely an oversight during a rebase. Guards use_multi_core to be only set when the global value is in use. It should not make a difference given the current code base, but makes the code sensible.
 2020-07-14 00:49:17 -04:00
Lioncash 0f8b977663 vk_device: Make use of designated initializers where applicable 
Avoids redundant repetitions of variable names, and allows assignment
all in one statement.
 2020-07-13 22:24:01 -04:00
LC edb2caaae5
Merge pull request #4280 from jbeich/system-libusb 
cmake: pass libusb include directory
 2020-07-13 22:21:07 -04:00
Ameer b284c43385 input_common: drop unused libusb.h include 
Remnant of an early implementation.
 2020-07-14 01:50:34 +00:00
Lioncash 0475a167f8 vk_graphics_pipeline: Make use of designated initializers where applicable 
Avoids redundant variable name repetitions.
 2020-07-13 21:07:56 -04:00
Jan Beich 883fab2fff input_common: make libusb private to gc_adapter 2020-07-13 18:48:19 +00:00
Lioncash f2f876e3ff memory_layout: Remove unused data member 
This isn't used, so it can be removed entirely, shrinking the structure
size by 8 bytes.
 2020-07-13 10:51:23 -04:00
Lioncash ed0fe04b4f address_space_info: Use type alias to simplify code 
We can define an alias for the index arrays and then just reuse it to
make the code nicer to read.
 2020-07-13 10:42:52 -04:00
Lioncash c3eb42de65 address_space_info: Make use of designated initializers 
We can alter the structure so that we can use designated initializers in
the array, eliminating the comments that indicate their field names.
 2020-07-13 10:42:49 -04:00
ReinUsesLisp fbc232426d video_core: Rearrange pixel format names 
Normalizes pixel format names to match Vulkan names. Previous to this
commit pixel formats had no convention, leading to confusion and
potential bugs.
 2020-07-13 01:44:23 -03:00
ReinUsesLisp eda37ff26b video_core: Fix DXT4 and RGB565 2020-07-13 01:01:09 -03:00
ReinUsesLisp a8dab2ffb3 video_core/format_lookup_table: Add formats with existing PixelFormat 2020-07-13 01:01:09 -03:00
ReinUsesLisp 480850ffe7 video_core: Fix B5G6R5_UNORM render target format 2020-07-13 01:01:09 -03:00
ReinUsesLisp 990b14f181 video_core: Fix B5G6R5U 2020-07-13 01:01:09 -03:00
ReinUsesLisp 1d20aac795 video_core: Implement RGBA32_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp 9338599d72 video_core: Implement RGBA32_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp 95c0f5afe5 video_core: Implement RGBA16_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp 977d6c46f3 video_core: Implement RGBA8_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp 50c6030a8d video_core: Implement RG32_SINT render target 2020-07-13 01:01:09 -03:00
ReinUsesLisp e849d68048 video_core: Implement RG8_SINT render target and fix RG8_UINT 2020-07-13 01:01:09 -03:00
ReinUsesLisp f29fede49c video_core: Implement R8_SINT render target 2020-07-13 01:01:08 -03:00
ReinUsesLisp fd33e996e0 video_core: Implement R8_SNORM render target 2020-07-13 01:01:08 -03:00
ReinUsesLisp 505c206eb8 video_core/surface: Remove explicit values on PixelFormat's definition 2020-07-13 01:01:08 -03:00
ReinUsesLisp 143662118c video_core/surface: Reorder render target to pixel format switch 2020-07-13 01:01:08 -03:00
ReinUsesLisp 9b38f4fc55 kernel/scheduler: Use std::mutex instead of spin lock 
Profiling shows that this is a highly contested mutex, causing dimishing
results compared to a OS lock. std::mutex implementations can spin for a
while before falling back to an OS lock.

This avoids wasting precious CPU cycles in a no-op.
 2020-07-12 21:27:24 -03:00
Lioncash db6fbd5894 vk_blit_screen: Make use of designated initializers where applicable 
Now that we make use of C++20, we can use designated initializers to
make things a little nicer to read.
 2020-07-12 19:45:30 -04:00
ReinUsesLisp 0fe09df386 vk_state_tracker: Fix dirty flags for stencil_enable on VK_EXT_extended_dynamic_state 
Fixes a regression on any game using stencil on devices with
VK_EXT_extended_dynamic_state.
 2020-07-12 20:43:42 -03:00
Lioncash 8df93132cd udp: Silence a C++20 deprecation warning 
C++20 deprecates using the = lambda capture to implicitly capture the
this pointer. Instead, we must specify it explicitly.
 2020-07-12 15:49:42 -04:00
Lioncash a1dddca4ab gc_poller: Mark GCButtonFactory::GetNextInput() as const 
This doesn't modify class instance state.
 2020-07-12 15:43:07 -04:00
Lioncash 839c91cd14 gc_poller: Get rid of undefined behavior in Create() 
Ensures that the function always has returns in all control paths.
 2020-07-12 15:41:35 -04:00
Lioncash a8ba6dc3c9 gc_poller: Silence sign conversion warnings 2020-07-12 15:40:22 -04:00
Lioncash 32b6fc4062 gc_adapter: Remove deprecated usage of = in lambda captures 
It's deprecated in C++20 to use = to capture the this pointer.

Instead, we can simply pass this as an argument to the thread
constructor.
 2020-07-12 15:38:19 -04:00
Lioncash 9ce6ea648f gc_adapter: Silence sign conversion warnings 2020-07-12 15:36:27 -04:00
MerryMage a67d00ef31 configure_cpu: Split optimization settings off into Debug tab 2020-07-12 19:32:32 +01:00
Fernando Sahmkow 739d90ee66
Merge pull request #4265 from Morph1984/file-rename 
vfs_real: Fix MoveFile
 2020-07-12 13:00:09 -04:00
LC ed89bcc767
Merge pull request #4290 from lioncash/latest 
CMakeLists: Make use of /std:c++latest on MSVC
 2020-07-12 12:25:10 -04:00
bunnei f1aabc21ee
Merge pull request #3385 from Morph1984/batch-install 
frontend: Add support to batch install files to NAND
 2020-07-12 12:20:56 -04:00
Tobias 80a0f2a118
common/alignment: Fix compilation errors (#4303) 2020-07-12 16:45:49 +02:00
Morph fd1c3aa14e fs: Fix RomFS building when zero byte files are present 
When zero byte files are present, the key (offset) for that file is identical to the file right after. A std::map isn't able to fit key-value pairs with identical keys (offsets), therefore, the solution is to use std::multimap which permits multiple entries with the same key.

This most prominently fixes Pokemon Sword and Shield weather with any RomFS mod applied.
 2020-07-12 04:33:35 -04:00
bunnei e60733aad3
Merge pull request #4275 from CrazyMax/desired_language 
AM: fix GetDesiredLanguage:
 2020-07-12 01:45:08 -04:00
bunnei 5fb27f83cf
Merge pull request #4289 from ReinUsesLisp/dynfix 
vk_rasterizer: Pass <pSizes> to CmdBindVertexBuffers2EXT
 2020-07-11 23:44:03 -04:00
bunnei e706501c8d hle: service: mii: Rewrite service to properly support creation of random and default miis. 2020-07-11 21:34:59 -04:00
bunnei 1074c87f18
Revert "Port citra-emu/citra#5441: "Common: remove a mod from AlignUp"" 2020-07-11 19:28:09 -04:00
Marshall Mohror a4306b9e56 Common: remove a mod from AlignUp (#5441) 
In cases where the size is not a known constant when inlining, AlignUp<std::size_t> currently generates two 64-bit div instructions.
This generates one div and a cmov which is significantly cheaper.
 2020-07-11 18:39:00 +02:00
MerryMage da11a27f42 configure_cpu: Add tooltips 2020-07-11 16:38:38 +01:00
MerryMage 505aa3a4c1 configure_cpu: Show/Hide debugging options 2020-07-11 16:38:38 +01:00
FearlessTobi a59ad9246b main/profile_select: Don't prompt for profile selection when only one is available 2020-07-11 16:08:34 +02:00
MerryMage 0193202964 configuration: Add settings to enable/disable specific CPU optimizations 2020-07-11 14:34:09 +01:00
Lioncash fb0fefc75c CMakeLists: Make use of /std:c++latest on MSVC 
Provides the buildbot with one builder that is always tracking the
latest version of the C++ standard, allowing us to progressively rectify
our code and amend any differences between standards over time instead
of waiting for a complete standard change, potentially breaking a lot of
code all at once.
 2020-07-11 04:45:40 -04:00
bunnei a0ee597b19
Merge pull request #4203 from VolcaEM/services 
service: Update function tables
 2020-07-11 00:02:36 -04:00
bunnei a45a57641f
Merge pull request #4250 from Morph1984/key-writing 
KeyManager: Prevent writing of invalid keys
 2020-07-10 22:45:18 -04:00
ReinUsesLisp fca26980a2 vk_rasterizer: Pass <pSizes> to CmdBindVertexBuffers2EXT 
This has been fixed in Nvidia's public beta driver 451.74. The previous
beta driver will be broken, people using these will have to update.
 2020-07-10 18:15:32 -03:00
bunnei 995067538d
Merge pull request #4221 from jbeich/unused-qt-opengl 
cmake: drop dependency on QtOpenGL
 2020-07-10 15:18:04 -04:00
Ameer 042c6602a0 Break out of scan loop if can't find adapter on first run 2020-07-10 11:07:43 -04:00
ReinUsesLisp c574ab5aa1 video_core/textures: Add and use SwizzleSliceToVoxel, and minor style changes 
Change GOB sizes from free-functions to constexpr constants.

Add SwizzleSliceToVoxel, a function that swizzles a 2D array of pixels
into a 3D texture and use it for 3D copies.
 2020-07-10 04:09:32 -03:00
Morph 755506d404 vfs_real: Fix MoveFile 
The file wasn't closed prior to being renamed / moved, throwing an error that states "The process cannot access the file because it is being used by another process." Fix this by closing the file prior to a rename / move operation.

Fixes saving in Luigi's Mansion 3 and KATANA KAMI: A Way of the Samurai Story.
 2020-07-10 00:39:23 -04:00
Morph 7351ca8c75 KeyManager: Prevent writing of invalid keys 
If the keys are zero, don't write them to the autogenerated file.
 2020-07-10 00:39:00 -04:00
Morph 75a01475d1 Add additional empty check for the QStringList returned by the InstallDialog 2020-07-10 00:38:29 -04:00
Morph 6d8d7ebc66 Update the install and progress dialogs 
- Remove the overwrite files checkbox, it will always overwrite
- The progressbar now reflects the progress in terms of data transferred.
 2020-07-10 00:38:28 -04:00
Morph 7f4d96d873 Refactor batch installing files 
Key issues fixed:
- Progress dialog showing up as white/hanging/getting stuck/unresponsive.

Key changes:
- Progress dialog now shows progress as a function of all files instead of per nca within a file.
- Overwrite existing files will overwrite all files in the selection.
 2020-07-10 00:38:28 -04:00
Morph 4c269e5ced Add support for batch install to NAND 
This adds support to batch install files to NAND
 2020-07-10 00:38:28 -04:00
Morph b24b463c87 bis_factory: Set User NAND free space to be 1 MiB less than total. 2020-07-10 00:37:39 -04:00
Morph 17242a8865 sdmc_factory: Set the SDMC total size to 1 TiB 
We should not be limited by the SDMC's partition size, set this to 1 TiB. Hardware is limited to the max allowed by the MBR partition table which is 2 TiB.
 2020-07-10 00:37:39 -04:00
Morph 0373ead96e bis_factory: Use hardware default NAND partition sizes 
Sets the total space of user and system partitions to their hardware defaults.
Furthermore, return the total space as free space for the user partition to prevent it from reaching zero.
Some games like Bioshock 2 check for the available free space prior to save creation, and we should not be limited by arbitrary limits.
 2020-07-10 00:37:39 -04:00
Morph 47e26d7bc7 settings: Remove storage size options 2020-07-10 00:37:39 -04:00
David Marcec bd2feb6873 cmake: Fix libfmt linking errors 2020-07-10 14:04:06 +10:00
Rodrigo Locatti e73c53fad1
Merge pull request #4283 from lat9nq/fix-linux-nvidia-vulkan 
vk_stream_buffer: Prevent Vulkan crash in Linux on recent NVIDIA driver
 2020-07-10 00:18:44 -03:00
lat9nq 63d23835ef
configuration: implement per-game configurations (#4098) 
* Switch game settings to use a pointer

In order to add full per-game settings, we need to be able to tell yuzu to switch
to using either the global or game configuration. Using a pointer makes it easier
to switch.

* configuration: add new UI without changing existing funcitonality

The new UI also adds General, System, Graphics, Advanced Graphics,
and Audio tabs, but as yet they do nothing. This commit keeps yuzu
to the same functionality as originally branched.

* configuration: Rename files

These weren't included in the last commit. Now they are.

* configuration: setup global configuration checkbox

Global config checkbox now enables/disables the appropriate tabs in the game
properties dialog. The use global configuration setting is now saved to the
config, defaulting to true. This also addresses some changes requested in the PR.

* configuration: swap to per-game config memory for properties dialog

Does not set memory going in-game. Swaps to game values when opening the
properties dialog, then swaps back when closing it. Uses a `memcpy` to swap.
Also implements saving config files, limited to certain groups of configurations
so as to not risk setting unsafe configurations.

* configuration: change config interfaces to use config-specific pointers

When a game is booted, we need to be able to open the configuration dialogs
without changing the settings pointer in the game's emualtion. A new pointer
specific to just the configuration dialogs can be used to separate changes
to just those config dialogs without affecting the emulation.

* configuration: boot a game using per-game settings

Swaps values where needed to boot a game.

* configuration: user correct config during emulation

Creates a new pointer specifically for modifying the configuration while
emulation is in progress. Both the regular configuration dialog and the game
properties dialog now use the pointer Settings::config_values to focus edits to
the correct struct.

* settings: split Settings::values into two different structs

By splitting the settings into two mutually exclusive structs, it becomes easier,
as a developer, to determine how to use the Settings structs after per-game
configurations is merged. Other benefits include only duplicating the required
settings in memory.

* settings: move use_docked_mode to Controls group

`use_docked_mode` is set in the input settings and cannot be accessed from the
system settings. Grouping it with system settings causes it to be saved with
per-game settings, which may make transferring configs more difficult later on,
especially since docked mode cannot be set from within the game properties
dialog.

* configuration: Fix the other yuzu executables and a regression

In main.cpp, we have to get the title ID before the ROM is loaded, else the
renderer will reflect only the global settings and now the user's game specific
settings.

* settings: use a template to duplicate memory for each setting

Replaces the type of each variable in the Settings::Values struct with a new
class that allows basic data reading and writing. The new struct
Settings::Setting duplicates the data in memory and can manage global overrides
per each setting.

* configuration: correct add-ons config and swap settings when apropriate

Any add-ons interaction happens directly through the global values struct.
Swapping bewteen structs now also includes copying the necessary global configs
that cannot be changed nor saved in per-game settings. General and System config
menus now update based on whether it is viewing the global or per-game settings.

* settings: restore old values struct

No longer needed with the Settings::Setting class template.

* configuration: implement hierarchical game properties dialog

This sets the apropriate global or local data in each setting.

* clang format

* clang format take 2

can the docker container save this?

* address comments and style issues

* config: read and write settings with global awareness

Adds new functions to read and write settings while keeping the global state in
focus. Files now generated per-game are much smaller since often they only need
address the global state.

* settings: restore global state when necessary

Upon closing a game or the game properties dialog, we need to restore all global
settings to the original global state so that we can properly open the
configuration dialog or boot a different game.

* configuration: guard setting values incorrectly

This disables setting values while a game is running if the setting is
overwritten by a per game setting.

* config: don't write local settings in the global config

Simple guards to prevent writing the wrong settings in the wrong files.

* configuration: add comments, assume less, and clang format

No longer assumes that a disabled UI element means the global state is turned
off, instead opting to directly answer that question. Still however assumes a
game is running if it is in that state.

* configuration: fix a logic error

Should not be negated

* restore settings' global state regardless of accept/cancel

Fixes loading a properties dialog and causing the global config dialog to show
local settings.

* fix more logic errors

Fixed the frame limit would set the global setting from the game properties
dialog. Also strengthened the Settings::Setting member variables and simplified
the logic in config reading (ReadSettingGlobal).

* fix another logic error

In my efforts to guard RestoreGlobalState, I accidentally negated the IsPowered
condition.

* configure_audio: set toggle_stretched_audio to tristate

* fixed custom rtc and rng seed overwriting the global value

* clang format

* rebased

* clang format take 4

* address my own review

Basically revert unintended changes

* settings: literal instead of casting

"No need to cast, use 1U instead"
Thanks, Morph!

Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>

* Revert "settings: literal instead of casting
"

This reverts commit 95e992a87c898f3e882ffdb415bb0ef9f80f613f.

* main: fix status buttons reporting wrong settings after stop emulation

* settings: Log UseDockedMode in the Controls group

This should have happened when use_docked_mode was moved over to the controls group
internally. This just reflects this in the log.

* main: load settings if the file has a title id

In other words, don't exit if the loader has trouble getting a title id.

* use a zero

* settings: initalize resolution factor with constructor instead of casting

* Revert "settings: initalize resolution factor with constructor instead of casting"

This reverts commit 54c35ecb46a29953842614620f9b7de1aa9d5dc8.

* configure_graphics: guard device selector when Vulkan is global

Prevents the user from editing the device selector if Vulkan is the global
renderer backend. Also resets the vulkan_device variable when the users
switches back-and-forth between global and Vulkan.

* address reviewer concerns

Changes function variables to const wherever they don't need to be changed. Sets Settings::Setting to final as it should not be inherited from. Sets ConfigurationShared::use_global_text to static.

Co-Authored-By: VolcaEM <volcaem@users.noreply.github.com>

* main: load per-game settings after LoadROM

This prevents `Restart Emulation` from restoring the global settings *after* the per-game settings were applied. Thanks to BSoDGamingYT for finding this bug.

* Revert "main: load per-game settings after LoadROM"

This reverts commit 9d0d48c52d2dcf3bfb1806cc8fa7d5a271a8a804.

* main: only restore global settings when necessary

Loading the per-game settings cannot happen after the ROM is loaded, so we have to specify when to restore the global state. Again thanks to BSoD for finding the bug.

* configuration_shared: address reviewer concerns except operator overrides

Dropping operator override usage in next commit.

Co-Authored-By: LC <lioncash@users.noreply.github.com>

* settings: Drop operator overrides from Setting template

Requires using GetValue and SetValue explicitly. Also reverts a change that broke title ID formatting in the game properties dialog.

* complete rebase

* configuration_shared: translate "Use global configuration"

Uses ConfigurePerGame to do so, since its usage, at least as of now, corresponds with ConfigurationShared.

* configure_per_game: address reviewer concern

As far as I understand, it prevents the program from unnecessarily copying strings.

Co-Authored-By: LC <lioncash@users.noreply.github.com>

Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
Co-authored-by: VolcaEM <volcaem@users.noreply.github.com>
Co-authored-by: LC <lioncash@users.noreply.github.com>
 2020-07-09 22:42:09 -04:00
bunnei 0f60ccdde2
Merge pull request #4281 from RealJohnGalt/linkfix2 
cmake: fix fmt linking when found
 2020-07-09 22:11:38 -04:00
bunnei f9e748b721
Merge pull request #4248 from Morph1984/CreateManagedDisplaySeparableLayer 
AM/ISelfController: Stub CreateManagedDisplaySeparableLayer
 2020-07-09 22:09:42 -04:00
lat9nq 1c7d106aac vk_stream_buffer: set allocable_size to 9 MiB 
This solves the crash on Linux systems running the current Linux Long Lived branch nVidia driver.
 2020-07-09 21:28:32 -04:00
bunnei 83b1b259bd
Merge pull request #4202 from ReinUsesLisp/scoped-lock 
core_timing,scheduler: Use std::scoped_lock when possible
 2020-07-09 15:33:41 -04:00
John Galt 95cd2e17ab cmake: fix fmt linking when found 
This is a new attempt at #4206 that shouldn't break windows builds.

If someone else could test on windows, it would be much appreciated.
Previously, the build bot passed but the actual builds failed.
 2020-07-09 11:35:28 -04:00
Jan Beich 48ff15602e cmake: pass libusb include directory as well 
In file included from src/input_common/gcadapter/gc_adapter.cpp:8:
src/./input_common/gcadapter/gc_adapter.h:11:10: fatal error: 'libusb.h' file not found
 #include <libusb.h>
          ^~~~~~~~~~
 2020-07-09 15:26:54 +00:00
bunnei 77bdd09aa2
Merge pull request #4219 from ogniK5377/audio-timing 
audio: Improving audio timing for multicore/single core
 2020-07-08 22:07:17 -04:00
Ameer 4489ea6f53 Rebase to master, fix merge conflicts 2020-07-08 21:15:49 -04:00
bunnei 5311b562aa
Merge pull request #4266 from jbeich/freebsd 
gcadapter: unbreak build on FreeBSD
 2020-07-08 16:30:26 -04:00
bunnei 9c2773409a
Merge pull request #4255 from lioncash/copy 
configure_graphics: Prevent unnecessary string copies in UpdateDeviceComboBox()
 2020-07-08 16:28:10 -04:00
Ameer 3c7a115afe Address comments for better clarity/signed dev count 2020-07-08 14:18:54 -04:00
Ameer ec13746e4d Add more libusb error checks 2020-07-08 13:19:33 -04:00
CrazyMax cf76769026 AM: fix GetDesiredLanguage: 
try to get a control metadata from application update when is failed to get from the basic version.

Tested on Kirby Star Allies
 2020-07-08 19:45:06 +03:00
bunnei 4e2464a713
Merge pull request #4243 from CrazyMax/display_version 
AM: fix GetDisplayVersion
 2020-07-08 10:46:56 -04:00
bunnei 2a87ddcce2
Merge pull request #4245 from MerryMage/page-table-race 
memory: Race-condition in pagetables.
 2020-07-08 10:44:33 -04:00
ReinUsesLisp 2a9d17b7e7 maxwell_dma: Rename registers to match official docs and reorder 
Rename registers in the MaxwellDMA class to match Nvidia's official
documentation. This one can be found here:

https://github.com/NVIDIA/open-gpu-doc/blob/master/classes/dma-copy/clb0b5.h

While we are at it, reorganize the code in MaxwellDMA to be separated in
different functions.
 2020-07-07 19:19:33 -03:00
MerryMage e7c77b90c4 cpu_interrupt_handler: Remove #pragma once from .cpp file 2020-07-07 22:47:00 +01:00
Ameer b57475887b Address PR feedback, fix axis button thresholding 2020-07-07 12:20:59 -04:00
bunnei 35f7740b6c
Merge pull request #4150 from ReinUsesLisp/dynamic-state-impl 
vulkan: Use VK_EXT_extended_dynamic_state when available
 2020-07-07 10:58:09 -04:00
Jan Beich 1db10b8f4c input_common/gcadapter: add missing C++11 header required by libc++ 
In file included from src/input_common/gcadapter/gc_adapter.cpp:8:
src/./input_common/gcadapter/gc_adapter.h:77:10: error: no template named 'unordered_map' in namespace 'std'
    std::unordered_map<int, bool> buttons;
    ~~~~~^
src/./input_common/gcadapter/gc_adapter.h:78:10: error: no template named 'unordered_map' in namespace 'std'
    std::unordered_map<int, u16> axes;
    ~~~~~^
 2020-07-07 10:02:03 +00:00
Ameer e3253b5f18 Brace the code! Fix compile error due to class member construction order 2020-07-06 23:01:57 -04:00
Ameer 86abff48e1 Recalibrate reconnected controllers 2020-07-06 22:09:07 -04:00
Ameer 7ad423923d Save origin state of GC controller analog features, compare against origin for input detection 2020-07-06 21:58:31 -04:00
Ameer 40cf9288e9 change shortcut context for other hotkeys with file open dialog 2020-07-06 19:45:57 -04:00
CrazyMax 7bd3558c64 GetDisplayVersion should return a null-terminated version string. 
also, in case of failed to get of the basic version, we will try get it from application update.
 2020-07-07 02:04:24 +03:00
Ameer fa4d6df4c5 Fix ss crash on game menu, fix ss on windowed mode 2020-07-06 17:30:28 -04:00
Lioncash 4f678284e2 configure_graphics: Make use of qOverload in signals/slots 
While we're in the same area, we can make use of qOverload to tidy up
some function pointer casts.
 2020-07-06 09:07:21 -04:00
Lioncash be06b21f7b configure_graphics: Prevent unnecessary string copies in UpdateDeviceComboBox() 
Unlikely to impact performance at all, but this is essentially a "free"
transformation, so why not?
 2020-07-06 09:07:03 -04:00
MerryMage 76bd617b2d memory: Set page-table pointers before setting attribute = Memory 2020-07-05 12:54:19 +01:00
Morph c0dc8f9d25 AM/ISelfController: Stub CreateManagedDisplaySeparableLayer 
Stub this by sending 1 layer id instead of 2 as yuzu does not support multiple layers per display.
No adverse side effects have been observed.
- Used by Animal Crossing: New Horizons Update 1.3.0
 2020-07-05 06:26:21 -04:00
Fernando Sahmkow 52882a93a5
Merge pull request #4194 from ReinUsesLisp/fix-shader-cache 
shader_cache: Fix use-after-free and orphan invalidation cache entries
 2020-07-04 20:49:00 -04:00
Ameer f829932ed1 Fix merge conflicts? 2020-07-04 00:59:40 -04:00
Ameer d00972fce1 Fix for always firing triggers on some controllers, trigger threshold more universal 2020-07-04 00:40:48 -04:00
Rodrigo Locatti 3096adb347
Merge pull request #4218 from ogniK5377/opus-external 
externals: Track opus as submodule instead of using conan
 2020-07-04 01:32:54 -03:00
Ameer e69d715e3d Address lioncash feedback: Log formatting, extern const PadButtonArray, little touch ups 2020-07-03 11:52:07 -04:00
bunnei 41a333321a
Merge pull request #4175 from ReinUsesLisp/read-buffer 
gl_buffer_cache: Copy to buffers created as STREAM_READ before downloading
 2020-07-02 23:30:08 -04:00
bunnei 8a1cfcc8b7
Merge pull request #3924 from ogniK5377/GetKeyCodeMap 
Implement GetKeyCodeMap & GetKeyCodeMap2
 2020-07-02 23:03:20 -04:00
bunnei 98fcd3ba5d
Revert "cmake: fix fmt linking" 2020-07-02 22:53:12 -04:00
bunnei 064b7bfa5f
Merge pull request #4206 from RealJohnGalt/linkfix 
cmake: fix fmt linking
 2020-07-02 22:23:39 -04:00
bunnei b13fd9e65a
Merge pull request #4193 from ogniK5377/GetIndirectLayerConsumerHandle-stub 
am: Stub GetIndirectLayerConsumerHandle
 2020-07-02 21:31:20 -04:00
bunnei af787e451b
Merge pull request #4192 from ogniK5377/acc-ListOpenContextStoredUsers-stub 
acc: ListOpenContextStoredUsers partial stub
 2020-07-02 20:36:54 -04:00
Ameer 6e1639c7b0 Fix unnecessary diffs 2020-07-02 16:51:16 -04:00
Ameer 6b7c8e469b Add LR triggers as axes, half press to initiate a press, add GC axis id in config, clarify some code blocks for better readability 2020-07-02 15:54:44 -04:00
Rodrigo Locatti c58e21cd76
Merge pull request #4082 from Morph1984/mirror-once-clamp 
maxwell_to_gl: Implement MirrorOnceClampOGL wrap mode using GL_MIRROR_CLAMP_EXT
 2020-07-02 04:57:40 -03:00
VolcaEM 3f910efb40
Rename two functions in NS 
- Rename "GetShellEvent" to "GetShellEventHandle"
- Rename "LaunchApplicationFromHost" to "LaunchApplication"
 2020-07-02 09:02:55 +02:00
VolcaEM 38b585a309
Rename GetApplicationArea2 to GetApplicationAreaSize 2020-07-02 08:58:51 +02:00
Jan Beich b1b1ed7597 cmake: stop linking against QGL after c6a0ab9792 2020-07-01 22:11:39 +00:00
ReinUsesLisp f6cb128eac shader_cache: Fix use-after-free and orphan invalidation cache entries 
This fixes some cases where entries could have been removed multiple
times reading freed memory. To address this issue this commit removes
duplicates from entries marked for removal and sorts out the removal
process to fix another use-after-free situation.

Another issue fixed in this commit is orphan invalidation cache entries.
Previously only the entries that were invalidated in the current
operations had its entries removed. This led to more use-after-free
situations when these entries were actually invalidated but referenced
an object that didn't exist.
 2020-07-01 18:16:53 -03:00
Ameer 34a590e509 Reset adapter state on init, fixes errors relating driver hang from unexpected unplug 2020-07-01 12:52:50 -04:00
David Marcec 28aa697528 Don't handle cycles late if stretcher is active 
Timestretcher seems to be broken
 2020-07-01 16:59:42 +10:00
David Marcec 24c2930012 audio: Improving audio timing for multicore/single core 
Fixes the issue with needing the timestretcher for multicore.
 2020-07-01 16:52:02 +10:00
David 15a04fb704
Merge pull request #4217 from lioncash/prototype 
key_manager: Make use of canonical deleted operator=
 2020-07-01 16:13:14 +10:00
David Marcec d5dfe34c49 externals: Track opus as submodule instead of using conan 
Supersedes #4068 see for details.
 2020-07-01 15:09:33 +10:00
LC 0b954a3305
Merge pull request #4208 from jbeich/freebsd 
common: unbreak build on BSDs
 2020-07-01 00:34:20 -04:00
Lioncash fb13f053bb key_manager: Correct casing of instance() 
Our codebase uppercases member function names.
 2020-07-01 00:28:50 -04:00
Lioncash c91710a82f key_manager: Delete move operations 
Prevents the singleton from being moved from.
 2020-07-01 00:24:38 -04:00
Lioncash 00a1d106bd key_manager: Make use of canonical deleted operator= 
operator= typically returns a reference, it's not void.

While we're at it, we can correct the parameter formatting to adhere to the
codebase.
 2020-07-01 00:21:31 -04:00
David 3bb63bc0b3
Merge pull request #3967 from FearlessTobi/keys-singleton 
crypto: Make KeyManager a singleton class
 2020-07-01 14:16:26 +10:00
bunnei c6b0353c4d
Merge pull request #4153 from ogniK5377/prepo-multibuf 
prepo: : Don't read extra buffer from report unless passed
 2020-06-30 22:37:13 -04:00
bunnei 424540d9e8
Merge pull request #4063 from FreddyFunk/game-version-in-title 
Add game version to window title
 2020-06-30 21:42:33 -04:00
bunnei f1b1238e2d
Merge pull request #4166 from VolcaEM/quickstart-faq 
Add "Open Quickstart Guide" and "FAQ" buttons to the Help menu
 2020-06-30 19:03:47 -04:00
Jan Beich 3b1683a152 common: switch to nullptr for sysctl's empty new value 2020-06-30 23:00:18 +00:00
Ameer a76e11e7f0 Address feedback regarding increments, const vars, and general cleanup 2020-06-30 17:28:02 -04:00
Fernando Sahmkow a4f48efea4
Merge pull request #4176 from ReinUsesLisp/compatible-formats 
texture_cache: Check format compatibility before copying
 2020-06-30 15:36:13 -04:00
Fernando Sahmkow 977a3ab352
Merge pull request #4157 from ReinUsesLisp/unified-turing 
gl_device: Enable NV_vertex_buffer_unified_memory on Turing devices
 2020-06-30 14:36:51 -04:00
Ameer dfdf87d844 fix implicit conversion of size_t type to int 2020-06-30 11:44:55 -04:00
Morph 1b31755ba6 maxwell_to_gl: Implement MirrorOnceClampOGL using GL_MIRROR_CLAMP_EXT 
Like MirrorOnceBorder, this requires the GL_EXT_texture_mirror_clamp extension. This extension is unfortunately not available on Intel's drivers (both Windows proprietary and Linux Mesa). Use GL_MIRROR_CLAMP_TO_EDGE as a fallback if the extension is unavailable.
 2020-06-30 02:40:14 -04:00
Rodrigo Locatti d217017c9e
Merge pull request #4191 from Morph1984/vertex-formats 
maxwell_to_gl/vk: Reorder vertex formats
 2020-06-30 03:30:00 -03:00
David 7c970132b5
macro: Add support for "middle methods" on the code cache (#4112) 
Macro code is just uploaded sequentially from a starting address, however that does not mean the entry point for the macro is at that address. This PR adds preliminary support for executing macros in the middle of our cached code.
 2020-06-30 02:32:24 -03:00
bunnei fa8e35c49f
Merge pull request #4182 from Kewlan/fullscreen-hotkey-fix 
hotkeys: Fix issues caused when changing the fullscreen hotkey
 2020-06-29 23:11:57 -04:00
Jan Beich e6085ea35f common: add sysconf() fallback 
src/common/memory_detect.cpp:15:10: fatal error: 'sys/sysinfo.h' file not found
 #include <sys/sysinfo.h>
          ^~~~~~~~~~~~~~~
 2020-06-29 22:41:22 +00:00
Morph 10eca7f651 maxwell_to_gl: Rename VertexType() to VertexFormat() 2020-06-29 11:48:38 -04:00
John Galt 765e37aa35 cmake: fix fmt linking 
On gcc/ld, and clang/lld, fmt::v6 symbols are excluded, so linking
fails. This fixes the issue.

Note: This was included in the FindBoost changes I shared with
BlinkHawk, however only they were merged. I'm not sure if it was missed,
or if there was an issue with this part of the change.
 2020-06-29 07:10:07 -04:00
Rodrigo Locatti f84cbf6429
Merge pull request #4140 from ReinUsesLisp/validation-layers 
renderer_vulkan: Update validation layer name and test before enabling
 2020-06-29 02:12:38 -03:00
VolcaEM 86946ea13c
Remove duplicate functions 2020-06-29 04:22:38 +02:00
VolcaEM f3630a0713
Use decimal instead of hexadecimal 
Co-authored-by: David <25727384+ogniK5377@users.noreply.github.com>
 2020-06-29 04:21:10 +02:00
VolcaEM a0c499aef7
Fix typo 2020-06-29 04:12:36 +02:00
VolcaEM f2eead3b5b
Clang-format 2020-06-29 04:09:38 +02:00
VolcaEM 6a0010d0c6
service: Update function tables 2020-06-29 04:01:34 +02:00
ReinUsesLisp 8562b516c0 core_timing,scheduler: Use std::scoped_lock when possible 
Simplifies the cognitive load of procedures using locks and makes locks
safe against exceptions.
 2020-06-28 21:42:57 -03:00
bunnei b05795d704
Merge pull request #3955 from FernandoS27/prometheus-2b 
Remake Kernel Scheduling, CPU Management & Boot Management (Prometheus)
 2020-06-28 12:37:50 -04:00
David Marcec db824b59c8 ldr: Cleanup NRO & NRR structs 2020-06-28 20:54:37 +10:00
David d67c7d9a82
Merge pull request #4026 from VolcaEM/ldr 
ldr: Update NRR/NRO structs
 2020-06-28 20:46:42 +10:00
David 4a5f6c03b0
Merge pull request #4184 from VolcaEM/patch-9 
grc: Update function table
 2020-06-28 18:49:15 +10:00
David d3a306b7a6
Merge pull request #4185 from VolcaEM/patch-10 
lbl: Update function table
 2020-06-28 18:48:54 +10:00
David 477979dd43
Merge pull request #4186 from VolcaEM/patch-11 
ldn: Update function table
 2020-06-28 18:48:28 +10:00
David b478b61dcf
Merge pull request #4187 from VolcaEM/patch-12 
mig: Update function table
 2020-06-28 18:48:15 +10:00
David 00aa9f6a53
Merge pull request #4188 from VolcaEM/patch-13 
mm: Update function table
 2020-06-28 18:47:55 +10:00
David 26e243d2d7
Merge pull request #4189 from VolcaEM/patch-14 
ncm: Update function table
 2020-06-28 18:47:27 +10:00
David bd590895cf
Merge pull request #4190 from VolcaEM/patch-15 
nfc: Update function table
 2020-06-28 18:47:07 +10:00
David e978f05ed1
Merge pull request #4183 from VolcaEM/patch-8 
friend: Update function table
 2020-06-28 18:46:40 +10:00
Morph 4a35df337b maxwell_to_vk: Reorder vertex formats and add A2B10G10R10 for all types except float 2020-06-28 02:57:10 -04:00
David Marcec dcf345febe am: Stub GetIndirectLayerConsumerHandle 
Needed by Monster Hunter Generations Ultimate
 2020-06-28 16:51:28 +10:00
Morph 78d80d99a0 maxwell_to_gl: Add 32 bit component sizes to (un)signed scaled formats 
Add 32 bit component sizes to (un)signed scaled formats and group (un)signed normalized, scaled, and integer formats together.
 2020-06-28 02:51:13 -04:00
David Marcec f0baf2abf2 acc: ListOpenContextStoredUsers partial stub 
Needed by Baldur's Gate 1/2
 2020-06-28 16:44:36 +10:00
Fernando Sahmkow 2f8947583f Core/Common: Address Feedback. 2020-06-27 18:20:06 -04:00
Fernando Sahmkow e486c66850 NvFlinger: Clang Format. 2020-06-27 11:36:30 -04:00
Fernando Sahmkow 626cc44d7a Build System: Fix GCC & MINGW Build. 2020-06-27 11:36:28 -04:00
Fernando Sahmkow 4105f38022 SVC: Implement 32-bits wrappers and update Dynarmic. 2020-06-27 11:36:27 -04:00
Fernando Sahmkow ce350e7ce0 SVC: Add GetCurrentProcessorNumber32, CreateTransferMemory32, SetMemoryAttribute32 2020-06-27 11:36:27 -04:00
Fernando Sahmkow b8df61c642 ARM: Update Dynarmic and Setup A32 according to latest interface. 2020-06-27 11:36:26 -04:00
Fernando Sahmkow 22ceaca2f4 SVC: Add GetThreadPriority32 & SetThreadPriority32 2020-06-27 11:36:25 -04:00
Fernando Sahmkow ec11918323 ArmDynarmic32: Setup CNTPCT correctly 2020-06-27 11:36:24 -04:00
Fernando Sahmkow e3d561fb84 Audio: Correct buffer release for host timing. 2020-06-27 11:36:23 -04:00
Fernando Sahmkow 7fd7d05838 Common/Kernel: Corrections and small bug fixing. 2020-06-27 11:36:21 -04:00
Fernando Sahmkow 272a87127a Services/NvFlinger: Do vSync in a sepparate thread on Multicore. 2020-06-27 11:36:20 -04:00
Fernando Sahmkow 3165152396 Common/NativeClockx86: Reduce native clock accuracy further. 2020-06-27 11:36:18 -04:00
Fernando Sahmkow 71c4779211 Tests/CoreTiming: Correct host timing tests. 2020-06-27 11:36:17 -04:00
Fernando Sahmkow 0a8013d71e ARMDynarmicInterface: Correct GCC Build Errors. 2020-06-27 11:36:17 -04:00
Fernando Sahmkow 7b1804dab4 Common/AtomicOps: Correct GCC Intrinsic argument ordering. 2020-06-27 11:36:16 -04:00
Fernando Sahmkow d240143588 Kernel: Correct Host Context on Threads and Scheduler. 2020-06-27 11:36:15 -04:00
Fernando Sahmkow 0e4c35c591 YuzuQT: Hide Speed UI on Multicore. 2020-06-27 11:36:14 -04:00
Fernando Sahmkow 467d43570e Clang Format. 2020-06-27 11:36:14 -04:00
Fernando Sahmkow 3714f2e471 ARMInterface/Externals: Update dynarmic and fit to latest version. 2020-06-27 11:36:13 -04:00
Fernando Sahmkow dda6147b0d ARMInterface: Correct rebase errors. 2020-06-27 11:36:12 -04:00
Fernando Sahmkow 71f1c0f9f9 CoreTiming: Correct rebase bugs and other miscellaneous things. 2020-06-27 11:36:11 -04:00
Fernando Sahmkow cdf900f1e3 Core: Split Microprofile Dynarmic timing per Core 2020-06-27 11:36:10 -04:00
Fernando Sahmkow 528b19a842 General: Tune the priority of main emulation threads so they have higher priority than less important helper threads. 2020-06-27 11:36:09 -04:00
Fernando Sahmkow 7b44187fd2 Dynarmic Interface: don't clear cache if JIT has not been created. 2020-06-27 11:36:08 -04:00
Fernando Sahmkow ad92865497 General: Correct rebase, sync gpu and context management. 2020-06-27 11:36:08 -04:00
Fernando Sahmkow bfb5244cf8 CoreTiming/CycleTimer: Correct Idling. 2020-06-27 11:36:07 -04:00
Fernando Sahmkow bece52cd81 SingleCore: Correct ticks reset to be on preemption. 2020-06-27 11:36:06 -04:00
Fernando Sahmkow 48fa3b7a0f General: Cleanup legacy code. 2020-06-27 11:36:05 -04:00
Fernando Sahmkow c8bf47dcfb Kernel/svcBreak: Implement CacheInvalidation for Singlecore and correct svcBreak. 2020-06-27 11:36:04 -04:00
Fernando Sahmkow 54e304fe2a Bootmanager/CPU_Manager: Correct shader caches and sync GPU on OpenGL. 2020-06-27 11:36:03 -04:00
Fernando Sahmkow 19165cd859 HLE_IPC: Correct HLE Event behavior on timeout. 2020-06-27 11:36:03 -04:00
Fernando Sahmkow 7e2ce2f7f4 SingleCore: Improve Cycle timing Behavior and replace mutex in global scheduler for spinlock. 2020-06-27 11:36:02 -04:00
Fernando Sahmkow a7ecd9e19c FrameLimiting: Enable frame limiting for single core. 2020-06-27 11:36:01 -04:00
Fernando Sahmkow f5e32935ca SingleCore: Use Cycle Timing instead of Host Timing. 2020-06-27 11:36:01 -04:00
Fernando Sahmkow 9bde28d7b1 Scheduler: Correct Reload/Unload 2020-06-27 11:35:59 -04:00
Fernando Sahmkow 5974e3ea33 Thread: Release the ARM Interface on exitting. 2020-06-27 11:35:58 -04:00
Fernando Sahmkow 1567824d2d General: Move ARM_Interface into Threads. 2020-06-27 11:35:58 -04:00
Fernando Sahmkow 1b82ccec22 Core: Refactor ARM Interface. 2020-06-27 11:35:56 -04:00
Fernando Sahmkow 534466754f X64 Clock: Reduce accuracy to be less or equal to guest accuracy. 2020-06-27 11:35:55 -04:00
Fernando Sahmkow 7b18174eef ARM/WaitTree: Better track the CallStack for each thread. 2020-06-27 11:35:54 -04:00
Fernando Sahmkow 87c49aa7be SVC/ARM: Correct svcSendSyncRequest and cache ticks on arm interface. 2020-06-27 11:35:53 -04:00
Fernando Sahmkow f2ade343e2 SingleCore: Move Host Timing from a sepparate thread to main cpu thread. 2020-06-27 11:35:52 -04:00
Fernando Sahmkow 5d3a2be04f GUI: Make multicore only work with Async and add GUI for multicore. 2020-06-27 11:35:52 -04:00
Fernando Sahmkow 25565dffd5 ARM: Addapt to new Exclusive Monitor Interface. 2020-06-27 11:35:50 -04:00
Fernando Sahmkow 1a5f2e290b CPU_Manager: Correct stopping on SingleCore. 2020-06-27 11:35:49 -04:00
Fernando Sahmkow db68fba4a6 Scheduler: Correct yielding interaction with SetThreadActivity. 2020-06-27 11:35:49 -04:00
Fernando Sahmkow 7020d498c5 General: Fix microprofile on dynarmic/svc, fix wait tree showing which threads were running. 2020-06-27 11:35:48 -04:00
Fernando Sahmkow e6f8bde74b General: Fix Stop function 2020-06-27 11:35:47 -04:00
Fernando Sahmkow f370de84b1 Kernel: Rewind on SVC change. 2020-06-27 11:35:46 -04:00
Fernando Sahmkow d494b074e8 Kernel: Preempt Single core on redudant yields. 2020-06-27 11:35:45 -04:00
Fernando Sahmkow a439cdf22e CPU_Manager: Unload/Reload threads on preemption on SingleCore 2020-06-27 11:35:43 -04:00
Fernando Sahmkow 8a78fc2580 Synchronization: Correct wide Assertion. 2020-06-27 11:35:43 -04:00
Fernando Sahmkow ab9aae28bf General: Initial Setup for Single Core. 2020-06-27 11:35:42 -04:00
Fernando Sahmkow 391f5f360d Scheduler: Set last running time on thread. 2020-06-27 11:35:41 -04:00
Fernando Sahmkow 9e9c287f8b Kernel: Corrections to TimeManager, Scheduler and Mutex. 2020-06-27 11:35:40 -04:00
Fernando Sahmkow 6515c6e8c6 Kernel: Fixes, corrections and asserts to scheduler and different svcs. 2020-06-27 11:35:40 -04:00
Fernando Sahmkow 4217e58a10 Scheduler: Correct yields. 2020-06-27 11:35:39 -04:00
Fernando Sahmkow 445b4342b3 Mutex: Revert workaround due to poor exclusive memory. 2020-06-27 11:35:38 -04:00
Fernando Sahmkow cd1c38be8d ARM/Memory: Correct Exclusive Monitor and Implement Exclusive Memory Writes. 2020-06-27 11:35:37 -04:00
Fernando Sahmkow 535c542d84 SVC: WaitSynchronization add Termination Pending Result. 2020-06-27 11:35:36 -04:00
Fernando Sahmkow 725bac1404 Scheduler: Remove arm_interface lock and a few corrections. 2020-06-27 11:35:35 -04:00
Fernando Sahmkow 38c6c497f6 Yuzu/Debuggers: Correct Wait Tree for Paused threads. 2020-06-27 11:35:34 -04:00
Fernando Sahmkow 83c7ba1ef7 SVC: Correct SetThreadActivity. 2020-06-27 11:35:33 -04:00
Fernando Sahmkow a66c61ca2d SCC: Small corrections to CancelSynchronization 2020-06-27 11:35:33 -04:00
Fernando Sahmkow 44cb9997b3 Scheduler: Correct locking for hle threads. 2020-06-27 11:35:32 -04:00
Fernando Sahmkow 6ed28e15fa Scheduler: Fix HLE Threads on guard 2020-06-27 11:35:31 -04:00
Fernando Sahmkow 3de33348e4 Scheduler: Protect on closed threads. 2020-06-27 11:35:31 -04:00
Fernando Sahmkow 19847d4d42 Scheduler: Correct assert. 2020-06-27 11:35:30 -04:00
Fernando Sahmkow a33fbaddec Core: Correct rebase. 2020-06-27 11:35:29 -04:00
Fernando Sahmkow 1c672128c4 Scheduler: Release old thread fiber before trying to switch to the next thread fiber. 2020-06-27 11:35:28 -04:00
Fernando Sahmkow c43e559734 NVDRV: Remove frame limiting as Host Timing already takes care. 2020-06-27 11:35:28 -04:00
Fernando Sahmkow a6bce296ad Mutex: Correct Result writting to clear exclusivity. 2020-06-27 11:35:26 -04:00
Fernando Sahmkow e4b175ade2 SVC: Correct svcWaitForAddress and svcSignalToAddress. 2020-06-27 11:35:25 -04:00
Fernando Sahmkow 1e987dbe8d Scheduler: Correct Select Threads Step 2. 2020-06-27 11:35:24 -04:00
Fernando Sahmkow 07993ac8c8 Kernel: Corrections to Scheduling. 2020-06-27 11:35:23 -04:00
Fernando Sahmkow b4dc01f16a Kernel: Correct Signal on Thread Death and Setup Sync Objects on Thread for Debugging 2020-06-27 11:35:23 -04:00
Fernando Sahmkow 75e10578f1 Core: Correct HLE Event Callbacks and other issues. 2020-06-27 11:35:22 -04:00
Fernando Sahmkow de5b521c09 Process: Protect TLS region and Modules. 2020-06-27 11:35:21 -04:00
Fernando Sahmkow 2a8837ff51 General: Add Asserts 2020-06-27 11:35:21 -04:00
Fernando Sahmkow 04e0f8776c General: Add better safety for JIT use. 2020-06-27 11:35:20 -04:00
Fernando Sahmkow bd36eaf15d SVC: Correct races on physical core switching. 2020-06-27 11:35:19 -04:00
Fernando Sahmkow cc3aa95926 NVFlinger: Lock race condition between CPU, Host Timing, VSync. 2020-06-27 11:35:18 -04:00
Fernando Sahmkow 3902067008 SVC: Add locks to the memory management. 2020-06-27 11:35:18 -04:00
Fernando Sahmkow d4ebb510a0 SVC: Correct WaitSynchronization, WaitProcessWideKey, SignalProcessWideKey. 2020-06-27 11:35:17 -04:00
Fernando Sahmkow 5b6a67f849 SVC: Cleanup old methods. 2020-06-27 11:35:16 -04:00
Fernando Sahmkow 3d9fbb8226 CPU_Manager: Reconfigre guest threads for dynamrmic downsides 2020-06-27 11:35:15 -04:00
Fernando Sahmkow 15a79eb0d7 SVC: Correct SendSyncRequest. 2020-06-27 11:35:14 -04:00
Fernando Sahmkow 203e706302 SVC: Correct ArbitrateUnlock 2020-06-27 11:35:14 -04:00
Fernando Sahmkow 3b5b950c89 SVC: Correct SignalEvent, ClearEvent, ResetSignal, WaitSynchronization, CancelSynchronization, ArbitrateLock 2020-06-27 11:35:13 -04:00
Fernando Sahmkow ef4afa9760 SVC: Remove global HLE Lock. 2020-06-27 11:35:13 -04:00
Fernando Sahmkow 589f9cf108 SVC: Correct GetThreadPriority, SetThreadPriority, GetThreadCoreMask, SetThreadCoreMask, GetCurrentProcessorNumber 2020-06-27 11:35:12 -04:00
Fernando Sahmkow 49ba563995 SVC: Correct CreateThread, StartThread, ExitThread, SleepThread. 2020-06-27 11:35:11 -04:00
Fernando Sahmkow 18dcb09342 HostTiming: Pause the hardware clock on pause. 2020-06-27 11:35:10 -04:00
Fernando Sahmkow 6bf137a0e8 AudioCore: Use nanoseconds instead of cycles for buffer time. 2020-06-27 11:35:10 -04:00
Fernando Sahmkow dc58058203 General: Setup yuzu threads' microprofile, naming and registry. 2020-06-27 11:35:09 -04:00
Fernando Sahmkow a5c58a25ef CPU_Manager: remove debugging code. 2020-06-27 11:35:08 -04:00
Fernando Sahmkow 9e4b9f1afd YuzuCMD/Tester: Correct execution 2020-06-27 11:35:07 -04:00
Fernando Sahmkow e31425df38 General: Recover Prometheus project from harddrive failure 
This commit: Implements CPU Interrupts, Replaces Cycle Timing for Host 
Timing, Reworks the Kernel's Scheduler, Introduce Idle State and 
Suspended State, Recreates the bootmanager, Initializes Multicore 
system.
 2020-06-27 11:35:06 -04:00
David 0ea4a8bcc4
Merge pull request #3396 from FernandoS27/prometheus-1 
Implement SpinLocks, Fibers and a Host Timer
 2020-06-28 01:34:07 +10:00
VolcaEM 23515e0ccc
nfc: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/NFC_services
 2020-06-27 13:09:36 +02:00
VolcaEM c56414b80d
ncm: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/NCM_services

ILocationResolver's 16, 17, 18 and 19 have unofficial names
 2020-06-27 13:05:22 +02:00
VolcaEM b829643946
mm: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/Display_services
 2020-06-27 12:59:01 +02:00
VolcaEM 5219424226
mig: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/Migration_services
 2020-06-27 12:53:59 +02:00
VolcaEM b9be484a51
ldn: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/LDN_services
 2020-06-27 12:50:56 +02:00
VolcaEM a8d17adb7c
Oops (fix typo) 2020-06-27 12:45:42 +02:00
VolcaEM 73b035d2e2
lbl: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/Backlight_services
 2020-06-27 12:43:33 +02:00
VolcaEM 64fa9b9f57
grc: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/GRC_services
 2020-06-27 12:41:21 +02:00
VolcaEM af88767508
friend: Update function table 2020-06-27 12:39:10 +02:00
Kewlan 323eb86c9f Fix issues caused when changing the fullscreen hotkey 2020-06-27 11:30:32 +02:00
bunnei 6205965df9
Merge pull request #4097 from kevinxucs/kevinxucs/device-pixel-scaling-float 
Fix framebuffer size on fractional scaling display
 2020-06-27 02:49:07 -04:00
bunnei 9eaccac674
Merge pull request #4164 from Kewlan/mute-audio-hotkey 
hotkeys: Add a "Mute Audio" hotkey
 2020-06-27 02:47:13 -04:00
bunnei 6f16f54f10
Merge pull request #4158 from Morph1984/caps 
caps: Use enum classes and check struct sizes on compile time
 2020-06-27 00:09:32 -04:00
Ameer J bd697bef03
left const auto&, comment punctuation. 
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
 2020-06-26 23:46:49 -04:00
bunnei a91f92a89d
Merge pull request #4152 from ogniK5377/ipc-err 
Mark invalid IPC buffers as ASSERT_OR_EXECUTE_MSG
 2020-06-26 23:37:19 -04:00
bunnei 705cccb1e4
Merge pull request #4154 from ogniK5377/swkbd-nullptr 
Prevent nullptr dereference on swkbd error case
 2020-06-26 23:25:04 -04:00
bunnei efef7b1517
Merge pull request #4147 from ReinUsesLisp/hset2-imm 
shader/half_set: Implement HSET2_IMM
 2020-06-26 23:14:56 -04:00
David b32b7c6e74
Merge pull request #4178 from VolcaEM/patch-6 
es: Update function table
 2020-06-27 13:05:12 +10:00
VolcaEM 2d82b7f1a1
Use better names for "Unknown"s 2020-06-27 02:48:29 +02:00
VolcaEM bc51a9365b
Update function names 2020-06-27 02:43:22 +02:00
David Marcec 0b23ce6ef2 btm: Give better names for unknown functions 2020-06-27 10:42:46 +10:00
VolcaEM 032b7d490d
btdrv: Update function table (#4174) 
* btdrv: Update function table
 2020-06-26 20:34:29 -04:00
VolcaEM 6e14edbcc2
bpc: Update function tables (#4173) 
* bpc: Update function tables

This was based on Switchbrew page: https://switchbrew.org/wiki/PCV_services
 2020-06-26 20:33:55 -04:00
VolcaEM e6fee39ae7
bcat: Update function tables and add missing classes (#4172) 
* bcat: Update function tables and add missing classes
 2020-06-26 20:33:25 -04:00
VolcaEM ca25a3845e
am: Update function tables and add missing classes (#4169) 
* am: Update function tables and add missing classes

* Remove comments (1/5)

* Remove comments (2/5)

* Remove comments (3/5)

* Remove comments (4/5)

* Remove comments (5/5)

* Remove unused classes (1/2)

* Remove unused classes (2/2)
 2020-06-26 20:32:26 -04:00
VolcaEM b5d54619cc
aoc: Update function table (#4170) 
* aoc: Update function table

* Remove comments
 2020-06-26 20:31:44 -04:00
LC 98bbab8030
Merge pull request #4177 from VolcaEM/patch-5 
btm: Update function tables
 2020-06-26 20:30:59 -04:00
VolcaEM 0f4a611129
eupld: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/Error_Upload_services
 2020-06-27 02:25:04 +02:00
VolcaEM 3828aa4927
es: Update function table 
This was based on Switchbrew page: https://switchbrew.org/wiki/ETicket_services
 2020-06-27 02:17:51 +02:00
VolcaEM b1f4de7874
Update FAQ function name (2/2) 2020-06-27 02:14:29 +02:00
VolcaEM db96b5ee3b
Update FAQ function name (1/2) 2020-06-27 02:13:34 +02:00
VolcaEM d3e9b45ce0
btm: Update function tables 
This was based on Switchbrew page: https://switchbrew.org/wiki/BTM_services

"No comment" edition
 2020-06-27 01:57:48 +02:00
ReinUsesLisp 9d55e5586f vk_rasterizer: Use nullptr for <pSizes> in CmdBindVertexBuffers2EXT 
Disable this temporarily.
 2020-06-26 20:57:22 -03:00
ReinUsesLisp 8584a77eb2 vk_pipeline_cache: Avoid hashing and comparing dynamic state when possible 
With extended dynamic states, some bytes don't have to be collected from
the pipeline key, hence we can avoid hashing and comparing them on
lookups.
 2020-06-26 20:57:22 -03:00
ReinUsesLisp 1a84209418 vulkan/fixed_pipeline_state: Move state out of individual structures 2020-06-26 20:57:22 -03:00
ReinUsesLisp c94b398f14 vk_rasterizer: Use VK_EXT_extended_dynamic_state 2020-06-26 20:57:22 -03:00
ReinUsesLisp a6db8e5f4d renderer_vulkan/wrapper: Add VK_EXT_extended_dynamic_state functions 2020-06-26 20:55:15 -03:00
ReinUsesLisp c387a72c76 fixed_pipeline_state: Add requirements for VK_EXT_extended_dynamic_state 
This moves dynamic state present in VK_EXT_extended_dynamic_state to a
separate structure in FixedPipelineState. This is structure is at the
bottom allowing us to hash and memcmp only when the extension is not
supported.
 2020-06-26 20:55:15 -03:00
ReinUsesLisp 7527402a46 vk_device: Enable VK_EXT_extended_dynamic_state when available 2020-06-26 20:55:15 -03:00
ReinUsesLisp bb2cbdf704 texture_cache: Test format compatibility before copying 
Avoid illegal copies. This intercepts the last step of a copy to avoid
generating validation errors or corrupting the driver on some instances.

We can create views and emit copies accordingly in future commits and
remove this last-step validation.
 2020-06-26 20:52:22 -03:00
bunnei 3579db425e
Merge pull request #4144 from FernandoS27/tt-fix 
TextureCache: Fix case where layer goes off bound.
 2020-06-26 19:02:39 -04:00
bunnei 78d3b54ea7
Merge pull request #4111 from ReinUsesLisp/preserve-contents-vk 
vk_rasterizer: Don't preserve contents on full screen clears
 2020-06-26 18:48:12 -04:00
ReinUsesLisp 1d6be9febf video_core/compatible_formats: Table to test if two formats are legal to view or copy 
Add a flat table to test if it's legal to create a texture view between
two formats or copy betweem them.

This table is based on ARB_copy_image and ARB_texture_view. Copies are
more permissive than views.
 2020-06-26 19:28:11 -03:00
ReinUsesLisp 6481d91e4a gl_buffer_cache: Copy to buffers created as STREAM_READ before downloading 
After marking buffers as resident, Nvidia's driver seems to take a
slow path. To workaround this issue, copy to a STREAM_READ buffer and
then call GetNamedBufferSubData on it.

This is a temporary solution until we have asynchronous flushing.
 2020-06-26 16:58:40 -03:00
VolcaEM 9e1975a166
Update function name again 2020-06-26 18:51:12 +02:00
VolcaEM 0b86c7eb6a
Update function name (2/2) 2020-06-26 18:50:28 +02:00
VolcaEM f8247826fa
Update function name (1/2) 2020-06-26 18:49:57 +02:00
Fernando Sahmkow 7b893c7963 Common: Fix non-conan build 2020-06-26 12:25:19 -04:00
Morph 72f14ae21f caps_u: Fix GetAlbumContentsFileListForApplication stub 2020-06-26 08:35:21 -04:00
Morph 3017be7855 caps: Use enum classes and check struct sizes on compile time 2020-06-26 08:35:21 -04:00
Morph 02a33feef4 caps: Update copyright headers 
Updated to "yuzu Emulator Project"
 2020-06-26 08:35:21 -04:00
Kewlan 3eb8efc095 Add a "Mute Audio" hotkey 2020-06-26 06:03:29 +02:00
bunnei c4fe83a7bc
Merge pull request #4159 from ogniK5377/mem-manager-dumb-assert 
memory_manager: Remove useless assertion
 2020-06-25 22:53:13 -04:00
Rodrigo Locatti 5872fc21fe
Merge pull request #4151 from ReinUsesLisp/gl-invalidations 
gl_shader_cache: Avoid use after move for program size
 2020-06-25 21:05:27 -03:00
Ameer J ecbc813711
const& to button in button array 
Co-authored-by: VolcaEM <63682805+VolcaEM@users.noreply.github.com>
 2020-06-25 19:46:50 -04:00
Ameer 3f739514e3 Stop reading loop if error is encountered 2020-06-25 19:31:51 -04:00
VolcaEM 7d08d548a9
Clang-format again 2020-06-25 23:44:41 +02:00
VolcaEM b9f0b9dd06
Clang-format 2020-06-25 23:40:53 +02:00
VolcaEM 6582857356
Remove unnecessary newline 2020-06-25 23:38:38 +02:00
VolcaEM 0f4512291a
Merge branch 'master' into quickstart-faq 2020-06-25 23:34:37 +02:00
VolcaEM a46df40939
Fix typo 2: electric boogaloo 2020-06-25 23:32:43 +02:00
VolcaEM 9e7ac6a009
Use QUrl (2/2) 2020-06-25 23:31:01 +02:00
VolcaEM 5c6adea222
Use QUrl (1/2) 2020-06-25 23:28:38 +02:00
VolcaEM 04497d9e4a
Fix formatting 2020-06-25 23:18:54 +02:00
VolcaEM 5f6e44552a
Fix typo 2020-06-25 23:07:58 +02:00
VolcaEM 57b93395a8
Add "Open Quickstart Guide" and "FAQ" buttons to the Help menu 
While we're at it, also refactor the function used by OnOpenModsPage to be compatible with other URLs
 2020-06-25 23:02:33 +02:00
bunnei a980b4cbc1
Merge pull request #4136 from VolcaEM/mods 
Add a "Open Mods Page" button to the GUI
 2020-06-25 15:10:18 -04:00
Rodrigo Locatti ae1f709658
Merge pull request #4160 from ogniK5377/IsASTCSupported-fix 
gl_device: Fix IsASTCSupported to scan all targets instead of just GL_TEXTURE_2D
 2020-06-25 15:58:09 -03:00
David d11baf8bf8
Merge pull request #4141 from Morph1984/SevenSixAxisSensor 
hid: Stub a series of "SevenSixAxisSensor" service commands
 2020-06-25 19:37:39 +10:00
David Marcec a927d8be52 gl_device: Fix IsASTCSupported 
Other targets were never actually checked
 2020-06-25 19:12:56 +10:00
David Marcec 38868e5750 memory_manager: Remove useless assertion 
num_pages is an std::size_t. It will always be >= 0
 2020-06-25 16:35:58 +10:00
ReinUsesLisp bc8d3b8f82 gl_device: Enable NV_vertex_buffer_unified_memory on Turing devices 
Once we make sure not to corrupt Nvidia's driver, we can safely use
resident buffers on Turing devices.

See GitHub pull request #4156
 2020-06-25 01:28:47 -03:00
Morph 2c9308954c hid: Stub a series of "SevenSixAxisSensor" service commands 
- Used by Captain Toad: Treasure Tracker Update 1.3.0

While we're at it, fix the input parameters for SetIsPalmaAllConnectable and SetPalmaBoostMode
 2020-06-24 11:57:39 -04:00
bunnei 0e1268e507
Merge pull request #4105 from ReinUsesLisp/resident-buffers 
gl_rasterizer: Use NV_vertex_buffer_unified_memory for vertex buffer robustness
 2020-06-24 11:40:30 -04:00
Ameer c18dc9c707 padbutton enum class and struct initiailization 2020-06-24 11:39:30 -04:00
bunnei 2f2df9a4a7
Merge pull request #4083 from Morph1984/B10G11R11F 
decode/image: Implement B10G11R11F
 2020-06-24 11:02:38 -04:00
David Marcec 510838759f Prevent nullptr dereference on swkbd error case 2020-06-25 00:25:15 +10:00
David Marcec 2f0b322e72 prepo: : Don't read extra buffer from report unless passed 
Prepo doesn't always pass a secondary buffer, we assume it always does which leads to a bad read.
 2020-06-24 23:01:00 +10:00
Fernando Sahmkow 32343d820d
Merge pull request #4046 from ogniK5377/macro-hle-prod 
Add support for HLEing Macros
 2020-06-24 09:01:00 -04:00
David Marcec 82ecdd0104 Mark invalid IPC buffers as ASSERT_OR_EXECUTE_MSG 
Previously if applications would send faulty buffers(example homebrew) it would lead to us returning uninitalized data. Switching from ASSERT_MSG to ASSERT_OR_EXECUTE_MSG allows us to have a fail safe to prevent crashes but also continue execution without introducing undefined behavior
 2020-06-24 22:50:27 +10:00
ReinUsesLisp 32a2dcd415 buffer_cache: Use buffer methods instead of cache virtual methods 2020-06-24 02:36:14 -03:00
ReinUsesLisp 39c97f1b65 gl_stream_buffer: Use InvalidateBufferData instead unmap and map 
Making the stream buffer resident increases GPU usage significantly on
some games. This seems to be addressed invalidating the stream buffer
with InvalidateBufferData instead of using a Unmap + Map (with
invalidation flags).
 2020-06-24 02:36:14 -03:00
ReinUsesLisp 41a4090320 gl_rasterizer: Use NV_vertex_buffer_unified_memory for vertex buffer robustness 
Switch games are allowed to bind less data than what they use in a
vertex buffer, the expected behavior here is that these values are read
as zero. At the moment of writing this only D3D12, OpenGL and NVN through
NV_vertex_buffer_unified_memory support vertex buffer with a size limit.

In theory this could be emulated on Vulkan creating a new VkBuffer for
each (handle, offset, length) tuple and binding the expected data to it.
This is likely going to be slow and memory expensive when used on the
vertex buffer and we have to do it on all draws because we can't know
without analyzing indices when a game is going to read vertex data out
of bounds.

This is not a problem on OpenGL's BufferAddressRangeNV because it takes
a length parameter, unlike Vulkan's CmdBindVertexBuffers that only takes
buffers and offsets (the length is implicit in VkBuffer). It isn't a
problem on D3D12 either, because D3D12_VERTEX_BUFFER_VIEW on
IASetVertexBuffers takes SizeInBytes as a parameter (although I am not
familiar with robustness on D3D12).

Currently this only implements buffer ranges for vertex buffers,
although indices can also be affected. A KHR_robustness profile is not
created, but Nvidia's driver reads out of bound vertex data as zero
anyway, this might have to be changed in the future.

- Fixes SMO random triangles when capturing an enemy, getting hit, or
looking at the environment on certain maps.
 2020-06-24 02:36:14 -03:00
ReinUsesLisp 32485917ba gl_buffer_cache: Mark buffers as resident 
Make stream buffer and cached buffers as resident and query their
address. This allows us to use GPU addresses for several proprietary
Nvidia extensions.
 2020-06-24 02:36:14 -03:00
ReinUsesLisp 73fb3a304b gl_device: Expose NV_vertex_buffer_unified_memory except on Turing 
Expose NV_vertex_buffer_unified_memory when the driver supports it.

This commit adds a function the determine if a GL_RENDERER is a Turing
GPU. This is required because on Turing GPUs Nvidia's driver crashes
when the buffer is marked as resident or on DeleteBuffers. Without a
synchronous debug output (single threaded driver), it's likely that
the driver will crash in the first blocking call.
 2020-06-24 02:36:14 -03:00
ReinUsesLisp 00c66a7289 gl_stream_buffer: Always use a non-coherent buffer 2020-06-24 02:35:33 -03:00
ReinUsesLisp da79ec9565 gl_stream_buffer: Always use persistent memory maps 
yuzu no longer supports platforms without persistent maps.
 2020-06-24 02:35:33 -03:00
Rodrigo Locatti b66ccaa376
Merge pull request #4129 from Morph1984/texture-shadow-lod-workaround 
gl_shader_decompiler: Workaround textureLod when GL_EXT_texture_shadow_lod is not available
 2020-06-24 01:51:15 -03:00
David Marcec 380fbd8cb7 Move GetKeyCodeMapImpl to an anonymous namespace 2020-06-24 13:05:08 +10:00
David Marcec f5e2aec422 addressed issues 2020-06-24 12:18:33 +10:00
David Marcec 52340e94ac clear mme draw mode 
We already draw, so we can clear it
 2020-06-24 12:09:04 +10:00
David Marcec fabdf5d385 Addressed issues 2020-06-24 12:09:03 +10:00
David Marcec 74b4334d51 Fix constbuffer for 0217920100488FF7 2020-06-24 12:09:02 +10:00
David Marcec 6ce5f3120b Macro HLE support 2020-06-24 12:09:01 +10:00
David Marcec e3d2b646e0 Fixed logging output 2020-06-24 12:07:41 +10:00
David Marcec 5226610a15 Implement GetKeyCodeMap & GetKeyCodeMap2 
Closes #3919
 2020-06-24 12:05:52 +10:00
bunnei 3bab5a5e4a
Merge pull request #4138 from Morph1984/GyroscopeZeroDriftMode 
hid: Implement Get/ResetGyroscopeZeroDriftMode
 2020-06-23 21:56:16 -04:00
ReinUsesLisp 9f54cd4dad gl_shader_cache: Avoid use after move for program size 
All programs had a size of zero due to this bug, skipping invalidations.

While we are at it, remove some unused forward declarations.
 2020-06-23 22:54:42 -03:00
bunnei 1d1489da80
Merge pull request #4128 from lioncash/move2 
software_keyboard: Eliminate trivial redundant copies
 2020-06-23 18:24:15 -04:00
Ameer 743e1f02a0 cleanup check access, read, and factory GetNextInput funcs. Use size rather than magic number 2020-06-23 17:37:15 -04:00
bunnei 15aeae3dd3
Merge pull request #4127 from lioncash/dst-typo 
texture_cache: Fix incorrect address used in a DeduceSurface() call
 2020-06-23 15:59:37 -04:00
bunnei 60da57b518
Merge pull request #3948 from Morph1984/log-cpu-instructions 
main/common: Log/append AVX/FMA to the Host CPU string if available and add AVX512 detection
 2020-06-23 15:19:47 -04:00
Ameer d4e07fd95e Fix deallocation of GC Adapter 2020-06-23 12:47:58 -04:00
Morph b8798a995b yuzu_tester: Silence type conversion warning 2020-06-22 22:56:15 -04:00
Morph 45dac6bc5c lm: Silence no return value warning 2020-06-22 22:55:32 -04:00
Ameer 901bc09dd7 Small quality of life indication that mapped button is GC 2020-06-22 22:02:50 -04:00
ReinUsesLisp 39ab33ee1c shader/half_set: Implement HSET2_IMM 
Add HSET2_IMM. Due to the complexity of the encoding avoid using
BitField unions and read the relevant bits from the code itself.
This is less error prone.
 2020-06-22 20:51:18 -03:00
Ameer fcc23139f6 std::array and const reference passing of non-trivial objects 2020-06-22 18:11:59 -04:00
ameerj f5d2a1e8bd Update src/input_common/main.cpp 
Co-authored-by: LC <mathew1800@gmail.com>

update libusb submodule (hopefully windows build error fixed)
 2020-06-22 17:05:50 -04:00
VolcaEM e193aa3f53
account: Update function tables and add missing classes (#4145) 
* account: Update function tables and add missing classes

* clang-format

* Add missing "public"

* Add missing public again

* Add missing final
 2020-06-22 16:03:26 -04:00
Fernando Sahmkow 544b15e8e4 TextureCache: Fix case where layer goes off bound. 
The returned layer is expected to be between 0 and the depth of the
surface, anything larger is off bounds.
 2020-06-22 11:37:40 -04:00
unknown 8cf6efe677 Reorder variables to comply with the Auzure build pipeline 2020-06-22 15:56:41 +02:00
Morph f2df941e8d arm_dynarmic_64: Log the instruction when an exception is raised 2020-06-22 07:00:24 -04:00
Morph e0af4cdf98 arm_dynarmic_32: Log under Core_ARM instead of HW_GPU 2020-06-22 06:59:41 -04:00
Rodrigo Locatti 406d298457
Merge pull request #4110 from ReinUsesLisp/direct-upload-sets 
vk_update_descriptor: Upload descriptor sets data directly
 2020-06-22 05:02:13 -03:00
ReinUsesLisp 2f09c7ddd3 renderer_vulkan: Update validation layer name and test before enabling 
Update validation layer string to VK_LAYER_KHRONOS_validation.

While we are at it, properly check for available validation layers
before enabling them.
 2020-06-22 04:10:45 -03:00
Ameer 28046ae3a9 Tidy up the pointers, use pair over tuple where appropriate 2020-06-21 23:56:56 -04:00
Ameer 0f729ef078 fix for sleep using stl 2020-06-21 22:58:53 -04:00
bunnei 14a1181a97
Merge pull request #4122 from lioncash/hide 
video_core: Eliminate some variable shadowing
 2020-06-21 22:38:04 -04:00
bunnei c27c76ed43
Merge pull request #4126 from lioncash/noexcept 
vulkan/wrapper: Remove noexcept from GetSurfaceCapabilitiesKHR()
 2020-06-21 22:36:14 -04:00
bunnei e8855ed0fc
Merge pull request #4134 from FearlessTobi/port-5322 
Port citra-emu/citra#5322: "Fix: fatal error CVT1100 when compiling manifest file"
 2020-06-21 22:35:17 -04:00
Ameer 46b4461fbb shared_ptr for the GC adapter class, constexpr constants 2020-06-21 21:50:58 -04:00
Ameer 968d631aa5 std::arrays where appropriate, clear q in adapter class, other touch ups 2020-06-21 21:17:46 -04:00
Ameer 5f0fa4cb82 fix include thread 2020-06-21 21:17:46 -04:00
Ameer 121af3646d Singleton GC Adapter class, remove globals, fix naming convention 
Fix clang formatting

Manual fix for configure_input_player formatting

Add missing lib usb cmake command
 2020-06-21 21:17:07 -04:00
Morph 0235915baa hid: Implement Get/ResetGyroscopeZeroDriftMode 
- Used by Captain Toad Treasure Tracker
 2020-06-21 16:25:41 -04:00
Ameer c94583d867 Clang Formatting 2020-06-21 15:31:57 -04:00
Ameer 0076a08d04 Cleanup after linter 2020-06-21 13:02:43 -04:00
Ameer 0248614add GC Adapter Implementation 2020-06-21 12:36:28 -04:00
VolcaEM 409fedaf97
Correct function name (2/2) 2020-06-21 18:10:23 +02:00
VolcaEM 182ac8a504
Correct function name (1/2) 2020-06-21 18:09:14 +02:00
VolcaEM 23d57ed4f7
Clang-format 2020-06-21 06:17:46 +02:00
VolcaEM d11b04ed46
Remove unnecessary conversion 2020-06-21 06:16:03 +02:00
VolcaEM 606e833d26
Address review comment by Lioncash 
Co-authored-by: LC <mathew1800@gmail.com>
 2020-06-21 06:12:23 +02:00
VolcaEM b81af6ae9b
Add a "Open Mods Page" button to the GUI 2020-06-21 06:09:28 +02:00
Morph f77c897b8d gl_shader_decompiler: Enable GL_EXT_texture_shadow_lod if available 
Enable GL_EXT_texture_shadow_lod if available. If this extension is not available, such as on Intel/AMD proprietary drivers, use textureGrad as a workaround.
 2020-06-20 23:02:29 -04:00
Morph 1e65da971b gl_device: Check for GL_EXT_texture_shadow_lod 2020-06-20 22:14:32 -04:00
bunnei f98bf1025f
Merge pull request #4120 from lioncash/arb 
gl_arb_decompiler: Avoid several string copies
 2020-06-20 22:11:49 -04:00
FearlessTobi a8674a7b86 Fix: fatal error CVT1100 when compiling manifest file 
Occurs when doing a local compile in MSVC build. The compiler I'm using is as below:
Microsoft Visual Studio Community 2019 Preview
Version 16.6.0 Preview 5.0

Fixes this error:
CVTRES : fatal error CVT1100: duplicate resource. type:MANIFEST, name:1, language:0x0409
LINK : fatal error LNK1123: failure during conversion to COFF: file invalid or corrupt

I have put 0 since previous name was 1. If have other names in mind, please let me know.

Co-Authored-By: dragios <dragios@users.noreply.github.com>
 2020-06-21 03:11:23 +02:00
MerryMage c12eb814b4 macro_jit_x64: Use ecx for shift register 
shl/shr only accept cl as their second argument
 2020-06-20 22:24:05 +01:00
Lioncash ef53b2fd08 texture_cache: Fix incorrect address used in a DeduceSurface() call 
Previously the source was being deduced twice in a row.
 2020-06-20 14:11:28 -04:00
merry 928e9c09aa
Merge pull request #4125 from lioncash/macro-shift 
macro_jit_x64: Amend readability of Compile_ExtractShiftLeftRegister()
 2020-06-20 16:08:23 +01:00
merry 2bd903e021
Merge pull request #4123 from lioncash/unused-var 
macro_jit_x64: Remove unused variable
 2020-06-20 16:07:58 +01:00
Lioncash a5ed0c3df7 software_keyboard: Eliminate trivial redundant copies 
We can just make use of moves here to get rid of two redundant copies
 2020-06-20 01:06:10 -04:00
Morph 9bb5bf0b2b main: Append AVX and FMA instructions to cpu string 
Append AVX and FMA instructions to cpu string if the host cpu supports them
 2020-06-20 00:31:37 -04:00
Morph 97ba520434 common/telemetry: Add AVX512 to telemetry 2020-06-20 00:31:37 -04:00
Morph d6474b4aca common/cpu_detect: Add AVX512 detection 2020-06-20 00:31:37 -04:00
Morph 480e1fa987 decode/image: Implement B10G11R11F 
- Used by Kirby Star Allies
 2020-06-20 00:28:30 -04:00
bunnei 7d1dca4c98
Merge pull request #4099 from MerryMage/macOS-build 
Fix compilation on macOS
 2020-06-19 23:31:04 -04:00
Lioncash 5865a10885 gl_arb_decompiler: Avoid several string copies 
Variables that are marked as const cannot have the move constructor
invoked when returning from a function (the move constructor requires a
non-const variable so it can "steal" the resources from it.
 2020-06-19 23:09:16 -04:00
Lioncash a6e5b84d1f vulkan/wrapper: Remove noexcept from GetSurfaceCapabilitiesKHR() 
Check() can throw an exception if the Vulkan result isn't successful.

We remove the check so that std::terminate isn't outright called and
allows for better debugging (should it ever actually fail).
 2020-06-19 23:01:59 -04:00
Lioncash 5a4e89b901 macro_jit_x64: Correct readability of Compile_ExtractShiftLeftImmediate() 
Previously dst wasn't being used.
 2020-06-19 22:57:23 -04:00
Lioncash 140f953b6a macro_jit_x64: Correct readability of Compile_ExtractShiftLeftRegister() 
Previously dst wasn't being used.
 2020-06-19 22:56:55 -04:00
Lioncash 8ea749c1ca macro_jit_x64: Remove unused variable 
Removes a completely unused label and marks another variable as unused,
given it seems like it has potential uses in the future.
 2020-06-19 22:10:45 -04:00
Lioncash 479605b3e5 memory_manager: Eliminate variable shadowing 
Renames some variables to prevent ones in inner scopes from shadowing
outer-scoped variables.

The Copy* functions have no shadowing, but we rename them anyways to
remain consistent with the other functions.
 2020-06-19 22:02:58 -04:00
bunnei 9c5ed4408d
Merge pull request #4113 from ogniK5377/boxcat-disable 
Fix compilation when not building with boxcat
 2020-06-19 21:59:59 -04:00
David Marcec a7fe6dc232 Add translation of "Current Boxcat Events" 2020-06-20 11:57:51 +10:00
Lioncash 811bff009e macro_jit_x64: Eliminate variable shadowing in Compile_ProcessResult() 
We can reduce the capture scope so that it's not possible for both "reg"
variables to clash with one another.

While we're at it, we can prevent unnecessary copies while we're at it.
 2020-06-19 21:57:44 -04:00
Lioncash 4514b80b3e buffer_cache: Eliminate local variable shadowing 
We can just make use of the instance in the scope above this one.
 2020-06-19 21:55:02 -04:00
bunnei 7daea551c0
Merge pull request #4087 from MerryMage/macrojit-inline-Read 
macro_jit_x64: Inline Engines::Maxwell3D::GetRegisterValue
 2020-06-19 21:32:07 -04:00
MerryMage c6a963c48e input_common/motion_emu: Remove redundant move 
Named return value optimization automatically applies here.
 2020-06-19 14:29:59 +01:00
MerryMage 8272f53cf9 input_common/keyboard: Remove redundant move 
Named return value optimization automatically applies here.
 2020-06-19 14:29:36 +01:00
MerryMage 7236393114 mii_model: Remove redundant std::move 
Named return value optimization automatically applies here.
 2020-06-19 14:29:09 +01:00
David Marcec c7ed7d9427 Fix compilation when not building with boxcat 
Fixes compilation when trying to build without boxcat enabled
 2020-06-19 22:17:56 +10:00
MerryMage 977ceb4056 macro_jit_x64: Remove unused function Read 2020-06-19 11:39:41 +01:00
bunnei 0f7822acb1
Merge pull request #4080 from ogniK5377/audren-RendererInfo 
audren: Implement RendererInfo
 2020-06-19 01:02:30 -04:00
bunnei 5a092fb61e
Merge pull request #4090 from MerryMage/macrojit-bugs 
macro_jit_x64: Optimization correctness
 2020-06-18 22:28:17 -04:00
ReinUsesLisp cf137ea40b vk_rasterizer: Don't preserve contents on full screen clears 
There's no need to load contents from the CPU when a clear resets all
the contents of the underlying memory. This is already implemented on
OpenGL and the texture cache.
 2020-06-18 18:18:33 -03:00
Rodrigo Locatti de644d506f
Merge pull request #4081 from Morph1984/maxwell-to-gl-vk 
maxwell_to_gl/vk: Miscellaneous changes
 2020-06-18 17:51:41 -03:00
ReinUsesLisp 7d763f060e vk_update_descriptor: Upload descriptor sets data directly 
Instead of copying to a temporary payload before sending the update task
to the worker thread, insert elements to the payload directly.
 2020-06-18 17:47:19 -03:00
Fernando Sahmkow 45d29436b3 Tests/HostTiming: Correct GCC Compile error. 2020-06-18 16:29:28 -04:00
Fernando Sahmkow e77ee67bfa Common/Fiber: Address Feedback and Correct Memory leaks. 2020-06-18 16:29:27 -04:00
Fernando Sahmkow b6655aa2e4 Common/Fiber: Implement Rewind on Boost Context. 2020-06-18 16:29:27 -04:00
Fernando Sahmkow 59ce6e6d06 Common/uint128: Correct MSVC Compilation in old versions. 2020-06-18 16:29:26 -04:00
Fernando Sahmkow 18f54f7486 Common/Fiber: Document fiber interexchange. 2020-06-18 16:29:26 -04:00
Fernando Sahmkow 137d862d9b Common/Fiber: Implement Rewinding. 2020-06-18 16:29:25 -04:00
Fernando Sahmkow 41013381d6 Common/Fiber: Additional corrections to f_context. 2020-06-18 16:29:25 -04:00
Fernando Sahmkow 7d2b1a6ec4 Common/Fiber: Correct f_context based Fibers. 2020-06-18 16:29:24 -04:00
Fernando Sahmkow 8f6ffcd5c4 Host Timing: Correct clang format. 2020-06-18 16:29:23 -04:00
Fernando Sahmkow 96b2d8419c HostTiming: Correct rebase and implement AddTicks. 2020-06-18 16:29:22 -04:00
Fernando Sahmkow 49a7e0984a Core/HostTiming: Allow events to be advanced manually. 2020-06-18 16:29:22 -04:00
Fernando Sahmkow 1f7dd36499 Common/Tests: Address Feedback 2020-06-18 16:29:21 -04:00
Fernando Sahmkow 3398f701ee Common: Make MinGW build use Windows Fibers instead of fcontext_t 2020-06-18 16:29:20 -04:00
Fernando Sahmkow 1bd706344e Common/Tests: Clang Format. 2020-06-18 16:29:19 -04:00
Fernando Sahmkow 03e4f5dac4 Common: Correct fcontext fibers. 2020-06-18 16:29:19 -04:00
Fernando Sahmkow e3524d1142 Common: Refactor & Document Wall clock. 2020-06-18 16:29:18 -04:00
Fernando Sahmkow 234b5ff6a9 Common: Implement WallClock Interface and implement a native clock for x64 2020-06-18 16:29:17 -04:00
Fernando Sahmkow 0f8e5a1465 Tests: Add base tests to host timing 2020-06-18 16:29:17 -04:00
Fernando Sahmkow 62e35ffc0e Core: Implement a Host Timer. 2020-06-18 16:29:16 -04:00
Fernando Sahmkow be320a9e10 Common: Polish Fiber class, add comments, asserts and more tests. 2020-06-18 16:29:15 -04:00
Fernando Sahmkow 8d0e3c5422 Tests: Add tests for fibers and refactor/fix Fiber class 2020-06-18 16:29:15 -04:00
Fernando Sahmkow bc266a9d98 Common: Implement a basic Fiber class. 2020-06-18 16:29:14 -04:00
Fernando Sahmkow 13ed9438fb Common: Implement a basic SpinLock class 2020-06-18 16:29:13 -04:00
ReinUsesLisp 778043a44c arm_dynarmic_32: Fix implicit conversion error in SetTPIDR_EL0 
On MSVC builds we treat conversion warnings as errors.
 2020-06-18 16:52:15 -03:00
MerryMage 778f86989a bootmanager: Remove references to OpenGL for macOS 
OpenGL macOS headers definitions clash heavily with each other
 2020-06-18 15:47:44 +01:00
MerryMage b19fe55f84 memory_manager: Explicitly specifcy std::min<size_t> 2020-06-18 15:47:44 +01:00
MerryMage 4f09f0aea4 shared_font: Service::NS::EncryptSharedFont takes a size_t& 2020-06-18 15:47:44 +01:00
MerryMage 69f38355ed vk_rasterizer: BindTransformFeedbackBuffersEXT accepts a size of type VkDeviceSize 2020-06-18 15:47:44 +01:00
MerryMage b1eada6079 renderer_vulkan: Fix macOS GetBundleDirectory reference 2020-06-18 15:47:44 +01:00
MerryMage 442e48ef4c memory_util: boost hashes are size_t 
* boost::hash_value returns a size_t
* boost::hash_combine takes a size_t& argument
 2020-06-18 15:47:43 +01:00
MerryMage 8ae7154541 Rename PAGE_SHIFT to PAGE_BITS 
macOS header files #define PAGE_SHIFT
 2020-06-18 15:47:43 +01:00
VolcaEM 684dfbf209
Move SHA256Hash to its original position 
It's not needed to have it in its previous position anymore
 2020-06-18 15:45:47 +02:00
Morph 2f420618ea vk_sampler_cache: Emulate GL_LINEAR/NEAREST minification filters 
Emulate GL_LINEAR/NEAREST minification filters using minLod = 0 and maxLod = 0.25 during sampler creation
 2020-06-18 04:56:31 -04:00
Morph be660e7749 maxwell_to_vk: Reorder filter cases and correct mipmap_filter=None 
maxwell_to_vk: Reorder filtering modes to start with None, then Nearest, then Linear.
maxwell_to_vk: Logs filter modes under UNREACHABLE_MSG instead of UNIMPLEMENTED_MSG, since any unknown filter modes are invalid and not unimplemented.
maxwell_to_vk: Return VK_SAMPLER_MIPMAP_MODE_NEAREST instead of VK_SAMPLER_MIPMAP_MODE_LINEAR when mipmap_filter is None with the description from the VkSamplerCreateInfo(3) man page.
 2020-06-18 04:56:31 -04:00
Morph 8868fb745f maxwell_to_gl: Miscellaneous changes 
maxwell_to_gl: Log unimplemented features under UNIMPLEMENTED_MSG instead of LOG_ERROR to bring into parity with maxwell_to_vk
maxwell_to_gl: Deduplicate logging in VertexType(), merging them into one.

maxwell_to_gl: Return GL_NEAREST instead of GL_LINEAR if an unknown texture filter mode is encountered.
maxwell_to_gl: Log the mipmap filter mode if an unknown value is passed in.
maxwell_to_gl: Reorder filtering modes to start with None, then Nearest, then Linear.
 2020-06-18 04:56:31 -04:00
Rodrigo Locatti edb2114bac
Merge pull request #4092 from Morph1984/image-bindings 
gl_device: Reserve 4 image bindings for fragment stage
 2020-06-18 04:59:48 -03:00
MerryMage 44f10d9b9f macro_jit_x64: Inline Engines::Maxwell3D::GetRegisterValue 2020-06-17 17:17:08 +01:00
MerryMage 52bcfac116 arm_dynarmic_cp15: Implement CNTPCT 2020-06-17 17:10:24 +01:00
MerryMage 109df7705f arm_dynarmic_cp15: Update CP15 2020-06-17 17:10:24 +01:00
MerryMage 32a127faaa arm_dynarmic_32: InterpreterFallback should never happen 2020-06-17 17:10:24 +01:00
bunnei a8ac99b619
Merge pull request #4086 from MerryMage/abi 
xbyak_abi: Cleanup
 2020-06-17 11:20:52 -04:00
MerryMage c409722435 macro_jit_x64: Optimization implicitly assumes same destination 2020-06-17 10:36:36 +01:00
MerryMage a6ddd7c382 macro_jit_x64: Should not skip zero registers for certain ALU ops 
The code generated for these ALU ops assume src_a and src_b are always valid.
 2020-06-17 10:36:34 +01:00
Kaiwen Xu 7a59eeb5be Fix framebuffer size on fractional scaling display. 2020-06-16 20:45:20 -07:00
bunnei b660ef6c8a
Merge pull request #4089 from MerryMage/macrojit-cleanup-1 
macro_jit_x64: Cleanup
 2020-06-16 23:44:48 -04:00
bunnei 798ec003ce
Merge pull request #4041 from ReinUsesLisp/arb-decomp 
gl_arb_decompiler: Implement an assembly shader decompiler
 2020-06-16 14:56:23 -04:00
VolcaEM bd9495c9ab
Remove unnecessary pragmas 2020-06-16 20:28:44 +02:00
VolcaEM c0d6162050
Revert IsValidNRO refactor but make it more readable 2020-06-16 20:24:58 +02:00
bunnei f22d02083c
Merge pull request #3966 from Morph1984/hide-internal-resolution-ui 
yuzu/frontend: Remove internal resolution option
 2020-06-16 14:12:17 -04:00
VolcaEM 4b71bf654d
Update assert string 2020-06-16 15:57:02 +02:00
Morph e2f5d16540 gl_device: Reserve at least 4 image bindings for fragment stage 
Due to the limitation of GL_MAX_IMAGE_UNITS being low (8) on Intel's and Nvidia's proprietary drivers, we have to reserve an appropriate amount of image bindings for each of the stages. So far games have been observed to use 4 image bindings on the fragment stage (Kirby Star Allies) and 1 on the vertex stage (TWD series).
No games thus far in my limited testing used more than 4 images concurrently and across all currently active programs.
This fixes shader compilation errors on Kirby Star Allies on OpenGL (GLSL/GLASM)
 2020-06-16 03:03:07 -04:00
Rodrigo Locatti 0bd9bc7201
Merge pull request #4066 from ReinUsesLisp/shared-ptr-buf 
buffer_cache: Avoid passing references of shared pointers and misc style changes
 2020-06-15 22:29:32 -03:00
MerryMage cf0aad7d6a macro_jit_x64: Remove NEXT_PARAMETER 
Not required, as PARAMETERS can just be incremented directly.
 2020-06-15 21:19:38 +01:00
MerryMage 1799f4e774 macro_jit_x64: Remove unused function Compile_WriteCarry 2020-06-15 21:19:38 +01:00
MerryMage c09a9e5cc7 macro_jit_x64: Select better registers 
All registers are now callee-save registers.

RBX and RBP selected for STATE and RESULT because these are most commonly accessed; this is to avoid the REX prefix.
RBP not used for STATE because there are some SIB restrictions, RBX emits smaller code.
 2020-06-15 21:19:38 +01:00
MerryMage 79aa7b3ace macro_jit_x64: Remove REGISTERS 
Unnecessary since this is just an offset from STATE.
 2020-06-15 21:00:59 +01:00
MerryMage 35db6e1c68 macro_jit_x64: Remove JITState::parameters 
This can be passed in as an argument instead.
 2020-06-15 20:55:02 +01:00
MerryMage 389549b80d macro_jit_x64: Remove METHOD_ADDRESS_64 
Unnecessary variable.
 2020-06-15 20:51:33 +01:00
MerryMage a6a43a5ae0 macro_jit_x64: Remove RESULT_64 
This Reg64 codepath has the exact same behaviour as the Reg32 one.
 2020-06-15 20:35:08 +01:00
MerryMage 7c6203dc5e xbyak_abi: Prefer returning a struct to using out parameters in ABI_CalculateFrameSize 2020-06-15 19:07:11 +01:00
MerryMage 36362e9695 xbyak_abi: Register indexes should be unsigned 2020-06-15 19:07:11 +01:00
MerryMage d563017dfe xbyak_abi: Remove *GPS variants of stack manipulation functions 2020-06-15 18:59:54 +01:00
MerryMage 4417770ba9 xbyak_abi: Fix ABI_PushRegistersAndAdjustStack 
Pushing GPRs twice.
 2020-06-15 18:59:01 +01:00
ReinUsesLisp 6e5d8aac4d video_core/macro_jit_x64: Remove initializer in member variable 
Fix build time issues on gcc. Confirmed through asan that avoiding this
initialization is safe.
 2020-06-15 05:17:55 -03:00
bunnei 55ebf68636
Merge pull request #4070 from ogniK5377/GetTPCMasks-fix 
nvdrv: Fix GetTPCMasks for ioctl3
 2020-06-14 20:12:45 -04:00
VolcaEM 39213b1c59
Clang-format again 2020-06-14 19:41:28 +02:00
VolcaEM 198b0fa790
Use consistent variable names 2020-06-14 19:37:44 +02:00
VolcaEM 1520d7865d
Clang-format 2020-06-14 19:34:58 +02:00
VolcaEM 761d206049
Make assert strings consistent 2020-06-14 19:30:08 +02:00
VolcaEM 151a3fe7b3
Attempt to fix crashes in SSBU and refactor IsValidNRO 2020-06-14 19:28:39 +02:00
bunnei 89d11f2268
Merge pull request #4069 from ogniK5377/total-phys-mem 
kernel: Account for system resource size for memory usage
 2020-06-14 00:44:34 -04:00
bunnei 92021a344c
Merge pull request #4064 from ReinUsesLisp/invalidate-buffers 
gl_rasterizer: Mark vertex buffers as dirty after buffer cache invalidation
 2020-06-14 00:29:16 -04:00
bunnei c2ea1e1bcb
Merge pull request #4049 from ReinUsesLisp/separate-samplers 
shader/texture: Join separate image and sampler pairs offline
 2020-06-13 13:48:27 -04:00
David Marcec 42250427c5 audren: Implement RendererInfo 
Fixes ZLA softlock
 2020-06-13 14:04:28 +10:00
bunnei 5633887569
Merge pull request #3986 from ReinUsesLisp/shader-cache 
shader_cache: Implement a generic runtime shader cache
 2020-06-12 23:14:48 -04:00
bunnei e1911e5c8b
Merge pull request #4010 from ogniK5377/reserve-always-break 
kernel: ResourceLimit::Reserve remove useless while loop
 2020-06-12 22:30:19 -04:00
ReinUsesLisp 87011a97f9 gl_arb_decompiler: Implement FSwizzleAdd 2020-06-11 22:12:07 -03:00
ReinUsesLisp a63a0daa5e gl_arb_decompiler: Implement an assembly shader decompiler 
Emit code compatible with NV_gpu_program5.
This should emit code compatible with Fermi, but it wasn't tested on
that architecture. Pascal has some issues not present on Turing GPUs.
 2020-06-11 22:12:07 -03:00
ReinUsesLisp d89888389d yuzu/configuration: Show assembly shaders check box 2020-06-10 19:04:53 -03:00
David Marcec b15cbf9bcf nvdrv: Fix GetTPCMasks for ioctl3 
Fixes animal crossing svcBreak on launch
 2020-06-10 18:36:42 +10:00
David Marcec 74ff1db758 kernel: Account for system resource size for memory usage 
GetTotalPhysicalMemoryAvailableWithoutSystemResource & GetTotalPhysicalMemoryUsedWithoutSystemResource seem to subtract the resource size from the usage.
 2020-06-10 14:49:00 +10:00
bunnei 83e3b77ed7
Merge pull request #4027 from ReinUsesLisp/3d-slices 
texture_cache: Implement rendering to 3D textures
 2020-06-09 21:52:15 -04:00
ReinUsesLisp 6508cdd003 buffer_cache: Avoid passing references of shared pointers and misc style changes 
Instead of using as template argument a shared pointer, use the
underlying type and manage shared pointers explicitly. This can make
removing shared pointers from the cache more easy.

While we are at it, make some misc style changes and general
improvements (like insert_or_assign instead of operator[] + operator=).
 2020-06-09 18:30:49 -03:00
ReinUsesLisp 7646f2c21d gl_rasterizer: Mark vertex buffers as dirty after buffer cache invalidation 
Vertex buffers bindings become invalid after the stream buffer is
invalidated. We were originally doing this, but it got lost at some
point.

- Fixes Animal Crossing: New Horizons, but it affects everything.
 2020-06-08 20:24:16 -03:00
ReinUsesLisp 6e122f0b2c buffer_cache: Return stream buffer invalidation in Map instead of Unmap 
We have to invalidate whatever cache is being used before uploading the
data, hence it makes more sense to return this on Map instead of Unmap.
 2020-06-08 20:22:31 -03:00
unknown 20a779299a Add game versio to title bar 2020-06-08 23:58:04 +02:00
bunnei 3626254f48
Merge pull request #4040 from ReinUsesLisp/nv-transform-feedback 
gl_rasterizer: Use NV_transform_feedback for XFB on assembly shaders
 2020-06-08 16:18:33 -04:00
bunnei 98d2461529
Merge pull request #4052 from ReinUsesLisp/debug-output 
renderer_opengl: Only enable DEBUG_OUTPUT when graphics debugging is enabled
 2020-06-08 10:16:41 -04:00
ReinUsesLisp bd43c05470 texture_cache: Port original code management for 2D vs 3D textures 
Handle blits to images as 2D, even when they have block depth.

- Fixes rendering issues on Luigi's Mansion 3
 2020-06-08 05:02:22 -03:00
ReinUsesLisp c99f5d405b texture_cache: Simplify blit code 2020-06-08 05:01:44 -03:00
ReinUsesLisp 3c2ae53b4c texture_cache: Handle 3D texture blits with one layer 2020-06-08 05:01:00 -03:00
ReinUsesLisp c95c254f3e texture_cache: Implement rendering to 3D textures 
This allows rendering to 3D textures with more than one slice.
Applications are allowed to render to more than one slice of a texture
using gl_Layer from a VTG shader.

This also requires reworking how 3D texture collisions are handled, for
now, this commit allows rendering to slices but not to miplevels. When a
render target attempts to write to a mipmap, we fallback to the previous
implementation (copying or flushing as needed).

- Fixes color correction 3D textures on UE4 games (rainbow effects).
- Allows Xenoblade games to render to 3D textures directly.
 2020-06-08 05:01:00 -03:00
Rodrigo Locatti 2293e8a11a
Merge pull request #4034 from ReinUsesLisp/storage-texels 
vk_rasterizer: Implement storage texels and atomic image operations
 2020-06-07 18:43:24 -03:00
ReinUsesLisp abcea1bb18 rasterizer_cache: Remove files and includes 
The rasterizer cache is no longer used. Each cache has its own generic
implementation optimized for the cached data.
 2020-06-07 04:32:57 -03:00
ReinUsesLisp 678f95e4f8 vk_pipeline_cache: Use generic shader cache 
Trivial port the generic shader cache to Vulkan.
 2020-06-07 04:32:57 -03:00
ReinUsesLisp b96f65b62b gl_shader_cache: Use generic shader cache 
Trivially port the generic shader cache to OpenGL.
 2020-06-07 04:32:57 -03:00
ReinUsesLisp dc27252352 shader_cache: Implement a generic shader cache 
Implement a generic shader cache for fast lookups and invalidations.
Invalidations are cheap but expensive when a shader is invalidated.

Use two mutexes instead of one to avoid locking invalidations for
lookups and vice versa. When a shader has to be removed, lookups are
locked as expected.
 2020-06-07 04:32:32 -03:00
Morph 03fad5ebe8 yuzu/frontend: Remove internal resolution option 2020-06-06 15:56:14 -04:00
ReinUsesLisp e78d681a6c gl_device: Black list NVIDIA 443.24 for fast buffer uploads 
Skip fast buffer uploads on Nvidia 443.24 Vulkan beta driver on OpenGL.
This driver throws the following error when calling BufferSubData or
BufferData on buffers that are candidates for fast constant buffer
uploads. This is the equivalens to push constants on Vulkan, except that
they can access the full buffer. The error:

Unknown internal debug message. The NVIDIA OpenGL driver has encountered
an out of memory error. This application might
behave inconsistently and fail.

If this error persists on future drivers, we might have to look deeper
into this issue. For now, we can black list it and log it as a temporary
solution.
 2020-06-06 02:56:42 -03:00
ReinUsesLisp 354fbe701e renderer_opengl: Only enable DEBUG_OUTPUT when graphics debugging is enabled 
Avoids logging when it's not relevant. This can potentially reduce
driver's internal thread overhead.
 2020-06-05 21:21:12 -03:00
bunnei 98671b4cfe
Merge pull request #4013 from ReinUsesLisp/skip-no-xfb 
vk_rasterizer: Skip transform feedbacks when extension is unavailable
 2020-06-05 11:14:36 -04:00
ReinUsesLisp 5b2b6d594c shader/texture: Join separate image and sampler pairs offline 
Games using D3D idioms can join images and samplers when a shader
executes, instead of baking them into a combined sampler image. This is
also possible on Vulkan.

One approach to this solution would be to use separate samplers on
Vulkan and leave this unimplemented on OpenGL, but we can't do this
because there's no consistent way of determining which constant buffer
holds a sampler and which one an image. We could in theory find the
first bit and if it's in the TIC area, it's an image; but this falls
apart when an image or sampler handle use an index of zero.

The used approach is to track for a LOP.OR operation (this is done at an
IR level, not at an ISA level), track again the constant buffers used as
source and store this pair. Then, outside of shader execution, join
the sample and image pair with a bitwise or operation.

This approach won't work on games that truly use separate samplers in a
meaningful way. For example, pooling textures in a 2D array and
determining at runtime what sampler to use.

This invalidates OpenGL's disk shader cache :)

- Used mostly by D3D ports to Switch
 2020-06-05 00:24:51 -03:00
bunnei 1adf640d37 service: nvhost_vic: Ignore Submit commands. 2020-06-04 22:32:28 -04:00
Zach Hilman 34635a42c0 nvdrv: Stub nvdec/vic ioctls to bypass nvdec movies 2020-06-04 22:32:28 -04:00
ReinUsesLisp e1438f8e91 shader/track: Move bindless tracking to a separate function 2020-06-04 23:02:55 -03:00
bunnei 22369df357
Merge pull request #4031 from Morph1984/fix-gs-outputs 
gl_shader_decompiler: Fix geometry shader outputs on Intel drivers
 2020-06-04 15:18:51 -04:00
bunnei 624def4f38
Merge pull request #4044 from ogniK5377/handle-not-signalled-err 
Downgrade "handle not signaled" error to trace
 2020-06-04 12:23:40 -04:00
bunnei 34d4abc4f9
Merge pull request #4009 from ogniK5377/macro-jit-prod 
video_core: Implement Macro JIT
 2020-06-04 11:40:52 -04:00
David Marcec c0d2e3212f Downgrade "handle not signaled" error to trace 
clogs logs quite a bit
 2020-06-04 22:27:15 +10:00
David Marcec eca3d16e54 Default init labels and use initializer list for macro engine 2020-06-04 22:23:07 +10:00
bunnei 1b64fae912
Merge pull request #4039 from FearlessTobi/port-5376 
Port citra-emu/citra#5376: "Actually save the input when clearing/resetting to default"
 2020-06-03 21:49:31 -04:00
ReinUsesLisp 3d99b449d3 gl_rasterizer: Use NV_transform_feedback for XFB on assembly shaders 
NV_transform_feedback, NV_transform_feedback2 and
ARB_transform_feedback3 with NV_transform_feedback interactions allows
implementing transform feedbacks as dynamic state.

Maxwell implements transform feedbacks as dynamic state, so using these
extensions with TransformFeedbackStreamAttribsNV allows us to properly
emulate transform feedbacks without having to recompile shaders when the
state changes.
 2020-06-03 20:22:12 -03:00
bunnei c647999c61
Merge pull request #4012 from ReinUsesLisp/mipmap-overlaps 
texture_cache: Handle overlaps with multiple subresources
 2020-06-03 12:17:25 -04:00
David Marcec 411f5527d4 Mark parameters as const 2020-06-03 16:33:38 +10:00
FearlessTobi aaa4822fcb Actually save the input when clearing/resetting to default 
Co-Authored-By: xperia64 <xperiancedapps@gmail.com>
 2020-06-03 05:17:34 +02:00
bunnei 623b93a2b3
Merge pull request #4014 from ReinUsesLisp/astc-nvidia 
gl_device: Avoid devices with CAVEAT_SUPPORT on ASTC
 2020-06-02 17:43:33 -04:00
bunnei 23d3e4a3c4
Merge pull request #4032 from VolcaEM/xpad 
hid: Stub GetXpadIDs
 2020-06-02 16:46:47 -04:00
bunnei 597d8b4bd4
Merge pull request #4006 from ReinUsesLisp/squash-ubos 
glsl: Squash constant buffers into a single SSBO when we hit the limit
 2020-06-02 14:58:50 -04:00
VolcaEM dfd1badc12
Address review comments 2020-06-02 17:54:10 +02:00
LC 9a0c1456e3
Merge pull request #4016 from ReinUsesLisp/invocation-info 
shader/other: Fix hardcoded value in S2R INVOCATION_INFO
 2020-06-02 09:47:53 -04:00
LC c5de3c1059
Merge pull request #4033 from ReinUsesLisp/vk-r16ui 
maxwell_to_vk: Add R16UI image format
 2020-06-02 09:42:49 -04:00
David Marcec 3a20e74f40 Pass by reference instead of copying parameters 2020-06-02 16:37:06 +10:00
ReinUsesLisp 866c1165af vk_shader_decompiler: Implement atomic image operations 
Implement atomic operations on images.
On GLSL these are atomicImage* functions (e.g. atomicImageAdd).
 2020-06-02 02:20:02 -03:00
ReinUsesLisp 4a6b9a1a71 vk_rasterizer: Implement storage texels 
This is the equivalent of an image buffer on OpenGL.

- Used by Octopath Traveler
 2020-06-02 02:16:33 -03:00
ReinUsesLisp 3a59e724c9 maxwell_to_vk: Add R16UI image format 
- Used by Octopath Traveler
 2020-06-02 02:15:20 -03:00
bunnei 4511502ca6
Merge pull request #4001 from ReinUsesLisp/avoid-copies 
buffer_cache: Avoid copying twice on certain cases
 2020-06-01 16:59:17 -04:00
bunnei bb6d93630f
Merge pull request #3998 from ReinUsesLisp/init-3d 
maxwell_3d: Initialize more registers to their expected value
 2020-06-01 16:11:56 -04:00
Morph 74f2e5f1a4 gl_shader_decompiler: Declare gl_Layer and gl_ViewportIndex within gl_PerVertex for vertex and tessellation shaders 2020-06-01 15:35:44 -04:00
Morph 70188d69b0 gl_shader_decompiler: Fix geometry shader outputs for Intel drivers 
On Intel's proprietary drivers, gl_Layer and gl_ViewportIndex are not allowed members of gl_PerVertex block, causing the shader to fail to compile. Fix this by declaring these variables outside of gl_PerVertex.
 2020-06-01 15:34:05 -04:00
Rodrigo Locatti 3a6714ab7f
Merge pull request #4005 from ReinUsesLisp/g24r8 
format_lookup_table: Implement G24S8 format as S8Z24
 2020-06-01 16:07:58 -03:00
bunnei 6c0b1a9ee2
Merge pull request #3996 from ReinUsesLisp/front-faces 
fixed_pipeline_state,gl_rasterizer: Swap negative viewport checks for front faces
 2020-06-01 14:04:35 -04:00
VolcaEM 8c84a7e7ec
Clang-format 2020-06-01 19:42:54 +02:00
VolcaEM 4d10d3113f
hid: Stub GetXpadIDs 
Allows Minecraft: Nintendo Switch Edition (a.k.a. old Minecraft) to boot and go ingame
 2020-06-01 19:38:44 +02:00
ReinUsesLisp 0ee310ebdc gl_device: Avoid devices with CAVEAT_SUPPORT on ASTC 
This avoids using Nvidia's ASTC decoder on OpenGL.
The last time it was profiled, it was slower than yuzu's decoder.

While we are at it, fix a bug in the texture cache when native ASTC is
not supported.
 2020-05-31 21:34:34 -03:00
ReinUsesLisp ee21e4ecd3 glsl: Squash constant buffers into a single SSBO when we hit the limit 
Avoids compilation errors at the cost of shader build times and runtime
performance when a game hits the limit of uniform buffers we can use.
 2020-05-31 21:33:49 -03:00
bunnei e68ee43a1a
Merge pull request #3930 from ReinUsesLisp/animal-borders 
vk_rasterizer: Implement constant attributes
 2020-05-31 18:40:17 -04:00
bunnei edbf3144d2
Merge pull request #3958 from FernandoS27/gl-debug 
OpenGL: Enable Debug Context and Synchronous debugging when graphics debugging is enabled
 2020-05-31 17:04:27 -04:00
bunnei f7debcaa04
Merge pull request #3999 from ReinUsesLisp/opt-tex-cache 
texture_cache: Optimize GetSurfacesInRegion
 2020-05-31 17:02:29 -04:00
VolcaEM a087b3365a
Add comment to nrr_kind 
According to Atmosphére (c7026b9094/libraries/libstratosphere/include/stratosphere/ro/ro_types.hpp), nrr_kind (Atmosphére calls it "type") is 7.0.0+
 2020-05-31 19:12:09 +02:00
VolcaEM 2b1cc232bc
ldr: Update NRR/NRO structs 
This was based on Switchbrew pages:

https://switchbrew.org/wiki/NRR

https://switchbrew.org/wiki/NRO
 2020-05-31 18:49:51 +02:00
Morph bb8ef38152 gl_device: Enable compute shaders for Intel proprietary drivers 
Previously we were disabling compute shaders on Intel's proprietary driver due to broken compute. This has been fixed in the latest Intel drivers. Re-enable compute for Intel proprietary drivers and remove the check for broken compute.
 2020-05-31 03:21:07 -04:00
bunnei 058ec22787
Merge pull request #3982 from ReinUsesLisp/membar-cts 
shader/other: Implement MEMBAR.CTS
 2020-05-30 11:51:42 -04:00
ReinUsesLisp f2d1aa97ad shader/other: Fix hardcoded value in S2R INVOCATION_INFO 
Geometry shaders built from Nvidia's compiler check for bits[16:23] to
be less than or equal to 0 with VSETP to default to a "safe" value of
0x8000'0000 (safe from hardware's perspective). To avoid hitting this
path in the shader, return 0x00ff'0000 from S2R INVOCATION_INFO.

This seems to be the maximum number of vertices a geometry shader can
emit in a primitive.
 2020-05-30 01:49:14 -03:00
ReinUsesLisp 1ee1a5d3d6 texture_cache: More relaxed reconstruction 
Only reupload textures when they've not been modified from the GPU.
 2020-05-29 23:56:52 -03:00
David Marcec 8118ea160b Favor switch case over jump table 
Easier to read and will emit a jump table automatically.
 2020-05-30 12:23:58 +10:00
David Marcec b032ebdfee Implement macro JIT 2020-05-30 11:40:04 +10:00
David Marcec d0bdd26c26 Add xbyak external 2020-05-30 10:55:27 +10:00
ReinUsesLisp e454f7e7a7 texture_cache: Only copy textures that were modified from host 2020-05-29 20:12:46 -03:00
ReinUsesLisp dd70e097cc texture_cache: Reload textures when number of resources mismatch 2020-05-29 20:10:58 -03:00
bunnei 87b272699f
Merge pull request #4007 from ReinUsesLisp/reduce-logs 
maxwell_3d: Reduce severity of logs that can be spammed
 2020-05-29 17:29:17 -04:00
ReinUsesLisp 5616be12be vk_rasterizer: Skip transform feedbacks when extension is unavailable 
Avoids calling transform feedback procedures when
VK_EXT_transform_feedback is not available.
 2020-05-29 03:05:29 -03:00
ReinUsesLisp 5b37cecd76 texture_cache: Handle overlaps with multiple subresources 
Implement more surface reconstruct cases. Allow overlaps with more than
one layer and mipmap and copies all of them to the new texture.

- Fixes textures moving around objects on Xenoblade games
 2020-05-29 02:57:30 -03:00
David Marcec 43bf860b22 kernel: ResourceLimit::Reserve remove useless while loop 
Timeout is a u64, it will always be >= 0
 2020-05-29 13:48:01 +10:00
bunnei 1bb3122c1f
Merge pull request #3991 from ReinUsesLisp/depth-sampling 
texture_cache: Implement depth stencil texture swizzles
 2020-05-28 23:33:38 -04:00
bunnei 5242b21524
Merge pull request #4002 from lat9nq/fix-nix-mod-directories 
patch_manager: Add support for case-sensitivity on Linux
 2020-05-28 22:36:39 -04:00
ReinUsesLisp 9b06e823ee maxwell_3d: Reduce severity of logs that can be spammed 
These logs were killing performance on some games when they were
spammed. Reduce them to Debug severity.
 2020-05-28 18:23:25 -03:00
ReinUsesLisp fc153f6bcd format_lookup_table: Implement G24S8 format as S8Z24 2020-05-28 17:16:07 -03:00
lat9nq f57cbd9f24 Make copying directory string more concise 2020-05-28 13:33:50 -04:00
lat9nq 326403518d Address requested changes 2020-05-28 13:30:22 -04:00
bunnei 099ac9c2a8
Merge pull request #3993 from ReinUsesLisp/fix-zla 
gl_shader_manager: Unbind GLSL program when binding a host pipeline
 2020-05-28 12:15:22 -04:00
lat9nq 136c563f76 *nix systems can read any-case patch directories 
Changes many patch_manager functions to use a case-less variant of
GetSubdirectory. Fixes patches not showing up on *nix systems when
patch directories are named with odd cases, i.e. `exeFS'.
 2020-05-27 23:12:56 -04:00
bunnei 640f0d1cec
Merge pull request #3954 from Morph1984/log-memory-amount 
main: Log host system memory parameters
 2020-05-27 22:58:51 -04:00
ReinUsesLisp 3b2dee88e6 buffer_cache: Avoid copying twice on certain cases 
Avoid copying to a staging buffer on non-granular memory addresses.
Add a callable argument to StreamBufferUpload to be able to copy to the
staging buffer directly from ReadBlockUnsafe.
 2020-05-27 23:05:50 -03:00
ReinUsesLisp b8b6f94ba9 texture_cache: Use unordered_map::find instead of operator[] on hot code 2020-05-27 17:59:04 -03:00
bunnei 630fc12d4e
Merge pull request #3961 from Morph1984/bgra8_srgb 
maxwell_to_vk: Add format B8G8R8A8_SRGB and add Attachable capability for B8G8R8A8_UNORM
 2020-05-27 16:44:22 -04:00
ReinUsesLisp d2b2557542 texture_cache: Use small vector for surface vectors 
This avoids most heap allocations when collecting surfaces into a
vector.
 2020-05-27 17:31:14 -03:00
ReinUsesLisp f3f056c3b6 maxwell_3d: Initialize line widths 
Initialize line widths to avoid setting a line width of zero.
 2020-05-27 16:53:43 -03:00
ReinUsesLisp 31eb658fea maxwell_3d: Initialize polygon modes 
NVN expects this to be initialized as Fill, otherwise games that never
bind a rasterizer state will log an invalid polygon mode.
 2020-05-27 16:52:52 -03:00
Morph b2af304918 Fix macOS code and change "Swapfile" to "Swap" 2020-05-27 11:21:59 -04:00
ReinUsesLisp 32e6727dae shader/other: Implement MEMBAR.CTS 
This silences an assertion we were hitting and uses workgroup memory
barriers when the game requests it.
 2020-05-27 00:19:45 -03:00
ReinUsesLisp b2c4521a91 texture_cache: Fix layered null surfaces 
Null texture cubes were not considered arrays, causing issues on Vulkan
and OpenGL when creating views.
 2020-05-26 17:50:08 -03:00
ReinUsesLisp b17fe82973 gl_texture_cache: Implement small texture view cache for swizzles 
This fixes cases where the texture swizzle was applied twice on the same
draw to a texture bound to two different slots.
 2020-05-26 17:50:08 -03:00
ReinUsesLisp 8bba84a401 texture_cache: Implement depth stencil texture swizzles 
Stop ignoring image swizzles on depth and stencil images.

This doesn't fix a known issue on Xenoblade Chronicles 2 where an OpenGL
texture changes swizzles twice before being used. A proper fix would be
having a small texture view cache for this like we do on Vulkan.
 2020-05-26 17:44:50 -03:00
ReinUsesLisp 606a62d4c7 gl_rasterizer: Port front face flip check from Vulkan 
While Vulkan was assuming we had no negative viewports, OpenGL code
was assuming we had them. Port the old code from Vulkan to OpenGL,
checking if the first viewport is negative before flipping faces.

This is not a complete implementation since we only check for the first
viewport to be negative. That said, unless a game is using Vulkan,
OpenGL and NVN games should be fine here, and we can always compare with
our Vulkan backend to see if there's a difference.
 2020-05-26 16:33:50 -03:00
ReinUsesLisp efe7b7483b fixed_pipeline_state: Remove unnecessary check for front faces flip 
The check to flip faces when viewports are negative were a left over
from the old OpenGL code. This is not required on Vulkan where we have
negative viewports.
 2020-05-26 16:32:27 -03:00
bunnei 508242c267
Merge pull request #3981 from ReinUsesLisp/bar 
shader/other: Implement BAR.SYNC 0x0
 2020-05-26 14:40:13 -04:00
bunnei 623d9c47a2
Merge pull request #3980 from ReinUsesLisp/red-op 
shader/memory: Implement non-addition operations in RED
 2020-05-26 12:50:41 -04:00
ReinUsesLisp c13e2f1b75 gl_shader_manager: Unbind GLSL program when binding a host pipeline 
Fixes regression in Link's Awakening caused by 420cc13248
 2020-05-26 04:20:39 -03:00
bunnei 86345c126a
Merge pull request #3978 from ReinUsesLisp/write-rz 
shader_decompiler: Visit source nodes even when they assign to RZ
 2020-05-25 21:31:33 -04:00
bunnei 1adabdac7f
Merge pull request #3905 from FernandoS27/vulkan-fix 
Correct a series of crashes and intructions on Async GPU and Vulkan Pipeline
 2020-05-24 15:23:38 -04:00
bunnei 325e7eed3c
Merge pull request #3964 from ReinUsesLisp/arb-integration 
renderer_opengl: Add assembly program code paths
 2020-05-24 00:34:12 -04:00
bunnei 487dd05170
Merge pull request #3979 from ReinUsesLisp/thread-group 
shader/other: Implement thread comparisons (NV_shader_thread_group)
 2020-05-24 00:33:06 -04:00
bunnei 6a5cf1473e
Merge pull request #3975 from ReinUsesLisp/fast-bufcache 
buffer_cache: Replace boost::icl::interval_map with boost::intrusive::set
 2020-05-24 00:32:44 -04:00
Tobias d0a9caa08f
yuzu/discord_impl: Update the applicationID (#3977) 2020-05-22 18:26:26 +02:00
ReinUsesLisp 5d0986a53b shader/other: Implement BAR.SYNC 0x0 
Trivially implement this particular case of BAR. Unless games use OpenCL
or CUDA barriers, we shouldn't hit any other case here.
 2020-05-21 23:20:43 -03:00
ReinUsesLisp 103809a0ca shader/memory: Implement non-addition operations in RED 
Trivially implement these instructions. They are used in Astral Chain.
 2020-05-21 23:19:46 -03:00
ReinUsesLisp e2b67a868b shader/other: Implement thread comparisons (NV_shader_thread_group) 
Hardware S2R special registers match gl_Thread*MaskNV. We can trivially
implement these using Nvidia's extension on OpenGL or naively stubbing
them with the ARB instructions to match. This might cause issues if the
host device warp size doesn't match Nvidia's. That said, this is
unlikely on proper shaders.

Refer to the attached url for more documentation about these flags.
https://www.khronos.org/registry/OpenGL/extensions/NV/NV_shader_thread_group.txt
 2020-05-21 23:18:37 -03:00
ReinUsesLisp ed4e324991 shader_decompiler: Visit source nodes even when they assign to RZ 
Some operations like atomicMin were ignored because they returned were
being stored to RZ. This operations have a side effect and it was being
ignored.
 2020-05-21 23:16:03 -03:00
ReinUsesLisp 434856c636 vk_shader_decompiler: Don't assert for void returns 
Atomic instructions can be used without returning anything and this is
valid code. Remove the assert.
 2020-05-21 23:16:03 -03:00
ReinUsesLisp ebaace294f buffer_cache: Remove unused boost headers 2020-05-21 16:44:00 -03:00
ReinUsesLisp a2dcc642c1 map_interval: Add interval allocator and drop hack 
Drop the std::list hack to allocate memory indefinitely.

Instead use a custom allocator that keeps references valid until
destruction. This allocates fixed chunks of memory and puts pointers in
a free list. When an allocation is no longer used put it back to the
free list, this doesn't heap allocate because std::vector doesn't change
the capacity. If the free list is empty, allocate a new chunk.
 2020-05-21 16:44:00 -03:00
ReinUsesLisp 19d4f28001 buffer_cache: Use boost::container::small_vector for maps in range 
Most overlaps in the buffer cache only contain one mapped address.
We can avoid close to all heap allocations once the buffer cache is
warmed up by using a small_vector with a stack size of one.
 2020-05-21 16:44:00 -03:00
ReinUsesLisp 891236124c buffer_cache: Use boost::intrusive::set for caching 
Instead of using boost::icl::interval_map for caching, use
boost::intrusive::set. interval_map is intended as a container where the
keys can overlap with one another; we don't need this for caching
buffers and a std::set-like data structure that allows us to search with
lower_bound is enough.
 2020-05-21 16:44:00 -03:00
ReinUsesLisp 3b0baf746e buffer_cache: Remove shared pointers 
Removing shared pointers is a first step to be able to use intrusive
objects and keep allocations close to one another in memory.
 2020-05-21 16:02:54 -03:00
ReinUsesLisp 599274e3f0 buffer_cache: Minor style changes 
Minor style changes. Mostly done so I avoid editing it while doing other
changes.
 2020-05-21 16:02:20 -03:00
VolcaEM cb75ccc1f7
clang-format 2020-05-21 10:43:55 +02:00
VolcaEM 235805edf3
nifm: correct assert in CreateTemporaryNetworkProfile 
This has been wrong since 0432af5ad1
I haven't found a game that called this function (and I haven't tried this on a real Switch), and because of this I haven't been able to check if the number in assert OR the string in the assert is wrong, but one of the two is wrong:
NetworkProfileData is 0x18E, while SfNetworkProfileData is 0x17C, according to Switchbrew
Switchbrew doesn't officially say that NetworkProfileData's size is 0x18E but it's possible to calculate its size since Switchbrew provides the size and the offset of all the components of NetworkProfileData (which isn't currently implemented in yuzu, alongside SfNetworkProfileData)
NetworkProfileData documentation: https://switchbrew.org/wiki/Network_Interface_services#NetworkProfileData
SfNetworkProfileData documentation: https://switchbrew.org/wiki/Network_Interface_services#SfNetworkProfileData
Since I trust ogniK's work on reversing NIFM, I'd assume this was just a typo in the string
 2020-05-21 10:23:53 +02:00
bunnei ae61e47cba
Merge pull request #3946 from ogniK5377/sysverdat-10-0-2 
file_sys: Update SystemVersion archive to version 10.0.2
 2020-05-20 19:21:27 -04:00
FearlessTobi 9f82a9a244 crypto: Make KeyManager a singleton class 
Previously, we were reading the keys everytime a KeyManager object was created, causing yuzu to reread the keys file multiple hundreds of times when loading the game list.
With this change, it is only loaded once.
On my system, this decreased game list loading times by a factor of 20.
 2020-05-20 21:28:16 +02:00
ReinUsesLisp 420cc13248 renderer_opengl: Add assembly program code paths 
Add code required to use OpenGL assembly programs based on
NV_gpu_program5. Decompilation for ARB programs is intended to be added
in a follow up commit. This does **not** include ARB decompilation and
it's not in an usable state.

The intention behind assembly programs is to reduce shader stutter
significantly on drivers supporting NV_gpu_program5 (and other required
extensions). Currently only Nvidia's proprietary driver supports these
extensions.

Add a UI option hidden for now to avoid people enabling this option
accidentally.

This code path has some limitations that OpenGL compatibility doesn't
have:
- NV_shader_storage_buffer_object is limited to 16 entries for a single
OpenGL context state (I don't know if this is an intended limitation, an
specification issue or I am missing something). Currently causes issues
on The Legend of Zelda: Link's Awakening.
- NV_parameter_buffer_object can't bind buffers using an offset
different to zero. The used workaround is to copy to a temporary buffer
(this doesn't happen often so it's not an issue).

On the other hand, it has the following advantages:
- Shaders build a lot faster.
- We have control over how floating point rounding is done over
individual instructions (SPIR-V on Vulkan can't do this).
- Operations on shared memory can be unsigned and signed.
- Transform feedbacks are dynamic state (not yet implemented).
- Parameter buffers (uniform buffers) are per stage, matching NVN and
hardware's behavior.
- The API to bind and create assembly programs makes sense, unlike
ARB_separate_shader_objects.
 2020-05-19 18:00:04 -03:00
ReinUsesLisp 47a7c4f4fe yuzu: Add frontend settings for assembly shaders 
Add settings for assembly shaders. Currently hidden to avoid users from
accidentally enabled them.
 2020-05-19 17:53:17 -03:00
bunnei cf4ee279c6
Merge pull request #3926 from ogniK5377/keyboard-states 
hid: Clear keyboard states & fix logic issue
 2020-05-19 15:55:14 -04:00
Morph d0fc12684a maxwell_to_vk: Add format B8G8R8A8_SRGB 
Add format B8G8R8A8_SRGB and add Attachable capability for B8G8R8A8_UNORM
Used by Bravely Default II
 2020-05-18 13:02:09 -04:00
Fernando Sahmkow 4cff5dd194 OpenGL: Enable Debug Context and Synchronous debugging when graphics debugging is enabled. 
This commit aims to help easing debugging of driver crashes without
having to modify existing code.
 2020-05-17 21:45:09 -04:00
Morph 9a36d8600c main: Log host system memory parameters 
Logs both physical memory and swapfile sizes, this is useful for support.
 2020-05-17 14:45:12 -04:00
bunnei 65010607b7
Merge pull request #3665 from bunnei/device-save 
FS: Improve emulation of device saves
 2020-05-16 12:39:58 -04:00
bunnei 3c378a31b5
Merge pull request #3945 from ogniK5377/nvflinger-pixformat 
nv_flinger: Use enum for pixel format instead of u32
 2020-05-16 02:00:50 -04:00
David Marcec 17455b7222 file_sys: Update SystemVersion archive to version 10.0.2 2020-05-16 13:56:06 +10:00
David Marcec 6f0360690b nv_flinger: Use enum for pixel format instead of u32 2020-05-16 13:47:55 +10:00
David Marcec 4b9504028d DmaPusher: Remove dead code in step 2020-05-16 12:42:27 +10:00
bunnei 55c0dd1cb3
Merge pull request #3942 from ReinUsesLisp/flush-and-invalidate 
vk_rasterizer: Match OpenGL's FlushAndInvalidate behavior
 2020-05-15 21:34:07 -04:00
ReinUsesLisp 7a27b7f3a3 vk_rasterizer: Match OpenGL's FlushAndInvalidate behavior 
Match OpenGL's behavior. This can fix or simplify bisecting issues on
Vulkan.
 2020-05-15 20:40:08 -03:00
Morph b73f678ee8 frontend: Set minimum window size to 640x360 instead of 1280x720 (#3413) 2020-05-15 22:22:27 +02:00
bunnei 024c84d2db
Merge pull request #3927 from jroweboy/fix-bug 
Frontend: Remove tracking for context wrapper
 2020-05-14 00:07:38 -04:00
bunnei 0e2ded049d
Merge pull request #3757 from ogniK5377/better-voice-mixing 
audio_renderer: Better voice mixing and 6 channel downmixing
 2020-05-13 22:46:41 -04:00
bunnei 670a7f51e8
Merge pull request #3909 from bunnei/timezone 
Improve time zone support
 2020-05-13 21:41:45 -04:00
bunnei b1a1bd12ca
Merge pull request #3899 from ReinUsesLisp/float-comparisons 
shader_ir: Add separate instructions for ordered and unordered comparisons and fix NE on GLSL
 2020-05-13 09:51:14 -04:00
ReinUsesLisp 91dddca26e vk_rasterizer: Implement constant attributes 
Constant attributes (in OpenGL known disabled attributes) are not
supported on Vulkan, even with extensions. To emulate this behavior we
return zero on reads from disabled vertex attributes in shader code.
This has no caching cost because attribute formats are not dynamic state
on Vulkan and we have to store it in the pipeline cache anyway.

- Fixes Animal Crossing: New Horizons terrain borders
 2020-05-13 04:36:47 -03:00
ReinUsesLisp cf6a40fc12 vk_rasterizer: Remove buffer check in attribute selection 
This was a left over from OpenGL when disabled buffers where not properly
emulated. We no longer have to assert this as it is checked in vertex
buffer initialization.
 2020-05-13 04:36:47 -03:00
bunnei bba54e1880 time_zone: Use std::chrono::seconds for strong typing. 2020-05-12 18:44:07 -04:00
James Rowe 1585981eec Frontend: Remove tracking for context wrapper 2020-05-11 23:50:03 -06:00
David Marcec a79f060ea2 hid: Clear keyboard states & fix logic issue 
Previously we never cleared the states of the entries and the key would stay held down, also looping over the key bytes for each key lead to setting every bit for the key state instead of the key we wanted
 2020-05-12 12:40:50 +10:00
bunnei 1beaebe666
Merge pull request #3816 from ReinUsesLisp/vk-rasterizer-enable 
vk_graphics_pipeline: Implement rasterizer_enable on Vulkan
 2020-05-11 18:22:51 -04:00
bunnei 3c8cd62b0d hle: service: time_zone_manager: Use current time zone setting. 2020-05-11 17:55:25 -04:00
bunnei 33441fa728 common: Add module to get the current time zone. 2020-05-11 17:51:26 -04:00
bunnei 988e42a3f5 core: settings: Add a setting for time zone. 2020-05-11 17:50:07 -04:00
David Marcec 16c0373adc fix logic error & scale sample volume based on voice volume 2020-05-11 12:56:15 -04:00
David Marcec c4e7ec7a99 pass by const ref instead 2020-05-11 12:56:15 -04:00
David Marcec 9de860a419 audio_renderer: Better voice mixing and 6 channel downmixing 
Supersedes #3738 and #3321
 2020-05-11 12:56:15 -04:00
bunnei 47b97b9577 service: fsp_srv: Stub implementation of OpenMultiCommitManager. 2020-05-11 12:54:30 -04:00
bunnei 551c61bf27 yuzu: game_list: Fix 'Open Save Data Location' for device saves. 2020-05-11 12:54:30 -04:00
bunnei ab9ddab0a2 file_sys: savefata_factory: Update to support DeviceSaveData. 2020-05-11 12:54:30 -04:00
bunnei 9c065c013e file_sys: control_metadata: Expose device_save_data_size. 2020-05-11 12:54:30 -04:00
David Marcec ecc8ccc9d3 Stub SendKeyboardLockKeyEvent 
Needed for Puchikon 4 SmileBASIC 1.0.0
 2020-05-12 01:01:50 +10:00
ReinUsesLisp 8b329ddcc9 gl_shader_decompiler: Properly emulate NaN behaviour on NE 
"Not equal" operators on GLSL seem to behave as unordered when we expect
an ordered comparison.

Manually emulate this checking for LGE values (numbers, not-NaNs).
 2020-05-10 02:59:33 -03:00
Fernando Sahmkow 1887afaf9e RasterizerCache: Correct documentation. 2020-05-09 21:03:39 -04:00
Fernando Sahmkow 8d15f8b28e VkPipelineCache: Use a null shader on invalid address. 2020-05-09 20:51:34 -04:00
Fernando Sahmkow 0a4be73b9b VideoCore: Use SyncGuestMemory mechanism for Shader/Pipeline Cache invalidation. 2020-05-09 19:25:29 -04:00
Rodrigo Locatti 7e376af8fc
Merge pull request #3839 from Morph1984/r8g8ui 
texture: Implement R8G8UI
 2020-05-09 05:28:55 -03:00
ReinUsesLisp 4e57f9d5cf shader_ir: Separate float-point comparisons in ordered and unordered 
This allows us to use native SPIR-V instructions without having to
manually check for NAN.
 2020-05-09 04:55:15 -03:00
bunnei a9ee6e346b
Merge pull request #3842 from makigumo/maxwell_to_vk_vertexattribute_signed_int 
maxwell_to_vk: implement missing signed int formats
 2020-05-09 00:36:09 -04:00
James Rowe bc30a591ba
Replace externals with Conan (#3735) 
* Remove git submodules that will be loaded through conan

* Move custom Find modules to their own folder

* Use conan for downloading missing external dependencies

* CI: Change the yuzu source folder user to the user that the containers run on

* Attempt to remove dirty mingw build hack

* Install conan on the msvc build

* Only set release build type when using not using multi config generator

* Re-add qt bundled to workaround an issue with conan qt not downloading prebuilt binaries

* Add workaround for submodules that use legacy CMAKE variables

* Re-add USE_BUNDLED_QT on the msvc build bot
 2020-05-08 17:09:29 -04:00
bunnei 50c27d5ae1
Merge pull request #3885 from ReinUsesLisp/viewport-swizzles 
video_core: Implement viewport swizzles with NV_viewport_swizzle
 2020-05-08 15:16:53 -04:00
bunnei 1121960f0e
Merge pull request #3879 from lioncash/global2 
hle_ipc: Eliminate core memory globals
 2020-05-07 19:13:34 -04:00
bunnei 028f6fdbf6
Merge pull request #3884 from ReinUsesLisp/border-colors 
vk_sampler_cache: Use VK_EXT_custom_border_color when available
 2020-05-07 12:18:53 -04:00
FearlessTobi 9e5af4ad30 Menubar: fix mouse tracking bug 
Co-Authored-By: Vitor K <vitor-k@users.noreply.github.com>
 2020-05-06 22:14:52 +02:00
bunnei 41682e0888
Merge pull request #3815 from FernandoS27/command-list-2 
GPU: More optimizations to GPU Command List Processing and DMA Copy Optimizations
 2020-05-05 17:12:42 -04:00
bunnei 88141bb2d4
Merge pull request #3881 from lioncash/mem-warning 
kernel/memory: Resolve several compiler warnings
 2020-05-05 15:41:18 -04:00
bunnei eb2c50c5e6
Update src/video_core/gpu.cpp 
Co-authored-by: David <25727384+ogniK5377@users.noreply.github.com>
 2020-05-05 15:39:44 -04:00
bunnei ea09930196
Update src/video_core/gpu.cpp 
Co-authored-by: David <25727384+ogniK5377@users.noreply.github.com>
 2020-05-05 15:39:37 -04:00
ReinUsesLisp 227278098a vk_sampler_cache: Use VK_EXT_custom_border_color when available 
This should fix grass interactions on Breath of the Wild on Vulkan.
It is currently untested against validation layers.

Nvidia's Windows 443.09 beta driver or Linux 440.66.12 is required for
now.
 2020-05-04 20:49:23 -03:00
bunnei 929acd4d1e
Merge pull request #3880 from lioncash/encoding 
kernel/memory: Amend potential encoding warnings
 2020-05-04 18:50:29 -04:00
ReinUsesLisp 2dbf5290f2 vk_graphics_pipeline: Implement viewport swizzles with NV_viewport_swizzle 2020-05-04 18:31:17 -03:00
ReinUsesLisp f813cd3ff7 gl_rasterizer: Implement viewport swizzles with NV_viewport_swizzle 2020-05-04 17:51:30 -03:00
ReinUsesLisp 9b8e962368 maxwell_3d: Add viewport swizzles 2020-05-04 17:50:59 -03:00
bunnei 500e9c5969
Merge pull request #3843 from ogniK5377/GetPopFromGeneralChannelEvent 
am: IHomeMenuFunctions:GetPopFromGeneralChannelEvent
 2020-05-04 16:20:11 -04:00
bunnei fc04108c77
Merge pull request #3637 from FearlessTobi/port-5094 
Port citra-emu/citra#5094: "yuzu: Option to hide mouse on inactivity"
 2020-05-03 23:16:19 -04:00
bunnei 29fce1a187
Merge pull request #3822 from ogniK5377/GetAccountId 
acc: Return a unique value per account for GetAccountId
 2020-05-03 23:15:03 -04:00
Lioncash 4620580245 kernel/memory: Remove #pragma once within cpp file 
This isn't necessary in a cpp file and will cause warnings on clang.
 2020-05-03 13:42:07 -04:00
Lioncash 1ecaa86a52 kernel/memory: Remove unused includes 
Prevents header churn and needing to recompile these files if these
headers are ever changed in the future.
 2020-05-03 13:41:18 -04:00
Lioncash a2e61e6542 kernel/memory: Remove unused variables in memory_block_manager 
Prevents unused variable warnings.
 2020-05-03 13:36:20 -04:00
Lioncash 26aee55aef kernel/memory: Make use of std::array consistently in address_space_info 
This allows tuning standard library implementations to enable or disable
range checks at runtime, which is nicer for debugging.
 2020-05-03 13:34:24 -04:00
Lioncash dfa582169b kernel/memory: Resolve -Wshadow warnings 
Prevents variable name clashing.
 2020-05-03 13:29:42 -04:00
Lioncash 93c083aef1 kernel/memory: Amend potential encoding warnings 
While èis generally representable in some language encodings, in some
it isn't and will result in compilation warnings occurring. To remain
friendly with other language's codepages on Windows, we normalize it to
an ASCII e.
 2020-05-03 13:01:03 -04:00
Lioncash 0ec07e8763 hle_ipc: Eliminate core memory globals 
We can just pass the required instances into the constructor of the
request, eliminating all usages of the global system accessor.
 2020-05-03 12:57:40 -04:00
Morph 3cfa7a89e0
settings: Add anisotropic filtering level to the yuzu configuration log (#3875) 2020-05-03 17:42:17 +02:00
bunnei 2aff0b4733
Merge pull request #3808 from ReinUsesLisp/wait-for-idle 
{maxwell_3d,buffer_cache}: Implement memory barriers using 3D registers
 2020-05-03 02:43:18 -04:00
Mat M 3309a6cdf1
Merge pull request #3872 from FearlessTobi/reopen-3792 
input_common: fix build when SDL2 is disabled
 2020-05-03 01:01:11 -04:00
bunnei 8db4feb5b4
Merge pull request #3871 from lioncash/semi 
readable_event: Remove unnecessary semicolon in Signal()
 2020-05-02 23:38:36 -04:00
bunnei 7459215933
Merge pull request #3824 from ogniK5377/GetDisplayVersion 
am: Properly implement GetDisplayVersion
 2020-05-02 23:35:38 -04:00
bunnei c49f51eaf1
Update src/core/hle/service/am/am.cpp 
Co-authored-by: Mat M. <mathew1800@gmail.com>
 2020-05-02 23:35:31 -04:00
FearlessTobi 3d1e741645 input_common: fix build when SDL2 is disabled 2020-05-02 21:47:17 +02:00
Lioncash aabf5b2059 readable_event: Remove unnecessary semicolon in Signal() 
Resolves a -Wextra-semi warning.

While we're at it, we can invert the branch to form a guard clause,
unindenting all of the contained code.
 2020-05-02 14:07:31 -04:00
bunnei 30bd77c6e7
Merge pull request #3811 from ogniK5377/audin-init 
audin:u: ListAudioIns, OpenAudioIn, ListAudioInsAuto, OpenAudioInAuto, ListAudioInsAutoFiltered, OpenAudioInProtocolSpecified
 2020-05-02 13:11:52 -04:00
bunnei 5ddcc1b2f5
Merge pull request #3819 from ogniK5377/err-log2 
kernel: Don't fail silently
 2020-05-02 02:51:50 -04:00
bunnei f4ca8e0d3e
Merge pull request #3732 from lioncash/header 
vulkan: Remove unnecessary includes
 2020-05-02 01:36:57 -04:00
bunnei 0128901102
Merge pull request #3809 from ReinUsesLisp/empty-index 
vk_rasterizer: Skip index buffer setup when vertices are zero
 2020-05-02 01:21:57 -04:00
ReinUsesLisp 3b668e1210 vk_graphics_pipeline: Implement rasterizer_enable on Vulkan 
We can simply enable rasterizer discard matching the current pipeline
key.
 2020-05-02 01:47:25 -03:00
bunnei e6b4311178
Merge pull request #3693 from ReinUsesLisp/clean-samplers 
shader/texture: Support multiple unknown sampler properties
 2020-05-02 00:45:41 -04:00
Mat M 5f2a9a4c86
Merge pull request #3859 from jbeich/clang 
Unbreak build with Clang < 10
 2020-05-01 23:39:12 -04:00
bunnei 1bcdf5e61c
Merge pull request #3833 from qwell/caps_su-32-stub 
Add stub for caps:su SetShimLibraryVersion
 2020-05-01 23:34:05 -04:00
bunnei fd005585f6
Merge pull request #3821 from ogniK5377/InitializeApplicationInfo-fix 
acc: Fix InitializeApplicationInfo
 2020-05-01 22:06:05 -04:00
bunnei 224cf3075c
Merge pull request #3812 from ogniK5377/lisst-qualified-users 
account: ListQualifiedUsers
 2020-05-01 22:05:37 -04:00
Jan Beich b4d0724a63 fixed_pipeline_state: explicitly use template keyword after 1f345ebe3a 
In file included from src/video_core/renderer_opengl/renderer_opengl.cpp:25:
In file included from src/./video_core/renderer_opengl/gl_rasterizer.h:26:
In file included from src/./video_core/renderer_opengl/gl_fence_manager.h:11:
src/./video_core/fence_manager.h:91:32: error: use 'template' keyword
      to treat 'Write' as a dependent template name
                memory_manager.Write<u32>(current_fence->GetAddress(), current_fence->GetPayload());
                               ^
                               template
src/./video_core/fence_manager.h:137:32: error: use 'template'
      keyword to treat 'Write' as a dependent template name
                memory_manager.Write<u32>(current_fence->GetAddress(), current_fence->GetPayload());
                               ^
                               template
 2020-05-01 23:38:23 +00:00
David Marcec d5a69ecb68 nvdrv: Fix GetGpuTime stack corruption 
IoctlGetGpuTime should be 16 bytes, not 8.
 2020-05-02 00:14:37 +10:00
David Marcec 8850d85341 am: IHomeMenuFunctions:GetPopFromGeneralChannelEvent 
QLaunch 1.0.0
 2020-05-01 11:20:43 +10:00
Dan 96ee1b42bc maxwell_to_vk: implement missing signed int formats 2020-04-30 23:39:16 +02:00
Jason Parker 4b16e93f1a caps:su Stub out SetShimLibraryVersion 
Used by Animal Crossing: New Horizons when trying to take a picture.
 2020-04-30 15:16:53 -04:00
Mat M f88d2f5739
Merge pull request #3823 from ogniK5377/setvrmode 
am: IsVrModeEnabled & SetVrModeEnabled fixes
 2020-04-30 13:39:16 -04:00
Mat M ecf1f2e054
Merge pull request #3830 from ogniK5377/GetFriendInvitationStorageChannelEvent 
am: GetFriendInvitationStorageChannelEvent
 2020-04-30 13:38:35 -04:00
Mat M 0a0b676286
Merge pull request #3835 from ogniK5377/GetFreeSpaceSize-GetTotalSpaceSize 
fs-srv: GetFreeSpaceSize & GetTotalSpaceSize
 2020-04-30 13:37:43 -04:00
Mat M 07552d4615
Merge pull request #3832 from ogniK5377/nim-eca-CreateServerInterface 
nim: CreateServerInterface, CreateAccessorInterface, CreateAsyncInterface
 2020-04-30 13:36:04 -04:00
Mat M e6f4251988
Merge pull request #3831 from ogniK5377/caps-su-names 
caps: Add missing service names to caps:su
 2020-04-30 13:32:53 -04:00
Morph 7909860d16 texture: Implement R8G8UI 
- Used by The Walking Dead: The Final Season
 2020-04-30 13:19:36 -04:00
bunnei 96cd5dce85
Merge pull request #3825 from ogniK5377/psm-no-warn 
psm: Mark as debug instead of warning
 2020-04-30 13:11:11 -04:00
bunnei bf3f030a0d
Merge pull request #3807 from ReinUsesLisp/fix-depth-clamp 
maxwell_3d: Fix depth clamping register
 2020-04-30 13:07:31 -04:00
bunnei c7b5a87c90
Merge pull request #3799 from ReinUsesLisp/iadd-cc 
shader: Implement P2R CC, IADD Rd.CC and IADD.X
 2020-04-30 12:56:36 -04:00
bunnei da2b8295e1
Merge pull request #3805 from ReinUsesLisp/preserve-contents 
texture_cache: Reintroduce preserve_contents accurately
 2020-04-30 12:56:19 -04:00
bunnei 6572660fde
Merge pull request #3788 from FernandoS27/revert 
Revert: shader_decode: Fix LD, LDG when track constant buffer.
 2020-04-30 12:55:39 -04:00
David Marcec 78e5f162e2 fs-srv: GetFreeSpaceSize & GetTotalSpaceSize 
Closes #3533

Turns out the functions were already implemented but just never added
 2020-04-30 23:59:57 +10:00
David Marcec 55e423c8b6 nim: CreateServerInterface, CreateAccessorInterface, CreateAsyncInterface 
Closes #3026
 2020-04-30 23:10:20 +10:00
David Marcec 738140fdd8 caps: Add missing service names to caps:su 
SetShimLibraryVersion, SaveScreenShotEx1 & SaveScreenShotEx2 were missing
 2020-04-30 22:51:06 +10:00
David Marcec 10804d6d0e am: GetFriendInvitationStorageChannelEvent 
Closes #3829
 2020-04-30 22:37:26 +10:00
David Marcec 973c40b63e psm: Mark as debug instead of warning 
No point to emulate battery life. However options are broken out if we ever want to add a setting for it
 2020-04-29 22:39:49 +10:00
David Marcec 9acd336422 am: Properly implement GetDisplayVersion 
Properly implement IApplicationFunctions::GetDisplayVersion
 2020-04-29 22:13:56 +10:00
David Marcec 8bddc750e2 am: IsVrModeEnabled & SetVrModeEnabled fixes 
Return the proper state of vr mode for IsVrModeEnabled
We should not return an error for SetVrModeEnabled. When VR Mode is turned on, it signals to lbl to turn vr mode on, not return an error code
 2020-04-29 21:48:58 +10:00
David Marcec 1417849a2b acc: Return a unique value per account for GetAccountId 2020-04-29 21:09:53 +10:00
David Marcec 1fbc341aba acc: Fix InitializeApplicationInfo 
We're not suppose to pop a u64, should just read the sent pid and check that
 2020-04-29 20:49:35 +10:00
David Marcec b6538c3e7c kernel: Don't fail silently 2020-04-29 14:53:53 +10:00
Lioncash 6c53edd4d3 vulkan: Remove unnecessary includes 
Reduces some header churn and reduces rebuilds when some header
internals change.

While we're at it we can also resolve a missing include in buffer_cache.
 2020-04-28 21:54:46 -04:00
bunnei 8e64fb3225
Merge pull request #3771 from benru/dump-romfs-with-updates 
Dump RomFS command to include Updates
 2020-04-28 21:54:06 -04:00
Mat M c3c3e07263
Merge pull request #3818 from ogniK5377/err-log 
Don't fail silently for vi, sm, set and ns services
 2020-04-28 21:41:13 -04:00
Mat M 5cb531b6cf
Merge pull request #3783 from lioncash/pointer 
physical_core: Make use of std::make_unique instead of std::make_shared in ctor
 2020-04-28 21:38:02 -04:00
David Marcec b4dbf1b9c7 Don't fail silently for vi, sm, set and ns services 2020-04-29 11:15:21 +10:00
ReinUsesLisp 871aadbe36 shader/arithmetic_integer: Fix tracking issue in temporary 
This temporary is not needed as we mark Rd.CC + IADD.X as unimplemented.
It caused issues when tracking global buffers.
 2020-04-28 17:14:53 -03:00
Fernando Sahmkow 9df67b2095 Clang Format and Documentation. 2020-04-28 14:02:51 -04:00
Fernando Sahmkow 37c690576f MaxwellDMA: Optimize micro copies. 2020-04-28 13:44:14 -04:00
bunnei 72b73d22ab
Merge pull request #3784 from ReinUsesLisp/shader-memory-util 
shader/memory_util: Deduplicate code
 2020-04-28 12:05:50 -04:00
David Marcec 2261cf24af kernel: Bad GetInfo ids should not be marked as stubs 
As we currently match hardware and don't return a successful result, these should be marked as errors instead of warnings and as stubs.
 2020-04-29 01:17:59 +10:00
David Marcec fdbeb90bd0 Updated comment to reflect ListQualifiedUsers better 2020-04-29 01:13:03 +10:00
David Marcec 0f6064e5c9 style: Change AMs & Glues error codes to be dec instead of hex 
Consistency for the rest of the error codes in the codebase
 2020-04-29 00:49:49 +10:00
David Marcec 1276e425d2 marked stubs 2020-04-29 00:43:05 +10:00
David Marcec a17813c4f4 account: ListQualifiedUsers 
Closes #2844
 2020-04-29 00:37:47 +10:00
David Marcec fb51a655b8 Audin:u ListAudioIns, OpenAudioIn, ListAudioInsAuto, OpenAudioInAuto, ListAudioInsAutoFiltered, OpenAudioInProtocolSpecified 
Closes #2874
 2020-04-29 00:19:07 +10:00
ReinUsesLisp d6a24b4a5b vk_rasterizer: Skip index buffer setup when vertices are zero 
Xenoblade 2 invokes a draw call with zero vertices.
This is likely due to indirect drawing (glDrawArraysIndirect).

This causes a crash in the staging buffer pool when trying to create a
buffer with a size of zero. To workaround this, skip index buffer setup
entirely when the number of indices is zero.
 2020-04-28 02:24:33 -03:00
ReinUsesLisp fe931ac976 {maxwell_3d,buffer_cache}: Implement memory barriers using 3D registers 
Drop MemoryBarrier from the buffer cache and use Maxwell3D's register
WaitForIdle.

To implement this on OpenGL we just call glMemoryBarrier with the
necessary bits.

Vulkan lacks this synchronization primitive, so we set an event and
immediately wait for it. This is not a pretty solution, but it's what
Vulkan can do without submitting the current command buffer to the queue
(which ends up being more expensive on the CPU).
 2020-04-28 02:18:12 -03:00
Fernando Sahmkow b87422a86f VideoCore/GPU: Delegate subchannel engines to the dma pusher. 2020-04-27 22:07:21 -04:00
Fernando Sahmkow 90e5694230 VideoCore/Engines: Refactor Engines CallMethod. 2020-04-27 21:47:58 -04:00
ReinUsesLisp bb1ed66d99 maxwell_3d: Fix depth clamping register 
Using deko3d as reference:
4e47ba0013/source/maxwell/gpu_3d_state.cpp (L42)

We were using bits 3 and 4 to determine depth clamping, but these are
the same both enabled and disabled:

state->depthClampEnable ? 0x101A : 0x181D

The same happens on Nvidia's OpenGL driver, where they do something like
this (default capabilities, GL 4.5 compatibility):

(state & DEPTH_CLAMP) != 0 ? 0x201a : 0x281c

There's always a difference between the first bits in this register, but
bit 11 is consistently disabled on both deko3d/NVN and OpenGL. This
commit changes yuzu's behaviour to use bit 11 to determine depth
clamping.

- Fixes depth issues on Super Mario Odyssey's intro.
 2020-04-27 20:50:14 -03:00
bunnei 4dca2298f9
Merge pull request #3785 from ogniK5377/set-buffer-count-unit 
vi: Don't let uninitialized data pass as a response for SetBufferCount
 2020-04-27 17:10:28 -04:00
Fernando Sahmkow 1517cba8ca
Merge pull request #3766 from ReinUsesLisp/renderpass-cache-key 
vk_renderpass_cache: Pack renderpass cache key and unify keys
 2020-04-27 16:05:14 -04:00
Fernando Sahmkow a65e9ad552
Merge pull request #3756 from ReinUsesLisp/integrated-devices 
vk_memory_manager: Remove unified memory model flag
 2020-04-27 16:04:22 -04:00
Mat M e8e04a4b80
Merge pull request #3797 from slashiee/hid-stub 
services: hid: Stub StopSevenSixAxisSensor.
 2020-04-27 15:37:08 -04:00
bunnei 6c7d8073be
Merge pull request #3742 from FernandoS27/command-list 
Optimize GPU Command Lists and Introduce Fast GPU Time Option
 2020-04-27 00:18:46 -04:00
ReinUsesLisp 8da16cf9fb texture_cache: Reintroduce preserve_contents accurately 
This reverts commit 94b0e2e5da.

preserve_contents proved to be a meaningful optimization. This commit
reintroduces it but properly implemented on OpenGL.

We have to make sure the clear removes all the previous contents of the
image.

It's not currently implemented on Vulkan because we can do smart things
there that's preferred to be introduced in a separate commit.
 2020-04-26 19:53:02 -03:00
bunnei 378aed07e9
Merge pull request #3795 from vitor-k/fix-folder 
Fix "Port citra-emu/citra#4956: "Fixes to game list sorting" #3611"
 2020-04-26 13:55:26 -04:00
bunnei 11e1629d89
Merge pull request #3744 from lioncash/table2 
service: Update function tables
 2020-04-26 04:15:47 -04:00
Rodrigo Locatti 7e38dd580f
Merge pull request #3753 from ReinUsesLisp/ac-vulkan 
{gl,vk}_rasterizer: Add lazy default buffer maker and use it for empty buffers
 2020-04-26 01:55:43 -03:00
ReinUsesLisp ddd82ef42b shader/memory_util: Deduplicate code 
Deduplicate code shared between vk_pipeline_cache and gl_shader_cache as
well as shader decoder code.

While we are at it, fix a bug in gl_shader_cache where compute shaders
had an start offset of a stage shader.
 2020-04-26 01:38:51 -03:00
bunnei 9bd70c52e5
Merge pull request #3791 from Kewlan/hotkey-config-plus 
configuration: Add Restore Default and Clear options to hotkeys
 2020-04-26 00:33:08 -04:00
bunnei ccda5ffa58
Merge pull request #3761 from Kewlan/stick-modifier-slider 
configure_input_player: Use slider to edit modifier scale
 2020-04-25 22:55:41 -04:00
ReinUsesLisp e895a4e2d7 shader/arithmetic_integer: Fix edge case and mark IADD.X Rd.CC as unimplemented 
IADD.X Rd.CC requires some extra logic that is not currently
implemented. Abort when this is hit.
 2020-04-25 22:58:33 -03:00
ReinUsesLisp 2a96bea6a7 shader/arithmetic_integer: Change IAdd to UAdd to avoid signed overflow 
Signed integer addition overflow might be undefined behavior. It's free
to change operations to UAdd and use unsigned integers to avoid
potential bugs.
 2020-04-25 22:57:54 -03:00
ReinUsesLisp c788f9c0bd shader/arithmetic_integer: Implement IADD.X 
IADD.X takes the carry flag and adds it to the result. This is generally
used to emulate 64-bit operations with 32-bit registers.
 2020-04-25 22:56:11 -03:00
ReinUsesLisp 255197e643 shader/arithmetic_integer: Implement CC for IADD 2020-04-25 22:55:26 -03:00
ReinUsesLisp ffc5ec6fa8 decode/register_set_predicate: Implement CC 
P2R CC takes the state of condition codes and puts them into a register.
We already have this implemented for PR (predicates). This commit
implements CC over that.
 2020-04-25 22:54:42 -03:00
ReinUsesLisp d523734266 decode/register_set_predicate: Use move for shared pointers 
Avoid atomic counters used by shared pointers.
 2020-04-25 22:54:14 -03:00
M&M c1ffaa8b29 services: hid: Stub StopSevenSixAxisSensor. 
- Used by The Legend of Zelda: Breath of the Wild v1.6.0
 2020-04-25 15:38:56 -07:00
Vitor Kiguchi dffcff9fec Fix the mistake in the port and update the comment for clarity 2020-04-25 15:01:20 -03:00
bunnei c5bf693882
Merge pull request #3721 from ReinUsesLisp/sort-devices 
vulkan/wrapper: Sort physical devices
 2020-04-25 03:27:40 -04:00
bunnei 4e37825dab
Merge pull request #3734 from ReinUsesLisp/half-float-mods 
decode/arithmetic_half: Fix HADD2 and HMUL2 absolute and negation bits
 2020-04-25 00:41:43 -04:00
bunnei d1e7cf3bdc
Merge pull request #3780 from lioncash/process 
svc: Re-add MapProcessCodeMemory/UnmapProcessCodeMemory
 2020-04-24 23:22:26 -04:00
ReinUsesLisp 527a1574c3 vk_rasterizer: Pack texceptions and color formats on invalid formats 
Sometimes for unknown reasons NVN games can bind a render target format
of 0. This may be a yuzu bug.

With the commits before this the formats were specified without being
"packed", assuming all formats and texceptions will be written like in
the color_attachments vector.

To address this issue, iterate all render targets and pack them as they
are valid. This way they will match color_attachments.

- Fixes validation errors and graphical issues on Breath of the Wild.
 2020-04-24 22:21:29 -03:00
Kewlan a19c6317ef Add Restore Defaults and Clear options to hotkeys 2020-04-24 23:50:26 +02:00
bunnei 7c8acb0025
Merge pull request #3749 from ReinUsesLisp/lea-imm 
shader/arithmetic_integer: Fix LEA_IMM encoding
 2020-04-24 14:30:13 -04:00
Fernando Sahmkow d8a961cd6c Revert: shader_decode: Fix LD, LDG when track constant buffer. 2020-04-24 11:00:54 -04:00
Markus Wick e717a1df20 Fix -Wdeprecated-copy warning. 2020-04-24 09:33:04 +02:00
Markus Wick c499c22cf7 Fix -Werror=conversion error. 2020-04-24 09:33:04 +02:00
David Marcec 03a6f3b0f4 vi: Don't let uninitialized data pass as a response for SetBufferCount 
Currently SetBufferCount doesn't write to the out buffer which then contains uninitialized data. This leads to non-zero data which leads to responding with different error codes
 2020-04-24 17:24:58 +10:00
bunnei 8f548266cd
Merge pull request #3760 from Morph1984/trailing-filedir-separator 
frontend/filesystem: Add a trailing separator to the string path
 2020-04-24 01:44:32 -04:00
Lioncash cc84b48ce5 physical_core: Make use of std::make_unique instead of std::make_shared in ctor 
We can also allow unicorn to be constructed in 32-bit mode or 64-bit
mode to satisfy the need for both interpreter instances.

Allows this code to compile successfully of non x86-64 architectures.
 2020-04-24 00:20:58 -04:00
Rodrigo Locatti f24c67877b
Merge pull request #3777 from lioncash/warn 
page_table: Remove unused captures
 2020-04-23 21:47:54 -03:00
Rodrigo Locatti db3dcb2f64
Merge pull request #3778 from lioncash/unused-var 
svc: Remove unused variable
 2020-04-23 21:47:24 -03:00
Lioncash ce7c02735e shared_memory: Amend doxygen reference 
Amends the parameter to match the documentation reference.

Resolves a -Wdocumentation warning with clang.
 2020-04-23 18:42:14 -04:00
Lioncash 4730347f8e svc: Re-add MapProcessCodeMemory/UnmapProcessCodeMemory 
These were lost in the re-implementation of the virtual memory manager.
 2020-04-23 18:12:04 -04:00
Lioncash bed4865981 svc: Remove unused variable 
Since the VMM refactor, this is no longer used or needed.
 2020-04-23 17:53:26 -04:00
Lioncash f77b5dfe81 page_table: Remove unused captures 
Any time the lambda function is called, the permission being used in the
capture would be passed in as an argument to the lambda, so the capture
is unnecessary.
 2020-04-23 17:33:08 -04:00
ReinUsesLisp dbaebd8582 decode/arithmetic_half: Fix HADD2 and HMUL2 absolute and negation bits 
The encoding for negation and absolute value was wrong.
Extracting is now done manually. Similar instructions having different
encodings is the rule, not the exception. To keep sanity and readability
I preferred to extract the desired bit manually.

This is implemented against nxas:
8dbc389957/table.h (L68)

That is itself tested against nvdisasm (Nvidia's official disassembler).
 2020-04-23 18:29:38 -03:00
ReinUsesLisp 4fb921ff6b shader/texture: Support multiple unknown sampler properties 
This allows deducing some properties from the texture instruction before
asking the runtime. By doing this we can handle type mismatches in some
instructions from the renderer instead of the shader decoder.

Fixes texelFetch issues with games using 2D texture instructions on a 1D
sampler.
 2020-04-23 18:04:13 -03:00
ReinUsesLisp 72deb773fd shader_ir: Turn classes into data structures 2020-04-23 18:00:06 -03:00
ReinUsesLisp 3e35101895 vk_rasterizer: Fix framebuffer creation validation errors 
Framebuffer creation was ignoring the number of color attachments.
 2020-04-23 17:34:16 -03:00
ReinUsesLisp 8c37cd1af6 vk_pipeline_cache: Unify pipeline cache keys into a single operation 
This allows us to call Common::CityHash and std::memcmp only once for
GraphicsPipelineCacheKey. While we are at it, do the same for compute.
 2020-04-23 17:34:16 -03:00
ReinUsesLisp f665c92114 vk_renderpass_cache: Pack renderpass cache key to 12 bytes 2020-04-23 17:34:16 -03:00
Rodrigo Locatti 26f2820ae3
Merge pull request #3768 from H27CK/cmd-title-fmt 
Fix format error in performance statistics
 2020-04-23 16:14:33 -03:00
bunnei ff0c49e1ce
kernel: memory: Improve implementation of device shared memory. (#3707) 
* kernel: memory: Improve implementation of device shared memory.

* fixup! kernel: memory: Improve implementation of device shared memory.

* fixup! kernel: memory: Improve implementation of device shared memory.
 2020-04-23 11:37:12 -04:00
Fernando Sahmkow 5c9feaebb6 Clang Format. 2020-04-23 08:52:58 -04:00
Fernando Sahmkow b8aef40c56 GPU: Add Fast GPU Time Option. 2020-04-23 08:52:57 -04:00
Fernando Sahmkow 18a88d19dc Maxwell3D: Process Macros on MultiMethod. 2020-04-23 08:52:56 -04:00
Fernando Sahmkow 3fedcc2f6e DMAPusher: Propagate multimethod writes into the engines. 2020-04-23 08:52:55 -04:00
Ben Russell bcd0444bb9
Update src/yuzu/main.cpp with missing const 
Co-Authored-By: Mat M. <mathew1800@gmail.com>
 2020-04-23 13:10:06 +01:00
Ben Russell dd43d725c6
Dump RomFS command to include Updates 
Patch the RomFS with the selected updates before dumping. Previously the resulting RomFS only contained data from the original title.

To dump the RomFS without updates the user can disable the update under Properties before choosing Dump RomFS.
 2020-04-23 13:06:18 +01:00
bunnei eb26e9e711
Merge pull request #3730 from lioncash/time 
service/time: Remove reliance on the global system accessor
 2020-04-23 02:41:38 -04:00
bunnei 2409fedacf
Merge pull request #3697 from lioncash/declarations 
CMakeLists: Enable -Wmissing-declarations on Linux builds
 2020-04-23 02:18:52 -04:00
Kewlan 8d917e14f8 Edit modifier_scale with the deadzone slider 2020-04-23 06:32:39 +02:00
H27CK a26a725515 Fix format error in performance statistics 
Formatting
 2020-04-23 04:31:26 +02:00
bunnei bf2ddb8fd5
Merge pull request #3677 from FernandoS27/better-sync 
Introduce Predictive Flushing and Improve ASYNC GPU
 2020-04-22 22:09:38 -04:00
Mat M 2c806c5fd3
Merge pull request #3767 from ReinUsesLisp/point-size-pipeline 
vk_pipeline_cache: Fix unintentional memcpy into optional
 2020-04-22 21:20:14 -04:00
ReinUsesLisp d9463f4562 vk_pipeline_cache: Fix unintentional memcpy into optional 
The intention behind this was to assign a float to from an uint32_t, but
it was unintentionally being copied directly into the std::optional.

Copy to a temporary and assign that temporary to std::optional. This can
be replaced with std::bit_cast<float> once we are in C++20.
 2020-04-22 21:36:05 -03:00
Fernando Sahmkow c043ac4f13 GL_Fence_Manager: use GL_TIMEOUT_IGNORED instead of a loop, 2020-04-22 20:34:32 -04:00
bunnei bee2c64b34
Merge pull request #3725 from MerryMage/fpcr 
thread: FPCR.FZ is likely not 1 (and FPCR.RMode = TieAway and FPCR.DN = 0)
 2020-04-22 19:49:13 -04:00
Fernando Sahmkow 63d2ba4f69
Merge pull request #3763 from H27CK/vk-cmd 
Add missing ;
 2020-04-22 17:43:42 -04:00
H27CK 4d74578d35 Add missing ; 2020-04-22 23:36:21 +02:00
bunnei 5ed13304e1
Merge pull request #3758 from H27CK/vk-cmd 
Introduce dummy context for yuzu-cmd VK support
 2020-04-22 12:37:01 -04:00
Fernando Sahmkow afae40a99e
Merge pull request #3653 from ReinUsesLisp/nsight-aftermath 
renderer_vulkan: Integrate Nvidia Nsight Aftermath on Windows
 2020-04-22 11:39:01 -04:00
Fernando Sahmkow 4e37f1b113 Address Feedback. 2020-04-22 11:36:27 -04:00
Fernando Sahmkow 39e5b72948 Async GPU: Correct flushing behavior to be similar to old async GPU behavior. 2020-04-22 11:36:26 -04:00
Fernando Sahmkow 1b3be8a8f8 MaxwellDMA: Correct copying on accuracy level. 2020-04-22 11:36:25 -04:00
Fernando Sahmkow 644588fd88 ShaderCache/PipelineCache: Cache null shaders. 2020-04-22 11:36:25 -04:00
Fernando Sahmkow f616dc0b59 Address Feedback. 2020-04-22 11:36:24 -04:00
Fernando Sahmkow ec2f3e48e1 Fix GCC error. 2020-04-22 11:36:23 -04:00
Fernando Sahmkow 7f44f22451 Correct Linux Compile Error. 2020-04-22 11:36:22 -04:00
Fernando Sahmkow d2d4a6cbcf Clang format. 2020-04-22 11:36:22 -04:00
Fernando Sahmkow b3e5f177ba QueryCache: Only do async flushes on async gpu. 2020-04-22 11:36:21 -04:00
Fernando Sahmkow f4ab223ef0 Async GPU: Only do reactive flushing on Extreme Level. 2020-04-22 11:36:20 -04:00
ReinUsesLisp b752faf2d3 vk_fence_manager: Initial implementation 2020-04-22 11:36:19 -04:00
Fernando Sahmkow 0649f05900 QueryCache: Implement Async Flushes. 2020-04-22 11:36:18 -04:00
Fernando Sahmkow 131b342130 OpenGL: Guarantee writes to Buffers. 2020-04-22 11:36:18 -04:00
Fernando Sahmkow 1fb516cd97 GPU: Implement Flush Requests for Async mode. 2020-04-22 11:36:17 -04:00
Fernando Sahmkow b7bc3c2549 FenceManager: Manage syncpoints and rename fences to semaphores. 2020-04-22 11:36:16 -04:00
Fernando Sahmkow 96bb961a64 BufferCache: Refactor async managing. 2020-04-22 11:36:15 -04:00
Fernando Sahmkow b10db7e4a5 FenceManager: Implement async buffer cache flushes on High settings 2020-04-22 11:36:15 -04:00
Fernando Sahmkow 4adfc9bb08 Rasterizer: Document SignalFence & ReleaseFences and setup skeletons on Vulkan. 2020-04-22 11:36:14 -04:00
Fernando Sahmkow a081a7c855 GPU: Fix rebase errors. 2020-04-22 11:36:13 -04:00
Fernando Sahmkow e84eb64e51 Rasterizer: Disable fence managing in synchronous gpu. 2020-04-22 11:36:12 -04:00
Fernando Sahmkow 165ae823f5 ThreadManager: Sync async reads on accurate gpu. 2020-04-22 11:36:12 -04:00
Fernando Sahmkow 57fdbd9b89 FenceManager: Implement should wait. 2020-04-22 11:36:11 -04:00
Fernando Sahmkow 1f345ebe3a GPU: Implement a Fence Manager. 2020-04-22 11:36:10 -04:00
Fernando Sahmkow 487379c593 OpenGL: Implement Fencing backend. 2020-04-22 11:36:10 -04:00
Fernando Sahmkow ed7e965712 TextureCache: Flush linear textures after finishing rendering. 2020-04-22 11:36:09 -04:00
Fernando Sahmkow 339d0d9d6c GPU: Delay Fences. 2020-04-22 11:36:08 -04:00
Fernando Sahmkow 8b1eb44b3e BufferCache: Implement OnCPUWrite and SyncGuestHost 2020-04-22 11:36:07 -04:00
Fernando Sahmkow da8f17715d GPU: Refactor synchronization on Async GPU 2020-04-22 11:36:06 -04:00
Fernando Sahmkow a60a22d9c2 Texture Cache: Implement OnCPUWrite and SyncGuestHost 2020-04-22 11:36:05 -04:00
Fernando Sahmkow 084ceb925a UI: Replasce accurate GPU option for GPU Accuracy Level 2020-04-22 11:36:04 -04:00
Morph 91f1ffd283 Add a trailing separator to the string path 
Fixes #3643
 2020-04-22 07:33:14 -04:00
H27CK c883cd103e Init SDL info structure and add dummy context 2020-04-22 07:47:21 +02:00
bunnei e84f82a028
Merge pull request #3699 from FearlessTobi/port-5185 
Port citra-emu/citra#5185: "gdbstub: Fix some gdbstub jankiness"
 2020-04-21 22:26:10 -04:00
ReinUsesLisp 6f47bd9641 vk_memory_manager: Remove unified memory model flag 
All drivers (even Intel) seem to have a device local memory type that is
not host visible. Remove this flag so all devices follow the same path.

This fixes a crash when trying to map to host device local memory on
integrated devices.
 2020-04-21 22:06:38 -03:00
bunnei d64290884a
Merge pull request #3714 from lioncash/copies 
gl_shader_decompiler: Avoid copies where applicable
 2020-04-21 20:16:02 -04:00
bunnei cd47ccec49
Merge pull request #3745 from bunnei/fix-homebrew-load 
Fix process memory initialization for ELF and NRO
 2020-04-21 18:59:16 -04:00
ReinUsesLisp 488ed8bd02 vk_rasterizer: Add lazy default buffer maker and use it for empty buffers 
Introduce a default buffer getter that lazily constructs an empty
buffer. This is intended to match OpenGL's buffer 0.

Use this for disabled vertex and uniform buffers.

While we are at it, include vertex buffer usages for staging buffers to
silence validation errors.
 2020-04-21 19:55:52 -03:00
ReinUsesLisp 0bbae63300 gl_rasterizer: Fix buffers without size 
On NVN buffers can be enabled but have no size. According to deko3d and
the behavior we see in Animal Crossing: New Horizons these buffers get
the special address of 0x1000 and limit themselves to 0xfff.

Implement buffers without a size by binding a null buffer to OpenGL
without a side.

1d1930beea/source/maxwell/gpu_3d_vbo.cpp (L62-L63)
 2020-04-21 19:55:44 -03:00
Rodrigo Locatti f293b15611
Merge pull request #3718 from ReinUsesLisp/better-pipeline-state 
fixed_pipeline_state: Pack structure, use memcmp and CityHash on it
 2020-04-21 18:17:58 -03:00
bunnei 9bf3abcb63
Merge pull request #3698 from lioncash/warning 
General: Resolve minor assorted warnings
 2020-04-21 14:11:18 -04:00
bunnei 48b670d132
Merge pull request #3724 from bunnei/fix-unicorn 
core: arm_unicorn: Fix interpret fallback by temporarily mapping instruction page.
 2020-04-20 23:28:23 -04:00
David 11c63ca969
audio_renderer: Preliminary BehaviorInfo (#3736) 
* audio_renderer: Preliminary BehaviorInfo

* clang format

* Fixed IsRevisionSupported

* fixed IsValidRevision

* Fixed logic error & spelling errors & crash

* Addressed issues
 2020-04-20 22:57:30 -04:00
bunnei d3e0cefa60
Merge pull request #3695 from ReinUsesLisp/default-attributes 
maxwell_3d: Initialize format attributes constant as one
 2020-04-20 21:40:18 -04:00
ReinUsesLisp 8734ccb0cb shader/arithmetic_integer: Fix LEA_IMM encoding 
The operand order in LEA_IMM was flipped compared to nvdisasm. Fix that
using nxas as reference:

8dbc389957/table.h (L122)
 2020-04-20 21:54:59 -03:00
Mat M cb5b8ca886
Merge pull request #3733 from ambasta/patch-2 
Initialize quad_indexed_pass before uint8_pass
 2020-04-20 20:36:46 -04:00
bunnei 9c12aef2f8 loader: nro: Fix process initialization using ProgramMetadata default. 2020-04-20 18:19:45 -04:00
bunnei 68039addbc loader: elf: Fix process initialization using ProgramMetadata default. 2020-04-20 18:19:45 -04:00
bunnei f0a7f05070 file_sys: program_metadata: Add a helper function for generating reasonable default metadata. 
- We need this for homebrew process initialization.
 2020-04-20 18:19:45 -04:00
Lioncash 99eaa2e6f2 service: Update function tables 
Keeps the service function tables up to date.

Updated based off information on SwitchBrew.
 2020-04-20 15:53:49 -04:00
Mat M 200f69d2ff
Merge pull request #3739 from MerryMage/disable_cpu_opt 
dynarmic: Add option to disable CPU JIT optimizations
 2020-04-20 14:19:18 -04:00
FearlessTobi 4e99a06c70 npad: Lower log level for VibrateController to Debug 2020-04-20 18:44:57 +02:00
FearlessTobi 6ce0f3575a audren: Lower log level for RequestUpdateImpl to Debug 2020-04-20 18:44:41 +02:00
Fernando Sahmkow ec2f8f4272
Merge pull request #3700 from ReinUsesLisp/stream-buffer-sizes 
vk_stream_buffer: Fix out of memory on boot on recent Nvidia drivers
 2020-04-20 09:37:42 -04:00
MerryMage a3a12deecc dynarmic: Add option to disable CPU JIT optimizations 2020-04-20 13:36:26 +01:00
bunnei 6de36f0b61
Merge pull request #3712 from lioncash/remove 
service: Remove unused RequestParser instances
 2020-04-20 01:04:04 -04:00
bunnei e3977243e2
Merge pull request #3709 from lioncash/am 
am: Resolve ineffective moves
 2020-04-20 00:15:00 -04:00
FearlessTobi e7664b7a4f yuzu: Option to hide mouse on inactivity 
Co-Authored-By: Vitor K <vitor-k@users.noreply.github.com>
 2020-04-20 04:21:58 +02:00
Amit Prakash Ambasta 5324b1d01e
Initialize quad_indexed_pass before uint8_pass 
Fixes Werror=reorder in gcc
 2020-04-20 04:53:52 +05:30
Rodrigo Locatti 4932010c6f
Merge pull request #3729 from lioncash/globals 
dma_pusher: Remove reliance on the global system instance
 2020-04-19 19:12:40 -03:00
bunnei 85c17a2c35
Merge pull request #3694 from ReinUsesLisp/indexed-quads 
vk_compute_pass: Implement indexed quads
 2020-04-19 16:52:40 -04:00
Lioncash bfee33cce3 service/time: Remove reliance on the global system accessor 
Eliminates usages of the global system accessor and instead passes the
existing system instance into the interfaces.
 2020-04-19 16:31:28 -04:00
Lioncash 44e959157b dma_pusher: Remove reliance on the global system instance 
With this, the video core is now has no calls to the global system
instance at all.
 2020-04-19 16:12:08 -04:00
bunnei 2ea7a70da0
Merge pull request #3686 from lioncash/table 
texture_cache/format_lookup_table: Fix incorrect green, blue, and alpha indices
 2020-04-19 15:33:33 -04:00
bunnei 10fb26f69c
Merge pull request #3696 from lioncash/cast-size 
hle_ipc: Remove std::size_t casts where applicable
 2020-04-19 14:24:15 -04:00
MerryMage 2bfac7b61d thread: FPCR.FZ is likely not 1 2020-04-19 08:37:20 +01:00
bunnei 779a3b222a
Merge pull request #3655 from FearlessTobi/ui-retext-yuzu 
yuzu/main: Add better popup texts and remove duplicated actions
 2020-04-19 02:16:50 -04:00
bunnei 73db83c0ab
Merge pull request #3679 from lioncash/track 
track: Eliminate redundant copies
 2020-04-19 01:22:47 -04:00
bunnei 74c27fd1b5 core: arm_unicorn: Fix interpret fallback by temporarily mapping instruction page. 2020-04-19 00:53:23 -04:00
Jan Beich afcc84a172 renderer_vulkan: assume X11 if not Windows/macOS after bf1d66b7c0 
Render.Vulkan <Error> video_core/renderer_vulkan/renderer_vulkan.cpp:CreateInstance:131: Presentation not supported on this platform
Render.Vulkan <Error> video_core/renderer_vulkan/renderer_vulkan.cpp:CreateSurface:378: Presentation not supported on this platform
Core <Critical> core/core.cpp:Load:199: Failed to initialize system (Error 5)!
 2020-04-19 00:32:23 +00:00
ReinUsesLisp c81bf06d03 vulkan/wrapper: Sort physical devices 
Sort discrete GPUs over the rest, Nvidia over AMD, AMD over Intel, Intel
over the rest. This gives us a somewhat consistent order when Optimus
is removed (renderdoc does this when it's attached).

This can break the configuration of users with an Intel GPU that
manually remove Optimus on yuzu. That said, it's a very unlikely to
happen.
 2020-04-18 21:31:15 -03:00
ReinUsesLisp d62f57cf5a fixed_pipeline_state: Hash and compare the whole structure 
Pad FixedPipelineState's size to 384 bytes to be a multiple of 16.

Compare the whole struct with std::memcmp and hash with CityHash. Using
CityHash instead of a naive hash should reduce the number of collisions.
Improve used type traits to ensure this operation is safe.

With these changes the improvements to the hashable pipeline state are:

Optimized structure
Hash:            89 ns
Comparison:     103 ns
Construction*:  164 ns
Struct size:    384 bytes

Original structure
Hash:           148 ns
Equal:          174 ns
Construction*:  281 ns
Size:          1384 bytes

* Attribute state initialization is not measured

These measures are averages taken with std::chrono::high_accuracy_clock
on MSVC shipped on Visual Studio 16.6.0 Preview 2.1.
 2020-04-18 19:57:26 -03:00
ReinUsesLisp b571c92dfd fixed_pipeline_state: Pack blending state 
Reduce FixedPipelineState's size to 364 bytes.
 2020-04-18 19:23:35 -03:00
ReinUsesLisp 548dd27f45 fixed_pipeline_state: Pack rasterizer state 
Reduce FixedPipelineState's size to 600 bytes.
 2020-04-18 19:22:57 -03:00
ReinUsesLisp 7790144a55 fixed_pipeline_state: Pack depth stencil state 
Reduce FixedPipelineState's size to 632 bytes.
 2020-04-18 19:22:11 -03:00
ReinUsesLisp ab6704f20c fixed_pipeline_state: Pack attribute state 
Reduce FixedPipelineState's size from 1384 to 664 bytes
 2020-04-18 19:21:19 -03:00
Mat M 5305806071
Merge pull request #3716 from bunnei/fix-another-impl-fallthrough 
video_core: gl_shader_decompiler: Fix implicit fallthrough errors.
 2020-04-18 15:17:52 -04:00
bunnei 03726fb7f5 video_core: gl_shader_decompiler: Fix implicit fallthrough errors. 2020-04-18 15:15:21 -04:00
bunnei 89e512ca8d
Merge pull request #3710 from lioncash/nso 
loader/nso: Resolve moves not occurring in DecompressSegment
 2020-04-18 14:44:42 -04:00
Mat M 45964e6fec
Merge pull request #3715 from bunnei/fix-impl-fallthrough 
service: hid: npad: Fix implicit fallthrough errors.
 2020-04-18 14:44:20 -04:00
bunnei a8d5d08e2e service: hid: npad: Fix implicit fallthrough errors. 2020-04-18 14:41:08 -04:00
bunnei 907ba8794e
Merge pull request #3713 from lioncash/time 
service/time: Minor changes
 2020-04-17 21:04:43 -04:00
bunnei 90ddb13372
Merge pull request #3711 from lioncash/cast 
memory/slab_heap: Make use of static_cast over reinterpret_cast
 2020-04-17 21:04:11 -04:00
Lioncash bf328ed35a gl_shader_decompiler: Avoid copies where applicable 
Avoids unnecessary reference count increments where applicable and also
avoids reallocating a vector.

Unlikely to make a huge difference, but given how trivial of an
amendment it is, why not?
 2020-04-17 20:48:52 -04:00
Lioncash 7714b02d95 time/system_clock_core: Remove unnecessary initializer 
This is already initialized within the class body.
 2020-04-17 20:04:06 -04:00
Lioncash b533f18ab9 service/time: Mark IsStandardNetworkSystemClockAccuracySufficient as const 
This doesn't modify internal member state.
 2020-04-17 20:02:45 -04:00
Lioncash 0cfd3b94db service/time: Add virtual destructors where applicable 
Many of these implementations are used to implement a polymorphic
interface. While not directly used polymorphically, this prevents
virtual destruction from ever becoming an issue.
 2020-04-17 19:59:31 -04:00
Lioncash 4d8a8a8033 service: Remove unused RequestParser instances 
These aren't used, so they should be removed to reduce compilation
warnings.
 2020-04-17 19:47:43 -04:00
bunnei 7438d36d0e
Merge pull request #3630 from benru/open-windows-network-files 
common/file_util: Allow access to files on network shares
 2020-04-17 19:47:11 -04:00
Lioncash 7e585bce28 memory/slab_heap: Make use of static_cast over reinterpret_cast 
Casting from void* with static_cast is permitted by the standard, so we
can just make use of that instead.
 2020-04-17 19:38:59 -04:00
Lioncash 441a2812ed loader/nso: Resolve moves not occurring in DecompressSegment 
Given the std::vector was const, an automatic move out of the function
could not occur.

We can allow automatic return value optimizations to occur by making the
buffer non-const.
 2020-04-17 19:26:50 -04:00
Lioncash 64f226889c am: Resolve ineffective moves 
Previously const objects were being std::moved, which results in no move
actually occurring. This resolves that.
 2020-04-17 19:22:46 -04:00
Markus Wick 07fbef1776 video_code: Fix implicit switch fallthrough. 
Since yesterday, this breaks the build on linux.
So let's fix it.
 2020-04-17 23:43:35 +02:00
ReinUsesLisp a7b6bd56d7 vk_stream_buffer: Fix out of memory on boot on recent Nvidia drivers 
Nvidia recently introduced a new memory type for data streaming
(awesome!), but yuzu was assuming that all heaps had enough memory
for the assumed stream buffer size (256 MiB).

This worked fine on AMD but Nvidia's new memory heap was smaller than
256 MiB. This commit changes this assumption and allocates a bit less
than the size of the preferred heap, with a maximum of 256 MiB (to avoid
allocating all system memory on integrated devices).

- Fixes a crash on NVIDIA 450.82.0.0
 2020-04-17 18:12:48 -03:00
Fernando Sahmkow 2133482a17
Merge pull request #3703 from yuzu-emu/revert-3656-glsl-full-decompile 
Revert "gl_shader_cache: Use CompileDepth::FullDecompile on GLSL"
 2020-04-17 17:08:41 -04:00
Fernando Sahmkow 775ecc7d05
Merge pull request #3672 from lioncash/null 
file_util: Early-exit in WriteArray and ReadArray if specified lengths are zero
 2020-04-17 17:02:35 -04:00
Rodrigo Locatti 990c0b184f
Revert "gl_shader_cache: Use CompileDepth::FullDecompile on GLSL" 2020-04-17 17:41:48 -03:00
bunnei b8f5c71f2d
Merge pull request #3666 from bunnei/new-vmm 
Implement a new virtual memory manager
 2020-04-17 16:33:08 -04:00
bunnei ca3af2961c
Merge pull request #3682 from lioncash/uam 
gl_query_cache: Resolve use-after-move in CachedQuery move assignment operator
 2020-04-17 01:24:08 -04:00
bunnei 8bbe74a8dc core: hle: Address various feedback & code cleanup. 
- Should be no functional changes.
 2020-04-17 00:59:36 -04:00
bunnei 92caa003a8 core: device_memory: Remove incorrect usage of constexpr. 2020-04-17 00:59:36 -04:00
bunnei 6f3266e98b memory: Add copyright notice for Atmosphere where applicable. 2020-04-17 00:59:35 -04:00
bunnei 02547a0cb4 kernel: Remove old VMManager class. 2020-04-17 00:59:35 -04:00
bunnei bebfb05c1b loader: nso: Fix loader size and arguments. 2020-04-17 00:59:35 -04:00
bunnei 83761d5316 loader: elf/kip/nro: Updates for new VMM. 2020-04-17 00:59:35 -04:00
bunnei 37b79ebe85 service: ldr: Updates for new VMM. 
- Includes removing some service impls. that are untested.
 2020-04-17 00:59:35 -04:00
bunnei a8292f6cd9 kernel: memory: page_table: Simplify GetPhysicalAddr impl. 2020-04-17 00:59:35 -04:00
bunnei c629e544a7 kernel: svc: Updates for new VMM. 
- Includes removing some SVC impls. that are untested.
 2020-04-17 00:59:34 -04:00
bunnei ff5d5b6f41 core: memory: Fix memory access on page boundaries. 
- Fixes Super Smash Bros. Ultimate.
 2020-04-17 00:59:34 -04:00
bunnei 32fc2aae3c video_core: memory_manager: Updates for Common::PageTable changes. 2020-04-17 00:59:34 -04:00
bunnei f7c03610e1 core: memory: Updates for new VMM. 2020-04-17 00:59:34 -04:00
bunnei 4c1812ae37 common: page_table: Update to use VirtualBuffer and simplify. 2020-04-17 00:59:34 -04:00
bunnei 1d5923e150 core: gdbstub: Updates for new VMM. 2020-04-17 00:59:34 -04:00
bunnei c7bc7986bb core: reporter: Updates for new VMM. 2020-04-17 00:59:33 -04:00
bunnei 18c4bb6f5c memory: cheat_engine: Updates for new VMM. 2020-04-17 00:59:33 -04:00
bunnei d95ceaa8ec arm_test_common: Updates for new VMM. 2020-04-17 00:59:33 -04:00
bunnei 108564df57 kernel: process: Updates for new VMM. 2020-04-17 00:59:33 -04:00
bunnei 77382ac2b2 service: pl_u: Update for new shared memory layout. 2020-04-17 00:59:33 -04:00
bunnei 67b3df683b service: time: Update for new shared memory layout. 2020-04-17 00:59:33 -04:00
bunnei 8eca0f9cd2 service: hid: Update for new shared memory layout. 2020-04-17 00:59:33 -04:00
bunnei 8bbc38a7bd service: irs: Update for new shared memory layout. 2020-04-17 00:59:32 -04:00
bunnei fc61cb44ee kernel: resource_limit: Reserve physical memory. 2020-04-17 00:59:32 -04:00
bunnei 8f75524e55 kernel: Initialize memory layout for new VMM. 2020-04-17 00:59:32 -04:00
bunnei 11c02a50e9 core: system: Rename GetDeviceManager -> DeviceManager. 
- More consistent with other system components.
 2020-04-17 00:59:32 -04:00
bunnei 3fcc4cab4f kernel: transfer_memory: Refactor for new VMM. 2020-04-17 00:59:32 -04:00
bunnei c53454ff46 core: Construct/Destruct DeviceMemory on Init/Shutdown. 2020-04-17 00:59:32 -04:00
bunnei d0162fc3d7 kernel: shared_memory: Refactor for new VMM. 2020-04-17 00:59:32 -04:00
bunnei a040a15246 core: device_memory: Update to use VirtualBuffer class. 2020-04-17 00:59:31 -04:00
bunnei 4ba2428c86 common: Add VirtualBuffer class, to abstract memory virtualization. 2020-04-17 00:59:31 -04:00
bunnei a238d08f71 kernel: errors: Add ERR_OUT_OF_RESOURCES. 2020-04-17 00:59:31 -04:00
bunnei ffc3de762b kernel: process_capability: Update to use Memory::PageTable. 2020-04-17 00:59:31 -04:00
bunnei 84f1b6d530 kernel: memory: Add PageTable class, to manage process address space. 2020-04-17 00:59:31 -04:00
bunnei cfae8a1c1a kernel: memory: Add MemoryLayout class, to build physical memory layout. 2020-04-17 00:59:31 -04:00
bunnei 5d6e8a5b44 kernel: memory: Add MemoryManager class, to manage page heaps. 2020-04-17 00:59:30 -04:00
bunnei 548ef190ab kernel: memory: Add MemoryBlockManager class, to manage memory blocks. 2020-04-17 00:59:30 -04:00
bunnei 3927012734 kernel: memory: Add PageHeap class, to manage a heap of pages. 2020-04-17 00:59:30 -04:00
bunnei dc720311cc kernel: memory: Add PageLinkedList class, to manage a list of pages. 2020-04-17 00:59:30 -04:00
bunnei 81cb4d3c7f kernel: memory: Add system_control code, which will be used for ASLR support. 2020-04-17 00:59:30 -04:00
bunnei fc040b5b70 physical_memory: Add missing include for <vector>. 2020-04-17 00:59:30 -04:00
bunnei c2f4dcb1e3 kernel: memory: Add MemoryBlock class, for managing memory blocks and their state. 2020-04-17 00:59:29 -04:00
bunnei ea5ee9918e kernel: memory: Add memory_types.h, for things that are commonly used in memory code. 2020-04-17 00:59:29 -04:00
bunnei d364e7cf09 kernel: memory: Add SlabHeap class, for managing memory heaps. 
- This will be used for TLS pages, among other things.
 2020-04-17 00:59:29 -04:00
bunnei 14aa65ce00 kernel: memory: Add AddressSpaceInfo class, for managing the memory address space. 2020-04-17 00:59:29 -04:00
bunnei dc25c86556 core: device_manager: Add a simple class to manage device RAM. 2020-04-17 00:59:29 -04:00
bunnei f1b607829e dynarmic: Enable strict alignment checks. 
- Also add a missing include.
 2020-04-17 00:59:29 -04:00
bunnei 4df6ef04ac common: scope_exit: Implement mechanism for canceling a scope exit. 2020-04-17 00:59:28 -04:00
bunnei 4caff51710 core: memory: Move to Core::Memory namespace. 
- helpful to disambiguate Kernel::Memory namespace.
 2020-04-17 00:59:28 -04:00
bunnei b838e58d63 common: alignment: Add a helper function for generic alignment checking. 2020-04-17 00:59:28 -04:00
bunnei ad48ebb2c8 core: kernel: Add svc_types header to include SVC-specific types. 2020-04-17 00:59:28 -04:00
bunnei 82d457af37 core: kernel: Move SVC to its own namesapce. 2020-04-17 00:59:28 -04:00
bunnei b0e3cbef7a kernel: resource_limit: Improvements to implementation. 2020-04-17 00:59:27 -04:00
bunnei 7aa0e4a7ca loader: nso: Fix loading of static objects to be properly sized and aligned. 2020-04-17 00:59:27 -04:00
bunnei b11b424a2d common: common_funcs: Add a macro for defining enum flag operators. 2020-04-17 00:59:27 -04:00
bunnei f2676efe23 process: SetupMainThread: Zero out argument on process start. 2020-04-17 00:11:50 -04:00
bunnei 0f4f90cd04 arm_interface: Ensure ThreadContext is zero'd out. 2020-04-17 00:11:50 -04:00
Lioncash dcbb39cdae CMakeLists: Make missing declarations a compile-time error 
Ensures that our code always has its linkage explicit.
 2020-04-16 23:43:41 -04:00
Lioncash e2d8be1ca2 General: Resolve warnings related to missing declarations 2020-04-16 23:43:34 -04:00
MerryMage 1cc9507bc5 gdbstub: Fix some gdbstub jankiness 
1. Ensure that register information available to gdbstub is most up-to-date.
2. There's no reason to check for current_thread == thread when emitting a trap.
   Doing this results in random hangs whenever a step happens upon a thread switch.
 2020-04-17 05:41:43 +02:00
bunnei 86f9c9aa1c
Merge pull request #3671 from lioncash/switch 
kernel/thread: Resolve -Wswitch warnings
 2020-04-16 23:30:32 -04:00
Lioncash 8f9c599c9f key_manager: Resolve missing field initializer warning 2020-04-16 22:45:44 -04:00
Lioncash 678ac54749 decode/memory: Resolve unused variable warning 
Only the first element of the returned pair is ever used.
 2020-04-16 22:45:44 -04:00
Lioncash d159643fd7 decode/texture: Resolve unused variable warnings. 
Some variables aren't used, so we can remove these.

Unfortunately, diagnostics are still reported on structured bindings
even when annotated with [[maybe_unused]], so we need to unpack the
elements that we want to use manually.
 2020-04-16 22:45:41 -04:00
Lioncash f522abd8ab decode/texture: Collapse loop down into std::generate 
Same behavior, less code.
 2020-04-16 22:29:07 -04:00
Lioncash 7e2d60de26 decode/texture: Eliminate trivial missing field initializer warnings 
We can just specify the initializers.
 2020-04-16 22:27:21 -04:00
Lioncash 337f2dc11f time_zone_manager: Resolve sign conversion warnings 
ttis and ats will never exceed the length of INT32_MAX in our case, so
this is safe.
 2020-04-16 22:23:59 -04:00
Lioncash fc5df84581 CMakeLists: Enable -Wmissing-declarations on Linux builds 
Allows catching cases where internal linkage isn't specified for helper
functions when they should be marked as such.
 2020-04-16 22:07:16 -04:00
Lioncash 77356731a9 hle_ipc: Remove std::size_t casts where applicable 
These were added in the change that enabled -Wextra on linux builds so
as not to introduce interface changes in the same change as a
build-system flag addition.

Now that the flags are enabled, we can freely change the interface to
make these unnecessary.
 2020-04-16 22:02:10 -04:00
bunnei 79c1269f0f
Merge pull request #3673 from lioncash/extra 
CMakeLists: Specify -Wextra on linux builds
 2020-04-16 21:12:33 -04:00
ReinUsesLisp 238c6016f9 maxwell_3d: Initialize format attributes constant as one 
nouveau expects this to be true but it doesn't set it.
 2020-04-16 21:15:07 -03:00
ReinUsesLisp c961770900 vk_compute_pass: Implement indexed quads 
Implement indexed quads (GL_QUADS used with glDrawElements*) with a
compute pass conversion.

The compute shader converts from uint8/uint16/uint32 indices to uint32.
The format is passed through push constants to avoid having different
variants of the same shader.

- Used by Fast RMX
- Used by Xenoblade Chronicles 2 (it still has graphical due to
synchronization issues on Vulkan)
 2020-04-16 21:12:32 -03:00
Fernando Sahmkow c81f256111
Merge pull request #3600 from ReinUsesLisp/no-pointer-buf-cache 
buffer_cache: Return handles instead of pointer to handles
 2020-04-16 19:58:13 -04:00
Markus Wick fedf750e1b externals: Move LibreSSL linking to httplib. 
Neither core nor web_services use OpenSSL nor LibreSSL.
However they need to link them as it's a requirement of httplib.
So let's declare this within httplib instead of core and web_services.
 2020-04-16 16:46:33 +02:00
Markus Wick 94c2c828a5 input_common: Use the CMake target instead of the variable. 2020-04-16 16:42:59 +02:00
Rodrigo Locatti db67e017cb
Merge pull request #3659 from bunnei/time-calc-standard-user 
service: time: Implement CalculateStandardUserSystemClockDifferenceByUser.
 2020-04-16 02:51:57 -03:00
ReinUsesLisp 090fd3fefa buffer_cache: Return handles instead of pointer to handles 
The original idea of returning pointers is that handles can be moved.
The problem is that the implementation didn't take that in mind and made
everything harder to work with. This commit drops pointer to handles and
returns the handles themselves. While it is still true that handles can
be invalidated, this way we get an old handle instead of a dangling
pointer.

This problem can be solved in the future with sparse buffers.
 2020-04-16 02:33:34 -03:00
Rodrigo Locatti a5a2ee8766
Merge pull request #3689 from lioncash/unused-var 
decode/shift: Remove unused variable within Shift()
 2020-04-16 02:05:54 -03:00
Rodrigo Locatti d196ce0f71
Merge pull request #3688 from lioncash/nequal 
surface_view: Add missing operator!= to ViewParams
 2020-04-16 01:39:51 -03:00
Rodrigo Locatti 4209dba1f6
Merge pull request #3680 from lioncash/static 
gl_device: Mark stage_swizzle as constexpr
 2020-04-16 01:26:23 -03:00
Rodrigo Locatti 60e8de7c95
Merge pull request #3687 from lioncash/constness 
surface_base: Make IsInside() a const member function
 2020-04-16 01:22:50 -03:00
Rodrigo Locatti 612966399b
Merge pull request #3685 from lioncash/copies 
control_flow: Make use of std::move in TryInspectAddress()
 2020-04-16 01:22:40 -03:00
Lioncash cd2a12e78f decode/shift: Remove unused variable within Shift() 
Removes a redundant variable that is already satisfied by the IsFull()
utility function.
 2020-04-16 00:16:06 -04:00
Lioncash 5fbe8785d2 surface_view: Add missing operator!= to ViewParams 
Provides logical symmetry to the interface.
 2020-04-16 00:03:12 -04:00
Lioncash d551c910bb surface_base: Make IsInside() a const member function 
This doesn't modify internal state, so this can be made const.
 2020-04-15 23:59:35 -04:00
bunnei 319df1db77
Merge pull request #3683 from lioncash/docs 
video_core: Amend doxygen comment references
 2020-04-15 23:54:58 -04:00
Lioncash 636c8ab85b texture_cache/format_lookup_table: Fix incorrect green, blue, and alpha indices 
Previously these were all using the red component to derive the indices,
which is definitely not intentional.
 2020-04-15 23:50:46 -04:00
Lioncash 72a224d3fc control_flow: Make use of std::move in TryInspectAddress() 
Eliminates redundant atomic reference count increments and decrements.
 2020-04-15 23:31:22 -04:00
Lioncash 11837e8f13 video_core: Amend doxygen comment references 
Fixes broken documentation references.
 2020-04-15 22:33:29 -04:00
Lioncash 24620bc4ea decode/image: Fix typo in assert in GetComponentSize() 2020-04-15 22:29:51 -04:00
Lioncash 3a60f19eaf gl_query_cache: Resolve use-after-move in CachedQuery move assignment operator 
Avoids potential invalid junk data from being read.
 2020-04-15 22:20:06 -04:00
Lioncash b178c9a349 decoder/image: Fix incorrect G24R8 component sizes in GetComponentSize() 
The components' sizes were mismatched. This corrects that.
 2020-04-15 22:10:44 -04:00
Lioncash 71fb156611 gl_device: Mark stage_swizzle as constexpr 
Previously this was mutable even though it shouldn't be.
 2020-04-15 21:59:13 -04:00
Lioncash e15ec2705c track: Eliminate redundant copies 
Two variables can be references, while two others can be std::moved.
Makes for 4 less atomic reference count increments and decrements.
 2020-04-15 21:50:09 -04:00
Lioncash 1c340c6efa CMakeLists: Specify -Wextra on linux builds 
Allows reporting more cases where logic errors may exist, such as
implicit fallthrough cases, etc.

We currently ignore unused parameters, since we currently have many
cases where this is intentional (virtual interfaces).

While we're at it, we can also tidy up any existing code that causes
warnings. This also uncovered a few bugs as well.
 2020-04-15 21:33:46 -04:00
Rodrigo Locatti 65cbb122ea
Merge pull request #3649 from FernandoS27/3d-fix 
Texture Cache: Read current data when flushing a 3D segment.
 2020-04-15 17:06:55 -03:00
Fernando Sahmkow e33196d4e7
Merge pull request #3612 from ReinUsesLisp/red 
shader/memory: Implement RED.E.ADD and minor changes to ATOM
 2020-04-15 15:03:49 -04:00
Lioncash e77337588e file_util: Early-exit in WriteArray and ReadArray if specified lengths are zero 
It's undefined behavior to pass a null pointer to std::fread and
std::fwrite, even if the length passed in is zero, so we must perform
the precondition checking ourselves.

A common case where this can occur is when passing in the data of an
empty std::vector and size, as an empty vector will typically have a
null internal buffer.

While we're at it, we can move the implementation out of line and add
debug checks against passing in nullptr to std::fread and std::fwrite.
 2020-04-15 14:43:37 -04:00
Lioncash 213fff67bc CMakeLists: Make -Wreorder a compile-time error 
This can result in silent logic bugs within code, and given the amount
of times these kind of warnings are caused, they should be flagged at
compile-time so no new code is submitted with them.
 2020-04-15 14:14:41 -04:00
Lioncash 521c4c33b5 kernel/thread: Resolve -Wswitch warnings 2020-04-15 13:48:14 -04:00
Mat M 64b5985f0a
Merge pull request #3662 from ReinUsesLisp/constant-attrs 
gl_rasterizer: Implement constant vertex attributes
 2020-04-15 11:54:50 -04:00
Fernando Sahmkow 6789d88a9c Texture Cache: Read current data when flushing a 3D segment. 
This PR corrects flushing of 3D segments when data of other segments is
mixed, this aims to preserve the data in place.
 2020-04-15 11:46:17 -04:00
Mat M 9208d555b7
Merge pull request #3668 from ReinUsesLisp/vtx-format-16ui 
maxwell_to_vk: Add uint16 vertex formats
 2020-04-15 11:43:52 -04:00
Mat M ab72696beb
Merge pull request #3656 from ReinUsesLisp/glsl-full-decompile 
gl_shader_cache: Use CompileDepth::FullDecompile on GLSL
 2020-04-15 03:17:46 -04:00
Mat M 4878d6bb49
Merge pull request #3654 from ReinUsesLisp/fix-fb-attach 
gl_texture_cache: Fix layered texture attachment base level
 2020-04-15 03:17:18 -04:00
Mat M 50c0a92db8
Merge pull request #3663 from ReinUsesLisp/fcmp-rc 
shader/arithmetic: Add FCMP_CR variant
 2020-04-15 03:16:56 -04:00
Mat M 13331a3a32
Merge pull request #3664 from ReinUsesLisp/fe3h-black-squares 
Revert "gl_shader_decompiler: Implement merges with bitfieldInsert"
 2020-04-15 03:14:28 -04:00
ReinUsesLisp 3036067047 maxwell_to_vk: Add uint16 vertex formats 2020-04-15 04:06:30 -03:00
ReinUsesLisp b4e43c64c8 maxwell_to_vk: Add missing breaks 
Avoid invalid fallbacks.
 2020-04-15 04:05:33 -03:00
ReinUsesLisp 0ca456830f vk_blit_screen: Initialize all members in VkPipelineViewportStateCreateInfo 
When the dynamic state is specified, pViewports and pScissors are
ignored, quoting the specification:

  pViewports is a pointer to an array of VkViewport structures, defining
  the viewport transforms. If the viewport state is dynamic, this member
  is ignored.

That said, AMD's proprietary driver itself seem to read it regardless of
what the specification says.
 2020-04-15 03:30:08 -03:00
Rodrigo Locatti 0b132e8cc1
Merge pull request #3657 from ReinUsesLisp/viewport-zero 
vk_rasterizer: Default to 1 viewports with a size of 0
 2020-04-15 01:51:17 -03:00
Fernando Sahmkow daddbeffd1
Texture Cache: Only do buffer copies on accurate GPU. (#3634) 
This is a simple optimization as Buffer Copies are mostly used for texture recycling. They are, however, useful when games abuse undefined behavior but most 3D APIs forbid it.
 2020-04-14 23:21:00 -04:00
bunnei eb676c343a service: time: Implement CalculateStandardUserSystemClockDifferenceByUser. 
- Used by Animal Crossing: New Horizons.
 2020-04-14 22:28:41 -04:00
ReinUsesLisp fd6371eba7 Revert "gl_shader_decompiler: Implement merges with bitfieldInsert" 
This reverts commit 05cf270836.

Apparently the first approach using floats instead of bitfieldInert
worked better for Fire Emblem: Three Houses. Reverting to get that
behavior back.
 2020-04-14 21:24:33 -03:00
ReinUsesLisp fefe7f18f9 shader/arithmetic: Add FCMP_CR variant 
Adds another variant of FCMP.
 2020-04-14 19:11:04 -03:00
Zach Hilman e366b4ee1f
Merge pull request #3660 from bunnei/friend-blocked-users 
service: friend: Stub IFriendService::GetBlockedUserListIds.
 2020-04-14 16:59:46 -04:00
ReinUsesLisp 6dfcabc800 gl_rasterizer: Implement constant vertex attributes 
Credits go to gdkchan from Ryujinx for finding constant attributes are
used in retail games.
 2020-04-14 17:58:53 -03:00
bunnei fc35803f91 file_sys: patch_manager: Return early when there are no layers to apply. 2020-04-14 16:25:55 -04:00
bunnei 598740f1dd service: friend: Stub IFriendService::GetBlockedUserListIds. 
- This is safe to stub, as there should be no adverse consequences from reporting no blocked users.
 2020-04-14 16:20:51 -04:00
ReinUsesLisp 37e5c4fa7c vk_rasterizer: Default to 1 viewports with a size of 0 
Silence validation layer errors.
 2020-04-14 04:44:34 -03:00
ReinUsesLisp 453d7419d9 gl_shader_cache: Use CompileDepth::FullDecompile on GLSL 
From my testing on a Splatoon 2 shader that takes 3800ms on average to
compile changing to FullDecompile reduces it to 900ms on average.

The shader decoder will automatically fallback to a more naive method if
it can't use full decompile.
 2020-04-14 01:34:20 -03:00
ReinUsesLisp 0e232cfdc1 renderer_vulkan: Integrate Nvidia Nsight Aftermath on Windows 
Adds optional support for Nsight Aftermath. It is enabled through
ENABLE_NSIGHT_AFTERMATH in cmake. A path to the SDK has to be provided
by the environment variable NSIGHT_AFTERMATH_SDK.

Nsight Aftermath allows an application to generate "minidumps" of the
GPU state when a device loss happens. By analysing these on Nsight we
can know what a game was doing and why it triggered a device loss.

The dump is generated inside %APPDATA%\yuzu\log\gpucrash and this
directory is deleted every time a new instance is initialized with
Nsight enabled.

To enable it on yuzu there has a to be a driver and device capable of
running Nsight Aftermath on Vulkan. That means only Turing based GPUs
on the latest stable driver, beta drivers won't work for now.

It is manually enabled in Configuration>Debug>Enable Graphics Debugging
because when using all debugging capabilities there is a runtime cost.
 2020-04-14 00:39:21 -03:00
FearlessTobi c2bf91156a yuzu/main: Add better popup texts and remove duplicated actions 
Makes popup texts more compact and clear and also links our quickstart guide now.
Also removes OnMenuSelectEmulatedDirectory from the File dropdown, as the action already exists in the Filesystem tab and provides better visual feedback there.
 2020-04-14 02:56:22 +02:00
ReinUsesLisp 21dc842171 gl_texture_cache: Fix layered texture attachment base level 
The base level is already included in the texture view. If we specify
the base level in the texture again, this will end up in the incorrect
level and potentially out of bounds.
 2020-04-13 18:24:56 -03:00
ReinUsesLisp 6cfe2a7246 renderer_vulkan: Remove Nvidia checkpoints 2020-04-13 17:33:59 -03:00
ReinUsesLisp 16105c6a66 renderer_vulkan: Catch device losses in more places 2020-04-13 17:33:59 -03:00
Rodrigo Locatti 7e4a132a77
Merge pull request #3636 from ReinUsesLisp/drop-vk-hpp 
renderer_vulkan: Drop Vulkan-Hpp
 2020-04-13 17:08:04 -03:00
Mat M fbf13d3f48
Merge pull request #3651 from ReinUsesLisp/line-widths 
gl_rasterizer: Implement line widths and smooth lines
 2020-04-13 10:19:59 -04:00
Mat M 08266d70ba
Merge pull request #3638 from ReinUsesLisp/remove-preserve-contents 
texture_cache: Remove preserve_contents
 2020-04-13 10:19:01 -04:00
Mat M c4001225f6
Merge pull request #3631 from ReinUsesLisp/more-astc 
texture/astc: More small ASTC optimizations
 2020-04-13 10:17:32 -04:00
Mat M 7b62212461
Merge pull request #3619 from ReinUsesLisp/i2i 
shader/conversion: Implement I2I sign extension, saturation and selection
 2020-04-13 10:17:07 -04:00
Mat M 3351e1e94f
Merge pull request #3627 from ReinUsesLisp/layered-view 
gl_texture_cache: Attach view instead of base texture for layered attchments
 2020-04-13 10:16:18 -04:00
Mat M d37d899431
Merge pull request #3646 from ReinUsesLisp/fix-glsl-turing 
gl_shader_decompiler: Improve generated code in HMergeH*
 2020-04-13 10:15:12 -04:00
Mat M 47036859eb
Merge pull request #3633 from ReinUsesLisp/clean-texdec 
shader/texture: Remove type mismatches management from shader decoder
 2020-04-13 10:13:05 -04:00
ReinUsesLisp 76615b9f34 gl_rasterizer: Implement line widths and smooth lines 
Implements "legacy" features from OpenGL present on hardware such as
smooth lines and line width.
 2020-04-13 01:30:34 -03:00
ReinUsesLisp 05cf270836 gl_shader_decompiler: Implement merges with bitfieldInsert 
This also fixes Turing issues but it avoids doing more bitcasts. This
should improve the generated code while also avoiding more points where
compilers can flush floats.
 2020-04-12 22:39:59 -03:00
bunnei a9f866264d
Merge pull request #3606 from ReinUsesLisp/nvflinger 
service/vi: Partially implement BufferQueue disconnect
 2020-04-12 11:44:48 -04:00
Fernando Sahmkow 3d91dbb21d
Merge pull request #3578 from ReinUsesLisp/vmnmx 
shader/video: Partially implement VMNMX
 2020-04-12 10:44:03 -04:00
Mat M 4aec01b850
Merge pull request #3644 from ReinUsesLisp/msaa 
video_core: Add MSAA registers in 3D engine and TIC
 2020-04-12 09:11:44 -04:00
ReinUsesLisp 75eb953575 gl_shader_decompiler: Improve generated code in HMergeH* 
Avoiding bitwise expressions, this fixes Turing issues in shaders using
half float merges that affected several games.
 2020-04-12 05:06:55 -03:00
ReinUsesLisp 76f178ba6e shader/video: Partially implement VMNMX 
Implements the common usages for VMNMX. Inputs with a different size
than 32 bits are not supported and sign mismatches aren't supported
either.

VMNMX works as follows:
It grabs Ra and Rb and applies a maximum/minimum on them (this is
defined by .MX), having in mind the input sign. This result can then be
saturated. After the intermediate result is calculated, it applies
another operation on it using Rc. These operations are merges,
accumulations or another min/max pass.

This instruction allows to implement with a more flexible approach GCN's
min3 and max3 instructions (for instance).
 2020-04-12 00:34:42 -03:00
ReinUsesLisp a7baf6fee4 video_core: Add MSAA registers in 3D engine and TIC 
This adds the registers used for multisampling. It doesn't implement
anything for now.
 2020-04-12 00:21:27 -03:00
Rodrigo Locatti 75e39f7f88
Merge pull request #3635 from FernandoS27/buffer-free 
Buffer queue: Correct behavior of free buffer.
 2020-04-11 17:58:15 -03:00
bunnei 8938f9941c
Merge pull request #3611 from FearlessTobi/port-4956 
Port citra-emu/citra#4956: "Fixes to game list sorting"
 2020-04-11 12:44:36 -04:00
ReinUsesLisp 94b0e2e5da texture_cache: Remove preserve_contents 
preserve_contents was always true. We can't assume we don't have to
preserve clears because scissored and color masked clears exist.

This removes preserve_contents and assumes it as true at all times.
 2020-04-11 01:51:02 -03:00
ReinUsesLisp 2905142f47 renderer_vulkan: Drop Vulkan-Hpp 2020-04-10 22:49:02 -03:00
bunnei 51c6688e21
Merge pull request #3594 from ReinUsesLisp/vk-instance 
yuzu: Drop SDL2 and Qt frontend Vulkan requirements
 2020-04-10 20:06:55 -04:00
Fernando Sahmkow 486a42c45a Buffer queue: Correct behavior of free buffer. 
This corrects the behavior of free buffer after witnessing it in an
unrelated hardware test. I haven't found any games affected by it but in
name of better accuracy we'll correct such behavior.
 2020-04-10 16:44:28 -04:00
bunnei 8adf66f9fd
Merge pull request #3607 from FearlessTobi/input-kms 
yuzu/configuration: Fix input profiles and a wrong assert
 2020-04-10 00:39:48 -04:00
ReinUsesLisp 8c0ba9c6fe service/vi: Partially implement BufferQueue disconnect 2020-04-10 01:00:50 -03:00
ReinUsesLisp a87b16da9a shader/texture: Remove type mismatches management from shader decoder 
Since commit e22816a5bb we handle type mismatches from the CPU.
We don't need to hack our shader decoder due to game bugs anymore.

Removed in this commit.
 2020-04-10 00:57:32 -03:00
Fernando Sahmkow f570b129a2
Merge pull request #3623 from ReinUsesLisp/renderdoc-bind-spam 
qt/bootmanager: Remove unnecessary glBindFramebuffer
 2020-04-09 18:02:17 -04:00
Fernando Sahmkow 7182ef31c9
Merge pull request #3622 from ReinUsesLisp/srgb-texture-border 
video_core/texture: Use a LUT to convert sRGB texture borders
 2020-04-09 18:01:48 -04:00
ReinUsesLisp 6bf5d2b011 astc: Hard code bit depth changes to 8 and use fast replicate 2020-04-09 18:37:12 -03:00
Rodrigo Locatti 36f607217f
Merge pull request #3610 from FernandoS27/gpu-caches 
Refactor all the GPU Caches to use VAddr for cache addressing
 2020-04-09 17:59:21 -03:00
Ben Russell f98a2c42de
common/file_util: Allow access to files on network shares 
On Windows, network shares use paths like \\server\share\file which were
being broken by FileUtil::SanitizePath() removing double slashes.

Changed the code in SanitizePath to permit a double-backslash if it
occurs at the start of a filepath (on Windows only).
 2020-04-09 18:48:28 +01:00
ReinUsesLisp bd2c1ab8a0 astc: Use boost's static_vector to avoid heap allocations 2020-04-09 05:27:57 -03:00
ReinUsesLisp 5de130beea astc: Implement a fast precompiled alternative for Replicate 2020-04-09 03:58:25 -03:00
ReinUsesLisp 6b4d4473be astc: Move Replicate to a constexpr LUT when possible 2020-04-09 03:35:07 -03:00
ReinUsesLisp d22a689250 astc: Make InputBitStream constexpr 2020-04-09 02:54:05 -03:00
ReinUsesLisp 0efc230381 astc: OutputBitStream style changes and make it constexpr 2020-04-09 02:37:51 -03:00
bunnei b96fd0bd0e
Merge pull request #3601 from ReinUsesLisp/some-shader-encodings 
video_core/shader: Add some instruction and S2R encodings
 2020-04-09 00:17:39 -04:00
ReinUsesLisp 6c8f9f40d7 gl_texture_cache: Attach view instead of base texture for layered attachments 
This way we are not ignoring the base layer of the current texture.
 2020-04-08 22:20:25 -03:00
Fernando Sahmkow 7cd6daf115 VkRasterizer: Eliminate Legacy code. 2020-04-08 18:59:09 -04:00
Fernando Sahmkow 1c18dc6577 Memory: Correct GCC errors. 2020-04-08 18:09:16 -04:00
Fernando Sahmkow 913f42a3a7 Memory: Address Feedback. 2020-04-08 13:40:46 -04:00
Fernando Sahmkow e00d992848 GPUMemoryManager: Improve safety of memory reads. 2020-04-08 12:08:06 -04:00
Kewlan 848d619aec Place SL and SR in the right most column. 2020-04-08 11:34:16 +02:00
bunnei b128beb3a9
Merge pull request #3572 from FearlessTobi/port-5127 
Port citra-emu/citra#5127: "common: Port some changes from dolphin"
 2020-04-07 23:48:16 -04:00
ReinUsesLisp c6ea0d010b qt/bootmanager: Remove unnecessary glBindFramebuffer 
Presentation context always has GL_DRAW_FRAMEBUFFER_BINDING as zero.
There is no need to bind the default framebuffer constantly.

According to Nsight this was using ~0.7ms per frame and it broke
renderdoc captures.
 2020-04-07 20:51:56 -03:00
ReinUsesLisp a209d464f9 video_core/textures: Move GetMaxAnisotropy to cpp file 2020-04-07 20:47:31 -03:00
ReinUsesLisp d7db088180 video_core/texture: Use a LUT to convert sRGB texture borders 
This is a reversed look up table extracted from
https://gist.github.com/rygorous/2203834#file-gistfile1-cpp-L41-L62

that is used in
04d4e9e587/source/maxwell/tsc_generate.cpp (L38)

Games usually bind 0xFD expecting a float texture border of 1.0f.
The conversion previous to this commit was multiplying the uint8 sRGB
texture border color by 255. This is close to 1.0f but when that
difference matters, some graphical glitches appear.

This look up table is manually changed in the edges, clamping towards
0.0f and 1.0f.

While we are at it, move this logic to its own translation unit.
 2020-04-07 20:38:14 -03:00
Zach Hilman 26ed65495d
Merge pull request #3621 from SilverBeamx/fullnamefix 
Log version and about section version fix
 2020-04-07 17:16:23 -04:00
SilverBeamx 863f7385dc Addressed feedback: switched to snake case and fixed clang-format errors 2020-04-07 22:59:09 +02:00
bunnei f316911248
Merge pull request #3599 from ReinUsesLisp/revert-3499 
Revert "Merge pull request #3499 from ReinUsesLisp/depth-2d-array"
 2020-04-07 16:51:41 -04:00
SilverBeamx 6b512d78c9 Addressed feedback: removed CMake hack in favor of building the necessary strings via the supplied title format 2020-04-07 22:41:45 +02:00
ReinUsesLisp bf1d66b7c0 yuzu: Drop SDL2 and Qt frontend Vulkan requirements 
Create Vulkan instances and surfaces from the Vulkan backend.
 2020-04-07 16:32:19 -03:00
Rodrigo Locatti 487f9ba525
Merge pull request #3489 from namkazt/patch-2 
shader: implement SULD.D bits32/64
 2020-04-07 16:21:09 -03:00
Nguyen Dac Nam 935648ffa9
address nit. 2020-04-07 18:29:30 +07:00
ReinUsesLisp bc1b4b85b0 renderer_vulkan: Query device names from the backend 2020-04-07 02:23:23 -03:00
ReinUsesLisp 7104e01bb3 common/dynamic_library: Import and adapt helper from Dolphin 2020-04-07 02:23:23 -03:00
ReinUsesLisp da706cad25 shader/conversion: Implement I2I sign extension, saturation and selection 
Reimplements I2I adding sign extension, saturation (clamp source value
to the destination), selection and destination sizes that are not 32
bits wide.

It doesn't implement CC yet.
 2020-04-07 02:19:44 -03:00
Nguyen Dac Nam bf1174c114
Apply suggestions from code review 
Co-Authored-By: Rodrigo Locatti <reinuseslisp@airmail.cc>
 2020-04-07 07:55:49 +07:00
enler 27f122c48c
file_sys: fix LayeredFS error when loading some games made with… (#3602) 
* fix LayeredFS error when loading some games made with the Unity
 2020-04-07 02:03:32 +02:00
Fernando Sahmkow f9d5718c4b Clang Format. 2020-04-06 09:23:08 -04:00
Fernando Sahmkow ea535d9470 Shader/Pipeline Cache: Use VAddr instead of physical memory for addressing. 2020-04-06 09:23:07 -04:00
Fernando Sahmkow 3dd5c07454 Query Cache: Use VAddr instead of physical memory for adressing. 2020-04-06 09:23:07 -04:00
Fernando Sahmkow 7fcd0fee6d Buffer Cache: Use vAddr instead of physical memory. 2020-04-06 09:23:06 -04:00
Fernando Sahmkow 6ee316cb8f Texture Cache: Use vAddr instead of physical memory for caching. 2020-04-06 09:23:05 -04:00
Fernando Sahmkow 9c0f40a1f5 GPU: Setup Flush/Invalidate to use VAddr instead of CacheAddr 2020-04-06 09:21:46 -04:00
Fernando Sahmkow 588a20be3f
Merge pull request #3513 from ReinUsesLisp/native-astc 
video_core: Use native ASTC when available
 2020-04-06 09:21:11 -04:00
namkazy 2c98e14d13 shader_decode: SULD.D using std::pair instead of out parameter 2020-04-06 13:46:55 +07:00
namkazy 9efa51311f shader_decode: SULD.D avoid duplicate code block. 2020-04-06 13:34:06 +07:00
namkazy 7f5696513f shader_decode: SULD.D fix conversion error. 2020-04-06 13:26:58 +07:00
namkazy 2906372ba1 shader_decode: SULD.D implement bits64 and reverse shader ir init method to removed shader stage. 2020-04-06 13:09:19 +07:00
ReinUsesLisp 3185245845 shader/memory: Implement RED.E.ADD 
Implements a reduction operation. It's an atomic operation that doesn't
return a value.

This commit introduces another primitive because some shading languages
might have a primitive for reduction operations.
 2020-04-06 02:24:47 -03:00
ReinUsesLisp fd0a2b5151 shader/memory: Add "using std::move" 2020-04-06 02:18:14 -03:00
ReinUsesLisp 79970c9174 shader/memory: Minor fixes in ATOM 2020-04-06 00:54:22 -03:00
FearlessTobi 8d0fb33ac4 yuzu: Fixes to game list sorting 
Should fix citra-emu/citra#4593.
As the issue might not be entirely clear, I'll offer a short explanation from what I understood from it and found from experimentation.

Currently yuzu offers the user the option to change the text that's displayed in the "Name" column in the game list. Generally, it is expected that the items are sorted based on the displayed text, but yuzu would sort them by title instead.

Made it so that an access to SortRole returns the same as DisplayRole.
There shouldn't be any UI changes, only change in behaviour.

Also fixes a bug with directory sorting, where having the directories out of order would enable you to try to "move up" to the addDirectory button, which would crash the emulator.

Co-Authored-By: Vitor K <vitor-k@users.noreply.github.com>
 2020-04-06 03:12:17 +02:00
Fernando Sahmkow 69277de29d
Merge pull request #3592 from ReinUsesLisp/ipa 
shader_decompiler: Remove FragCoord.w hack and change IPA implementation
 2020-04-05 19:29:40 -04:00
Fernando Sahmkow 1633fbf99a
Merge pull request #3589 from ReinUsesLisp/fix-clears 
gl_rasterizer: Mark cleared textures as dirty
 2020-04-05 19:29:26 -04:00
namkazy 730f9b55b3 silent warning (conversion error) 2020-04-05 16:02:07 +07:00
namkazy 9f6ebccf06 shader_decode: SULD.D -> SINT actually same as UNORM. 2020-04-05 15:18:42 +07:00
namkazy 6f2b7087c2 shader_decode: SULD.D fix decode SNORM component 2020-04-05 14:46:43 +07:00
namkazy 69657ff19c clang-format 2020-04-05 12:57:50 +07:00
namkazy 24cc64c5b3 shader_decode: get sampler descriptor from registry. 2020-04-05 12:54:48 +07:00
FearlessTobi aa6214feb7 yuzu/configuration: Only assert that all buttons exist when we are handling the click for a button device 
This fixes failed assertions that were present in yuzu master code for 18 months.
 2020-04-05 07:16:09 +02:00
FearlessTobi fb8afee077 yuzu/configure_input_simple: Fix "Docked Joycons" controller profile 
This was incorrectly using PlayerIndex 1 when calling the ConfigureDialog.
 2020-04-05 07:14:35 +02:00
namkazy acd3f0ab37 tweaking. 2020-04-05 10:31:32 +07:00
Nguyen Dac Nam 8370188b3c clang-format 2020-04-05 10:31:31 +07:00
namkazy 3e3afa9be6 cleanup unuse params 2020-04-05 10:31:31 +07:00
namkazy 5cd5857000 cleanup debug code. 2020-04-05 10:31:30 +07:00
namkazy 658112783d reimplement get component type, uncomment mistaken code 2020-04-05 10:31:30 +07:00
namkazy 3ad06e9b2b remove disable optimize 2020-04-05 10:31:30 +07:00
namkazy f24c2e1103 [wip] reimplement SULD.D 2020-04-05 10:31:29 +07:00
namkazy 58bcb86af5 add shader stage when init shader ir 2020-04-05 10:31:29 +07:00
Nguyen Dac Nam 2cefdd92bd clang-fix 2020-04-05 10:31:28 +07:00
Nguyen Dac Nam 1f3d142875 shader: image - import PredCondition 2020-04-05 10:31:27 +07:00
Nguyen Dac Nam 08db60392d shader: SULD.D bits32 implement more complexer method. 2020-04-05 10:31:27 +07:00
Nguyen Dac Nam ed1d8beb13 shader: SULD.D import StoreType 2020-04-05 10:31:26 +07:00
Nguyen Dac Nam 6d235b8631 shader: implement SULD.D bits32 2020-04-05 10:31:26 +07:00
ReinUsesLisp 60106531b4 shader/other: Add error message for some S2R registers 2020-04-04 03:46:07 -03:00
ReinUsesLisp 8b719e9e1d shader_bytecode: Rename MOV_SYS to S2R 2020-04-04 03:37:51 -03:00
ReinUsesLisp 9d15feb892 shader_bytecode: Add encoding for BAR 2020-04-04 03:36:21 -03:00
ReinUsesLisp 16ae98dbb3 shader_ir: Add error message for EXIT.FCSM_TR 2020-04-04 03:34:08 -03:00
ReinUsesLisp c02a2dc24a shader_bytecode: Add encoding for VOTE.VTG 2020-04-04 03:28:11 -03:00
ReinUsesLisp 80c4fee4ec Revert "Merge pull request #3499 from ReinUsesLisp/depth-2d-array" 
This reverts commit 41905ee467, reversing
changes made to 35145bd529.

It causes regressions in several games.
 2020-04-04 00:02:26 -03:00
bunnei e6f02d5725
Merge pull request #3579 from Kewlan/reorder-shoulder 
configuration: Reorder shoulder buttons
 2020-04-03 11:28:14 -04:00
Fernando Sahmkow 9d8886b1a4
Merge pull request #3563 from bunnei/fix-ldr-memstate 
services: ldr: Fix MemoryState for read/write regions of NROs.
 2020-04-03 10:14:56 -04:00
ReinUsesLisp e1bd89e1c2 shader/memory: Silence no return value warning 
Silences a warning about control paths not all returning a value.
 2020-04-02 03:34:27 -03:00
Rodrigo Locatti 825a6e2615
Merge pull request #3552 from jroweboy/single-context 
Refactor Context management (Fixes renderdoc on opengl issues)
 2020-04-02 01:38:25 -03:00
ReinUsesLisp 2339fe199f shader_decompiler: Remove FragCoord.w hack and change IPA implementation 
Credits go to gdkchan and Ryujinx. The pull request used for this can
be found here: https://github.com/Ryujinx/Ryujinx/pull/1082

yuzu was already using the header for interpolation, but it was missing
the FragCoord.w multiplication described in the linked pull request.
This commit finally removes the FragCoord.w == 1.0f hack from the shader
decompiler.

While we are at it, this commit renames some enumerations to match
Nvidia's documentation (linked below) and fixes component declaration
order in the shader program header (z and w were swapped).

https://github.com/NVIDIA/open-gpu-doc/blob/master/Shader-Program-Header/Shader-Program-Header.html
 2020-04-01 21:48:55 -03:00
ReinUsesLisp dd1232755b gl_texture_cache: Fix software ASTC fallback 2020-04-01 01:44:15 -03:00
ReinUsesLisp 2f0da10dc3 vk_device: Add missing ASTC queries 2020-04-01 01:14:04 -03:00
ReinUsesLisp b6571ca9f0 video_core: Use native ASTC when available 2020-04-01 01:14:04 -03:00
ReinUsesLisp 16270dcfe4 gl_device: Detect if ASTC is reported and expose it 2020-04-01 01:14:04 -03:00
Rodrigo Locatti baf91c920c
Merge pull request #3591 from ReinUsesLisp/vk-wrapper-part2 
renderer_vulkan/wrapper: Add a Vulkan wrapper (part 2 of 2)
 2020-03-31 22:14:26 -03:00
Vitor K bd0c56c6e7 common: Port some changes from dolphin (#5127) 
* IOFile: Make the move constructor and move assignment operator noexcept

Certain parts of the standard library try to determine whether or not a
transfer operation should either be a copy or a move. The prevalent notion
of move constructors/assignment operators is that they should not throw,
they simply move an already existing resource somewhere else.

This is typically done with 'std::move_if_noexcept'. Like the name says,
if a type's move constructor is noexcept, then the functions retrieves an
r-value reference (for move semantics), or an l-value (for copy semantics)
if it is not noexcept.

As IOFile deletes the copy constructor and copy assignment operators,
using IOFile with certain parts of the standard library can fail in
unexcepted ways (especially when used with various container
implementations). This prevents that.

* fix various instances of -1 being assigned to unsigned types

* do not assign in conditional statements

* File/IOFile: Check _tfopen_s properly

* common/file_util.cpp: address review comments

Co-authored-by: Lioncash <mathew1800@gmail.com>
Co-authored-by: Shawn Hoffman <godisgovernment@gmail.com>
Co-authored-by: Sepalani <sepalani@hotmail.fr>
 2020-04-01 02:58:42 +02:00
ReinUsesLisp f22f6b72c3 renderer_vulkan/wrapper: Add vkEnumerateInstanceExtensionProperties wrapper 2020-03-31 21:32:08 -03:00
ReinUsesLisp 27dd542c60 renderer_vulkan/wrapper: Add command buffer handle 2020-03-31 21:32:08 -03:00
ReinUsesLisp 5c90d060d8 renderer_vulkan/wrapper: Add physical device handle 2020-03-31 21:32:08 -03:00
ReinUsesLisp 0eb37de98f renderer_vulkan/wrapper: Add device handle 2020-03-31 21:32:08 -03:00
ReinUsesLisp 11774308d3 renderer_vulkan/wrapper: Add swapchain handle 2020-03-31 21:32:07 -03:00
ReinUsesLisp 7fe52ef77f renderer_vulkan/wrapper: Add fence handle 2020-03-31 21:32:07 -03:00
ReinUsesLisp 3a63ae0658 renderer_vulkan/wrapper: Add device memory handle 2020-03-31 21:32:07 -03:00
ReinUsesLisp 397f53dea1 renderer_vulkan/wrapper: Add pool handles 2020-03-31 21:32:07 -03:00
ReinUsesLisp affee77b70 renderer_vulkan/wrapper: Add buffer and image handles 2020-03-31 21:32:07 -03:00
ReinUsesLisp d85ca0ab33 renderer_vulkan/wrapper: Add queue handle 2020-03-31 21:32:07 -03:00
ReinUsesLisp 151ddcf419 renderer_vulkan/wrapper: Add instance handle 2020-03-31 21:32:07 -03:00
Morph 224a75d839
capsrv: Split Capture services into individual files and stub GetAlbumContentsFileListForApplication (#3571) 
* Organize capture services into individual files

* Stub GetAlbumContentsFileListForApplication

* Address feedback
 2020-03-31 19:16:36 -04:00
Fernando Sahmkow b03c0536ce
Merge pull request #3561 from ReinUsesLisp/f2f-conversion 
shader/conversion: Fix F2F rounding operations with different sizes
 2020-03-31 14:45:02 -04:00
Fernando Sahmkow 5b95a01463
Merge pull request #3577 from ReinUsesLisp/lea 
shader/lea: Fix LEA implementation
 2020-03-31 14:36:07 -04:00
ReinUsesLisp 1c5e2b60a7 gl_rasterizer: Mark cleared textures as dirty 
Fixes a potential edge case where cleared textures read from the CPU
were not flushed.
 2020-03-31 05:51:56 -03:00
Rodrigo Locatti c19425ed69
Merge pull request #3506 from namkazt/patch-9 
shader_decode: Implement partial ATOM/ATOMS instr
 2020-03-31 00:56:28 -03:00
Nguyen Dac Nam 238c35b2c9
clang-format 2020-03-31 08:08:06 +07:00
Nguyen Dac Nam defb9642da
shader_decode: fix by suggestion 2020-03-31 08:02:44 +07:00
Rodrigo Locatti 69728e8ad5
Merge pull request #3566 from ReinUsesLisp/vk-wrapper-part1 
renderer_vulkan/wrapper: Add a Vulkan wrapper (part 1 of 2)
 2020-03-30 21:57:36 -03:00
bunnei 4c72190a06
Merge pull request #3560 from ReinUsesLisp/fix-stencil 
gl_rasterizer: Synchronize stencil testing on clears
 2020-03-30 17:03:07 -04:00
James Rowe f1da3ec584 Frontend: Don't call DoneCurrent if the context isnt already current 2020-03-30 14:57:42 -06:00
namkazy cb0a4151f8 clang-format 2020-03-30 20:46:21 +07:00
namkazy c2665ec9c2 gl_decompiler: min/max op not implement yet 2020-03-30 18:48:22 +07:00
namkazy 4f7bea403a shader_decode: ATOM/ATOMS: add function to avoid code repetition 2020-03-30 18:47:50 +07:00
namkazy c8f6d9effd shader_decode: merge GlobalAtomicOp to AtomicOp 2020-03-30 18:47:00 +07:00
Nguyen Dac Nam 972485ff18 shader_decode: implement ATOM operation for S32 and U32 2020-03-30 17:44:48 +07:00
namkazy 93cac0d294 clang-format 2020-03-30 17:44:48 +07:00
Nguyen Dac Nam 3dc09a6250 shader_decode: implement ATOMS instr partial. 2020-03-30 17:44:46 +07:00
Nguyen Dac Nam a2cc80b605 vk_decompiler: add atomic op and handler function. 2020-03-30 17:44:45 +07:00
Nguyen Dac Nam 552f0ff267 gl_decompiler: add atomic op 2020-03-30 17:44:45 +07:00
Nguyen Dac Nam 2c780db5b9 shader: node - update correct comment 2020-03-30 17:44:44 +07:00
Nguyen Dac Nam c119473c40 shader_decode: add Atomic op for common usage 2020-03-30 17:44:44 +07:00
Kewlan a8f3a13a1f Re-order the shoulder buttons both in the configuration menu, and in the code. 2020-03-29 14:37:23 +02:00
bunnei 2c9879d2eb
Merge pull request #3568 from bunnei/time-calcspan 
services: time: Implement CalculateSpanBetween.
 2020-03-29 00:03:55 -04:00
bunnei 5e2f8e30e7
Merge pull request #3545 from FearlessTobi/audren-rev 
audio_core: Accept Audren REV8
 2020-03-28 22:08:19 -04:00
ReinUsesLisp 08470d261d shader_bytecode: Fix I2I_IMM encoding 2020-03-28 18:49:07 -03:00
bunnei ffe1e2b5ec
Merge pull request #3562 from perillamint/vrsvc 
am: Implement VR related APIs
 2020-03-28 13:32:52 -04:00
bunnei 997a802bd6
Merge pull request #3569 from bunnei/hid-stub 
services: hid: Stub InitializeSevenSixAxisSensor.
 2020-03-28 04:10:45 -04:00
ReinUsesLisp b6c9fba81c renderer_vulkan/wrapper: Address feedback 2020-03-28 04:09:02 -03:00
ReinUsesLisp 5300a918c6 shader/lea: Simplify generated LEA code 2020-03-28 03:55:04 -03:00
bunnei 75795a9a63
Merge pull request #3573 from FearlessTobi/port-5089 
Port citra-emu/citra#5089: "Set render window's focus policy to Qt::StrongFocus"
 2020-03-28 01:48:46 -04:00
FearlessTobi 8ba06aa4e1 yuzu: fix the stuck in fullscreen mode bug 
Co-Authored-By: Valentin Vanelslande <vvanelslandedev@gmail.com>
 2020-03-28 02:31:35 +01:00
ReinUsesLisp 523a709bf1 shader/lea: Fix op_a and op_b usages 
They were swapped.
 2020-03-27 18:37:20 -03:00
ReinUsesLisp 796b3319e6 shader/lea: Remove const and use move when possible 2020-03-27 18:36:38 -03:00
Vitor K 10ba8d16be Set render window to also accept focus via tabbing (Qt::StrongFocus) (#5089) 2020-03-27 22:25:01 +01:00
Fernando Sahmkow 7a2f60df26
Merge pull request #3565 from ReinUsesLisp/image-format 
engines/const_buffer_engine_interface: Store image format and types
 2020-03-27 14:08:54 -04:00
bunnei 8a6a25e4b6 services: hid: Stub InitializeSevenSixAxisSensor. 
- Used by Super Smash Bros. Ultimate v7.0.0.
 2020-03-27 10:48:01 -04:00
bunnei a60f34a850 services: time: Implement CalculateSpanBetween. 
- Used by Super Smash Bros. Ultimate.
 2020-03-27 10:42:13 -04:00
perillamint a429644672 am: Implement VR related APIs 
Implement (and stub) VR related APIs in AM sysmodule.

This fixes issue #2938
 2020-03-27 18:22:28 +09:00
ReinUsesLisp 2694552b7f renderer_vulkan/wrapper: Add owning handles 2020-03-27 03:21:04 -03:00
ReinUsesLisp 7413b30923 renderer_vulkan/wrapper: Add pool allocations owning templated class 2020-03-27 03:21:04 -03:00
ReinUsesLisp d8d392b39a renderer_vulkan/wrapper: Add owning handle templated class 2020-03-27 03:21:04 -03:00
ReinUsesLisp 60f351084a renderer_vulkan/wrapper: Add destroy and free overload set 2020-03-27 03:21:04 -03:00
ReinUsesLisp a9e4528d10 renderer_vulkan/wrapper: Add dispatch table and loaders 2020-03-27 03:21:04 -03:00
ReinUsesLisp 3f0b7673f0 renderer_vulkan/wrapper: Add exception class 2020-03-27 03:21:04 -03:00
ReinUsesLisp f5cee0e885 renderer_vulkan/wrapper: Add ToString function for VkResult 2020-03-27 03:21:03 -03:00
ReinUsesLisp 92c8d783b3 renderer_vulkan/wrapper: Add Vulakn wrapper and a span helper 
The intention behind a Vulkan wrapper is to drop Vulkan-Hpp.

The issues with Vulkan-Hpp are:
- Regular breaks of the API.
- Copy constructors that do the same as the aggregates (fixed recently)
- External dynamic dispatch that is hard to remove
- Alias KHR handles with non-KHR handles making it impossible to use
smart handles on Vulkan 1.0 instances with extensions that were included
on Vulkan 1.1.
- Dynamic dispatchers silently change size depending on preprocessor
definitions. Different files will have different dispatch definitions,
generating all kinds of hard to debug memory issues.

In other words, Vulkan-Hpp is not "production ready" for our needs and
this wrapper aims to replace it without losing RAII and exception
safety.
 2020-03-27 03:13:18 -03:00
ReinUsesLisp cedbe925cd engines/const_buffer_engine_interface: Store image format type 
This information is required to properly implement SULD.B. It might also
be handy for all image operations, since it would allow us to implement
them on devices that require the image format to be specified (on
desktop, this would be AMD on OpenGL and Intel on OpenGL and Vulkan).
 2020-03-27 00:36:22 -03:00
Dan 744b207d92 maxwell_to_vk: implement signedscaled vertex formats 2020-03-27 00:14:19 +01:00
bunnei 950b6dbc80
Merge pull request #3453 from FearlessTobi/remove-pause-lock 
yuzu: Remove exit lock for game pausing
 2020-03-26 16:42:57 -04:00
bunnei 5228bd0bb9 services: ldr: Fix MemoryState for read/write regions of NROs. 
- Fixes #3541, used by Final Fantasy VIII Remastered.
 2020-03-26 15:52:59 -04:00
James Rowe cf9c94d401 Address review and fix broken yuzu-tester build 2020-03-25 23:32:42 -06:00
ReinUsesLisp 46791c464a shader/conversion: Fix F2F rounding operations with different sizes 
Rounding operations only matter when the conversion size of source and
destination is the same, i.e. .F16.F16, .F32.F32 and .F64.F64.

When there is a mismatch (.F16.F32), these bits are used for IEEE
rounding, we don't emulate this because GLSL and SPIR-V don't support
configuring it per operation.
 2020-03-26 01:58:49 -03:00
ReinUsesLisp 7617e88fb2 gl_rasterizer: Update stencil test regardless of it being disabled 2020-03-26 01:08:14 -03:00
ReinUsesLisp c310cef615 gl_rasterizer: Synchronize stencil testing on clears 2020-03-26 00:51:47 -03:00
bunnei 23c7dda710
Merge pull request #3544 from makigumo/myfork/patch-2 
xmad: fix clang build error
 2020-03-25 19:29:16 -04:00
bunnei e6aff11057
Merge pull request #3520 from ReinUsesLisp/legacy-varyings 
gl_shader_decompiler: Implement legacy varyings
 2020-03-25 19:27:51 -04:00
James Rowe 282adfc70b Frontend/GPU: Refactor context management 
Changes the GraphicsContext to be managed by the GPU core. This
eliminates the need for the frontends to fool around with tricky
MakeCurrent/DoneCurrent calls that are dependent on the settings (such
as async gpu option).

This also refactors out the need to use QWidget::fromWindowContainer as
that caused issues with focus and input handling. Now we use a regular
QWidget and just access the native windowHandle() directly.

Another change is removing the debug tool setting in FrameMailbox.
Instead of trying to block the frontend until a new frame is ready, the
core will now take over presentation and draw directly to the window if
the renderer detects that its hooked by NSight or RenderDoc

Lastly, since it was in the way, I removed ScopeAcquireWindowContext and
replaced it with a simple subclass in GraphicsContext that achieves the
same result
 2020-03-24 21:03:42 -06:00
bunnei f8382c9d9d
Merge pull request #3524 from FearlessTobi/port-5106 
Port citra-emu/citra#5106: "gdbstub: Ensure gdbstub doesn't drop packets crucial to initialization"
 2020-03-24 16:50:58 -04:00
Fernando Sahmkow 497f593525
Merge pull request #3543 from ReinUsesLisp/gl-depth-range 
gl_rasterizer: Use transformed viewport for depth ranges
 2020-03-23 12:00:21 -04:00
Fernando Sahmkow 7981910746
Merge pull request #3542 from namkazt/patch-10 
Implement MME shadow RAM
 2020-03-23 12:00:01 -04:00
FearlessTobi 4afebf26b6 sm/controller: Increase PointerBufferSize 
This increases the PointerBufferSize as a lager one is required by some services.
This change is still not hw-accurate, but it is proven to work in Ryujinx.

Instead of using a hardcoded size, we should figure out the specific values for each service in the future. Some of them can be taken from Atmosphere: https://github.com/Atmosphere-NX/Atmosphere/search?q=PointerBufferSize.
 2020-03-23 03:19:30 +01:00
FearlessTobi 5d3b228409 audio_core: Accept Audren REV8 
According to Ryujinx, REV8 only added changes on Performance buffer and Wavebuffer DSP command generation.

As we don't support any of those, we can just increment the revision number for now.
 2020-03-23 03:07:14 +01:00
makigumo 5a5c6d4ed8 xmad: fix clang build error 2020-03-23 00:09:31 +01:00
bunnei e731c4b991
Merge pull request #3477 from FearlessTobi/webapplet-shit 
core/web_browser: Allow WebApplet to exit gracefully when an error occurs
 2020-03-22 13:11:02 -04:00
namkazy fc37672f26 apply replay logic to all writes. remove replay from MacroInterpreter::Send (@fincs) 2020-03-22 22:25:44 +07:00
FearlessTobi 977418c65b core/web_browser: Allow WebApplet to exit gracefully when an error occurs 
Currently, yuzu just freezes when an error occurs while Initializing the WebApplet.
From a user perspective, this obviously isn't great as the game just softlocks.
With this change, yuzu will call the Finalize method, so to the game it seems like as the user just exited the WebApplet normally.

This works around https://github.com/yuzu-emu/yuzu/issues/2852.
 2020-03-22 16:01:13 +01:00
namkazy f66743cd0c maxwell_3d: change declaration order 2020-03-22 13:41:16 +07:00
namkazy d4e93cf38c maxwell_3d: init shadow_state 2020-03-22 13:35:11 +07:00
ReinUsesLisp bdcedc8506 gl_rasterizer: Use transformed viewport for depth ranges 
Implement depth ranges using the transformed viewport instead of the
generic one. This matches the current Vulkan implementation but doesn't
support negative depth ranges. An update to glad is required for this.
 2020-03-22 03:26:07 -03:00
namkazy 22f4268c2f maxwell_3d: this seem more correct. 2020-03-22 12:02:54 +07:00
namkazy 7051dc1902 maxwell_3d: update comments for shadow ram usage 2020-03-22 11:35:26 +07:00
Nguyen Dac Nam 01af036c1f marco_interpreter: write hw value when shadow ram requested 2020-03-22 10:53:41 +07:00
Nguyen Dac Nam 63c2635e6f maxwell_3d: track shadow ram ctrl and hw reg value 2020-03-22 10:53:41 +07:00
Nguyen Dac Nam dbfbe352e0 maxwell_3d: implement MME shadow RAM 2020-03-22 10:53:35 +07:00
bunnei e5bb5d13c4
Merge pull request #3531 from makigumo/yuzu_master 
set: implement GetRegionCode
 2020-03-21 22:49:28 -04:00
bunnei e70451d967
Merge pull request #3525 from FearlessTobi/linux-compile-error 
input_common/udp: Fix Linux build by using a backwards compatible way of error checking
 2020-03-21 16:04:45 -04:00
bunnei 81fa492825
Merge pull request #3526 from FearlessTobi/bcat-disable 
bcat: Disable Boxcat backend by default
 2020-03-20 13:01:28 -04:00
bunnei bdddbe2daa
Merge pull request #3505 from namkazt/patch-8 
shader_decode: implement XMAD mode CSfu
 2020-03-19 17:41:01 -04:00
Dan 06dea163fa set: implement GetRegionCode 2020-03-19 10:37:42 +01:00
bunnei bc681dc555
Merge pull request #3527 from FearlessTobi/output-mode 
yuzu: Save sound output mode and set it to Stereo by default
 2020-03-18 23:19:22 -04:00
Mat M 9418b983bd
Merge pull request #3535 from ReinUsesLisp/gcc-warnings 
video_core: Silence misc warnings
 2020-03-18 20:09:32 -04:00
ReinUsesLisp 38c1e77f01 vk_texture_cache: Silence misc warnings 2020-03-18 20:03:19 -03:00
ReinUsesLisp b6b2e31e5e vk_staging_buffer_pool: Silence unused constant warning 2020-03-18 20:03:19 -03:00
ReinUsesLisp fc51ece7bf vk_rasterizer: Remove unused variable 2020-03-18 20:03:19 -03:00
ReinUsesLisp 98d85cdc20 vk_pipeline_cache: Remove unused variable 2020-03-18 20:03:19 -03:00
ReinUsesLisp dab450ec46 maxwell_to_vk: Sielence -Wswitch warning 2020-03-18 20:03:19 -03:00
ReinUsesLisp 351816ac38 gl_shader_decompiler: Remove deprecated function and its usages 2020-03-18 20:03:19 -03:00
ReinUsesLisp acf328a71f gl_rasterizer: Silence misc warnings 2020-03-18 20:03:19 -03:00
ReinUsesLisp 9f46066bda kepler_compute: Remove unused variables 2020-03-18 20:03:19 -03:00
ReinUsesLisp ac7ee21331 time_zone_content_manager: Fix out of bounds read 
There were cases where raw_data didn't contain enough
space to hold the zero terminator.

This was caught with -fsanitize=address.
 2020-03-18 19:06:16 -03:00
ReinUsesLisp 716d6aee30 input_common/udp: Fix clang build issues 2020-03-18 04:30:26 -03:00
ReinUsesLisp 664fa4ea06 astc: Fix clang build issues 2020-03-18 04:30:25 -03:00
ReinUsesLisp f5658a9fda gl_shader_decompiler: Don't redeclare gl_VertexID and gl_InstanceID 2020-03-18 01:28:41 -03:00
Mat M edb9cccb36
Merge pull request #3510 from FernandoS27/dirty-write 
DirtyFlags: relax need to set render_targets as dirty
 2020-03-17 17:29:22 -04:00
Mat M f54d2d3114
Merge pull request #3509 from ReinUsesLisp/astc-opts 
astc: General changes and optimizations
 2020-03-17 17:28:49 -04:00
Mat M d787856621
Merge pull request #3518 from ReinUsesLisp/scissor-clears 
vk_rasterizer: Implement scissor clears and layered clears
 2020-03-17 17:27:15 -04:00
Mat M 9fdfd58f9f
Merge pull request #3519 from ReinUsesLisp/int-formats 
maxwell_to_vk: Implement RG32 and RGB32 integer vertex formats
 2020-03-17 17:26:16 -04:00
FearlessTobi cdeadd448b yuzu: Save sound output mode and set it to Stereo by default 2020-03-17 19:03:00 +01:00
bunnei 1c45c8086e
Merge pull request #3498 from ReinUsesLisp/texel-fetch-glsl 
gl_shader_decompiler: Add layer component to texelFetch
 2020-03-17 10:53:38 -04:00
FearlessTobi 2fd3b328ae bcat: Disable Boxcat backend by default 
This commit disables the Boxcat backend by default for new users of yuzu.

There's several reasons as to why this is done:
1. Boxcat currently only actually has an impact on 3 games and doesn't influence any core mechanics of them
2. It causes a plethora of issues when enabled such as games like Crash Team Racing, Diablo 3 and Tales of Vesperia not booting at all or hanging
3. It causes https://github.com/yuzu-emu/yuzu/issues/2957 to happen. This makes the configuration menu totally unusable for many Linux users of yuzu

I think those points show that currently the negative impact of Boxcat outweighs its benefits and should therefore be disabled by default.
For users who are eager to use the extra features provided by it, they can still just turn it on in the settings.
 2020-03-17 15:24:26 +01:00
FearlessTobi 230ac6a4e8 input_common/udp: Fix Linux build by using a backwards compatible way of error checking 
Should fix https://github.com/yuzu-emu/yuzu/issues/3487.

error_code::failed is a function which has been introduced in Boost 1.69.
This version of boost hasn't landed in most major distros yet.
 2020-03-17 12:29:25 +01:00
Gauvain "GovanifY" Roussel-Tarbouriech eae2ed6b07 gdbstub: small logic bug fix with defer_start 2020-03-17 11:18:39 +01:00
Gauvain "GovanifY" Roussel-Tarbouriech 38036eb1c8 gdbstub: Ensure gdbstub doesn't drop packets crucial to initialization 2020-03-17 11:18:13 +01:00
ReinUsesLisp 53d673a7d3 renderer_opengl: Move some logic to an anonymous namespace 2020-03-16 04:03:34 -03:00
ReinUsesLisp 311d2fc768 renderer_opengl: Detect Nvidia Nsight as a debugging tool 
Use getenv to detect Nsight.
 2020-03-16 03:59:08 -03:00
Rodrigo Locatti b16c8e0e8d
Merge pull request #3515 from ReinUsesLisp/vertex-vk-assert 
vk_rasterizer: Fix vertex range assert
 2020-03-15 21:26:54 -03:00
Rodrigo Locatti 7cc46a6faa
Merge pull request #3501 from ReinUsesLisp/rgba16-snorm 
video_core: Implement RGBA16_SNORM
 2020-03-15 21:24:53 -03:00
Rodrigo Locatti ddafc99776
Merge pull request #3502 from namkazt/patch-3 
shader_decode: Reimplement BFE instructions
 2020-03-15 21:23:04 -03:00
Rodrigo Locatti d64edf21bb
Merge pull request #3503 from makigumo/patch-2 
maxwell_to_vk: add vertex format eA2B10G10R10UnormPack32
 2020-03-15 21:21:38 -03:00
ReinUsesLisp 5afc397d52 gl_shader_decompiler: Implement legacy varyings 
Legacy varyings are special attributes carried over in hardware from
the OpenGL 1 and OpenGL 2 days. These were generally used instead of the
generic attributes we use today. They are deprecated or removed from
most APIs, but Nvidia still ships them in hardware.

To implement these, this commit maps them 1:1 to OpenGL compatibility.
 2020-03-15 21:03:59 -03:00
ReinUsesLisp 6442e02c5d shader/shader_ir: Track usage in input attribute and of legacy varyings 2020-03-15 21:01:52 -03:00
ReinUsesLisp 8e6e55d6f8 shader/shader_ir: Fix clip distance usage stores 2020-03-15 20:53:14 -03:00
ReinUsesLisp 464bd5fad7 shader/shader_ir: Change declare output attribute to a switch 2020-03-15 20:49:35 -03:00
Rodrigo Locatti 86b1f15d9a
Merge pull request #3512 from bunnei/fix-renderdoc 
renderer_opengl: Keep frames synchronized when using a GPU debugger.
 2020-03-15 19:28:43 -03:00
ReinUsesLisp 52acb7f9a0 maxwell_to_vk: Implement RG32 and RGB32 integer vertex formats 2020-03-15 18:51:49 -03:00
ReinUsesLisp 71cc772988 vk_rasterizer: Implement layered clears 2020-03-15 18:37:19 -03:00
makigumo f91046bf8d
vk_shader_decompiler: fix linux build 2020-03-15 18:00:14 +01:00
ReinUsesLisp a7131af7d6 vk_rasterizer: Fix vertex range assert 
End can be equal to start in CalculateVertexArraysSize. This is quite
common when the vertex size is zero.
 2020-03-15 04:04:17 -03:00
ReinUsesLisp 8baf98e439 vk_rasterizer: Reimplement clears with vkCmdClearAttachments 2020-03-15 03:40:41 -03:00
bunnei c5afe93dcc renderer_opengl: Keep presentation frames in lock-step when GPU debugging. 
- Fixes renderdoc with OpenGL renderer.
 2020-03-14 17:45:01 -04:00
bunnei 4373fa8042 gl_device: Add option to check GL_EXT_debug_tool. 2020-03-14 17:39:29 -04:00
bunnei 4dfd5c84ea
Merge pull request #3508 from FernandoS27/page-table 
PageTable: move backing addresses to a children class as the CPU page table does not need them.
 2020-03-14 16:50:27 -04:00
Fernando Sahmkow 380fc8d2e1 DirtyFlags: relax need to set render_targets as dirty 
The texture cache already takes care of setting a render target to dirty 
when invalidated.
 2020-03-14 11:47:33 -04:00
Fernando Sahmkow c51dbf8038
Merge pull request #3500 from ReinUsesLisp/incompatible-types 
texture_cache: Report incompatible textures as black
 2020-03-14 09:49:05 -04:00
Fernando Sahmkow 41905ee467
Merge pull request #3499 from ReinUsesLisp/depth-2d-array 
texture_cache/surface_params: Force depth=1 on 2D textures
 2020-03-14 09:48:39 -04:00
Fernando Sahmkow 27cbb75e7c PageTable: move backing addresses to a children class as the CPU page table does not need them. 
This PR aims to reduce the memory usage in the CPU page table by moving
GPU specific parameters into a child class. This saves 1Gb of Memory for
most games.
 2020-03-14 09:43:57 -04:00
ReinUsesLisp 42cb8f1124 astc: Fix typos from search and replace 2020-03-14 01:05:20 -03:00
ReinUsesLisp 9b8fb3c756 astc: Minor changes to InputBitStream 2020-03-14 00:45:54 -03:00
ReinUsesLisp d71d7d917e astc: Pass val in Replicate by copy 2020-03-14 00:13:58 -03:00
ReinUsesLisp 134f3ff9b4 astc: Call std::vector:reserve on decodedClolorValues to avoid reallocating 2020-03-14 00:09:56 -03:00
Nguyen Dac Nam 3287b1247d
clang-format 2020-03-14 10:07:40 +07:00
Nguyen Dac Nam 240d45830d
nit 2020-03-14 09:57:24 +07:00
ReinUsesLisp 3377b78ea7 astc: Call std::vector::reserve on texelWeightValues to avoid reallocating 2020-03-13 23:52:51 -03:00
ReinUsesLisp 801fd04f75 astc: Create a LUT at compile time for encoding values 2020-03-13 23:40:02 -03:00
ReinUsesLisp e183820956 astc: Make IntegerEncodedValue a trivial structure 2020-03-13 22:49:28 -03:00
ReinUsesLisp 70a31eda62 astc: Make IntegerEncodedValue constructor constexpr 2020-03-13 22:36:45 -03:00
ReinUsesLisp 5ed377b989 astc: Make IntegerEncodedValue trivially copyable 2020-03-13 22:30:31 -03:00
ReinUsesLisp e7d97605e8 astc: Rename C types to common_types 2020-03-13 22:28:51 -03:00
ReinUsesLisp 835a3d09c6 astc: Move Popcnt to an anonymous namespace and make it constexpr 2020-03-13 22:26:48 -03:00
ReinUsesLisp 731a9a322e astc: Use common types instead of stdint.h integer types 2020-03-13 22:22:27 -03:00
ReinUsesLisp d3dc4e399c astc: Use 'enum class' instead of 'enum' for EIntegerEncoding 2020-03-13 22:20:12 -03:00
ReinUsesLisp 69c7a01f88 vk/gl_shader_decompiler: Silence assertion on compute 2020-03-13 18:33:05 -03:00
ReinUsesLisp 62560f1e63 vk_shader_decompiler: Fix default varying regression 2020-03-13 18:33:05 -03:00
ReinUsesLisp afebdda203 maxwell_3d: Add padding words to XFB entries 
Use INSERT_UNION_PADDING_WORDS instead of alignas to ensure a size
requirement.
 2020-03-13 18:33:05 -03:00
ReinUsesLisp 4bc4851d45 gl_shader_decompiler: Fix implicit conversion errors 2020-03-13 18:33:05 -03:00
Rodrigo Locatti 47459f6a36 vk_shader_decompiler: Fix implicit type conversion 
Co-Authored-By: Mat M. <mathew1800@gmail.com>
 2020-03-13 18:33:05 -03:00
ReinUsesLisp 2fae1e6205 vk_rasterizer: Implement transform feedback binding zero 2020-03-13 18:33:05 -03:00
ReinUsesLisp b67360c0f8 vk_shader_decompiler: Add XFB decorations to generic varyings 2020-03-13 18:33:05 -03:00
ReinUsesLisp 8d5bdcb17b vk_device: Enable VK_EXT_transform_feedback when available 2020-03-13 18:33:05 -03:00
ReinUsesLisp c320702092 vk_device: Shrink formatless capability name size 2020-03-13 18:33:05 -03:00
ReinUsesLisp ae6189d7c2 shader/transform_feedback: Expose buffer stride 2020-03-13 18:33:05 -03:00
ReinUsesLisp 7acebd7eb6 vk_shader_decompiler: Use registry for specialization 2020-03-13 18:33:05 -03:00
ReinUsesLisp 8e9f23f393 gl_rasterizer: Implement transform feedback bindings 2020-03-13 18:33:04 -03:00
ReinUsesLisp 4d711dface gl_shader_decompiler: Decorate output attributes with XFB layout 
We sometimes have to slice attributes in different parts. This is needed
for example in instances where the game feedbacks 3 components but
writes 4 from the shader (something that is possible with
GL_NV_transform_feedback).
 2020-03-13 18:33:04 -03:00
ReinUsesLisp 3dcaa84ba4 shader/transform_feedback: Add host API friendly TFB builder 2020-03-13 18:33:04 -03:00
Rodrigo Locatti 244fe13219
Merge branch 'master' into shader-purge 2020-03-13 16:44:06 -03:00
bunnei b30b1f741d
Merge pull request #3491 from ReinUsesLisp/polygon-modes 
gl_rasterizer: Implement polygon modes and fill rectangles
 2020-03-13 10:08:57 -04:00
Nguyen Dac Nam 829f424618
nit & remove some optional param 2020-03-13 20:47:38 +07:00
Nguyen Dac Nam a166217480
shader_decode: implement XMAD mode CSfu 2020-03-13 19:01:49 +07:00
makigumo 753bc2026f
fix formatting 2020-03-13 11:37:24 +01:00
makigumo 54681909be
maxwell_to_vk: add vertex format eA2B10G10R10UnormPack32 2020-03-13 11:26:13 +01:00
Nguyen Dac Nam 00607fe1e0
clang-format 2020-03-13 15:38:57 +07:00
Nguyen Dac Nam 325977c0c6
Apply suggestions from code review 
Co-Authored-By: Mat M. <mathew1800@gmail.com>
 2020-03-13 15:35:15 +07:00
Nguyen Dac Nam 70ff82f72d
shader_decode: BFE add ref of reverse parallel method. 2020-03-13 14:20:18 +07:00
Nguyen Dac Nam 96a4abe12d
shader_decode: implement BREV on BFE 
Implement reverse parallel follow: https://graphics.stanford.edu/~seander/bithacks.html#ReverseParallel
 2020-03-13 14:13:31 +07:00
Nguyen Dac Nam 93547cac68
shader_bytecode: update BFE instructions struct. 2020-03-13 12:52:16 +07:00
Nguyen Dac Nam 911c56ccef
node_helper: add IBitfieldExtract case 2020-03-13 12:50:32 +07:00
Nguyen Dac Nam 465ba30d08
shader_decode: Reimplement BFE instructions 2020-03-13 12:48:01 +07:00
ReinUsesLisp e24197bb3f gl_shader_decompiler: Initialize gl_Position on vertex shaders 2020-03-12 23:31:06 -03:00
Fernando Sahmkow 00e9ba0603
Merge pull request #3483 from namkazt/patch-1 
vk_rasterizer: fix mistype on SetupGraphicsImages
 2020-03-12 22:10:48 -04:00
Fernando Sahmkow f159a12820
Merge pull request #3480 from ReinUsesLisp/vk-disabled-ubo 
vk_rasterizer: Support disabled uniform buffers
 2020-03-12 22:09:49 -04:00
ReinUsesLisp 3a10016e38 gl_shader_decompiler: Add missing {} on smem GLSL emission 2020-03-12 21:50:37 -03:00
ReinUsesLisp 4dcca90ef4 video_core: Implement RGBA16_SNORM 
Implement RGBA16_SNORM with the current API. Nothing special here.
 2020-03-12 21:42:33 -03:00
ReinUsesLisp e22816a5bb texture_cache: Report incompatible textures as black 
Some games bind incompatible texture types to certain types.
For example Astral Chain binds a 2D texture with 1 layer (non-array) to
a cubemap slot (that's how it's used in the shader). After testing this
in hardware, the expected "undefined behavior" is to report all pixels
as black.

We already have a path for reporting black textures in the texture
cache. When textures types are incompatible, this commit binds these
kind of textures. This is done on the API agnostic texture cache so no
extra code has to be inserted on OpenGL or Vulkan.

As a side effect, this fixes invalidations of ASTC textures on Astral
Chain. This happened because yuzu detected a cube texture and forced
6 faces, generating a texture larger than what the TIC reported.
 2020-03-12 18:22:05 -03:00
ReinUsesLisp daae6a323b texture_cache/surface_params: Force depth=1 on 2D textures 
Sometimes games will sample a 2D array TIC with a 2D access in the
shader. This causes bad interactions with the rest of the texture cache.
To emulate what the game wants to do, force a depth=1 on 2D textures
(not 2D arrays) and let the texture cache handle the rest.
 2020-03-12 18:11:42 -03:00
ReinUsesLisp 38fe070d78 gl_shader_decompiler: Add layer component to texelFetch 
TexelFetch was not emitting the array component generating invalid GLSL.
 2020-03-12 18:10:29 -03:00
bunnei ca2d228c9d
Merge pull request #3497 from FernandoS27/microprogfile-extend 
Small corrections and features to microprofile
 2020-03-12 12:14:03 -04:00
bunnei c21dc36cda
Merge pull request #3496 from vitor-k/remove-enum 
framebuffer_layout.h: drop the use of enum for screen dimensions
 2020-03-12 12:00:39 -04:00
Fernando Sahmkow 95b804ff05 NVFlinger: Do the microprofile Flip after processing a valid frame. 2020-03-12 10:52:44 -04:00
ReinUsesLisp 825d629565 gl_shader_decompiler: Fix regression in render target declarations 
A previous commit introduced a way to declare as few render targets as
possible. Turns out this introduced a regression in some games.
 2020-03-12 05:01:20 -03:00
bunnei fce33adcf1
Merge pull request #3494 from ReinUsesLisp/fix-cs-pipeline 
gl_shader_manager: Fix interaction between graphics and compute
 2020-03-11 13:51:54 -04:00
Vitor Kiguchi e891ff9a0c framebuffer_layout.h: drop the use of enum for screen dimensions. 
+clang format
 2020-03-11 14:22:28 -03:00
ReinUsesLisp 8357908099 gl_shader_manager: Fix interaction between graphics and compute 
After a compute shader was set to the pipeline, no graphics shader was
invoked again. To address this use glUseProgram to bind compute shaders
(without state tracking) and call glUseProgram(0) when transitioning out
of it back to the graphics pipeline.
 2020-03-11 01:04:52 -03:00
bunnei 503ebe9b96
Merge pull request #3458 from FearlessTobi/voice-issues 
cubeb_sink: Don't discard other channels when performing downmixing
 2020-03-10 22:18:37 -04:00
ReinUsesLisp e4bc3c3342 gl_rasterizer: Implement polygon modes and fill rectangles 2020-03-09 20:39:58 -03:00
ReinUsesLisp eb5861e0a2 engines/maxwell_3d: Add TFB registers and store them in shader registry 2020-03-09 18:40:53 -03:00
ReinUsesLisp b1acb4f73f shader/registry: Address feedback 2020-03-09 18:40:53 -03:00
ReinUsesLisp b1061afed9 gl_shader_decompiler: Add identifier to decompiled code 2020-03-09 18:40:53 -03:00
ReinUsesLisp e612242977 gl_shader_decompiler: Roll back to GLSL core 430 
RenderDoc won't build shaders if we use GLSL compatibility.
 2020-03-09 18:40:53 -03:00
ReinUsesLisp 978172530e const_buffer_engine_interface: Store component types 
This is required for Vulkan. Sampling integer textures with float
handles is illegal.
 2020-03-09 18:40:53 -03:00
ReinUsesLisp 120f688272 yuzu/loading_screen: Remove unused shader progress mode 2020-03-09 18:40:53 -03:00
ReinUsesLisp e1932351a9 gl_shader_cache: Reduce registry consistency to debug assert 
Registry consistency is something that practically can't happen and it
has a measurable runtime cost. Reduce it to a DEBUG_ASSERT.
 2020-03-09 18:40:07 -03:00
ReinUsesLisp 66a8a3e887 shader/registry: Cache tessellation state 2020-03-09 18:40:07 -03:00
ReinUsesLisp 0528be5c92 shader/registry: Store graphics and compute metadata 
Store information GLSL forces us to provide but it's dynamic state in
hardware (workgroup sizes, primitive topology, shared memory size).
 2020-03-09 18:40:07 -03:00
ReinUsesLisp e8efd5a901 video_core: Rename "const buffer locker" to "registry" 2020-03-09 18:40:06 -03:00
ReinUsesLisp bd8b9bbcee gl_shader_cache: Rework shader cache and remove post-specializations 
Instead of pre-specializing shaders and then post-specializing them,
drop the later and only "specialize" the shader while decoding it.
 2020-03-09 18:40:06 -03:00
Rodrigo Locatti 22e825a3bc
Merge pull request #3301 from ReinUsesLisp/state-tracker 
video_core: Remove gl_state and use a state tracker based on dirty flags
 2020-03-09 18:34:37 -03:00
ReinUsesLisp 1aa75b1081 textures: Fix anisotropy hack 
Previous code could generate an anisotropy value way higher than x16.
 2020-03-08 15:59:38 -03:00
FearlessTobi 59d0d34dce cubeb_sink: Don't discard other channels when performing downmixing 
Previously, when performing downmixing, we would discard all channels except the left and right one.
This implementation respects them when mixing down to Stereo.
It is taken from this document: http://www.atsc.org/wp-content/uploads/2015/03/A52-201212-17.pdf.

Fixes Luigis Mansion 3 cutscene and Bayonetta audio.
 2020-03-08 03:16:06 -04:00
bunnei 84e9f9f395
Merge pull request #3452 from Morph1984/anisotropic-filtering 
frontend/Graphics: Add "Advanced" graphics tab and experimental Anisotropic Filtering support
 2020-03-07 22:28:35 -05:00
Nguyen Dac Nam 16cfbb068c
vk_reasterizer: fix mistype on SetupGraphicsImages 
This should use Maxwell3D engine. Fixed some GPU error on Kirby and maybe other games.
 2020-03-08 10:06:59 +07:00
bunnei 662feb8c1c
Merge pull request #3481 from ReinUsesLisp/abgr5-storage 
maxwell_to_vk: Remove Storage capability for A1B5G5R5U
 2020-03-07 19:51:33 -05:00
ReinUsesLisp e4f9ce0379 vk_rasterizer: Support disabled uniform buffers 2020-03-06 18:47:51 -03:00
ReinUsesLisp aa6fe3f1aa maxwell_to_vk: Remove Storage capability for A1B5G5R5U 2020-03-06 18:47:27 -03:00
bunnei 49eff536d0
Merge pull request #3463 from ReinUsesLisp/vk-toctou 
vk_swapchain: Silence TOCTOU race condition
 2020-03-05 19:38:42 -05:00
bunnei 4a8fe67964
Merge pull request #3479 from jroweboy/dont-log-on-no-input 
Minor fixes for udp input
 2020-03-05 15:09:48 -05:00
bunnei 0361aa1915
Merge pull request #3451 from ReinUsesLisp/indexed-textures 
vk_shader_decompiler: Implement indexed textures
 2020-03-05 11:42:46 -05:00
bunnei fa1d625eed
Merge pull request #3469 from namkazt/patch-1 
shader_decode: Fix LD, LDG when track constant buffer
 2020-03-04 23:10:01 -05:00
bunnei 1e84d22275
Merge pull request #3478 from bunnei/a32 
Refactoring to boot A32 games
 2020-03-04 20:37:51 -05:00
James Rowe 002d9508a0 input/udp - Add minor error handling to prevent bad input from crashing 2020-03-03 23:46:05 -07:00
bunnei 67e7186d79
Merge pull request #3455 from ReinUsesLisp/attr-scaled 
video_core: Implement more scaled attribute formats
 2020-03-03 22:46:20 -05:00
James Rowe fc205a1bc5 Frontend/SDL - Provide proper default for UDP input 
When the default file is read in, the settings default value is only used
when the key is missing. As it was, the key existed, but the value was empty string
causing it to accept that as a value to pass into the core
 2020-03-03 20:05:42 -07:00
James Rowe 2cdda8c564 input/udp - Dont log on invalid packet received 2020-03-03 19:52:16 -07:00
bunnei dba112e510 core: hle: Implement separate A32/A64 SVC interfaces. 2020-03-02 21:52:03 -05:00
bunnei c083ea7d78 core: Implement separate A32/A64 ARM interfaces. 2020-03-02 21:51:57 -05:00
bunnei 6fc485a607 core: loader: Remove check for 32-bit. 2020-03-02 21:43:15 -05:00
bunnei 64facb403e core: dynarmic: Add CP15 from Citra. 2020-03-02 21:43:15 -05:00
bunnei 08c638f249
Merge pull request #3464 from FernandoS27/jit-fix 
ARM_Interface: Cache the JITs instead of deleting/recreating.
 2020-03-02 21:41:43 -05:00
Nguyen Dac Nam 85a4222a8c
nit: move comment to right place. 2020-02-29 13:50:10 +07:00
bunnei ca7618684c
Merge pull request #3448 from bunnei/fix-audio-interp-2 
audio_core: interpolate: Improvements to fix audio crackling.
 2020-02-28 16:07:10 -05:00
ReinUsesLisp 735c003a70 video_core/dirty_flags: Address feedback 2020-02-28 17:56:43 -03:00
ReinUsesLisp ef7f6eb67d renderer_opengl: Fix edge-case where alpha testing might cull presentation 2020-02-28 17:56:43 -03:00
ReinUsesLisp a6a350ddc3 gl_texture_cache: Remove blending disable on blits 
Blending doesn't affect blits. Rasterizer discard does, update the
commentaries.
 2020-02-28 17:56:43 -03:00
ReinUsesLisp 887d5288ef gl_rasterizer: Don't disable blending on clears 
Blending doesn't affect clears.
 2020-02-28 17:56:43 -03:00
ReinUsesLisp ac204754d4 dirty_flags: Deduplicate code between OpenGL and Vulkan 2020-02-28 17:56:43 -03:00
ReinUsesLisp 6669b359a3 vk_rasterizer: Pass Maxwell registers to dynamic updates 2020-02-28 17:56:43 -03:00
ReinUsesLisp 042256c6bb state_tracker: Remove type traits with named structures 2020-02-28 17:56:43 -03:00
ReinUsesLisp 6ac3eb4d87 vk_state_tracker: Implement dirty flags for stencil properties 2020-02-28 17:56:43 -03:00
ReinUsesLisp f9df2c6bcd vk_state_tracker: Implement dirty flags for depth bounds 2020-02-28 17:56:43 -03:00
ReinUsesLisp cd0e28c9ec vk_state_tracker: Implement dirty flags for blend constants 2020-02-28 17:56:43 -03:00
ReinUsesLisp a33870996b vk_state_tracker: Implement dirty flags for depth bias 2020-02-28 17:56:43 -03:00
ReinUsesLisp 42f1874965 vk_state_tracker: Implement dirty flags for scissors 2020-02-28 17:56:43 -03:00
ReinUsesLisp 1bd95a314f vk_state_tracker: Initial implementation 
Add support for render targets and viewports.
 2020-02-28 17:56:43 -03:00
ReinUsesLisp b1498d2c54 gl_rasterizer: Remove num vertex buffers magic number 2020-02-28 17:56:43 -03:00
ReinUsesLisp 62437943a7 gl_rasterizer: Only apply polygon offset clamp if enabled 2020-02-28 17:56:43 -03:00
ReinUsesLisp 2eeea90713 gl_state_tracker: Implement dirty flags for depth clamp enabling 2020-02-28 17:56:43 -03:00
ReinUsesLisp 3ce66776ec gl_rasterizer: Disable scissor 0 when scissor is not used on clear 2020-02-28 17:56:43 -03:00
ReinUsesLisp 35bb9239ca gl_rasterizer: Notify depth mask changes on clear 2020-02-28 17:56:43 -03:00
ReinUsesLisp 98c8948b23 gl_rasterizer: Minor sort changes to clearing 2020-02-28 17:56:42 -03:00
ReinUsesLisp 15cadc3948 maxwell_3d: Use two tables instead of three for dirty flags 2020-02-28 17:56:42 -03:00
ReinUsesLisp a5bfc0d045 gl_state_tracker: Track state of index buffers 2020-02-28 17:56:42 -03:00
ReinUsesLisp a42a6e1a2c gl_state_tracker: Implement dirty flags for clip control 2020-02-28 17:56:42 -03:00
ReinUsesLisp 4f8d152b18 gl_state_tracker: Implement dirty flags for point sizes 2020-02-28 17:56:42 -03:00
ReinUsesLisp 231601763c gl_state_tracker: Implement dirty flags for fragment color clamp 2020-02-28 17:56:42 -03:00
ReinUsesLisp bf1a1d989f gl_state_tracker: Implement dirty flags for logic op 2020-02-28 17:56:42 -03:00
ReinUsesLisp 13afd0e5b0 gl_state_tracker: Implement dirty flags for sRGB 2020-02-28 17:56:42 -03:00
ReinUsesLisp d8f5c45051 gl_state_tracker: Implement dirty flags for rasterize enable 2020-02-28 17:56:42 -03:00
ReinUsesLisp b727d99441 gl_state_tracker: Implement dirty flags for multisample 2020-02-28 17:56:42 -03:00
ReinUsesLisp 3c22bd92d8 gl_state_tracker: Implement dirty flags for alpha testing 2020-02-28 17:56:42 -03:00
ReinUsesLisp 9e46953580 gl_state_tracker: Implement dirty flags for polygon offsets 2020-02-28 17:56:42 -03:00
ReinUsesLisp 46a1888e02 gl_state_tracker: Implement dirty flags for primitive restart 2020-02-28 17:56:42 -03:00
ReinUsesLisp 37536d7a49 gl_state_tracker: Implement dirty flags for stencil testing 2020-02-28 17:56:42 -03:00
ReinUsesLisp 40a2c57df5 gl_state_tracker: Implement depth dirty flags 2020-02-28 17:56:42 -03:00
ReinUsesLisp b910a83a47 gl_state_tracker: Implement dirty flags for front face and culling 2020-02-28 17:56:42 -03:00
ReinUsesLisp b01dd7d1c8 gl_state_tracker: Implement dirty flags for blending 2020-02-28 17:56:42 -03:00
ReinUsesLisp f7ec078592 gl_state_tracker: Implement dirty flags for clip distances and shaders 2020-02-28 17:56:42 -03:00
ReinUsesLisp 758ad3f75d gl_state_tracker: Add dirty flags for buffers and divisors 2020-02-28 17:56:42 -03:00
ReinUsesLisp 9b08698a0c maxwell_3d: Change write dirty flags to a bitset 2020-02-28 17:56:42 -03:00
ReinUsesLisp 69ad6279e4 gl_state_tracker: Implement dirty flags for vertex formats 2020-02-28 17:56:42 -03:00
ReinUsesLisp 6530144ccb gl_state_tracker: Implement dirty flags for color masks 2020-02-28 17:56:42 -03:00
ReinUsesLisp ba6f390448 gl_state_tracker: Implement dirty flags for scissors 2020-02-28 17:56:42 -03:00
ReinUsesLisp 7f52efdf61 gl_state_tracker: Implement dirty flags for viewports 2020-02-28 17:56:41 -03:00
ReinUsesLisp dacf83ac02 renderer_opengl: Reintroduce dirty flags for render targets 2020-02-28 17:56:41 -03:00
ReinUsesLisp 9e74e6988b maxwell_3d: Flatten cull and front face registers 2020-02-28 17:56:41 -03:00
ReinUsesLisp eed789d0d1 video_core: Reintroduce dirty flags infrastructure 2020-02-28 17:56:41 -03:00
ReinUsesLisp b92dfcd7f2 gl_state: Remove completely 2020-02-28 17:56:35 -03:00
ReinUsesLisp 1c4bf9cbfa gl_state: Remove program tracking 2020-02-28 17:52:14 -03:00
ReinUsesLisp 5ccb07933a gl_state: Remove framebuffer tracking 2020-02-28 17:52:10 -03:00
ReinUsesLisp 17a7fa751b gl_state: Remove image tracking 2020-02-28 17:36:40 -03:00
ReinUsesLisp 9677db03da gl_state: Remove texture and sampler tracking 2020-02-28 17:35:58 -03:00
ReinUsesLisp 1bc0da3dea gl_state: Remove blend state tracking 2020-02-28 17:34:43 -03:00
ReinUsesLisp 7d9a5e9e30 gl_state: Remove stencil test tracking 2020-02-28 17:32:05 -03:00
ReinUsesLisp 07a954e67f gl_state: Remove clip control tracking 2020-02-28 17:31:57 -03:00
ReinUsesLisp 1eee891f6e gl_state: Remove clip distances tracking 2020-02-28 17:26:26 -03:00
ReinUsesLisp e8125af8dd gl_state: Remove rasterizer disable tracking 2020-02-28 17:25:28 -03:00
ReinUsesLisp d3e433a380 gl_state: Remove viewport and depth range tracking 2020-02-28 17:25:18 -03:00
ReinUsesLisp 7c16b3551b gl_state: Remove scissor test tracking 2020-02-28 17:00:23 -03:00
ReinUsesLisp 0914c70b7f gl_state: Remove color mask tracking 2020-02-28 16:59:17 -03:00
ReinUsesLisp 2392b548be gl_state: Remove clamp framebuffer color tracking 
This commit doesn't reset it for screen draws because clamping doesn't
change anything there.
 2020-02-28 16:58:30 -03:00
ReinUsesLisp f92236976b gl_state: Remove multisample tracking 2020-02-28 16:57:47 -03:00
ReinUsesLisp 04d1134191 gl_state: Remove framebuffer sRGB tracking 2020-02-28 16:55:23 -03:00
ReinUsesLisp d5ab0358b6 gl_state: Remove VAO cache and tracking 2020-02-28 16:54:37 -03:00
ReinUsesLisp 2a662fea36 gl_state: Remove depth clamp tracking 2020-02-28 16:53:35 -03:00
ReinUsesLisp e1a16a52fa gl_state: Remove depth tracking 2020-02-28 16:52:46 -03:00
ReinUsesLisp 0f343d32c4 gl_state: Remove primitive restart tracking 2020-02-28 16:51:45 -03:00
ReinUsesLisp 42708c762e gl_state: Remove logic op tracker 2020-02-28 16:51:23 -03:00
ReinUsesLisp 915d73f3b8 gl_state: Remove blend color tracking 2020-02-28 16:50:58 -03:00
ReinUsesLisp a0321b984f gl_state: Remove polygon offset tracking 2020-02-28 16:49:20 -03:00
ReinUsesLisp f646321dd0 gl_state: Remove alpha test tracking 2020-02-28 16:48:57 -03:00
ReinUsesLisp c8f5f54a44 gl_state: Remove cull mode tracking 2020-02-28 16:48:23 -03:00
ReinUsesLisp 925521da5f gl_state: Remove front face tracking 2020-02-28 16:47:59 -03:00
ReinUsesLisp d2d5554296 gl_state: Remove point size tracking 2020-02-28 16:39:44 -03:00
ReinUsesLisp b95f064b51 gl_rasterizer: Add oglEnablei helper 2020-02-28 16:39:44 -03:00
ReinUsesLisp 1698143a1d gl_rasterizer: Add OpenGL enable/disable helper 2020-02-28 16:39:44 -03:00
ReinUsesLisp 96ac3d518a gl_rasterizer: Remove dirty flags 2020-02-28 16:39:27 -03:00
ReinUsesLisp e38ed26b98 common/math_util: Support float type rectangles 2020-02-28 16:22:11 -03:00
bunnei 5056d23d0d renderer_opengl: Fix SRGB presentation frame tracking. 
- Fixes SRGB in Super Smash Bros. Ultimate.
 2020-02-28 01:13:38 -05:00
Nguyen Dac Nam 6c0c2dfabc shader_decode: Fix LD, LDG when track constant buffer 2020-02-28 13:11:19 +07:00
Morph 7ee6065178 Create an "Advanced" tab in the graphics configuration tab and add anisotropic filtering levels. 2020-02-27 21:34:00 -05:00
bunnei 969357af1a
Merge pull request #3430 from bunnei/split-presenter 
Port citra-emu/citra#4940: "Split Presentation thread from Render thread"
 2020-02-27 19:51:55 -05:00
bunnei ebbfe73557 renderer_opengl: Reduce swap chain size to 3. 2020-02-27 19:50:17 -05:00
Morph e1efab1f51
AM/ICommonStateGetter: Stub SetLcdBacklighOffEnabled (#3454) 
* Stub SetLcdBacklighOffEnabled

Used by Super Smash Bros. Ultimate
We require backlight services to be implemented to turn on/off the backlight.

* Address feedback
 2020-02-27 17:49:23 +01:00
Nguyen Dac Nam db2f547434
shader: FMUL switch to using LUT (#3441) 
* shader: add FmulPostFactor LUT table

* shader: FMUL apply LUT

* Update src/video_core/engines/shader_bytecode.h

Co-Authored-By: Mat M. <mathew1800@gmail.com>

* nit: mistype

* clang-format & add missing import

* shader: remove post factor LUT.

* shader: move post factor LUT to function and fix incorrect order.

* clang-format

* shader: FMUL: add static to post factor LUT

* nit: typo

Co-authored-by: Mat M. <mathew1800@gmail.com>
 2020-02-27 11:14:25 -05:00
bunnei a17214baea renderer_opengl: Use more concise lock syntax. 2020-02-26 18:35:35 -05:00
bunnei aef159354c renderer_opengl: Move Frame/FrameMailbox to OpenGL namespace. 2020-02-26 18:28:50 -05:00
ReinUsesLisp 0aaa69e4d7 vk_swapchain: Silence TOCTOU race condition 
It's possible that the window is resized from the moment we ask for its
size to the moment a swapchain is created, causing validation issues.

To workaround this Vulkan issue request the capabilities again just
before creating the swapchain, making the race condition less likely.
 2020-02-26 17:07:18 -03:00
Fernando Sahmkow f3d4d4eaa8 ARM_Interface: Cache the JITs instead of deleting/recreating. 
This was a bug inherited from citra which was fixed by then at some 
time. This commit corrects such bug and ensures JITs are correctly 
recycled.
 2020-02-26 15:53:47 -04:00
bunnei 1f57f679a4
Merge pull request #3440 from namkazt/patch-6 
shader: implement LOP3 fast replace for old function
 2020-02-26 10:24:35 -05:00
bunnei 01a05b48b7
Merge pull request #3431 from CJBok/npad-fix 
InputCommon: analog_from_button get direction implementation
 2020-02-25 21:39:26 -05:00
bunnei 795893a9a5 renderer_opengl: Create gl_framebuffer_data if empty. 2020-02-25 21:23:02 -05:00
bunnei c6f78a4a6d frontend: qt: bootmanager: Acquire a shared context in main emu thread. 2020-02-25 21:23:02 -05:00
bunnei e25297536f frontend: qt: bootmanager: Vulkan: Restore support for VK backend. 2020-02-25 21:23:01 -05:00
bunnei 14877b8f35 frontend: qt: bootmanager: OpenGL: Implement separate presentation thread. 2020-02-25 21:23:01 -05:00
bunnei b2a38cce4e frontent: qt: main: Various updates/refactoring for separate presentation thread. 2020-02-25 21:23:00 -05:00
bunnei 667f026c95 core: frontend: Refactor scope_acquire_window_context to scope_acquire_context. 2020-02-25 21:23:00 -05:00
bunnei 2e16c23784 frontend: sdl2: emu_window: Implement separate presentation thread. 2020-02-25 21:23:00 -05:00
bunnei dc672ca4b3 renderer_opengl: Add texture mailbox support for presenter thread. 2020-02-25 21:22:59 -05:00
bunnei add2c38b73 renderer_opengl: Add OGLRenderbuffer to resource/state management. 2020-02-25 21:22:58 -05:00
bunnei 0c82b00dfd core: frontend: emu_window: Add TextureMailbox class. 2020-02-25 21:22:57 -05:00
bunnei 571451bdfe core: settings: Add setting to enable vsync, which is on by default. 2020-02-25 20:57:02 -05:00
Mat M 45ac1c62c6
Merge pull request #3461 from ReinUsesLisp/r32i-rt 
video_core/surface: Add R32_SINT render target format
 2020-02-25 17:47:14 -05:00
Mat M 00e3eab9c1
Merge pull request #3460 from ReinUsesLisp/unused-format-getter 
video_core/gpu: Remove unused functions
 2020-02-25 17:46:07 -05:00
ReinUsesLisp 466ce715e4 video_core/surface: Add R32_SINT render target format 2020-02-25 17:19:34 -03:00
ReinUsesLisp 3c648e3e2d video_core/gpu: Remove unused functions 2020-02-25 16:53:47 -03:00
bunnei 78ab2e0474
Merge pull request #3417 from ReinUsesLisp/r32i 
texture: Implement R32I
 2020-02-25 14:08:45 -05:00
FearlessTobi 7cbe6748c3 yuzu: Remove exit lock for game pausing 
This removes the "exit lock" popup from yuzu when pausing a game.

Motivation
The exit lock feature is broken in many ways and doesn't work properly in a lot of games, causing it to appear every time you want to pause the game or stop it, even in places where it wouldn't on Switch.

Additionally, the feature of pausing a game doesn't exist like this on Switch and yuzu should be guaranteed to be deterministic anyway, so pausing the emulation shouldn't be able to interrupt any critical processes in any way.
 2020-02-24 17:51:17 +01:00
bunnei e22ad52cdb
Merge pull request #3425 from ReinUsesLisp/layered-framebuffer 
texture_cache: Implement layered framebuffer attachments
 2020-02-24 10:14:50 -05:00
ReinUsesLisp 1e9213632a vk_shader_decompiler: Implement indexed textures 
Implement accessing textures through an index. It uses the same
interface as OpenGL, the main difference is that Vulkan bindings are
forced to be arrayed (the binding index doesn't change for stacked
textures in SPIR-V).
 2020-02-24 01:26:07 -03:00
ReinUsesLisp 1dda77d392 shader: Simplify indexed sampler usages 2020-02-24 01:26:07 -03:00
ReinUsesLisp e2dd59e341 video_core: Implement more scaler attribute formats 
While changing this, fix assert in vk_shader_decompiler. We now know
scaled formats are expected to be float in shaders attributes.
 2020-02-24 00:27:37 -03:00
bunnei 2b4cdb73b6
Merge pull request #3424 from ReinUsesLisp/spirv-layer 
vk_shader_decompiler: Implement Layer output attribute
 2020-02-22 23:45:16 -05:00
bunnei 754aac331f
Merge pull request #3422 from ReinUsesLisp/buffer-flush 
surface_base: Implement texture buffer flushes
 2020-02-22 23:09:50 -05:00
bunnei 1989e1b9ac audio_core: interpolate: Improvements to fix audio crackling. 
- Fixes audio crackling in Crash Team Racing Nitro-Fueled, Super Mario Odyssey, and others.
- Addresses followup issues from #3310.
 2020-02-22 22:26:16 -05:00
Fernando Sahmkow 3d0a2375ca Scheduler: Inline global scheduler in Scheduler Lock. 2020-02-22 12:39:17 -04:00
Fernando Sahmkow a1bf353780 Kernel: Correct pending feedback. 2020-02-22 11:51:03 -04:00
Fernando Sahmkow b9472eae44 System: Expose Host thread registering routines from kernel. 2020-02-22 11:18:07 -04:00
Fernando Sahmkow d219a96cc8 Kernel: Address Feedback. 2020-02-22 11:18:07 -04:00
Fernando Sahmkow ea956c823e Kernel: Implement Scheduler locks 2020-02-22 11:18:07 -04:00
Fernando Sahmkow 5c90d22f3d Kernel: Implement Time Manager. 2020-02-22 11:18:07 -04:00
Fernando Sahmkow 179bafa7cb Kernel: Rename ThreadCallbackHandleTable and Setup Thread Ids on Kernel. 2020-02-22 11:18:06 -04:00
Fernando Sahmkow 0728dfef84 Kernel: Make global scheduler depend on KernelCore 2020-02-22 11:18:06 -04:00
bunnei f5cf67140b audio_core: interpolate: Fix include for climits (Linux build break). 2020-02-22 02:29:41 -05:00
bunnei 19bce3685a
Merge pull request #3310 from FearlessTobi/fast-resample 
audio_core: Switch to a faster interpolation technique
 2020-02-22 01:54:40 -05:00
ReinUsesLisp 7dc488a375 shader/texture: Fix illegal 3D texture assert 
Fix typo in the illegal 3D texture assert logic. We care about catching
arrayed 3D textures or 3D shadow textures, not regular 3D textures.
 2020-02-21 15:57:27 -03:00
Rodrigo Locatti 4a6a1aeab4
Merge pull request #3433 from namkazt/patch-1 
renderer_vulkan: Add the rest of case for TryConvertBorderColor
 2020-02-21 15:56:09 -03:00
Rodrigo Locatti ef27b4b7b5
Merge pull request #3434 from namkazt/patch-2 
vk_shader: Implement ImageLoad
 2020-02-21 15:55:05 -03:00
Rodrigo Locatti 6b2719c0bb
Merge pull request #3435 from namkazt/patch-3 
vulkan: add DXT23_SRGB
 2020-02-21 15:48:19 -03:00
bunnei dc7ebc2d01
Merge pull request #3423 from ReinUsesLisp/no-match-3d 
texture_cache: Avoid matches in 3D textures
 2020-02-21 12:16:51 -05:00
Nguyen Dac Nam 10d8afb302
nit: add const to where it need. 2020-02-21 21:16:45 +07:00
Nguyen Dac Nam 1956a34ee5
shader: implement LOP3 fast replace for old function 
ref: https://devtalk.nvidia.com/default/topic/1070081/cuda-programming-and-performance/reverse-lut-for-lop3-lut/
 2020-02-21 19:08:07 +07:00
Nguyen Dac Nam c0c4da27d9
vk_device: remove left over from other branch 2020-02-21 08:56:18 +07:00
bunnei fe8e5d8ae4
Merge pull request #3438 from bunnei/gpu-mem-manager-fix 
video_core: memory_manager: Flush/invalidate asynchronously when possible.
 2020-02-20 20:04:05 -05:00
Nguyen Dac Nam ecf275887b
clang-format 2020-02-20 09:39:30 +07:00
Nguyen Dac Nam fbbad95845
shader_decompiler: only add StorageImageReadWithoutFormat when available 2020-02-20 09:28:13 +07:00
bunnei 2342c0d50e
Merge pull request #3432 from brianclinkenbeard/update-httplib 
Update httplib to 0.5.5
 2020-02-19 21:15:06 -05:00
bunnei bf0c929d4c
Merge pull request #3415 from ReinUsesLisp/texture-code 
shader/texture: Allow 2D shadow arrays and simplify code
 2020-02-19 20:06:14 -05:00
bunnei d65fa7d65c video_core: memory_manager: Flush/invalidate asynchronously on Unmap. 
- Minor perf improvement.
 2020-02-19 20:03:52 -05:00
bunnei b2bc7682b4
Merge pull request #3414 from ReinUsesLisp/maxwell-3d-draw 
maxwell_3d: Unify draw methods
 2020-02-19 16:13:50 -05:00
bunnei c8261a1a57
Merge pull request #3411 from ReinUsesLisp/specific-funcs 
gl_rasterizer: Use the least generic OpenGL draw function possible
 2020-02-19 15:37:41 -05:00
Nguyen Dac Nam 88cb05e6e7
shader_decompiler: add check in case of device not support ShaderStorageImageReadWithoutFormat 2020-02-19 12:57:22 +07:00
Nguyen Dac Nam e61c7e9310
vk_device: setup shaderStorageImageReadWithoutFormat 2020-02-19 12:56:36 +07:00
Nguyen Dac Nam 47106ab152
vk_device: add check for shaderStorageImageReadWithoutFormat 2020-02-19 12:55:56 +07:00
Nguyen Dac Nam 1b6308727c
shader_conversion: I2F : add Assert for case src_size is Short 2020-02-19 11:40:35 +07:00
Nguyen Dac Nam a2c2c5768f
fix warning 2020-02-19 11:10:26 +07:00
Nguyen Dac Nam a8508f2bc0
clang-format fix 2020-02-19 11:02:59 +07:00
Nguyen Dac Nam 556f3a6e9a
shader_conversion: add conversion I2F for Short 2020-02-19 10:54:37 +07:00
bunnei e545c2322c
Merge pull request #3410 from ReinUsesLisp/vk-draw-index 
vk_shader_decompiler: Fix vertex id and instance id
 2020-02-18 22:37:33 -05:00
Nguyen Dac Nam 2ef8af93aa
vk_shader: add Capability StorageImageReadWithoutFormat 2020-02-19 10:16:51 +07:00
Brian Clinkenbeard ad4e5c15fb httplib compatibility 2020-02-18 18:04:33 -08:00
Nguyen Dac Nam f6f0762e81 vk_shader: Implement function ImageLoad (Used by Kirby Start Allies) 
Please enter the commit message for your changes. Lines starting
 2020-02-19 08:39:01 +07:00
Nguyen Dac Nam ec206f7f95
fixups mistake auto commit. 2020-02-19 01:24:32 +07:00
Nguyen Dac Nam eaf60ca5d8
Update code structure 
Co-Authored-By: Mat M. <mathew1800@gmail.com>
 2020-02-19 01:23:08 +07:00
Fernando Sahmkow 93acfbd3a5
Merge pull request #3409 from ReinUsesLisp/host-queries 
query_cache: Implement a query cache and query 21 (samples passed)
 2020-02-18 11:31:06 -04:00
Nguyen Dac Nam 9295966d26
add vertex UnsignedInt size RGBA 2020-02-18 21:52:51 +07:00
Nguyen Dac Nam 9fc42fffd9
add eBc2SrgbBlock to formats 2020-02-18 21:44:09 +07:00
Nguyen Dac Nam 493f0ad904
vulkan: add DXT23_SRGB 2020-02-18 21:39:50 +07:00
Nguyen Dac Nam ba84f0988f
renderer_vulkan: Add the rest of case for TryConvertBorderColor 2020-02-18 16:52:54 +07:00
CJBok 23c4cc80e2 analog_from_button get direction implementation 2020-02-18 06:45:37 +01:00
bunnei 72d4c6fee0
Merge pull request #3412 from Morph1984/aspect-ratio 
GUI: Add aspect ratio dropdown
 2020-02-17 22:02:18 -05:00
bunnei 26006cbd2c
Merge pull request #3420 from namkazt/master2 
nvhost_gpu: implement ChannelSetTimeslice
 2020-02-17 00:31:11 -05:00
ReinUsesLisp 6a0220b2e1 texture_cache: Implement layered framebuffer attachments 
Layered framebuffer attachments is a feature that allows applications to
write attach layered textures to a single attachment. What layer the
fragments are written to is decided from the shader using gl_Layer.
 2020-02-16 04:19:32 -03:00
ReinUsesLisp 1caf3f11c8 vk_shader_decompiler: Implement Layer output attribute 
SPIR-V's Layer is GLSL's gl_Layer. It lets the application choose from a
shader stage (vertex, tessellation or geometry) which framebuffer layer
write the output fragments to.
 2020-02-16 04:17:37 -03:00
ReinUsesLisp bfda5ff3f6 texture_cache: Avoid matches in 3D textures 
Code before this commit was trying to match 3D textures with another
target. Fix that.
 2020-02-16 04:15:42 -03:00
ReinUsesLisp fd62bdf377 surface_base: Implement texture buffer flushes 
Implement downloads to guest memory from texture buffers on the generic
cache and OpenGL.
 2020-02-16 04:13:27 -03:00
Nguyen Dac Nam 5257a83ebe
IUserLocalCommunicationService: add function Initialize2 2020-02-16 13:24:34 +07:00
Nguyen Dac Nam 6c0eb6026b
HLE: correct function name of IUserLocalCommunicationService 
402: function name should be Initialize2 (7.0.0+) not SetOperationMode
Follow by: https://switchbrew.org/wiki/LDN_services#IUserLocalCommunicationService
 2020-02-16 13:14:06 +07:00
namkazy 7fadc9c180 nvhost_gpu: implement ChannelSetTimeslice 2020-02-16 11:53:03 +07:00
bunnei 0f70f68fb3
Revert "video_core: memory_manager: Use GPU interface for cache functions." 2020-02-15 17:47:15 -05:00
ReinUsesLisp 14c2a4a2ec texture: Implement R32I 2020-02-15 16:26:50 -03:00
ReinUsesLisp 6910ade146 shader/texture: Allow 2D shadow arrays and simplify code 
Shadow sampler 2D arrays are supported on OpenGL, so there's no reason
to forbid these. Enable textureLod usage on these.

Minor style changes.
 2020-02-15 02:36:28 -03:00
ReinUsesLisp 91aa58e410 maxwell_3d: Unify draw methods 
Pass instanced state of a draw invocation as an argument instead of
having two separate virtual methods.
 2020-02-14 18:09:40 -03:00
ReinUsesLisp 6d3a046caa query_cache: Address feedback 2020-02-14 17:38:27 -03:00
ReinUsesLisp 54a00ee4cf query_cache: Fix ambiguity in CacheAddr getter 2020-02-14 17:38:27 -03:00
ReinUsesLisp cc0694559f query_cache: Add a recursive mutex for concurrent usage 2020-02-14 17:38:27 -03:00
ReinUsesLisp bcd348f238 vk_query_cache: Implement generic query cache on Vulkan 2020-02-14 17:38:27 -03:00
ReinUsesLisp c31382ced5 query_cache: Abstract OpenGL implementation 
Abstract the current OpenGL implementation into the VideoCommon
namespace and reimplement it on top of that. Doing this avoids repeating
code and logic in the Vulkan implementation.
 2020-02-14 17:38:27 -03:00
ReinUsesLisp 73d2d3342d gl_query_cache: Optimize query cache 
Use a custom cache instead of relying on a ranged cache.
 2020-02-14 17:38:27 -03:00
ReinUsesLisp aae8c180cb gl_query_cache: Implement host queries using a deferred cache 
Instead of waiting immediately for executed commands, defer the query
until the guest CPU reads it. This way we get closer to what the guest
program is doing.

To archive this we have to build a dependency queue, because host APIs
(like OpenGL and Vulkan) use ranged queries instead of counters like
NVN.

Waiting for queries implicitly uses fences and this requires a command
being queued, otherwise the driver will lock waiting until a timeout. To
fix this when there are no commands queued, we explicitly call glFlush.
 2020-02-14 17:33:13 -03:00
ReinUsesLisp ef9920e164 gl_rasterizer: Sort method declarations 2020-02-14 17:27:17 -03:00
ReinUsesLisp fe1238be7a gl_rasterizer: Add queued commands counter 
Keep track of the queued OpenGL commands that can signal a fence if
waited on. As a side effect, we avoid calls to glFlush when no commands
are queued.
 2020-02-14 17:27:17 -03:00
ReinUsesLisp 2b58652f08 maxwell_3d: Slow implementation of passed samples (query 21) 
Implements GL_SAMPLES_PASSED by waiting immediately for queries.
 2020-02-14 17:27:17 -03:00
bunnei f552d553ba
Merge pull request #3401 from FernandoS27/synchronization 
Set of refactors for Kernel Synchronization and Hardware Constants
 2020-02-14 14:40:20 -05:00
Morph c3d0a0d627 Add 4:3 aspect ratio and address feedback 2020-02-14 14:39:04 -05:00
bunnei 63a59b9935
Merge pull request #3379 from ReinUsesLisp/cbuf-offset 
shader/decode: Fix constant buffer offsets
 2020-02-14 13:22:53 -05:00
Fernando Sahmkow 829d8c0d6b Core: Correct compilition in GCC 2020-02-14 05:53:30 -04:00
Morph 20dc2e3622 Address feedback 2020-02-14 00:06:26 -05:00
Morph 22f58cca5e Use enumeration instead of magic numbers 2020-02-13 23:13:23 -05:00
Morph 27e19f87c6 Add following aspect ratios: 16:9, 21:9, Stretch to Window 
Available as a drop down within the configure graphics tab.
 2020-02-13 22:17:28 -05:00
bunnei 74feed372c
Merge pull request #3400 from makigumo/patch-1 
update hwopus DecodeInterleaved for FW 7.0.0+
 2020-02-13 21:26:13 -05:00
ReinUsesLisp 3217400dd1 gl_resource_manager: Add managed query class 2020-02-13 22:25:55 -03:00
bunnei 3563af2364
Merge pull request #3395 from FernandoS27/queries 
GPU: Refactor queries implementation and correct GPU Clock.
 2020-02-13 20:18:26 -05:00
ReinUsesLisp 336a4f8e99 gl_rasterizer: Use the least generic OpenGL draw function possible 
This may help some implementations.
 2020-02-13 21:55:21 -03:00
ReinUsesLisp cbea8c74de vk_shader_decompiler: Fix vertex id and instance id 
Vulkan's VertexIndex and InstanceIndex don't match with hardware. This
is because Nvidia implements gl_VertexID and gl_InstanceID. The math
that relates these is:

gl_VertexIndex = gl_BaseVertex + gl_VertexID
gl_InstanceIndex = gl_InstanceIndex + gl_InstanceID

To emulate it using what Vulkan's SPIR-V offers (the *Index variants)
this commit substracts gl_Base* from gl_*Index to obtain the OpenGL and
hardware's equivalent.
 2020-02-13 20:25:28 -03:00
Fernando Sahmkow 2bc949628d Core: Address Feedback 2020-02-13 19:10:33 -04:00
Fernando Sahmkow d6ed31b9fa GPU: Address Feedback. 2020-02-13 18:16:07 -04:00
Lioncash be269e21a5 address_arbiter: Collapse loops in InsertThread() and RemoveThread() 
Same behavior, but without the need to explicitly loop through
everything manually.
 2020-02-12 15:34:07 -05:00
Lioncash 9f2c703137 address_arbiter: Simplify GetThreadsWaitingOnAddress() 
Simplifies the overall function and also allows for it to become a
const-qualified member function.
 2020-02-12 15:10:16 -05:00
bunnei 8f8dda2d5b
Merge pull request #3403 from lioncash/debug 
bcat/backend: Prevent fmt exception in debug log within NullBackend::Clear()
 2020-02-12 11:17:43 -05:00
Lioncash f00a54f508 bcat/backend: Make formatting of passphrase consistent in NullBackend::SetPassphrase() 
Aligns the '=' to be consistent with the rest of the logs within this
source file.
 2020-02-12 01:18:29 -05:00
Lioncash eefd97e80d bcat/backend: Prevent fmt exception in debug log within NullBackend::Clear() 
A formatting specifier within Clear wasn't being used, which will cause
fmt to throw an exception. This fixes that.
 2020-02-12 01:14:47 -05:00
Lioncash b80c348b09 kernel/thread: Remove trivial usages of the global system accessor 
We can just use the kernel member variable directly instead of going
through the system to obtain the same thing.
 2020-02-12 01:00:41 -05:00
Fernando Sahmkow 1e6f8aba04 Core: Set all hardware emulation constants in a single file. 2020-02-11 20:19:11 -04:00
Fernando Sahmkow d23d504d77 Kernel: Refactor synchronization to better match RE 2020-02-11 18:47:31 -04:00
makigumo 926ea5a16d
update hwopus DecodeInterleaved for FW 7.0.0+ 
trivial change,
see https://switchbrew.org/wiki/Audio_services#IHardwareOpusDecoder
 2020-02-11 18:41:04 +01:00
Fernando Sahmkow c5aefe42aa Kernel: Change WaitObject to Synchronization object. In order to better reflect RE. 2020-02-11 10:46:25 -04:00
bunnei 37f1cf8cbd
Merge pull request #3376 from ReinUsesLisp/point-sprite 
gl_rasterizer: Implement GL_POINT_SPRITE
 2020-02-11 08:26:07 -05:00
Fernando Sahmkow 8e9a4944db GPU: Implement GPU Clock correctly. 2020-02-10 10:44:54 -04:00
Fernando Sahmkow 0cb3bcfbb7 Maxwell3D: Correct query reporting. 2020-02-10 10:41:43 -04:00
bunnei 84ea9c2b42 Merge pull request #3372 from ReinUsesLisp/fix-back-stencil 
maxwell_3d: Fix stencil back mask
 2020-02-09 22:29:28 -05:00
Zach Hilman 21c3f48279
Merge pull request #3391 from Morph1984/remove-unknown 
Remove option "Show files with type 'Unknown'"
 2020-02-09 12:08:01 -05:00
Morph fcf3425b1b Remove option "Show files with type 'Unknown'" 2020-02-09 11:30:02 -05:00
bunnei a952fbc5b3
Merge pull request #3388 from bunnei/service-shared-ptr 
hle: services: Use std::shared_ptr instead of copy by value.
- This is a prerequisite to adding a mutex to `ServiceFramework`, which cannot be copied.
- This will be used for threaded services.
 2020-02-08 21:35:30 -05:00
bunnei e210835dd0
Merge pull request #3387 from bunnei/gpu-mpscqueue 
gpu_thread: Use MPSCQueue for GPU commands.
 2020-02-08 21:15:48 -05:00
bunnei 7b07e521ca hle: services: Use std::shared_ptr instead of copy by value. 2020-02-07 23:02:26 -05:00
bunnei b5c13ee0eb gpu_thread: Use MPSCQueue for GPU commands. 
- Necessary for multiple service threads.
 2020-02-07 23:01:23 -05:00
bunnei 7cacb08cdf video_core: memory_manager: Use GPU interface for cache functions. 2020-02-07 22:59:35 -05:00
bunnei 90bda66028
Merge pull request #3378 from ReinUsesLisp/uscaled 
maxwell_to_gl: Implement R8G8_USCALED
 2020-02-07 22:55:52 -05:00
bunnei 90df4b8e2b
Merge pull request #3369 from ReinUsesLisp/shf 
shader/shift: Implement SHF
 2020-02-07 22:06:57 -05:00
bunnei aa3f9b9606
Merge pull request #3381 from bunnei/ipc-fix 
hle: services: Fix prepo IPC, and add better error checking.
 2020-02-07 16:25:42 -05:00
bunnei 09d766d357
Merge pull request #3362 from ReinUsesLisp/fix-instanced 
gl_rasterizer: Fix instanced draw arrays
 2020-02-06 21:39:59 -05:00
bunnei ba53543da6 kernel: transfer_memory: Properly reserve and reset memory region. 2020-02-05 23:06:54 -05:00
Zach Hilman 7a547b9342 wait_object: Make wait behavior only require one object to signal. 
- This was holdover from citra.
 2020-02-05 23:06:53 -05:00
bunnei 3a0c1e79f8 am: Correct IPC object count mismatch. 2020-02-05 23:06:53 -05:00
bunnei 77da74e17a services: am: Clear events on PopOutData and PopInteractiveOutData. 2020-02-05 23:06:52 -05:00
bunnei 84e895cdd6 am: Refactor IStorage interface. 2020-02-05 23:06:52 -05:00
bunnei 3557fa25d0 applets: software_keyboard: Signal state change on end of interactive session. 2020-02-05 23:06:51 -05:00
bunnei be5fcffb89 applets: software_keyboard: Minor cleanup. 2020-02-05 23:06:50 -05:00
bunnei 2245c24e21 services: prepo: Fix IPC interface with SaveReport/SaveReportWithUser. 2020-02-05 22:52:35 -05:00
bunnei 9751ccc5e0 hle_ipc: Add error checking to read/write buffer access. 2020-02-05 22:52:35 -05:00
ReinUsesLisp bf9a822b87 shader/decode: Fix constant buffer offsets 
Some instances were using cbuf34.offset instead of cbuf34.GetOffset().
This returned the an invalid offset. Address those instances and rename
offset to "shifted_offset" to avoid future bugs.
 2020-02-05 12:19:09 -03:00
ReinUsesLisp 8bb9eef97b maxwell_to_gl: Implement R8G8_USCALED 2020-02-04 21:32:36 -03:00
ReinUsesLisp c81c361e82 maxwell_to_gl: Reduce unimplemented formats to LOG_ERROR 2020-02-04 21:32:08 -03:00
ReinUsesLisp 0eb36c90f4 vk_rasterizer: Use noexcept variants of std::bitset 
Removes bounds checking from "texceptions" instances.
 2020-02-04 18:04:24 -03:00
bunnei 08c508b1c4
Merge pull request #3357 from ReinUsesLisp/bfi-rc 
shader/bfi: Implement register-constant buffer variant
 2020-02-04 15:14:13 -05:00
ReinUsesLisp 7da52673d0 gl_rasterizer: Implement GL_POINT_SPRITE 
OpenGL core defaults to GL_POINT_SPRITE, meanwhile on OpenGL
compatibility we have to explicitly enable it. This fixes
gl_PointCoord's behaviour.
 2020-02-04 15:19:45 -03:00
bunnei bf21aacc74
Merge pull request #3356 from ReinUsesLisp/fcmp 
shader/arithmetic: Implement FCMP
 2020-02-04 11:36:59 -05:00
bunnei 5733287822
Merge pull request #3360 from CJBok/statusbar-buttons 
GUI: Togglable graphics settings buttons in status bar
 2020-02-03 16:57:18 -05:00
bunnei c31ec00d67
Merge pull request #3337 from ReinUsesLisp/vulkan-staged 
yuzu: Implement Vulkan frontend
 2020-02-03 16:56:25 -05:00
Lioncash c7678c3044 input_common/udp: Ensure that UDP is shut down within Shutdown() 
Previously the UDP backend would never actually get shut down.
 2020-02-03 09:29:15 -05:00
Lioncash 83f8090273 input_common/udp: Add missing override specifiers 
Prevents trivial warnings and ensures interfaces are properly
maintained between the base class.
 2020-02-03 09:26:53 -05:00
Lioncash 5c61e0ba39 input_common/udp: std::move SocketCallback instances where applicable 
std::function is allowed to heap allocate if the size of the captures
associated with each lambda exceed a certain threshold. This prevents
potentially unnecessary reallocations from occurring.
 2020-02-03 09:24:05 -05:00
Lioncash fb9c9ddcc9 input_common/udp: std::move shared_ptr within Client constructor 
Gets rid of a trivially avoidable atomic reference count increment and
decrement.
 2020-02-03 09:21:46 -05:00
Lioncash 9bb6ab77f4 udp/client: Replace deprecated from_string() call with make_address_v4() 
Future-proofs code if boost is ever updated.
 2020-02-03 09:20:40 -05:00
Lioncash 881408445a input_common/udp: Silence -Wreorder warning for Socket 
Amends the constructor initializer list to specify the order of its
elements in the same order that initialization would occur.
 2020-02-03 09:15:32 -05:00
Lioncash 36524465a6 input_common/udp: Remove unnecessary inclusions 2020-02-03 09:13:40 -05:00
Lioncash 4aa9c9632d input_common/udp: Add missing header guard 2020-02-03 09:09:06 -05:00
ReinUsesLisp 4eed744277 maxwell_3d: Fix stencil back mask 2020-02-02 17:50:46 -03:00
ReinUsesLisp 223a89a19f shader: Remove curly braces initializers on shared pointers 2020-02-01 22:52:10 -03:00
bunnei b5bbe7e752
Merge pull request #3282 from FernandoS27/indexed-samplers 
Partially implement Indexed samplers in general and specific code in GLSL
 2020-02-01 20:41:40 -05:00
ReinUsesLisp 729ca120e3 shader/shift: Implement SHIFT_RIGHT_{IMM,R} 
Shifts a pair of registers to the right and returns the low register.
 2020-02-01 21:20:02 -03:00
ReinUsesLisp 017474c3f8 shader/shift: Implement SHF_LEFT_{IMM,R} 
Shifts a pair of registers to the left and returns the high register.
 2020-02-01 21:19:44 -03:00
bunnei 2916c1bc25
Merge pull request #3268 from CJBok/deadzone 
GUI: Deadzone controls for sdl engine at configuration input
 2020-02-01 16:35:15 -05:00
bunnei 69a6796de1
Merge pull request #3284 from CJBok/hid-fix 
hid: Fix analog sticks directional states
 2020-02-01 14:02:41 -05:00
bunnei c18f9898d9
Merge pull request #3364 from lioncash/thread 
core/arm: Remove usage of global GetCurrentThread()
 2020-01-31 11:13:24 -05:00
bunnei 6b5b01b29f
Merge pull request #3363 from lioncash/unique_ptr 
kernel/physical_core: Make use of std::unique_ptr instead of std::shared_ptr
 2020-01-30 23:33:02 -05:00
bunnei 91b0a3f799
Revert "system_archive: Fix Korean and Chinese fonts" 2020-01-30 22:02:15 -05:00
Lioncash 472319e573 core/arm: Remove usage of global GetCurrentThread() 
Now both CPU backends go through their referenced system instance to
obtain the current thread.
 2020-01-30 18:52:25 -05:00
Lioncash 2de2bb980e kernel/physical_core: Make use of std::unique_ptr 
shared_ptr was used in 2d1984c20c due to a
misunderstanding of how the language generates move constructors and
move assignment operators.

If a destructor is user-provided, then the compiler won't generate the
move constructor and move assignment operators by default--they must be
explicitly opted into.

The reason for the compilation errors is due to the fact that the
language will fall back to attempting to use the copy constructor/copy
assignment operators if the respective move constructor or move
assignment operator is unavailable.

Given that we explicitly opt into them now, the the move constructor and
move assignment operators will be generated as expected.
 2020-01-30 18:42:40 -05:00
Lioncash 16e7b7b83d core/cpu_manager: Remove unused includes 
Nothing from these headers are used within this source file, so we can
remove them.
 2020-01-30 18:30:57 -05:00
Lioncash 51927bc9dc kernel/physical_core: Remove unused kernel reference member variable 
This isn't used within the class, so it can be removed to simplify the
overall interface.

While we're in the same area, we can simplify a unique_ptr reset() call.
 2020-01-30 18:29:57 -05:00
bunnei 985d0f35e5
Merge pull request #3353 from FernandoS27/aries 
System: Refactor CPU Core management and move ARMInterface and Schedulers to Kernel
 2020-01-30 18:13:59 -05:00
bunnei 8a7cdfc3ff
Merge pull request #3151 from FearlessTobi/fix-korean 
system_archive: Fix Korean and Chinese fonts
 2020-01-30 15:09:55 -05:00
bunnei c593e45dbd
Merge pull request #3347 from ReinUsesLisp/local-mem 
shader/memory: Implement LDL.S16, LDS.S16, STL.S16 and STS.S16
 2020-01-30 10:59:52 -05:00
ReinUsesLisp b69321650e gl_rasterizer: Fix instanced draw arrays 
glDrawArrays was being used when the draw had a base instance specified.
This commit removes the draw parameters abstraction and fixes the
mentioned issue.
 2020-01-30 02:22:00 -03:00
ReinUsesLisp a7beabb68f yuzu/bootmanager: Define Vulkan widget only when enabled 2020-01-29 19:20:12 -03:00
bunnei 2db7adc42a
Merge pull request #3350 from ReinUsesLisp/atom 
shader/memory: Implement ATOM.ADD
 2020-01-29 16:49:54 -05:00
ReinUsesLisp c29584a090 yuzu_cmd: Fix memcpy on Vulkan handlers 2020-01-29 17:53:11 -03:00
ReinUsesLisp f92cbc5501 yuzu: Implement Vulkan frontend 
Adds a Qt and SDL2 frontend for Vulkan. It also finishes the missing
bits on Vulkan initialization.
 2020-01-29 17:53:11 -03:00
ReinUsesLisp 8299f1ceef web_service/telemetry_json: Report USER_CONFIG 2020-01-29 17:53:11 -03:00
ReinUsesLisp 788d57d723 settings: Add settings for graphics backend 2020-01-29 17:53:11 -03:00
ReinUsesLisp e651e54b85 core: Only wait for idle on gpu_core when it was initialized 
This fixes crashes when a Vulkan device fails to initialize.
 2020-01-29 17:53:11 -03:00
ReinUsesLisp 9f0162e4b5 shader/other: Fix skips for SYNC and BRK 2020-01-29 17:53:11 -03:00
ReinUsesLisp 270177f38a shader/other: Stub S2R LaneId 2020-01-29 17:53:11 -03:00
ReinUsesLisp b35449c85d buffer_cache: Delay buffer destructions 
Delay buffer destruction some extra frames to avoid destroying buffers
that are still being used from older frames. This happens on Nvidia's
driver with mailbox.
 2020-01-29 17:53:11 -03:00
bunnei b11aeced18
Merge pull request #3355 from ReinUsesLisp/break-down 
texture_cache/surface_base: Fix layered break down
 2020-01-29 12:29:56 -05:00
bunnei 91f79225e7
Merge pull request #3358 from ReinUsesLisp/implicit-texture-cache 
gl_texture_cache: Silence implicit sign cast warnings
 2020-01-29 11:23:50 -05:00
CJBok 8d6b4e836c clang 2020-01-29 05:43:55 +01:00
CJBok 6e87111f91 minor corrections 2020-01-29 00:02:28 +01:00
CJBok 4bc4fdf5ff GUI: Togglable graphics settings buttons in status bar 2020-01-28 23:59:30 +01:00
bunnei c457e47297
Merge pull request #3359 from ReinUsesLisp/assert-point-size 
gl_shader_decompiler: Remove UNIMPLEMENTED for gl_PointSize
 2020-01-28 15:19:51 -05:00
ReinUsesLisp 8178fe8960 gl_shader_decompiler: Remove UNIMPLEMENTED for gl_PointSize 
This was implemented by a previous commit and it's no longer required.
 2020-01-28 16:32:30 -03:00
bunnei bea6327d74
Merge pull request #3354 from ReinUsesLisp/depth-stencil 
gl_texture_cache: Properly implement depth/stencil sampling
 2020-01-28 12:06:11 -05:00
ReinUsesLisp abae795986 gl_texture_cache: Silence implicit sign cast warnings 2020-01-27 20:59:11 -03:00
Fernando Sahmkow 2d1984c20c System: Address Feedback 2020-01-27 09:54:11 -04:00
ReinUsesLisp 137a8aa55c shader/bfi: Implement register-constant buffer variant 
It's the same as the variant that was implemented, but it takes the
operands from another source.
 2020-01-27 01:20:38 -03:00
ReinUsesLisp e3fc3459c8 shader/arithmetic: Implement FCMP 
Compares the third operand with zero, then selects between the first and
second.
 2020-01-27 01:15:44 -03:00
ReinUsesLisp f55f6ff9bb texture_cache/surface_base: Fix layered break down 
Layered break downs was passing "layer" as a "depth" parameter. This
commit addresses that.
 2020-01-26 21:48:07 -03:00
ReinUsesLisp d17dfa6104 gl_texture_cache: Properly implement depth/stencil sampling 
This addresses the long standing issue of compatibility vs. core
profiles on OpenGL, properly implementing depth vs. stencil sampling
depending on the texture swizzle.
 2020-01-26 21:44:08 -03:00
Fernando Sahmkow de4b01f75d System: Correct PrepareReschedule. 2020-01-26 14:32:50 -04:00
Fernando Sahmkow a1630ab53e Kernel: Remove a few global instances from the kernel. 2020-01-26 14:23:46 -04:00
Fernando Sahmkow e4a1ead897 Core: Refactor CpuCoreManager to CpuManager and Cpu to Core Manager. 
This commit instends on better naming the new purpose of this classes.
 2020-01-26 14:07:22 -04:00
Fernando Sahmkow 450341b397 ArmInterface: Delegate Exclusive monitor factory to exclusive monitor interfasce. 2020-01-26 10:28:23 -04:00
ReinUsesLisp d95d4ac843 shader/memory: Implement ATOM.ADD 
ATOM operates atomically on global memory. For now only add ATOM.ADD
since that's what was found in commercial games.

This asserts for ATOM.ADD.S32 (handling the others as unimplemented),
although ATOM.ADD.U32 shouldn't be any different.

This change forces us to change the default type on SPIR-V storage
buffers from float to uint. We could also alias the buffers, but it's
simpler for now to just use uint. While we are at it, abstract the code
to avoid repetition.
 2020-01-26 01:54:24 -03:00
Fernando Sahmkow 4d6a86b03f Core: Refactor CPU Management. 
This commit moves ARM Interface and Scheduler handling into the kernel.
 2020-01-25 18:55:32 -04:00
Fernando Sahmkow bb8eb15d39 Shader_IR: Address feedback. 2020-01-25 09:04:59 -04:00
ReinUsesLisp d26e74f0a3 shader/memory: Implement STL.S16 and STS.S16 2020-01-25 03:16:10 -03:00
ReinUsesLisp 9a2cdf8520 shader/memory: Implement unaligned LDL.S16 and LDS.S16 2020-01-25 03:16:10 -03:00
ReinUsesLisp 531f25a037 shader/memory: Move unaligned load/store to functions 2020-01-25 03:16:10 -03:00
ReinUsesLisp 96638f57c9 shader/memory: Implement LDL.S16 and LDS.S16 2020-01-25 03:15:55 -03:00
bunnei 2a822f3378 bsd: Stub several more functions. 
- Required for Little Town Hero to boot further.
 2020-01-25 00:47:15 -05:00
bunnei 05df4a8c94
Merge pull request #3343 from FearlessTobi/ui-tab 
yuzu/configuration: create UI tab and move gamelist settings there
 2020-01-25 00:40:13 -05:00
bunnei 2b1d66eda3
Merge pull request #3326 from FearlessTobi/port-5039 
Port citra-emu/citra#5039: "common/logging: don't use regex for path trimming"
 2020-01-24 20:59:57 -05:00
FearlessTobi 845a5dbca9 Disable clang-format for font files 2020-01-24 23:54:19 +01:00
bunnei dfd998216c
Merge pull request #3344 from ReinUsesLisp/vk-botw 
vk_shader_decompiler: Disable default values on unwritten render targets
 2020-01-24 17:31:55 -05:00
Fernando Sahmkow 806f569143 Shader_IR: Change name of TrackSampler function so it does not confuse with the type. 2020-01-24 16:44:48 -04:00
Fernando Sahmkow 3919b7b8a9 Shader_IR: Corrections, styling and extras. 2020-01-24 16:44:48 -04:00
Fernando Sahmkow 37b8504faa Shader_IR: Correct Custom Variable assignment. 2020-01-24 16:44:47 -04:00
Fernando Sahmkow 7c530e0666 Shader_IR: Propagate bindless index into the GL compiler. 2020-01-24 16:44:47 -04:00
Fernando Sahmkow 3c34678627 Shader_IR: Implement Injectable Custom Variables to the IR. 2020-01-24 16:43:31 -04:00
Fernando Sahmkow 2b02f29a2d GL Backend: Introduce indexed samplers into the GL backend 2020-01-24 16:43:31 -04:00
Fernando Sahmkow 037ea431ce Shader_IR: deduce size of indexed samplers 2020-01-24 16:43:31 -04:00
Fernando Sahmkow f4603d23c5 Shader_IR: Setup Indexed Samplers on the IR 2020-01-24 16:43:30 -04:00
Fernando Sahmkow 603c861532 Shader_IR: Implement initial code for tracking indexed samplers. 2020-01-24 16:43:30 -04:00
Fernando Sahmkow 64496f2456 Shader_IR: Address Feedback 2020-01-24 16:43:30 -04:00
Fernando Sahmkow b97608ca64 Shader_IR: Allow constant access of guest driver. 2020-01-24 16:43:30 -04:00
Fernando Sahmkow dc5cfa8d28 Shader_IR: Address Feedback 2020-01-24 16:43:29 -04:00
Fernando Sahmkow 74aa7de5e3 Guest_driver: Correct compiling errors in GCC. 2020-01-24 16:43:29 -04:00
Fernando Sahmkow 1e4b6bef6f Shader_IR: Store Bound buffer on Shader Usage 2020-01-24 16:43:29 -04:00
Fernando Sahmkow c921e496eb GPU: Implement guest driver profile and deduce texture handler sizes. 2020-01-24 16:43:29 -04:00
Fernando Sahmkow ab89ced244 Kernel: Implement Physical Core. 2020-01-24 15:38:20 -04:00
bunnei a104b985a8
Merge pull request #3273 from FernandoS27/txd-array 
Shader_IR: Implement TXD Array.
 2020-01-24 14:02:40 -05:00
bunnei f64adcfc37
Merge pull request #3340 from SciresM/pmdx 
loader: provide default arguments (zero byte) to NSOs
 2020-01-24 10:31:43 -05:00
ReinUsesLisp 1690f1adba vk_shader_decompiler: Disable default values on unwritten render targets 
Some games like The Legend of Zelda: Breath of the Wild assign
render targets without writing them from the fragment shader. This
generates Vulkan validation errors, so silence these I previously
introduced a commit to set "vec4(0, 0, 0, 1)" for these attachments. The
problem is that this is not what games expect. This commit reverts that
change.
 2020-01-24 01:16:21 -03:00
FearlessTobi e3cad7d49e audio_core: Switch to a faster interpolation technique 2020-01-24 00:38:22 +01:00
FearlessTobi d0e4f1c6f4 yuzu/configuration: create UI tab and move gamelist settings there 2020-01-24 00:15:51 +01:00
BreadFish64 a31ed02ae4 common/logging: don't use regex for path trimming 2020-01-23 23:08:05 +01:00
FearlessTobi d01eb12f36 Replace GetString with Get function 
This should hopefully fix compilation errors.
 2020-01-23 20:55:26 +01:00
FearlessTobi bbd85a495a Address second part of review comments 2020-01-23 20:55:26 +01:00
FearlessTobi 0fe11746fc Address review comments 2020-01-23 20:55:26 +01:00
fearlessTobi ac3690f205 Input: UDP Client to provide motion and touch controls 
An implementation of the cemuhook motion/touch protocol, this adds the
ability for users to connect several different devices to citra to send
direct motion and touch data to citra.

Co-Authored-By: jroweboy <jroweboy@gmail.com>
 2020-01-23 20:55:26 +01:00
bunnei a167da4278
Merge pull request #3341 from bunnei/time-posix-myrule 
service: time: Implement ToPosixTimeWithMyRule.
 2020-01-23 12:04:01 -05:00
Fernando Sahmkow 9c6b5cae68
Merge pull request #3338 from ReinUsesLisp/no-fastmath 
gl_shader_cache: Disable fastmath on Nvidia
 2020-01-23 10:08:45 -04:00
bunnei ed76c71319 service: time: Implement ToPosixTimeWithMyRule. 
- Used by Pokemon Mystery Dungeon.
 2020-01-22 23:20:19 -05:00
Michael Scire 5a7eecc3ad loader: provide default arguments (zero byte) to NSOs 
Certain newer unity games (Terraria, Pokemon Mystery Dungeon) require
that the argument region be populated. Failure to do so results in
an integer underflow in argument count, and eventually an unmapped
read at 0x800000000. Providing this default fixes this.

Note that the behavior of official software is as yet unverified,
arguments-wise.
 2020-01-22 20:14:06 -08:00
bunnei 89b326e396
Merge pull request #3324 from FearlessTobi/port-5037 
Port citra-emu/citra#5037: "CMake: Create thin archives on Linux"
 2020-01-22 19:48:15 -05:00
Bartosz Kaszubowski 9a22b6dced GUI: fix minor issues with dark themes 
GUI: rename and reorder themes
 2020-01-22 21:12:45 +01:00
ReinUsesLisp 3ce28342a2 gl_shader_cache: Disable fastmath on Nvidia 2020-01-21 19:08:08 -03:00
Fernando Sahmkow 79e0991d9b
Merge pull request #3330 from ReinUsesLisp/vk-blit-screen 
vk_blit_screen: Initial implementation
 2020-01-20 22:32:16 -04:00
ReinUsesLisp a665581684 vk_blit_screen: Address feedback 2020-01-20 18:43:11 -03:00
bunnei 7113236b30 time: Fix month off-by-one error. 
- Fixes timestamp in ZLA and Astral Chain saves.
 2020-01-20 14:20:32 -05:00
bunnei 4ea073c286
Merge pull request #3332 from bunnei/config-audio-tab 
yuzu_qt: config: Move audio to its own tab.
 2020-01-20 04:24:51 -05:00
bunnei 69b44392a7
Merge pull request #3328 from ReinUsesLisp/vulkan-atoms 
vk_shader_decompiler: Implement UAtomicAdd (ATOMS) on SPIR-V
 2020-01-20 00:01:52 -05:00
bunnei 5a077c95ce
Merge pull request #3322 from ReinUsesLisp/vk-front-face 
vk_graphics_pipeline: Set front facing properly
 2020-01-19 23:22:34 -05:00
bunnei 690732bc0d yuzu_qt: config: Move audio to its own tab. 
- We have some important audio settings, makes them more discoverable.
 2020-01-19 23:17:53 -05:00
bunnei 8b9f433d95
Merge pull request #3271 from bunnei/time-rewrite 
service: time: Rewrite implementation of glue services.
 2020-01-19 22:45:05 -05:00
ReinUsesLisp f5dfe68a94 vk_blit_screen: Initial implementation 
This abstraction takes care of presenting accelerated and
non-accelerated or "framebuffer" images to the Vulkan swapchain.
 2020-01-19 21:12:43 -03:00
bunnei 41373d212e
Merge pull request #3313 from ReinUsesLisp/vk-rasterizer 
vk_rasterizer: Implement Vulkan's rasterizer
 2020-01-19 18:09:01 -05:00
Bartosz Kaszubowski 9ac33c2620 GUI/gamelist: add "None" as an option for second row and remove dynamically duplicate row options (#3309) 
* GUI/gamelist: add "None" as an option for second row and remove duplicated row options

* fix clang-format warnings
 2020-01-19 15:56:49 -05:00
ReinUsesLisp b2c976ad0e vk_shader_decompiler: Implement UAtomicAdd (ATOMS) on SPIR-V 
Also updates sirit to include atomic instructions.
 2020-01-19 16:40:31 -03:00
FearlessTobi 4e9331f45d system_archive: Fix Chinese font 
Adds the proper OSS font for the Chinese language.
 2020-01-19 15:09:53 +01:00
FearlessTobi 999e3f89b9 system_archive: Fix Korean font 
Fixes Korean fonts when using Open-source system archives.
 2020-01-19 15:09:50 +01:00
Léo Lam f98cd210ab CMake: Create thin archives on Linux 
This significantly reduces unnecessary disk writes and space usage
when building Citra.

libcore.a is now only ~1MB rather than several hundred megabytes.
 2020-01-19 12:52:09 +01:00
Fernando Sahmkow 51c8aea979
Merge pull request #3317 from ReinUsesLisp/gl-decomp-cc-decomp 
gl_shader_decompiler: Fix decompilation of condition codes
 2020-01-18 19:56:55 -04:00
ReinUsesLisp d110a371bb gl_state: Use bool instead of GLboolean 
This fixes template resolution considering GLboolean an integer instead
of a bool.
 2020-01-18 19:10:34 -03:00
ReinUsesLisp 94915d4ea1 vk_graphics_pipeline: Set front facing properly 
Front face was being forced to a certain value when cull face is
disabled. Set a default value on initialization and drop the forcefully
set front facing value with culling disabled.
 2020-01-18 18:50:47 -03:00
bunnei e972016456
Merge pull request #3298 from Simek/missing_hotkeys 
GUI: add few missing hotkeys to main menu
 2020-01-18 13:07:13 -05:00
Markus Wick 56672b8c98 core/memory: Create a special MapMemoryRegion for physical memory. 
This allows us to create a fastmem arena within the memory.cpp helpers.
 2020-01-18 08:38:47 +01:00
Markus Wick 55103da066 core/hle: Simplify PhysicalMemory usage in vm_manager. 2020-01-18 08:29:19 +01:00
Markus Wick 7e94e544f4 core/loaders: Simplify PhysicalMemory usage. 
It is currently a std::vector, however we might want to replace it with a more fancy allocator.
So we can't use the C++ iterators any more.
 2020-01-18 08:29:19 +01:00
bunnei 9bf4850f74
Merge pull request #3305 from ReinUsesLisp/point-size-program 
gl_state: Implement PROGRAM_POINT_SIZE
 2020-01-18 01:56:32 -05:00
bunnei 15163edaaa
Merge pull request #3312 from ReinUsesLisp/atoms-u32 
shader/memory: Implement ATOMS.ADD.U32
 2020-01-18 00:54:07 -05:00
James Rowe 4512a6bbfc Remove unused CPU Vendor string and telemtry field 
The information is duplicated in the brand string and the telemetry field is unused
 2020-01-17 18:41:18 -07:00
ReinUsesLisp 09b1d762d7 vk_rasterizer: Address feedback 2020-01-17 21:40:01 -03:00
ReinUsesLisp f34e519da3 gl_shader_decompiler: Fix decompilation of condition codes 
Use Visit instead of reimplementing it. Fixes unimplemented negations
for condition codes.
 2020-01-17 21:23:01 -03:00
TotalCaesar659 dd74fd014b Add headbar icon on Linux 2020-01-18 02:46:07 +03:00
bunnei 48863afb65
Merge pull request #3306 from ReinUsesLisp/gl-texture 
gl_texture_cache: Minor fixes and style changes
 2020-01-17 15:44:02 -05:00
bunnei 657b3a366e
Merge pull request #3311 from ReinUsesLisp/z32fx24s8 
format_lookup_table: Fix ZF32_X24S8 component types
 2020-01-17 08:22:32 -05:00
ReinUsesLisp fe5356d223 vk_rasterizer: Implement Vulkan's rasterizer 
This abstraction is Vulkan's equivalent to OpenGL's rasterizer. It takes
care of joining all parts of the backend and rendering accordingly on
demand.
 2020-01-16 23:05:15 -03:00
ReinUsesLisp 38e789c761 renderer_vulkan: Add header as placeholder 2020-01-16 22:54:15 -03:00
bunnei e041f33569
Merge pull request #3300 from ReinUsesLisp/vk-texture-cache 
vk_texture_cache: Implement generic texture cache on Vulkan
 2020-01-16 19:19:26 -05:00
ReinUsesLisp f09cd52980 vk_texture_cache: Address feedback 2020-01-16 18:23:10 -03:00
ReinUsesLisp 63ba41a26d shader/memory: Implement ATOMS.ADD.U32 2020-01-16 17:30:55 -03:00
ReinUsesLisp 0caab54b5d format_lookup_table: Fix ZF32_X24S8 component types 
Component types for ZF32_X24S8 were using UNORM. Drivers will set FLOAT,
UINT, UNORM, UNORM; causing a format mismatch. This commit addresses
that.
 2020-01-16 17:29:13 -03:00
Rodrigo Locatti 82e1285c1e
vk_texture_cache: Fix typo in commentary 
Co-Authored-By: MysticExile <30736337+MysticExile@users.noreply.github.com>
 2020-01-16 16:59:46 -03:00
bunnei 30faf6a964
Merge pull request #3308 from lioncash/private 
maxwell_3d: Make dirty_pointers private
 2020-01-16 13:26:35 -05:00
bunnei d23869811d
Merge pull request #3304 from lioncash/fwd-decl 
renderer_opengl/utils: Forward declare private structs
 2020-01-16 11:21:18 -05:00
Lioncash 9e874898f5 maxwell_3d: Make dirty_pointers private 
This isn't used outside of the class itself, so we can make it private
for the time being.
 2020-01-16 04:07:15 -05:00
James Rowe b429095b61 Fix git version in scm_rev.cpp 2020-01-16 00:12:50 -07:00
ReinUsesLisp c375d735e6 gl_state: Implement PROGRAM_POINT_SIZE 
For gl_PointSize to have effect we have to activate
GL_PROGRAM_POINT_SIZE.
 2020-01-15 16:14:17 -03:00
Lioncash 7af56dfa76 renderer_opengl/utils: Remove unused header inclusions 
Nothing from these headers are used, so they can be removed.
 2020-01-15 06:31:23 -05:00
Lioncash 06d30fbcca renderer_opengl/utils: Forward declare private structs 
Keeps the definitions hidden and allows changes to the structs without
needing to recompile all users of classes containing said structs.
 2020-01-15 06:30:01 -05:00
CJBok 635deb70d4 Moved analog direction logic to sdl_impl 2020-01-15 11:25:15 +01:00
CJBok 231d9c10f3 Corrected directional states sensitivity 2020-01-14 21:51:58 +01:00
ReinUsesLisp 66a1c777c9 gl_texture_cache: Use local variables to simplify DownloadTexture 2020-01-14 17:39:48 -03:00
ReinUsesLisp cdb00546f0 gl_texture_cache: Fix format for RGBX16F 2020-01-14 17:38:33 -03:00
ReinUsesLisp 2d09467f6f gl_texture_cache: Use Snorm internal format for RG8S 2020-01-14 17:37:58 -03:00
ReinUsesLisp 02624c35ec gl_texture_cache: Use Snorm internal format for ABGR8S 2020-01-14 17:37:23 -03:00
Rodrigo Locatti 64cd46579b
Merge pull request #3303 from lioncash/reorder 
control_flow: Silence -Wreorder warning for CFGRebuildState
 2020-01-14 16:15:18 -03:00
Rodrigo Locatti 81e9e229fa
Merge pull request #3302 from lioncash/unused-var 
gl_shader_cache: Remove unused variables
 2020-01-14 16:14:47 -03:00
Lioncash a1eee1749e control_flow: Silence -Wreorder warning for CFGRebuildState 
Organizes the initializer list in the same order that the variables
would actually be initialized in.
 2020-01-14 13:28:48 -05:00
bunnei a83e28b237
Merge pull request #3296 from Simek/hotkeys_resize 
GUI/configure: resize hotkeys action column to fit content
 2020-01-14 13:17:16 -05:00
Lioncash f10ea944e0 gl_shader_cache: Remove unused STAGE_RESERVED_UBOS constant 
Given this isn't used, this can be removed entirely.
 2020-01-14 13:16:52 -05:00
Lioncash 4cd5ad90f3 gl_shader_cache: std::move entries in CachedShader constructor 
Avoids several reallocations of std::vector instances where applicable.
 2020-01-14 13:14:16 -05:00
Lioncash 15a6840e7a gl_shader_cache: Remove unused entries variable in BuildShader() 
Eliminates a few unnecessary constructions of std::vectors.
 2020-01-14 13:11:49 -05:00
bunnei 55f95e7f26
Merge pull request #3287 from ReinUsesLisp/ldg-stg-16 
shader_ir/memory: Implement u16 and u8 for STG and LDG
 2020-01-14 09:57:08 -05:00
bunnei 15788ffcde
Merge pull request #3288 from ReinUsesLisp/uncurse-aoffi 
shader_ir/texture: Simplify AOFFI code
 2020-01-13 23:52:12 -05:00
bunnei 6985eea519
Merge pull request #3290 from ReinUsesLisp/gl-clamp 
maxwell_to_vk: Implement GL_CLAMP hacking Nvidia's driver
 2020-01-13 19:16:06 -05:00
bunnei e749f17257
Merge pull request #3292 from degasus/heap_space_fix 
core/kernel: Fix GetTotalPhysicalMemoryUsed.
 2020-01-13 19:15:43 -05:00
ReinUsesLisp 09e17fbb0f vk_texture_cache: Implement generic texture cache on Vulkan 
It currently ignores PBO linearizations since these should be dropped as
soon as possible on OpenGL.
 2020-01-13 20:37:50 -03:00
ReinUsesLisp 2b2712fa95 texture_cache/surface_params: Make GetNumLayers public 2020-01-13 20:35:43 -03:00
Bartosz Kaszubowski da3049aa74 GUI: add few missing hotkeys to main menu 2020-01-13 00:49:44 +01:00
CJBok 83be9fc96d Merge remote-tracking branch 'upstream/master' 2020-01-12 23:21:30 +01:00
Bartosz Kaszubowski 6726e8b784 GUI/configure: resize hotkeys column to content 2020-01-12 22:46:28 +01:00
Markus Wick c76ffa5019 core/kernel: Fix GetTotalPhysicalMemoryUsed. 
module._memory was already moved over to a new shared_ptr.
So code_memory_size was not increased at all.

This lowers the heap space and so saves a bit of memory, usually between 50 to 100 MB.

This fixes a regression of c0a01f3adc
 2020-01-11 14:04:44 +01:00
Rodrigo Locatti b1138e5ea1
vk_compute_pass: Address feedback 
Comment hardcoded SPIR-V modules.
 2020-01-10 22:46:34 -03:00
ReinUsesLisp 3d46709b7f maxwell_to_vk: Implement GL_CLAMP hacking Nvidia's driver 
Nvidia's driver defaults invalid enumerations to GL_CLAMP. Vulkan
doesn't expose GL_CLAMP through its API, but we can hack it on Nvidia's
driver using the internal driver defaults.
 2020-01-10 17:12:50 -03:00
ReinUsesLisp 13021b534c shader_ir/texture: Simplify AOFFI code 2020-01-09 03:50:37 -03:00
ReinUsesLisp e2a2a556b9 shader_ir/memory: Implement u16 and u8 for STG and LDG 
Using the same technique we used for u8 on LDG, implement u16.

In the case of STG, load memory and insert the value we want to set
into it with bitfieldInsert. Then set that value.
 2020-01-09 02:12:29 -03:00
CJBok ae7fd01e38 hid: Fix analog sticks directional states 2020-01-09 02:40:55 +01:00
ReinUsesLisp 908e085d02 vk_compute_pass: Add compute passes to emulate missing Vulkan features 
This currently only supports quad arrays and u8 indices.

In the future we can remove quad arrays with a table written from the
CPU, but this was used to bootstrap the other passes helpers and it
was left in the code.

The blob code is generated from the "shaders/" directory. Read the
instructions there to know how to generate the SPIR-V.
 2020-01-08 19:24:26 -03:00
ReinUsesLisp 82a64da077 vk_shader_util: Add helper to build SPIR-V shaders 2020-01-08 19:22:20 -03:00
Fernando Sahmkow 80436c1330
Merge pull request #3279 from ReinUsesLisp/vk-pipeline-cache 
vk_pipeline_cache: Initial implementation
 2020-01-08 17:31:20 -04:00
bunnei 319c4d2108
Merge pull request #3272 from bunnei/vi-close-layer 
service: vi: Implement CloseLayer.
 2020-01-07 12:45:34 -05:00
ReinUsesLisp 6888d776ff vk_pipeline_cache: Initial implementation 
Given a pipeline key, this cache returns a pipeline abstraction (for
graphics or compute).
 2020-01-06 22:02:26 -03:00
ReinUsesLisp 2effdeb924 vk_graphics_pipeline: Initial implementation 
This abstractio represents the state of the 3D engine at a given draw.
Instead of changing individual bits of the pipeline how it's done in
APIs like D3D11, OpenGL and NVN; on Vulkan we are forced to put
everything together into a single, immutable object.

It takes advantage of the few dynamic states Vulkan offers.
 2020-01-06 22:02:26 -03:00
ReinUsesLisp dc96a59fa0 vk_compute_pipeline: Initial implementation 
This abstraction represents a Vulkan compute pipeline.
 2020-01-06 22:02:26 -03:00
ReinUsesLisp b392a5986e vk_pipeline_cache: Add file and define descriptor update template filler 
This function allows us to share code between compute and graphics
pipelines compilation.
 2020-01-06 22:02:26 -03:00
ReinUsesLisp 3142f1b597 fixed_pipeline_state: Add depth clamp 2020-01-06 22:02:26 -03:00
ReinUsesLisp 9c548146ca vk_rasterizer: Add placeholder 2020-01-06 22:02:26 -03:00
bunnei 5be00cba15
Merge pull request #3276 from ReinUsesLisp/pipeline-reqs 
vk_update_descriptor/vk_renderpass_cache: Add pipeline cache dependencies
 2020-01-06 17:03:34 -05:00
bunnei ee9b4a7f9a
Merge pull request #3278 from ReinUsesLisp/vk-memory-manager 
renderer_vulkan: Buffer cache, stream buffer and memory manager changes
 2020-01-06 17:03:04 -05:00
ReinUsesLisp 5aeff9aff5 vk_renderpass_cache: Initial implementation 
The renderpass cache is used to avoid creating renderpasses on each
draw. The hashed structure is not currently optimized.
 2020-01-06 18:28:32 -03:00
ReinUsesLisp 322d6a0311 vk_update_descriptor: Initial implementation 
The update descriptor is used to store in flat memory a large chunk of
staging data used to update descriptor sets through templates. It
provides a push interface to easily insert descriptors following the
current pipeline. The order used in the descriptor update template has
to be implicitly followed. We can catch bugs here using validation
layers.
 2020-01-06 18:28:32 -03:00
ReinUsesLisp 5b01f80a12 vk_stream_buffer/vk_buffer_cache: Avoid halting and use generic cache 
The stream buffer before this commit once it was full (no more bytes to
write before looping) waiting for all previous operations to finish.
This was a temporary solution and had a noticeable performance penalty
in performance (from what a profiler showed).

To avoid this mark with fences usages of the stream buffer and once it
loops wait for them to be signaled. On average this will never wait.
Each fence knows where its usage finishes, resulting in a non-paged
stream buffer.

On the other side, the buffer cache is reimplemented using the generic
buffer cache. It makes use of the staging buffer pool and the new
stream buffer.
 2020-01-06 18:13:41 -03:00
ReinUsesLisp ceb851b590 vk_memory_manager: Misc changes 
* Allocate memory in discrete exponentially increasing chunks until the
128 MiB threshold. Allocations larger thant that increase linearly by
256 MiB (depending on the required size). This allows to use small
allocations for small resources.

* Move memory maps to a RAII abstraction. To optimize for debugging
tools (like RenderDoc) users will map/unmap on usage. If this ever
becomes a noticeable overhead (from my profiling it doesn't) we can
transparently move to persistent memory maps without harming the API,
getting optimal performance for both gameplay and debugging.

* Improve messages on exceptional situations.

* Fix typos "requeriments" -> "requirements".

* Small style changes.
 2020-01-06 18:13:41 -03:00
ReinUsesLisp 85bb6a6f08 vk_buffer_cache: Temporarily remove buffer cache 
This is intended for a follow up commit to avoid circular dependencies.
 2020-01-06 17:58:46 -03:00
bunnei 984563b773
Merge pull request #3277 from ReinUsesLisp/make-current 
yuzu/bootmanager: Remove {glx,wgl}MakeCurrent on SwapBuffers
 2020-01-06 14:09:19 -05:00
ReinUsesLisp 8306703a7d yuzu/bootmanager: Remove {glx,wgl}MakeCurrent on SwapBuffers 
MakeCurrent is a costly (according to Nsight's profiler it takes a tenth
of a millisecond to complete), and we don't have a reason to call it
because:
- Qt no longer signals a warning if it's not called
- yuzu no longer supports macOS
 2020-01-06 14:02:47 -03:00
bunnei 09908207fb
Merge pull request #3261 from degasus/page_table 
core/memory + arm/dynarmic: Use a global offset within our arm page table.
 2020-01-06 11:56:59 -05:00
bunnei 89fc75d769
Merge pull request #3257 from degasus/no_busy_loops 
video_core: Block in WaitFence.
 2020-01-06 00:09:57 -05:00
Fernando Sahmkow 56e450a3f7
Merge pull request #3264 from ReinUsesLisp/vk-descriptor-pool 
vk_descriptor_pool: Initial implementation
 2020-01-05 15:54:41 -04:00
bunnei 6fe51f398f
Merge pull request #2945 from FernandoS27/fix-bcat 
nifm: Only return that there's an internet connection when there's a BCATServer
 2020-01-05 02:17:16 -05:00
bunnei be5c149d37 service: time: Implement GetStandardLocalSystemClock. 2020-01-04 22:18:54 -05:00
bunnei cd0a7dfdbc
Merge pull request #3258 from FernandoS27/shader-amend 
Shader_IR: add the ability to amend code in the shader ir.
 2020-01-04 14:05:17 -05:00
bunnei 361285add9 time: Remove overflow error checking (currently breaks ADO builds). 2020-01-04 13:48:31 -05:00
bunnei a4e840181c service: time: Implement GetClockSnapshotFromSystemClockContext. 2020-01-04 13:48:30 -05:00
bunnei fab2607c6b service: time: Implement IsStandardNetworkSystemClockAccuracySufficient. 2020-01-04 13:48:30 -05:00
bunnei 4414640285 system_archive: Add a basic HLE implementation for time zone binary. 2020-01-04 13:48:29 -05:00
bunnei 78f977c980 service: time: Rewrite implementation of glue services. 2020-01-04 13:48:29 -05:00
Fernando Sahmkow 3dd6b55851 Shader_IR: Address Feedback 2020-01-04 14:40:57 -04:00
bunnei 5135b74179 core: Initialize several structs that make use of Common::UUID. 2020-01-04 13:29:55 -05:00
Fernando Sahmkow a1667a7b46 Shader_IR: Implement TXD Array. 
This commit extends the compilation of TXD to support array samplers on
TXD.
 2020-01-04 13:28:02 -04:00
bunnei 64c5631579 service: vi: Implement CloseLayer. 
- Needed for Undertale.
 2020-01-04 00:45:06 -05:00
Rodrigo Locatti 6e347d8d1b
Update src/video_core/renderer_vulkan/vk_descriptor_pool.cpp 
Co-Authored-By: Mat M. <mathew1800@gmail.com>
 2020-01-03 17:34:30 -03:00
bunnei 624a0f7f3f
Merge pull request #3247 from FernandoS27/remap-fix 
NvServices: Correct Ioctl Remap.
 2020-01-03 12:30:56 -05:00
CJBok 2fa9a96309 const correction 2020-01-03 10:30:51 +01:00
CJBok 90f9c830ca clang 2020-01-03 09:31:54 +01:00
CJBok 351e3fb72e
Update configure_input_player.cpp 2020-01-03 09:11:34 +01:00
CJBok 4a566b9828 Added deadzone controls for sdl engine at input settings 2020-01-03 08:54:57 +01:00
ReinUsesLisp 0d6d8129c4 yuzu: Remove Maxwell debugger 
This was carried from Citra and wasn't really used on yuzu. It also adds
some runtime overhead. This commit removes it from yuzu's codebase.
 2020-01-02 23:09:44 -03:00
bunnei ae0e481677
Merge pull request #3243 from ReinUsesLisp/topologies 
maxwell_to_gl: Implement missing primitive topologies
 2020-01-01 20:33:33 -05:00
ReinUsesLisp 1fe7df4517 vk_descriptor_pool: Initial implementation 
Create a large descriptor pool where we allocate all our descriptors
from. It has to be wide enough to support any pipeline, hence its large
numbers.

If the descritor pool is filled, we allocate more memory at that moment.
This way we can take advantage of permissive drivers like Nvidia's that
allocate more descriptors than what the spec requires.
 2020-01-01 16:44:06 -03:00
Markus Wick 0986caa8d8 core/memory + arm/dynarmic: Use a global offset within our arm page table. 
This saves us two x64 instructions per load/store instruction.

TODO: Clean up our memory code. We can use this optimization here as well.
 2020-01-01 12:24:54 +01:00
bunnei 028b2718ed
Merge pull request #3239 from ReinUsesLisp/p2r 
shader/p2r: Implement P2R Pr
 2019-12-31 20:37:16 -05:00
Fernando Sahmkow b3371ed09e Shader_IR: add the ability to amend code in the shader ir. 
This commit introduces a mechanism by which shader IR code can be
amended and extended. This useful for track algorithms where certain
information can derived from before the track such as indexes to array
samplers.
 2019-12-30 15:31:48 -04:00
Fernando Sahmkow 7bd447355f
Merge pull request #3248 from ReinUsesLisp/vk-image 
vk_image: Add an image object abstraction
 2019-12-30 14:25:14 -04:00
Rodrigo Locatti 4cbb363d3f
vk_image: Avoid unnecesary equals 2019-12-30 13:28:23 -03:00
Fernando Sahmkow 287d5921cf
Merge pull request #3249 from ReinUsesLisp/vk-staging-buffer-pool 
vk_staging_buffer_pool: Add a staging pool for temporary operations
 2019-12-30 12:25:59 -04:00
Markus Wick cb9dd01ffd video_core: Block in WaitFence. 
This function is called rarely and blocks quite often for a long time.
So don't waste power and let the CPU sleep.

This might also increase the performance as the other cores might be allowed to clock higher.
 2019-12-30 13:04:53 +01:00
Rodrigo Locatti f2c61bbe13
vk_staging_buffer_pool: Initialize last epoch to zero 2019-12-29 19:19:43 -03:00
Fernando Sahmkow f846e3d6d0
Merge pull request #3250 from ReinUsesLisp/empty-fragment 
gl_rasterizer: Allow rendering without fragment shader
 2019-12-28 14:33:53 -04:00
bunnei 8a76f816a4
Merge pull request #3228 from ReinUsesLisp/ptp 
shader/texture: Implement AOFFI and PTP for TLD4 and TLD4S
 2019-12-26 21:43:44 -05:00
ReinUsesLisp 5b989f189f
gl_rasterizer: Allow rendering without fragment shader 
Rendering without a fragment shader is usually used in depth-only
passes.
 2019-12-26 16:38:49 -03:00
ReinUsesLisp 3813af2f3c
vk_staging_buffer_pool: Add a staging pool for temporary operations 
The job of this abstraction is to provide staging buffers for temporary
operations. Think of image uploads or buffer uploads to device memory.

It automatically deletes unused buffers.
 2019-12-25 18:12:17 -03:00
ReinUsesLisp c83bf7cd1e
vk_image: Add an image object abstraction 
This object's job is to contain an image and manage its transitions.
Since Nvidia hardware doesn't know what a transition is but Vulkan
requires them anyway, we have to state track image subresources
individually.

To avoid the overhead of tracking each subresource in images with many
subresources (think of cubemap arrays with several mipmaps), this commit
tracks when subresources have diverged. As long as this doesn't happen
we can check the state of the first subresource (that will be shared
with all subresources) and update accordingly.

Image transitions are deferred to the scheduler command buffer.
 2019-12-25 18:00:16 -03:00
Fernando Sahmkow a5bb1ac6e3 NvServices: Correct Ioctl Remap. 
This commit corrects a padding value in Ioctl Remap that was actually an 
offset to the mapping address.
 2019-12-25 14:37:28 -04:00
Fernando Sahmkow 5619d24377
Merge pull request #3244 from ReinUsesLisp/vk-fps 
fixed_pipeline_state: Define structure and loaders
 2019-12-25 14:31:29 -04:00
bunnei 4af569ee47
Merge pull request #3236 from ReinUsesLisp/rasterize-enable 
gl_rasterizer: Implement RASTERIZE_ENABLE
 2019-12-24 22:54:10 -05:00
ReinUsesLisp b9e3f5eb36
fixed_pipeline_state: Define symetric operator!= and mark as noexcept 
Marks as noexcept Hash, operator== and operator!= for consistency.
 2019-12-24 18:24:08 -03:00
ReinUsesLisp 4a3026b16b
fixed_pipeline_state: Define structure and loaders 
The intention behind this hasheable structure is to describe the state
of fixed function pipeline state that gets compiled to a single graphics
pipeline state object. This is all dynamic state in OpenGL but Vulkan
wants it in an immutable state, even if hardware can edit it freely.

In this commit the structure is defined in an optimized state (it uses
booleans, has paddings and many data entries that can be packed to
single integers). This is intentional as an initial implementation that
is easier to debug, implement and review. It will be optimized in later
stages, or it might change if Vulkan gets more dynamic states.
 2019-12-22 22:59:11 -03:00
ReinUsesLisp 5770418fb3
maxwell_3d: Add depth bounds registers 2019-12-22 22:55:06 -03:00
ReinUsesLisp 91d35559e5
maxwell_to_gl: Implement missing primitive topologies 
Many of these topologies are exclusively available in OpenGL.
 2019-12-22 22:33:01 -03:00
bunnei e976d0e924
Merge pull request #3241 from ReinUsesLisp/gl-shader-cache 
gl_shader_cache: Style changes
 2019-12-22 16:23:46 -05:00
bunnei 1e76655f83
Merge pull request #3238 from ReinUsesLisp/vk-resource-manager 
vk_resource_manager: Catch device losses and other changes
 2019-12-22 15:57:16 -05:00
bunnei 0f3ac9cfeb
Merge pull request #3203 from FernandoS27/tex-cache-fixes 
Texture Cache: Add HLE methods for building 3D textures
 2019-12-22 14:25:13 -05:00
Fernando Sahmkow 3dc585d011
Merge pull request #3237 from ReinUsesLisp/vk-shader-decompiler 
vk_shader_decompiler: Misc changes
 2019-12-22 12:36:56 -04:00
Fernando Sahmkow 218ee18417 Texture Cache: Improve documentation 2019-12-22 12:29:23 -04:00
Fernando Sahmkow a3916588b6 Texture Cache: Address Feedback 2019-12-22 12:24:34 -04:00
Fernando Sahmkow 51c9e98677 Texture Cache: Add HLE methods for building 3D textures within the GPU in certain scenarios. 
This commit adds a series of HLE methods for handling 3D textures in
general. This helps games that generate 3D textures on every frame and
may reduce loading times for certain games.
 2019-12-22 12:24:34 -04:00
Fernando Sahmkow aea978e037
Merge pull request #3230 from ReinUsesLisp/vk-emu-shaders 
renderer_vulkan/shader: Add helper GLSL shaders
 2019-12-22 11:23:09 -04:00
Fernando Sahmkow 27efcc15e9
Merge pull request #3240 from ReinUsesLisp/decomp-cond-code 
vk_shader_decompiler: Use Visit instead of reimplementing it
 2019-12-22 11:20:55 -04:00
bunnei 16dcfacbfc
Merge pull request #3235 from ReinUsesLisp/ldg-u8 
shader/memory: Implement LDG.U8 and unaligned U8 loads
 2019-12-21 22:50:28 -05:00
ReinUsesLisp 1e16023d60
gl_shader_cache: Update commentary for shared memory 
Remove false commentary. Not dividing by 4 the size of shared memory is
not a hack; it describes the number of integers, not bytes.

While we are at it sort the generated code to put preprocessor lines on
the top.
 2019-12-20 22:51:21 -03:00
ReinUsesLisp 486c6a5316
gl_shader_cache: Remove unused entry in GetPrimitiveDescription 2019-12-20 22:49:30 -03:00
ReinUsesLisp af93909c9c
vk_shader_decompiler: Use Visit instead of reimplementing it 
ExprCondCode visit implements the generic Visit. Use this instead of
that one.

As an intended side effect this fixes unwritten memory usages in cases
when a negation of a condition code is used.
 2019-12-20 21:36:25 -03:00
ReinUsesLisp 38d3a48873
shader/p2r: Implement P2R Pr 
P2R dumps predicate or condition codes state to a register. This is
useful for unit testing.
 2019-12-20 18:02:41 -03:00
ReinUsesLisp cf27b59493
shader/r2p: Refactor P2R to support P2R 2019-12-20 17:55:42 -03:00
bunnei 7be65c6a68
Merge pull request #3234 from ReinUsesLisp/i2f-u8-selector 
shader/conversion: Implement byte selector in I2F
 2019-12-19 22:36:26 -05:00
bunnei 6d55b14cc0
Merge pull request #3233 from ReinUsesLisp/mismatch-sizes 
shader/texture: Properly shrink unused entries in size mismatches
 2019-12-19 20:40:27 -05:00
ReinUsesLisp e41da22c8d
vk_resource_manager: Add entry to VKFence to test its usage 2019-12-19 16:31:34 -03:00
ReinUsesLisp ec983a2451
vk_reosurce_manager: Add assert for releasing fences 
Notify the programmer when a request to release a fence is invalid
because the fence is already free.
 2019-12-19 16:31:34 -03:00
ReinUsesLisp 6ddffa010a
vk_resource_manager: Implement VKFenceWatch move constructor 
This allows us to put VKFenceWatch inside a std::vector without storing
it in heap. On move we have to signal the fences where the new protected
resource is, adding some overhead.
 2019-12-19 16:31:34 -03:00
ReinUsesLisp 54747d60bc
vk_device: Add entry to catch device losses 
VK_NV_device_diagnostic_checkpoints allows us to push data to a Vulkan
queue and then query it even after a device loss. This allows us to push
the current pipeline object and see what was the call that killed the
device.
 2019-12-19 16:31:33 -03:00
ReinUsesLisp 2a63b3bdb9
vk_shader_decompiler: Fix full decompilation 
When full decompilation was enabled, labels were not being inserted and
instructions were misused. Fix these bugs.
 2019-12-19 16:24:45 -03:00
ReinUsesLisp de918ebeb0
vk_shader_decompiler: Skip NDC correction when it is native 
Avoid changing gl_Position when the NDC used by the game is [0, 1]
(Vulkan's native).
 2019-12-19 16:24:45 -03:00
ReinUsesLisp 485c21eac3
vk_shader_decompiler: Normalize output fragment attachments 
Some games write from fragment shaders to an unexistant framebuffer
attachment or they don't write to one when it exists in the framebuffer.
Fix this by skipping writes or adding zeroes.
 2019-12-19 16:24:45 -03:00
bunnei 1eb4a95d2b
Merge pull request #3232 from ReinUsesLisp/gl-decompiler-images 
gl_shader_decompiler: Add missing DeclareImages
 2019-12-19 11:32:47 -05:00
bunnei 253aa52351
Merge pull request #3231 from ReinUsesLisp/tld4s-encoding 
shader_bytecode: Fix TLD4S encoding
 2019-12-19 11:32:25 -05:00
ReinUsesLisp f4a25f854c
vk_device: Add query for RGBA8Uint 2019-12-19 02:08:29 -03:00
ReinUsesLisp abb33d4aec
vk_shader_decompiler: Update sirit and implement Texture AOFFI 2019-12-19 01:42:13 -03:00
bunnei d53cf05513
Merge pull request #3221 from ReinUsesLisp/vk-scheduler 
vk_scheduler: Delegate commands to a worker thread and state track
 2019-12-18 22:04:08 -05:00
ReinUsesLisp da0aa4da6b
gl_rasterizer: Implement RASTERIZE_ENABLE 
RASTERIZE_ENABLE is the opposite of GL_RASTERIZER_DISCARD. Implement it
naturally using this.

NVN games expect rasterize to be enabled by default, reflect that in our
initial GPU state.
 2019-12-18 19:28:23 -03:00
ReinUsesLisp ae8d4b6c0c
shader/memory: Implement LDG.U8 and unaligned U8 loads 
LDG can load single bytes instead of full integers or packs of integers.
These have the advantage of loading bytes that are not aligned to 4
bytes.

To emulate these this commit gets the byte being referenced (by doing
"address & 3" and then using that to extract the byte from the loaded
integer:

result = bitfieldExtract(loaded_integer, (address % 4) * 8, 8)
 2019-12-18 01:21:46 -03:00
ReinUsesLisp a7d6bd1ef1
shader/conversion: Implement byte selector in I2F 
I2F's byte selector is used to choose what bytes to convert to float.
e.g. if the input is 0xaabbccdd and the selector is ".B3" it will
convert 0xaa. The default (when it's not shown in nvdisasm) is ".B0", in
that example the default would convert 0xdd to float.
 2019-12-18 00:41:22 -03:00
ReinUsesLisp 15a753b9a5
shader/texture: Properly shrink unused entries in size mismatches 
When a image format mismatches we were inserting zeroes to the texture
itself. This was not handling cases were the mismatch uses less
coordinates than the guest shader code. Address that by resizing the
vector.
 2019-12-17 23:38:10 -03:00
ReinUsesLisp e438079b50
gl_shader_decompiler: Add missing DeclareImages 2019-12-17 23:34:15 -03:00
ReinUsesLisp 8b26b4228b
shader_bytecode: Fix TLD4S encoding 2019-12-17 23:32:10 -03:00
bunnei 8825b88a45
Merge pull request #3173 from yuzu-emu/bunnei-spscqueue 
common: SPSCQueue: Notify after incrementing queue size.
 2019-12-17 14:11:20 -05:00
bunnei 67b8ecc73e common: SPSCQueue: Notify after incrementing queue size. 2019-12-16 20:39:53 -05:00
ReinUsesLisp b52297767e
renderer_vulkan/shader: Add helper GLSL shaders 
These shaders are used to specify code that is not dynamically generated
in the Vulkan backend. Instead of packing it inside the build system,
it's manually built and copied to the C++ file to avoid adding
unnecessary build time dependencies.

quad_array should be dropped in the future since it can be emulated with
a memory pool generated from the CPU.
 2019-12-16 17:59:08 -03:00
bunnei 65b1b05e05
Merge pull request #3182 from ReinUsesLisp/renderer-opengl 
renderer_opengl: Miscellaneous clean ups
 2019-12-16 13:01:04 -05:00
ReinUsesLisp e09c1fbc1f
shader/texture: Implement TLD4.PTP 2019-12-16 04:09:24 -03:00
ReinUsesLisp 844e4a297b
shader/texture: Enable arrayed TLD4 2019-12-16 02:37:21 -03:00
ReinUsesLisp a87c85eba2
gl_shader_decompiler: Rename "sepparate" to "separate" 2019-12-16 02:12:51 -03:00
ReinUsesLisp 3d2c44848b
shader/texture: Implement AOFFI for TLD4S 2019-12-16 02:06:42 -03:00
ReinUsesLisp 3d9fff82c0
shader/texture: Remove unnecesary parenthesis 2019-12-16 01:52:33 -03:00
Rodrigo Locatti eac075692b
Merge pull request #3219 from FernandoS27/fix-bindless 
Corrections and fixes to TLD4S & bindless samplers failing
 2019-12-16 01:26:11 -03:00
bunnei 3d51153611
Merge pull request #3222 from ReinUsesLisp/maxwell-to-vk 
maxwell_to_vk: Use VK_EXT_index_type_uint8 and misc changes
 2019-12-14 22:30:12 -05:00
bunnei 035ec7d9de
Merge pull request #3213 from ReinUsesLisp/intel-mesa 
gl_device: Enable compute shaders for Intel Mesa drivers
 2019-12-14 16:04:31 -05:00
bunnei 2b650543c6
Merge pull request #3212 from ReinUsesLisp/fix-smem-lmem 
gl_shader_cache: Add missing new-line on emitted GLSL
 2019-12-13 21:35:29 -05:00
ReinUsesLisp e3ea583893
maxwell_to_vk: Improve image format table and add more formats 
A1B5G5R5 uses A1R5G5B5. This is flipped with image view swizzles;
flushing is still not properly implemented on Vulkan for this particular
format.
 2019-12-13 03:12:29 -03:00
ReinUsesLisp f27b21077d
maxwell_to_vk: Implement more vertex formats 2019-12-13 03:12:28 -03:00
ReinUsesLisp 8db8631d81
maxwell_to_vk: Implement more primitive topologies 
Add an extra argument to query device capabilities in the future. The
intention behind this is to use native quads, quad strips, line loops
and polygons if these are released for Vulkan.
 2019-12-13 03:12:28 -03:00
ReinUsesLisp 15513f0801
maxwell_to_vk: Approach GL_CLAMP closer to the GL spec 
The OpenGL spec defines GL_CLAMP's formula similarly to CLAMP_TO_EDGE
and CLAMP_TO_BORDER depending on the filter mode used. It doesn't
exactly behave like this, but it's the closest we can get with what
Vulkan offers without emulating it by injecting shader code.
 2019-12-13 03:12:28 -03:00
ReinUsesLisp f845df8651
maxwell_to_vk: Use VK_EXT_index_type_uint8 when available 2019-12-13 02:37:23 -03:00
ReinUsesLisp 2df9a2dcaf
vk_scheduler: Delegate commands to a worker thread and state track 
Introduce a worker thread approach for delegating Vulkan work derived
from dxvk's approach. https://github.com/doitsujin/dxvk

Now that the scheduler is what handles all Vulkan work related to
command streaming, store state tracking in itself. This way we can know
when to reupload Vulkan dynamic state to the queue (since this one is
invalidated between command buffers unlike NVN). We can also store the
renderpass state and graphics pipeline bound to avoid redundant binds
and renderpass begins/ends.
 2019-12-13 02:24:48 -03:00
bunnei 6d0d79109b
Merge pull request #3214 from lioncash/svc-func 
kernel/svc: Amend function signature of SignalProcessWideKey
 2019-12-12 21:32:36 -05:00
bunnei 8fc49a83b6
Merge pull request #3217 from jhol/fix-boost-include 
Added missing include
 2019-12-11 22:21:24 -05:00
Fernando Sahmkow c0ee0aa1a8 Shader_IR: Correct TLD4S Depth Compare. 2019-12-11 19:53:17 -04:00
Fernando Sahmkow af89723fa3 Shader_Ir: Correct TLD4S encoding and implement f16 flag. 2019-12-11 19:53:17 -04:00
Fernando Sahmkow 84a158c977 Gl_Shader_compiler: Correct Depth Compare for Texture Gather operations. 2019-12-11 19:53:16 -04:00
Fernando Sahmkow 271a3264f3 Shader_Ir: default failed tracks on bindless samplers to null values. 2019-12-11 19:53:16 -04:00
Fernando Sahmkow 1d2ba3cc97 Gl_Rasterizer: Skip Tesselation Control and Eval stages as they are un implemented. 
This commit ensures the OGL backend does not execute tesselation shader 
stages as they are currently unimplemented.
 2019-12-11 15:41:26 -04:00
bunnei 1a66cde175
Merge pull request #3210 from ReinUsesLisp/memory-barrier 
shader: Implement MEMBAR.GL
 2019-12-11 14:24:39 -05:00
Joel Holdsworth e9faa1617c Added missing include 2019-12-11 18:11:49 +00:00
Fernando Sahmkow 22c6b9fab2 Kernel: Correct behavior of Address Arbiter threads. (#3165) 
* Kernel: Correct behavior of Address Arbiter threads.

This corrects arbitration threads to behave just like in Horizon OS.
They are added into a container and released according to what priority
they had when added. Horizon OS does not reorder them if their priority
changes.

* Kernel: Address Feedback.
 2019-12-11 10:55:38 -05:00
Lioncash 30e365e4fc kernel/svc: Correct function signature of SignalProcessWideKey 
This function doesn't actually return a result code, so we can amend the
signature of it to match.
 2019-12-11 07:13:27 -05:00
ReinUsesLisp f564eaebed
gl_device: Enable compute shaders for Intel Mesa drivers 
Previously we naively checked for "Intel" in GL_VENDOR, but this
includes both Intel's proprietary driver and the mesa driver. Re-enable
compute shaders for mesa.
 2019-12-11 00:00:30 -03:00
ReinUsesLisp 48e16c4c49
gl_shader_cache: Add missing new-line on emitted GLSL 
Add missing new-line. This caused shaders using local memory and shared
memory to inject a preprocessor GLSL line after an expression (resulting
in invalid code).

It looked like this:
shared uint smem[8];#define LOCAL_MEMORY_SIZE 16

It should look like this (addressed by this commit):
shared uint smem[8];
\#define LOCAL_MEMORY_SIZE 16
 2019-12-10 23:52:51 -03:00
bunnei 34f8881d3e
Merge pull request #3201 from lioncash/dump 
kernel/svc: Provide implementations for svcDumpInfo/svcDumpInfoNew
 2019-12-10 21:48:37 -05:00
Fernando Sahmkow 7ffb672f61 Maxwell3D: Implement Depth Mode. 
This commit finishes adding depth mode that was reverted before due to
other unresolved issues.
 2019-12-10 19:51:46 -04:00
ReinUsesLisp 425a254fa2
shader: Implement MEMBAR.GL 
Implement using memoryBarrier in GLSL and OpMemoryBarrier on SPIR-V.
 2019-12-10 16:45:03 -03:00
ReinUsesLisp 233ed96a5c
vk_shader_decompiler: Fix build issues on old gcc versions 2019-12-10 01:55:38 -03:00
ReinUsesLisp d30cf51d7d
vk_shader_decompiler: Reduce YNegate's severity 2019-12-09 23:52:28 -03:00
ReinUsesLisp 0b5b93053d
shader_ir/other: Implement S2R InvocationId 2019-12-09 23:52:28 -03:00
ReinUsesLisp ecbfa416f0
vk_shader_decompiler: Misc changes 
Update Sirit and its usage in vk_shader_decompiler. Highlights:
- Implement tessellation shaders
- Implement geometry shaders
- Implement some missing features
- Use native half float instructions when available.
 2019-12-09 23:51:57 -03:00
ReinUsesLisp 9ad6327fbd
shader: Keep track of shaders using warp instructions 2019-12-09 23:40:41 -03:00
ReinUsesLisp 6233b1db08
shader_ir/memory: Implement patch stores 2019-12-09 23:25:21 -03:00
ReinUsesLisp 19ce0d4f1a
vk_device: Misc changes 
- Setup more features and requirements.
- Improve logging for missing features.
- Collect telemetry parameters.
- Add queries for more image formats.
- Query push constants limits.
- Optionally enable some extensions.
 2019-12-09 01:04:48 -03:00
bunnei faf5ae6a50
Merge pull request #3198 from ReinUsesLisp/tessellation-maxwell 
maxwell_3d: Add tessellation state entries
 2019-12-08 22:28:25 -05:00
ReinUsesLisp 7ea362e134
externals: Update Vulkan-Headers 2019-12-08 22:08:19 -03:00
Rodrigo Locatti e54699565a
Merge pull request #3199 from ReinUsesLisp/vk-swapchain 
vk_swapchain: Add support for swapping sRGB
 2019-12-08 21:53:22 -03:00
Lioncash c3e43c7e81 kernel: Remove unnecessary includes 
Over the course of the changes to the kernel code, a few includes are no
longer necessary, particularly with the change over to std::shared_ptr
from Boost's intrusive_ptr.
 2019-12-07 22:37:05 -05:00
Lioncash 67b8265bd6 kernel/svc: Provide implementations for svcDumpInfo/svcDumpInfoNew 
These are fairly trivial to implement, we can just do nothing. This also
provides a spot for us to potentially dump out any relevant info in the
future (e.g. for debugging purposes with homebrew, etc).

While we're at it, we can also correct the names of both of these
supervisor calls.
 2019-12-07 22:01:17 -05:00
ReinUsesLisp f632d00eb1
vk_swapchain: Add support for swapping sRGB 
We don't know until the game is running if it's using an sRGB color
space or not. Add support for hot-swapping swapchain surface formats.
 2019-12-06 22:42:08 -03:00
ReinUsesLisp 36651f215a
maxwell_3d: Add tessellation tess level registers 2019-12-06 22:08:22 -03:00
ReinUsesLisp 707bf41c6f
maxwell_3d: Add tessellation mode register 2019-12-06 22:07:31 -03:00
ReinUsesLisp d2b50c5ebd
maxwell_3d: Add patch vertices register 2019-12-06 22:06:53 -03:00
bunnei 4bbb22a477
Merge pull request #3195 from FernandoS27/clear-exclusive 
CpuCore: Clear exclusive state after doing a run in dynarmic.
 2019-12-06 20:00:23 -05:00
ReinUsesLisp 74f515e8b6
shader_bytecode: Remove corrupted character 2019-12-06 20:31:56 -03:00
bunnei e36814d6d5
Merge pull request #3109 from FernandoS27/new-instr 
Implement FLO & TXD Instructions on GPU Shaders
 2019-12-06 18:18:16 -05:00
Fernando Sahmkow 40cd4df584 CpuCore: Clear exclusive state after doing a run in dynarmic. 
This commit corrects an error in which a Core could remain with an
exclusive state after running, leaving space for possible race
conditions between changing cores.
 2019-12-05 18:08:59 -04:00
ReinUsesLisp be9f80ef56
telemetry_session: Report renderer backend 
We only have OpenGL as an option for now. Hardcode the entry.
 2019-12-02 16:50:39 -03:00
ReinUsesLisp 526e533e90
telemetry_session: Use temporary to avoid writing the same enum 2019-12-02 16:49:46 -03:00
bunnei 3c1b6b5723
Merge pull request #2987 from FernandoS27/texture-invalid 
Texture_Cache: Redo invalid Surfaces handling.
 2019-12-02 12:07:05 -05:00
bunnei 5c7253f8d3
Merge pull request #3177 from bunnei/new-ipc-req 
kernel: Implement a more accurate IPC dispatch.
 2019-11-30 18:56:35 -05:00
bunnei 930b7c18a6
Merge pull request #3184 from ReinUsesLisp/framebuffer-cache 
gl_framebuffer_cache: Optimize framebuffer cache management
 2019-11-30 18:46:40 -05:00
ReinUsesLisp ff64c3951a
texture_cache/surface_base: Fix out of bounds texture views 
Some texture views were being created out of bounds (with more layers or
mipmaps than what the original texture has). This is because of a
miscalculation in mipmap bounding. end_layer and end_mipmap are out of
bounds (e.g. layer 6 in a cubemap), there's no need to add one more
there.

Fixes OpenGL errors and Vulkan crashes on Splatoon 2.
 2019-11-29 16:51:14 -03:00
ReinUsesLisp fb6cf12a17
gl_framebuffer_cache: Optimize framebuffer key 
Pack color attachment enumerations into a single u32. To determine the
number of buffers, the highest color attachment with a shared pointer
that doesn't point to null is used.
 2019-11-28 23:02:20 -03:00
ReinUsesLisp c34da106ed
gl_rasterizer: Re-enable framebuffer cache for clear buffers 2019-11-28 23:02:20 -03:00
ReinUsesLisp e6a0a30334
renderer_opengl: Make ScreenRectVertex's constructor constexpr 2019-11-28 20:36:02 -03:00
ReinUsesLisp dee7844443
renderer_opengl: Remove C casts 2019-11-28 20:28:27 -03:00
ReinUsesLisp 3a44faff11
renderer_opengl: Use explicit binding for presentation shaders 2019-11-28 20:25:56 -03:00
ReinUsesLisp 75cc501d52
renderer_opengl: Drop macros for message decorations 2019-11-28 20:15:25 -03:00
ReinUsesLisp 056f049b26
renderer_opengl: Move static definitions to anonymous namespace 2019-11-28 20:14:40 -03:00
ReinUsesLisp 4589582eaf
renderer_opengl: Move commentaries to header file 2019-11-28 20:11:03 -03:00
bunnei c3d3b173d3 kernel: Implement a more accurate IPC dispatch. 2019-11-28 12:01:53 -05:00
bunnei e3ee017e91
Merge pull request #3169 from lioncash/memory 
core/memory: Deglobalize memory management code
 2019-11-28 11:43:17 -05:00
bunnei fe65045dcb
Merge pull request #3171 from lioncash/internal-link 
filesys/romfs: Make ProcessFile and ProcessDirectory internally linked
 2019-11-28 01:18:10 -05:00
Morph e0242a4654 patch_manager: Adds check for disabled cheats to prevent them from being enabled (#3178) 
* Adds check for disabled cheats to prevent them from being added to the CheatList

* Address feedback
 2019-11-28 01:17:17 -05:00
bunnei c47fc3301d
Merge pull request #3170 from lioncash/enum 
file_sys/directory: Make EntryType an enum class
 2019-11-27 23:23:01 -05:00
Rodrigo Locatti 913d0bb269
Merge pull request #3174 from lioncash/optional 
video_core/gpu_thread: Tidy up SwapBuffers()
 2019-11-27 20:35:31 -03:00
Lioncash aed6d8bef5 video_core/gpu_thread: Tidy up SwapBuffers() 
We can just use std::nullopt and std::make_optional to make this a
little bit less noisy.
 2019-11-27 17:46:11 -05:00
Lioncash 9403979c22 video_core/const_buffer_locker: Make use of std::tie in HasEqualKeys() 
Tidies it up a little bit visually.
 2019-11-27 05:53:43 -05:00
Lioncash 930e311526 video_core/const_buffer_locker: Remove unused includes 2019-11-27 05:51:13 -05:00
Lioncash 9341ca7979 video_core/const_buffer_locker: Remove #pragma once from cpp file 
Silences a compiler warning.
 2019-11-27 05:50:51 -05:00
Lioncash d66ab2b8aa filesys/romfs: Remove unused includes 
These inclusions aren't used at all within the public interface, so they
can be removed.
 2019-11-27 05:29:52 -05:00
Lioncash ba3c55ab7b filesys/romfs: Make ProcessFile and ProcessDirectory internally linked 
These functions aren't used outside of this file, so we can place them
within an anonymous namespace.
 2019-11-27 05:26:35 -05:00
Lioncash a3149536e2 file_sys/directory: Make EntryType an enum class 
This can trivially be an enum class rather than a regular enum, making
it more strongly typed.
 2019-11-27 05:11:02 -05:00
Lioncash e7e939104b core/memory; Migrate over SetCurrentPageTable() to the Memory class 
Now that literally every other API function is converted over to the
Memory class, we can just move the file-local page table into the Memory
implementation class, finally getting rid of global state within the
memory code.
 2019-11-26 21:55:39 -05:00
Lioncash 50a518be69 core/memory: Migrate over GetPointerFromVMA() to the Memory class 
Now that everything else is migrated over, this is essentially just code
relocation and conversion of a global accessor to the class member
variable.

All that remains is to migrate over the page table.
 2019-11-26 21:55:39 -05:00
Lioncash e4c381b885 core/memory: Migrate over Write{8, 16, 32, 64, Block} to the Memory class 
The Write functions are used slightly less than the Read functions,
which make these a bit nicer to move over.

The only adjustments we really need to make here are to Dynarmic's
exclusive monitor instance. We need to keep a reference to the currently
active memory instance to perform exclusive read/write operations.
 2019-11-26 21:55:39 -05:00
Lioncash b05bfc6036 core/memory: Migrate over Read{8, 16, 32, 64, Block} to the Memory class 
With all of the trivial parts of the memory interface moved over, we can
get right into moving over the bits that are used.

Note that this does require the use of GetInstance from the global
system instance to be used within hle_ipc.cpp and the gdbstub. This is
fine for the time being, as they both already rely on the global system
instance in other functions. These will be removed in a change directed
at both of these respectively.

For now, it's sufficient, as it still accomplishes the goal of
de-globalizing the memory code.
 2019-11-26 21:55:39 -05:00
Lioncash 89ef3ef575 core/memory: Migrate over ZeroBlock() and CopyBlock() to the Memory class 
These currently aren't used anywhere in the codebase, so these are very
trivial to move over to the Memory class.
 2019-11-26 21:55:38 -05:00
Lioncash 849581075a core/memory: Migrate over RasterizerMarkRegionCached() to the Memory class 
This is only used within the accelerated rasterizer in two places, so
this is also a very trivial migration.
 2019-11-26 21:55:38 -05:00
Lioncash b2165c6b35 core/memory: Migrate over ReadCString() to the Memory class 
This only had one usage spot, so this is fairly straightforward to
convert over.
 2019-11-26 21:55:38 -05:00
Lioncash 3f08e8d8d4 core/memory: Migrate over GetPointer() 
With all of the interfaces ready for migration, it's trivial to migrate
over GetPointer().
 2019-11-26 21:55:38 -05:00
Lioncash 536fc7f0ea core: Prepare various classes for memory read/write migration 
Amends a few interfaces to be able to handle the migration over to the
new Memory class by passing the class by reference as a function
parameter where necessary.

Notably, within the filesystem services, this eliminates two ReadBlock()
calls by using the helper functions of HLERequestContext to do that for
us.
 2019-11-26 21:55:37 -05:00
Lioncash fc7d0a17b6 core/memory: Move memory read/write implementation functions into an anonymous namespace 
These will eventually be migrated into the main Memory class, but for
now, we put them in an anonymous namespace, so that the other functions
that use them, can be migrated over separately.
 2019-11-26 21:53:35 -05:00
Lioncash e58748fd80 core/memory: Migrate over address checking functions to the new Memory class 
A fairly straightforward migration. These member functions can just be
mostly moved verbatim with minor changes. We already have the necessary
plumbing in places that they're used.

IsKernelVirtualAddress() can remain a non-member function, since it
doesn't rely on class state in any form.
 2019-11-26 21:53:34 -05:00
Lioncash 323680e5ad core/memory: Migrate over memory mapping functions to the new Memory class 
Migrates all of the direct mapping facilities over to the new memory
class. In the process, this also obsoletes the need for memory_setup.h,
so we can remove it entirely from the project.
 2019-11-26 21:53:34 -05:00
Lioncash 4c2ed2706e core/memory: Introduce skeleton of Memory class 
Currently, the main memory management code is one of the remaining
places where we have global state. The next series of changes will aim
to rectify this.

This change simply introduces the main skeleton of the class that will
contain all the necessary state.
 2019-11-26 21:53:34 -05:00
bunnei 6df6caaf5f
Merge pull request #3143 from ReinUsesLisp/indexing-bug 
gl_device: Deduce indexing bug from device instead of heuristic
 2019-11-26 21:53:12 -05:00
bunnei ec0ce96c56
core_timing: Use better reference tracking for EventType. (#3159) 
* core_timing: Use better reference tracking for EventType.

- Moves ownership of the event to the caller, ensuring we don't fire events for destroyed objects.
- Removes need for unique names - we won't be using this for save states anyways.
 2019-11-26 21:48:56 -05:00
bunnei 31daaa7911
Merge pull request #3164 from ReinUsesLisp/half-cast-float 
gl_shader_decompiler: Fix casts from fp32 to fp16
 2019-11-26 09:11:23 -05:00
ReinUsesLisp ef4446cb11
gl_shader_decompiler: Fix casts from fp32 to f16 
Casts from f32 to f16 zeroes the higher half of the target register.
 2019-11-25 22:22:33 -03:00
bunnei f6b9b7910e kernel: Fix reference management for client/server session. 
- Fixes shutdown crash and crash in Pokemon SwSh.
 2019-11-25 18:17:49 -05:00
ReinUsesLisp 410d44ce05
gl_device: Deduce indexing bug from device instead of heuristic 
The heuristic to detect AMD's driver was not working properly since it
also included Intel. Instead of using heuristics to detect it, compare
the GL_VENDOR string.
 2019-11-25 16:15:22 -03:00
bunnei 2899c93818
Merge pull request #3158 from ReinUsesLisp/srgb-blit 
gl_texture_cache: Apply sRGB on blits
 2019-11-24 20:47:13 -05:00
bunnei 50c7539108
Merge pull request #3094 from lioncash/tables 
service: Update function tables
 2019-11-24 20:30:58 -05:00
bunnei 33a6b45a6c
Merge pull request #3155 from bunnei/fix-asynch-gpu-wait 
gpu_thread: Don't spin wait if there are no GPU commands.
 2019-11-24 20:19:25 -05:00
bunnei 9046d4a548
kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. (#3154) 
* kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects.

- See https://github.com/citra-emu/citra/pull/4710 for details.
 2019-11-24 20:15:51 -05:00
bunnei b03242067d
Merge pull request #3098 from ReinUsesLisp/shader-invalidations 
gl_shader_cache: Miscellaneous changes to shaders
 2019-11-24 19:36:30 -05:00
ReinUsesLisp 74fff717aa
gl_texture_cache: Apply sRGB on blits 
glBlitFramebuffer keeps in mind GL_FRAMEBUFFER_SRGB's state. Enable this
depending on the target surface pixel format.
 2019-11-24 18:13:33 -03:00
bunnei b7031b2b9d
Merge pull request #3105 from ReinUsesLisp/fix-stencil-reg 
maxwell_3d: Fix stencil_back_func_mask offset
 2019-11-24 13:53:23 -05:00
bunnei 7298dcc016
Merge pull request #3156 from bunnei/sys-ticks 
svc: GetSystemTick should return cntpct_el0, not core ticks.
 2019-11-24 13:52:28 -05:00
bunnei ec8bfe94a7
Merge pull request #3153 from FearlessTobi/port-4964 
Port citra-emu/citra#4964: "Unfold UNREACHABLE implementation for dumb compilers"
 2019-11-24 02:56:12 -05:00
bunnei e81e0036b4
Merge pull request #3145 from ReinUsesLisp/buffer-cache-init 
buffer_cache: Remove brace initialized for objects with default constructor
 2019-11-24 02:55:02 -05:00
bunnei 63248f4edd
Update svc.cpp 2019-11-23 16:01:06 -05:00
bunnei 6eaf7ab55f svc: GetSystemTick should return cntpct_el0, not core ticks. 2019-11-23 15:29:15 -05:00
bunnei 9ec84fc592 gpu_thread: Don't spin wait if there are no GPU commands. 2019-11-23 15:17:28 -05:00
bunnei 6a3fc5d2ff
Merge pull request #3114 from FernandoS27/cond-var 
Kernel: Correct behavior of Condition Variables to be more similar to real hardware.
 2019-11-23 13:24:39 -05:00
bunnei 4ed183ee42
Merge pull request #3141 from ReinUsesLisp/gl-position 
gl_shader_gen: Apply default value to gl_Position
 2019-11-23 13:23:46 -05:00
bunnei 6e4d46908a
Merge pull request #3130 from FernandoS27/cancel-sync 
Kernel: Correct Cancel Synchronization.
 2019-11-23 13:23:23 -05:00
Weiyi Wang 49e0a30dbd fix clang-format and lambda capture 2019-11-23 01:30:06 +01:00
Weiyi Wang 9a60d8a430 unfold UNREACHABLE implementation for dumb compilers 
We relies on UNREACHABLE's noreturn attribute to eliminate parent's "no return value" warning. However, this was wrapped in a `if(!false)` block, which compilers may not unfold to recognize the noreturn nature.
 2019-11-23 01:30:06 +01:00
ReinUsesLisp dc2e83fa31
gl_device: Reserve base bindings on limited devices 
SSBOs and other resources are limited per pipeline on Intel and AMD.
Heuristically reserve resources per stage having in mind the reported
OpenGL limits.
 2019-11-22 21:28:50 -03:00
ReinUsesLisp e3d7334be9
gl_state: Skip null texture binds 
glBindTextureUnit doesn't support null textures. Skip binding these.
 2019-11-22 21:28:50 -03:00
ReinUsesLisp 919ac2c4d3
gl_rasterizer: Disable compute shaders on Intel 
Intel's proprietary driver enters in a corrupt state when compute
shaders are executed. For now, disable these.
 2019-11-22 21:28:50 -03:00
ReinUsesLisp 894ad74b87
gl_shader_cache: Hack shared memory size 
The current shared memory size seems to be smaller than what the game
actually uses. This makes Nvidia's driver consistently blow up; in the
case of FE3H it made it explode on Qt's SwapBuffers while SDL2 worked
just fine. For now keep this hack since it's still progress over the
previous hardcoded shared memory size.
 2019-11-22 21:28:49 -03:00
ReinUsesLisp e35b9597ef
gl_shader_decompiler: Normalize image bindings 2019-11-22 21:28:49 -03:00
ReinUsesLisp 36d9b409fc
gl_shader_decompiler: Normalize cbuf bindings 
Stage and compute shaders were using a different binding counter.
Normalize these.
 2019-11-22 21:28:49 -03:00
ReinUsesLisp f936b86c7c
gl_rasterizer: Add missing cbuf counter reset on compute 2019-11-22 21:28:49 -03:00
ReinUsesLisp 180417c514
gl_shader_cache: Remove dynamic BaseBinding specialization 2019-11-22 21:28:49 -03:00
ReinUsesLisp c8a48aacc0
video_core: Unify ProgramType and ShaderStage into ShaderType 2019-11-22 21:28:48 -03:00
ReinUsesLisp 0f23359a44
gl_rasterizer: Bind graphics images to draw commands 
Images were not being bound to draw invocations because these would
require a cache invalidation.
 2019-11-22 21:28:48 -03:00
ReinUsesLisp 287ae2b9e8
gl_shader_cache: Specialize local memory size for compute shaders 
Local memory size in compute shaders was stubbed with an arbitary size.
This commit specializes local memory size from guest GPU parameters.
 2019-11-22 21:28:48 -03:00
ReinUsesLisp dbeb523879
gl_shader_cache: Specialize shared memory size 
Shared memory was being declared with an undefined size. Specialize from
guest GPU parameters the compute shader's shared memory size.
 2019-11-22 21:28:47 -03:00
ReinUsesLisp 4f5d8e4342
gl_shader_cache: Specialize shader workgroup 
Drop the usage of ARB_compute_variable_group_size and specialize compute
shaders instead. This permits compute to run on AMD and Intel
proprietary drivers.
 2019-11-22 21:28:47 -03:00
ReinUsesLisp dc9961f341
shader/texture: Handle TLDS texture type mismatches 
Some games like "Fire Emblem: Three Houses" bind 2D textures to offsets
used by instructions of 1D textures. To handle the discrepancy this
commit uses the the texture type from the binding and modifies the
emitted code IR to build a valid backend expression.

E.g.: Bound texture is 2D and instruction is 1D, the emitted IR samples
a 2D texture in the coordinate ivec2(X, 0).
 2019-11-22 21:28:47 -03:00
ReinUsesLisp 32c1bc6a67
shader/texture: Deduce texture buffers from locker 
Instead of specializing shaders to separate texture buffers from 1D
textures, use the locker to deduce them while they are being decoded.
 2019-11-22 21:28:47 -03:00
bunnei bedc903c65
Merge pull request #3140 from FearlessTobi/port-4953 
Port citra-emu/citra#4953: "citra_qt/main.ui: remove unused actions "Load Symbol Map..." and "Select Game Directory...""
 2019-11-21 15:32:24 -05:00
bunnei eedb048585
Merge pull request #3112 from lioncash/skip 
service/am: Remove unnecessary Skip calls
 2019-11-21 15:30:01 -05:00
bunnei d7953b8ee5
Merge pull request #3111 from lioncash/query 
am: Stub QueryApplicationPlayStatistics
 2019-11-21 15:29:34 -05:00
Fernando Sahmkow 46bb609981 Kernel: Optimize condition variable threads management. 2019-11-21 11:13:29 -04:00
Fernando Sahmkow 2ab41ceff4 Kernel: Correct SignalProcessWideKey 
When the target is 0, all threads must be processed.
 2019-11-21 10:46:55 -04:00
Fernando Sahmkow 2d16507f9f Kernel: Correct behavior of Condition Variables to be more similar to real hardware. 
This commit ensures cond var threads act exactly as they do in the real
console. The original implementation uses an RBTree and the behavior of
cond var threads is that at the same priority level they act like a
FIFO.
 2019-11-21 10:46:55 -04:00
ReinUsesLisp 73aaf365e7
buffer_cache: Remove brace initialized for objects with default constructor 2019-11-20 16:00:40 -03:00
Fernando Sahmkow cc81c0ce64 Texture_Cache: Redo invalid Surfaces handling. 
This commit aims to redo the full setup of invalid textures and
guarantee correct behavior across backends in the case of finding one by
using black dummy textures that match the target of the expected
texture.
 2019-11-20 14:59:35 -04:00
ReinUsesLisp 24f4198cee
shader/other: Reduce DEPBAR log severity 
While DEPBAR is stubbed it doesn't change anything from our end. Shading
languages handle what this instruction does implicitly. We are not
getting anything out fo this log except noise.
 2019-11-19 21:26:40 -03:00
ReinUsesLisp bc10714dcf
gl_shader_gen: Apply default value to gl_Position 
Nvidia has sane default output values for varyings, but the other
vendors don't apply these. To properly emulate this we would have to
analyze the shader header. For the time being, apply the same default
Nvidia applies so we get the same behaviour on non-Nvidia drivers.
 2019-11-19 20:32:01 -03:00
bunnei b0819e2ffb
Merge pull request #3086 from ReinUsesLisp/format-lookups 
texture_cache: Use a flat table instead of switch for texture format lookups
 2019-11-19 18:29:17 -05:00
Tobias f9d7a6bec6
citra_qt/main.ui: remove unused actions "Load Symbol Map..." and... 
..."Select Game Directory..."

Co-authored-by: vvanelslande <vvanelslandedev@gmail.com>
 2019-11-19 16:39:58 +01:00
Fernando Sahmkow c8473f399e Shader_IR: Address Feedback 2019-11-18 07:34:34 -04:00
Fernando Sahmkow 7d16b2d2dd Kernel: Correct Cancel Synchronization. 
This commit corrects the behavior of cancel synchronization when the
thread is running/ready and ensures the next wait is cancelled as it's
suppose to.
 2019-11-16 12:41:51 -04:00
ReinUsesLisp 2ac834c722
common/logging: Silence no return value warnings 2019-11-15 18:43:35 -03:00
bunnei a8295d2c53
Merge pull request #3047 from ReinUsesLisp/clip-control 
gl_rasterizer: Emulate viewport flipping with ARB_clip_control
 2019-11-15 12:09:19 -05:00
bunnei 3e0e4f146b
Merge pull request #3091 from lioncash/core-conversion 
core: Make most implicit type conversion warnings errors on MSVC
 2019-11-15 12:08:50 -05:00
ReinUsesLisp 4681381a34
format_lookup_table: Address feedback 
format_lookup_table: Drop bitfields

format_lookup_table: Use std::array for definition table

format_lookup_table: Include <limits> instead of <numeric>
 2019-11-14 20:57:30 -03:00
ReinUsesLisp 80eacdf89b
texture_cache: Use a table instead of switch for texture formats 
Use a large flat array to look up texture formats. This allows us to
properly implement formats with different component types. It should
also be faster.
 2019-11-14 20:57:10 -03:00
Rodrigo Locatti bb31df62bb
Merge pull request #3113 from lioncash/semi 
common_funcs: Remove semicolons from INSERT_PADDING_* macros
 2019-11-14 20:29:51 -03:00
Lioncash f2e34efcbb common_funcs: Remove semicolons from INSERT_PADDING_* macros 
Makes code that uses the macros consistent by requiring the lines to be
terminated with a semicolon.
 2019-11-14 17:05:27 -05:00
Lioncash 2c4c2b5eee service/am: Remove unnecessary Skip calls 
We can simplify these by wrapping the necessary members in structs and
then simply reading out the whole struct.
 2019-11-14 16:31:52 -05:00
ReinUsesLisp 48a1687f51
texture_cache: Drop abstracted ComponentType 
Abstracted ComponentType was not being used in a meaningful way.
This commit drops its usage.

There is one place where it was being used to test compatibility between
two cached surfaces, but this one is implied in the pixel format.
Removing the component type test doesn't change the behaviour.
 2019-11-14 18:21:42 -03:00
Lioncash 1cd8637bf0 am: Stub QueryApplicationPlayStatistics 
Maintains implementation parity between QueryApplicationPlayStatistics
and QueryApplicationPlayStatisticsByUid.

These function the same behaviorally underneath the hood, with the only
difference being that one allows specifying a UID.
 2019-11-14 16:02:39 -05:00
greggameplayer c6bc13d0aa correct the implementation of RGBA16UI 2019-11-14 21:37:39 +01:00
bunnei 885d88825e
Merge pull request #3089 from SciresM/play_statistics 
Implement stub for IApplicationFunctions::QueryApplicationPlayStatisticsByUid
 2019-11-14 13:54:29 -05:00
bunnei 360b0d1b30
Merge pull request #3093 from lioncash/mbedtls 
core: Migrate off deprecated mbedtls functions
 2019-11-14 13:47:23 -05:00
bunnei 02880a8195
Merge pull request #3092 from lioncash/util 
key_manager: Make use of IOFile in WriteKeyToFile()
 2019-11-14 13:46:55 -05:00
Fernando Sahmkow cd0f5dfc17 Shader_IR: Implement TXD instruction. 2019-11-14 11:15:27 -04:00
Fernando Sahmkow f3d1b370aa Shader_IR: Implement FLO instruction. 2019-11-14 11:15:27 -04:00
Fernando Sahmkow 95137a04e1 Shader_Bytecode: Add encodings for FLO, SHF and TXD 2019-11-14 11:15:26 -04:00
Fernando Sahmkow b6f6733131
Merge pull request #3081 from ReinUsesLisp/fswzadd-shuffles 
shader: Implement FSWZADD and reimplement SHFL
 2019-11-14 10:27:27 -04:00
Rodrigo Locatti 7f424d0f60
Merge pull request #3107 from lioncash/hashable 
common/hash: Remove unused HashableStruct
 2019-11-13 17:30:30 -03:00
Rodrigo Locatti ebb30cbefb
Merge pull request #3104 from lioncash/xts 
xts_archive: Remove redundant std::string constructor
 2019-11-13 17:00:02 -03:00
Lioncash c5c89a4d5c common/hash: Remove unused HashableStruct 
This is unused, so it can be removed. There's better ways of ensuring
zeroed out padding bits, like using zero-initialization, anyhow.
 2019-11-13 14:58:43 -05:00
ReinUsesLisp 7990220df7
maxwell_3d: Fix stencil_back_func_mask offset 
stencil_back_func_mask and stencil_back_mask were misplaced. This commit
addresses that issue.
 2019-11-13 16:35:17 -03:00
Rodrigo Locatti cc9e682021
Merge pull request #3103 from lioncash/cfunc 
common_funcs: silence sign-conversion warnings in MakeMagic()
 2019-11-13 16:26:34 -03:00
Lioncash 03b73aa575 xts_archive: Remove redundant std::string constructor 
We can just call the .data() member of path instead of constructing a
completely new string.
 2019-11-13 10:02:10 -05:00
Lioncash 61f6eaad45 common_funcs: silence sign-conversion warnings in MakeMagic() 
We can trivially resolve these by casting the characters to unsigned
values and then shifting the bits.
 2019-11-13 06:53:19 -05:00
Rodrigo Locatti cf770a68a5
Merge pull request #3084 from ReinUsesLisp/cast-warnings 
video_core: Treat implicit conversions as errors
 2019-11-13 02:16:22 -03:00
Lioncash e21b6ff79d service: Update function tables 
Keeps the function tables up to date.

Updated based off information from Switchbrew.
 2019-11-12 10:32:56 -05:00
Lioncash 64cbebc58f key_manager: Make use of IOFile in WriteKeyToFile() 
This properly handles unicode-based paths on Windows, while opening a
raw stream doesn't out-of-the-box.

Prevents file creation from potentially failing on Windows PCs that make
use of unicode characters in their save paths (e.g. writing to a user's
AppData folder, where the user has a name with non-ASCII characters).
 2019-11-12 08:52:18 -05:00
Lioncash e0c46e6879 core: Migrate off deprecated mbedtls functions 
These functions are marked for deprecation and it's recommended that the
*_ret variants be used instead.
 2019-11-12 08:45:56 -05:00
Lioncash 47a6bb2d5b externals: Update httplib 
Since the introduction of this library, numerous improvements have been
made. Notably, many of the warnings we would get by simply including the
library header have now been fixed. This makes it much easier to make
conversion warning an error.
 2019-11-12 08:31:27 -05:00
Lioncash f11b87ebf1 service: Resolve sign conversion errors 
These are fairly trivial to resolve and most of the changes entail
using RESULT_UNKNOWN over ResultCode(-1).
 2019-11-12 07:55:39 -05:00
Lioncash 75dec14f21 perf_stats: Resolve implicit int to double conversion error 
We simply need to turn the literal argument to std::accumulate into a
double, rather than an int.
 2019-11-12 07:55:39 -05:00
Lioncash 23878bf360 loader; Resolve sign conversion/truncation errors 2019-11-12 07:55:39 -05:00
Lioncash 86a1eb7789 gdbstub: Resolve sign conversion errors 2019-11-12 07:55:39 -05:00
Lioncash 12dc918937 kernel: Resolve sign conversion warnings 
Uncovered a bug within Thread's SetCoreAndAffinityMask() where an
unsigned variable (ideal_core) was being compared against "< 0", which
would always be a false condition.

We can also get rid of an unused function (GetNextProcessorId) which contained a sign
mismatch warning.
 2019-11-12 07:55:39 -05:00
Lioncash 86c397dd6e file_sys: Resolve sign conversion warnings 
Resolves a few trivial sign conversion/mismatch errors.
 2019-11-12 07:55:39 -05:00
Lioncash ef060ed40c result: Add default error code for the ResultCode(-1) case 
Will be used to reduce the overall duplication of the same magic value
all over the codebase in following changes.
 2019-11-12 07:55:38 -05:00
Lioncash 581d2e36e5 crypto: Resolve sign-conversion warnings 2019-11-12 07:55:22 -05:00
Lioncash 27ab99490e result: Resolve sign-coversion warnings 
The constructor was implicitly using signed->unsigned conversions to
produce 0xFFFFFFFF. We can just specify this explicitly with UINT32_MAX.
 2019-11-12 07:06:48 -05:00
Lioncash 19a0abc19b arm_unicorn: Resolve sign conversion warnings 
While we're at it, this also resolves a type truncation warning as well,
given the code was truncating from a 64-bit value to a 32-bit one.
 2019-11-12 07:06:48 -05:00
Lioncash 96d677bef0 CMakeLists: Make most implicit type conversion warnings errors on MSVC 
Quite frequently there have been cases where code has been merged into
the core that produces warning. In order to prevent this from occurring,
we can make the compiler flag these cases and allow our CI to flag down
any code that would generate these warnings.

This is beneficial given silent conversions from signed/unsigned can
result in logic bugs. This forces one writing changes to be explicit
about when signedness conversions are desirable, rather than leaving it
up to readers' interpretation.

Currently the codebase isn't in a state where it will build successfully
with this change applied, but this will be addressed in subsequent
follow-up changes. This set of changes will focus on making it build
properly with these changes for MSVC as a starting point for basic
coverage.
 2019-11-12 07:06:25 -05:00
Rodrigo Locatti fb9418798d
video_core: Enable sign conversion warnings 
Enable sign conversion warnings but don't treat them as errors.
 2019-11-11 18:00:37 -03:00
Michael Scire b0b0786493 Implement stub for QueryApplicationPlayStatisticsByUid 2019-11-11 07:32:47 -08:00
bunnei 8714d40a77
Merge pull request #3085 from bunnei/web-token-b64 
yuzu: configure_web: Use Base64 encoded token
 2019-11-09 14:50:31 -05:00
bunnei 8dc9f35baf web-service: Port citra's updated web_backend code. 2019-11-09 14:00:44 -05:00
bunnei 883eb1a1a1 yuzu: configure_web: Use Base64 encoded token for simplifying user experience. 2019-11-09 14:00:44 -05:00
bunnei 0fc596de6e
Merge pull request #3082 from ReinUsesLisp/fix-lockers 
gl_shader_cache: Fix locker constructors
 2019-11-09 13:58:36 -05:00
ReinUsesLisp 18c1cb68fd video_core: Treat implicit conversions as errors 2019-11-08 22:49:39 +00:00
ReinUsesLisp 096f339a2a video_core: Silence implicit conversion warnings 2019-11-08 22:48:50 +00:00
bunnei a056d8de16
Merge pull request #3080 from FernandoS27/glsl-fix 
GLSLDecompiler: Correct Texture Gather Offset.
 2019-11-08 15:56:29 -05:00
ReinUsesLisp bfa973a62b
gl_shader_cache: Fix locker constructors 
Properly pass engine when a shader is being constructed from memory.
 2019-11-07 20:43:31 -03:00
ReinUsesLisp 3ab0514698
gl_shader_cache: Enable extensions only when available 
Silence GLSL compilation warnings.
 2019-11-07 20:08:42 -03:00
ReinUsesLisp cd66395944
gl_shader_decompiler: Add safe fallbacks when ARB_shader_ballot is not available 2019-11-07 20:08:42 -03:00
ReinUsesLisp 56e237d1f9
shader_ir/warp: Implement FSWZADD 2019-11-07 20:08:41 -03:00
ReinUsesLisp 08b2b1080a
gl_shader_decompiler: Reimplement shuffles with platform agnostic intrinsics 2019-11-07 20:08:41 -03:00
Fernando Sahmkow 3d7c284e0f GLSLDecompiler: Correct Texture Gather Offset. 
This commit corrects the argument ordering in textureGatherOffset.
 2019-11-07 11:43:56 -04:00
bunnei b6ae48966d
Merge pull request #3032 from ReinUsesLisp/simplify-control-flow-brx 
shader/control_flow: Abstract repeated code chunks in BRX tracking
 2019-11-07 01:30:01 -05:00
Morph 0e8a3bf3e5 buffer_cache: Add missing includes (#3079) 
`boost::make_iterator_range` is available when `boost/range/iterator_range.hpp` is included.
Also include `boost/icl/interval_map.hpp` and `boost/icl/interval_set.hpp`.
 2019-11-07 06:25:53 +00:00
bunnei 344d15f61e
Merge pull request #3070 from ReinUsesLisp/shader-warnings 
shader_ir: Reduce severity of warnings
 2019-11-07 00:47:24 -05:00
ReinUsesLisp e9d2fad984
gl_rasterizer: Remove front facing hack 2019-11-07 01:52:18 -03:00
ReinUsesLisp f1facaeaef
gl_shader_decompiler: Fix typo "y_negate"->"y_direction" 2019-11-07 01:52:18 -03:00
ReinUsesLisp e2ea0c3e11
gl_shader_manager: Remove unused variable in SetFromRegs 2019-11-07 01:52:18 -03:00
ReinUsesLisp 028b1a34a9
yuzu_cmd: Use string_view instead of string for extensions 
Avoids potential allocations due to the usage of std::string on strings
that we know at compile time. Most of these might fit in SSO, but it
adds complexity that can be easily avoided with string views.
 2019-11-07 01:52:18 -03:00
ReinUsesLisp f019817f8f
gl_rasterizer: Emulate viewport flipping with ARB_clip_control 
Emulates negative y viewports with ARB_clip_control. This allows us to
more easily emulated pipelines with tessellation and/or geometry shader
stages. It also avoids corrupting games with transform feedbacks and
negative viewports (gl_Position.y was being modified).
 2019-11-07 01:52:18 -03:00
Rodrigo Locatti ff5a0f370c
shader/control_flow: Specify constness on caller lambdas 
Update src/video_core/shader/control_flow.cpp

Co-Authored-By: Mat M. <mathew1800@gmail.com>

Update src/video_core/shader/control_flow.cpp

Co-Authored-By: Mat M. <mathew1800@gmail.com>

Update src/video_core/shader/control_flow.cpp

Co-Authored-By: Mat M. <mathew1800@gmail.com>

Update src/video_core/shader/control_flow.cpp

Co-Authored-By: Mat M. <mathew1800@gmail.com>

Update src/video_core/shader/control_flow.cpp

Co-Authored-By: Mat M. <mathew1800@gmail.com>

Update src/video_core/shader/control_flow.cpp

Co-Authored-By: Mat M. <mathew1800@gmail.com>
 2019-11-07 01:44:09 -03:00
ReinUsesLisp 7b069252f8
shader/control_flow: Use callable template instead of std::function 2019-11-07 01:44:08 -03:00
ReinUsesLisp 46c3047283
shader/control_flow: Abstract repeated code chunks in BRX tracking 
Remove copied and pasted for cycles into a common templated function.
 2019-11-07 01:44:08 -03:00
ReinUsesLisp ae7dfa93be
shader/control_flow: Silence Intellisense cast warnings 2019-11-07 01:44:08 -03:00
ReinUsesLisp deb1b54eed
shader/control_flow: Remove brace initializer in std containers 
These containers have a default constructor.
 2019-11-07 01:44:08 -03:00
ReinUsesLisp 39c66abd91
shader/decode: Reduce severity of arithmetic rounding warnings 2019-11-07 01:43:38 -03:00
ReinUsesLisp c4374d0d41
shader/arithmetic: Reduce RRO stub severity 2019-11-07 01:43:38 -03:00
ReinUsesLisp 35d40b74b3
shader/texture: Remove NODEP warnings 
These warnings don't offer meaningful information while decoding
shaders. Remove them.
 2019-11-07 01:43:38 -03:00
Fernando Sahmkow 3c95e49c42 nifm: Only return that there's an internet connection when there's a BCATServer 
This helps games that need internet for other purposes boot as the rest
of our internet infrastructure is incomplete.
 2019-11-06 23:10:32 -05:00
bunnei 468576284d
Merge pull request #3057 from ReinUsesLisp/buffer-sub-data 
gl_rasterizer: Upload constant buffers with glNamedBufferSubData
 2019-11-06 10:08:55 -05:00
bunnei 4d66ca97e5
Merge pull request #3076 from DarkLordZach/telem-names 
ci: Populate build repository from Azure environment
 2019-11-06 10:08:27 -05:00
bunnei c1a3d19897
Merge pull request #3062 from bunnei/event-improve 
kernel: Improve events
 2019-11-06 10:05:50 -05:00
Rodrigo Locatti 654b77d2ec
Merge pull request #3039 from ReinUsesLisp/cleanup-samplers 
shader/node: Unpack bindless texture encoding
 2019-11-06 04:54:11 +00:00
Zach Hilman 0c8b6b0351 ci: Populate build repository from Azure environment 2019-11-05 21:37:27 -05:00
David 0e34f648f4
Merge pull request #2859 from Morph1984/hid 
hid: Stub SetNpadJoyAssignmentModeSingle and GetNpadHandheldActivationMode
 2019-11-06 12:48:07 +11:00
bunnei 21e07df7b7
Merge pull request #2914 from FernandoS27/fermi-fix 
Fermi2D: limit blit area to only available area
 2019-11-05 20:45:24 -05:00
bunnei 1bdae0fe29 common_func: Use std::array for INSERT_PADDING_* macros. 
- Zero initialization here is useful for determinism.
 2019-11-03 22:22:41 -05:00
bunnei ae6eb61892
Merge pull request #3059 from FearlessTobi/stub-am-commands 
core/am: Stub InitializeApplicationCopyrightFrameBuffer, SetApplicationCopyrightImage and SetApplicationCopyrightVisibility
 2019-11-03 05:26:33 -05:00
bunnei ece5287843 kernel: readable_event: Signal only once. 2019-11-03 04:25:41 -05:00
bunnei b0ab803ce8 kernel: events: Remove ResetType::Automatic. 
- This does not actually seem to exist in the real kernel - games reset these automatically.

# Conflicts:
#	src/core/hle/service/am/applets/applets.cpp
#	src/core/hle/service/filesystem/fsp_srv.cpp
 2019-11-03 04:22:45 -05:00
bunnei 28bb248db6 kernel: readable_event: Initialize members. 2019-11-03 04:18:39 -05:00
Tobias a81987a7cb
common/bit_field: Remove FORCE_INLINE calls 
See bunneis comment here https://github.com/citra-emu/citra/pull/4629#discussion_r258533167.
They were supposed to be removed by him, but he missed them.
 2019-11-03 08:25:37 +01:00
FearlessTobi 832c138eff core/am: Stub InitializeApplicationCopyrightFrameBuffer, SetApplicationCopyrightImage and SetApplicationCopyrightVisibility 
These commands require Screenshots to be implemented anyway, so they are safe to stub for now.
 2019-11-03 07:37:38 +01:00
FearlessTobi 727ba2f2d0 citra_qt: add amiibo drag and drop support 
Co-Authored-By: Valentin Vanelslande <vvanelslandedev@gmail.com>
 2019-11-03 05:24:47 +01:00
ReinUsesLisp 442a1cc021
gl_rasterizer: Re-enable stream buffer memory due to global memory 
Global memory is still using the stream buffer when it shouldn't. As a
temporary fix re-enable the stream buffer on compute.
 2019-11-02 13:19:19 -03:00
ReinUsesLisp 76ca2a5f82
gl_rasterizer: Upload constant buffers with glNamedBufferSubData 
Nvidia's OpenGL driver maps gl(Named)BufferSubData with some requirements
to a fast. This path has an extra memcpy but updates the buffer without
orphaning or waiting for previous calls. It can be seen as a better
model for "push constants" that can upload a whole UBO instead of 256
bytes.

This path has some requirements established here:
http://on-demand.gputechconf.com/gtc/2014/presentations/S4379-opengl-44-scene-rendering-techniques.pdf#page=24

Instead of using the stream buffer, this commits moves constant buffers
uploads to calls of glNamedBufferSubData and from my testing it brings a
performance improvement. This is disabled when the vendor is not Nvidia
since it brings performance regressions.
 2019-11-02 05:05:34 -03:00
Fernando Sahmkow 23cabc98db Shader_IR: Fix regression on TLD4 
Originally on the last commit I thought TLD4 acted the same as TLD4S and 
didn't have a mask. It actually does have a component mask. This commit 
corrects that.
 2019-10-30 21:14:57 -04:00
Rodrigo Locatti 658489ebf7
Merge pull request #3050 from FernandoS27/fix-tld4 
shader_ir: Fix TLD4 and add bindless variant
 2019-10-30 18:37:17 +00:00
Fernando Sahmkow 9293c3a0f2 Shader_IR: Fix TLD4 and add Bindless Variant. 
This commit fixes an issue where not all 4 results of tld4 were being
written, the color component was defaulted to red, among other things.
It also implements the bindless variant.
 2019-10-30 12:02:03 -04:00
Rodrigo Locatti 04b838c857
Merge pull request #3038 from lioncash/docs 
kernel/scheduler: Minor changes
 2019-10-30 03:47:28 +00:00
bunnei 2382bbe3ac
Merge pull request #3046 from ReinUsesLisp/clean-gl-state 
gl_state: Miscellaneous clean up
 2019-10-29 22:50:04 -04:00
bunnei b5138f3c35
Merge pull request #3035 from ReinUsesLisp/rasterizer-accelerated 
rasterizer_accelerated: Add intermediary for GPU rasterizers
 2019-10-29 22:06:41 -04:00
bunnei a81bd962ab
Merge pull request #3007 from DarkLordZach/fsc-regress 
savedata_factory: Automatically create certain savedata
 2019-10-29 22:05:09 -04:00
Rodrigo Locatti 3d0cde6a75
gl_state: Use std::array::fill instead of std::fill 
Co-Authored-By: Mat M. <mathew1800@gmail.com>
 2019-10-30 01:30:31 +00:00
ReinUsesLisp ce20ed8e4e
gl_state: Move dirty checks to individual apply calls instead of Apply 
This requires removing constness from some methods, but for consistency
it's removed in all methods.
 2019-10-29 21:27:25 -03:00
ReinUsesLisp 3c6557c235
gl_state: Remove ApplyDefaultState 
OpenGL has defaults values we can trust. Remove these.
 2019-10-29 21:27:25 -03:00
ReinUsesLisp d3651b0b82
gl_state: Change SetDefaultViewports to use default constructor 2019-10-29 21:27:24 -03:00
ReinUsesLisp c7698d0bc8
gl_state: Minor style changes 2019-10-29 21:27:24 -03:00
ReinUsesLisp a14d202ac2
gl_state: Remove unused Citra TextureUnits 2019-10-29 21:27:24 -03:00
ReinUsesLisp 28fece8e9b
gl_state: Move initializers from constructor to class declaration 2019-10-29 21:27:23 -03:00
ReinUsesLisp a993df1ee2
shader/node: Unpack bindless texture encoding 
Bindless textures were using u64 to pack the buffer and offset from
where they come from. Drop this in favor of separated entries in the
struct.

Remove the usage of std::set in favor of std::list (it's not std::vector
to avoid reference invalidations) for samplers and images.
 2019-10-29 20:53:48 -03:00
Rodrigo Locatti 2ec5b55ee3
Merge pull request #3004 from ReinUsesLisp/maxwell3d-cleanup 
maxwell_3d: Remove unused entries
 2019-10-29 23:46:33 +00:00
Rodrigo Locatti c5d9589942
Merge pull request #3037 from FernandoS27/new-formats 
video_core: Implement texture format E5B9G9R9_SHAREDEXP.
 2019-10-28 01:36:58 -03:00
Lioncash 6c8f28813c scheduler: Mark parameter of AskForReselectionOrMarkRedundant() as const 
This is only compared against, so it can be made const.
 2019-10-27 23:35:50 -04:00
ReinUsesLisp fa31e5b868
maxwell_3d/kepler_compute: Remove unused arguments in GetTexture 2019-10-28 00:23:42 -03:00
ReinUsesLisp 538ddd220e
video_core/textures: Remove unused index entry in FullTextureInfo 2019-10-28 00:14:38 -03:00
ReinUsesLisp 961fe4d19b
maxwell_3d: Remove unused method GetStageTextures 2019-10-28 00:14:29 -03:00
Lioncash f19c1a7cda scheduler: Silence sign conversion warnings 2019-10-27 22:44:52 -04:00
Lioncash 2fb0bbff29 scheduler: Initialize class members directly where applicable 
Reduces the overall amount of code.
 2019-10-27 22:13:55 -04:00
Lioncash 2dc469ceba scheduler: Amend documentation comments 
Adjusts the formatting of a few of the comments an ensures they get
recognized as proper Doxygen comments.
 2019-10-27 22:12:32 -04:00
David 4c5731c34f
Merge pull request #2971 from FernandoS27/new-scheduler-v2 
Kernel: Implement a New Thread Scheduler V2
 2019-10-28 10:53:27 +11:00
Fernando Sahmkow 3f9262195b Video_Core: Implement texture format E5B9G9R9_SHAREDEXP. 
This commit implements the E5B9G9R9 Texture format into the general 
system and OpenGL backend.
 2019-10-27 16:44:09 -04:00
bunnei 6909b2f0f9
Merge pull request #3034 from ReinUsesLisp/w4244-maxwell3d 
maxwell_3d: Silence implicit conversion warnings
 2019-10-27 15:08:59 -04:00
ReinUsesLisp 3e469cecc1
maxwell_3d: Silence implicit conversion warnings 
While we are at it, unify types for dirty reg pointers.
 2019-10-27 15:22:17 -03:00
ReinUsesLisp bd2aff3e26
rasterizer_accelerated: Add intermediary for GPU rasterizers 
Add an intermediary class that implements common functions across GPU
accelerated rasterizers. This avoids code repetition on different
backends.
 2019-10-27 03:40:08 -03:00
ReinUsesLisp a5aa1bb174
astc: Silence implicit conversion warnings 2019-10-27 03:04:50 -03:00
Rodrigo Locatti 26f3e18c5c
Merge pull request #2976 from FernandoS27/cache-fast-brx-rebased 
Implement Fast BRX, fix TXQ and addapt the Shader Cache for it
 2019-10-26 16:56:13 -03:00
Fernando Sahmkow be856a38d6 Shader_IR: Address Feedback. 2019-10-26 15:38:30 -04:00
Rodrigo Locatti a0d79085c4
Merge pull request #3027 from lioncash/lookup 
shader_ir: Use std::array with std::pair instead of std::unordered_map
 2019-10-26 05:49:15 -03:00
Rodrigo Locatti d52598173d
Merge pull request #3013 from FernandoS27/tld4s-fix 
Shader_Ir: Fix TLD4S from using a component mask.
 2019-10-25 20:06:26 -03:00
Fernando Sahmkow e3afd6595a Shader_IR: Clang format 2019-10-25 09:01:32 -04:00
ReinUsesLisp 78f3e8a757 gl_shader_cache: Implement locker variants invalidation 2019-10-25 09:01:32 -04:00
ReinUsesLisp ec85648af3 gl_shader_disk_cache: Store and load fast BRX 2019-10-25 09:01:31 -04:00
ReinUsesLisp fa2c297f3e const_buffer_locker: Minor style changes 2019-10-25 09:01:31 -04:00
ReinUsesLisp 7b81ba4d8a gl_shader_decompiler: Move entries to a separate function 2019-10-25 09:01:31 -04:00
Fernando Sahmkow 1244f2d368 Shader_IR: Implement Fast BRX and allow multi-branches in the CFG. 2019-10-25 09:01:31 -04:00
Fernando Sahmkow a05120ec0b Shader_IR: Correct typo in Consistent method. 2019-10-25 09:01:30 -04:00
Fernando Sahmkow 33fcec3502 Shader_IR: allow lookup of texture samplers within the shader_ir for instructions that don't provide it 2019-10-25 09:01:30 -04:00
Fernando Sahmkow 8909f52166 Shader_IR: Implement Fast BRX and allow multi-branches in the CFG. 2019-10-25 09:01:30 -04:00
Fernando Sahmkow acd6441134 Shader_Cache: setup connection of ConstBufferLocker 2019-10-25 09:01:29 -04:00
Fernando Sahmkow 1a58f45d76 VideoCore: Unify const buffer accessing along engines and provide ConstBufferLocker class to shaders. 2019-10-25 09:01:29 -04:00
Fernando Sahmkow 2ef696c85a Shader_IR: Implement BRX tracking. 2019-10-25 09:01:29 -04:00
Rodrigo Locatti 5062728669
Merge pull request #3028 from lioncash/constexpr 
shader_bytecode: Make Matcher constexpr capable
 2019-10-24 15:10:40 -03:00
Lioncash 7fdf991097 shader_bytecode: Make Matcher constexpr capable 
Greatly shrinks the amount of generated code for GetDecodeTable().

Collapses an assembly output of 9000+ lines down to ~3621 with Clang,
and 6513 down to ~2616 with GCC, given it's now allowed to construct all
the entries as a sequence of constant data.
 2019-10-24 01:10:10 -04:00
Lioncash 382717172e shader_ir: Use std::array with pair instead of unordered_map 
Given the overall size of the maps are very small, we can use arrays of
pairs here instead of always heap allocating a new map every time the
functions are called. Given the small size of the maps, the difference
in container lookups are negligible, especially given the entries are
already sorted.
 2019-10-24 00:25:38 -04:00
Lioncash 1f5401c89c video_core/shader: Resolve instances of variable shadowing 
Silences a few -Wshadow warnings.
 2019-10-23 23:00:31 -04:00
bunnei 6fe89acf0d
Merge pull request #2991 from lioncash/npad 
hid/npad: Minor cleanup
 2019-10-22 19:51:24 -04:00
Zach Hilman bb207fe27a savedata_factory: Automatically create certain savedata 
After further hardware investigation, it appears that some games, perhaps those more lazily coded, will not call EnsureSaveData, meaning that they expect the normal (current) save to be automatically made. Additionally, some games do not create a cache or temporary save before use.
In these 3 specific instances, the save is created automatically for the game if it doesn't exist.
 2019-10-22 15:47:38 -04:00
Fernando Sahmkow c4a0aa9207
Merge pull request #2995 from ReinUsesLisp/ignore-gmem 
shader_ir/memory: Ignore global memory when tracking fails
 2019-10-22 13:22:43 -04:00
Fernando Sahmkow 7ecf9f7228
Merge pull request #2983 from lioncash/fallthrough 
gl_shader_decompiler/vk_shader_decompiler: Resolve implicit fallthrough cases
 2019-10-22 13:16:46 -04:00
Fernando Sahmkow 1509d2ffbd Shader_Ir: Fix TLD4S from using a component mask. 
TLD4S always outputs 4 values, the previous code checked a component 
mask and omitted those values that weren't part of it. This commit 
corrects that and makes sure all 4 values are set.
 2019-10-22 10:59:07 -04:00
ReinUsesLisp 1ea07954fb shader_ir/memory: Ignore global memory when tracking fails 
Ignore global memory operations instead of invoking undefined behaviour
when constant buffer tracking fails and we are blasting through asserts,
ignore the operation.

In the case of LDG this means filling the destination registers with
zeroes; for STG this means ignore the instruction as a whole.

The default behaviour is still to abort execution on failure.
 2019-10-22 02:49:17 -03:00
ReinUsesLisp e3107788e6
maxwell_3d: Reduce FlushMMEInlineDraw logging to Trace 2019-10-20 03:43:17 -03:00
bunnei a86a88109a core: Fix clang-format errors. 2019-10-19 14:47:18 -04:00
Nicolae-Andrei Cociorba 20521da259 Fix null pointer deref. 2019-10-18 14:12:12 +00:00
Rodrigo Locatti dc5eedef71
Merge pull request #2994 from lioncash/fmt 
video_core/shader/ast: Minor changes to ASTPrinter
 2019-10-18 01:05:25 -03:00
Lioncash 074b38b7a9 video_core/shader/ast: Make ShowCurrentState() and SanityCheck() const member functions 
These can also trivially be made const member functions, with the
addition of a few consts.
 2019-10-17 20:59:48 -04:00
Lioncash 222f4b45eb video_core/shader/ast: Make ASTManager::Print a const member function 
Given all visiting functions never modify the nodes, we can trivially
make this a const member function.
 2019-10-17 20:56:39 -04:00
Rodrigo Locatti fd922ddb01
Merge pull request #2993 from lioncash/vulkan-expr 
vk_shader_decompiler: Mark operator() function parameters as const references
 2019-10-17 21:46:49 -03:00
Lioncash 7831e86c34 video_core/shader/ast: Make ExprPrinter members private 
This member already has an accessor, so there's no need for it to be
public.
 2019-10-17 20:39:36 -04:00
Lioncash a2eccbf075 video_core/shader/ast: Make Indent() return a string_view 
The returned string is simply a substring of our constexpr tabs
string_view, so we can just use a string_view here as well, since the
original string_view is guaranteed to always exist.

Now the function is fully non-allocating.
 2019-10-17 20:29:00 -04:00
Lioncash 15d177a6ac video_core/shader/ast: Make Indent() private 
It's never used outside of this class, so we can narrow its scope down.
 2019-10-17 20:26:13 -04:00
Lioncash 7f6a8a33d4 video_core/shader/ast: Rename Ident() to Indent() 
This can be confusing, given "ident" is generally used as a shorthand
for "identifier".
 2019-10-17 20:26:13 -04:00
Lioncash 081530686c video_core/shader/ast: Make use of fmt where applicable 
Makes a few strings nicer to read and also eliminates a bit of string
churn with operator+.
 2019-10-17 20:26:10 -04:00
bunnei d1713ad451
Merge pull request #2992 from lioncash/dmnt 
dmnt_cheat_vm: Correct register Restore and ClearRegs behavior
 2019-10-17 19:52:24 -04:00
Lioncash c6bec9aa10 vk_shader_decompiler: Mark operator() function parameters as const references 
These parameters aren't actually modified in any way, so they can be
made const references.
 2019-10-17 19:44:00 -04:00
Lioncash 2c34d8aabb dmnt_cheat_vm: Correct register Restore and ClearRegs behavior 
Previously these were performing the same behavior as the Save and
ClearSaved opcode types.
 2019-10-17 18:49:39 -04:00
Rodrigo Locatti 219fdcb9d9
Merge pull request #2966 from FernandoS27/astc-formats 
Implement a series of ASTC formats and R4G4B4A4 format
 2019-10-17 19:24:11 -03:00
Rodrigo Locatti a21b88ef8f
Merge pull request #2979 from lioncash/macro 
video_core/macro_interpreter: Make definitions of most private enums/unions hidden
 2019-10-17 19:21:09 -03:00
Fernando Sahmkow c0eb1aecfd Fermi2D: Use a different formula for delimiting blit areas. 2019-10-17 18:21:01 -04:00
Rodrigo Locatti 7cf091bb20
Merge pull request #2989 from lioncash/apm 
service/apm/controller: Minor interface changes
 2019-10-17 19:20:14 -03:00
Lioncash 8d8e495248 hid/npad: Fix incorrect connection boolean value in ConnectAllDisconnectedControllers() 
We should be setting the connection state to true, otherwise we aren't
actually making the controllers connected like the function name
indicates.
 2019-10-17 18:19:47 -04:00
Lioncash d076466f26 hid/npad: Add missing break in default case 
While not an issue, it does prevent fallthrough from occurring if
anything is ever added after this case (unlikely to occur, but this
turns a trivial "should not cause issues" into a definite "won't cause
issues).
 2019-10-17 18:17:42 -04:00
Lioncash 26c84718c8 hid/npad: Replace std::for_each with ranged for loops 
Performs the same behavior, but is built into the core language itself.

No functional change.
 2019-10-17 18:16:36 -04:00
Lioncash e433e99191 hid/npad: Remove redundant non-const variant of IsControllerSupported() 
The const qualified variant can also be called in non-const contexts, so
we can remove the non-const variant to eliminate a bit of code
duplication.
 2019-10-17 18:11:41 -04:00
Lioncash a71e8066a1 hid/npad: Move function declarations 
Clearly separate these from the variable declarations to make them more
visible.
 2019-10-17 18:09:08 -04:00
Lioncash 125caf5d6e video_core/macro_interpreter: Make definitions of most private enums/unions hidden 
This allows the implementation of these types to change without
requiring a rebuild of everything that includes the macro interpreter
header.
 2019-10-17 17:55:46 -04:00
Lioncash 98c6a95079 core/core: Resolve -Wreorder warnings 
Amends the initializer lists to be ordered in the same manner that
they're declared within the class.
 2019-10-17 17:51:06 -04:00
Lioncash 6414d9e2e5 core/memory/cheat_engine: Resolve -Wreorder warnings 
Amends the initializer lists to be ordered in the same manner that
they're declared within the class.
 2019-10-17 16:21:47 -04:00
Lioncash b77430df70 apm/controller: Make SetPerformanceConfiguration() use an array of pairs over a map 
While a map is an OK way to do lookups (and usually recommended in most
cases), this is a map that lives for the entire duration of the program
and only deallocates its contents when the program terminates.

Given the total size of the map is quite small, we can simply use a
std::array of pairs and utilize std::find_if to perform the same
behavior without loss of performance.

This eliminates a static constructor and places the data into the
read-only segment.

While we're at it, we can also handle malformed inputs instead of
directly dereferencing the resulting iterator.
 2019-10-17 16:13:14 -04:00
Lioncash 141d929929 apm/controller: Make GetCurrentPerformanceMode() a const member function 
This doesn't modify instance state, so it can be made const qualified.
 2019-10-17 15:58:25 -04:00
bunnei 9fe8072c67
Merge pull request #2980 from lioncash/warn 
maxwell_3d: Silence truncation warnings
 2019-10-17 14:02:16 -04:00
Fernando Sahmkow 57a46c69f1 Fermi2D: limit blit area to only available area 
Normaly OpenGL does not care if the areas exceed the texture regions but
other backends such as Vulkan do care about the limits of this areas.
This PR crops the areas of the blit in order that they don't surpass the
limits of the textures. This should help Vulkan and faulty OpenGL
drivers
 2019-10-17 10:38:44 -04:00
Rodrigo Locatti 60c602e4e7
Merge pull request #2978 from lioncash/doxygen 
video_core/texture_cache: Amend Doxygen references
 2019-10-16 22:09:40 -03:00
Rodrigo Locatti e00b529a89
Merge pull request #2982 from lioncash/surface 
texture_cache: Avoid unnecessary surface copies within PickStrategy() and TryReconstructSurface()
 2019-10-16 19:43:32 -03:00
bunnei ef9b31783d
Merge pull request #2912 from FernandoS27/async-fixes 
General fixes to Async GPU
 2019-10-16 10:34:48 -04:00
Rodrigo Locatti 60315060b1
Merge pull request #2984 from lioncash/fallthrough2 
video_core/surface: Add missing break in PixelFormatFromTextureFormat()
 2019-10-15 23:08:34 -03:00
Lioncash cf9e13c255 video_core/surface: Add missing break in PixelFormatFromTextureFormat() 
Prevents fallthrough into the following case.
 2019-10-15 21:53:15 -04:00
Rodrigo Locatti 14f3cebcd4
Merge pull request #2981 from lioncash/copy 
gl_shader_decompiler: Minor cleanup-related changes
 2019-10-15 21:07:25 -03:00
Lioncash 6947bf8e44 vk_shader_decompiler: Resolve fallthrough within ExprDecompiler's ExprCondCode operator() 
This would previously result in NeverExecute and UnusedIndex being
treated as regular predicates.
 2019-10-15 19:40:58 -04:00
Lioncash b42a74ff2c gl_shader_decompiler: Resolve fallthrough within ExprDecompiler's ExprCondCode operator() 
This would previously result in NeverExecute and UnusedIndex being
treated as regular predicates.
 2019-10-15 19:38:55 -04:00
Lioncash a24e8bf9cf texture_cache: Avoid unnecessary surface copies within PickStrategy() and TryReconstructSurface() 
We can take these by const reference and avoid making unnecessary
copies, preventing some atomic reference count increments and
decrements.
 2019-10-15 19:31:33 -04:00
Lioncash 77b4916b33 control_flow: Silence truncation warnings 
This can be trivially fixed by making the input size a size_t.
CFGRebuildState's constructor parameter is already a std::size_t, so
this just makes the size type fully conform with it.
 2019-10-15 19:10:28 -04:00
Lioncash 4f16ce9294 gl_shader_decompiler: Make ExprDecompiler's GetResult() a const member function 
This is only ever used to read, but not write, the resulting string, so
we can enforce this by making it a const member function.
 2019-10-15 19:02:59 -04:00
Lioncash 67df3f7742 gl_shader_decompiler: Use a std::string_view with GetDeclarationWithSuffix() 
This allows the function to be completely non-allocating for inputs of
all sizes (i.e. there's no heap cost for an input to convert to a
std::string_view).
 2019-10-15 19:00:48 -04:00
Lioncash 04a1161354 gl_shader_decompiler: Fold flow_var constant into GetFlowVariable() 
This is only ever used within this function, so we can narrow it's scope
down.
 2019-10-15 18:58:36 -04:00
Lioncash 2f2ab9b5bc gl_shader_decompiler: Mark ASTDecompiler/ExprDecompiler parameters as const references where applicable 
These member functions don't actually modify the input parameter, so we
can make this explicit with the use of const.
 2019-10-15 18:57:02 -04:00
Lioncash b8a62adcf1 gl_shader_decompiler: Pass by reference to GenerateTextureArgument() 
Avoids an unnecessary atomic reference count increment and decrement.
 2019-10-15 18:29:37 -04:00
Lioncash d1d7ce74d2 gl_shader_decompiler: Use std::holds_alternative within GenerateTexture() 
This only ever queries if the type exists within the variant, but
doesn't actually do anything with the return value. We can just use
std::holds_alternative for this use case.
 2019-10-15 18:25:48 -04:00
Lioncash 67658dd6e8 shader/node: std::move Meta instance within OperationNode constructor 
Allows usages of the constructor to avoid an unnecessary copy.
 2019-10-15 18:21:59 -04:00
Lioncash 9760795bfb gl_shader_decompiler: Avoid unnecessary copies of MetaImage 
MetaImage contains a std::vector, so copying here could result in
unnecessary reallocations. Given the operation lives throughout the
entire scope, this is safe to do.
 2019-10-15 18:14:55 -04:00
Lioncash c9c75f9587 maxwell_3d: Silence truncation warnings 
A trivial warning caused by not using size_t as the argument types
instead of u32.
 2019-10-15 17:51:35 -04:00
bunnei 2299950de1
Merge pull request #2972 from lioncash/system 
{bcat, gpu, nvflinger}: Remove trivial usages of the global system accessor
 2019-10-15 17:49:12 -04:00
Lioncash b25b94400e video_core/gpu: Remove use of the global system accessor 
We can just make use of the reference member variable instead of
accessing the global system instance.
 2019-10-15 16:39:30 -04:00
Lioncash cc1d7048b5 bcat: Remove use of global system accessors 
Removes all uses of the global system accessor within the BCAT
interface.
 2019-10-15 16:39:27 -04:00
Lioncash 524eb15513 video_core/texture_cache: Amend Doxygen references 
Amends the doxygen comments so that they properly resolve. While we're
at it, we can correct some typos and fix up some of the comments'
formatting in order to make them slightly nicer to read.
 2019-10-15 15:40:00 -04:00
Lioncash d5706346d7 common/algorithm: Add description comment indicating intended algorithms 
Makes it explicit that the header is intended for iterator-based
algorithms that can ideally operate on any type.
 2019-10-15 15:25:23 -04:00
Lioncash ac4dbd3b25 common: Rename binary_find.h to algorithm.h 
Makes the header more general for other potential algorithms in the
future. While we're at it, include a missing <functional> include to
satisfy the use of std::less.
 2019-10-15 15:24:50 -04:00
Fernando Sahmkow 64e652d8cb Kernel Thread: Cleanup THREADPROCESSORID_DONT_UPDATE. 2019-10-15 11:55:30 -04:00
Fernando Sahmkow e28c7f5217 Kernel: Address Feedback 2 2019-10-15 11:55:28 -04:00
Fernando Sahmkow a3524879be Kernel: Clang Format 2019-10-15 11:55:27 -04:00
Fernando Sahmkow c32520ceb7 Kernel: Reverse global accessor removal. 2019-10-15 11:55:26 -04:00
Fernando Sahmkow 3073615dbc Kernel: Address Feedback. 2019-10-15 11:55:25 -04:00
Fernando Sahmkow 25f8606a6d Kernel Scheduler: Make sure the global scheduler shutdowns correctly. 2019-10-15 11:55:24 -04:00
Fernando Sahmkow b3c1deba49 Kernel_Thread: Eliminate most global accessors. 2019-10-15 11:55:23 -04:00
Fernando Sahmkow 0b72b34d89 KernelSVC: Assert that condition variable address is aligned to 4 bytes. 2019-10-15 11:55:22 -04:00
Fernando Sahmkow 96b1b144af Kernel: Correct Paused scheduling 2019-10-15 11:55:21 -04:00
Fernando Sahmkow 1c6a11ab14 Kernel: Corrections to Wait Objects clearing in which a thread could still be signalled after a timeout or a cancel. 2019-10-15 11:55:20 -04:00
Fernando Sahmkow 27d571c084 Kernel: Correct redundant yields to only advance time forward. 2019-10-15 11:55:20 -04:00
Fernando Sahmkow 7176857177 Kernel: Corrections to ModifyByWaitingCountAndSignalToAddressIfEqual 2019-10-15 11:55:19 -04:00
Fernando Sahmkow 44e09e5f21 Kernel: Correct Results in Condition Variables and Mutexes 2019-10-15 11:55:18 -04:00
Fernando Sahmkow 1ec1e81373 Kernel: Clang Format 2019-10-15 11:55:17 -04:00
Fernando Sahmkow e05a8c2385 Kernel: Remove global system accessor from WaitObject 2019-10-15 11:55:16 -04:00
Fernando Sahmkow 0cf26cee59 Scheduler: Implement Yield Count and Core migration on Thread Preemption. 2019-10-15 11:55:16 -04:00
Fernando Sahmkow 2d382de6fa Scheduler: Corrections to YieldAndBalanceLoad and Yield bombing protection. 2019-10-15 11:55:15 -04:00
Fernando Sahmkow b49c0dab87 Kernel: Initial implementation of thread preemption. 2019-10-15 11:55:14 -04:00
Fernando Sahmkow 103f3a2fe5 Scheduler: Add protections for Yield bombing 
In case of redundant yields, the scheduler will now idle the core for 
it's timeslice, in order to avoid continuously yielding the same thing 
over and over.
 2019-10-15 11:55:13 -04:00
Fernando Sahmkow 82218c925a Kernel: Style and Corrections 2019-10-15 11:55:12 -04:00
Fernando Sahmkow fcc6b34fff Correct PrepareReschedule 2019-10-15 11:55:12 -04:00
Fernando Sahmkow 3a94e7ea33 Comment and reorganize the scheduler 2019-10-15 11:55:11 -04:00
Fernando Sahmkow b5d1e44782 Add PrepareReschedule where required. 2019-10-15 11:55:10 -04:00
Fernando Sahmkow b8b7ebcece Correct compiling errors and addapt to the new interface. 2019-10-15 11:55:09 -04:00
Fernando Sahmkow 9031502974 Correct Supervisor Calls to work with the new scheduler, 2019-10-15 11:55:08 -04:00
Fernando Sahmkow 47c6c78c03 Redesign CPU Cores to work with the new scheduler 2019-10-15 11:55:07 -04:00
Fernando Sahmkow 57a71f899a Add interfacing to the Global Scheduler 2019-10-15 11:55:07 -04:00
Fernando Sahmkow a1ac0c6cb4 Addapt thread class to the new Scheduler 2019-10-15 11:55:06 -04:00
Fernando Sahmkow b164d8ee53 Implement a new Core Scheduler 2019-10-15 11:55:04 -04:00
bunnei cab2619aeb
Merge pull request #2965 from FernandoS27/fair-core-timing 
Core Timing: Rework Core Timing to run all cores evenly.
 2019-10-15 11:48:30 -04:00
bunnei 0378babd15
Merge pull request #2897 from DarkLordZach/oss-ext-fonts-1 
pl_u: Move open source font archives and fix NAND error
 2019-10-14 15:13:41 -04:00
bunnei c274fd588d
Merge pull request #2968 from FreddyFunk/fix-zl-zr-analog-triggers 
yuzu/configure_input_player: Fix input handling for ZL and ZR from controllers with analog triggers
 2019-10-14 13:04:49 -04:00
bunnei cd2efed922
Merge pull request #2930 from DarkLordZach/gamecard-partitions 
file_sys: Add code to access raw gamecard partitions and lazily load them
 2019-10-14 10:29:10 -04:00
Zach Hilman e0b9ee9b94 card_image: Implement system update commands in XCI 2019-10-13 14:18:45 -04:00
Zach Hilman 1911f85391 pl_u: Fix mismatched rebase size error in font encryption 2019-10-13 13:46:27 -04:00
Zach Hilman 36d829c27b pl_u: Use kernel physical memory 2019-10-13 13:46:27 -04:00
Zach Hilman b3a8a094a5 pl_u: Remove excess static qualifier 2019-10-13 13:46:27 -04:00
Zach Hilman 40284c6868 pl_u: Use OSS system archives if real archives don't exist 2019-10-13 13:46:27 -04:00
Zach Hilman 920742d418 system_archive: Synthesize shared fonts system archives 2019-10-13 13:46:10 -04:00
Zach Hilman d6d6a87bde externals: Move OSS font data to file_sys in core 2019-10-13 13:46:10 -04:00
Lioncash 574440d59f nvflinger/buffer_queue: Remove use of a global system accessor 2019-10-12 09:17:56 -04:00
Fernando Sahmkow a4ae11d63e Core_Timing: Address Remaining feedback. 2019-10-12 07:26:38 -04:00
Fernando Sahmkow 91f6333e23 Core_Timing: Fix tests. 2019-10-12 07:23:08 -04:00
Fernando Sahmkow e0650a2034 Core_Timing: Address Feedback and suppress warnings. 2019-10-11 14:44:14 -04:00
Fernando Sahmkow cfc2f30dc4 AsyncGpu: Address Feedback 2019-10-11 13:41:15 -04:00
FreddyFunk be5dc68ca3 fixed clang format & addressed feedback 2019-10-10 23:27:00 +02:00
FreddyFunk a31c6b2c4e yuzu/configure_input_player: Fix input handling for ZL and ZR from controllers with analog triggers 2019-10-10 23:12:06 +02:00
bunnei b41692b69b
Merge pull request #2910 from FearlessTobi/port-4930 
Port citra-emu/citra#4930: "Pause when in background"
 2019-10-09 21:36:51 -04:00
bunnei 2ba273e49e
Merge pull request #2928 from ReinUsesLisp/dirty-depth-bounds 
maxwell_3d: Add dirty flags for depth bounds values
 2019-10-09 15:44:30 -04:00
bunnei 6b5e50d20e
Merge pull request #2927 from ReinUsesLisp/polygon-offset-units 
gl_rasterizer: Fix polygon offset units
 2019-10-09 15:38:52 -04:00
Fernando Sahmkow f32a49d3d8 Surfaces: Implement R4G4B4A4U format. 2019-10-09 12:57:02 -04:00
Fernando Sahmkow b9ddb517b1 Surfaces: Implement ASTC 6x6 10x10 12x12 8x6 6x5 2019-10-09 12:44:31 -04:00
Fernando Sahmkow 96f2b16356 Core Timing: Correct Idle and remove lefting pragma 2019-10-09 12:30:33 -04:00
Fernando Sahmkow 65aff6930b Core Timing: General corrections and added tests. 2019-10-09 12:30:33 -04:00
Fernando Sahmkow c9a1129c95 Tests: Eliminate old Core Timing Tests 2019-10-09 12:30:32 -04:00
Fernando Sahmkow 555866f8dc Core Timing: Rework Core Timing to run all cores evenly. 2019-10-09 12:30:31 -04:00
bunnei e664c24355
Merge pull request #2921 from FreddyFunk/compiler-warnings-core 
Services::ES fix casting warnings
 2019-10-09 10:34:48 -04:00
bunnei b9c831de62
Merge pull request #2654 from DarkLordZach/lm-log-rewrite 
lm: Rewrite logger to use core reporting services
 2019-10-08 20:23:13 -04:00
Fernando Sahmkow 971870b89d
Merge pull request #2959 from ReinUsesLisp/cbuf-hsetp2 
shader/half_set_predicate: Fix HSETP2 for constant buffers
 2019-10-08 12:00:44 -04:00
ReinUsesLisp 3d0f357307
shader/half_set_predicate: Fix HSETP2 for constant buffers 
HSETP2 when used with a constant buffer parses the second operand type
as F32. This is not configurable.
 2019-10-07 14:49:47 -03:00
ReinUsesLisp 632c9e4ee3
shader/half_set_predicate: Reduce DEBUG_ASSERT to LOG_DEBUG 2019-10-07 14:48:58 -03:00
Morph 29e15601f3 hid: Implement DeactivateNpad 
Makes use of the already existing DeactivateController function.
 2019-10-07 04:44:09 -07:00
Morph c1e9ca4c08 hid: Stub SetNpadJoyAssignmentModeSingle and reorganize service commands 2019-10-07 04:43:34 -07:00
Zach Hilman 5326d3cb3a
Merge pull request #2951 from lioncash/global 
core: Remove Core::CurrentProcess()
 2019-10-06 20:47:48 -04:00
Rodrigo Locatti dcdd887df3
Merge pull request #2952 from lioncash/warning 
bcat: Silence various warnings
 2019-10-06 23:35:12 +00:00
Rodrigo Locatti 3cb4c9f08a
Merge pull request #2955 from lioncash/allocator 
alignment: Resolve allocator construction issues on debug
 2019-10-06 23:30:54 +00:00
Lioncash 57ffada746 alignment: Resolve allocator construction issues on debug 
This was related to the source allocator being passed into the
constructor potentially having a different type than allocator being
constructed.

We simply need to provide a constructor to handle this case.

This resolves issues related to the allocator causing debug builds on
MSVC to fail.
 2019-10-06 18:49:49 -04:00
Lioncash 9aafb2a277 alignment: Specify trait definitions within the allocator 
Allows containers and other data structures to consider optimizations
based off of them. We satisfy all of these requirements anyways.
 2019-10-06 18:48:05 -04:00
Fernando Sahmkow 8f407adeeb
Merge pull request #2954 from ReinUsesLisp/fix-invalidation 
gl_shader_disk_cache: Properly ignore existing cache
 2019-10-06 17:48:14 -04:00
ReinUsesLisp 58b597c5ec
gl_shader_disk_cache: Properly ignore existing cache 
Previously old entries where appended to the file even if the shader
cache was ignored at boot. Address that issue.
 2019-10-06 18:00:20 -03:00
Lioncash 0705ce0ed1 bcat/module: Silence truncation warnings 
We need to perform explicit casts here, otherwise we're implicitly
truncating a 64-bit type to a 32-bit one.
 2019-10-06 15:38:12 -04:00
Lioncash 7e77d1593f bcat: Take std::function instance by value in NullBackend's constructor 
Without this, the std::move within the constructor initializer list
won't be able to actually perform a move.
 2019-10-06 15:38:12 -04:00
Lioncash 81adf46d1d bcat: In-class initialize ProgressServiceBackend's impl member 
Allows us to remove a constructor initializer list.
 2019-10-06 15:38:12 -04:00
Lioncash 3fcd2180e4 bcat: Make ProgressServiceBackend's constructor take a std::string_view 
Given the string is appended to another, we can make it a view so a
redundant full copy of the string isn't made.
 2019-10-06 15:38:09 -04:00
Zach Hilman 81fff7aec0 qt: Fix game name format error 2019-10-06 15:07:04 -04:00
Lioncash f2fa16b609 bcat: Make ProgressServiceBackend's GetEvent() const 
This member function doesn't modify internal member state, so it can be
marked const.
 2019-10-06 14:03:18 -04:00
Lioncash 329081fcb7 boxcat: Silence an unused variable warning 
On parse errors, we can log out the explanatory string indicating what
the parsing error was, rather than just ignoring the variable and
returning an overly broad error code.
 2019-10-06 14:00:32 -04:00
Lioncash 839b38c404 core/core: Remove unused header 
This isn't used anywhere in either the cpp or header file.
 2019-10-06 13:54:27 -04:00
Lioncash f1382cf0e7 core: Remove Core::CurrentProcess() 
This only encourages the use of the global system instance (which will
be phased out long-term). Instead, we use the direct system function
call directly to remove the appealing but discouraged short-hand.
 2019-10-06 13:53:12 -04:00
Lioncash 69f16ba50e hle/service: Replace global system instance calls with instance-based ones 
Migrates the HLE service code off the use of directly accessing the
global system instance where trivially able to do so.

This removes all usages of Core::CurrentProcess from the service code,
only 8 occurrences of this function exist elsewhere. There's still quite
a bit of "System::GetInstance()" being used, however this was able to
replace a few instances.
 2019-10-06 13:42:23 -04:00
bunnei deecd7f074
Merge pull request #2942 from ReinUsesLisp/clang-warnings 
Silence miscellaneous warnings
 2019-10-05 20:41:20 -04:00
bunnei 6f511c8006
Merge pull request #2943 from DarkLordZach/azure-titlebars-v2 
ci: Add custom titlebars for mainline and patreon
 2019-10-05 19:29:35 -04:00
Lioncash f883cd4f0e video_core/control_flow: Eliminate variable shadowing warnings 2019-10-05 09:14:27 -04:00
Lioncash 25702b6256 video_core/control_flow: Eliminate pessimizing moves 
These can inhibit the ability of a compiler to perform RVO.
 2019-10-05 09:14:27 -04:00
Lioncash d82b181d44 video_core/ast: Unindent most of IsFullyDecompiled() by one level 2019-10-05 09:14:27 -04:00
Lioncash 6c41d1cd7e video_core/ast: Make ShowCurrentState() take a string_view instead of std::string 
Allows the function to be non-allocating in terms of the output string.
 2019-10-05 09:14:27 -04:00
Lioncash 3c54edae24 video_core/ast: Eliminate variable shadowing warnings 2019-10-05 09:14:26 -04:00
Lioncash 5a0a9c7449 video_core/ast: Replace std::string with a constexpr std::string_view 
Same behavior, but without the need to heap allocate
 2019-10-05 09:14:26 -04:00
Lioncash 3a20d9734f video_core/ast: Default the move constructor and assignment operator 
This is behaviorally equivalent and also fixes a bug where some members
weren't being moved over.
 2019-10-05 09:14:26 -04:00
Lioncash 43503a69bf video_core/{ast, expr}: Organize forward declaration 
Keeps them alphabetically sorted for readability.
 2019-10-05 09:14:26 -04:00
Lioncash 50ad745585 video_core/expr: Supply operator!= along with operator== 
Provides logical symmetry to the interface.
 2019-10-05 09:14:26 -04:00
Lioncash 8eb1398f8d video_core/{ast, expr}: Use std::move where applicable 
Avoids unnecessary atomic reference count increments and decrements.
 2019-10-05 09:14:23 -04:00
Lioncash 8e0c80f269 video_core/ast: Supply const accessors for data where applicable 
Provides const equivalents of data accessors for use within const
contexts.
 2019-10-05 08:22:03 -04:00
David 3728bbc22a
Merge pull request #2888 from FernandoS27/decompiler2 
Shader_IR: Implement a full control flow decompiler for the shader IR.
 2019-10-05 21:52:20 +10:00
Zach Hilman 57fe7fdec0 qt: Change titlebar formatting 2019-10-05 00:10:04 -04:00
Zach Hilman 3d4a0b94e3 common: Add additional SCM revision fields 2019-10-05 00:09:49 -04:00
ReinUsesLisp fe7f20e659 maxwell_3d: Add dirty flags for depth bounds values 
This is useful in Vulkan where we want to update depth bounds without
caring if it's enabled or disabled through vkCmdSetDepthBounds.
 2019-10-05 04:07:47 +00:00
Fernando Sahmkow 538f5880ff GL_Renderer: Remove lefting snippet. 2019-10-04 19:59:55 -04:00
Fernando Sahmkow 75395605d6 NvFlinger: Remove leftover from corrections and clang format. 2019-10-04 19:59:54 -04:00
Fernando Sahmkow 9f2719d1a4 Gl_Rasterizer: Protect CPU Memory mapping from multiple threads. 2019-10-04 19:59:53 -04:00
Fernando Sahmkow 3f104464de Core: Wait for GPU to be idle before shutting down. 2019-10-04 19:59:53 -04:00
Fernando Sahmkow 69fa2e6525 Nvdrv: Correct Event setup in Nvdrv 
Events are supposed to be cleared on quering. This fixes that issue.
 2019-10-04 19:59:52 -04:00
Fernando Sahmkow 782b7a0ca4 NVFlinger: Reverse the change that only signaled events on buffer acquire. 
This has been hardware tested and it seems that NVFlinger will still 
signal even if there are no buffers to present.
 2019-10-04 19:59:51 -04:00
Fernando Sahmkow ffc2ce89a0 Nvdrv: Do framelimiting only in the CPU Thread 2019-10-04 19:59:50 -04:00
Fernando Sahmkow 976d9ef43c NvFlinger: Don't swap buffers if a frame is missing and always trigger event in sync gpu. 2019-10-04 19:59:49 -04:00
Fernando Sahmkow 5b5e60ffec GPU_Async: Correct fences, display events and more. 
This commit uses guest fences on vSync event instead of an articial fake 
fence we had.
It also corrects to keep signaling display events while loading the game 
as the OS is suppose to send buffers to vSync during that time.
 2019-10-04 19:59:48 -04:00
Fernando Sahmkow 4e9f975935 Nvdrv: Correct Async regression and avoid signaling empty buffer vsyncs 2019-10-04 19:59:47 -04:00
ReinUsesLisp 25ee892d5e audio/audout_u: Change formatting for old clang-format versions 2019-10-04 23:51:56 +00:00
ReinUsesLisp e1afeec76d yuzu/game_list_worker: Silence warnings 2019-10-04 23:41:22 +00:00
ReinUsesLisp f297e9ff22 yuzu/game_list: Silence -Wswitch and -Wunused-variable 2019-10-04 23:41:22 +00:00
ReinUsesLisp 2b9b695fa7 yuzu/configure_service: Silence -Wswitch 2019-10-04 23:41:22 +00:00
ReinUsesLisp e03f46fb0e yuzu_tester: Remove unused variable 2019-10-04 23:41:22 +00:00
ReinUsesLisp 8d0b1a957e service/nvdrv: Silence -Wswitch 2019-10-04 23:41:22 +00:00
ReinUsesLisp 5c907f85fc service/nfp: Silence -Wunused and -Wswitch 2019-10-04 23:41:22 +00:00
ReinUsesLisp 0759df0aff service/hid: Silence -Wunused and -Wswitch 2019-10-04 23:41:22 +00:00
ReinUsesLisp ab6f8d8a1e service/am: Silence -Wreorder 2019-10-04 23:41:21 +00:00
ReinUsesLisp 634c6e24b0 service/hid: Remove unused system reference 2019-10-04 23:41:21 +00:00
ReinUsesLisp 1dbd22e695 service/friend: Remove unused field 2019-10-04 23:41:21 +00:00
ReinUsesLisp 99db7d23dd service/filesystem: Silence -Wunused-variable 2019-10-04 23:41:21 +00:00
ReinUsesLisp 8566096794 service/bcat: Silence -Wreorder and -Wunused 2019-10-04 23:41:21 +00:00
ReinUsesLisp 87e7cc2d5a service/audio: Silence -Wunused 2019-10-04 23:28:34 +00:00
ReinUsesLisp aacb473aa2 service/apm: Silence -Wunused and -Wreorder 2019-10-04 23:28:34 +00:00
ReinUsesLisp f4417eab8f common/file_util: Silence -Wswitch 2019-10-04 23:28:34 +00:00
Fernando Sahmkow ab47a660c8 Texture_Cache: Blit Deduction corrections and simplifications. 2019-10-04 18:53:47 -04:00
Fernando Sahmkow 2036504a82 TextureCache: Add the ability to deduce if two textures are depth on blit. 2019-10-04 18:53:46 -04:00
Fernando Sahmkow e6eae4b815 Shader_ir: Address feedback 2019-10-04 18:52:57 -04:00
Fernando Sahmkow 3c09d9abe6 Shader_Ir: Address Feedback and clang format. 2019-10-04 18:52:57 -04:00
Fernando Sahmkow 507a9c6a40 vk_shader_decompiler: Correct Branches inside conditionals. 2019-10-04 18:52:56 -04:00
Fernando Sahmkow 000ad558dd vk_shader_decompiler: Clean code and be const correct. 2019-10-04 18:52:55 -04:00
Fernando Sahmkow 7c756baa77 Shader_IR: clean up AST handling and add documentation. 2019-10-04 18:52:55 -04:00
Fernando Sahmkow 5ea740beb5 Shader_IR: Correct OutwardMoves for Ifs 2019-10-04 18:52:54 -04:00
Fernando Sahmkow 100a4bd988 vk_shader_compiler: Don't enclose branches with if(true) to avoid crashing AMD 2019-10-04 18:52:54 -04:00
Fernando Sahmkow 189a50bc2a gl_shader_decompiler: Refactor and address feedback. 2019-10-04 18:52:53 -04:00
Fernando Sahmkow b3c46d6948 Shader_IR: corrections and clang-format 2019-10-04 18:52:53 -04:00
Fernando Sahmkow 466cd52ad4 vk_shader_compiler: Correct SPIR-V AST Decompiling 2019-10-04 18:52:52 -04:00
Fernando Sahmkow 2e9a810423 Shader_IR: allow else derivation to be optional. 2019-10-04 18:52:52 -04:00
Fernando Sahmkow ca9901867e vk_shader_compiler: Implement the decompiler in SPIR-V 2019-10-04 18:52:51 -04:00
Fernando Sahmkow 0366c18d87 Shader_IR: mark labels as unused for partial decompile. 2019-10-04 18:52:51 -04:00
Fernando Sahmkow 47e4f6a52c Shader_Ir: Refactor Decompilation process and allow multiple decompilation modes. 2019-10-04 18:52:50 -04:00
Fernando Sahmkow 38fc995f6c gl_shader_decompiler: Implement AST decompiling 2019-10-04 18:52:50 -04:00
Fernando Sahmkow 6fdd501113 shader_ir: Declare Manager and pass it to appropiate programs. 2019-10-04 18:52:49 -04:00
Fernando Sahmkow 8be6e1c522 shader_ir: Corrections to outward movements and misc stuffs 2019-10-04 18:52:48 -04:00
Fernando Sahmkow 4fde66e609 shader_ir: Add basic goto elimination 2019-10-04 18:52:48 -04:00
Fernando Sahmkow c17953978b shader_ir: Initial Decompile Setup 2019-10-04 18:52:47 -04:00
Fernando Sahmkow 678d9ccad6 SDL: Fix missing header 
This fixes linux and mingw builds.
 2019-10-04 18:14:11 -04:00
bunnei 94c34f23d7
Merge pull request #2896 from FearlessTobi/port-4950 
Port citra-emu/citra#4950: "Add FPS to SDL title bar"
 2019-10-04 15:51:03 -04:00
bunnei 7fbaf62bac
Merge pull request #2936 from VPeruS/use-isallzeroarray 
[crypto] Use IsAllZeroArray helper function
 2019-10-04 15:44:35 -04:00
bunnei c818728513
Merge pull request #2898 from FearlessTobi/port-4004 
Port citra-emu/citra#4004: "qt_themes: add two colorful themes"
 2019-10-03 21:34:40 -04:00
David 9aac7fbc22
Merge pull request #2539 from DarkLordZach/bcat 
bcat: Implement BCAT service and connect to yuzu Boxcat server
 2019-10-03 19:06:13 +10:00
vperus 29b1d0db0f [crypto] Use IsAllZeroArray helper function 2019-10-02 19:20:45 +03:00
Zach Hilman e55d086cc9 qt: Add service dialog 2019-10-02 08:35:43 -04:00
bunnei 5e677a3178
Merge pull request #2904 from ogniK5377/better-signal-hid 
Signal styleset changes at a better time
 2019-10-01 10:58:02 -04:00
Zach Hilman 5d86c52a3a boxcat: Use updated game-asset API URL and tags 2019-10-01 09:13:31 -04:00
Zach Hilman 19c466dfb1 bcat: Add FSC accessors for BCAT data 
Ports BCAT to use FSC interface
 2019-10-01 09:13:09 -04:00
ReinUsesLisp 69c806feb6
gl_rasterizer: Fix polygon offset units 
For some reason hardware divides polygon offset units by two. This is
visible since drivers multiply the application requested polygon offset
by two.
 2019-10-01 02:00:23 -03:00
Zach Hilman bcf1eafb8b boxcat: Implement events global field 2019-09-30 17:28:23 -04:00
Zach Hilman 2d410ddf4d bcat: Implement DeliveryCacheProgressImpl structure 
Huge thanks to lioncash for re-ing this for me.
 2019-09-30 17:27:23 -04:00
Zach Hilman 92b70a3bf9 boxcat: Use Etag header names for file digest 2019-09-30 17:27:23 -04:00
Zach Hilman e8183f9ef0 boxcat: Add downloading and client for launch parameter data 2019-09-30 17:27:23 -04:00
Zach Hilman b8ce87103d bcat: Add backend function for BCAT Indirect (launch parameter) 
Returns the data that should be returned by PopLaunchParameter kind=ApplicationSpecific.
 2019-09-30 17:27:23 -04:00
Zach Hilman ea17b294ea bcat: Expose CreateBackendFromSettings helper function 2019-09-30 17:27:23 -04:00
Zach Hilman fe8c7e66e2 am: Unstub PopLaunchParameter and add bcat connection for app-specific data 
Previously we were simply returning the account-preselect structure all times but if passed with a different mode the game expects application-specific data. This also adds a hook for BCAT into this allowing us to send the launch parameter through bcat,
 2019-09-30 17:27:23 -04:00
Zach Hilman 02f8f1bb3e configure_service: Allow Qt to open external links 2019-09-30 17:26:10 -04:00
Zach Hilman f0551aef09 yuzu: Add UI tab to configure BCAT services 
Also displays current events if boxcat is selected.
 2019-09-30 17:26:10 -04:00
Zach Hilman 102db206e0 bcat: Implement cmd 90201 ClearDeliveryCacheStorage 
Takes a title ID and simply deletes all the data for that title ID's bcat. Invokes the respective backend command.
 2019-09-30 17:23:26 -04:00
Zach Hilman 1bde5a3c6a bcat: Implement cmd 30100 SetPassphrase 
Takes a title ID and passphrase (0x40 byte string) and passes it to the backend.
 2019-09-30 17:23:26 -04:00
Zach Hilman 86773a7f08 bcat: Implement cmd RequestSyncDeliveryCache and variant 
Variant also supports only updating a single directory. These just both invoke backend commands.
 2019-09-30 17:23:26 -04:00
Zach Hilman cb7c96b96a bcat: Implement IDeliveryCacheProgressService commands 
Used to query completion status and events for the current delivery task.
 2019-09-30 17:23:26 -04:00
Zach Hilman f352ad5c93 bcat: Implement IDeliveryCacheFileService commands 
Used to read the contents of files and access their metadata.
 2019-09-30 17:23:26 -04:00
Zach Hilman 8812018c1d bcat: Implement IDeliveryCacheDirectoryService commands 
Used to list and get directories at the root level.
 2019-09-30 17:23:26 -04:00
Zach Hilman 862131ead9 bcat: Implement IDeliveryCacheStorageService commands 
Used to create subclasses to manage files and directories and to list directories.
 2019-09-30 17:23:26 -04:00
Zach Hilman 78d146f907 bcat: Add commands to create IDeliveryCacheStorageService 
Used to access contents of download.
 2019-09-30 17:23:26 -04:00
Zach Hilman 68658a8385 module: Create BCAT backend based upon Settings value on construction 2019-09-30 17:23:26 -04:00